111119 2013-02-28 15:08:00 -0800 DFG CFA should not do liveness pruning 2013-02-28 17:34:09 -0800 1 1 1 Unclassified WebKit JavaScriptCore 528+ (Nightly build) All All RESOLVED FIXED P2 Normal --- 109389 1 fpizlo fpizlo barraclough ggaren mario mark.lam mhahnenberg oliver sam oldest_to_newest 844519 0 fpizlo 2013-02-28 15:08:00 -0800 It adds complexity and probably buys nothing. Moreover, I'm transitioning to having liveness only available at the bitter end of compilation, so this will stop working after https://bugs.webkit.org/show_bug.cgi?id=109389 anyway. 844520 1 190818 fpizlo 2013-02-28 15:09:47 -0800 Created attachment 190818 the patch 844522 2 190818 mhahnenberg 2013-02-28 15:15:01 -0800 Comment on attachment 190818 the patch r=me 844599 3 190834 fpizlo 2013-02-28 16:21:33 -0800 Created attachment 190834 the patch Fix a bug. 844612 4 190834 mhahnenberg 2013-02-28 16:36:13 -0800 Comment on attachment 190834 the patch r=me 844656 5 fpizlo 2013-02-28 17:34:09 -0800 Landed in http://trac.webkit.org/changeset/144401 190818 2013-02-28 15:09:47 -0800 2013-02-28 16:21:33 -0800 the patch blah.patch text/plain 2642 fpizlo SW5kZXg6IFNvdXJjZS9KYXZhU2NyaXB0Q29yZS9DaGFuZ2VMb2cKPT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gU291 cmNlL0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwkocmV2aXNpb24gMTQ0Mzc3KQorKysgU291cmNl L0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDE4IEBA CisyMDEzLTAyLTI4ICBGaWxpcCBQaXpsbyAgPGZwaXpsb0BhcHBsZS5jb20+CisKKyAgICAgICAg REZHIENGQSBzaG91bGQgbm90IGRvIGxpdmVuZXNzIHBydW5pbmcKKyAgICAgICAgaHR0cHM6Ly9i dWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTExMTExOQorCisgICAgICAgIFJldmlld2Vk IGJ5IE5PQk9EWSAoT09QUyEpLgorICAgICAgICAKKyAgICAgICAgSXQgYWRkcyBjb21wbGV4aXR5 IGFuZCBwcm9iYWJseSBidXlzIG5vdGhpbmcuICBNb3Jlb3ZlciwgSSdtIHRyYW5zaXRpb25pbmcg dG8gaGF2aW5nCisgICAgICAgIGxpdmVuZXNzIG9ubHkgYXZhaWxhYmxlIGF0IHRoZSBiaXR0ZXIg ZW5kIG9mIGNvbXBpbGF0aW9uLCBzbyB0aGlzIHdpbGwgc3RvcCB3b3JraW5nCisgICAgICAgIGFm dGVyIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xMDkzODkgYW55d2F5 LgorCisgICAgICAgICogZGZnL0RGR0Fic3RyYWN0U3RhdGUuY3BwOgorICAgICAgICAoSlNDOjpE Rkc6OkFic3RyYWN0U3RhdGU6OmluaXRpYWxpemUpOgorICAgICAgICAoSlNDOjpERkc6OkFic3Ry YWN0U3RhdGU6Om1lcmdlU3RhdGVBdFRhaWwpOgorCiAyMDEzLTAyLTI4ICBGaWxpcCBQaXpsbyAg PGZwaXpsb0BhcHBsZS5jb20+CiAKICAgICAgICAgREZHIFBoYW50b20gbm9kZSBzaG91bGQgYmUg aG9uZXN0IGFib3V0IHRoZSBmYWN0IHRoYXQgaXQgY2FuIGV4aXQKSW5kZXg6IFNvdXJjZS9KYXZh U2NyaXB0Q29yZS9kZmcvREZHQWJzdHJhY3RTdGF0ZS5jcHAKPT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gU291cmNl L0phdmFTY3JpcHRDb3JlL2RmZy9ERkdBYnN0cmFjdFN0YXRlLmNwcAkocmV2aXNpb24gMTQ0Mzcx KQorKysgU291cmNlL0phdmFTY3JpcHRDb3JlL2RmZy9ERkdBYnN0cmFjdFN0YXRlLmNwcAkod29y a2luZyBjb3B5KQpAQCAtODksMTMgKzg5LDYgQEAgdm9pZCBBYnN0cmFjdFN0YXRlOjppbml0aWFs aXplKEdyYXBoJiBncgogICAgIGZvciAoc2l6ZV90IGkgPSAwOyBpIDwgcm9vdC0+dmFsdWVzQXRI ZWFkLm51bWJlck9mQXJndW1lbnRzKCk7ICsraSkgewogICAgICAgICBOb2RlKiBub2RlID0gcm9v dC0+dmFyaWFibGVzQXRIZWFkLmFyZ3VtZW50KGkpOwogICAgICAgICBBU1NFUlQobm9kZS0+b3Ao KSA9PSBTZXRBcmd1bWVudCk7Ci0gICAgICAgIGlmICghbm9kZS0+c2hvdWxkR2VuZXJhdGUoKSkg ewotICAgICAgICAgICAgLy8gVGhlIGFyZ3VtZW50IGlzIGRlYWQuIFdlIGRvbid0IGRvIGFueSBj aGVja3MgZm9yIHN1Y2ggYXJndW1lbnRzLCBhbmQgc28KLSAgICAgICAgICAgIC8vIGZvciB0aGUg cHVycG9zZSBvZiB0aGUgYW5hbHlzaXMsIHRoZXkgY29udGFpbiBubyB2YWx1ZS4KLSAgICAgICAg ICAgIHJvb3QtPnZhbHVlc0F0SGVhZC5hcmd1bWVudChpKS5jbGVhcigpOwotICAgICAgICAgICAg Y29udGludWU7Ci0gICAgICAgIH0KLSAgICAgICAgCiAgICAgICAgIGlmICghbm9kZS0+dmFyaWFi bGVBY2Nlc3NEYXRhKCktPnNob3VsZFVuYm94SWZQb3NzaWJsZSgpKSB7CiAgICAgICAgICAgICBy b290LT52YWx1ZXNBdEhlYWQuYXJndW1lbnQoaSkubWFrZVRvcCgpOwogICAgICAgICAgICAgY29u dGludWU7CkBAIC0xNjE2LDIwICsxNjA5LDYgQEAgaW5saW5lIGJvb2wgQWJzdHJhY3RTdGF0ZTo6 bWVyZ2VTdGF0ZUF0VAogICAgICAgICBkYXRhTG9nRigiIGZyb20gbGFzdCBhY2Nlc3MgZHVlIHRv IGNhcHR1cmVkIHZhcmlhYmxlLlxuIik7CiAjZW5kaWYKICAgICB9IGVsc2UgewotICAgICAgICBp ZiAoIW5vZGUtPnNob3VsZEdlbmVyYXRlKCkpIHsKLSAgICAgICAgICAgIC8vIElmIHRoZSBub2Rl IGF0IHRhaWwgaXMgYSBHZXRMb2NhbCB0aGF0IGlzIGRlYWQsIHRoZW4gc2tpcCBpdCB0byBnZXQg dG8gdGhlIFBoaS4KLSAgICAgICAgICAgIC8vIFRoZSBQaGkgbWF5IGJlIGxpdmUuCi0gICAgICAg ICAgICBpZiAobm9kZS0+b3AoKSAhPSBHZXRMb2NhbCkKLSAgICAgICAgICAgICAgICByZXR1cm4g ZmFsc2U7Ci0gICAgICAgICAgICAKLSAgICAgICAgICAgIG5vZGUgPSBub2RlLT5jaGlsZDEoKS5u b2RlKCk7Ci0gICAgICAgICAgICBBU1NFUlQobm9kZS0+b3AoKSA9PSBQaGkpOwotICAgICAgICAg ICAgaWYgKCFub2RlLT5zaG91bGRHZW5lcmF0ZSgpKQotICAgICAgICAgICAgICAgIHJldHVybiBm YWxzZTsKLSAgICAgICAgfQotICAgICAgICAKLSAgICAgICAgQVNTRVJUKG5vZGUtPnNob3VsZEdl bmVyYXRlKCkpOwotCiAjaWYgREZHX0VOQUJMRShERUJVR19QUk9QQUdBVElPTl9WRVJCT1NFKQog ICAgICAgICBkYXRhTG9nRigiICAgICAgICAgIEl0J3MgbGl2ZSwgbm9kZSBAJXUuXG4iLCBub2Rl LT5pbmRleCgpKTsKICNlbmRpZgo= 190834 2013-02-28 16:21:33 -0800 2013-02-28 16:36:12 -0800 the patch blah.patch text/plain 3507 fpizlo SW5kZXg6IFNvdXJjZS9KYXZhU2NyaXB0Q29yZS9DaGFuZ2VMb2cKPT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gU291 cmNlL0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwkocmV2aXNpb24gMTQ0Mzg3KQorKysgU291cmNl L0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDE4IEBA CisyMDEzLTAyLTI4ICBGaWxpcCBQaXpsbyAgPGZwaXpsb0BhcHBsZS5jb20+CisKKyAgICAgICAg REZHIENGQSBzaG91bGQgbm90IGRvIGxpdmVuZXNzIHBydW5pbmcKKyAgICAgICAgaHR0cHM6Ly9i dWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTExMTExOQorCisgICAgICAgIFJldmlld2Vk IGJ5IE1hcmsgSGFobmVuYmVyZy4KKyAgICAgICAgCisgICAgICAgIEl0IGFkZHMgY29tcGxleGl0 eSBhbmQgcHJvYmFibHkgYnV5cyBub3RoaW5nLiAgTW9yZW92ZXIsIEknbSB0cmFuc2l0aW9uaW5n IHRvIGhhdmluZworICAgICAgICBsaXZlbmVzcyBvbmx5IGF2YWlsYWJsZSBhdCB0aGUgYml0dGVy IGVuZCBvZiBjb21waWxhdGlvbiwgc28gdGhpcyB3aWxsIHN0b3Agd29ya2luZworICAgICAgICBh ZnRlciBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTA5Mzg5IGFueXdh eS4KKworICAgICAgICAqIGRmZy9ERkdBYnN0cmFjdFN0YXRlLmNwcDoKKyAgICAgICAgKEpTQzo6 REZHOjpBYnN0cmFjdFN0YXRlOjppbml0aWFsaXplKToKKyAgICAgICAgKEpTQzo6REZHOjpBYnN0 cmFjdFN0YXRlOjptZXJnZVN0YXRlQXRUYWlsKToKKwogMjAxMy0wMi0yOCAgRmlsaXAgUGl6bG8g IDxmcGl6bG9AYXBwbGUuY29tPgogCiAgICAgICAgIERvbid0IHRyeSB0byBlbWl0IHByb2ZpbGlu ZyBpZiB5b3UgZG9uJ3QgaGF2ZSB0aGUgREZHIEpJVC4KSW5kZXg6IFNvdXJjZS9KYXZhU2NyaXB0 Q29yZS9kZmcvREZHQWJzdHJhY3RTdGF0ZS5jcHAKPT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gU291cmNlL0phdmFT Y3JpcHRDb3JlL2RmZy9ERkdBYnN0cmFjdFN0YXRlLmNwcAkocmV2aXNpb24gMTQ0MzcxKQorKysg U291cmNlL0phdmFTY3JpcHRDb3JlL2RmZy9ERkdBYnN0cmFjdFN0YXRlLmNwcAkod29ya2luZyBj b3B5KQpAQCAtODksMTMgKzg5LDYgQEAgdm9pZCBBYnN0cmFjdFN0YXRlOjppbml0aWFsaXplKEdy YXBoJiBncgogICAgIGZvciAoc2l6ZV90IGkgPSAwOyBpIDwgcm9vdC0+dmFsdWVzQXRIZWFkLm51 bWJlck9mQXJndW1lbnRzKCk7ICsraSkgewogICAgICAgICBOb2RlKiBub2RlID0gcm9vdC0+dmFy aWFibGVzQXRIZWFkLmFyZ3VtZW50KGkpOwogICAgICAgICBBU1NFUlQobm9kZS0+b3AoKSA9PSBT ZXRBcmd1bWVudCk7Ci0gICAgICAgIGlmICghbm9kZS0+c2hvdWxkR2VuZXJhdGUoKSkgewotICAg ICAgICAgICAgLy8gVGhlIGFyZ3VtZW50IGlzIGRlYWQuIFdlIGRvbid0IGRvIGFueSBjaGVja3Mg Zm9yIHN1Y2ggYXJndW1lbnRzLCBhbmQgc28KLSAgICAgICAgICAgIC8vIGZvciB0aGUgcHVycG9z ZSBvZiB0aGUgYW5hbHlzaXMsIHRoZXkgY29udGFpbiBubyB2YWx1ZS4KLSAgICAgICAgICAgIHJv b3QtPnZhbHVlc0F0SGVhZC5hcmd1bWVudChpKS5jbGVhcigpOwotICAgICAgICAgICAgY29udGlu dWU7Ci0gICAgICAgIH0KLSAgICAgICAgCiAgICAgICAgIGlmICghbm9kZS0+dmFyaWFibGVBY2Nl c3NEYXRhKCktPnNob3VsZFVuYm94SWZQb3NzaWJsZSgpKSB7CiAgICAgICAgICAgICByb290LT52 YWx1ZXNBdEhlYWQuYXJndW1lbnQoaSkubWFrZVRvcCgpOwogICAgICAgICAgICAgY29udGludWU7 CkBAIC0xNjE2LDIwICsxNjA5LDYgQEAgaW5saW5lIGJvb2wgQWJzdHJhY3RTdGF0ZTo6bWVyZ2VT dGF0ZUF0VAogICAgICAgICBkYXRhTG9nRigiIGZyb20gbGFzdCBhY2Nlc3MgZHVlIHRvIGNhcHR1 cmVkIHZhcmlhYmxlLlxuIik7CiAjZW5kaWYKICAgICB9IGVsc2UgewotICAgICAgICBpZiAoIW5v ZGUtPnNob3VsZEdlbmVyYXRlKCkpIHsKLSAgICAgICAgICAgIC8vIElmIHRoZSBub2RlIGF0IHRh aWwgaXMgYSBHZXRMb2NhbCB0aGF0IGlzIGRlYWQsIHRoZW4gc2tpcCBpdCB0byBnZXQgdG8gdGhl IFBoaS4KLSAgICAgICAgICAgIC8vIFRoZSBQaGkgbWF5IGJlIGxpdmUuCi0gICAgICAgICAgICBp ZiAobm9kZS0+b3AoKSAhPSBHZXRMb2NhbCkKLSAgICAgICAgICAgICAgICByZXR1cm4gZmFsc2U7 Ci0gICAgICAgICAgICAKLSAgICAgICAgICAgIG5vZGUgPSBub2RlLT5jaGlsZDEoKS5ub2RlKCk7 Ci0gICAgICAgICAgICBBU1NFUlQobm9kZS0+b3AoKSA9PSBQaGkpOwotICAgICAgICAgICAgaWYg KCFub2RlLT5zaG91bGRHZW5lcmF0ZSgpKQotICAgICAgICAgICAgICAgIHJldHVybiBmYWxzZTsK LSAgICAgICAgfQotICAgICAgICAKLSAgICAgICAgQVNTRVJUKG5vZGUtPnNob3VsZEdlbmVyYXRl KCkpOwotCiAjaWYgREZHX0VOQUJMRShERUJVR19QUk9QQUdBVElPTl9WRVJCT1NFKQogICAgICAg ICBkYXRhTG9nRigiICAgICAgICAgIEl0J3MgbGl2ZSwgbm9kZSBAJXUuXG4iLCBub2RlLT5pbmRl eCgpKTsKICNlbmRpZgpAQCAtMTY0OSw2ICsxNjI4LDE4IEBAIGlubGluZSBib29sIEFic3RyYWN0 U3RhdGU6Om1lcmdlU3RhdGVBdFQKICAgICAgICAgICAgIGJyZWFrOwogICAgICAgICAgICAgCiAg ICAgICAgIGNhc2UgR2V0TG9jYWw6CisgICAgICAgICAgICAvLyBJZiB0aGUgR2V0TG9jYWwgaXMg ZGVhZCwgdGhlbiB3ZSB0cmFuc2ZlciBmcm9tIGhlYWQgdG8gdGFpbC4KKyAgICAgICAgICAgIC8v IEZJWE1FOiBXZSBjYW4gZ2V0IHJpZCBvZiB0aGlzIGNhc2UgYWZ0ZXIgaHR0cHM6Ly9idWdzLndl YmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTEwOTM4OQorICAgICAgICAgICAgaWYgKCFub2RlLT5z aG91bGRHZW5lcmF0ZSgpKSB7CisgICAgICAgICAgICAgICAgLy8gVGhlIGJsb2NrIHRyYW5zZmVy cyB0aGUgdmFsdWUgZnJvbSBoZWFkIHRvIHRhaWwuCisgICAgICAgICAgICAgICAgc291cmNlID0g aW5WYXJpYWJsZTsKKyNpZiBERkdfRU5BQkxFKERFQlVHX1BST1BBR0FUSU9OX1ZFUkJPU0UpCisg ICAgICAgICAgICAgICAgZGF0YUxvZ0YoIiAgICAgICAgICBUcmFuc2ZlcmluZyAiKTsKKyAgICAg ICAgICAgICAgICBzb3VyY2UuZHVtcChXVEY6OmRhdGFGaWxlKCkpOworICAgICAgICAgICAgICAg IGRhdGFMb2dGKCIgZnJvbSBoZWFkIHRvIHRhaWwgKGRlYWQgR2V0TG9jYWwgY2FzZSkuXG4iKTsK KyNlbmRpZgorICAgICAgICAgICAgICAgIGJyZWFrOworICAgICAgICAgICAgfQogICAgICAgICAg ICAgLy8gVGhlIGJsb2NrIHJlZmluZXMgdGhlIHZhbHVlIHdpdGggYWRkaXRpb25hbCBzcGVjdWxh dGlvbnMuCiAgICAgICAgICAgICBzb3VyY2UgPSBmb3JOb2RlKG5vZGUpOwogI2lmIERGR19FTkFC TEUoREVCVUdfUFJPUEFHQVRJT05fVkVSQk9TRSkK