110937 2013-02-26 20:25:57 -0800 Threaded HTML parser hits ASSERTION FAILED: this == frameLoader()->activeDocumentLoader() 2014-01-18 10:02:41 -0800 1 1 1 Unclassified WebKit WebCore Misc. 528+ (Nightly build) Unspecified Unspecified RESOLVED INVALID P2 Normal --- 111136 106127 110907 1 abarth webkit-unassigned andersca darin eric esprehn+autocc japhet ojan.autocc syoichi webkit.review.bot oldest_to_newest 842641 0 abarth 2013-02-26 20:25:57 -0800 This happens on a bunch of tests. For example, fast/text/reset-drag-on-mouse-down.html crash log for DumpRenderTree (pid 26853): STDOUT: <empty> STDERR: ASSERTION FAILED: this == frameLoader()->activeDocumentLoader() STDERR: ../../third_party/WebKit/Source/WebCore/loader/DocumentLoader.cpp(434) : void WebCore::DocumentLoader::checkLoadComplete() STDERR: 1 0x7fd34ab53045 STDERR: 2 0x7fd349dc837b STDERR: 3 0x7fd34aec3a9c STDERR: 4 0x7fd34aeb1150 STDERR: 5 0x7fd34aeb0910 STDERR: 6 0x7fd34aea4048 STDERR: 7 0x7fd34aea3f81 STDERR: 8 0x7fd349a17708 STDERR: 9 0x7fd349a174b8 STDERR: 10 0x7fd34eae6f62 STDERR: 11 0x7fd34eae6e8b STDERR: 12 0x7fd34eae6cc5 STDERR: 13 0x7fd34e720521 STDERR: 14 0x7fd34e768e47 MessageLoop::RunTask(base::PendingTask const&) STDERR: 15 0x7fd34e768f5e MessageLoop::DeferOrRunPendingTask(base::PendingTask const&) STDERR: 16 0x7fd34e7697ef MessageLoop::DoWork() STDERR: 17 0x7fd34e704c9e base::MessagePumpGlib::RunWithDispatcher(base::MessagePump::Delegate*, base::MessagePumpDispatcher*) STDERR: 18 0x7fd34e705120 base::MessagePumpGlib::Run(base::MessagePump::Delegate*) STDERR: 19 0x7fd34e768a3b MessageLoop::RunInternal() STDERR: 20 0x7fd34e7688f6 MessageLoop::RunHandler() STDERR: 21 0x7fd34e7a0fe6 base::RunLoop::Run() STDERR: 22 0x7fd34e768228 MessageLoop::Run() STDERR: 23 0x4ace8d STDERR: 24 0x472c26 STDERR: 25 0x46cd20 STDERR: 26 0x46593c STDERR: 27 0x4664ec STDERR: 28 0x7fd343232c4d __libc_start_main STDERR: 29 0x463c99 STDERR: Received signal 11 SEGV_MAPERR 0000bbadbeef STDERR: [0x7fd34e72add0] base::debug::StackTrace::StackTrace() STDERR: [0x7fd34e72a67a] base::debug::(anonymous namespace)::StackDumpSignalHandler() STDERR: [0x7fd3435a68f0] <unknown> STDERR: [0x7fd34ab5304f] WebCore::DocumentLoader::checkLoadComplete() STDERR: [0x7fd349dc837b] WebCore::Document::decrementActiveParserCount() STDERR: [0x7fd34aec3a9c] WebCore::ActiveParserSession::~ActiveParserSession() STDERR: [0x7fd34aeb1150] WebCore::HTMLDocumentParser::processParsedChunkFromBackgroundParser() STDERR: [0x7fd34aeb0910] WebCore::HTMLDocumentParser::didReceiveParsedChunkFromBackgroundParser() STDERR: [0x7fd34aea4048] WTF::FunctionWrapper<>::operator()() STDERR: [0x7fd34aea3f81] WTF::BoundFunctionImpl<>::operator()() STDERR: [0x7fd349a17708] WTF::Function<>::operator()() STDERR: [0x7fd349a174b8] WTF::callFunctionObject() STDERR: [0x7fd34eae6f62] base::internal::RunnableAdapter<>::Run() STDERR: [0x7fd34eae6e8b] base::internal::InvokeHelper<>::MakeItSo() STDERR: [0x7fd34eae6cc5] base::internal::Invoker<>::Run() STDERR: [0x7fd34e720521] base::Callback<>::Run() STDERR: [0x7fd34e768e47] MessageLoop::RunTask() STDERR: [0x7fd34e768f5e] MessageLoop::DeferOrRunPendingTask() STDERR: [0x7fd34e7697ef] MessageLoop::DoWork() STDERR: [0x7fd34e704c9e] base::MessagePumpGlib::RunWithDispatcher() STDERR: [0x7fd34e705120] base::MessagePumpGlib::Run() STDERR: [0x7fd34e768a3b] MessageLoop::RunInternal() STDERR: [0x7fd34e7688f6] MessageLoop::RunHandler() STDERR: [0x7fd34e7a0fe6] base::RunLoop::Run() STDERR: [0x7fd34e768228] MessageLoop::Run() STDERR: [0x0000004ace8d] webkit_support::RunMessageLoop() STDERR: [0x000000472c26] TestShell::waitTestFinished() STDERR: [0x00000046cd20] TestShell::runFileTest() STDERR: [0x00000046593c] runTest() STDERR: [0x0000004664ec] main STDERR: [0x7fd343232c4d] __libc_start_main STDERR: [0x000000463c99] <unknown> STDERR: r8: 00007fd33d1e47e0 r9: 00007fd34b6689fe r10: 00000000004002d0 r11: 0000000000000000 STDERR: r12: 0000000000000050 r13: 00007fffdebeb5a0 r14: 0000000000000000 r15: 0000000000000000 STDERR: di: 0000000000000000 si: 00000000efcdab90 bp: 00007fffdebe9c60 bx: 00000f40972cd458 STDERR: dx: 00007fd343592e00 ax: 00000000bbadbeef cx: 00007fd3432ecacd sp: 00007fffdebe9c50 STDERR: ip: 00007fd34ab5304f efl: 0000000000010246 cgf: 0000000000000033 erf: 0000000000000006 STDERR: trp: 000000000000000e msk: 0000000000000000 cr2: 00000000bbadbeef 842649 1 abarth 2013-02-26 20:35:14 -0800 I silenced the ASSERT in http://trac.webkit.org/changeset/144139, but we should dig into this issue a bit more to understand whether the ASSERT should be re-enabled. 842679 2 eric 2013-02-26 21:50:44 -0800 Yeah, this sounds very useful. We can look tomorrow. 843165 3 darin 2013-02-27 09:32:00 -0800 Might be better to put the assert back in, inside an #if, so we have a chance to catch regressions unrelated to the threaded HTML parser work while we continue to investigate the new issue. On platforms where the threaded HTML parser is turned off at compile time we could still get some value from the assertion. Maybe an unimportant point if this is resolved quickly enough. 843242 4 190553 abarth 2013-02-27 10:45:52 -0800 Created attachment 190553 Patch 843245 5 abarth 2013-02-27 10:46:19 -0800 > Might be better to put the assert back in, inside an #if, so we have a chance to catch regressions unrelated to the threaded HTML parser work while we continue to investigate the new issue. Good idea. 843310 6 190553 darin 2013-02-27 11:34:08 -0800 Comment on attachment 190553 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=190553&action=review > Source/WebCore/loader/DocumentLoader.cpp:434 > +#if ENABLE(THREADED_HTML_PARSER) #if !ENABLE 843386 7 190577 abarth 2013-02-27 12:37:41 -0800 Created attachment 190577 Patch for landing 843399 8 190577 eric 2013-02-27 12:50:55 -0800 Comment on attachment 190577 Patch for landing Didn't we turn off the threaded parser by default again? If so, can't we just add back the ASSERT and be sure to fix it before turning it back on? In any case, this is fine too. 843400 9 190577 eric 2013-02-27 12:51:48 -0800 Comment on attachment 190577 Patch for landing Oh. This is likely that we're calling checkLoadComplete() too often. I guess we just need to check in decrementActiveParserCount() before calling. 843439 10 190577 webkit.review.bot 2013-02-27 13:25:00 -0800 Comment on attachment 190577 Patch for landing Clearing flags on attachment: 190577 Committed r144232: <http://trac.webkit.org/changeset/144232> 843440 11 webkit.review.bot 2013-02-27 13:25:03 -0800 All reviewed patches have been landed. Closing bug. 843453 12 abarth 2013-02-27 13:39:43 -0800 Re-opening to actually fix the bug. 844288 13 eric 2013-02-28 11:40:16 -0800 This appears to have been fixed by bug 110951. 844299 14 190771 eric 2013-02-28 11:44:27 -0800 Created attachment 190771 Patch 844301 15 eric 2013-02-28 11:46:24 -0800 I ran all the layout tests with --chromium --debug and saw no ASSERTs. 844321 16 190771 abarth 2013-02-28 11:59:35 -0800 Comment on attachment 190771 Patch Great! 844322 17 abarth 2013-02-28 12:00:03 -0800 (In reply to comment #15) > I ran all the layout tests with --chromium --debug and saw no ASSERTs. Did you check the mentioned test on apple-mac WebKit1? 844331 18 190771 eric 2013-02-28 12:07:25 -0800 Comment on attachment 190771 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=190771&action=review > Source/WebCore/loader/DocumentLoader.cpp:290 > if (document() && document()->hasActiveParser()) The magic is that document() returns null in the case we were trying to avoid: if (m_frame && m_frame->loader()->documentLoader() == this) return m_frame->document(); 844332 19 190771 eric 2013-02-28 12:08:04 -0800 Comment on attachment 190771 Patch Sorry, missed your question. 844441 20 eric 2013-02-28 13:47:30 -0800 run-webkit-tests --debug http/tests/security/feed-urls-from-remote.html still passes with the #ifdef removed on Mac WK1. 844445 21 190802 eric 2013-02-28 13:50:38 -0800 Created attachment 190802 Patch for landing 844482 22 190802 webkit.review.bot 2013-02-28 14:35:30 -0800 Comment on attachment 190802 Patch for landing Clearing flags on attachment: 190802 Committed r144370: <http://trac.webkit.org/changeset/144370> 844483 23 webkit.review.bot 2013-02-28 14:35:34 -0800 All reviewed patches have been landed. Closing bug. 844775 24 webkit.review.bot 2013-02-28 20:53:29 -0800 Re-opened since this is blocked by bug 111136 190553 2013-02-27 10:45:52 -0800 2013-02-27 12:37:38 -0800 Patch bug-110937-20130227104206.patch text/plain 1598 abarth U3VidmVyc2lvbiBSZXZpc2lvbjogMTQ0MjA5CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggNWE4ZTZiNzgyNjRkMGY2 NWQ4YmM1MDVkYjRhNTY0MjJhMTU2NmU4Ni4uMDBiMjZlMTgyOTgxMGRlN2FlODRmZGQ5NTZjNzUz ODdhNGFjNzRhMSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE3IEBACisyMDEzLTAyLTI3ICBBZGFt IEJhcnRoICA8YWJhcnRoQHdlYmtpdC5vcmc+CisKKyAgICAgICAgVGhyZWFkZWQgSFRNTCBwYXJz ZXIgaGl0cyBBU1NFUlRJT04gRkFJTEVEOiB0aGlzID09IGZyYW1lTG9hZGVyKCktPmFjdGl2ZURv Y3VtZW50TG9hZGVyKCkKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcu Y2dpP2lkPTExMDkzNworCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisg ICAgICAgIFRoaXMgcGF0Y2ggcmVzdG9yZXMgdGhlIEFTU0VSVCBiZWhpbmQgYW4gaWZkZWYgc28g dGhhdCB3ZSBjYW4gY29udGludWUKKyAgICAgICAgdG8gZ2V0IGNvbnZlcmFnZSBmcm9tIHRoZSBB U1NFUlQgd2hpbGUgd2UgaW52ZXN0aWdhdGUgd2h5IGl0IGlzCisgICAgICAgIHRyaWdnZXJpbmcg aW4gdGhlIHRocmVhZGVkIHBhcnNlci4KKworICAgICAgICAqIGxvYWRlci9Eb2N1bWVudExvYWRl ci5jcHA6CisgICAgICAgIChXZWJDb3JlOjpEb2N1bWVudExvYWRlcjo6Y2hlY2tMb2FkQ29tcGxl dGUpOgorCiAyMDEzLTAyLTI3ICBBbGxhbiBTYW5kZmVsZCBKZW5zZW4gIDxhbGxhbi5qZW5zZW5A ZGlnaWEuY29tPgogCiAgICAgICAgIFN3aXRjaCBRdFdlYktpdCB0byBHU3RyZWFtZXIgMS4wLgpk aWZmIC0tZ2l0IGEvU291cmNlL1dlYkNvcmUvbG9hZGVyL0RvY3VtZW50TG9hZGVyLmNwcCBiL1Nv dXJjZS9XZWJDb3JlL2xvYWRlci9Eb2N1bWVudExvYWRlci5jcHAKaW5kZXggN2E5NGExOGE1ZjM2 NjdhMmIzMWFiM2ZiZDE2ODVlYzVkNzA2YTI4OS4uZTJhYzEwYzk2Njg4ZmI3NzI2ZDJjOTEzOGZl YjcyNTg5YmEwNzQwYSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvbG9hZGVyL0RvY3VtZW50 TG9hZGVyLmNwcAorKysgYi9Tb3VyY2UvV2ViQ29yZS9sb2FkZXIvRG9jdW1lbnRMb2FkZXIuY3Bw CkBAIC00MzEsNiArNDMxLDExIEBAIHZvaWQgRG9jdW1lbnRMb2FkZXI6OmNoZWNrTG9hZENvbXBs ZXRlKCkKIHsKICAgICBpZiAoIW1fZnJhbWUgfHwgaXNMb2FkaW5nKCkpCiAgICAgICAgIHJldHVy bjsKKyNpZiBFTkFCTEUoVEhSRUFERURfSFRNTF9QQVJTRVIpCisgICAgLy8gVGhpcyBBU1NFUlQg dHJpZ2dlcnMgd2l0aCB0aGUgdGhyZWFkZWQgSFRNTCBwYXJzZXIuCisgICAgLy8gU2VlIGh0dHBz Oi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xMTA5MzcKKyAgICBBU1NFUlQodGhp cyA9PSBmcmFtZUxvYWRlcigpLT5hY3RpdmVEb2N1bWVudExvYWRlcigpKTsKKyNlbmRpZgogICAg IG1fZnJhbWUtPmRvY3VtZW50KCktPmRvbVdpbmRvdygpLT5maW5pc2hlZExvYWRpbmcoKTsKIH0K IAo= 190577 2013-02-27 12:37:41 -0800 2013-02-28 11:44:24 -0800 Patch for landing bug-110937-20130227123354.patch text/plain 1502 abarth SW5kZXg6IFNvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2Vi Q29yZS9DaGFuZ2VMb2cJKHJldmlzaW9uIDE0NDIyMikKKysrIFNvdXJjZS9XZWJDb3JlL0NoYW5n ZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDE3IEBACisyMDEzLTAyLTI3ICBBZGFtIEJh cnRoICA8YWJhcnRoQHdlYmtpdC5vcmc+CisKKyAgICAgICAgVGhyZWFkZWQgSFRNTCBwYXJzZXIg aGl0cyBBU1NFUlRJT04gRkFJTEVEOiB0aGlzID09IGZyYW1lTG9hZGVyKCktPmFjdGl2ZURvY3Vt ZW50TG9hZGVyKCkKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dp P2lkPTExMDkzNworCisgICAgICAgIFJldmlld2VkIGJ5IERhcmluIEFkbGVyLgorCisgICAgICAg IFRoaXMgcGF0Y2ggcmVzdG9yZXMgdGhlIEFTU0VSVCBiZWhpbmQgYW4gaWZkZWYgc28gdGhhdCB3 ZSBjYW4gY29udGludWUKKyAgICAgICAgdG8gZ2V0IGNvbnZlcmFnZSBmcm9tIHRoZSBBU1NFUlQg d2hpbGUgd2UgaW52ZXN0aWdhdGUgd2h5IGl0IGlzCisgICAgICAgIHRyaWdnZXJpbmcgaW4gdGhl IHRocmVhZGVkIHBhcnNlci4KKworICAgICAgICAqIGxvYWRlci9Eb2N1bWVudExvYWRlci5jcHA6 CisgICAgICAgIChXZWJDb3JlOjpEb2N1bWVudExvYWRlcjo6Y2hlY2tMb2FkQ29tcGxldGUpOgor CiAyMDEzLTAyLTI3ICBNYW51ZWwgUmVnbyBDYXNhc25vdmFzICA8cmVnb0BpZ2FsaWEuY29tPgog CiAgICAgICAgIEFkZCBzbWFydEluc2VydERlbGV0ZUVuYWJsZWQgc2V0dGluZyB0byBXZWJDb3Jl OjpQYWdlCkluZGV4OiBTb3VyY2UvV2ViQ29yZS9sb2FkZXIvRG9jdW1lbnRMb2FkZXIuY3BwCj09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT0KLS0tIFNvdXJjZS9XZWJDb3JlL2xvYWRlci9Eb2N1bWVudExvYWRlci5jcHAJKHJl dmlzaW9uIDE0NDIyMikKKysrIFNvdXJjZS9XZWJDb3JlL2xvYWRlci9Eb2N1bWVudExvYWRlci5j cHAJKHdvcmtpbmcgY29weSkKQEAgLTQzMSw2ICs0MzEsMTEgQEAgdm9pZCBEb2N1bWVudExvYWRl cjo6Y2hlY2tMb2FkQ29tcGxldGUoKQogewogICAgIGlmICghbV9mcmFtZSB8fCBpc0xvYWRpbmco KSkKICAgICAgICAgcmV0dXJuOworI2lmICFFTkFCTEUoVEhSRUFERURfSFRNTF9QQVJTRVIpCisg ICAgLy8gVGhpcyBBU1NFUlQgdHJpZ2dlcnMgd2l0aCB0aGUgdGhyZWFkZWQgSFRNTCBwYXJzZXIu CisgICAgLy8gU2VlIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xMTA5 MzcKKyAgICBBU1NFUlQodGhpcyA9PSBmcmFtZUxvYWRlcigpLT5hY3RpdmVEb2N1bWVudExvYWRl cigpKTsKKyNlbmRpZgogICAgIG1fZnJhbWUtPmRvY3VtZW50KCktPmRvbVdpbmRvdygpLT5maW5p c2hlZExvYWRpbmcoKTsKIH0KIAo= 190771 2013-02-28 11:44:27 -0800 2013-02-28 13:50:35 -0800 Patch bug-110937-20130228114044.patch text/plain 3132 eric U3VidmVyc2lvbiBSZXZpc2lvbjogMTQ0MzIwCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggYThmMjNkZGU5ZjdmNzk0 YmE3MDIxYjgxYTc4MTk3MGRiODk0Y2RkOS4uMzA2YmI2ZDU1M2EzNTYxNzZlYWFiZTI4ZDJhODQx ODdhMmMxYzQyZiAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDIxIEBACisyMDEzLTAyLTI4ICBFcmlj IFNlaWRlbCAgPGVyaWNAd2Via2l0Lm9yZz4KKworICAgICAgICBUaHJlYWRlZCBIVE1MIHBhcnNl ciBoaXRzIEFTU0VSVElPTiBGQUlMRUQ6IHRoaXMgPT0gZnJhbWVMb2FkZXIoKS0+YWN0aXZlRG9j dW1lbnRMb2FkZXIoKQorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5j Z2k/aWQ9MTEwOTM3CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAg ICAgICAgUmVtb3ZlIHRoZSAjaWZkZWYgZ3VhcmRzIGFkZGVkIHRvIHdvcmsgYXJvdW5kIHRoaXMg QVNTRVJULgorICAgICAgICBUaGlzIHdhcyBmaXhlZCBieSBodHRwczovL2J1Z3Mud2Via2l0Lm9y Zy9zaG93X2J1Zy5jZ2k/aWQ9MTEwOTUxCisgICAgICAgIGFzIG5vdyBEb2N1bWVudExvYWRlcjo6 Y2hlY2tMb2FkQ29tcGxldGUoKSB3aWxsIGlnbm9yZSB0aGUgY2FsbAorICAgICAgICBpZiB0aGUg RG9jdW1lbnRMb2FkZXIgaXMgbm90IHRoZSBhY3RpdmUgZG9jdW1lbnQgbG9hZGVyIGZvciB0aGUg RG9jdW1lbnQuCisKKyAgICAgICAgKiBkb20vRG9jdW1lbnQuY3BwOgorICAgICAgICAoV2ViQ29y ZTo6RG9jdW1lbnQ6OmRlY3JlbWVudEFjdGl2ZVBhcnNlckNvdW50KToKKyAgICAgICAgKiBsb2Fk ZXIvRG9jdW1lbnRMb2FkZXIuY3BwOgorICAgICAgICAoV2ViQ29yZTo6RG9jdW1lbnRMb2FkZXI6 OmlzTG9hZGluZyk6CisgICAgICAgIChXZWJDb3JlOjpEb2N1bWVudExvYWRlcjo6Y2hlY2tMb2Fk Q29tcGxldGUpOgorCiAyMDEzLTAyLTI2ICBEYXZpZCBIeWF0dCAgPGh5YXR0QGFwcGxlLmNvbT4K IAogICAgICAgICBbTmV3IE11bHRpY29sdW1uXSBSZXdyaXRlIHRoZSBwYWludGluZy9zdGFja2lu ZyBtb2RlbCB0byBiZSBzcGVjIGNvbXBsaWFudC4KZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3Jl L2RvbS9Eb2N1bWVudC5jcHAgYi9Tb3VyY2UvV2ViQ29yZS9kb20vRG9jdW1lbnQuY3BwCmluZGV4 IDJjNWRmNjczMmE1YzMwZGRjOTIxNmUyOWNlMWEwMWMwNGRjZmZhMWUuLjVkMDNhNzk1NWQ4NTRh MTk1NGZiNjAwMWNkNDM1ZmUwMWUzNDUyOGMgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJDb3JlL2Rv bS9Eb2N1bWVudC5jcHAKKysrIGIvU291cmNlL1dlYkNvcmUvZG9tL0RvY3VtZW50LmNwcApAQCAt NTgwOCwxMiArNTgwOCw3IEBAIHZvaWQgRG9jdW1lbnQ6OmRlY3JlbWVudEFjdGl2ZVBhcnNlckNv dW50KCkKICAgICAtLW1fYWN0aXZlUGFyc2VyQ291bnQ7CiAgICAgaWYgKCFmcmFtZSgpKQogICAg ICAgICByZXR1cm47Ci0gICAgLy8gRklYTUU6IFRoaXMgc2hvdWxkIGFsd2F5cyBiZSBlbmFibGVk LCBidXQgaXQgc2VlbXMgdG8gY2F1c2UKLSAgICAvLyBodHRwL3Rlc3RzL3NlY3VyaXR5L2ZlZWQt dXJscy1mcm9tLXJlbW90ZS5odG1sIHRvIHRpbWVvdXQgb24gTWFjIFdLMQotICAgIC8vIHNlZSBo dHRwOi8vd2Via2l0Lm9yZy9iLzExMDU1NCBhbmQgaHR0cDovL3dlYmtpdC5vcmcvYi8xMTA0MDEK LSNpZiBFTkFCTEUoVEhSRUFERURfSFRNTF9QQVJTRVIpCiAgICAgbG9hZGVyKCktPmNoZWNrTG9h ZENvbXBsZXRlKCk7Ci0jZW5kaWYKICAgICBmcmFtZSgpLT5sb2FkZXIoKS0+Y2hlY2tMb2FkQ29t cGxldGUoKTsKIH0KIApkaWZmIC0tZ2l0IGEvU291cmNlL1dlYkNvcmUvbG9hZGVyL0RvY3VtZW50 TG9hZGVyLmNwcCBiL1NvdXJjZS9XZWJDb3JlL2xvYWRlci9Eb2N1bWVudExvYWRlci5jcHAKaW5k ZXggNDRhMjkxZTcyMDc2MzdlYzNhNzBlY2UzZDczYjQwYTY5OTBjMDUwMy4uMGE1ZGY2NTUxNGRi MjhmNmE0NGFkN2MxNzFjY2ZhYTRiYjZiOWQzMyAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUv bG9hZGVyL0RvY3VtZW50TG9hZGVyLmNwcAorKysgYi9Tb3VyY2UvV2ViQ29yZS9sb2FkZXIvRG9j dW1lbnRMb2FkZXIuY3BwCkBAIC0yODcsMTMgKzI4Nyw4IEBAIHZvaWQgRG9jdW1lbnRMb2FkZXI6 OmNvbW1pdElmUmVhZHkoKQogCiBib29sIERvY3VtZW50TG9hZGVyOjppc0xvYWRpbmcoKSBjb25z dAogewotICAgIC8vIEZJWE1FOiBUaGlzIHNob3VsZCBhbHdheXMgYmUgZW5hYmxlZCwgYnV0IGl0 IHNlZW1zIHRvIGNhdXNlCi0gICAgLy8gaHR0cC90ZXN0cy9zZWN1cml0eS9mZWVkLXVybHMtZnJv bS1yZW1vdGUuaHRtbCB0byB0aW1lb3V0IG9uIE1hYyBXSzEKLSAgICAvLyBzZWUgaHR0cDovL3dl YmtpdC5vcmcvYi8xMTA1NTQgYW5kIGh0dHA6Ly93ZWJraXQub3JnL2IvMTEwNDAxCi0jaWYgRU5B QkxFKFRIUkVBREVEX0hUTUxfUEFSU0VSKQogICAgIGlmIChkb2N1bWVudCgpICYmIGRvY3VtZW50 KCktPmhhc0FjdGl2ZVBhcnNlcigpKQogICAgICAgICByZXR1cm4gdHJ1ZTsKLSNlbmRpZgogICAg IHJldHVybiBpc0xvYWRpbmdNYWluUmVzb3VyY2UoKSB8fCAhbV9zdWJyZXNvdXJjZUxvYWRlcnMu aXNFbXB0eSgpIHx8ICFtX3BsdWdJblN0cmVhbUxvYWRlcnMuaXNFbXB0eSgpOwogfQogCkBAIC00 MzgsMTEgKzQzMyw3IEBAIHZvaWQgRG9jdW1lbnRMb2FkZXI6OmNoZWNrTG9hZENvbXBsZXRlKCkK IHsKICAgICBpZiAoIW1fZnJhbWUgfHwgaXNMb2FkaW5nKCkpCiAgICAgICAgIHJldHVybjsKLSNp ZiAhRU5BQkxFKFRIUkVBREVEX0hUTUxfUEFSU0VSKQotICAgIC8vIFRoaXMgQVNTRVJUIHRyaWdn ZXJzIHdpdGggdGhlIHRocmVhZGVkIEhUTUwgcGFyc2VyLgotICAgIC8vIFNlZSBodHRwczovL2J1 Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTEwOTM3CiAgICAgQVNTRVJUKHRoaXMgPT0g ZnJhbWVMb2FkZXIoKS0+YWN0aXZlRG9jdW1lbnRMb2FkZXIoKSk7Ci0jZW5kaWYKICAgICBtX2Zy YW1lLT5kb2N1bWVudCgpLT5kb21XaW5kb3coKS0+ZmluaXNoZWRMb2FkaW5nKCk7CiB9CiAK 190802 2013-02-28 13:50:38 -0800 2013-02-28 14:35:30 -0800 Patch for landing bug-110937-20130228134654.patch text/plain 3833 eric U3VidmVyc2lvbiBSZXZpc2lvbjogMTQ0MzIwCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggYThmMjNkZGU5ZjdmNzk0 YmE3MDIxYjgxYTc4MTk3MGRiODk0Y2RkOS4uM2VjNDM0MTRmM2M4ZDQ0ZWZmYWQ2ZDczZDlhYTM0 OGUzODlmNzAyNSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDIxIEBACisyMDEzLTAyLTI4ICBFcmlj IFNlaWRlbCAgPGVyaWNAd2Via2l0Lm9yZz4KKworICAgICAgICBUaHJlYWRlZCBIVE1MIHBhcnNl ciBoaXRzIEFTU0VSVElPTiBGQUlMRUQ6IHRoaXMgPT0gZnJhbWVMb2FkZXIoKS0+YWN0aXZlRG9j dW1lbnRMb2FkZXIoKQorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5j Z2k/aWQ9MTEwOTM3CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgQWRhbSBCYXJ0aC4KKworICAgICAg ICBSZW1vdmUgdGhlICNpZmRlZiBndWFyZHMgYWRkZWQgdG8gd29yayBhcm91bmQgdGhpcyBBU1NF UlQuCisgICAgICAgIFRoaXMgd2FzIGZpeGVkIGJ5IGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3No b3dfYnVnLmNnaT9pZD0xMTA5NTEKKyAgICAgICAgYXMgbm93IERvY3VtZW50TG9hZGVyOjpjaGVj a0xvYWRDb21wbGV0ZSgpIHdpbGwgaWdub3JlIHRoZSBjYWxsCisgICAgICAgIGlmIHRoZSBEb2N1 bWVudExvYWRlciBpcyBub3QgdGhlIGFjdGl2ZSBkb2N1bWVudCBsb2FkZXIgZm9yIHRoZSBEb2N1 bWVudC4KKworICAgICAgICAqIGRvbS9Eb2N1bWVudC5jcHA6CisgICAgICAgIChXZWJDb3JlOjpE b2N1bWVudDo6ZGVjcmVtZW50QWN0aXZlUGFyc2VyQ291bnQpOgorICAgICAgICAqIGxvYWRlci9E b2N1bWVudExvYWRlci5jcHA6CisgICAgICAgIChXZWJDb3JlOjpEb2N1bWVudExvYWRlcjo6aXNM b2FkaW5nKToKKyAgICAgICAgKFdlYkNvcmU6OkRvY3VtZW50TG9hZGVyOjpjaGVja0xvYWRDb21w bGV0ZSk6CisKIDIwMTMtMDItMjYgIERhdmlkIEh5YXR0ICA8aHlhdHRAYXBwbGUuY29tPgogCiAg ICAgICAgIFtOZXcgTXVsdGljb2x1bW5dIFJld3JpdGUgdGhlIHBhaW50aW5nL3N0YWNraW5nIG1v ZGVsIHRvIGJlIHNwZWMgY29tcGxpYW50LgpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYkNvcmUvZG9t L0RvY3VtZW50LmNwcCBiL1NvdXJjZS9XZWJDb3JlL2RvbS9Eb2N1bWVudC5jcHAKaW5kZXggMmM1 ZGY2NzMyYTVjMzBkZGM5MjE2ZTI5Y2UxYTAxYzA0ZGNmZmExZS4uNWQwM2E3OTU1ZDg1NGExOTU0 ZmI2MDAxY2Q0MzVmZTAxZTM0NTI4YyAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvZG9tL0Rv Y3VtZW50LmNwcAorKysgYi9Tb3VyY2UvV2ViQ29yZS9kb20vRG9jdW1lbnQuY3BwCkBAIC01ODA4 LDEyICs1ODA4LDcgQEAgdm9pZCBEb2N1bWVudDo6ZGVjcmVtZW50QWN0aXZlUGFyc2VyQ291bnQo KQogICAgIC0tbV9hY3RpdmVQYXJzZXJDb3VudDsKICAgICBpZiAoIWZyYW1lKCkpCiAgICAgICAg IHJldHVybjsKLSAgICAvLyBGSVhNRTogVGhpcyBzaG91bGQgYWx3YXlzIGJlIGVuYWJsZWQsIGJ1 dCBpdCBzZWVtcyB0byBjYXVzZQotICAgIC8vIGh0dHAvdGVzdHMvc2VjdXJpdHkvZmVlZC11cmxz LWZyb20tcmVtb3RlLmh0bWwgdG8gdGltZW91dCBvbiBNYWMgV0sxCi0gICAgLy8gc2VlIGh0dHA6 Ly93ZWJraXQub3JnL2IvMTEwNTU0IGFuZCBodHRwOi8vd2Via2l0Lm9yZy9iLzExMDQwMQotI2lm IEVOQUJMRShUSFJFQURFRF9IVE1MX1BBUlNFUikKICAgICBsb2FkZXIoKS0+Y2hlY2tMb2FkQ29t cGxldGUoKTsKLSNlbmRpZgogICAgIGZyYW1lKCktPmxvYWRlcigpLT5jaGVja0xvYWRDb21wbGV0 ZSgpOwogfQogCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9sb2FkZXIvRG9jdW1lbnRMb2Fk ZXIuY3BwIGIvU291cmNlL1dlYkNvcmUvbG9hZGVyL0RvY3VtZW50TG9hZGVyLmNwcAppbmRleCA0 NGEyOTFlNzIwNzYzN2VjM2E3MGVjZTNkNzNiNDBhNjk5MGMwNTAzLi4wYTVkZjY1NTE0ZGIyOGY2 YTQ0YWQ3YzE3MWNjZmFhNGJiNmI5ZDMzIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9sb2Fk ZXIvRG9jdW1lbnRMb2FkZXIuY3BwCisrKyBiL1NvdXJjZS9XZWJDb3JlL2xvYWRlci9Eb2N1bWVu dExvYWRlci5jcHAKQEAgLTI4NywxMyArMjg3LDggQEAgdm9pZCBEb2N1bWVudExvYWRlcjo6Y29t bWl0SWZSZWFkeSgpCiAKIGJvb2wgRG9jdW1lbnRMb2FkZXI6OmlzTG9hZGluZygpIGNvbnN0CiB7 Ci0gICAgLy8gRklYTUU6IFRoaXMgc2hvdWxkIGFsd2F5cyBiZSBlbmFibGVkLCBidXQgaXQgc2Vl bXMgdG8gY2F1c2UKLSAgICAvLyBodHRwL3Rlc3RzL3NlY3VyaXR5L2ZlZWQtdXJscy1mcm9tLXJl bW90ZS5odG1sIHRvIHRpbWVvdXQgb24gTWFjIFdLMQotICAgIC8vIHNlZSBodHRwOi8vd2Via2l0 Lm9yZy9iLzExMDU1NCBhbmQgaHR0cDovL3dlYmtpdC5vcmcvYi8xMTA0MDEKLSNpZiBFTkFCTEUo VEhSRUFERURfSFRNTF9QQVJTRVIpCiAgICAgaWYgKGRvY3VtZW50KCkgJiYgZG9jdW1lbnQoKS0+ aGFzQWN0aXZlUGFyc2VyKCkpCiAgICAgICAgIHJldHVybiB0cnVlOwotI2VuZGlmCiAgICAgcmV0 dXJuIGlzTG9hZGluZ01haW5SZXNvdXJjZSgpIHx8ICFtX3N1YnJlc291cmNlTG9hZGVycy5pc0Vt cHR5KCkgfHwgIW1fcGx1Z0luU3RyZWFtTG9hZGVycy5pc0VtcHR5KCk7CiB9CiAKQEAgLTQzOCwx MSArNDMzLDcgQEAgdm9pZCBEb2N1bWVudExvYWRlcjo6Y2hlY2tMb2FkQ29tcGxldGUoKQogewog ICAgIGlmICghbV9mcmFtZSB8fCBpc0xvYWRpbmcoKSkKICAgICAgICAgcmV0dXJuOwotI2lmICFF TkFCTEUoVEhSRUFERURfSFRNTF9QQVJTRVIpCi0gICAgLy8gVGhpcyBBU1NFUlQgdHJpZ2dlcnMg d2l0aCB0aGUgdGhyZWFkZWQgSFRNTCBwYXJzZXIuCi0gICAgLy8gU2VlIGh0dHBzOi8vYnVncy53 ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xMTA5MzcKICAgICBBU1NFUlQodGhpcyA9PSBmcmFt ZUxvYWRlcigpLT5hY3RpdmVEb2N1bWVudExvYWRlcigpKTsKLSNlbmRpZgogICAgIG1fZnJhbWUt PmRvY3VtZW50KCktPmRvbVdpbmRvdygpLT5maW5pc2hlZExvYWRpbmcoKTsKIH0KIApkaWZmIC0t Z2l0IGEvTGF5b3V0VGVzdHMvcGxhdGZvcm0vbWFjL1Rlc3RFeHBlY3RhdGlvbnMgYi9MYXlvdXRU ZXN0cy9wbGF0Zm9ybS9tYWMvVGVzdEV4cGVjdGF0aW9ucwppbmRleCBiNDFjNzdhNzkzNTU3YzMw MWQ0YTc5Mjg2ZjI4YmE5MmVhNWJlMmI1Li44YTZkN2NiNjY0MTgyZDliOGQxMGRmMTVhNGNjMDg3 MGU5ZmJlZWJjIDEwMDY0NAotLS0gYS9MYXlvdXRUZXN0cy9wbGF0Zm9ybS9tYWMvVGVzdEV4cGVj dGF0aW9ucworKysgYi9MYXlvdXRUZXN0cy9wbGF0Zm9ybS9tYWMvVGVzdEV4cGVjdGF0aW9ucwpA QCAtMTQzOSw3ICsxNDM5LDYgQEAgd2Via2l0Lm9yZy9iLzExMDE3MyBtZWRpYS92aWRlby1jb250 cm9scy1jYXB0aW9ucy10cmFja21lbnUuaHRtbCBbIENyYXNoIFBhc3MgXQogCiB3ZWJraXQub3Jn L2IvMTEwMTg2IGluc3BlY3Rvci1wcm90b2NvbC9wYWdlL2phdmFzY3JpcHREaWFsb2dFdmVudHMu aHRtbCBbIFNraXAgXQogCi13ZWJraXQub3JnL2IvMTEwNTU0IGh0dHAvdGVzdHMvc2VjdXJpdHkv ZmVlZC11cmxzLWZyb20tcmVtb3RlLmh0bWwgWyBGYWlsdXJlIF0KIHdlYmtpdC5vcmcvYi8xMTA1 NTUgZmFzdC9jYW52YXMvY2FudmFzLWN1cnJlbnRQYXRoLmh0bWwgWyBGYWlsdXJlIF0KIHdlYmtp dC5vcmcvYi8xMTA1NTUgZmFzdC9jYW52YXMvY2FudmFzLXBhdGgtY29uc3RydWN0b3JzLmh0bWwg WyBGYWlsdXJlIF0KIAo=