110844 2013-02-25 21:34:28 -0800 REGRESSION (r143931): set-cookie-on-redirect.html breaks subsequent tests 2013-03-06 17:14:00 -0800 1 1 1 Unclassified WebKit Tools / Tests 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 ap svillar beidson cgarcia dino mrobinson roger_fong svillar webkit.review.bot oldest_to_newest 841606 0 ap 2013-02-25 21:34:28 -0800 This test doesn't clean up cookies, so they show up in subsequent tests, and in particular break third-party-cookie-relaxing.html, because it depends on whether there are already cookies set for the particular first party. Bots hide this misbehavior, because they re-run failing tests, this time without set-cookie-on-redirect.html. Sergio, can you please look into this? I think that the patch will need to be rolled out if this cannot be fixed soon. 841719 1 svillar 2013-02-26 00:39:17 -0800 (In reply to comment #0) > This test doesn't clean up cookies, so they show up in subsequent tests, and in particular break third-party-cookie-relaxing.html, because it depends on whether there are already cookies set for the particular first party. > > Bots hide this misbehavior, because they re-run failing tests, this time without set-cookie-on-redirect.html. > > Sergio, can you please look into this? I think that the patch will need to be rolled out if this cannot be fixed soon. Sure. It's true that the test I added does not clean up cookies, but in any case, shouldn't third-party-cookie-relaxing.html call clearAllCookies() at the beginning as the other tests do? 841727 2 ap 2013-02-26 00:48:33 -0800 Possibly. Cookie testing machinery is extremely fragile, and I'm not sure if that would help. 841777 3 190237 svillar 2013-02-26 01:28:37 -0800 Created attachment 190237 Patch 841922 4 190237 webkit.review.bot 2013-02-26 05:39:20 -0800 Comment on attachment 190237 Patch Clearing flags on attachment: 190237 Committed r144045: <http://trac.webkit.org/changeset/144045> 841923 5 webkit.review.bot 2013-02-26 05:39:23 -0800 All reviewed patches have been landed. Closing bug. 842137 6 ap 2013-02-26 10:13:01 -0800 Confirmed that the patch helped on Mac. Thank you! 849507 7 dino 2013-03-06 17:14:00 -0800 More reports in https://bugs.webkit.org/show_bug.cgi?id=111650 190237 2013-02-26 01:28:37 -0800 2013-02-26 05:39:20 -0800 Patch bug-110844-20130226102446.patch text/plain 2344 svillar U3VidmVyc2lvbiBSZXZpc2lvbjogMTQzOTMxCmRpZmYgLS1naXQgYS9MYXlvdXRUZXN0cy9DaGFu Z2VMb2cgYi9MYXlvdXRUZXN0cy9DaGFuZ2VMb2cKaW5kZXggYmNjODlhNmJhYTVlNWY4NWU5YjM5 ZmMxNDAwZDVmYTQzOTA0YjQ3YS4uMjQ0OWFkZmY5MzMyYThkZmM1MjAyYTQwMTIxMDI4N2IxMjk2 YWVjNyAxMDA2NDQKLS0tIGEvTGF5b3V0VGVzdHMvQ2hhbmdlTG9nCisrKyBiL0xheW91dFRlc3Rz L0NoYW5nZUxvZwpAQCAtMSwzICsxLDE2IEBACisyMDEzLTAyLTI2ICBTZXJnaW8gVmlsbGFyIFNl bmluICA8c3ZpbGxhckBpZ2FsaWEuY29tPgorCisgICAgICAgIFJFR1JFU1NJT04gKHIxNDM5MzEp OiBzZXQtY29va2llLW9uLXJlZGlyZWN0Lmh0bWwgYnJlYWtzIHN1YnNlcXVlbnQgdGVzdHMKKyAg ICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTExMDg0NAorCisg ICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIENsZWFuIHVwIGNv b2tpZXMgYXQgdGhlIGJlZ2lubmluZyBhbmQgYWZ0ZXIgZmluaXNoaW5nIHRoZSB0ZXN0IGluCisg ICAgICAgIG9yZGVyIG5vdCB0byBicmVhayBvdGhlciB0ZXN0cyBiZWhhdmlvci4KKworICAgICAg ICAqIGh0dHAvdGVzdHMvY29va2llcy9yZXNvdXJjZXMvc2V0LWNvb2tpZS1vbi1yZWRpcmVjdC5w aHA6IGNsZWFyIGNvb2tpZSBiZWZvcmUgcmV0dXJuaW5nLgorICAgICAgICAqIGh0dHAvdGVzdHMv Y29va2llcy9zZXQtY29va2llLW9uLXJlZGlyZWN0Lmh0bWw6IGNsZWFyIGFsbCBjb29raWVzIGJl Zm9yZSBzdGFydGluZyB0aGUgdGVzdC4KKwogMjAxMy0wMi0yNSAgU2VyZ2lvIFZpbGxhciBTZW5p biAgPHN2aWxsYXJAaWdhbGlhLmNvbT4KIAogICAgICAgICBbc291cF0gIlRvbyBtYW55IHJlZGly ZWN0cyIgZXJyb3IgbG9hZGluZyBjaGF0IGluIHBsdXMuZ29vZ2xlLmNvbQpkaWZmIC0tZ2l0IGEv TGF5b3V0VGVzdHMvaHR0cC90ZXN0cy9jb29raWVzL3Jlc291cmNlcy9zZXQtY29va2llLW9uLXJl ZGlyZWN0LnBocCBiL0xheW91dFRlc3RzL2h0dHAvdGVzdHMvY29va2llcy9yZXNvdXJjZXMvc2V0 LWNvb2tpZS1vbi1yZWRpcmVjdC5waHAKaW5kZXggMjZkMDRlMzI4MzYxODQzZmJmODE4NmM5NWY2 MDJkODY1OGE5ODM3OC4uYzhkMzBjZTc0ZjU5N2E2NjdlMTk0M2RmZjMzMzc0ODM2Y2IxYWU3YSAx MDA2NDQKLS0tIGEvTGF5b3V0VGVzdHMvaHR0cC90ZXN0cy9jb29raWVzL3Jlc291cmNlcy9zZXQt Y29va2llLW9uLXJlZGlyZWN0LnBocAorKysgYi9MYXlvdXRUZXN0cy9odHRwL3Rlc3RzL2Nvb2tp ZXMvcmVzb3VyY2VzL3NldC1jb29raWUtb24tcmVkaXJlY3QucGhwCkBAIC05LDYgKzksOSBAQCBp ZiAoJF9HRVRbJ3N0ZXAnXSA9PSAxKSB7CiB9IGVsc2UgaWYgKCRfR0VUWydzdGVwJ10gPT0gMykg ewogICBoZWFkZXIoIkhUVFAvMS4wIDIwMCBPSyIpOwogICBpZiAoaXNzZXQoJF9DT09LSUVbJ3Rl c3RfY29va2llJ10pKSB7CisgICAgLyogQ2xlYXIgY29va2llIGluIG9yZGVyIG5vdCB0byBhZmZl Y3Qgb3RoZXIgdGVzdHMuICovCisgICAgc2V0Y29va2llKCJ0ZXN0X2Nvb2tpZSIsICIiLCB0aW1l KCkgLSAxKTsKKwogICAgIGVjaG8gIlBBU1NFRDogQ29va2llIHN1Y2Nlc3NmdWxseSBzZXRcbiI7 CiAgIH0gZWxzZSB7CiAgICAgZWNobyAiRkFJTEVEOiBDb29raWUgbm90IHNldFxuIjsKZGlmZiAt LWdpdCBhL0xheW91dFRlc3RzL2h0dHAvdGVzdHMvY29va2llcy9zZXQtY29va2llLW9uLXJlZGly ZWN0Lmh0bWwgYi9MYXlvdXRUZXN0cy9odHRwL3Rlc3RzL2Nvb2tpZXMvc2V0LWNvb2tpZS1vbi1y ZWRpcmVjdC5odG1sCmluZGV4IDM4MjdkMjNhNmU5NmRhNTM4YjFmZTA1OTg2MTg2OTU5NGRjYWMw YmEuLjc1ZGY3YmY0NGI4MWE1ODYxYTZlNTY3OWMwMWU5ZDgwNTE0ODMyNzkgMTAwNjQ0Ci0tLSBh L0xheW91dFRlc3RzL2h0dHAvdGVzdHMvY29va2llcy9zZXQtY29va2llLW9uLXJlZGlyZWN0Lmh0 bWwKKysrIGIvTGF5b3V0VGVzdHMvaHR0cC90ZXN0cy9jb29raWVzL3NldC1jb29raWUtb24tcmVk aXJlY3QuaHRtbApAQCAtMSwxMSArMSwxMiBAQAogPCFET0NUWVBFIEhUTUwgUFVCTElDICItLy9J RVRGLy9EVEQgSFRNTC8vRU4iPgogPGh0bWw+Ci0KKzxzY3JpcHQgc3JjPSJyZXNvdXJjZXMvY29v a2llcy10ZXN0LXByZS5qcyI+PC9zY3JpcHQ+CiA8c2NyaXB0PgogaWYgKHdpbmRvdy50ZXN0UnVu bmVyKSB7CiAgICAgdGVzdFJ1bm5lci5kdW1wQXNUZXh0KCk7CiAgICAgdGVzdFJ1bm5lci53YWl0 VW50aWxEb25lKCk7CiB9CitjbGVhckFsbENvb2tpZXMoKTsKIAogZnVuY3Rpb24gZG9SZWRpcmVj dCgpCiB7Cg==