110752 2013-02-25 05:46:23 -0800 OpenCL implementation of FEImage SVG Filter. 2013-02-28 03:52:31 -0800 1 1 1 Unclassified WebKit SVG 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 70099 0 tczene webkit-unassigned dino d-r fmalita pdr schenney webkit.review.bot zherczeg zimmermann oldest_to_newest 840906 0 tczene 2013-02-25 05:46:23 -0800 This implementation runs the software method and then it uploads the results to the OpenCL device. 840907 1 190042 tczene 2013-02-25 05:47:13 -0800 Created attachment 190042 proposed patch 840909 2 190044 tczene 2013-02-25 05:48:58 -0800 Created attachment 190044 proposed patch 842842 3 190044 zherczeg 2013-02-27 01:41:12 -0800 Comment on attachment 190044 proposed patch Good patch, but the patch does not apply. Could you reupload the patch for chechking it again? 842855 4 190472 tczene 2013-02-27 02:00:19 -0800 Created attachment 190472 proposed patch 842967 5 190472 schenney 2013-02-27 05:34:51 -0800 Comment on attachment 190472 proposed patch View in context: https://bugs.webkit.org/attachment.cgi?id=190472&action=review > Source/WebCore/svg/graphics/filters/SVGFEImage.h:43 > + virtual bool platformApplyOpenCL(); This has not been enforced on your patches to date, but WebKit standards say that all implementations of virtual methods must be explicitly marked OVERRIDE. Leave it for now but please follow up with a patch to fix all the overrides of platformApplyOpenCL. 843956 6 zherczeg 2013-02-28 03:42:45 -0800 (In reply to comment #5) > (From update of attachment 190472 [details]) > View in context: https://bugs.webkit.org/attachment.cgi?id=190472&action=review > > > Source/WebCore/svg/graphics/filters/SVGFEImage.h:43 > > + virtual bool platformApplyOpenCL(); > > This has not been enforced on your patches to date, but WebKit standards say that all implementations of virtual methods must be explicitly marked OVERRIDE. Leave it for now but please follow up with a patch to fix all the overrides of platformApplyOpenCL. Good point. 843957 7 190472 zherczeg 2013-02-28 03:43:40 -0800 Comment on attachment 190472 proposed patch r=me, but please make a follow-up patch for fixing all virtual methods. 843963 8 190472 webkit.review.bot 2013-02-28 03:52:27 -0800 Comment on attachment 190472 proposed patch Clearing flags on attachment: 190472 Committed r144289: <http://trac.webkit.org/changeset/144289> 843964 9 webkit.review.bot 2013-02-28 03:52:31 -0800 All reviewed patches have been landed. Closing bug. 190042 2013-02-25 05:47:13 -0800 2013-02-25 05:48:58 -0800 proposed patch patch text/plain 4439 tczene ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZyBiL1NvdXJjZS9XZWJDb3JlL0No YW5nZUxvZwppbmRleCA0YzZhZjFmLi4wMzkzOGQyIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29y ZS9DaGFuZ2VMb2cKKysrIGIvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTkg QEAKKzIwMTMtMDItMjUgIFRhbWFzIEN6ZW5lICA8dGN6ZW5lQGluZi51LXN6ZWdlZC5odT4KKwor ICAgICAgICBPcGVuQ0wgaW1wbGVtZW50YXRpb24gb2YgRkVJbWFnZSBTVkcgRmlsdGVyLgorICAg ICAgICBOZWVkIHRoZSBidWcgVVJMIChPT1BTISkuCisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9C T0RZIChPT1BTISkuCisKKyAgICAgICAgVGhpcyBpbXBsZW1lbnRhdGlvbiBydW5zIHRoZSBzb2Z0 d2FyZSBtZXRob2QgYW5kIHRoZW4gaXQgdXBsb2FkcyB0aGUgcmVzdWx0cyB0byB0aGUgT3BlbkNM IGRldmljZS4KKworICAgICAgICAqIFRhcmdldC5wcmk6CisgICAgICAgICogcGxhdGZvcm0vZ3Jh cGhpY3MvZ3B1L29wZW5jbC9PcGVuQ0xGRUltYWdlLmNwcDogQWRkZWQuCisgICAgICAgIChXZWJD b3JlKToKKyAgICAgICAgKFdlYkNvcmU6OkZFSW1hZ2U6OnBsYXRmb3JtQXBwbHlPcGVuQ0wpOgor ICAgICAgICAqIHN2Zy9ncmFwaGljcy9maWx0ZXJzL1NWR0ZFSW1hZ2UuaDoKKyAgICAgICAgKEZF SW1hZ2UpOgorCiAyMDEzLTAyLTIwICBBbGV4ZXkgUHJvc2t1cnlha292ICA8YXBAYXBwbGUuY29t PgogCiAgICAgICAgIFN0b3AgaGFyZGNvZGluZyBrbm93bGVkZ2UgYWJvdXQgYmxvYiBwcm90b2Nv bCBpbiBSZXNvdXJjZUhhbmRsZQpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYkNvcmUvVGFyZ2V0LnBy aSBiL1NvdXJjZS9XZWJDb3JlL1RhcmdldC5wcmkKaW5kZXggOWEwOWEwNC4uODA4OTFjYSAxMDA2 NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvVGFyZ2V0LnByaQorKysgYi9Tb3VyY2UvV2ViQ29yZS9U YXJnZXQucHJpCkBAIC00MjM4LDYgKzQyMzgsNyBAQCBjb250YWlucyhERUZJTkVTLCBFTkFCTEVf T1BFTkNMPTEpIHsKICAgICAgICAgcGxhdGZvcm0vZ3JhcGhpY3MvZ3B1L29wZW5jbC9GaWx0ZXJD b250ZXh0T3BlbkNMLmNwcCBcCiAgICAgICAgIHBsYXRmb3JtL2dyYXBoaWNzL2dwdS9vcGVuY2wv T3BlbkNMRkVDb2xvck1hdHJpeC5jcHAgXAogICAgICAgICBwbGF0Zm9ybS9ncmFwaGljcy9ncHUv b3BlbmNsL09wZW5DTEZFRmxvb2QuY3BwIFwKKyAgICAgICAgcGxhdGZvcm0vZ3JhcGhpY3MvZ3B1 L29wZW5jbC9PcGVuQ0xGRUltYWdlLmNwcCBcCiAgICAgICAgIHBsYXRmb3JtL2dyYXBoaWNzL2dw dS9vcGVuY2wvT3BlbkNMRkVTb3VyY2VBbHBoYS5jcHAgXAogICAgICAgICBwbGF0Zm9ybS9ncmFw aGljcy9ncHUvb3BlbmNsL09wZW5DTEZFU291cmNlR3JhcGhpYy5jcHAgXAogICAgICAgICBwbGF0 Zm9ybS9ncmFwaGljcy9ncHUvb3BlbmNsL09wZW5DTEZFVHVyYnVsZW5jZS5jcHAKZGlmZiAtLWdp dCBhL1NvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL2dyYXBoaWNzL2dwdS9vcGVuY2wvT3BlbkNMRkVJ bWFnZS5jcHAgYi9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9ncmFwaGljcy9ncHUvb3BlbmNsL09w ZW5DTEZFSW1hZ2UuY3BwCm5ldyBmaWxlIG1vZGUgMTAwNjQ0CmluZGV4IDAwMDAwMDAuLjczNmE4 NjIKLS0tIC9kZXYvbnVsbAorKysgYi9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9ncmFwaGljcy9n cHUvb3BlbmNsL09wZW5DTEZFSW1hZ2UuY3BwCkBAIC0wLDAgKzEsNTEgQEAKKy8qCisgKiBDb3B5 cmlnaHQgKEMpIDIwMTMgVW5pdmVyc2l0eSBvZiBTemVnZWQKKyAqIENvcHlyaWdodCAoQykgMjAx MyBUYW1hcyBDemVuZSA8dGN6ZW5lQGluZi51LXN6ZWdlZC5odT4KKyAqIEFsbCByaWdodHMgcmVz ZXJ2ZWQuCisgKgorICogUmVkaXN0cmlidXRpb24gYW5kIHVzZSBpbiBzb3VyY2UgYW5kIGJpbmFy eSBmb3Jtcywgd2l0aCBvciB3aXRob3V0CisgKiBtb2RpZmljYXRpb24sIGFyZSBwZXJtaXR0ZWQg cHJvdmlkZWQgdGhhdCB0aGUgZm9sbG93aW5nIGNvbmRpdGlvbnMKKyAqIGFyZSBtZXQ6CisgKiAx LiBSZWRpc3RyaWJ1dGlvbnMgb2Ygc291cmNlIGNvZGUgbXVzdCByZXRhaW4gdGhlIGFib3ZlIGNv cHlyaWdodAorICogICAgbm90aWNlLCB0aGlzIGxpc3Qgb2YgY29uZGl0aW9ucyBhbmQgdGhlIGZv bGxvd2luZyBkaXNjbGFpbWVyLgorICogMi4gUmVkaXN0cmlidXRpb25zIGluIGJpbmFyeSBmb3Jt IG11c3QgcmVwcm9kdWNlIHRoZSBhYm92ZSBjb3B5cmlnaHQKKyAqICAgIG5vdGljZSwgdGhpcyBs aXN0IG9mIGNvbmRpdGlvbnMgYW5kIHRoZSBmb2xsb3dpbmcgZGlzY2xhaW1lciBpbiB0aGUKKyAq ICAgIGRvY3VtZW50YXRpb24gYW5kL29yIG90aGVyIG1hdGVyaWFscyBwcm92aWRlZCB3aXRoIHRo ZSBkaXN0cmlidXRpb24uCisgKgorICogVEhJUyBTT0ZUV0FSRSBJUyBQUk9WSURFRCBCWSBVTklW RVJTSVRZIE9GIFNaRUdFRCBgYEFTIElTJycgQU5EIEFOWQorICogRVhQUkVTUyBPUiBJTVBMSUVE IFdBUlJBTlRJRVMsIElOQ0xVRElORywgQlVUIE5PVCBMSU1JVEVEIFRPLCBUSEUKKyAqIElNUExJ RUQgV0FSUkFOVElFUyBPRiBNRVJDSEFOVEFCSUxJVFkgQU5EIEZJVE5FU1MgRk9SIEEgUEFSVElD VUxBUgorICogUFVSUE9TRSBBUkUgRElTQ0xBSU1FRC4gIElOIE5PIEVWRU5UIFNIQUxMIFVOSVZF UlNJVFkgT0YgU1pFR0VEIE9SCisgKiBDT05UUklCVVRPUlMgQkUgTElBQkxFIEZPUiBBTlkgRElS RUNULCBJTkRJUkVDVCwgSU5DSURFTlRBTCwgU1BFQ0lBTCwKKyAqIEVYRU1QTEFSWSwgT1IgQ09O U0VRVUVOVElBTCBEQU1BR0VTIChJTkNMVURJTkcsIEJVVCBOT1QgTElNSVRFRCBUTywKKyAqIFBS T0NVUkVNRU5UIE9GIFNVQlNUSVRVVEUgR09PRFMgT1IgU0VSVklDRVM7IExPU1MgT0YgVVNFLCBE QVRBLCBPUgorICogUFJPRklUUzsgT1IgQlVTSU5FU1MgSU5URVJSVVBUSU9OKSBIT1dFVkVSIENB VVNFRCBBTkQgT04gQU5ZIFRIRU9SWQorICogT0YgTElBQklMSVRZLCBXSEVUSEVSIElOIENPTlRS QUNULCBTVFJJQ1QgTElBQklMSVRZLCBPUiBUT1JUCisgKiAoSU5DTFVESU5HIE5FR0xJR0VOQ0Ug T1IgT1RIRVJXSVNFKSBBUklTSU5HIElOIEFOWSBXQVkgT1VUIE9GIFRIRSBVU0UKKyAqIE9GIFRI SVMgU09GVFdBUkUsIEVWRU4gSUYgQURWSVNFRCBPRiBUSEUgUE9TU0lCSUxJVFkgT0YgU1VDSCBE QU1BR0UuCisgKi8KKworI2luY2x1ZGUgImNvbmZpZy5oIgorI2lmIEVOQUJMRShGSUxURVJTKSAm JiBFTkFCTEUoT1BFTkNMKQorCisjaW5jbHVkZSAiRmlsdGVyQ29udGV4dE9wZW5DTC5oIgorI2lu Y2x1ZGUgIlNWR0ZFSW1hZ2UuaCIKKyNpbmNsdWRlICJTVkdGaWx0ZXIuaCIKKyNpbmNsdWRlICJT aGFyZWRCdWZmZXIuaCIKKworbmFtZXNwYWNlIFdlYkNvcmUgeworCitib29sIEZFSW1hZ2U6OnBs YXRmb3JtQXBwbHlPcGVuQ0woKQoreworICAgIHBsYXRmb3JtQXBwbHlTb2Z0d2FyZSgpOworICAg IEltYWdlQnVmZmVyKiBzb3VyY2VJbWFnZSA9IGFzSW1hZ2VCdWZmZXIoKTsKKyAgICBpZiAoc291 cmNlSW1hZ2UpIHsKKyAgICAgICAgUmVmUHRyPFVpbnQ4Q2xhbXBlZEFycmF5PiBzb3VyY2VJbWFn ZURhdGEgPSBzb3VyY2VJbWFnZS0+Z2V0VW5tdWx0aXBsaWVkSW1hZ2VEYXRhKEludFJlY3QoSW50 UG9pbnQoKSwgc291cmNlSW1hZ2UtPmludGVybmFsU2l6ZSgpKSk7CisgICAgICAgIGNyZWF0ZU9w ZW5DTEltYWdlUmVzdWx0KHNvdXJjZUltYWdlRGF0YS0+ZGF0YSgpKTsKKyAgICB9CisgICAgcmV0 dXJuIHRydWU7Cit9CisKK30gLy8gbmFtZXNwYWNlIFdlYkNvcmUKKworI2VuZGlmIC8vIEVOQUJM RShGSUxURVJTKSAmJiBFTkFCTEUoT1BFTkNMKQpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYkNvcmUv c3ZnL2dyYXBoaWNzL2ZpbHRlcnMvU1ZHRkVJbWFnZS5oIGIvU291cmNlL1dlYkNvcmUvc3ZnL2dy YXBoaWNzL2ZpbHRlcnMvU1ZHRkVJbWFnZS5oCmluZGV4IDg3ZTU4MzcuLjQ2YTg1M2MgMTAwNjQ0 Ci0tLSBhL1NvdXJjZS9XZWJDb3JlL3N2Zy9ncmFwaGljcy9maWx0ZXJzL1NWR0ZFSW1hZ2UuaAor KysgYi9Tb3VyY2UvV2ViQ29yZS9zdmcvZ3JhcGhpY3MvZmlsdGVycy9TVkdGRUltYWdlLmgKQEAg LTM5LDYgKzM5LDkgQEAgcHVibGljOgogICAgIHN0YXRpYyBQYXNzUmVmUHRyPEZFSW1hZ2U+IGNy ZWF0ZVdpdGhJUklSZWZlcmVuY2UoRmlsdGVyKiwgRG9jdW1lbnQqLCBjb25zdCBTdHJpbmcmLCBj b25zdCBTVkdQcmVzZXJ2ZUFzcGVjdFJhdGlvJik7CiAKICAgICB2aXJ0dWFsIHZvaWQgcGxhdGZv cm1BcHBseVNvZnR3YXJlKCk7CisjaWYgRU5BQkxFKE9QRU5DTCkKKyAgICB2aXJ0dWFsIGJvb2wg cGxhdGZvcm1BcHBseU9wZW5DTCgpOworI2VuZGlmCiAgICAgdmlydHVhbCB2b2lkIGR1bXAoKTsK IAogICAgIHZpcnR1YWwgdm9pZCBkZXRlcm1pbmVBYnNvbHV0ZVBhaW50UmVjdCgpOwo= 190044 2013-02-25 05:48:58 -0800 2013-02-27 02:00:19 -0800 proposed patch patch text/plain 4460 tczene ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZyBiL1NvdXJjZS9XZWJDb3JlL0No YW5nZUxvZwppbmRleCA0YzZhZjFmLi5mYjM2NWUyIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29y ZS9DaGFuZ2VMb2cKKysrIGIvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTkg QEAKKzIwMTMtMDItMjUgIFRhbWFzIEN6ZW5lICA8dGN6ZW5lQGluZi51LXN6ZWdlZC5odT4KKwor ICAgICAgICBPcGVuQ0wgaW1wbGVtZW50YXRpb24gb2YgRkVJbWFnZSBTVkcgRmlsdGVyLgorICAg ICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTEwNzUyCisKKyAg ICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgVGhpcyBpbXBsZW1l bnRhdGlvbiBydW5zIHRoZSBzb2Z0d2FyZSBtZXRob2QgYW5kIHRoZW4gaXQgdXBsb2FkcyB0aGUg cmVzdWx0cyB0byB0aGUgT3BlbkNMIGRldmljZS4KKworICAgICAgICAqIFRhcmdldC5wcmk6Cisg ICAgICAgICogcGxhdGZvcm0vZ3JhcGhpY3MvZ3B1L29wZW5jbC9PcGVuQ0xGRUltYWdlLmNwcDog QWRkZWQuCisgICAgICAgIChXZWJDb3JlKToKKyAgICAgICAgKFdlYkNvcmU6OkZFSW1hZ2U6OnBs YXRmb3JtQXBwbHlPcGVuQ0wpOgorICAgICAgICAqIHN2Zy9ncmFwaGljcy9maWx0ZXJzL1NWR0ZF SW1hZ2UuaDoKKyAgICAgICAgKEZFSW1hZ2UpOgorCiAyMDEzLTAyLTIwICBBbGV4ZXkgUHJvc2t1 cnlha292ICA8YXBAYXBwbGUuY29tPgogCiAgICAgICAgIFN0b3AgaGFyZGNvZGluZyBrbm93bGVk Z2UgYWJvdXQgYmxvYiBwcm90b2NvbCBpbiBSZXNvdXJjZUhhbmRsZQpkaWZmIC0tZ2l0IGEvU291 cmNlL1dlYkNvcmUvVGFyZ2V0LnByaSBiL1NvdXJjZS9XZWJDb3JlL1RhcmdldC5wcmkKaW5kZXgg OWEwOWEwNC4uODA4OTFjYSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvVGFyZ2V0LnByaQor KysgYi9Tb3VyY2UvV2ViQ29yZS9UYXJnZXQucHJpCkBAIC00MjM4LDYgKzQyMzgsNyBAQCBjb250 YWlucyhERUZJTkVTLCBFTkFCTEVfT1BFTkNMPTEpIHsKICAgICAgICAgcGxhdGZvcm0vZ3JhcGhp Y3MvZ3B1L29wZW5jbC9GaWx0ZXJDb250ZXh0T3BlbkNMLmNwcCBcCiAgICAgICAgIHBsYXRmb3Jt L2dyYXBoaWNzL2dwdS9vcGVuY2wvT3BlbkNMRkVDb2xvck1hdHJpeC5jcHAgXAogICAgICAgICBw bGF0Zm9ybS9ncmFwaGljcy9ncHUvb3BlbmNsL09wZW5DTEZFRmxvb2QuY3BwIFwKKyAgICAgICAg cGxhdGZvcm0vZ3JhcGhpY3MvZ3B1L29wZW5jbC9PcGVuQ0xGRUltYWdlLmNwcCBcCiAgICAgICAg IHBsYXRmb3JtL2dyYXBoaWNzL2dwdS9vcGVuY2wvT3BlbkNMRkVTb3VyY2VBbHBoYS5jcHAgXAog ICAgICAgICBwbGF0Zm9ybS9ncmFwaGljcy9ncHUvb3BlbmNsL09wZW5DTEZFU291cmNlR3JhcGhp Yy5jcHAgXAogICAgICAgICBwbGF0Zm9ybS9ncmFwaGljcy9ncHUvb3BlbmNsL09wZW5DTEZFVHVy YnVsZW5jZS5jcHAKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL2dyYXBoaWNz L2dwdS9vcGVuY2wvT3BlbkNMRkVJbWFnZS5jcHAgYi9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9n cmFwaGljcy9ncHUvb3BlbmNsL09wZW5DTEZFSW1hZ2UuY3BwCm5ldyBmaWxlIG1vZGUgMTAwNjQ0 CmluZGV4IDAwMDAwMDAuLjczNmE4NjIKLS0tIC9kZXYvbnVsbAorKysgYi9Tb3VyY2UvV2ViQ29y ZS9wbGF0Zm9ybS9ncmFwaGljcy9ncHUvb3BlbmNsL09wZW5DTEZFSW1hZ2UuY3BwCkBAIC0wLDAg KzEsNTEgQEAKKy8qCisgKiBDb3B5cmlnaHQgKEMpIDIwMTMgVW5pdmVyc2l0eSBvZiBTemVnZWQK KyAqIENvcHlyaWdodCAoQykgMjAxMyBUYW1hcyBDemVuZSA8dGN6ZW5lQGluZi51LXN6ZWdlZC5o dT4KKyAqIEFsbCByaWdodHMgcmVzZXJ2ZWQuCisgKgorICogUmVkaXN0cmlidXRpb24gYW5kIHVz ZSBpbiBzb3VyY2UgYW5kIGJpbmFyeSBmb3Jtcywgd2l0aCBvciB3aXRob3V0CisgKiBtb2RpZmlj YXRpb24sIGFyZSBwZXJtaXR0ZWQgcHJvdmlkZWQgdGhhdCB0aGUgZm9sbG93aW5nIGNvbmRpdGlv bnMKKyAqIGFyZSBtZXQ6CisgKiAxLiBSZWRpc3RyaWJ1dGlvbnMgb2Ygc291cmNlIGNvZGUgbXVz dCByZXRhaW4gdGhlIGFib3ZlIGNvcHlyaWdodAorICogICAgbm90aWNlLCB0aGlzIGxpc3Qgb2Yg Y29uZGl0aW9ucyBhbmQgdGhlIGZvbGxvd2luZyBkaXNjbGFpbWVyLgorICogMi4gUmVkaXN0cmli dXRpb25zIGluIGJpbmFyeSBmb3JtIG11c3QgcmVwcm9kdWNlIHRoZSBhYm92ZSBjb3B5cmlnaHQK KyAqICAgIG5vdGljZSwgdGhpcyBsaXN0IG9mIGNvbmRpdGlvbnMgYW5kIHRoZSBmb2xsb3dpbmcg ZGlzY2xhaW1lciBpbiB0aGUKKyAqICAgIGRvY3VtZW50YXRpb24gYW5kL29yIG90aGVyIG1hdGVy aWFscyBwcm92aWRlZCB3aXRoIHRoZSBkaXN0cmlidXRpb24uCisgKgorICogVEhJUyBTT0ZUV0FS RSBJUyBQUk9WSURFRCBCWSBVTklWRVJTSVRZIE9GIFNaRUdFRCBgYEFTIElTJycgQU5EIEFOWQor ICogRVhQUkVTUyBPUiBJTVBMSUVEIFdBUlJBTlRJRVMsIElOQ0xVRElORywgQlVUIE5PVCBMSU1J VEVEIFRPLCBUSEUKKyAqIElNUExJRUQgV0FSUkFOVElFUyBPRiBNRVJDSEFOVEFCSUxJVFkgQU5E IEZJVE5FU1MgRk9SIEEgUEFSVElDVUxBUgorICogUFVSUE9TRSBBUkUgRElTQ0xBSU1FRC4gIElO IE5PIEVWRU5UIFNIQUxMIFVOSVZFUlNJVFkgT0YgU1pFR0VEIE9SCisgKiBDT05UUklCVVRPUlMg QkUgTElBQkxFIEZPUiBBTlkgRElSRUNULCBJTkRJUkVDVCwgSU5DSURFTlRBTCwgU1BFQ0lBTCwK KyAqIEVYRU1QTEFSWSwgT1IgQ09OU0VRVUVOVElBTCBEQU1BR0VTIChJTkNMVURJTkcsIEJVVCBO T1QgTElNSVRFRCBUTywKKyAqIFBST0NVUkVNRU5UIE9GIFNVQlNUSVRVVEUgR09PRFMgT1IgU0VS VklDRVM7IExPU1MgT0YgVVNFLCBEQVRBLCBPUgorICogUFJPRklUUzsgT1IgQlVTSU5FU1MgSU5U RVJSVVBUSU9OKSBIT1dFVkVSIENBVVNFRCBBTkQgT04gQU5ZIFRIRU9SWQorICogT0YgTElBQklM SVRZLCBXSEVUSEVSIElOIENPTlRSQUNULCBTVFJJQ1QgTElBQklMSVRZLCBPUiBUT1JUCisgKiAo SU5DTFVESU5HIE5FR0xJR0VOQ0UgT1IgT1RIRVJXSVNFKSBBUklTSU5HIElOIEFOWSBXQVkgT1VU IE9GIFRIRSBVU0UKKyAqIE9GIFRISVMgU09GVFdBUkUsIEVWRU4gSUYgQURWSVNFRCBPRiBUSEUg UE9TU0lCSUxJVFkgT0YgU1VDSCBEQU1BR0UuCisgKi8KKworI2luY2x1ZGUgImNvbmZpZy5oIgor I2lmIEVOQUJMRShGSUxURVJTKSAmJiBFTkFCTEUoT1BFTkNMKQorCisjaW5jbHVkZSAiRmlsdGVy Q29udGV4dE9wZW5DTC5oIgorI2luY2x1ZGUgIlNWR0ZFSW1hZ2UuaCIKKyNpbmNsdWRlICJTVkdG aWx0ZXIuaCIKKyNpbmNsdWRlICJTaGFyZWRCdWZmZXIuaCIKKworbmFtZXNwYWNlIFdlYkNvcmUg eworCitib29sIEZFSW1hZ2U6OnBsYXRmb3JtQXBwbHlPcGVuQ0woKQoreworICAgIHBsYXRmb3Jt QXBwbHlTb2Z0d2FyZSgpOworICAgIEltYWdlQnVmZmVyKiBzb3VyY2VJbWFnZSA9IGFzSW1hZ2VC dWZmZXIoKTsKKyAgICBpZiAoc291cmNlSW1hZ2UpIHsKKyAgICAgICAgUmVmUHRyPFVpbnQ4Q2xh bXBlZEFycmF5PiBzb3VyY2VJbWFnZURhdGEgPSBzb3VyY2VJbWFnZS0+Z2V0VW5tdWx0aXBsaWVk SW1hZ2VEYXRhKEludFJlY3QoSW50UG9pbnQoKSwgc291cmNlSW1hZ2UtPmludGVybmFsU2l6ZSgp KSk7CisgICAgICAgIGNyZWF0ZU9wZW5DTEltYWdlUmVzdWx0KHNvdXJjZUltYWdlRGF0YS0+ZGF0 YSgpKTsKKyAgICB9CisgICAgcmV0dXJuIHRydWU7Cit9CisKK30gLy8gbmFtZXNwYWNlIFdlYkNv cmUKKworI2VuZGlmIC8vIEVOQUJMRShGSUxURVJTKSAmJiBFTkFCTEUoT1BFTkNMKQpkaWZmIC0t Z2l0IGEvU291cmNlL1dlYkNvcmUvc3ZnL2dyYXBoaWNzL2ZpbHRlcnMvU1ZHRkVJbWFnZS5oIGIv U291cmNlL1dlYkNvcmUvc3ZnL2dyYXBoaWNzL2ZpbHRlcnMvU1ZHRkVJbWFnZS5oCmluZGV4IDg3 ZTU4MzcuLjQ2YTg1M2MgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJDb3JlL3N2Zy9ncmFwaGljcy9m aWx0ZXJzL1NWR0ZFSW1hZ2UuaAorKysgYi9Tb3VyY2UvV2ViQ29yZS9zdmcvZ3JhcGhpY3MvZmls dGVycy9TVkdGRUltYWdlLmgKQEAgLTM5LDYgKzM5LDkgQEAgcHVibGljOgogICAgIHN0YXRpYyBQ YXNzUmVmUHRyPEZFSW1hZ2U+IGNyZWF0ZVdpdGhJUklSZWZlcmVuY2UoRmlsdGVyKiwgRG9jdW1l bnQqLCBjb25zdCBTdHJpbmcmLCBjb25zdCBTVkdQcmVzZXJ2ZUFzcGVjdFJhdGlvJik7CiAKICAg ICB2aXJ0dWFsIHZvaWQgcGxhdGZvcm1BcHBseVNvZnR3YXJlKCk7CisjaWYgRU5BQkxFKE9QRU5D TCkKKyAgICB2aXJ0dWFsIGJvb2wgcGxhdGZvcm1BcHBseU9wZW5DTCgpOworI2VuZGlmCiAgICAg dmlydHVhbCB2b2lkIGR1bXAoKTsKIAogICAgIHZpcnR1YWwgdm9pZCBkZXRlcm1pbmVBYnNvbHV0 ZVBhaW50UmVjdCgpOwo= 190472 2013-02-27 02:00:19 -0800 2013-02-28 03:52:27 -0800 proposed patch patch text/plain 4454 tczene ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZyBiL1NvdXJjZS9XZWJDb3JlL0No YW5nZUxvZwppbmRleCAyOTkwNzE1Li42MmY1NzdmIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29y ZS9DaGFuZ2VMb2cKKysrIGIvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTkg QEAKKzIwMTMtMDItMjcgIFRhbWFzIEN6ZW5lICA8dGN6ZW5lQGluZi51LXN6ZWdlZC5odT4KKwor ICAgICAgICBPcGVuQ0wgaW1wbGVtZW50YXRpb24gb2YgRkVJbWFnZSBTVkcgRmlsdGVyLgorICAg ICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTEwNzUyCisKKyAg ICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgVGhlIHJlc3VsdCBv ZiB0aGUgaW1hZ2UgaXMgdXBsb2FkZWQgdG8gYW4gT3BlbkNMIGJ1ZmZlci4KKworICAgICAgICAq IFRhcmdldC5wcmk6CisgICAgICAgICogcGxhdGZvcm0vZ3JhcGhpY3MvZ3B1L29wZW5jbC9PcGVu Q0xGRUltYWdlLmNwcDogQWRkZWQuCisgICAgICAgIChXZWJDb3JlKToKKyAgICAgICAgKFdlYkNv cmU6OkZFSW1hZ2U6OnBsYXRmb3JtQXBwbHlPcGVuQ0wpOgorICAgICAgICAqIHN2Zy9ncmFwaGlj cy9maWx0ZXJzL1NWR0ZFSW1hZ2UuaDoKKyAgICAgICAgKEZFSW1hZ2UpOgorCiAyMDEzLTAyLTI3 ICBBZGFtIEJhcnRoICA8YWJhcnRoQHdlYmtpdC5vcmc+CiAKICAgICAgICAgSFRNTERvY3VtZW50 UGFyc2VyOjpkaWRSZWNlaXZlUGFyc2VkQ2h1bmtGcm9tQmFja2dyb3VuZFBhcnNlciBjYW4gdHJp Z2dlciBBU1NFUlQobV9zcGVjdWxhdGlvbnMuaXNFbXB0eSgpKQpkaWZmIC0tZ2l0IGEvU291cmNl L1dlYkNvcmUvVGFyZ2V0LnByaSBiL1NvdXJjZS9XZWJDb3JlL1RhcmdldC5wcmkKaW5kZXggMzQ0 ODliOS4uZDYwNzkxMiAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvVGFyZ2V0LnByaQorKysg Yi9Tb3VyY2UvV2ViQ29yZS9UYXJnZXQucHJpCkBAIC00MjMzLDYgKzQyMzMsNyBAQCBjb250YWlu cyhERUZJTkVTLCBFTkFCTEVfT1BFTkNMPTEpIHsKICAgICAgICAgcGxhdGZvcm0vZ3JhcGhpY3Mv Z3B1L29wZW5jbC9GaWx0ZXJDb250ZXh0T3BlbkNMLmNwcCBcCiAgICAgICAgIHBsYXRmb3JtL2dy YXBoaWNzL2dwdS9vcGVuY2wvT3BlbkNMRkVDb2xvck1hdHJpeC5jcHAgXAogICAgICAgICBwbGF0 Zm9ybS9ncmFwaGljcy9ncHUvb3BlbmNsL09wZW5DTEZFRmxvb2QuY3BwIFwKKyAgICAgICAgcGxh dGZvcm0vZ3JhcGhpY3MvZ3B1L29wZW5jbC9PcGVuQ0xGRUltYWdlLmNwcCBcCiAgICAgICAgIHBs YXRmb3JtL2dyYXBoaWNzL2dwdS9vcGVuY2wvT3BlbkNMRkVNZXJnZS5jcHAgXAogICAgICAgICBw bGF0Zm9ybS9ncmFwaGljcy9ncHUvb3BlbmNsL09wZW5DTEZFU291cmNlQWxwaGEuY3BwIFwKICAg ICAgICAgcGxhdGZvcm0vZ3JhcGhpY3MvZ3B1L29wZW5jbC9PcGVuQ0xGRVNvdXJjZUdyYXBoaWMu Y3BwIFwKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL2dyYXBoaWNzL2dwdS9v cGVuY2wvT3BlbkNMRkVJbWFnZS5jcHAgYi9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9ncmFwaGlj cy9ncHUvb3BlbmNsL09wZW5DTEZFSW1hZ2UuY3BwCm5ldyBmaWxlIG1vZGUgMTAwNjQ0CmluZGV4 IDAwMDAwMDAuLjczNmE4NjIKLS0tIC9kZXYvbnVsbAorKysgYi9Tb3VyY2UvV2ViQ29yZS9wbGF0 Zm9ybS9ncmFwaGljcy9ncHUvb3BlbmNsL09wZW5DTEZFSW1hZ2UuY3BwCkBAIC0wLDAgKzEsNTEg QEAKKy8qCisgKiBDb3B5cmlnaHQgKEMpIDIwMTMgVW5pdmVyc2l0eSBvZiBTemVnZWQKKyAqIENv cHlyaWdodCAoQykgMjAxMyBUYW1hcyBDemVuZSA8dGN6ZW5lQGluZi51LXN6ZWdlZC5odT4KKyAq IEFsbCByaWdodHMgcmVzZXJ2ZWQuCisgKgorICogUmVkaXN0cmlidXRpb24gYW5kIHVzZSBpbiBz b3VyY2UgYW5kIGJpbmFyeSBmb3Jtcywgd2l0aCBvciB3aXRob3V0CisgKiBtb2RpZmljYXRpb24s IGFyZSBwZXJtaXR0ZWQgcHJvdmlkZWQgdGhhdCB0aGUgZm9sbG93aW5nIGNvbmRpdGlvbnMKKyAq IGFyZSBtZXQ6CisgKiAxLiBSZWRpc3RyaWJ1dGlvbnMgb2Ygc291cmNlIGNvZGUgbXVzdCByZXRh aW4gdGhlIGFib3ZlIGNvcHlyaWdodAorICogICAgbm90aWNlLCB0aGlzIGxpc3Qgb2YgY29uZGl0 aW9ucyBhbmQgdGhlIGZvbGxvd2luZyBkaXNjbGFpbWVyLgorICogMi4gUmVkaXN0cmlidXRpb25z IGluIGJpbmFyeSBmb3JtIG11c3QgcmVwcm9kdWNlIHRoZSBhYm92ZSBjb3B5cmlnaHQKKyAqICAg IG5vdGljZSwgdGhpcyBsaXN0IG9mIGNvbmRpdGlvbnMgYW5kIHRoZSBmb2xsb3dpbmcgZGlzY2xh aW1lciBpbiB0aGUKKyAqICAgIGRvY3VtZW50YXRpb24gYW5kL29yIG90aGVyIG1hdGVyaWFscyBw cm92aWRlZCB3aXRoIHRoZSBkaXN0cmlidXRpb24uCisgKgorICogVEhJUyBTT0ZUV0FSRSBJUyBQ Uk9WSURFRCBCWSBVTklWRVJTSVRZIE9GIFNaRUdFRCBgYEFTIElTJycgQU5EIEFOWQorICogRVhQ UkVTUyBPUiBJTVBMSUVEIFdBUlJBTlRJRVMsIElOQ0xVRElORywgQlVUIE5PVCBMSU1JVEVEIFRP LCBUSEUKKyAqIElNUExJRUQgV0FSUkFOVElFUyBPRiBNRVJDSEFOVEFCSUxJVFkgQU5EIEZJVE5F U1MgRk9SIEEgUEFSVElDVUxBUgorICogUFVSUE9TRSBBUkUgRElTQ0xBSU1FRC4gIElOIE5PIEVW RU5UIFNIQUxMIFVOSVZFUlNJVFkgT0YgU1pFR0VEIE9SCisgKiBDT05UUklCVVRPUlMgQkUgTElB QkxFIEZPUiBBTlkgRElSRUNULCBJTkRJUkVDVCwgSU5DSURFTlRBTCwgU1BFQ0lBTCwKKyAqIEVY RU1QTEFSWSwgT1IgQ09OU0VRVUVOVElBTCBEQU1BR0VTIChJTkNMVURJTkcsIEJVVCBOT1QgTElN SVRFRCBUTywKKyAqIFBST0NVUkVNRU5UIE9GIFNVQlNUSVRVVEUgR09PRFMgT1IgU0VSVklDRVM7 IExPU1MgT0YgVVNFLCBEQVRBLCBPUgorICogUFJPRklUUzsgT1IgQlVTSU5FU1MgSU5URVJSVVBU SU9OKSBIT1dFVkVSIENBVVNFRCBBTkQgT04gQU5ZIFRIRU9SWQorICogT0YgTElBQklMSVRZLCBX SEVUSEVSIElOIENPTlRSQUNULCBTVFJJQ1QgTElBQklMSVRZLCBPUiBUT1JUCisgKiAoSU5DTFVE SU5HIE5FR0xJR0VOQ0UgT1IgT1RIRVJXSVNFKSBBUklTSU5HIElOIEFOWSBXQVkgT1VUIE9GIFRI RSBVU0UKKyAqIE9GIFRISVMgU09GVFdBUkUsIEVWRU4gSUYgQURWSVNFRCBPRiBUSEUgUE9TU0lC SUxJVFkgT0YgU1VDSCBEQU1BR0UuCisgKi8KKworI2luY2x1ZGUgImNvbmZpZy5oIgorI2lmIEVO QUJMRShGSUxURVJTKSAmJiBFTkFCTEUoT1BFTkNMKQorCisjaW5jbHVkZSAiRmlsdGVyQ29udGV4 dE9wZW5DTC5oIgorI2luY2x1ZGUgIlNWR0ZFSW1hZ2UuaCIKKyNpbmNsdWRlICJTVkdGaWx0ZXIu aCIKKyNpbmNsdWRlICJTaGFyZWRCdWZmZXIuaCIKKworbmFtZXNwYWNlIFdlYkNvcmUgeworCiti b29sIEZFSW1hZ2U6OnBsYXRmb3JtQXBwbHlPcGVuQ0woKQoreworICAgIHBsYXRmb3JtQXBwbHlT b2Z0d2FyZSgpOworICAgIEltYWdlQnVmZmVyKiBzb3VyY2VJbWFnZSA9IGFzSW1hZ2VCdWZmZXIo KTsKKyAgICBpZiAoc291cmNlSW1hZ2UpIHsKKyAgICAgICAgUmVmUHRyPFVpbnQ4Q2xhbXBlZEFy cmF5PiBzb3VyY2VJbWFnZURhdGEgPSBzb3VyY2VJbWFnZS0+Z2V0VW5tdWx0aXBsaWVkSW1hZ2VE YXRhKEludFJlY3QoSW50UG9pbnQoKSwgc291cmNlSW1hZ2UtPmludGVybmFsU2l6ZSgpKSk7Cisg ICAgICAgIGNyZWF0ZU9wZW5DTEltYWdlUmVzdWx0KHNvdXJjZUltYWdlRGF0YS0+ZGF0YSgpKTsK KyAgICB9CisgICAgcmV0dXJuIHRydWU7Cit9CisKK30gLy8gbmFtZXNwYWNlIFdlYkNvcmUKKwor I2VuZGlmIC8vIEVOQUJMRShGSUxURVJTKSAmJiBFTkFCTEUoT1BFTkNMKQpkaWZmIC0tZ2l0IGEv U291cmNlL1dlYkNvcmUvc3ZnL2dyYXBoaWNzL2ZpbHRlcnMvU1ZHRkVJbWFnZS5oIGIvU291cmNl L1dlYkNvcmUvc3ZnL2dyYXBoaWNzL2ZpbHRlcnMvU1ZHRkVJbWFnZS5oCmluZGV4IDg3ZTU4Mzcu LjQ2YTg1M2MgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJDb3JlL3N2Zy9ncmFwaGljcy9maWx0ZXJz L1NWR0ZFSW1hZ2UuaAorKysgYi9Tb3VyY2UvV2ViQ29yZS9zdmcvZ3JhcGhpY3MvZmlsdGVycy9T VkdGRUltYWdlLmgKQEAgLTM5LDYgKzM5LDkgQEAgcHVibGljOgogICAgIHN0YXRpYyBQYXNzUmVm UHRyPEZFSW1hZ2U+IGNyZWF0ZVdpdGhJUklSZWZlcmVuY2UoRmlsdGVyKiwgRG9jdW1lbnQqLCBj b25zdCBTdHJpbmcmLCBjb25zdCBTVkdQcmVzZXJ2ZUFzcGVjdFJhdGlvJik7CiAKICAgICB2aXJ0 dWFsIHZvaWQgcGxhdGZvcm1BcHBseVNvZnR3YXJlKCk7CisjaWYgRU5BQkxFKE9QRU5DTCkKKyAg ICB2aXJ0dWFsIGJvb2wgcGxhdGZvcm1BcHBseU9wZW5DTCgpOworI2VuZGlmCiAgICAgdmlydHVh bCB2b2lkIGR1bXAoKTsKIAogICAgIHZpcnR1YWwgdm9pZCBkZXRlcm1pbmVBYnNvbHV0ZVBhaW50 UmVjdCgpOwo=