<?xml version="1.0" encoding="UTF-8" standalone="yes" ?>
<!DOCTYPE bugzilla SYSTEM "https://bugs.webkit.org/page.cgi?id=bugzilla.dtd">

<bugzilla version="5.0.4.1"
          urlbase="https://bugs.webkit.org/"
          
          maintainer="admin@webkit.org"
>

    <bug>
          <bug_id>110349</bug_id>
          
          <creation_ts>2013-02-20 07:32:21 -0800</creation_ts>
          <short_desc>[css exclusions] overflow:hidden undoes shape-outside offsets</short_desc>
          <delta_ts>2013-04-02 11:08:40 -0700</delta_ts>
          <reporter_accessible>1</reporter_accessible>
          <cclist_accessible>1</cclist_accessible>
          <classification_id>1</classification_id>
          <classification>Unclassified</classification>
          <product>WebKit</product>
          <component>CSS</component>
          <version>528+ (Nightly build)</version>
          <rep_platform>Unspecified</rep_platform>
          <op_sys>Unspecified</op_sys>
          <bug_status>RESOLVED</bug_status>
          <resolution>FIXED</resolution>
          
          
          <bug_file_loc>http://codepen.io/btravis/pen/HuecB</bug_file_loc>
          <status_whiteboard></status_whiteboard>
          <keywords></keywords>
          <priority>P2</priority>
          <bug_severity>Normal</bug_severity>
          <target_milestone>---</target_milestone>
          
          <blocked>98664</blocked>
          <everconfirmed>1</everconfirmed>
          <reporter name="Bear Travis">betravis</reporter>
          <assigned_to name="Bem Jones-Bey">bjonesbe</assigned_to>
          <cc>bjonesbe</cc>
    
    <cc>eric</cc>
    
    <cc>esprehn+autocc</cc>
    
    <cc>gtk-ews</cc>
    
    <cc>ojan.autocc</cc>
    
    <cc>simon.fraser</cc>
    
    <cc>webkit.review.bot</cc>
    
    <cc>xan.lopez</cc>
          

      

      

      

          <comment_sort_order>oldest_to_newest</comment_sort_order>  
          <long_desc isprivate="0" >
    <commentid>837461</commentid>
    <comment_count>0</comment_count>
    <who name="Bear Travis">betravis</who>
    <bug_when>2013-02-20 07:32:21 -0800</bug_when>
    <thetext>Setting overflow:hidden, float: left, and shape-outside: rectangle does not offset correctly.
See link for an example.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>857626</commentid>
    <comment_count>1</comment_count>
    <who name="Bem Jones-Bey">bjonesbe</who>
    <bug_when>2013-03-18 15:21:20 -0700</bug_when>
    <thetext>It looks like the shape is still handled normally, but the offset for the content of the float is no longer handled properly when overflow is hidden. Still very strange, but it is comforting that the wrapping behavior doesn&apos;t change in this case.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>866367</commentid>
    <comment_count>2</comment_count>
      <attachid>195798</attachid>
    <who name="Bem Jones-Bey">bjonesbe</who>
    <bug_when>2013-03-29 14:13:42 -0700</bug_when>
    <thetext>Created attachment 195798
Patch

Fix layer handling for overflow hidden and shapes</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>866426</commentid>
    <comment_count>3</comment_count>
      <attachid>195798</attachid>
    <who name="kov&apos;s GTK+ EWS bot">gtk-ews</who>
    <bug_when>2013-03-29 15:20:15 -0700</bug_when>
    <thetext>Comment on attachment 195798
Patch

Attachment 195798 did not pass gtk-ews (gtk):
Output: http://webkit-commit-queue.appspot.com/results/17369111</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>866436</commentid>
    <comment_count>4</comment_count>
      <attachid>195798</attachid>
    <who name="Bem Jones-Bey">bjonesbe</who>
    <bug_when>2013-03-29 15:35:36 -0700</bug_when>
    <thetext>Comment on attachment 195798
Patch

Since the GTK build bots are completely broken right now and the GTK EWS bot&apos;s output doesn&apos;t have any error whatsoever that&apos;s related to my patch, I contend that it&apos;s failure is entirely unrelated to my patch. So I&apos;m going to put the cq? back.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>867374</commentid>
    <comment_count>5</comment_count>
      <attachid>195798</attachid>
    <who name="Julien Chaffraix">jchaffraix</who>
    <bug_when>2013-04-01 14:52:13 -0700</bug_when>
    <thetext>Comment on attachment 195798
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=195798&amp;action=review

&gt; Source/WebCore/rendering/RenderLayer.cpp:5850
&gt; +            &amp;&amp; !(renderer()-&gt;style()-&gt;shapeOutside() &amp;&amp; renderer()-&gt;isFloating());

RenderObject::isFloating is probably cheaper to evaluate so you would be better off changing the order.

This starts to be a pattern in the code where you check renderer()-&gt;style()-&gt;shapeOutside() &amp;&amp; renderer()-&gt;isFloating() so it should be refactored into its own helper method.

&gt; LayoutTests/fast/exclusions/shape-outside-floats/shape-outside-floats-overflow-hidden-expected.html:1
&gt; +&lt;html&gt;

No doctype!

&gt; LayoutTests/fast/exclusions/shape-outside-floats/shape-outside-floats-overflow-hidden-expected.html:8
&gt; +  background-color: red;

Let&apos;s not put any red in the expected result as it would make the test pass, even if you are saying we shouldn&apos;t see any red.

&gt; LayoutTests/fast/exclusions/shape-outside-floats/shape-outside-floats-overflow-hidden.html:1
&gt; +&lt;html&gt;

Same comment.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>867609</commentid>
    <comment_count>6</comment_count>
      <attachid>195798</attachid>
    <who name="Build Bot">buildbot</who>
    <bug_when>2013-04-01 23:54:59 -0700</bug_when>
    <thetext>Comment on attachment 195798
Patch

Attachment 195798 did not pass win-ews (win):
Output: http://webkit-commit-queue.appspot.com/results/17405042</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>867986</commentid>
    <comment_count>7</comment_count>
    <who name="Bem Jones-Bey">bjonesbe</who>
    <bug_when>2013-04-02 10:22:09 -0700</bug_when>
    <thetext>(In reply to comment #5)
&gt; This starts to be a pattern in the code where you check renderer()-&gt;style()-&gt;shapeOutside() &amp;&amp; renderer()-&gt;isFloating() so it should be refactored into its own helper method.

Doing this right involves a bunch more changes than I am confortable including in this patch right now, so I&apos;ve filed Bug 113799 to do the refactoring. (I did the straightforward change, and introduced a crash, so I figure that I need to spend more time on it)</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>867999</commentid>
    <comment_count>8</comment_count>
      <attachid>196176</attachid>
    <who name="Bem Jones-Bey">bjonesbe</who>
    <bug_when>2013-04-02 10:40:59 -0700</bug_when>
    <thetext>Created attachment 196176
Patch

Update for review comments</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>868007</commentid>
    <comment_count>9</comment_count>
      <attachid>196176</attachid>
    <who name="Max Vujovic">mvujovic</who>
    <bug_when>2013-04-02 10:47:11 -0700</bug_when>
    <thetext>Comment on attachment 196176
Patch

Setting cq+ for Bem.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>868062</commentid>
    <comment_count>10</comment_count>
      <attachid>196176</attachid>
    <who name="WebKit Review Bot">webkit.review.bot</who>
    <bug_when>2013-04-02 11:08:36 -0700</bug_when>
    <thetext>Comment on attachment 196176
Patch

Clearing flags on attachment: 196176

Committed r147463: &lt;http://trac.webkit.org/changeset/147463&gt;</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>868063</commentid>
    <comment_count>11</comment_count>
    <who name="WebKit Review Bot">webkit.review.bot</who>
    <bug_when>2013-04-02 11:08:40 -0700</bug_when>
    <thetext>All reviewed patches have been landed.  Closing bug.</thetext>
  </long_desc>
      
          <attachment
              isobsolete="1"
              ispatch="1"
              isprivate="0"
          >
            <attachid>195798</attachid>
            <date>2013-03-29 14:13:42 -0700</date>
            <delta_ts>2013-04-02 10:41:18 -0700</delta_ts>
            <desc>Patch</desc>
            <filename>bug-110349-20130329141338.patch</filename>
            <type>text/plain</type>
            <size>5837</size>
            <attacher name="Bem Jones-Bey">bjonesbe</attacher>
            
              <data encoding="base64">U3VidmVyc2lvbiBSZXZpc2lvbjogMTQ3MjI3CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D
aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggNmRjNWFjOGNmODcxYzM3
NzdjNWYxNzBmYjE1MjgzNzZhY2NiODkzZS4uZGNkYzlhZjMzZjk1ZTBjYjg1YWY4ZDZkYjRhNTI0
ZmVhMjE5MzRlMyAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv
dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDI1IEBACisyMDEzLTAzLTI5ICBCZW0g
Sm9uZXMtQmV5ICA8YmpvbmVzYmVAYWRvYmUuY29tPgorCisgICAgICAgIFtjc3MgZXhjbHVzaW9u
c10gb3ZlcmZsb3c6aGlkZGVuIHVuZG9lcyBzaGFwZS1vdXRzaWRlIG9mZnNldHMKKyAgICAgICAg
aHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTExMDM0OQorCisgICAgICAg
IFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIFdoZW4gb3ZlcmZsb3c6IGhp
ZGRlbiB3YXMgc2V0IG9uIGEgZmxvYXQgd2l0aCBzaGFwZS1vdXRzaWRlLCB0aGUKKyAgICAgICAg
b2Zmc2V0IGZyb20gdGhlIHNoYXBlLW91dHNpZGUgd2FzIGJlaW5nIGlnbm9yZWQuIFRoaXMgd2Fz
IGJlY2F1c2UgdGhlCisgICAgICAgIGZsb2F0IHdhcyBiZWluZyBwbGFjZWQgaW4gdGhlIG5vcm1h
bCBmbG93LCBjYXVzaW5nIHRoZSBvZmZzZXRzIHRvIGJlCisgICAgICAgIGNhbGN1bGF0ZWQgZGlm
ZmVyZW50bHkuIFNpbmNlIGZsb2F0cyB3aXRoIHNoYXBlIG91dHNpZGUgYmVoYXZlIGxpa2UKKyAg
ICAgICAgcG9zaXRpb25lZCBvYmplY3RzIGluIG1hbnkgcGxhY2VzLCBJIGhhdmUgY2F1c2VkIHRo
ZW0gdG8gdGFrZSB0aGUgc2FtZQorICAgICAgICBiZWhhdmlvciBhcyBwb3NpdGlvbmVkIG9iamVj
dHMgaW4gdGhpcyBjYXNlIGFzIHdlbGw6IHRoZSBmbG9hdHMgd2l0aAorICAgICAgICBzaGFwZS1v
dXRzaWRlIGRvIG5vdCBnZXQgcGxhY2VkIGluIHRoZSBub3JtYWwgZmxvdyB3aGVuIG92ZXJmbG93
OgorICAgICAgICBoaWRkZW4gaXMgc2V0LgorCisgICAgICAgIFRlc3Q6IGZhc3QvZXhjbHVzaW9u
cy9zaGFwZS1vdXRzaWRlLWZsb2F0cy9zaGFwZS1vdXRzaWRlLWZsb2F0cy1vdmVyZmxvdy1oaWRk
ZW4uaHRtbAorCisgICAgICAgICogcmVuZGVyaW5nL1JlbmRlckxheWVyLmNwcDoKKyAgICAgICAg
KFdlYkNvcmU6OlJlbmRlckxheWVyOjpzaG91bGRCZU5vcm1hbEZsb3dPbmx5KTogRmxvYXRzIHRo
YXQgaGF2ZQorICAgICAgICAgICAgc2hhcGUtb3V0c2lkZSBzaG91bGQgbm90IGJlIGluIHRoZSBu
b3JtYWwgZmxvdy4KKwogMjAxMy0wMy0yOSAgVnNldm9sb2QgVmxhc292ICA8dnNldmlrQGNocm9t
aXVtLm9yZz4KIAogICAgICAgICBXZWIgSW5zcGVjdG9yOiBDb250ZW50IHNob3VsZCBub3QgYmUg
bG9zdCB3aGVuIHVpU291cmNlQ29kZSdzIGZpbGUgd2FzIHJlbW92ZWQgZXh0ZXJuYWxseSBvbiBm
aWxlIHN5c3RlbS4KZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL3JlbmRlcmluZy9SZW5kZXJM
YXllci5jcHAgYi9Tb3VyY2UvV2ViQ29yZS9yZW5kZXJpbmcvUmVuZGVyTGF5ZXIuY3BwCmluZGV4
IDE5ODU0ZDBjM2I1MmQ5ODgzMmI1MThmZWJiZDQyODRhMzk5MDVlZTQuLjE5OWE2ZTQ5YjlmNDVm
OWM3ZjQ4Mzc5ZGFmMzFhOTUyNjQ2ZThhOWIgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJDb3JlL3Jl
bmRlcmluZy9SZW5kZXJMYXllci5jcHAKKysrIGIvU291cmNlL1dlYkNvcmUvcmVuZGVyaW5nL1Jl
bmRlckxheWVyLmNwcApAQCAtNTg0NSw3ICs1ODQ1LDEwIEBAIGJvb2wgUmVuZGVyTGF5ZXI6OnNo
b3VsZEJlTm9ybWFsRmxvd09ubHkoKSBjb25zdAogICAgICAgICAgICAgJiYgIXJlbmRlcmVyKCkt
Pmhhc0JsZW5kTW9kZSgpCiAjZW5kaWYKICAgICAgICAgICAgICYmICFpc1RyYW5zcGFyZW50KCkK
LSAgICAgICAgICAgICYmICFuZWVkc0NvbXBvc2l0ZWRTY3JvbGxpbmcoKTsKKyAgICAgICAgICAg
ICYmICFuZWVkc0NvbXBvc2l0ZWRTY3JvbGxpbmcoKQorI2lmIEVOQUJMRShDU1NfRVhDTFVTSU9O
UykKKyAgICAgICAgICAgICYmICEocmVuZGVyZXIoKS0+c3R5bGUoKS0+c2hhcGVPdXRzaWRlKCkg
JiYgcmVuZGVyZXIoKS0+aXNGbG9hdGluZygpKTsKKyNlbmRpZgogfQogCiBib29sIFJlbmRlckxh
eWVyOjpzaG91bGRCZVNlbGZQYWludGluZ0xheWVyKCkgY29uc3QKZGlmZiAtLWdpdCBhL0xheW91
dFRlc3RzL0NoYW5nZUxvZyBiL0xheW91dFRlc3RzL0NoYW5nZUxvZwppbmRleCBmNzc5MDVlMDA3
ZDdiNDkzM2VmOTZjNmE4Y2Y1MTY1ODdmY2E0ODVhLi4wZDA3YTcyMjc1ZDQyM2Q0OGUzMzczM2Jm
ODk4NWVkNWNlOGFiMTg1IDEwMDY0NAotLS0gYS9MYXlvdXRUZXN0cy9DaGFuZ2VMb2cKKysrIGIv
TGF5b3V0VGVzdHMvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTYgQEAKKzIwMTMtMDMtMjkgIEJlbSBK
b25lcy1CZXkgIDxiam9uZXNiZUBhZG9iZS5jb20+CisKKyAgICAgICAgW2NzcyBleGNsdXNpb25z
XSBvdmVyZmxvdzpoaWRkZW4gdW5kb2VzIHNoYXBlLW91dHNpZGUgb2Zmc2V0cworICAgICAgICBo
dHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTEwMzQ5CisKKyAgICAgICAg
UmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgQWRkIGEgdGVzdCB0byBtYWtl
IHN1cmUgdGhlIGZsb2F0IGlzIHByb3Blcmx5IHBvc2l0aW9uZWQgd2l0aAorICAgICAgICBvdmVy
ZmxvdzogaGlkZGVuLgorCisgICAgICAgICogZmFzdC9leGNsdXNpb25zL3NoYXBlLW91dHNpZGUt
ZmxvYXRzL3NoYXBlLW91dHNpZGUtZmxvYXRzLW92ZXJmbG93LWhpZGRlbi1leHBlY3RlZC5odG1s
OiBBZGRlZC4KKyAgICAgICAgKiBmYXN0L2V4Y2x1c2lvbnMvc2hhcGUtb3V0c2lkZS1mbG9hdHMv
c2hhcGUtb3V0c2lkZS1mbG9hdHMtb3ZlcmZsb3ctaGlkZGVuLmh0bWw6IEFkZGVkLgorCiAyMDEz
LTAzLTI5ICBab2x0YW4gQXJ2YWkgIDx6YXJ2YWlAaW5mLnUtc3plZ2VkLmh1PgogCiAgICAgICAg
IFtRdF0gVW5yZXZpZXdlZCBnYXJkbmVpbmcuIFVwZGF0ZWQgcG5nIGV4cGVjdGVkIHJlc3VsdHMg
YWZ0ZXIgcjE0NjIwNi4KZGlmZiAtLWdpdCBhL0xheW91dFRlc3RzL2Zhc3QvZXhjbHVzaW9ucy9z
aGFwZS1vdXRzaWRlLWZsb2F0cy9zaGFwZS1vdXRzaWRlLWZsb2F0cy1vdmVyZmxvdy1oaWRkZW4t
ZXhwZWN0ZWQuaHRtbCBiL0xheW91dFRlc3RzL2Zhc3QvZXhjbHVzaW9ucy9zaGFwZS1vdXRzaWRl
LWZsb2F0cy9zaGFwZS1vdXRzaWRlLWZsb2F0cy1vdmVyZmxvdy1oaWRkZW4tZXhwZWN0ZWQuaHRt
bApuZXcgZmlsZSBtb2RlIDEwMDY0NAppbmRleCAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAw
MDAwMDAwMDAwMDAwLi5jZGU5OGUzNzc5OGQ3NzI2MWFhMWNkNGZhODdlYzU5YmU2NmRiYjIyCi0t
LSAvZGV2L251bGwKKysrIGIvTGF5b3V0VGVzdHMvZmFzdC9leGNsdXNpb25zL3NoYXBlLW91dHNp
ZGUtZmxvYXRzL3NoYXBlLW91dHNpZGUtZmxvYXRzLW92ZXJmbG93LWhpZGRlbi1leHBlY3RlZC5o
dG1sCkBAIC0wLDAgKzEsNDggQEAKKzxodG1sPgorPGhlYWQ+Cis8c3R5bGU+CisuY29udGFpbmVy
IHsKKyAgd2lkdGg6IDIwMHB4OworICBmb250OiAxMHB4LzEgQWhlbSwgc2Fucy1zZXJpZjsKKyAg
Y29sb3I6IGdyZWVuOworICBiYWNrZ3JvdW5kLWNvbG9yOiByZWQ7Cit9Cisuc2hhcGUgeworICB3
aWR0aDogODBweDsKKyAgaGVpZ2h0OiA5MHB4OworICBmbG9hdDogbGVmdDsKKyAgb3ZlcmZsb3c6
IGhpZGRlbjsKKyAgY29sb3I6IGJsdWU7Cit9Cis8L3N0eWxlPgorPC9oZWFkPgorPGJvZHk+Cis8
aDE+PGEgaHJlZj0iaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTk4Njc2
Ij5CdWcgMTEwMzQ5PC9hPiAtIFtjc3MgZXhjbHVzaW9uc10gb3ZlcmZsb3c6aGlkZGVuIHVuZG9l
cyBzaGFwZS1vdXRzaWRlIG9mZnNldHM8L2gxPgorPGgyPllvdSBzaG91bGQgc2VlIGEgYmx1ZSBy
ZWN0YW5nbGUgdG8gdGhlIGxlZnQgb2YgYSBncmVlbiByZWN0YW5nbGUuIFlvdSBzaG91bGQgbm90
IHNlZSBhbnkgcmVkLjwvaDI+Cis8ZGl2IGNsYXNzPSJjb250YWluZXIiPgorPGRpdiBjbGFzcz0n
c2hhcGUnPgorWFhYWFhYWFgKK1hYWFhYWFhYCitYWFhYWFhYWAorWFhYWFhYWFgKK1hYWFhYWFhY
CitYWFhYWFhYWAorWFhYWFhYWFgKK1hYWFhYWFhYCitYWFhYWFhYWAorWFhYWFhYWFgKK1hYWFhY
WFhYCitYWFhYWFhYWAorPC9kaXY+CitYWFhYWFhYWFhYWFgKK1hYWFhYWFhYWFhYWAorWFhYWFhY
WFhYWFhYCitYWFhYWFhYWFhYWFgKK1hYWFhYWFhYWFhYWAorWFhYWFhYWFhYWFhYCitYWFhYWFhY
WFhYWFgKK1hYWFhYWFhYWFhYWAorWFhYWFhYWFhYWFhYCis8L2Rpdj4KKzwvYm9keT4KKzwvaHRt
bD4KZGlmZiAtLWdpdCBhL0xheW91dFRlc3RzL2Zhc3QvZXhjbHVzaW9ucy9zaGFwZS1vdXRzaWRl
LWZsb2F0cy9zaGFwZS1vdXRzaWRlLWZsb2F0cy1vdmVyZmxvdy1oaWRkZW4uaHRtbCBiL0xheW91
dFRlc3RzL2Zhc3QvZXhjbHVzaW9ucy9zaGFwZS1vdXRzaWRlLWZsb2F0cy9zaGFwZS1vdXRzaWRl
LWZsb2F0cy1vdmVyZmxvdy1oaWRkZW4uaHRtbApuZXcgZmlsZSBtb2RlIDEwMDY0NAppbmRleCAw
MDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwLi4xNWU2NTJhMzMxN2RhOTgx
MDQ5ZWUwZGUyNDg2NzBhMzMzOTVkY2ZlCi0tLSAvZGV2L251bGwKKysrIGIvTGF5b3V0VGVzdHMv
ZmFzdC9leGNsdXNpb25zL3NoYXBlLW91dHNpZGUtZmxvYXRzL3NoYXBlLW91dHNpZGUtZmxvYXRz
LW92ZXJmbG93LWhpZGRlbi5odG1sCkBAIC0wLDAgKzEsNTMgQEAKKzxodG1sPgorPGhlYWQ+Cis8
c2NyaXB0PgorICAgIGlmICh3aW5kb3cuaW50ZXJuYWxzKQorICAgICAgICB3aW5kb3cuaW50ZXJu
YWxzLnNldHRpbmdzLnNldENTU0V4Y2x1c2lvbnNFbmFibGVkKHRydWUpOworPC9zY3JpcHQ+Cis8
c3R5bGU+CisuY29udGFpbmVyIHsKKyAgd2lkdGg6IDIwMHB4OworICBmb250OiAxMHB4LzEgQWhl
bSwgc2Fucy1zZXJpZjsKKyAgY29sb3I6IGdyZWVuOworICBiYWNrZ3JvdW5kLWNvbG9yOiByZWQ7
Cit9Cisuc2hhcGUgeworICB3aWR0aDogMTAwcHg7CisgIGhlaWdodDogMTAwcHg7CisgIC13ZWJr
aXQtc2hhcGUtb3V0c2lkZTogcmVjdGFuZ2xlKDEwJSwgMTAlLCA4MCUsIDkwJSk7CisgIGZsb2F0
OiBsZWZ0OworICBjb2xvcjogYmx1ZTsKKyAgb3ZlcmZsb3c6IGhpZGRlbjsKK30KKzwvc3R5bGU+
Cis8L2hlYWQ+Cis8Ym9keT4KKzxoMT48YSBocmVmPSJodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9z
aG93X2J1Zy5jZ2k/aWQ9OTg2NzYiPkJ1ZyAxMTAzNDk8L2E+IC0gW2NzcyBleGNsdXNpb25zXSBv
dmVyZmxvdzpoaWRkZW4gdW5kb2VzIHNoYXBlLW91dHNpZGUgb2Zmc2V0czwvaDE+Cis8aDI+WW91
IHNob3VsZCBzZWUgYSBibHVlIHJlY3RhbmdsZSB0byB0aGUgbGVmdCBvZiBhIGdyZWVuIHJlY3Rh
bmdsZS4gWW91IHNob3VsZCBub3Qgc2VlIGFueSByZWQuPC9oMj4KKzxkaXYgY2xhc3M9ImNvbnRh
aW5lciI+Cis8ZGl2IGNsYXNzPSdzaGFwZSc+CitYWFhYWFhYWAorWFhYWFhYWFgKK1hYWFhYWFhY
CitYWFhYWFhYWAorWFhYWFhYWFgKK1hYWFhYWFhYCitYWFhYWFhYWAorWFhYWFhYWFgKK1hYWFhY
WFhYCitYWFhYWFhYWAorWFhYWFhYWFgKK1hYWFhYWFhYCis8L2Rpdj4KK1hYWFhYWFhYWFhYWAor
WFhYWFhYWFhYWFhYCitYWFhYWFhYWFhYWFgKK1hYWFhYWFhYWFhYWAorWFhYWFhYWFhYWFhYCitY
WFhYWFhYWFhYWFgKK1hYWFhYWFhYWFhYWAorWFhYWFhYWFhYWFhYCitYWFhYWFhYWFhYWFgKKzwv
ZGl2PgorPC9ib2R5PgorPC9odG1sPgo=
</data>
<flag name="review"
          id="217756"
          type_id="1"
          status="+"
          setter="jchaffraix"
    />
    <flag name="commit-queue"
          id="217757"
          type_id="3"
          status="-"
          setter="jchaffraix"
    />
          </attachment>
          <attachment
              isobsolete="0"
              ispatch="1"
              isprivate="0"
          >
            <attachid>196176</attachid>
            <date>2013-04-02 10:40:59 -0700</date>
            <delta_ts>2013-04-02 11:08:36 -0700</delta_ts>
            <desc>Patch</desc>
            <filename>bug-110349-20130402104051.patch</filename>
            <type>text/plain</type>
            <size>5780</size>
            <attacher name="Bem Jones-Bey">bjonesbe</attacher>
            
              <data encoding="base64">U3VidmVyc2lvbiBSZXZpc2lvbjogMTQ3NDQ1CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D
aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggNTg1NDE4ZDQ0NmZlMjZi
ZmNlYTk2YWYzODExOTRkYTc4MTU0ZTc5Zi4uZDcwODE1ZjIxNWFjYmM0NzY5Mzg1ZmUwZDBhMWIx
ZjNlZTY0MDlmMiAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv
dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDI1IEBACisyMDEzLTA0LTAyICBCZW0g
Sm9uZXMtQmV5ICA8YmpvbmVzYmVAYWRvYmUuY29tPgorCisgICAgICAgIFtjc3MgZXhjbHVzaW9u
c10gb3ZlcmZsb3c6aGlkZGVuIHVuZG9lcyBzaGFwZS1vdXRzaWRlIG9mZnNldHMKKyAgICAgICAg
aHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTExMDM0OQorCisgICAgICAg
IFJldmlld2VkIGJ5IEp1bGllbiBDaGFmZnJhaXguCisKKyAgICAgICAgV2hlbiBvdmVyZmxvdzog
aGlkZGVuIHdhcyBzZXQgb24gYSBmbG9hdCB3aXRoIHNoYXBlLW91dHNpZGUsIHRoZQorICAgICAg
ICBvZmZzZXQgZnJvbSB0aGUgc2hhcGUtb3V0c2lkZSB3YXMgYmVpbmcgaWdub3JlZC4gVGhpcyB3
YXMgYmVjYXVzZSB0aGUKKyAgICAgICAgZmxvYXQgd2FzIGJlaW5nIHBsYWNlZCBpbiB0aGUgbm9y
bWFsIGZsb3csIGNhdXNpbmcgdGhlIG9mZnNldHMgdG8gYmUKKyAgICAgICAgY2FsY3VsYXRlZCBk
aWZmZXJlbnRseS4gU2luY2UgZmxvYXRzIHdpdGggc2hhcGUgb3V0c2lkZSBiZWhhdmUgbGlrZQor
ICAgICAgICBwb3NpdGlvbmVkIG9iamVjdHMgaW4gbWFueSBwbGFjZXMsIEkgaGF2ZSBjYXVzZWQg
dGhlbSB0byB0YWtlIHRoZSBzYW1lCisgICAgICAgIGJlaGF2aW9yIGFzIHBvc2l0aW9uZWQgb2Jq
ZWN0cyBpbiB0aGlzIGNhc2UgYXMgd2VsbDogdGhlIGZsb2F0cyB3aXRoCisgICAgICAgIHNoYXBl
LW91dHNpZGUgZG8gbm90IGdldCBwbGFjZWQgaW4gdGhlIG5vcm1hbCBmbG93IHdoZW4gb3ZlcmZs
b3c6CisgICAgICAgIGhpZGRlbiBpcyBzZXQuCisKKyAgICAgICAgVGVzdDogZmFzdC9leGNsdXNp
b25zL3NoYXBlLW91dHNpZGUtZmxvYXRzL3NoYXBlLW91dHNpZGUtZmxvYXRzLW92ZXJmbG93LWhp
ZGRlbi5odG1sCisKKyAgICAgICAgKiByZW5kZXJpbmcvUmVuZGVyTGF5ZXIuY3BwOgorICAgICAg
ICAoV2ViQ29yZTo6UmVuZGVyTGF5ZXI6OnNob3VsZEJlTm9ybWFsRmxvd09ubHkpOiBGbG9hdHMg
dGhhdCBoYXZlCisgICAgICAgICAgICBzaGFwZS1vdXRzaWRlIHNob3VsZCBub3QgYmUgaW4gdGhl
IG5vcm1hbCBmbG93LgorCiAyMDEzLTA0LTAyICBDaGFuZ1Nlb2sgT2ggIDxjaGFuZ3Nlb2sub2hA
Y29sbGFib3JhLmNvbT4KIAogICAgICAgICBbR1RLXVtBQ10gU3VwcG9ydCBwcmVzZXJ2ZXMzRCBj
c3MgcHJvcGVydHkgZm9yIGNsdXR0ZXIgYWMgYmFja2VuZC4KZGlmZiAtLWdpdCBhL1NvdXJjZS9X
ZWJDb3JlL3JlbmRlcmluZy9SZW5kZXJMYXllci5jcHAgYi9Tb3VyY2UvV2ViQ29yZS9yZW5kZXJp
bmcvUmVuZGVyTGF5ZXIuY3BwCmluZGV4IDE5ODU0ZDBjM2I1MmQ5ODgzMmI1MThmZWJiZDQyODRh
Mzk5MDVlZTQuLjQ2MGFjNTM2MjI1YWJkYTMxNjA1YWRjNTFlZWMyMTUyMmJhYmI2MzkgMTAwNjQ0
Ci0tLSBhL1NvdXJjZS9XZWJDb3JlL3JlbmRlcmluZy9SZW5kZXJMYXllci5jcHAKKysrIGIvU291
cmNlL1dlYkNvcmUvcmVuZGVyaW5nL1JlbmRlckxheWVyLmNwcApAQCAtNTg0NSw3ICs1ODQ1LDEw
IEBAIGJvb2wgUmVuZGVyTGF5ZXI6OnNob3VsZEJlTm9ybWFsRmxvd09ubHkoKSBjb25zdAogICAg
ICAgICAgICAgJiYgIXJlbmRlcmVyKCktPmhhc0JsZW5kTW9kZSgpCiAjZW5kaWYKICAgICAgICAg
ICAgICYmICFpc1RyYW5zcGFyZW50KCkKLSAgICAgICAgICAgICYmICFuZWVkc0NvbXBvc2l0ZWRT
Y3JvbGxpbmcoKTsKKyAgICAgICAgICAgICYmICFuZWVkc0NvbXBvc2l0ZWRTY3JvbGxpbmcoKQor
I2lmIEVOQUJMRShDU1NfRVhDTFVTSU9OUykKKyAgICAgICAgICAgICYmICEocmVuZGVyZXIoKS0+
aXNGbG9hdGluZygpICYmIHJlbmRlcmVyKCktPnN0eWxlKCktPnNoYXBlT3V0c2lkZSgpKTsKKyNl
bmRpZgogfQogCiBib29sIFJlbmRlckxheWVyOjpzaG91bGRCZVNlbGZQYWludGluZ0xheWVyKCkg
Y29uc3QKZGlmZiAtLWdpdCBhL0xheW91dFRlc3RzL0NoYW5nZUxvZyBiL0xheW91dFRlc3RzL0No
YW5nZUxvZwppbmRleCA1YTUzNTBmNGYwZWM1ZWRiMjQyYTZlM2U1YThjNmFjNWE5Nzc4MTU1Li5j
ZGFiNzc5MDEzNzM4YmQ5NmIzOWY5MTk3OTc2ZjlhMjAzZmYwZWJiIDEwMDY0NAotLS0gYS9MYXlv
dXRUZXN0cy9DaGFuZ2VMb2cKKysrIGIvTGF5b3V0VGVzdHMvQ2hhbmdlTG9nCkBAIC0xLDMgKzEs
MTYgQEAKKzIwMTMtMDQtMDIgIEJlbSBKb25lcy1CZXkgIDxiam9uZXNiZUBhZG9iZS5jb20+CisK
KyAgICAgICAgW2NzcyBleGNsdXNpb25zXSBvdmVyZmxvdzpoaWRkZW4gdW5kb2VzIHNoYXBlLW91
dHNpZGUgb2Zmc2V0cworICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5j
Z2k/aWQ9MTEwMzQ5CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgSnVsaWVuIENoYWZmcmFpeC4KKwor
ICAgICAgICBBZGQgYSB0ZXN0IHRvIG1ha2Ugc3VyZSB0aGUgZmxvYXQgaXMgcHJvcGVybHkgcG9z
aXRpb25lZCB3aXRoCisgICAgICAgIG92ZXJmbG93OiBoaWRkZW4uCisKKyAgICAgICAgKiBmYXN0
L2V4Y2x1c2lvbnMvc2hhcGUtb3V0c2lkZS1mbG9hdHMvc2hhcGUtb3V0c2lkZS1mbG9hdHMtb3Zl
cmZsb3ctaGlkZGVuLWV4cGVjdGVkLmh0bWw6IEFkZGVkLgorICAgICAgICAqIGZhc3QvZXhjbHVz
aW9ucy9zaGFwZS1vdXRzaWRlLWZsb2F0cy9zaGFwZS1vdXRzaWRlLWZsb2F0cy1vdmVyZmxvdy1o
aWRkZW4uaHRtbDogQWRkZWQuCisKIDIwMTMtMDQtMDIgIEp1bGllbiBDaGFmZnJhaXggIDxqY2hh
ZmZyYWl4QHdlYmtpdC5vcmc+CiAKICAgICAgICAgd2Via2l0IGZhaWxzIElFVEMgZ3JpZC1jb2x1
bW4tMDAyCmRpZmYgLS1naXQgYS9MYXlvdXRUZXN0cy9mYXN0L2V4Y2x1c2lvbnMvc2hhcGUtb3V0
c2lkZS1mbG9hdHMvc2hhcGUtb3V0c2lkZS1mbG9hdHMtb3ZlcmZsb3ctaGlkZGVuLWV4cGVjdGVk
Lmh0bWwgYi9MYXlvdXRUZXN0cy9mYXN0L2V4Y2x1c2lvbnMvc2hhcGUtb3V0c2lkZS1mbG9hdHMv
c2hhcGUtb3V0c2lkZS1mbG9hdHMtb3ZlcmZsb3ctaGlkZGVuLWV4cGVjdGVkLmh0bWwKbmV3IGZp
bGUgbW9kZSAxMDA2NDQKaW5kZXggMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAw
MDAwMC4uNmFjY2Y1NWI4MThmMzhiZThmZjY2Y2E2NGVhZTk3OWVkODFlNDI2ZQotLS0gL2Rldi9u
dWxsCisrKyBiL0xheW91dFRlc3RzL2Zhc3QvZXhjbHVzaW9ucy9zaGFwZS1vdXRzaWRlLWZsb2F0
cy9zaGFwZS1vdXRzaWRlLWZsb2F0cy1vdmVyZmxvdy1oaWRkZW4tZXhwZWN0ZWQuaHRtbApAQCAt
MCwwICsxLDQ4IEBACis8IURPQ1RZUEUgaHRtbD4KKzxodG1sPgorPGhlYWQ+Cis8c3R5bGU+Cisu
Y29udGFpbmVyIHsKKyAgd2lkdGg6IDIwMHB4OworICBmb250OiAxMHB4LzEgQWhlbSwgc2Fucy1z
ZXJpZjsKKyAgY29sb3I6IGdyZWVuOworfQorLnNoYXBlIHsKKyAgd2lkdGg6IDgwcHg7CisgIGhl
aWdodDogOTBweDsKKyAgZmxvYXQ6IGxlZnQ7CisgIG92ZXJmbG93OiBoaWRkZW47CisgIGNvbG9y
OiBibHVlOworfQorPC9zdHlsZT4KKzwvaGVhZD4KKzxib2R5PgorPGgxPjxhIGhyZWY9Imh0dHBz
Oi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD05ODY3NiI+QnVnIDExMDM0OTwvYT4g
LSBbY3NzIGV4Y2x1c2lvbnNdIG92ZXJmbG93OmhpZGRlbiB1bmRvZXMgc2hhcGUtb3V0c2lkZSBv
ZmZzZXRzPC9oMT4KKzxoMj5Zb3Ugc2hvdWxkIHNlZSBhIGJsdWUgcmVjdGFuZ2xlIHRvIHRoZSBs
ZWZ0IG9mIGEgZ3JlZW4gcmVjdGFuZ2xlLiBZb3Ugc2hvdWxkIG5vdCBzZWUgYW55IHJlZC48L2gy
PgorPGRpdiBjbGFzcz0iY29udGFpbmVyIj4KKzxkaXYgY2xhc3M9J3NoYXBlJz4KK1hYWFhYWFhY
CitYWFhYWFhYWAorWFhYWFhYWFgKK1hYWFhYWFhYCitYWFhYWFhYWAorWFhYWFhYWFgKK1hYWFhY
WFhYCitYWFhYWFhYWAorWFhYWFhYWFgKK1hYWFhYWFhYCitYWFhYWFhYWAorWFhYWFhYWFgKKzwv
ZGl2PgorWFhYWFhYWFhYWFhYCitYWFhYWFhYWFhYWFgKK1hYWFhYWFhYWFhYWAorWFhYWFhYWFhY
WFhYCitYWFhYWFhYWFhYWFgKK1hYWFhYWFhYWFhYWAorWFhYWFhYWFhYWFhYCitYWFhYWFhYWFhY
WFgKK1hYWFhYWFhYWFhYWAorPC9kaXY+Cis8L2JvZHk+Cis8L2h0bWw+CmRpZmYgLS1naXQgYS9M
YXlvdXRUZXN0cy9mYXN0L2V4Y2x1c2lvbnMvc2hhcGUtb3V0c2lkZS1mbG9hdHMvc2hhcGUtb3V0
c2lkZS1mbG9hdHMtb3ZlcmZsb3ctaGlkZGVuLmh0bWwgYi9MYXlvdXRUZXN0cy9mYXN0L2V4Y2x1
c2lvbnMvc2hhcGUtb3V0c2lkZS1mbG9hdHMvc2hhcGUtb3V0c2lkZS1mbG9hdHMtb3ZlcmZsb3ct
aGlkZGVuLmh0bWwKbmV3IGZpbGUgbW9kZSAxMDA2NDQKaW5kZXggMDAwMDAwMDAwMDAwMDAwMDAw
MDAwMDAwMDAwMDAwMDAwMDAwMDAwMC4uNjA4Yjg1NjRjMDBkYTcwNWQ5OWVmZjUwMjVkNThmMDk4
ZGVkMjI1ZAotLS0gL2Rldi9udWxsCisrKyBiL0xheW91dFRlc3RzL2Zhc3QvZXhjbHVzaW9ucy9z
aGFwZS1vdXRzaWRlLWZsb2F0cy9zaGFwZS1vdXRzaWRlLWZsb2F0cy1vdmVyZmxvdy1oaWRkZW4u
aHRtbApAQCAtMCwwICsxLDU0IEBACis8IURPQ1RZUEUgaHRtbD4KKzxodG1sPgorPGhlYWQ+Cis8
c2NyaXB0PgorICAgIGlmICh3aW5kb3cuaW50ZXJuYWxzKQorICAgICAgICB3aW5kb3cuaW50ZXJu
YWxzLnNldHRpbmdzLnNldENTU0V4Y2x1c2lvbnNFbmFibGVkKHRydWUpOworPC9zY3JpcHQ+Cis8
c3R5bGU+CisuY29udGFpbmVyIHsKKyAgd2lkdGg6IDIwMHB4OworICBmb250OiAxMHB4LzEgQWhl
bSwgc2Fucy1zZXJpZjsKKyAgY29sb3I6IGdyZWVuOworICBiYWNrZ3JvdW5kLWNvbG9yOiByZWQ7
Cit9Cisuc2hhcGUgeworICB3aWR0aDogMTAwcHg7CisgIGhlaWdodDogMTAwcHg7CisgIC13ZWJr
aXQtc2hhcGUtb3V0c2lkZTogcmVjdGFuZ2xlKDEwJSwgMTAlLCA4MCUsIDkwJSk7CisgIGZsb2F0
OiBsZWZ0OworICBjb2xvcjogYmx1ZTsKKyAgb3ZlcmZsb3c6IGhpZGRlbjsKK30KKzwvc3R5bGU+
Cis8L2hlYWQ+Cis8Ym9keT4KKzxoMT48YSBocmVmPSJodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9z
aG93X2J1Zy5jZ2k/aWQ9OTg2NzYiPkJ1ZyAxMTAzNDk8L2E+IC0gW2NzcyBleGNsdXNpb25zXSBv
dmVyZmxvdzpoaWRkZW4gdW5kb2VzIHNoYXBlLW91dHNpZGUgb2Zmc2V0czwvaDE+Cis8aDI+WW91
IHNob3VsZCBzZWUgYSBibHVlIHJlY3RhbmdsZSB0byB0aGUgbGVmdCBvZiBhIGdyZWVuIHJlY3Rh
bmdsZS4gWW91IHNob3VsZCBub3Qgc2VlIGFueSByZWQuPC9oMj4KKzxkaXYgY2xhc3M9ImNvbnRh
aW5lciI+Cis8ZGl2IGNsYXNzPSdzaGFwZSc+CitYWFhYWFhYWAorWFhYWFhYWFgKK1hYWFhYWFhY
CitYWFhYWFhYWAorWFhYWFhYWFgKK1hYWFhYWFhYCitYWFhYWFhYWAorWFhYWFhYWFgKK1hYWFhY
WFhYCitYWFhYWFhYWAorWFhYWFhYWFgKK1hYWFhYWFhYCis8L2Rpdj4KK1hYWFhYWFhYWFhYWAor
WFhYWFhYWFhYWFhYCitYWFhYWFhYWFhYWFgKK1hYWFhYWFhYWFhYWAorWFhYWFhYWFhYWFhYCitY
WFhYWFhYWFhYWFgKK1hYWFhYWFhYWFhYWAorWFhYWFhYWFhYWFhYCitYWFhYWFhYWFhYWFgKKzwv
ZGl2PgorPC9ib2R5PgorPC9odG1sPgo=
</data>

          </attachment>
      

    </bug>

</bugzilla>