110347 2013-02-20 07:20:53 -0800 [GTK][AC] Opacity animation doesn't work with clutter backend 2013-03-22 07:44:45 -0700 1 1 1 Unclassified WebKit WebKitGTK 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 105699 110607 0 kevin.cs.oh webkit-unassigned gustavo webkit.review.bot oldest_to_newest 837452 0 kevin.cs.oh 2013-02-20 07:20:53 -0800 After animation features enhancing, opacity animation doesn't work now. 839787 1 189803 kevin.cs.oh 2013-02-22 11:52:55 -0800 Created attachment 189803 Patch 848890 2 kevin.cs.oh 2013-03-06 08:33:32 -0800 This patch is also applied to webkit-clutter. http://cgit.collabora.com/git/webkit-clutter.git/commit/?h=wip/changseok/unreviewed&id=c4f68d0678b79ed3279227de572fd398500ab44a 852413 3 192489 gustavo 2013-03-11 09:56:33 -0700 Created attachment 192489 Simple test case I've tested this patch on WebKit Clutter with the attached page, and it looks like the transition is happening twice - once because of the CSS transition that is defined, and one because when WebCore sets the final result in the layer, the clutter transition is still set on the actor, so it happens again. I'm getting this warning, as well: (MxLauncher:24704): Clutter-CRITICAL **: clutter_timeline_set_progress_mode: assertion `mode < CLUTTER_ANIMATION_LAST' failed 852414 4 189803 gustavo 2013-03-11 09:56:53 -0700 Comment on attachment 189803 Patch r- for the above 853150 5 kevin.cs.oh 2013-03-12 00:45:17 -0700 (In reply to comment #3) Thanks for the review! > Created an attachment (id=192489) [details] > Simple test case > > I've tested this patch on WebKit Clutter with the attached page, and it looks like the transition is happening twice - once because of the CSS transition that is defined, and one because when WebCore sets the final result in the layer, the clutter transition is still set on the actor, so it happens again. Yeah, it's a known issue and dealt in bug110607. Please see bug110607, I applied it to webkit-clutter as well. I'm getting this warning, as well: > > (MxLauncher:24704): Clutter-CRITICAL **: clutter_timeline_set_progress_mode: assertion `mode < CLUTTER_ANIMATION_LAST' failed This is because webkit-clutter is using different toClutterAnimationMode in PlatformClutterAnimation.cpp. webkit-clutter's one is a little old so I think we need to replace it with the one of WebKitGTK+. You may want to refer https://developer.gnome.org/clutter/stable/ClutterAlpha.html#clutter-alpha-register-func And actually I think we don't need to care about timing functions anymore because clutter starts to supports them for css3 transitions since its version 1.12. https://developer.gnome.org/clutter/stable/ClutterTimeline.html#ClutterAnimationMode 853171 6 kevin.cs.oh 2013-03-12 01:14:31 -0700 The replacing patch for webkit-clutter is here. http://cgit.collabora.com/git/webkit-clutter.git/commit/?h=wip/changseok/unreviewed&id=7a69a2ed4aa739803997496d5823007eba517f2e 861445 7 189803 gustavo 2013-03-22 07:37:59 -0700 Comment on attachment 189803 Patch OK, this makes sense with bug 110607 861451 8 189803 webkit.review.bot 2013-03-22 07:44:42 -0700 Comment on attachment 189803 Patch Clearing flags on attachment: 189803 Committed r146609: <http://trac.webkit.org/changeset/146609> 861452 9 webkit.review.bot 2013-03-22 07:44:45 -0700 All reviewed patches have been landed. Closing bug. 189803 2013-02-22 11:52:55 -0800 2013-03-22 07:44:41 -0700 Patch bug-110347-20130223044914.patch text/plain 3524 kevin.cs.oh U3VidmVyc2lvbiBSZXZpc2lvbjogMTQzNzI5CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggYjZjNjgzZjBjYTFmYWI4 MzQ4YTZkMDRhMjE1NzQzMmFjM2U2NjZlZS4uZWVkMDcwODdhNDc1YjRmOThhZjBiYjNkZWZiZmJl ODkxM2Q2MTRiOCAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE5IEBACisyMDEzLTAyLTIyICBDaGFu Z1Nlb2sgT2ggIDxjaGFuZ3Nlb2sub2hAY29sbGFib3JhLmNvbT4KKworICAgICAgICBbR1RLXVtB Q10gT3BhY2l0eSBhbmltYXRpb24gZG9lc24ndCB3b3JrIHdpdGggY2x1dHRlciBiYWNrZW5kCisg ICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xMTAzNDcKKwor ICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBUaGUgc3RhdGlj IGNhc3RpbmcgaW4gdGVybmFyeSBvcGVyYXRvciBkb2Vzbid0IGNoYW5nZSBhY3R1YWwgaW5wdXR0 ZWQgYXJndW1lbnQgdHlwZS4KKyAgICAgICAgU28gSSByZXBsYWNlZCBpdCB3aXRoIGlmLWVsc2Ug c3RhdGVtZW50LgorCisgICAgICAgIENvdmVyZWQgYnkgZXhpc3RpbmcgYW5pbWF0aW9uIHRlc3Rz LgorCisgICAgICAgICogcGxhdGZvcm0vZ3JhcGhpY3MvY2x1dHRlci9QbGF0Zm9ybUNsdXR0ZXJB bmltYXRpb24uY3BwOgorICAgICAgICAoV2ViQ29yZTo6UGxhdGZvcm1DbHV0dGVyQW5pbWF0aW9u OjphZGRDbHV0dGVyVHJhbnNpdGlvbkZvclByb3BlcnR5KToKKyAgICAgICAgKFdlYkNvcmU6OlBs YXRmb3JtQ2x1dHRlckFuaW1hdGlvbjo6YWRkQ2x1dHRlcktleWZyYW1lVHJhbnNpdGlvbkZvclBy b3BlcnR5KToKKwogMjAxMy0wMi0yMiAgQW5kcmV5IEx1c2huaWtvdiAgPGx1c2huaWtvdkBjaHJv bWl1bS5vcmc+CiAKICAgICAgICAgV2ViIEluc3BlY3Rvcjogc2hvdyBzb3VyY2UgbG9jYXRpb24g YWZ0ZXIgZHJhd2VyIHZpZXdzCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9n cmFwaGljcy9jbHV0dGVyL1BsYXRmb3JtQ2x1dHRlckFuaW1hdGlvbi5jcHAgYi9Tb3VyY2UvV2Vi Q29yZS9wbGF0Zm9ybS9ncmFwaGljcy9jbHV0dGVyL1BsYXRmb3JtQ2x1dHRlckFuaW1hdGlvbi5j cHAKaW5kZXggNTc1MWEzMGQ4MWM0ZWQyZmI1N2JlOTI2ZDRlZDhlNjc5MGQwYjk5Ny4uZGFkZjkw MzAxOGQ0NDlhZjQ5MjE4OTVhM2EyZTYyYjU4NzM0NzI3OCAxMDA2NDQKLS0tIGEvU291cmNlL1dl YkNvcmUvcGxhdGZvcm0vZ3JhcGhpY3MvY2x1dHRlci9QbGF0Zm9ybUNsdXR0ZXJBbmltYXRpb24u Y3BwCisrKyBiL1NvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL2dyYXBoaWNzL2NsdXR0ZXIvUGxhdGZv cm1DbHV0dGVyQW5pbWF0aW9uLmNwcApAQCAtNDMzLDExICs0MzMsMTQgQEAgdm9pZCBQbGF0Zm9y bUNsdXR0ZXJBbmltYXRpb246OmFkZENsdXR0ZXJUcmFuc2l0aW9uRm9yUHJvcGVydHkoY29uc3Qg U3RyaW5nJiBwcm8KIHsKICAgICBBU1NFUlQocHJvcGVydHkgIT0gIk5vUHJvcGVydHkiKTsKIAot ICAgIEdUeXBlIGdUeXBlID0gKHByb3BlcnR5ID09ICJvcGFjaXR5IiA/IEdfVFlQRV9VSU5UIDog R19UWVBFX0ZMT0FUKTsKLQogICAgIEdSZWZQdHI8Q2x1dHRlclRyYW5zaXRpb24+IHRyYW5zaXRp b24gPSBhZG9wdEdSZWYoY2x1dHRlcl9wcm9wZXJ0eV90cmFuc2l0aW9uX25ldyhwcm9wZXJ0eS51 dGY4KCkuZGF0YSgpKSk7Ci0gICAgY2x1dHRlcl90cmFuc2l0aW9uX3NldF9mcm9tKHRyYW5zaXRp b24uZ2V0KCksIGdUeXBlLCAoZ1R5cGUgPT0gR19UWVBFX1VJTlQgPyBzdGF0aWNfY2FzdDx1bnNp Z25lZD4oZnJvbVZhbHVlKSA6IGZyb21WYWx1ZSkpOwotICAgIGNsdXR0ZXJfdHJhbnNpdGlvbl9z ZXRfdG8odHJhbnNpdGlvbi5nZXQoKSwgZ1R5cGUsIChnVHlwZSA9PSBHX1RZUEVfVUlOVCA/IHN0 YXRpY19jYXN0PHVuc2lnbmVkPih0b1ZhbHVlKSA6IHRvVmFsdWUpKTsKKyAgICBpZiAocHJvcGVy dHkgPT0gIm9wYWNpdHkiKSB7CisgICAgICAgIGNsdXR0ZXJfdHJhbnNpdGlvbl9zZXRfZnJvbSh0 cmFuc2l0aW9uLmdldCgpLCBHX1RZUEVfVUlOVCwgc3RhdGljX2Nhc3Q8dW5zaWduZWQ+KGZyb21W YWx1ZSkpOworICAgICAgICBjbHV0dGVyX3RyYW5zaXRpb25fc2V0X3RvKHRyYW5zaXRpb24uZ2V0 KCksIEdfVFlQRV9VSU5ULCBzdGF0aWNfY2FzdDx1bnNpZ25lZD4odG9WYWx1ZSkpOworICAgIH0g ZWxzZSB7CisgICAgICAgIGNsdXR0ZXJfdHJhbnNpdGlvbl9zZXRfZnJvbSh0cmFuc2l0aW9uLmdl dCgpLCBHX1RZUEVfRkxPQVQsIGZyb21WYWx1ZSk7CisgICAgICAgIGNsdXR0ZXJfdHJhbnNpdGlv bl9zZXRfdG8odHJhbnNpdGlvbi5nZXQoKSwgR19UWVBFX0ZMT0FULCB0b1ZhbHVlKTsKKyAgICB9 CiAKICAgICBjbHV0dGVyX3RpbWVsaW5lX3NldF9wcm9ncmVzc19tb2RlKHRpbWVsaW5lKCksIHRv Q2x1dHRlckFuaW1hdGlvbk1vZGUobV90aW1pbmdGdW5jdGlvbikpOwogCkBAIC00OTAsOCArNDkz LDEzIEBAIHZvaWQgUGxhdGZvcm1DbHV0dGVyQW5pbWF0aW9uOjphZGRDbHV0dGVyS2V5ZnJhbWVU cmFuc2l0aW9uRm9yUHJvcGVydHkoY29uc3QgU3RyCiAgICAgR1R5cGUgZ1R5cGUgPSAocHJvcGVy dHkgPT0gIm9wYWNpdHkiID8gR19UWVBFX1VJTlQgOiBHX1RZUEVfRkxPQVQpOwogCiAgICAgR1Jl ZlB0cjxDbHV0dGVyVHJhbnNpdGlvbj4gdHJhbnNpdGlvbiA9IGFkb3B0R1JlZihjbHV0dGVyX2tl eWZyYW1lX3RyYW5zaXRpb25fbmV3KHByb3BlcnR5LnV0ZjgoKS5kYXRhKCkpKTsKLSAgICBjbHV0 dGVyX3RyYW5zaXRpb25fc2V0X2Zyb20odHJhbnNpdGlvbi5nZXQoKSwgZ1R5cGUsIHZhbHVlcy5m aXJzdCgpKTsKLSAgICBjbHV0dGVyX3RyYW5zaXRpb25fc2V0X3RvKHRyYW5zaXRpb24uZ2V0KCks IGdUeXBlLCB2YWx1ZXMubGFzdCgpKTsKKyAgICBpZiAoZ1R5cGUgPT0gR19UWVBFX1VJTlQpIHsK KyAgICAgICAgY2x1dHRlcl90cmFuc2l0aW9uX3NldF9mcm9tKHRyYW5zaXRpb24uZ2V0KCksIGdU eXBlLCBzdGF0aWNfY2FzdDx1bnNpZ25lZD4odmFsdWVzLmZpcnN0KCkpKTsKKyAgICAgICAgY2x1 dHRlcl90cmFuc2l0aW9uX3NldF90byh0cmFuc2l0aW9uLmdldCgpLCBnVHlwZSwgc3RhdGljX2Nh c3Q8dW5zaWduZWQ+KHZhbHVlcy5sYXN0KCkpKTsKKyAgICB9IGVsc2UgeworICAgICAgICBjbHV0 dGVyX3RyYW5zaXRpb25fc2V0X2Zyb20odHJhbnNpdGlvbi5nZXQoKSwgZ1R5cGUsIHZhbHVlcy5m aXJzdCgpKTsKKyAgICAgICAgY2x1dHRlcl90cmFuc2l0aW9uX3NldF90byh0cmFuc2l0aW9uLmdl dCgpLCBnVHlwZSwgdmFsdWVzLmxhc3QoKSk7CisgICAgfQogCiAgICAgLy8gSWdub3JlIHRoZSBm aXJzdCBrZXlmcmFtZSwgc2luY2UgaXQncyBhICcwJyBmcmFtZSwgbWVhbmluZ2xlc3MuCiAgICAg Y29uc3QgdW5zaWduZWQgbktleWZyYW1lcyA9IHZhbHVlcy5zaXplKCkgLSAxOwo= 192489 2013-03-11 09:56:33 -0700 2013-03-11 09:56:33 -0700 Simple test case opacity.html text/html 444 gustavo PGh0bWw+CiAgPHN0eWxlPgogICAgI3Rlc3RhIHsKICAgICAgICB3aWR0aDogMjAwcHg7CiAgICAg ICAgaGVpZ2h0OiAyMDBweDsKICAgICAgICAtd2Via2l0LXRyYW5zZm9ybTogcm90YXRlWSg0MGRl Zyk7CiAgICAgICAgYmFja2dyb3VuZC1jb2xvcjogZ3JlZW47CiAgICAgICAgLXdlYmtpdC10cmFu c2l0aW9uOiBhbGwgM3MgZWFzZS1pbjsKICAgIH0KCiAgPC9zdHlsZT4KICA8c2NyaXB0PgogICAg ZnVuY3Rpb24gc3RhcnQoKSB7CiAgICAgIHNldFRpbWVvdXQoZnVuY3Rpb24gKCl7CiAgICAgICAg ZG9jdW1lbnQuZ2V0RWxlbWVudEJ5SWQoJ3Rlc3RhJykuc3R5bGUub3BhY2l0eSA9ICcwLjInCiAg ICAgIH0sIDEwMCk7CiAgICB9CiAgPC9zY3JpcHQ+CiAgPGJvZHkgb25sb2FkPSJzdGFydCgpIj4K ICAgIDxkaXYgaWQ9InRlc3RhIj48L2Rpdj4KICA8L2JvZHk+CjwvaHRtbD4K