110002 2013-02-15 20:32:37 -0800 Add WebKitCSSMatrix to FeatureObserver 2014-04-05 14:11:23 -0700 1 1 1 Unclassified WebKit WebCore Misc. 528+ (Nightly build) Unspecified Unspecified RESOLVED INVALID P2 Normal --- 110001 1 krit krit abarth dbates dino ojan.autocc webkit.review.bot oldest_to_newest 834619 0 krit 2013-02-15 20:32:37 -0800 At some point we want to introduce a new API for matrices and deprecate WebKitCSSMatrix. WebKitCSSMatrix is not used anywhere within WebCore. So it is probably not used in the web either. Add the interface to the observer to verify this. 834625 1 188690 krit 2013-02-15 20:39:12 -0800 Created attachment 188690 Patch 836834 2 188690 abarth 2013-02-19 15:13:01 -0800 Comment on attachment 188690 Patch This metric isn't really going to tell you anything, unfortunately. Too much code enumerates the global scope, and that will hide any real usage of this feature. Perhaps we should instrument the WebKitCSSMatrix constructor itself? 836851 3 krit 2013-02-19 15:23:17 -0800 (In reply to comment #2) > (From update of attachment 188690 [details]) > This metric isn't really going to tell you anything, unfortunately. Too much code enumerates the global scope, and that will hide any real usage of this feature. Perhaps we should instrument the WebKitCSSMatrix constructor itself? Talked with abarth on IRC. He suggest taking a look at how we instrument new-style notifications. Leaving this on the bug report here as a note. I'll investigate more. Thanks Adam. 188690 2013-02-15 20:39:12 -0800 2013-02-19 15:13:00 -0800 Patch bug-110002-20130215203538.patch text/plain 2347 krit U3VidmVyc2lvbiBSZXZpc2lvbjogMTQzMDI0CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggMTE0N2JlZGVhOGRlZTRm ZmQ3ZjlhNTgzZWYzN2Y2MTUzZjY1YTY5OS4uYzIzMTEwZGI3MDRjYzJjMjJlNmM5Njk3NGJhMGIy ZWQxYWNkM2Q4YyAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDIwIEBACisyMDEzLTAyLTE1ICBEaXJr IFNjaHVsemUgIDxrcml0QHdlYmtpdC5vcmc+CisKKyAgICAgICAgQWRkIFdlYktpdENTU01hdHJp eCB0byBGZWF0dXJlT2JzZXJ2ZXIKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hv d19idWcuY2dpP2lkPTExMDAwMgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEp LgorCisgICAgICAgIEF0IHNvbWUgcG9pbnQgd2Ugd2FudCB0byBpbnRyb2R1Y2UgYSBuZXcgQVBJ IGZvciB0cmFuc2Zvcm1hdGlvbiBtYXRyaWNlcworICAgICAgICBhbmQgZGVwcmVjYXRlIFdlYktp dENTU01hdHJpeC4KKworICAgICAgICBXZWJLaXRDU1NNYXRyaXggaXMgbm90IHVzZWQgYW55d2hl cmUgd2l0aGluIFdlYkNvcmUuIFNvIGl0IGlzIHByb2JhYmx5CisgICAgICAgIG5vdCB1c2VkIGlu IHRoZSB3ZWIgZWl0aGVyLiBBZGQgdGhlIGludGVyZmFjZSB0byB0aGUgZmVhdHVyZSBvYnNlcnZl ciB0bworICAgICAgICBnZXQgbWV0cmljcyBhYm91dCB0aGUgdXNhZ2UuCisKKyAgICAgICAgKiBw YWdlL0RPTVdpbmRvdy5pZGw6CisgICAgICAgICogcGFnZS9GZWF0dXJlT2JzZXJ2ZXIuaDoKKwog MjAxMy0wMi0xNSAgRXJpYyBDYXJsc29uICA8ZXJpYy5jYXJsc29uQGFwcGxlLmNvbT4KIAogICAg ICAgICBDcmFzaCBvY2N1cnMgYXQgV2ViQ29yZTo6VGV4dFRyYWNrTGlzdDo6bGVuZ3RoKCkgd2hl biBlbmFibGluZyBjbG9zZWQgY2FwdGlvbnMgaW4gbW92aWUKZGlmZiAtLWdpdCBhL1NvdXJjZS9X ZWJDb3JlL3BhZ2UvRE9NV2luZG93LmlkbCBiL1NvdXJjZS9XZWJDb3JlL3BhZ2UvRE9NV2luZG93 LmlkbAppbmRleCA2NzFlYzViZjFkZTViYWJkOTVlMWVlNjk0MWUzNDQ3OWY3MGI0ZmI2Li5jYWMx OTRhNzEzMjg4N2E4MmIzODNmY2FlMmI5MTJjZGQxYjNiNWZkIDEwMDY0NAotLS0gYS9Tb3VyY2Uv V2ViQ29yZS9wYWdlL0RPTVdpbmRvdy5pZGwKKysrIGIvU291cmNlL1dlYkNvcmUvcGFnZS9ET01X aW5kb3cuaWRsCkBAIC01ODEsNyArNTgxLDcgQEAKICAgICBhdHRyaWJ1dGUgV2ViS2l0Q1NTS2V5 ZnJhbWVzUnVsZUNvbnN0cnVjdG9yIFdlYktpdENTU0tleWZyYW1lc1J1bGU7CiAgICAgW0NvbmRp dGlvbmFsPUNTU19SRUdJT05TLCBWOEVuYWJsZWRBdFJ1bnRpbWU9Y3NzUmVnaW9uc10gYXR0cmli dXRlIFdlYktpdENTU1JlZ2lvblJ1bGVDb25zdHJ1Y3RvciBXZWJLaXRDU1NSZWdpb25SdWxlOwog Ci0gICAgYXR0cmlidXRlIFdlYktpdENTU01hdHJpeENvbnN0cnVjdG9yIFdlYktpdENTU01hdHJp eDsgLy8gVXNhYmxlIHdpdGggdGhlIG5ldyBvcGVyYXRvcgorICAgIGF0dHJpYnV0ZSBbVjhNZWFz dXJlQXM9V2ViS2l0Q1NTTWF0cml4XSBXZWJLaXRDU1NNYXRyaXhDb25zdHJ1Y3RvciBXZWJLaXRD U1NNYXRyaXg7IC8vIFVzYWJsZSB3aXRoIHRoZSBuZXcgb3BlcmF0b3IKIAogICAgIGF0dHJpYnV0 ZSBXZWJLaXRQb2ludENvbnN0cnVjdG9yIFdlYktpdFBvaW50OyAvLyBVc2FibGUgd2l0aCBuZXcg dGhlIG9wZXJhdG9yCiAKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL3BhZ2UvRmVhdHVyZU9i c2VydmVyLmggYi9Tb3VyY2UvV2ViQ29yZS9wYWdlL0ZlYXR1cmVPYnNlcnZlci5oCmluZGV4IDc4 Zjk5ZWQ4NjkyZDM3ZTZjODVmYzU2ZjEzZDhjNThlMDk3M2EwMGIuLjY4MzYwZmE3OWNjYjEyMDJh M2FlYzgyYTRhMWQ0Zjk3OGI2YzFlNjIgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJDb3JlL3BhZ2Uv RmVhdHVyZU9ic2VydmVyLmgKKysrIGIvU291cmNlL1dlYkNvcmUvcGFnZS9GZWF0dXJlT2JzZXJ2 ZXIuaApAQCAtOTUsNiArOTUsNyBAQCBwdWJsaWM6CiAgICAgICAgIFJlcXVpcmVkQXR0cmlidXRl LAogICAgICAgICBSZXN1bHRzQXR0cmlidXRlLAogICAgICAgICBTdGVwQXR0cmlidXRlLAorICAg ICAgICBXZWJLaXRDU1NNYXRyaXgsCiAgICAgICAgIC8vIEFkZCBuZXcgZmVhdHVyZXMgYWJvdmUg dGhpcyBsaW5lLiBEb24ndCBjaGFuZ2UgYXNzaWduZWQgbnVtYmVycyBvZiBlYWNoIGl0ZW1zLgog ICAgICAgICBOdW1iZXJPZkZlYXR1cmVzLCAvLyBUaGlzIGVudW0gdmFsdWUgbXVzdCBiZSBsYXN0 LgogICAgIH07Cg==