109653 2013-02-12 20:32:01 -0800 [Refactoring] Make SelectorChecker::mode a constructor parameter. 2013-02-12 21:11:54 -0800 1 1 1 Unclassified WebKit CSS 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 89879 1 tasak tasak koivisto webcomponents-bugzilla webkit.review.bot oldest_to_newest 831573 0 tasak 2013-02-12 20:32:01 -0800 Since StyleResolver uses SelectorChecker as an on-stack object now, no need to use setMode(Mode) to change SelectorChecker's mode. Instead, we can make the mode a constructor parameter. 831575 1 187997 tasak 2013-02-12 20:35:37 -0800 Created attachment 187997 Patch 831583 2 187997 dglazkov 2013-02-12 20:42:34 -0800 Comment on attachment 187997 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=187997&action=review > Source/WebCore/css/SelectorChecker.cpp:65 > +SelectorChecker::SelectorChecker(Document* document, Mode mode) Does Mode declaration need to move to StyleResolver now? 831595 3 187997 webkit.review.bot 2013-02-12 21:11:50 -0800 Comment on attachment 187997 Patch Clearing flags on attachment: 187997 Committed r142717: <http://trac.webkit.org/changeset/142717> 831597 4 webkit.review.bot 2013-02-12 21:11:54 -0800 All reviewed patches have been landed. Closing bug. 187997 2013-02-12 20:35:37 -0800 2013-02-12 21:11:50 -0800 Patch bug-109653-20130213133206.patch text/plain 6358 tasak U3VidmVyc2lvbiBSZXZpc2lvbjogMTQyNjk4CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggMDdhNmZjZjBlNzA1NmQ5 NjMxY2IwMmUwMWJhMTNjMzY3Yjg4ZTJjMC4uODdkMzgzM2EzNGQ5ZjdkZTdjY2I2ZjY2NWVkMjY3 YTMxNjgzM2U1YyAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDI4IEBACisyMDEzLTAyLTEyICBUYWth c2hpIFNha2Ftb3RvICA8dGFzYWtAZ29vZ2xlLmNvbT4KKworICAgICAgICBbUmVmYWN0b3Jpbmdd IE1ha2UgU2VsZWN0b3JDaGVja2VyOjptb2RlIGEgY29uc3RydWN0b3IgcGFyYW1ldGVyLgorICAg ICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTA5NjUzCisKKyAg ICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgTm8gbmV3IHRlc3Rz LCBiZWNhdXNlIGp1c3QgcmVmYWN0b3JpbmcuCisKKyAgICAgICAgKiBjc3MvU2VsZWN0b3JDaGVj a2VyLmNwcDoKKyAgICAgICAgKFdlYkNvcmU6OlNlbGVjdG9yQ2hlY2tlcjo6U2VsZWN0b3JDaGVj a2VyKToKKyAgICAgICAgTWFkZSBtb2RlIGEgY29uc3RydWN0b3IgcGFyYW1ldGVyLgorICAgICAg ICAqIGNzcy9TZWxlY3RvckNoZWNrZXIuaDoKKyAgICAgICAgUmVtb3ZlZCBzZXRNb2RlLgorICAg ICAgICAoU2VsZWN0b3JDaGVja2VyKToKKyAgICAgICAgKiBjc3MvU3R5bGVSZXNvbHZlci5jcHA6 CisgICAgICAgIChXZWJDb3JlOjpTdHlsZVJlc29sdmVyOjpydWxlTWF0Y2hlcyk6CisgICAgICAg IChXZWJDb3JlOjpTdHlsZVJlc29sdmVyOjpjaGVja1JlZ2lvblNlbGVjdG9yKToKKyAgICAgICAg KiBkb20vU2VsZWN0b3JRdWVyeS5jcHA6CisgICAgICAgIChXZWJDb3JlOjpTZWxlY3RvclF1ZXJ5 OjptYXRjaGVzKToKKyAgICAgICAgKFdlYkNvcmU6OlNlbGVjdG9yUXVlcnk6OnF1ZXJ5QWxsKToK KyAgICAgICAgKFdlYkNvcmU6OlNlbGVjdG9yUXVlcnk6OnF1ZXJ5Rmlyc3QpOgorICAgICAgICAq IGh0bWwvc2hhZG93L0NvbnRlbnRTZWxlY3RvclF1ZXJ5LmNwcDoKKyAgICAgICAgKFdlYkNvcmU6 OkNvbnRlbnRTZWxlY3RvckNoZWNrZXI6OkNvbnRlbnRTZWxlY3RvckNoZWNrZXIpOgorCiAyMDEz LTAyLTEyICBBbmRyZWFzIEtsaW5nICA8YWtsaW5nQGFwcGxlLmNvbT4KIAogICAgICAgICBNb3Zl IEVsZW1lbnRBdHRyaWJ1dGVEYXRhIGludG8gRWxlbWVudC5jcHAvaApkaWZmIC0tZ2l0IGEvU291 cmNlL1dlYkNvcmUvY3NzL1NlbGVjdG9yQ2hlY2tlci5jcHAgYi9Tb3VyY2UvV2ViQ29yZS9jc3Mv U2VsZWN0b3JDaGVja2VyLmNwcAppbmRleCA4MjkwNTU1M2Y0Y2MzY2UxN2ZhN2UxNDlmYzk1YWE5 YzVmNTJlOGQ0Li5kMjI2M2VmZTM0NjUwODZiM2IzNzBlNjVmZmY0ZWQ3Yjk0ZTlkYjkyIDEwMDY0 NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9jc3MvU2VsZWN0b3JDaGVja2VyLmNwcAorKysgYi9Tb3Vy Y2UvV2ViQ29yZS9jc3MvU2VsZWN0b3JDaGVja2VyLmNwcApAQCAtNjIsMTAgKzYyLDEwIEBAIG5h bWVzcGFjZSBXZWJDb3JlIHsKIAogdXNpbmcgbmFtZXNwYWNlIEhUTUxOYW1lczsKIAotU2VsZWN0 b3JDaGVja2VyOjpTZWxlY3RvckNoZWNrZXIoRG9jdW1lbnQqIGRvY3VtZW50KQorU2VsZWN0b3JD aGVja2VyOjpTZWxlY3RvckNoZWNrZXIoRG9jdW1lbnQqIGRvY3VtZW50LCBNb2RlIG1vZGUpCiAg ICAgOiBtX3N0cmljdFBhcnNpbmcoIWRvY3VtZW50LT5pblF1aXJrc01vZGUoKSkKICAgICAsIG1f ZG9jdW1lbnRJc0hUTUwoZG9jdW1lbnQtPmlzSFRNTERvY3VtZW50KCkpCi0gICAgLCBtX21vZGUo UmVzb2x2aW5nU3R5bGUpCisgICAgLCBtX21vZGUobW9kZSkKIHsKIH0KIApkaWZmIC0tZ2l0IGEv U291cmNlL1dlYkNvcmUvY3NzL1NlbGVjdG9yQ2hlY2tlci5oIGIvU291cmNlL1dlYkNvcmUvY3Nz L1NlbGVjdG9yQ2hlY2tlci5oCmluZGV4IDdiMDU5ZjgyNWM5Njk0ZDk0NDMxMmI3ZDY4MjNkNGIy NzUwZGMwZGQuLmI2MTljZDUwZDg5YzRjMGIwYmQxMDU0ZDg2YzU0ZTQzOTA1NTYxMzIgMTAwNjQ0 Ci0tLSBhL1NvdXJjZS9XZWJDb3JlL2Nzcy9TZWxlY3RvckNoZWNrZXIuaAorKysgYi9Tb3VyY2Uv V2ViQ29yZS9jc3MvU2VsZWN0b3JDaGVja2VyLmgKQEAgLTQ0LDExICs0NCwxMCBAQCBjbGFzcyBS ZW5kZXJTdHlsZTsKIGNsYXNzIFNlbGVjdG9yQ2hlY2tlciB7CiAgICAgV1RGX01BS0VfTk9OQ09Q WUFCTEUoU2VsZWN0b3JDaGVja2VyKTsKIHB1YmxpYzoKLSAgICBleHBsaWNpdCBTZWxlY3RvckNo ZWNrZXIoRG9jdW1lbnQqKTsKLQogICAgIGVudW0gTWF0Y2ggeyBTZWxlY3Rvck1hdGNoZXMsIFNl bGVjdG9yRmFpbHNMb2NhbGx5LCBTZWxlY3RvckZhaWxzQWxsU2libGluZ3MsIFNlbGVjdG9yRmFp bHNDb21wbGV0ZWx5IH07CiAgICAgZW51bSBWaXNpdGVkTWF0Y2hUeXBlIHsgVmlzaXRlZE1hdGNo RGlzYWJsZWQsIFZpc2l0ZWRNYXRjaEVuYWJsZWQgfTsKICAgICBlbnVtIE1vZGUgeyBSZXNvbHZp bmdTdHlsZSA9IDAsIENvbGxlY3RpbmdSdWxlcywgUXVlcnlpbmdSdWxlcywgU2hhcmluZ1J1bGVz IH07CisgICAgZXhwbGljaXQgU2VsZWN0b3JDaGVja2VyKERvY3VtZW50KiwgTW9kZSk7CiAKICAg ICBzdHJ1Y3QgU2VsZWN0b3JDaGVja2luZ0NvbnRleHQgewogICAgICAgICAvLyBJbml0aWFsIHNl bGVjdG9yIGNvbnN0cnVjdG9yCkBAIC04Nyw3ICs4Niw2IEBAIHB1YmxpYzoKICAgICBib29sIHN0 cmljdFBhcnNpbmcoKSBjb25zdCB7IHJldHVybiBtX3N0cmljdFBhcnNpbmc7IH0KIAogICAgIE1v ZGUgbW9kZSgpIGNvbnN0IHsgcmV0dXJuIG1fbW9kZTsgfQotICAgIHZvaWQgc2V0TW9kZShNb2Rl IG1vZGUpIHsgbV9tb2RlID0gbW9kZTsgfQogCiAgICAgc3RhdGljIGJvb2wgdGFnTWF0Y2hlcyhj b25zdCBFbGVtZW50KiwgY29uc3QgUXVhbGlmaWVkTmFtZSYpOwogICAgIHN0YXRpYyBib29sIGlz Q29tbW9uUHNldWRvQ2xhc3NTZWxlY3Rvcihjb25zdCBDU1NTZWxlY3RvciopOwpkaWZmIC0tZ2l0 IGEvU291cmNlL1dlYkNvcmUvY3NzL1N0eWxlUmVzb2x2ZXIuY3BwIGIvU291cmNlL1dlYkNvcmUv Y3NzL1N0eWxlUmVzb2x2ZXIuY3BwCmluZGV4IDhiZDFmYTk3ZDYzMzAwMjE0YzYxMDdiNjdlMmFi NmE2NDQzMmJmYjUuLmIxOWFmNzY5YzA3ZTEzNzFlYmQyZDY3YmJiOGY1ODQ0YjFlZDQ2MjcgMTAw NjQ0Ci0tLSBhL1NvdXJjZS9XZWJDb3JlL2Nzcy9TdHlsZVJlc29sdmVyLmNwcAorKysgYi9Tb3Vy Y2UvV2ViQ29yZS9jc3MvU3R5bGVSZXNvbHZlci5jcHAKQEAgLTIwNzcsOCArMjA3Nyw3IEBAIGlu bGluZSBib29sIFN0eWxlUmVzb2x2ZXI6OnJ1bGVNYXRjaGVzKGNvbnN0IFJ1bGVEYXRhJiBydWxl RGF0YSwgY29uc3QgQ29udGFpbmVyCiAgICAgfQogCiAgICAgLy8gU2xvdyBwYXRoLgotICAgIFNl bGVjdG9yQ2hlY2tlciBzZWxlY3RvckNoZWNrZXIoZG9jdW1lbnQoKSk7Ci0gICAgc2VsZWN0b3JD aGVja2VyLnNldE1vZGUoc3RhdGUubW9kZSk7CisgICAgU2VsZWN0b3JDaGVja2VyIHNlbGVjdG9y Q2hlY2tlcihkb2N1bWVudCgpLCBzdGF0ZS5tb2RlKTsKICAgICBTZWxlY3RvckNoZWNrZXI6OlNl bGVjdG9yQ2hlY2tpbmdDb250ZXh0IGNvbnRleHQocnVsZURhdGEuc2VsZWN0b3IoKSwgc3RhdGUu ZWxlbWVudCwgU2VsZWN0b3JDaGVja2VyOjpWaXNpdGVkTWF0Y2hFbmFibGVkKTsKICAgICBjb250 ZXh0LmVsZW1lbnRTdHlsZSA9IHN0YXRlLnN0eWxlLmdldCgpOwogICAgIGNvbnRleHQuc2NvcGUg PSBzY29wZTsKQEAgLTIwOTgsNyArMjA5Nyw3IEBAIGJvb2wgU3R5bGVSZXNvbHZlcjo6Y2hlY2tS ZWdpb25TZWxlY3Rvcihjb25zdCBDU1NTZWxlY3RvciogcmVnaW9uU2VsZWN0b3IsIEVsZW1lCiAK ICAgICBtX3N0YXRlLnBzZXVkb1N0eWxlID0gTk9QU0VVRE87CiAKLSAgICBTZWxlY3RvckNoZWNr ZXIgc2VsZWN0b3JDaGVja2VyKGRvY3VtZW50KCkpOworICAgIFNlbGVjdG9yQ2hlY2tlciBzZWxl Y3RvckNoZWNrZXIoZG9jdW1lbnQoKSwgU2VsZWN0b3JDaGVja2VyOjpSZXNvbHZpbmdTdHlsZSk7 CiAgICAgZm9yIChjb25zdCBDU1NTZWxlY3RvciogcyA9IHJlZ2lvblNlbGVjdG9yOyBzOyBzID0g Q1NTU2VsZWN0b3JMaXN0OjpuZXh0KHMpKQogICAgICAgICBpZiAoc2VsZWN0b3JDaGVja2VyLm1h dGNoZXMocywgcmVnaW9uRWxlbWVudCkpCiAgICAgICAgICAgICByZXR1cm4gdHJ1ZTsKZGlmZiAt LWdpdCBhL1NvdXJjZS9XZWJDb3JlL2RvbS9TZWxlY3RvclF1ZXJ5LmNwcCBiL1NvdXJjZS9XZWJD b3JlL2RvbS9TZWxlY3RvclF1ZXJ5LmNwcAppbmRleCBjNTM3MTcwYjc2NGEzY2NlYzhhZmQ2YWVm NjNkMWFjOTgzNjE2YWFhLi4zNTZiZjMxZTM4ZTU1ODE1ODNkMTIyY2EyNmNiM2UyNWIzOWQ2MWU5 IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9kb20vU2VsZWN0b3JRdWVyeS5jcHAKKysrIGIv U291cmNlL1dlYkNvcmUvZG9tL1NlbGVjdG9yUXVlcnkuY3BwCkBAIC0xNTIsMjEgKzE1MiwxOSBA QCBTZWxlY3RvclF1ZXJ5OjpTZWxlY3RvclF1ZXJ5KGNvbnN0IENTU1NlbGVjdG9yTGlzdCYgc2Vs ZWN0b3JMaXN0KQogCiBib29sIFNlbGVjdG9yUXVlcnk6Om1hdGNoZXMoRWxlbWVudCogZWxlbWVu dCkgY29uc3QKIHsKLSAgICBTZWxlY3RvckNoZWNrZXIgc2VsZWN0b3JDaGVja2VyKGVsZW1lbnQt PmRvY3VtZW50KCkpOworICAgIFNlbGVjdG9yQ2hlY2tlciBzZWxlY3RvckNoZWNrZXIoZWxlbWVu dC0+ZG9jdW1lbnQoKSwgU2VsZWN0b3JDaGVja2VyOjpSZXNvbHZpbmdTdHlsZSk7CiAgICAgcmV0 dXJuIG1fc2VsZWN0b3JzLm1hdGNoZXMoc2VsZWN0b3JDaGVja2VyLCBlbGVtZW50KTsKIH0KIAog UGFzc1JlZlB0cjxOb2RlTGlzdD4gU2VsZWN0b3JRdWVyeTo6cXVlcnlBbGwoTm9kZSogcm9vdE5v ZGUpIGNvbnN0CiB7Ci0gICAgU2VsZWN0b3JDaGVja2VyIHNlbGVjdG9yQ2hlY2tlcihyb290Tm9k ZS0+ZG9jdW1lbnQoKSk7Ci0gICAgc2VsZWN0b3JDaGVja2VyLnNldE1vZGUoU2VsZWN0b3JDaGVj a2VyOjpRdWVyeWluZ1J1bGVzKTsKKyAgICBTZWxlY3RvckNoZWNrZXIgc2VsZWN0b3JDaGVja2Vy KHJvb3ROb2RlLT5kb2N1bWVudCgpLCBTZWxlY3RvckNoZWNrZXI6OlF1ZXJ5aW5nUnVsZXMpOwog ICAgIHJldHVybiBtX3NlbGVjdG9ycy5xdWVyeUFsbChzZWxlY3RvckNoZWNrZXIsIHJvb3ROb2Rl KTsKIH0KIAogUGFzc1JlZlB0cjxFbGVtZW50PiBTZWxlY3RvclF1ZXJ5OjpxdWVyeUZpcnN0KE5v ZGUqIHJvb3ROb2RlKSBjb25zdAogewotICAgIFNlbGVjdG9yQ2hlY2tlciBzZWxlY3RvckNoZWNr ZXIocm9vdE5vZGUtPmRvY3VtZW50KCkpOwotICAgIHNlbGVjdG9yQ2hlY2tlci5zZXRNb2RlKFNl bGVjdG9yQ2hlY2tlcjo6UXVlcnlpbmdSdWxlcyk7CisgICAgU2VsZWN0b3JDaGVja2VyIHNlbGVj dG9yQ2hlY2tlcihyb290Tm9kZS0+ZG9jdW1lbnQoKSwgU2VsZWN0b3JDaGVja2VyOjpRdWVyeWlu Z1J1bGVzKTsKICAgICByZXR1cm4gbV9zZWxlY3RvcnMucXVlcnlGaXJzdChzZWxlY3RvckNoZWNr ZXIsIHJvb3ROb2RlKTsKIH0KIApkaWZmIC0tZ2l0IGEvU291cmNlL1dlYkNvcmUvaHRtbC9zaGFk b3cvQ29udGVudFNlbGVjdG9yUXVlcnkuY3BwIGIvU291cmNlL1dlYkNvcmUvaHRtbC9zaGFkb3cv Q29udGVudFNlbGVjdG9yUXVlcnkuY3BwCmluZGV4IDUyYTBhYzVhMWY5MmZhZGNlNmIwMzNjNDhj MGRlNjEzMGRjOGM2ZDYuLjljZjE5NTYyNzU0NDNlNzk2YzIzNzM2NDZiZjRjNDBjOWMwYzkyYjQg MTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJDb3JlL2h0bWwvc2hhZG93L0NvbnRlbnRTZWxlY3RvclF1 ZXJ5LmNwcAorKysgYi9Tb3VyY2UvV2ViQ29yZS9odG1sL3NoYWRvdy9Db250ZW50U2VsZWN0b3JR dWVyeS5jcHAKQEAgLTM2LDkgKzM2LDggQEAKIG5hbWVzcGFjZSBXZWJDb3JlIHsKIAogQ29udGVu dFNlbGVjdG9yQ2hlY2tlcjo6Q29udGVudFNlbGVjdG9yQ2hlY2tlcihEb2N1bWVudCogZG9jdW1l bnQpCi0gICAgOiBtX3NlbGVjdG9yQ2hlY2tlcihkb2N1bWVudCkKKyAgICA6IG1fc2VsZWN0b3JD aGVja2VyKGRvY3VtZW50LCBTZWxlY3RvckNoZWNrZXI6OkNvbGxlY3RpbmdSdWxlcykKIHsKLSAg ICBtX3NlbGVjdG9yQ2hlY2tlci5zZXRNb2RlKFNlbGVjdG9yQ2hlY2tlcjo6Q29sbGVjdGluZ1J1 bGVzKTsKIH0KIAogYm9vbCBDb250ZW50U2VsZWN0b3JDaGVja2VyOjpjaGVja0NvbnRlbnRTZWxl Y3Rvcihjb25zdCBDU1NTZWxlY3Rvciogc2VsZWN0b3IsIGNvbnN0IFZlY3RvcjxSZWZQdHI8Tm9k ZT4gPiYgc2libGluZ3MsIGludCBudGgpIGNvbnN0Cg==