109586 2013-02-12 07:48:46 -0800 Remove remaining traces of Web Intents 2013-02-12 13:23:15 -0800 1 1 1 Unclassified WebKit WebCore Misc. 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 109501 1 cdumez cdumez eric gyuyoung.kim mifenton ojan.autocc rakuco rwlbuis thakis tonikitoo webkit.review.bot yong.li.webkit zan oldest_to_newest 830940 0 cdumez 2013-02-12 07:48:46 -0800 There are still traces of Web Intents, especially in build system related files. 830951 1 187868 cdumez 2013-02-12 07:58:55 -0800 Created attachment 187868 Patch 830993 2 187868 thakis 2013-02-12 09:02:35 -0800 Comment on attachment 187868 Patch Thanks! I used a whitelist of file extensions when doing `git grep`, which in hindsight wasn't a great idea. Without the whitelist, I see there's another use in Source/WebCore/UseJSC.cmake – can you remove that too? 831058 3 thakis 2013-02-12 10:28:35 -0800 (In reply to comment #2) > (From update of attachment 187868 [details]) > Thanks! I used a whitelist of file extensions when doing `git grep`, which in hindsight wasn't a great idea. > > Without the whitelist, I see there's another use in Source/WebCore/UseJSC.cmake – can you remove that too? …nevermind, that already got removed in r142570. 831193 4 187868 webkit.review.bot 2013-02-12 13:23:10 -0800 Comment on attachment 187868 Patch Clearing flags on attachment: 187868 Committed r142664: <http://trac.webkit.org/changeset/142664> 831194 5 webkit.review.bot 2013-02-12 13:23:15 -0800 All reviewed patches have been landed. Closing bug. 187868 2013-02-12 07:58:55 -0800 2013-02-12 13:23:10 -0800 Patch 109586_web_intents_removal.patch text/plain 4967 cdumez ZGlmZiAtLWdpdCBhL0NoYW5nZUxvZyBiL0NoYW5nZUxvZwppbmRleCBmOGUyNjM0Li41NTQxMDlm IDEwMDY0NAotLS0gYS9DaGFuZ2VMb2cKKysrIGIvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTYgQEAK KzIwMTMtMDItMTIgIENocmlzdG9waGUgRHVtZXogIDxjaC5kdW1lekBzaXNhLnNhbXN1bmcuY29t PgorCisgICAgICAgIFJlbW92ZSByZW1haW5pbmcgdHJhY2VzIG9mIFdlYiBJbnRlbnRzCisgICAg ICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xMDk1ODYKKworICAg ICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBSZW1vdmUgcmVmZXJl bmNlcyB0byBXZWIgSW50ZW50cyBmcm9tIENNYWtlIGZpbGVzIGFzIHRoZSBmdW5jdGlvbmFsaXR5 CisgICAgICAgIHdhcyByZW1vdmVkIGluIHIxNDI1NDkuCisKKyAgICAgICAgKiBTb3VyY2UvY21h a2UvV2ViS2l0RmVhdHVyZXMuY21ha2U6CisgICAgICAgICogU291cmNlL2NtYWtlY29uZmlnLmgu Y21ha2U6CisKIDIwMTMtMDItMTIgIFphbiBEb2JlcnNlayAgPHpkb2JlcnNla0BpZ2FsaWEuY29t PgogCiAgICAgICAgIFJlbW92ZSBFTkFCTEVfWEhSX1JFU1BPTlNFX0JMT0IgaGFuZGxpbmcgZnJv bSB2YXJpb3VzIGJ1aWxkIHN5c3RlbXMKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL0NoYW5n ZUxvZyBiL1NvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZwppbmRleCAwZmZiNzcyLi45Y2ViOGU3IDEw MDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKKysrIGIvU291cmNlL1dlYkNvcmUv Q2hhbmdlTG9nCkBAIC0xLDMgKzEsMTggQEAKKzIwMTMtMDItMTIgIENocmlzdG9waGUgRHVtZXog IDxjaC5kdW1lekBzaXNhLnNhbXN1bmcuY29tPgorCisgICAgICAgIFJlbW92ZSByZW1haW5pbmcg dHJhY2VzIG9mIFdlYiBJbnRlbnRzCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3No b3dfYnVnLmNnaT9pZD0xMDk1ODYKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMh KS4KKworICAgICAgICBSZW1vdmUgcmVtYWluaW5nIHRyYWNlcyBvZiBXZWIgSW50ZW50cyBhcyB0 aGUgZnVuY3Rpb25hbGl0eSB3YXMKKyAgICAgICAgcmVtb3ZlZCBpbiByMTQyNTQ5LgorCisgICAg ICAgIE5vIG5ldyB0ZXN0cywgbm8gYmVoYXZpb3IgY2hhbmdlIGZvciBsYXlvdXQgdGVzdHMuCisK KyAgICAgICAgKiBHTlVtYWtlZmlsZS5mZWF0dXJlcy5hbS5pbjoKKyAgICAgICAgKiBodG1sL0hU TUxUYWdOYW1lcy5pbjoKKwogMjAxMy0wMi0xMiAgQnJ1bm8gZGUgT2xpdmVpcmEgQWJpbmFkZXIg IDxicnVuby5hYmluYWRlckBiYXN5c2tvbS5jb20+CiAKICAgICAgICAgW1RleE1hcF0gQXBwbHkg ZnJhbWVzLXBlci1zZWNvbmQgZGVidWcgY291bnRlciB0byBXSzEuCmRpZmYgLS1naXQgYS9Tb3Vy Y2UvV2ViQ29yZS9HTlVtYWtlZmlsZS5mZWF0dXJlcy5hbS5pbiBiL1NvdXJjZS9XZWJDb3JlL0dO VW1ha2VmaWxlLmZlYXR1cmVzLmFtLmluCmluZGV4IDdhNWY5ZTkuLmE2ZGM0MzkgMTAwNjQ0Ci0t LSBhL1NvdXJjZS9XZWJDb3JlL0dOVW1ha2VmaWxlLmZlYXR1cmVzLmFtLmluCisrKyBiL1NvdXJj ZS9XZWJDb3JlL0dOVW1ha2VmaWxlLmZlYXR1cmVzLmFtLmluCkBAIC05OSw4ICs5OSw2IEBAIGZl YXR1cmVfZGVmaW5lc19kZWZhdWx0cyArPSBcCiAJRU5BQkxFX1ZJREVPX1RSQUNLPTAgXAogCUVO QUJMRV9XRUJHTD0xIFwKIAlFTkFCTEVfV0VCX0FVRElPPTAgXAotCUVOQUJMRV9XRUJfSU5URU5U Uz0wIFwKLQlFTkFCTEVfV0VCX0lOVEVOVFNfVEFHPTAgXAogCUVOQUJMRV9XRUJfU09DS0VUUz0x IFwKIAlFTkFCTEVfV0VCX1RJTUlORz0xIFwKIAlFTkFCTEVfV09SS0VSUz0xIFwKZGlmZiAtLWdp dCBhL1NvdXJjZS9XZWJDb3JlL2h0bWwvSFRNTFRhZ05hbWVzLmluIGIvU291cmNlL1dlYkNvcmUv aHRtbC9IVE1MVGFnTmFtZXMuaW4KaW5kZXggMmE3OTZkNi4uNTIwMjFiYyAxMDA2NDQKLS0tIGEv U291cmNlL1dlYkNvcmUvaHRtbC9IVE1MVGFnTmFtZXMuaW4KKysrIGIvU291cmNlL1dlYkNvcmUv aHRtbC9IVE1MVGFnTmFtZXMuaW4KQEAgLTY5LDcgKzY5LDYgQEAgaWZyYW1lIGludGVyZmFjZU5h bWU9SFRNTElGcmFtZUVsZW1lbnQKIGltYWdlIG1hcFRvVGFnTmFtZT1pbWcKIGltZyBpbnRlcmZh Y2VOYW1lPUhUTUxJbWFnZUVsZW1lbnQsIGNvbnN0cnVjdG9yTmVlZHNGb3JtRWxlbWVudAogaW5w dXQgY29uc3RydWN0b3JOZWVkc0Zvcm1FbGVtZW50LCBjb25zdHJ1Y3Rvck5lZWRzQ3JlYXRlZEJ5 UGFyc2VyCi1pbnRlbnQgY29uZGl0aW9uYWw9V0VCX0lOVEVOVFNfVEFHCiBpbnMgaW50ZXJmYWNl TmFtZT1IVE1MTW9kRWxlbWVudAogaXNpbmRleCBpbnRlcmZhY2VOYW1lPUhUTUxVbmtub3duRWxl bWVudAoga2JkIGludGVyZmFjZU5hbWU9SFRNTEVsZW1lbnQKZGlmZiAtLWdpdCBhL1NvdXJjZS9X ZWJLaXQvYmxhY2tiZXJyeS9DaGFuZ2VMb2cgYi9Tb3VyY2UvV2ViS2l0L2JsYWNrYmVycnkvQ2hh bmdlTG9nCmluZGV4IDVkMTAyMzAuLjE1NGY0ZjUgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQv YmxhY2tiZXJyeS9DaGFuZ2VMb2cKKysrIGIvU291cmNlL1dlYktpdC9ibGFja2JlcnJ5L0NoYW5n ZUxvZwpAQCAtMSwzICsxLDE1IEBACisyMDEzLTAyLTEyICBDaHJpc3RvcGhlIER1bWV6ICA8Y2gu ZHVtZXpAc2lzYS5zYW1zdW5nLmNvbT4KKworICAgICAgICBSZW1vdmUgcmVtYWluaW5nIHRyYWNl cyBvZiBXZWIgSW50ZW50cworICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1 Zy5jZ2k/aWQ9MTA5NTg2CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisK KyAgICAgICAgUmVtb3ZlIHJlbWFpbmluZyB0cmFjZXMgb2YgV2ViIEludGVudHMgZnJvbSBCbGFj a2JlcnJ5IHBvcnQKKyAgICAgICAgY29uZmlndXJhdGlvbiBhcyB0aGUgZnVuY3Rpb25hbGl0eSB3 YXMgcmVtb3ZlZCBpbiByMTQyNTQ5LgorCisgICAgICAgICogV2ViQ29yZVN1cHBvcnQvQWJvdXRE YXRhRW5hYmxlRmVhdHVyZXMuaW46CisKIDIwMTMtMDItMTIgIFphbiBEb2JlcnNlayAgPHpkb2Jl cnNla0BpZ2FsaWEuY29tPgogCiAgICAgICAgIFJlbW92ZSBFTkFCTEVfWEhSX1JFU1BPTlNFX0JM T0IgaGFuZGxpbmcgZnJvbSB2YXJpb3VzIGJ1aWxkIHN5c3RlbXMKZGlmZiAtLWdpdCBhL1NvdXJj ZS9XZWJLaXQvYmxhY2tiZXJyeS9XZWJDb3JlU3VwcG9ydC9BYm91dERhdGFFbmFibGVGZWF0dXJl cy5pbiBiL1NvdXJjZS9XZWJLaXQvYmxhY2tiZXJyeS9XZWJDb3JlU3VwcG9ydC9BYm91dERhdGFF bmFibGVGZWF0dXJlcy5pbgppbmRleCA0Y2VlYzg1Li5lNmRjOGIxIDEwMDY0NAotLS0gYS9Tb3Vy Y2UvV2ViS2l0L2JsYWNrYmVycnkvV2ViQ29yZVN1cHBvcnQvQWJvdXREYXRhRW5hYmxlRmVhdHVy ZXMuaW4KKysrIGIvU291cmNlL1dlYktpdC9ibGFja2JlcnJ5L1dlYkNvcmVTdXBwb3J0L0Fib3V0 RGF0YUVuYWJsZUZlYXR1cmVzLmluCkBAIC0xOTgsOCArMTk4LDYgQEAgV0VCX0FSQ0hJVkUKIFdF Ql9BVURJTwogV0VCRE9NCiBXRUJHTAotV0VCX0lOVEVOVFMKLVdFQl9JTlRFTlRTX1RBRwogV0VC S0lUMgogV0VCX1BST0NFU1NfU0FOREJPWAogV0VCX1NPQ0tFVFMKZGlmZiAtLWdpdCBhL1NvdXJj ZS9jbWFrZS9XZWJLaXRGZWF0dXJlcy5jbWFrZSBiL1NvdXJjZS9jbWFrZS9XZWJLaXRGZWF0dXJl cy5jbWFrZQppbmRleCBjN2JkMjA0Li43Y2Q2N2ZiIDEwMDY0NAotLS0gYS9Tb3VyY2UvY21ha2Uv V2ViS2l0RmVhdHVyZXMuY21ha2UKKysrIGIvU291cmNlL2NtYWtlL1dlYktpdEZlYXR1cmVzLmNt YWtlCkBAIC0xMjIsOCArMTIyLDYgQEAgbWFjcm8oV0VCS0lUX09QVElPTl9CRUdJTikKICAgICBX RUJLSVRfT1BUSU9OX0RFRklORShFTkFCTEVfVklERU8gIlRvZ2dsZSBWaWRlbyBzdXBwb3J0IiBP RkYpCiAgICAgV0VCS0lUX09QVElPTl9ERUZJTkUoRU5BQkxFX1ZJREVPX1RSQUNLICJUb2dnbGUg VHJhY2sgc3VwcG9ydCBmb3IgSFRNTDUgdmlkZW8iIE9GRikKICAgICBXRUJLSVRfT1BUSU9OX0RF RklORShFTkFCTEVfV0VCX0FVRElPICJUb2dnbGUgV2ViIEF1ZGlvIHN1cHBvcnQiIE9GRikKLSAg ICBXRUJLSVRfT1BUSU9OX0RFRklORShFTkFCTEVfV0VCX0lOVEVOVFMgIlRvZ2dsZSBXZWIgSW50 ZW50cyBzdXBwb3J0IiBPRkYpCi0gICAgV0VCS0lUX09QVElPTl9ERUZJTkUoRU5BQkxFX1dFQl9J TlRFTlRTX1RBRyAiVG9nZ2xlIEhUTUxJbnRlbnRFbGVtZW50IHRhZyBzdXBwb3J0IiBPRkYpCiAg ICAgV0VCS0lUX09QVElPTl9ERUZJTkUoRU5BQkxFX1dFQl9TT0NLRVRTICJUb2dnbGUgV2ViIFNv Y2tldHMgc3VwcG9ydCIgT04pCiAgICAgV0VCS0lUX09QVElPTl9ERUZJTkUoRU5BQkxFX1dFQl9U SU1JTkcgIlRvZ2dsZSBXZWIgVGltaW5nIHN1cHBvcnQiIE9GRikKICAgICBXRUJLSVRfT1BUSU9O X0RFRklORShFTkFCTEVfV0VCR0wgIlRvZ2dsZSAzRCBjYW52YXMgKFdlYkdMKSBzdXBwb3J0IiBP RkYpCmRpZmYgLS1naXQgYS9Tb3VyY2UvY21ha2Vjb25maWcuaC5jbWFrZSBiL1NvdXJjZS9jbWFr ZWNvbmZpZy5oLmNtYWtlCmluZGV4IGNkNDQ4ZmMuLjk1YmVlMGQgMTAwNjQ0Ci0tLSBhL1NvdXJj ZS9jbWFrZWNvbmZpZy5oLmNtYWtlCisrKyBiL1NvdXJjZS9jbWFrZWNvbmZpZy5oLmNtYWtlCkBA IC0xMTksOCArMTE5LDYgQEAKICNjbWFrZWRlZmluZTAxIEVOQUJMRV9WSUVXUE9SVF9SRUZMT1cK ICNjbWFrZWRlZmluZTAxIEVOQUJMRV9XRUJHTAogI2NtYWtlZGVmaW5lMDEgRU5BQkxFX1dFQl9B VURJTwotI2NtYWtlZGVmaW5lMDEgRU5BQkxFX1dFQl9JTlRFTlRTCi0jY21ha2VkZWZpbmUwMSBF TkFCTEVfV0VCX0lOVEVOVFNfVEFHCiAjY21ha2VkZWZpbmUwMSBFTkFCTEVfV0VCX1NPQ0tFVFMK ICNjbWFrZWRlZmluZTAxIEVOQUJMRV9XRUJfVElNSU5HCiAjY21ha2VkZWZpbmUwMSBFTkFCTEVf V09SS0VSUwo=