109076 2013-02-06 11:30:06 -0800 Fix CompactHTMLToken's copy ctor to copy all fields 2013-02-06 13:51:30 -0800 1 1 1 Unclassified WebKit New Bugs 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 106127 1 tonyg tonyg abarth eric ojan.autocc webkit.review.bot oldest_to_newest 826591 0 tonyg 2013-02-06 11:30:06 -0800 Fix CompactHTMLToken's copy ctor to copy all fields 826594 1 186883 tonyg 2013-02-06 11:31:08 -0800 Created attachment 186883 Patch 826643 2 186883 darin 2013-02-06 12:32:33 -0800 Comment on attachment 186883 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=186883&action=review > Source/WebCore/html/parser/CompactHTMLToken.cpp:91 > CompactHTMLToken::CompactHTMLToken(const CompactHTMLToken& other) Sure would be nice if this could have been left to the compiler to generate. All we’d need would be a version of OwnPtr that knows how to clone, but I suppose that’s a lot to ask. > Source/WebCore/html/parser/CompactHTMLToken.cpp:92 > : m_type(other.type()) Seems to me that it’s an anti-pattern to use getter functions in copy constructors like this one. 826685 3 186904 tonyg 2013-02-06 13:03:07 -0800 Created attachment 186904 Patch for landing 826686 4 tonyg 2013-02-06 13:03:52 -0800 (In reply to comment #2) > (From update of attachment 186883 [details]) > View in context: https://bugs.webkit.org/attachment.cgi?id=186883&action=review > > > Source/WebCore/html/parser/CompactHTMLToken.cpp:91 > > CompactHTMLToken::CompactHTMLToken(const CompactHTMLToken& other) > > Sure would be nice if this could have been left to the compiler to generate. All we’d need would be a version of OwnPtr that knows how to clone, but I suppose that’s a lot to ask. Good point, but I'll leave that for another day if you don't mind. > > > Source/WebCore/html/parser/CompactHTMLToken.cpp:92 > > : m_type(other.type()) > > Seems to me that it’s an anti-pattern to use getter functions in copy constructors like this one. Fixed. 826728 5 186904 webkit.review.bot 2013-02-06 13:51:26 -0800 Comment on attachment 186904 Patch for landing Clearing flags on attachment: 186904 Committed r142029: <http://trac.webkit.org/changeset/142029> 826729 6 webkit.review.bot 2013-02-06 13:51:30 -0800 All reviewed patches have been landed. Closing bug. 186883 2013-02-06 11:31:08 -0800 2013-02-06 13:03:04 -0800 Patch bug-109076-20130206112745.patch text/plain 1717 tonyg U3VidmVyc2lvbiBSZXZpc2lvbjogMTQyMDA1CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggOTY3YmJmMmFkNjZjODVm NmU1NmViM2M2MDhjN2VmZjk5ZmRmZTY2YS4uMTI4YTU3MzRiYzk1MjBkMDVjOTU1NWYyMjllOWUw MzBiZjdhZmNhYSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE3IEBACisyMDEzLTAyLTA2ICBUb255 IEdlbnRpbGNvcmUgIDx0b255Z0BjaHJvbWl1bS5vcmc+CisKKyAgICAgICAgRml4IENvbXBhY3RI VE1MVG9rZW4ncyBjb3B5IGN0b3IgdG8gY29weSBhbGwgZmllbGRzCisgICAgICAgIGh0dHBzOi8v YnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xMDkwNzYKKworICAgICAgICBSZXZpZXdl ZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBUaGlzIHdhcyBpbnRyb2R1Y2VkIGJ5IG1l IGluIHIxNDIwMDQuIFdpdGhvdXQgdGhpcyBwYXRjaCB3ZSBmYWlsIGFsbCB0ZXN0cyB3aGVuIHVz aW5nIHRoZSBiYWNrZ3JvdW5kIHBhcnNlci4KKworICAgICAgICBObyBuZXcgdGVzdHMgYmVjYXVz ZSBubyBuZXcgZnVuY3Rpb25hbGl0eS4KKworICAgICAgICAqIGh0bWwvcGFyc2VyL0NvbXBhY3RI VE1MVG9rZW4uY3BwOgorICAgICAgICAoV2ViQ29yZTo6Q29tcGFjdEhUTUxUb2tlbjo6Q29tcGFj dEhUTUxUb2tlbik6CisKIDIwMTMtMDItMDYgIEpvbmF0aG9uIEpvbmdzbWEgIDxqb25hdGhvbi5q b25nc21hQGNvbGxhYm9yYS5jb20+CiAKICAgICAgICAgW0dTdHJlYW1lcl0gTWVkaWFQbGF5ZXIn cyBjb2RlIGlzIG5vdCBlYXNpbHkgcmV1c2FibGUgYnkgb3RoZXIgR1N0cmVhbWVyLWJhc2VkIHBs YXllcnMKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL2h0bWwvcGFyc2VyL0NvbXBhY3RIVE1M VG9rZW4uY3BwIGIvU291cmNlL1dlYkNvcmUvaHRtbC9wYXJzZXIvQ29tcGFjdEhUTUxUb2tlbi5j cHAKaW5kZXggZDhhNTExMDY5NzIxMDQ3ZGE3MDMzMzY0YjY0NDgwMDA2NDdiZWRlMy4uMTk5OGI1 ZDczMDc4MGRhODZhNWQ2NjcyNzU4NDRhYmZlYTllYjUyYiAxMDA2NDQKLS0tIGEvU291cmNlL1dl YkNvcmUvaHRtbC9wYXJzZXIvQ29tcGFjdEhUTUxUb2tlbi5jcHAKKysrIGIvU291cmNlL1dlYkNv cmUvaHRtbC9wYXJzZXIvQ29tcGFjdEhUTUxUb2tlbi5jcHAKQEAgLTkwLDggKzkwLDExIEBAIENv bXBhY3RIVE1MVG9rZW46OkNvbXBhY3RIVE1MVG9rZW4oY29uc3QgSFRNTFRva2VuKiB0b2tlbiwg Y29uc3QgVGV4dFBvc2l0aW9uJiB0CiAKIENvbXBhY3RIVE1MVG9rZW46OkNvbXBhY3RIVE1MVG9r ZW4oY29uc3QgQ29tcGFjdEhUTUxUb2tlbiYgb3RoZXIpCiAgICAgOiBtX3R5cGUob3RoZXIudHlw ZSgpKQorICAgICwgbV9zZWxmQ2xvc2luZyhvdGhlci5zZWxmQ2xvc2luZygpKQogICAgICwgbV9p c0FsbDhCaXREYXRhKG90aGVyLmlzQWxsOEJpdERhdGEoKSkKICAgICAsIG1fZG9jdHlwZUZvcmNl c1F1aXJrcyhvdGhlci5kb2N0eXBlRm9yY2VzUXVpcmtzKCkpCisgICAgLCBtX2RhdGEob3RoZXIu ZGF0YSgpKQorICAgICwgbV9hdHRyaWJ1dGVzKG90aGVyLmF0dHJpYnV0ZXMoKSkKICAgICAsIG1f dGV4dFBvc2l0aW9uKG90aGVyLnRleHRQb3NpdGlvbigpKQogewogICAgIGlmIChvdGhlci54c3NJ bmZvKCkpCg== 186904 2013-02-06 13:03:07 -0800 2013-02-06 13:51:26 -0800 Patch for landing bug-109076-20130206125944.patch text/plain 2176 tonyg U3VidmVyc2lvbiBSZXZpc2lvbjogMTQyMDIwCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggOTNmODg3ZDU3YjliNjli MzU1ZmM5ZjM0NGQ1ZTQ4NGExZWQ0MmRlOS4uNTJhNzM3ZWEzMGVkZTEyNWU3ZjliZDAyMzgzZmFj ODFmZjcyZTMwOCAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE5IEBACisyMDEzLTAyLTA2ICBUb255 IEdlbnRpbGNvcmUgIDx0b255Z0BjaHJvbWl1bS5vcmc+CisKKyAgICAgICAgRml4IENvbXBhY3RI VE1MVG9rZW4ncyBjb3B5IGN0b3IgdG8gY29weSBhbGwgZmllbGRzCisgICAgICAgIGh0dHBzOi8v YnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xMDkwNzYKKworICAgICAgICBSZXZpZXdl ZCBieSBBZGFtIEJhcnRoLgorCisgICAgICAgIFRoaXMgd2FzIGludHJvZHVjZWQgYnkgbWUgaW4g cjE0MjAwNC4gV2l0aG91dCB0aGlzIHBhdGNoIHdlIGZhaWwgYWxsIHRlc3RzIHdoZW4gdXNpbmcg dGhlIGJhY2tncm91bmQgcGFyc2VyLgorCisgICAgICAgIEFsc28gZG9uJ3QgdXNlIGdldHRlcnMg aW4gY29weSBjdG9yLgorCisgICAgICAgIE5vIG5ldyB0ZXN0cyBiZWNhdXNlIG5vIG5ldyBmdW5j dGlvbmFsaXR5LgorCisgICAgICAgICogaHRtbC9wYXJzZXIvQ29tcGFjdEhUTUxUb2tlbi5jcHA6 CisgICAgICAgIChXZWJDb3JlOjpDb21wYWN0SFRNTFRva2VuOjpDb21wYWN0SFRNTFRva2VuKToK KwogMjAxMy0wMi0wNiAgUHJhdmluIEQgIDxwcmF2aW5kLjJrNEBnbWFpbC5jb20+CiAKICAgICAg ICAgV2hlbiBhIGJsb2NrIGVsZW1lbnQgaXMgbWFkZSBpbmxpbmUgcG9zaXRpb25lZCBhbmQgaGFz IHN0YXRpYyBsZWZ0IGFuZCByaWdodCwgIGl0IGRvZXMgbm90IGZvbGxvdyBpbmxpbmUgZm9ybWF0 dGluZyBjb250ZXh0CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9odG1sL3BhcnNlci9Db21w YWN0SFRNTFRva2VuLmNwcCBiL1NvdXJjZS9XZWJDb3JlL2h0bWwvcGFyc2VyL0NvbXBhY3RIVE1M VG9rZW4uY3BwCmluZGV4IGQ4YTUxMTA2OTcyMTA0N2RhNzAzMzM2NGI2NDQ4MDAwNjQ3YmVkZTMu LjFmMTIyZjAzNzA0OGEwMjQyNmFjMjM2ODgzMTcxZDM4YjUzYzYxYjAgMTAwNjQ0Ci0tLSBhL1Nv dXJjZS9XZWJDb3JlL2h0bWwvcGFyc2VyL0NvbXBhY3RIVE1MVG9rZW4uY3BwCisrKyBiL1NvdXJj ZS9XZWJDb3JlL2h0bWwvcGFyc2VyL0NvbXBhY3RIVE1MVG9rZW4uY3BwCkBAIC04OSwxMyArODks MTYgQEAgQ29tcGFjdEhUTUxUb2tlbjo6Q29tcGFjdEhUTUxUb2tlbihjb25zdCBIVE1MVG9rZW4q IHRva2VuLCBjb25zdCBUZXh0UG9zaXRpb24mIHQKIH0KIAogQ29tcGFjdEhUTUxUb2tlbjo6Q29t cGFjdEhUTUxUb2tlbihjb25zdCBDb21wYWN0SFRNTFRva2VuJiBvdGhlcikKLSAgICA6IG1fdHlw ZShvdGhlci50eXBlKCkpCi0gICAgLCBtX2lzQWxsOEJpdERhdGEob3RoZXIuaXNBbGw4Qml0RGF0 YSgpKQotICAgICwgbV9kb2N0eXBlRm9yY2VzUXVpcmtzKG90aGVyLmRvY3R5cGVGb3JjZXNRdWly a3MoKSkKLSAgICAsIG1fdGV4dFBvc2l0aW9uKG90aGVyLnRleHRQb3NpdGlvbigpKQorICAgIDog bV90eXBlKG90aGVyLm1fdHlwZSkKKyAgICAsIG1fc2VsZkNsb3Npbmcob3RoZXIubV9zZWxmQ2xv c2luZykKKyAgICAsIG1faXNBbGw4Qml0RGF0YShvdGhlci5tX2lzQWxsOEJpdERhdGEpCisgICAg LCBtX2RvY3R5cGVGb3JjZXNRdWlya3Mob3RoZXIubV9kb2N0eXBlRm9yY2VzUXVpcmtzKQorICAg ICwgbV9kYXRhKG90aGVyLm1fZGF0YSkKKyAgICAsIG1fYXR0cmlidXRlcyhvdGhlci5tX2F0dHJp YnV0ZXMpCisgICAgLCBtX3RleHRQb3NpdGlvbihvdGhlci5tX3RleHRQb3NpdGlvbikKIHsKLSAg ICBpZiAob3RoZXIueHNzSW5mbygpKQotICAgICAgICBtX3hzc0luZm8gPSBhZG9wdFB0cihuZXcg WFNTSW5mbygqb3RoZXIueHNzSW5mbygpKSk7CisgICAgaWYgKG90aGVyLm1feHNzSW5mbykKKyAg ICAgICAgbV94c3NJbmZvID0gYWRvcHRQdHIobmV3IFhTU0luZm8oKm90aGVyLm1feHNzSW5mbykp OwogfQogCiBib29sIENvbXBhY3RIVE1MVG9rZW46OmlzU2FmZVRvU2VuZFRvQW5vdGhlclRocmVh ZCgpIGNvbnN0Cg==