109050 2013-02-06 07:12:52 -0800 Invalid code is generated for storing constants with baseindex addressing modes on ARM traditional. 2013-02-14 05:58:49 -0800 1 1 1 Unclassified WebKit JavaScriptCore 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 108645 1 zherczeg webkit-unassigned barraclough fpizlo laszlo.gombos oliver ossy webkit.review.bot oldest_to_newest 826420 0 zherczeg 2013-02-06 07:12:52 -0800 S1 scratch register, which should hold the constant value, is reused during the process. Fix attached. 826422 1 186850 zherczeg 2013-02-06 07:17:12 -0800 Created attachment 186850 patch 826424 2 zherczeg 2013-02-06 07:18:27 -0800 If we ever need bigger offsets, we can do that with a sequence of add/sub instructions. It will not be effective, but at least it will work. 827443 3 187090 zherczeg 2013-02-07 06:45:27 -0800 Created attachment 187090 improved patch Patch without assert. 827445 4 zherczeg 2013-02-07 06:46:31 -0800 Oliver, could you review it? 827649 5 187090 webkit.review.bot 2013-02-07 10:05:43 -0800 Comment on attachment 187090 improved patch Clearing flags on attachment: 187090 Committed r142146: <http://trac.webkit.org/changeset/142146> 827650 6 webkit.review.bot 2013-02-07 10:05:47 -0800 All reviewed patches have been landed. Closing bug. 186850 2013-02-06 07:17:12 -0800 2013-02-07 06:45:27 -0800 patch arm.patch text/plain 2187 zherczeg ZGlmZiAtLWdpdCBhL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9DaGFuZ2VMb2cgYi9Tb3VyY2UvSmF2 YVNjcmlwdENvcmUvQ2hhbmdlTG9nCmluZGV4IDMyNDRlYjQuLjFiOGRjMjYgMTAwNjQ0Ci0tLSBh L1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9DaGFuZ2VMb2cKKysrIGIvU291cmNlL0phdmFTY3JpcHRD b3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE2IEBACisyMDEzLTAyLTA2ICBab2x0YW4gSGVyY3pl ZyAgPHpoZXJjemVnQHdlYmtpdC5vcmc+CisKKyAgICAgICAgSW52YWxpZCBjb2RlIGlzIGdlbmVy YXRlZCBmb3Igc3RvcmluZyBjb25zdGFudHMgd2l0aCBiYXNlaW5kZXggYWRkcmVzc2luZyBtb2Rl cyBvbiBBUk0gdHJhZGl0aW9uYWwuCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3No b3dfYnVnLmNnaT9pZD0xMDkwNTAKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMh KS4KKworICAgICAgICBUaGUgUyEgc2NyYXRjaCByZWdpc3RlciBpcyByZXVzZWQsIGJ1dCBpdCBz aG91bGQgY29udGFpbiB0aGUgY29uc3RhbnQgdmFsdWUuCisKKyAgICAgICAgKiBhc3NlbWJsZXIv QVJNQXNzZW1ibGVyLmNwcDoKKyAgICAgICAgKEpTQzo6QVJNQXNzZW1ibGVyOjpiYXNlSW5kZXhU cmFuc2ZlcjMyKToKKyAgICAgICAgKEpTQzo6QVJNQXNzZW1ibGVyOjpiYXNlSW5kZXhUcmFuc2Zl cjE2KToKKwogMjAxMy0wMi0wNiAgSWx5YSBUaWtob25vdnNreSAgPGxvaXNsb0BjaHJvbWl1bS5v cmc+CiAKICAgICAgICAgV2ViIEluc3BlY3RvcjogTmF0aXZlIE1lbW9yeSBJbnN0cnVtZW50YXRp b246IGFzc2lnbiBjbGFzcyBuYW1lIHRvIHRoZSBoZWFwIGdyYXBoIG5vZGUgYXV0b21hdGljYWxs eQpkaWZmIC0tZ2l0IGEvU291cmNlL0phdmFTY3JpcHRDb3JlL2Fzc2VtYmxlci9BUk1Bc3NlbWJs ZXIuY3BwIGIvU291cmNlL0phdmFTY3JpcHRDb3JlL2Fzc2VtYmxlci9BUk1Bc3NlbWJsZXIuY3Bw CmluZGV4IDk2NTU1NTcuLjM5MjlhMjMgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9KYXZhU2NyaXB0Q29y ZS9hc3NlbWJsZXIvQVJNQXNzZW1ibGVyLmNwcAorKysgYi9Tb3VyY2UvSmF2YVNjcmlwdENvcmUv YXNzZW1ibGVyL0FSTUFzc2VtYmxlci5jcHAKQEAgLTI5Nyw4ICsyOTcsOSBAQCB2b2lkIEFSTUFz c2VtYmxlcjo6YmFzZUluZGV4VHJhbnNmZXIzMihEYXRhVHJhbnNmZXJUeXBlQSB0cmFuc2ZlclR5 cGUsIFJlZ2lzdGVySQogICAgICAgICByZXR1cm47CiAgICAgfQogCi0gICAgYWRkKEFSTVJlZ2lz dGVyczo6UzEsIGJhc2UsIG9wMik7Ci0gICAgZGF0YVRyYW5zZmVyMzIodHJhbnNmZXJUeXBlLCBz cmNEc3QsIEFSTVJlZ2lzdGVyczo6UzEsIG9mZnNldCk7CisgICAgQVNTRVJUKG9mZnNldCA8PSAw eGZmZmZmICYmIG9mZnNldCA+PSAtMHhmZmZmZik7CisgICAgYWRkKEFSTVJlZ2lzdGVyczo6UzAs IGJhc2UsIG9wMik7CisgICAgZGF0YVRyYW5zZmVyMzIodHJhbnNmZXJUeXBlLCBzcmNEc3QsIEFS TVJlZ2lzdGVyczo6UzAsIG9mZnNldCk7CiB9CiAKIHZvaWQgQVJNQXNzZW1ibGVyOjpkYXRhVHJh bnNmZXIxNihEYXRhVHJhbnNmZXJUeXBlQiB0cmFuc2ZlclR5cGUsIFJlZ2lzdGVySUQgc3JjRHN0 LCBSZWdpc3RlcklEIGJhc2UsIGludDMyX3Qgb2Zmc2V0KQpAQCAtMzMzLDggKzMzNCw5IEBAIHZv aWQgQVJNQXNzZW1ibGVyOjpiYXNlSW5kZXhUcmFuc2ZlcjE2KERhdGFUcmFuc2ZlclR5cGVCIHRy YW5zZmVyVHlwZSwgUmVnaXN0ZXJJCiAgICAgICAgIHJldHVybjsKICAgICB9CiAKLSAgICBhZGQo QVJNUmVnaXN0ZXJzOjpTMSwgYmFzZSwgbHNsKGluZGV4LCBzY2FsZSkpOwotICAgIGRhdGFUcmFu c2ZlcjE2KHRyYW5zZmVyVHlwZSwgc3JjRHN0LCBBUk1SZWdpc3RlcnM6OlMxLCBvZmZzZXQpOwor ICAgIEFTU0VSVChvZmZzZXQgPD0gMHhmZmZmICYmIG9mZnNldCA+PSAtMHhmZmZmKTsKKyAgICBh ZGQoQVJNUmVnaXN0ZXJzOjpTMCwgYmFzZSwgbHNsKGluZGV4LCBzY2FsZSkpOworICAgIGRhdGFU cmFuc2ZlcjE2KHRyYW5zZmVyVHlwZSwgc3JjRHN0LCBBUk1SZWdpc3RlcnM6OlMwLCBvZmZzZXQp OwogfQogCiB2b2lkIEFSTUFzc2VtYmxlcjo6ZGF0YVRyYW5zZmVyRmxvYXQoRGF0YVRyYW5zZmVy VHlwZUZsb2F0IHRyYW5zZmVyVHlwZSwgRlBSZWdpc3RlcklEIHNyY0RzdCwgUmVnaXN0ZXJJRCBi YXNlLCBpbnQzMl90IG9mZnNldCkK 187090 2013-02-07 06:45:27 -0800 2013-02-07 10:05:42 -0800 improved patch improved_arm.patch text/plain 2597 zherczeg ZGlmZiAtLWdpdCBhL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9DaGFuZ2VMb2cgYi9Tb3VyY2UvSmF2 YVNjcmlwdENvcmUvQ2hhbmdlTG9nCmluZGV4IDMyNDRlYjQuLjFiOGRjMjYgMTAwNjQ0Ci0tLSBh L1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9DaGFuZ2VMb2cKKysrIGIvU291cmNlL0phdmFTY3JpcHRD b3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE2IEBACisyMDEzLTAyLTA2ICBab2x0YW4gSGVyY3pl ZyAgPHpoZXJjemVnQHdlYmtpdC5vcmc+CisKKyAgICAgICAgSW52YWxpZCBjb2RlIGlzIGdlbmVy YXRlZCBmb3Igc3RvcmluZyBjb25zdGFudHMgd2l0aCBiYXNlaW5kZXggYWRkcmVzc2luZyBtb2Rl cyBvbiBBUk0gdHJhZGl0aW9uYWwuCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3No b3dfYnVnLmNnaT9pZD0xMDkwNTAKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMh KS4KKworICAgICAgICBUaGUgUyEgc2NyYXRjaCByZWdpc3RlciBpcyByZXVzZWQsIGJ1dCBpdCBz aG91bGQgY29udGFpbiB0aGUgY29uc3RhbnQgdmFsdWUuCisKKyAgICAgICAgKiBhc3NlbWJsZXIv QVJNQXNzZW1ibGVyLmNwcDoKKyAgICAgICAgKEpTQzo6QVJNQXNzZW1ibGVyOjpiYXNlSW5kZXhU cmFuc2ZlcjMyKToKKyAgICAgICAgKEpTQzo6QVJNQXNzZW1ibGVyOjpiYXNlSW5kZXhUcmFuc2Zl cjE2KToKKwogMjAxMy0wMi0wNiAgSWx5YSBUaWtob25vdnNreSAgPGxvaXNsb0BjaHJvbWl1bS5v cmc+CiAKICAgICAgICAgV2ViIEluc3BlY3RvcjogTmF0aXZlIE1lbW9yeSBJbnN0cnVtZW50YXRp b246IGFzc2lnbiBjbGFzcyBuYW1lIHRvIHRoZSBoZWFwIGdyYXBoIG5vZGUgYXV0b21hdGljYWxs eQpkaWZmIC0tZ2l0IGEvU291cmNlL0phdmFTY3JpcHRDb3JlL2Fzc2VtYmxlci9BUk1Bc3NlbWJs ZXIuY3BwIGIvU291cmNlL0phdmFTY3JpcHRDb3JlL2Fzc2VtYmxlci9BUk1Bc3NlbWJsZXIuY3Bw CmluZGV4IDk2NTU1NTcuLjY5MTJkMWUgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9KYXZhU2NyaXB0Q29y ZS9hc3NlbWJsZXIvQVJNQXNzZW1ibGVyLmNwcAorKysgYi9Tb3VyY2UvSmF2YVNjcmlwdENvcmUv YXNzZW1ibGVyL0FSTUFzc2VtYmxlci5jcHAKQEAgLTI5Nyw4ICsyOTcsMTUgQEAgdm9pZCBBUk1B c3NlbWJsZXI6OmJhc2VJbmRleFRyYW5zZmVyMzIoRGF0YVRyYW5zZmVyVHlwZUEgdHJhbnNmZXJU eXBlLCBSZWdpc3RlckkKICAgICAgICAgcmV0dXJuOwogICAgIH0KIAotICAgIGFkZChBUk1SZWdp c3RlcnM6OlMxLCBiYXNlLCBvcDIpOwotICAgIGRhdGFUcmFuc2ZlcjMyKHRyYW5zZmVyVHlwZSwg c3JjRHN0LCBBUk1SZWdpc3RlcnM6OlMxLCBvZmZzZXQpOworICAgIGlmIChvZmZzZXQgPD0gMHhm ZmZmZiAmJiBvZmZzZXQgPj0gLTB4ZmZmZmYpIHsKKyAgICAgICAgYWRkKEFSTVJlZ2lzdGVyczo6 UzAsIGJhc2UsIG9wMik7CisgICAgICAgIGRhdGFUcmFuc2ZlcjMyKHRyYW5zZmVyVHlwZSwgc3Jj RHN0LCBBUk1SZWdpc3RlcnM6OlMwLCBvZmZzZXQpOworICAgICAgICByZXR1cm47CisgICAgfQor CisgICAgbW92ZUltbShvZmZzZXQsIEFSTVJlZ2lzdGVyczo6UzApOworICAgIGFkZChBUk1SZWdp c3RlcnM6OlMwLCBBUk1SZWdpc3RlcnM6OlMwLCBvcDIpOworICAgIGR0clVwUmVnaXN0ZXIodHJh bnNmZXJUeXBlLCBzcmNEc3QsIGJhc2UsIEFSTVJlZ2lzdGVyczo6UzApOwogfQogCiB2b2lkIEFS TUFzc2VtYmxlcjo6ZGF0YVRyYW5zZmVyMTYoRGF0YVRyYW5zZmVyVHlwZUIgdHJhbnNmZXJUeXBl LCBSZWdpc3RlcklEIHNyY0RzdCwgUmVnaXN0ZXJJRCBiYXNlLCBpbnQzMl90IG9mZnNldCkKQEAg LTMzMyw4ICszNDAsMTcgQEAgdm9pZCBBUk1Bc3NlbWJsZXI6OmJhc2VJbmRleFRyYW5zZmVyMTYo RGF0YVRyYW5zZmVyVHlwZUIgdHJhbnNmZXJUeXBlLCBSZWdpc3RlckkKICAgICAgICAgcmV0dXJu OwogICAgIH0KIAotICAgIGFkZChBUk1SZWdpc3RlcnM6OlMxLCBiYXNlLCBsc2woaW5kZXgsIHNj YWxlKSk7Ci0gICAgZGF0YVRyYW5zZmVyMTYodHJhbnNmZXJUeXBlLCBzcmNEc3QsIEFSTVJlZ2lz dGVyczo6UzEsIG9mZnNldCk7CisgICAgQVJNV29yZCBvcDIgPSBsc2woaW5kZXgsIHNjYWxlKTsK KworICAgIGlmIChvZmZzZXQgPD0gMHhmZmZmICYmIG9mZnNldCA+PSAtMHhmZmZmKSB7CisgICAg ICAgIGFkZChBUk1SZWdpc3RlcnM6OlMwLCBiYXNlLCBvcDIpOworICAgICAgICBkYXRhVHJhbnNm ZXIxNih0cmFuc2ZlclR5cGUsIHNyY0RzdCwgQVJNUmVnaXN0ZXJzOjpTMCwgb2Zmc2V0KTsKKyAg ICAgICAgcmV0dXJuOworICAgIH0KKworICAgIG1vdmVJbW0ob2Zmc2V0LCBBUk1SZWdpc3RlcnM6 OlMwKTsKKyAgICBhZGQoQVJNUmVnaXN0ZXJzOjpTMCwgQVJNUmVnaXN0ZXJzOjpTMCwgb3AyKTsK KyAgICBoYWxmRHRyVXBSZWdpc3Rlcih0cmFuc2ZlclR5cGUsIHNyY0RzdCwgYmFzZSwgQVJNUmVn aXN0ZXJzOjpTMCk7CiB9CiAKIHZvaWQgQVJNQXNzZW1ibGVyOjpkYXRhVHJhbnNmZXJGbG9hdChE YXRhVHJhbnNmZXJUeXBlRmxvYXQgdHJhbnNmZXJUeXBlLCBGUFJlZ2lzdGVySUQgc3JjRHN0LCBS ZWdpc3RlcklEIGJhc2UsIGludDMyX3Qgb2Zmc2V0KQo=