108634 2013-02-01 06:59:37 -0800 [EFL][WK2] EWK2UnitTestBase.ewk_view_page_contents_get API test is sometimes failing 2013-02-07 10:51:26 -0800 1 1 1 Unclassified WebKit WebKit EFL 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 106440 106752 1 cdumez cdumez andersca ap benjamin gyuyoung.kim kling ky0.choi lucas.de.marchi naginenis rakuco sam tmpsantos webkit.review.bot oldest_to_newest 822730 0 cdumez 2013-02-01 06:59:37 -0800 EWK2UnitTestBase.ewk_view_page_contents_get APi test sometimes fail due to a fragile check in the test. This should be fixed. [ RUN ] EWK2UnitTestBase.ewk_view_page_contents_get /home/buildslave-1/webkit-buildslave/efl-linux-64-release-wk2/build/Source/WebKit2/UIProcess/API/efl/tests/test_ewk2_view.cpp:933: Failure Value of: strncmp(data + 359, lines, strlen(lines)) Actual: 1 Expected: 0 822738 1 186037 cdumez 2013-02-01 07:10:18 -0800 Created attachment 186037 Patch 822752 2 186037 naginenis 2013-02-01 07:24:21 -0800 Comment on attachment 186037 Patch LGTM 823391 3 186037 gyuyoung.kim 2013-02-01 16:00:33 -0800 Comment on attachment 186037 Patch Looks fine. 823782 4 cdumez 2013-02-03 01:24:22 -0800 Could someone please review this one? Our bots are currently red due to this API test failing. 827692 5 186037 webkit.review.bot 2013-02-07 10:51:21 -0800 Comment on attachment 186037 Patch Clearing flags on attachment: 186037 Committed r142153: <http://trac.webkit.org/changeset/142153> 827693 6 webkit.review.bot 2013-02-07 10:51:26 -0800 All reviewed patches have been landed. Closing bug. 186037 2013-02-01 07:10:18 -0800 2013-02-07 10:51:21 -0800 Patch 108634_html_utest_fix.patch text/plain 3123 cdumez ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJLaXQyL0NoYW5nZUxvZyBiL1NvdXJjZS9XZWJLaXQyL0No YW5nZUxvZwppbmRleCBlNjNkM2ZiLi41OTg4NDY0IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViS2l0 Mi9DaGFuZ2VMb2cKKysrIGIvU291cmNlL1dlYktpdDIvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMjAg QEAKKzIwMTMtMDItMDEgIENocmlzdG9waGUgRHVtZXogIDxkY2hyaXNAZ21haWwuY29tPgorCisg ICAgICAgIFtFRkxdW1dLMl0gRVdLMlVuaXRUZXN0QmFzZS5ld2tfdmlld19wYWdlX2NvbnRlbnRz X2dldCBBUEkgdGVzdCBpcyBzb21ldGltZXMgZmFpbGluZworICAgICAgICBodHRwczovL2J1Z3Mu d2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTA4NjM0CisKKyAgICAgICAgUmV2aWV3ZWQgYnkg Tk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgVXNlIG1vcmUgcm9idXN0IGRhdGEgdmFsaWRhdGlv biBpbiBFV0syVW5pdFRlc3RCYXNlLmV3a192aWV3X3BhZ2VfY29udGVudHNfZ2V0CisgICAgICAg IHNvIHRoYXQgdGhlIHRlc3QgcGFzc2VzIGNvbnNpc3RlbnRseS4gVGhlIGlzc3VlIHdhcyB0aGF0 IHRoZSBoZWFkZXIgYmVmb3JlIHRoZQorICAgICAgICBkYXRhIGluY2x1ZGVzIHRoZSBjdXJyZW50 IGRhdGUuIERlcGVuZGluZyBvbiB0aGUgZGF0ZSwgdGhlIGRhdGEgbWF5IHN0YXJ0IGF0IGEKKyAg ICAgICAgZGlmZmVyZW50IGluZGV4IGluIHRoZSByZXR1cm5lZCBzdHJpbmcuIEluc3RlYWQgb2Yg aGFyZGNvZGluZyB0aGUgZGF0YSBzdGFydAorICAgICAgICBpbmRleCBpbiB0aGUgdGVzdCwgd2Ug bm93IHVzZSBTdHJpbmc6OmNvbnRhaW5zKCkuCisKKyAgICAgICAgKiBVSVByb2Nlc3MvQVBJL2Vm bC90ZXN0cy90ZXN0X2V3azJfdmlldy5jcHA6CisgICAgICAgIChQYWdlQ29udGVudHNDYWxsYmFj ayk6CisgICAgICAgIChURVNUX0YpOgorCiAyMDEzLTAyLTAxICBKYWUgSHl1biBQYXJrICA8amFl LnBhcmtAY29tcGFueTEwMC5uZXQ+CiAKICAgICAgICAgQ29vcmRpbmF0ZWQgR3JhcGhpY3MgOiBT b3J0IFRhcmdldC5wcmkgYW5kIGNsYXNzIGRlY2xhcmF0aW9ucyBpbiBhbHBoYWJldGljYWwgb3Jk ZXIuCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0Mi9VSVByb2Nlc3MvQVBJL2VmbC90ZXN0cy90 ZXN0X2V3azJfdmlldy5jcHAgYi9Tb3VyY2UvV2ViS2l0Mi9VSVByb2Nlc3MvQVBJL2VmbC90ZXN0 cy90ZXN0X2V3azJfdmlldy5jcHAKaW5kZXggYWM4OTgyMS4uOGUwOGY5ZSAxMDA2NDQKLS0tIGEv U291cmNlL1dlYktpdDIvVUlQcm9jZXNzL0FQSS9lZmwvdGVzdHMvdGVzdF9ld2syX3ZpZXcuY3Bw CisrKyBiL1NvdXJjZS9XZWJLaXQyL1VJUHJvY2Vzcy9BUEkvZWZsL3Rlc3RzL3Rlc3RfZXdrMl92 aWV3LmNwcApAQCAtOTE3LDcgKzkxNyw3IEBAIFRFU1RfRihFV0syVW5pdFRlc3RCYXNlLCBld2tf dmlld19jb250ZW50c19zaXplX2NoYW5nZWQpCiAgICAgZXZhc19vYmplY3Rfc21hcnRfY2FsbGJh Y2tfZGVsKHdlYlZpZXcoKSwgImNvbnRlbnRzLHNpemUsY2hhbmdlZCIsIG9uQ29udGVudHNTaXpl Q2hhbmdlZCk7CiB9CiAKLXN0YXRpYyBib29sIGlzT2J0YWluZWRQYWdlQ29udGVudHMgPSBmYWxz ZTsKK3N0YXRpYyBib29sIG9idGFpbmVkUGFnZUNvbnRlbnRzID0gZmFsc2U7CiAKIHN0YXRpYyB2 b2lkIFBhZ2VDb250ZW50c0NhbGxiYWNrKEV3a19QYWdlX0NvbnRlbnRzX1R5cGUgdHlwZSwgY29u c3QgY2hhciogZGF0YSkKIHsKQEAgLTkyNSwxNCArOTI1LDE1IEBAIHN0YXRpYyB2b2lkIFBhZ2VD b250ZW50c0NhbGxiYWNrKEV3a19QYWdlX0NvbnRlbnRzX1R5cGUgdHlwZSwgY29uc3QgY2hhciog ZGF0YSkKICAgICBBU1NFUlRfRVEoRVdLX1BBR0VfQ09OVEVOVFNfVFlQRV9NSFRNTCwgdHlwZSk7 CiAKICAgICAvLyBUaGUgdmFyaWFibGUgZGF0YSBzaG91bGQgaGF2ZSBiZWxvdyB0ZXh0IGJsb2Nr LgotICAgIGNvbnN0IGNoYXIgbGluZXNbXSA9ICI8PTAwaD0wMHQ9MDBtPTAwbD0wMD49MDA8PTAw aD0wMGU9MDBhPTAwZD0wMD49MDA8PTAwbT0wMGU9MDB0PTAwYT0wMCA9MDBjPVxyXG4iCisgICAg Y29uc3QgU3RyaW5nIGV4cGVjdGVkTUhUTUwgPSAiXHJcblxyXG48PTAwaD0wMHQ9MDBtPTAwbD0w MD49MDA8PTAwaD0wMGU9MDBhPTAwZD0wMD49MDA8PTAwbT0wMGU9MDB0PTAwYT0wMCA9MDBjPVxy XG4iCiAgICAgICAgICI9MDBoPTAwYT0wMHI9MDBzPTAwZT0wMHQ9MDA9M0Q9MDBcIj0wMFU9MDBU PTAwRj0wMC09MDAxPTAwNj0wMEw9MDBFPTAwXCI9MDA+PVxyXG4iCiAgICAgICAgICI9MDA8PTAw Lz0wMGg9MDBlPTAwYT0wMGQ9MDA+PTAwPD0wMGI9MDBvPTAwZD0wMHk9MDA+PTAwPD0wMHA9MDA+ PTAwUz0wMGk9MDA9XHJcbiIKICAgICAgICAgIm09MDBwPTAwbD0wMGU9MDAgPTAwSD0wMFQ9MDBN PTAwTD0wMDw9MDAvPTAwcD0wMD49MDA8PTAwLz0wMGI9MDBvPTAwZD0wMHk9XHJcbiIKLSAgICAg ICAgIj0wMD49MDA8PTAwLz0wMGg9MDB0PTAwbT0wMGw9MDA+PTAwIjsKLSAgICBBU1NFUlRfRVEo MCwgc3RybmNtcChkYXRhICsgMzU5LCBsaW5lcywgc3RybGVuKGxpbmVzKSkpOworICAgICAgICAi PTAwPj0wMDw9MDAvPTAwaD0wMHQ9MDBtPTAwbD0wMD49MDBcclxuIjsKIAotICAgIGlzT2J0YWlu ZWRQYWdlQ29udGVudHMgPSB0cnVlOworICAgIEFTU0VSVF9UUlVFKFN0cmluZyhkYXRhKS5jb250 YWlucyhleHBlY3RlZE1IVE1MKSk7CisKKyAgICBvYnRhaW5lZFBhZ2VDb250ZW50cyA9IHRydWU7 CiB9CiAKIFRFU1RfRihFV0syVW5pdFRlc3RCYXNlLCBld2tfdmlld19wYWdlX2NvbnRlbnRzX2dl dCkKQEAgLTk0Miw3ICs5NDMsNyBAQCBURVNUX0YoRVdLMlVuaXRUZXN0QmFzZSwgZXdrX3ZpZXdf cGFnZV9jb250ZW50c19nZXQpCiAgICAgd2FpdFVudGlsTG9hZEZpbmlzaGVkKCk7CiAKICAgICBB U1NFUlRfVFJVRShld2tfdmlld19wYWdlX2NvbnRlbnRzX2dldCh3ZWJWaWV3KCksIEVXS19QQUdF X0NPTlRFTlRTX1RZUEVfTUhUTUwsIFBhZ2VDb250ZW50c0NhbGxiYWNrKSk7Ci0gICAgd2hpbGUg KCFpc09idGFpbmVkUGFnZUNvbnRlbnRzKQorICAgIHdoaWxlICghb2J0YWluZWRQYWdlQ29udGVu dHMpCiAgICAgICAgIGVjb3JlX21haW5fbG9vcF9pdGVyYXRlKCk7CiB9CiAK