108571 2013-01-31 20:51:33 -0800 [css3-text] Add gap to TextDecorationStyleWavy's vertical position 2013-03-28 13:33:27 -0700 1 1 1 Unclassified WebKit CSS 528+ (Nightly build) All Unspecified RESOLVED WONTFIX P2 Normal --- 92868 0 lamarque webkit-unassigned bruno.abinader eric ojan.autocc webkit.review.bot oldest_to_newest 822274 0 lamarque 2013-01-31 20:51:33 -0800 Current wavy text decoration implementations [1] draw the wavy stroke too close to the text, adding a gap with the size of the stroke thickness can fix this problem. I will push a patch to fix just that. [1] https://bugs.webkit.org/show_bug.cgi?id=92868 822281 1 185929 lamarque 2013-01-31 20:58:04 -0800 Created attachment 185929 Patch Proposed patch 822342 2 185949 lamarque 2013-01-31 22:43:45 -0800 Created attachment 185949 Screenshot of the change 823236 3 185929 benjamin 2013-02-01 13:57:13 -0800 Comment on attachment 185929 Patch Why no tests? 865758 4 lamarque 2013-03-28 13:32:10 -0700 This patch was merged into the patch in https://bugs.webkit.org/show_bug.cgi?id=92868 865759 5 185929 benjamin 2013-03-28 13:33:27 -0700 Comment on attachment 185929 Patch Clearing the flags to remove the patch from the review queue. 185929 2013-01-31 20:58:04 -0800 2013-03-28 13:33:27 -0700 Patch bug-108571-20130201025446.patch text/plain 3162 lamarque U3VidmVyc2lvbiBSZXZpc2lvbjogMTQxNDcyCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggMGY3OTc4YmY0NTIzYWNl MDk0MmU3MDYyMDk4ZTlkOWY4NTgxNjY0Ni4uMzhhMjUwZjQ0OGQ5OWQzNGZiYzBiNmNjYTk0Yjhm OTY0OTQwZmRhOSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE0IEBACisyMDEzLTAxLTMxICBMYW1h cnF1ZSBWLiBTb3V6YSAgPExhbWFycXVlLlNvdXphQGJhc3lza29tLmNvbT4KKworICAgICAgICBb Y3NzMy10ZXh0XSBBZGQgZ2FwIHRvIFRleHREZWNvcmF0aW9uU3R5bGVXYXZ5J3MgdmVydGljYWwg cG9zaXRpb24gdG8KKyAgICAgICAgcHJldmVudCB0aGUgZGVjb3JhdGlvbiBmcm9tIGNyb3NzaW5n IHRoZSB0ZXh0LgorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/ aWQ9MTA4NTcxCisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAg ICAgKiByZW5kZXJpbmcvSW5saW5lVGV4dEJveC5jcHA6CisgICAgICAgIChXZWJDb3JlOjpJbmxp bmVUZXh0Qm94OjpwYWludERlY29yYXRpb24pOgorCiAyMDEzLTAxLTMxICBEYXZpZCBLaWx6ZXIg IDxkZGtpbHplckBhcHBsZS5jb20+CiAKICAgICAgICAgVXNlIE9TKCkgYW5kIFBMQVRGT1JNKCkg bWFjcm9zIGluIFdlYkNvcmVQcmVmaXguaCBmb3IgcmVhZGFiaWxpdHkKZGlmZiAtLWdpdCBhL1Nv dXJjZS9XZWJDb3JlL3JlbmRlcmluZy9JbmxpbmVUZXh0Qm94LmNwcCBiL1NvdXJjZS9XZWJDb3Jl L3JlbmRlcmluZy9JbmxpbmVUZXh0Qm94LmNwcAppbmRleCAyZmNhOTc5ZTk3MTQxNzg1NzQ3MDA1 MmM3MWY5YmY0OTYzZmU1ZDRiLi44NTk1Nzk2OTlhNjQ0NjEzOWUxY2Q0NzkyNTQzZTliNmU3ZTQw MzMwIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9yZW5kZXJpbmcvSW5saW5lVGV4dEJveC5j cHAKKysrIGIvU291cmNlL1dlYkNvcmUvcmVuZGVyaW5nL0lubGluZVRleHRCb3guY3BwCkBAIC0x MDI3LDI2ICsxMDI3LDI5IEBAIHZvaWQgSW5saW5lVGV4dEJveDo6cGFpbnREZWNvcmF0aW9uKEdy YXBoaWNzQ29udGV4dCogY29udGV4dCwgY29uc3QgRmxvYXRQb2ludCYKICAgICAgICAgICAgIHNo YWRvdyA9IHNoYWRvdy0+bmV4dCgpOwogICAgICAgICB9CiAKKyAgICAgICAgZmxvYXQgd2F2eU9m ZnNldCA9IDA7CiAjaWYgRU5BQkxFKENTUzNfVEVYVCkKICAgICAgICAgLy8gT2Zmc2V0IGJldHdl ZW4gbGluZXMgLSBhbHdheXMgbm9uLXplcm8sIHNvIGxpbmVzIG5ldmVyIGNyb3NzIGVhY2ggb3Ro ZXIuCiAgICAgICAgIGZsb2F0IGRvdWJsZU9mZnNldCA9IHRleHREZWNvcmF0aW9uVGhpY2tuZXNz ICsgMS5mOworICAgICAgICBpZiAoZGVjb3JhdGlvblN0eWxlID09IFRleHREZWNvcmF0aW9uU3R5 bGVXYXZ5KQorICAgICAgICAgICAgd2F2eU9mZnNldCA9IGRvdWJsZU9mZnNldDsKICNlbmRpZiAv LyBDU1MzX1RFWFQKICAgICAgICAgY29udGV4dC0+c2V0U3Ryb2tlU3R5bGUodGV4dERlY29yYXRp b25TdHlsZVRvU3Ryb2tlU3R5bGUoZGVjb3JhdGlvblN0eWxlKSk7CiAgICAgICAgIGlmIChkZWNv ICYgVU5ERVJMSU5FKSB7CiAgICAgICAgICAgICBjb250ZXh0LT5zZXRTdHJva2VDb2xvcih1bmRl cmxpbmUsIGNvbG9yU3BhY2UpOwogICAgICAgICAgICAgLy8gTGVhdmUgb25lIHBpeGVsIG9mIHdo aXRlIGJldHdlZW4gdGhlIGJhc2VsaW5lIGFuZCB0aGUgdW5kZXJsaW5lLgotICAgICAgICAgICAg Y29udGV4dC0+ZHJhd0xpbmVGb3JUZXh0KEZsb2F0UG9pbnQobG9jYWxPcmlnaW4ueCgpLCBsb2Nh bE9yaWdpbi55KCkgKyBiYXNlbGluZSArIDEpLCB3aWR0aCwgaXNQcmludGluZyk7CisgICAgICAg ICAgICBjb250ZXh0LT5kcmF3TGluZUZvclRleHQoRmxvYXRQb2ludChsb2NhbE9yaWdpbi54KCks IGxvY2FsT3JpZ2luLnkoKSArIGJhc2VsaW5lICsgd2F2eU9mZnNldCArIDEpLCB3aWR0aCwgaXNQ cmludGluZyk7CiAjaWYgRU5BQkxFKENTUzNfVEVYVCkKICAgICAgICAgICAgIGlmIChkZWNvcmF0 aW9uU3R5bGUgPT0gVGV4dERlY29yYXRpb25TdHlsZURvdWJsZSkKLSAgICAgICAgICAgICAgICBj b250ZXh0LT5kcmF3TGluZUZvclRleHQoRmxvYXRQb2ludChsb2NhbE9yaWdpbi54KCksIGxvY2Fs T3JpZ2luLnkoKSArIGJhc2VsaW5lICsgMSArIGRvdWJsZU9mZnNldCksIHdpZHRoLCBpc1ByaW50 aW5nKTsKKyAgICAgICAgICAgICAgICBjb250ZXh0LT5kcmF3TGluZUZvclRleHQoRmxvYXRQb2lu dChsb2NhbE9yaWdpbi54KCksIGxvY2FsT3JpZ2luLnkoKSArIGJhc2VsaW5lICsgd2F2eU9mZnNl dCArIDEgKyBkb3VibGVPZmZzZXQpLCB3aWR0aCwgaXNQcmludGluZyk7CiAjZW5kaWYgLy8gQ1NT M19URVhUCiAgICAgICAgIH0KICAgICAgICAgaWYgKGRlY28gJiBPVkVSTElORSkgewogICAgICAg ICAgICAgY29udGV4dC0+c2V0U3Ryb2tlQ29sb3Iob3ZlcmxpbmUsIGNvbG9yU3BhY2UpOwotICAg ICAgICAgICAgY29udGV4dC0+ZHJhd0xpbmVGb3JUZXh0KGxvY2FsT3JpZ2luLCB3aWR0aCwgaXNQ cmludGluZyk7CisgICAgICAgICAgICBjb250ZXh0LT5kcmF3TGluZUZvclRleHQoRmxvYXRQb2lu dChsb2NhbE9yaWdpbi54KCksIGxvY2FsT3JpZ2luLnkoKSAtIHdhdnlPZmZzZXQpLCB3aWR0aCwg aXNQcmludGluZyk7CiAjaWYgRU5BQkxFKENTUzNfVEVYVCkKICAgICAgICAgICAgIGlmIChkZWNv cmF0aW9uU3R5bGUgPT0gVGV4dERlY29yYXRpb25TdHlsZURvdWJsZSkKLSAgICAgICAgICAgICAg ICBjb250ZXh0LT5kcmF3TGluZUZvclRleHQoRmxvYXRQb2ludChsb2NhbE9yaWdpbi54KCksIGxv Y2FsT3JpZ2luLnkoKSAtIGRvdWJsZU9mZnNldCksIHdpZHRoLCBpc1ByaW50aW5nKTsKKyAgICAg ICAgICAgICAgICBjb250ZXh0LT5kcmF3TGluZUZvclRleHQoRmxvYXRQb2ludChsb2NhbE9yaWdp bi54KCksIGxvY2FsT3JpZ2luLnkoKSAtIHdhdnlPZmZzZXQgLSBkb3VibGVPZmZzZXQpLCB3aWR0 aCwgaXNQcmludGluZyk7CiAjZW5kaWYgLy8gQ1NTM19URVhUCiAgICAgICAgIH0KICAgICAgICAg aWYgKGRlY28gJiBMSU5FX1RIUk9VR0gpIHsK 185949 2013-01-31 22:43:45 -0800 2013-01-31 22:43:45 -0800 Screenshot of the change before_and_after.png image/png 4430 lamarque iVBORw0KGgoAAAANSUhEUgAAAuQAAACmCAIAAAAdyQ18AAAAAXNSR0IDN8dNUwAAAAlwSFlzAAAL EgAACxIB0t1+/AAAEPNJREFUeNrt3X9ME/cfx3FKq2Qq/kBwqLHUiIKbiRNdpgYEnHNT0OBAXZwk c/gj++Xij/hrJuIWXfbDJSwu22Lc3CbT4FycG4YfbpRNhQwU0WwIsokmE5yIVVDHz37f9vietS0I RX6V5+OPy929r3f64Xr3anv3OY3ZbHYDAADoqtxpAgAAQFgBAAAgrAAAAMIKAAAAYQXoUFu3bm2m pNFomlqAKtX2qxqNRt6bgErj3N1AzRzfYWPLli3tcR7tstvtju0s54b4+HibmcrZIiwsTB2hKjPl iCHNZdPassPI/HiLZqrh4eHdbrudUpVhW+7T5PjM8dmV2rmRufXkzW9Gi8kfybkXtrGdO2u73bSd bd4LMtN6hTJu3Sw9ubrFwonXKjO73XY7vqoMe9r7l+Mzx+fm8TMQ0Jja5aO5zSdytaocIJQPNFSp tmtVySu8JQFrhBXgvrwibM4o1ucVqlQ7sgqAn4H4mpGvGdmf2Z9pZ/Zn9md+BgIAAOBnIAAAQFgB AAAgrAAAABBWAMCFNdP1LT0F21czMzOde218fHx33G5nVUtKSggrAIBGYWFhao9BNucM9cYK+/MK 1dZWrfvI6QnbbUtVRgwGA2EFAHCPdQ+HNuc5t/t7oqOqPMmh52y346v2z8EgrAAAbPMKPQVTdYEe mQkrAOCyeYW+gKm6SI/M9JBID4n0+Mleyv5MO7M/sz/Tgy0AAICTtE58UbN169aXXnqpqVJ4eLhG owkLC6OqVh021wNfK3+atmz34sWLN27cyLQj1SVLlsiILOCwumfPnu7YzgaDISoqyon3gPyvHa4W DhmNRueaq43tLH9lh3vsA8k/uKnjFe0M9ucu3s4qnROvUW6NU+5Hsml99XsqGbe5ALjHVqW5nHut erGS0/8qmbSvhoaGZmRkPLDavdrZ7WHcGoeuTHZL5174UO5EANifO5eTPwNxaxy3qLnerXEAAJcK K27cGkfV5W6NAwC4Wlhx49Y4qi52axwAoEtycOlJS3CS6Ji2op1pZ9qZdqadaeee3M5tCisAAAAd g35WAAAAYQUAAMBZOpoAgCgqKqqpqWn8EOPurtfr+/Xr16o15OTkbNy4sbi42NfXNzs7myYF8LBw zQqAuwIDAwsLC+99jtHp4uLiEhISPDw8WvLy27dvGwwGk8kk65GwkpaWRpMCeFj4ZgVAIy8vr/Dw cBmprq4+fvz4559/3rdv3x07drTktceOHbt69eoPP/wwd+5cWhLAw8U3KwDuCgwM9Pb2lsyhTF67 dm3ChAkmk+n69etarfaBL9+1a9fy5cvLysoeffRRGhPAw8UFtgAcGDx48Lx58yorKyV/WM+vqKg4 dOjQwYMHy8vL1ZmVFjJSVVUl+ea///5T5stnoVOnTn377be//fZbQ0OD9Xpu3Lhx584dGcnLy9u3 b9+///6rviQ3N1deIrGJj1IAFPwMBMCxRx55RIbWX6tIqli2bNmtW7dkvG/fvjI5Z84cGQ8JCcnP z5cRf39/N8uz1uLj42tqahYvXnzgwAHltVOnTv3pp58GDRqkTPr5+cXFxVVXV3/yyScy+eOPP0ZG Rt68eXP+/Pnq9S7h4eEyXzbE3wIgrACALbPZbDQavb29hwwZosw5efJkbGyshIxXX31VEsxHH320 aNGioqKioUOHLl26NDk5OSUlZdWqVX369Jk2bZos//bbb0tSmTFjxoIFCzIyMiTZrFixIikpSd1E amrqhQsXVq5c2b9/f9mQzJEFJKnIVmQN2dnZu3fvXr9+/c6dO/lzABySAMAcEBDg7+//pcWnn346 e/ZsOT7s2LFDXSAiIkIiRVlZmTJZWFio0+mURzUJeYksf/XqVWXy9u3bnp6eQUFBtbW1MtnQ0BAd He1muUFaWWDAgAFKXlHXf/bsWZmzbt06dY5kFw8PD5PJxF8H6OG4ZgVAo+Li4iUWr7zyypEjR55/ /vmVK1cqpaqqKgkWS5cuVa+fHTNmzMyZM48ePepwVSdOnKisrHzzzTcl0MikRqNZtWqVjKSkpKjL jBs3TtagTn7//fdarXb9+vXqnNdee626ulq95hdAj8XPQAAajRw5cvXq1TJSX1+fk5OTmJj44osv 7t+/X6LGH3/8UVdXN3nyZOvlH3vssb179zpclSzvZrlORZ3z5JNPShb5888/1TmTJk2yfkleXp4E IC8vL3XO2LFjlQjFnwYgrADAXcOGDXv99dfVST8/v+3bt7/xxhvBwcHKPUExMTESXJSbdGQomaap Xm6Ve4V8fX3VOb179x4yZMjVq1fVOda5RJSWlhYUFHh4eKhf/Crzq6qq+NMAhBUAcGDhwoUSVlJS UiSs1NbWypzIyEibblSa6t9WuVHZ3f2+H5q1Wq31DcySe6yrdXV1Q4cOte9TbsKECfwtAMIKADgw ePBgGV6+fFmGAwcOlOGyZcuUC28fqH///jK8fv16nz59lDlms/natWvKdbUOySZqamo+++wzWh6A DS6wBeBYaWmpDJW0oVw+0vLHE44ePVqGp0+fVucUFRXduXNHme+QbKKgoODmzZu0PADCCoAHM5vN u3btkpGJEyfKcPjw4ePHj//yyy9triBROoizFxwcrNVqv/rqK3XO119/7Wbp562pLUZERNTV1dl8 syJz1P5wAfRY/AwEoFFJScmGDRuUiJCTk/Prr7/6+vrGxMQo1U2bNi1cuHD27Nnbtm0bOXKkLJyY mChLKpnGho+Pz/z58/fv3//uu+8uWrQoIyPjgw8+CAoKsrmfyNrMmTMlGL311lsyHh0dLWnpxIkT H374YVJSUmBgIH8doKd/fgKAgIAAm4ODv7//yZMn1QUaGhrWrl1rs8zGjRsddgonSktLR40apS7p 5eV15swZtTpgwIA1a9bY/BuKi4sNBoP1+j09PS9dusRfB+jheOoygLuOHj2q/sSj0WiGDx8+YcIE ++ctHz9+/NChQxUVFSNGjIiMjFT7Srlw4UJ+fv6sWbOs7w8ymUy7d+8uKCjQ6/VxcXGyTrWUnJzs 5+c3btw4m/VXVlbu3bs3Ly+vd+/e8g+Ijo5Wru0F0JMRVgAAQJfGBbYAAICwAgAAQFgBAACEFQAA AMIKAAAAYQUAABBWAAAACCsAAICwAgAAQFgBAAAgrAAAAMIKAAAAYQUAABBWAAAACCsAAACEFQAA QFgBAAAgrAAAAMIKAAAAYQUAAICwAgAACCsAAACEFQAAQFihCQAAAGEFAACAsAIAAAgrgKvaunVr MyWNRtPUAlSptl/VaDTy3gQIK0CjLVu2yLnB4TnD/H/25xWqVNuvKiNhYWG8NwHCCnCPnB5s8opy zoiPj5dxGdqcV6hSbb+q7IoSoHlXAgqNkt+d08w357D/4N4p7dxZ2+2+7RxvISPKN/A2H23VmT28 qrSzNJRyTrU++6qaqirt3L2227ntzPGZ4zPHZzezs5QPBGgh+SN1Sjt31na7dTur76umNkFVnWzt a63buRttt9PbmeMzx+eefHy+e1gmrPBm4M3A/sz+TDuzP7M/d+WwwjUrAACgSyOsAAAAwgoAAABh BQAAEFYAAAAIKwAAAIQVAHBhzTxUiGcw2VczMzOde218fHx33G5nVUtKSggrAIBGYWFhPOuqA6r2 T0tw7e22pSojBoOBsAIAuMfMs65aXJVs16O22x2fdUVYAQDXzyv2z1GyPq9QpdquVUkqNs/wIqwA AO7LK8Js98RH9bxClWpHVp3flXn2BM+e4NkT7M/sz7Qz+zP7M88GAgAAcIaOJnBtmZmZTd1L1jyj 0djG66EA9meA/ZmwggfLyMhw7oUc2cH+DLA/dxHO/wxEp0Otqva0zn+6Y6dDAABXCyt0OtQx1e7Y +U837XQIAOBqYcWNTofo/Me1Oh0CAHRNGuXzqHOUk4ecKpSTRGZmpqxNzsrWyxiNRjmLhIaG9vCq eqJVzqn2Hek0U1VGaMmWt3Nb9me0d1vRzrQz7Uw7O/PtSNspq2rqFmolylCl2pFVAIDLaNM3KwAA AO2NTuEAAABhBQAAgLACAAAIKwAAAIQVAAAAwgoAACCsAHARf1s4LH333XfBwcGBgYGrV6+moQAQ VgB0gn/++WeUxZUrV2xKZ86cWbBgQV5eXm1tbX19fXl5+YYNG86ePUujASCsAOg4aWlpykh6erpN 6eDBgzqd7vz583/99VdCQoLJZHrvvfcKCwtpNACEFQAdGlb0ev2IESPU1KK6ePGilIYNG0YrAWhX OpoAQFPq6+vT09OjoqIaGhqOHDkiQ3f3u59wzGazlGpqarRabV1d3d3PPe7uyojMV+coC4vr169n ZWXJSEhIiKenp/X6ZSgruXz58u+//z5u3Dh/f3+aHYANvlkB0KS8vLxr1649Y3HlyhX1epRbt271 6tVr3759RUVFvSy2b98+duxYKb3wwgvKnKSkJGVhWUyv10dYGAwGo9Gorv/ZZ599+umnExMTZf68 efP27NlDmwOwxzcrAJqUmpoqw+nTpzc0NCiT48ePlxHJImvWrElOTpYE8/LLL8ucyZMny8gXX3wR GRkZEBAgc5Rhbm5ubGzsiBEjNm3aZDabExISoqOjz58/7+XlpWyitLR0+fLlc+fOleXHjBlDmwOw x1OXATRp2rRpVVVVp06dknGJKd7e3j///LNaXbx4sWSRc+fOKZPFxcWjR48+cOBATEyMusxzzz2X n59/5swZHx8fmTx9+nRQUND777+/du1amZwxY4ascPPmze+88w6tDaAp/AwEwLGbN29mZWVJnlAm ZeTYsWO3bt1q+RpMJlN6evqKFSuUpCKeeOKJkJAQ6xuLdDqdElwAgLACoHUyMjLq6uqeeeYZNazU 1NRkZma2fA35+fkNDQ1Tpkyxnvn444+fP39enQwICBgwYACtDaAZXLMCwLHU1FQPD4/g4GBlMiQk pFevXjJz9uzZLVxDWVmZDKOjo93d3ZVfnGVYXV09cOBAdRn14hUAIKwAaJ20tDStVjtnzpx7xwud zr63lWbU1tbKMDQ0dNCgQdbz+/Xrp46rtzcDAGEFQCv8ZSEj1lfUinPnzl26dEmv17dkJcrvO+vW rZO8QpMCcBqfaQA4oHyDcvjw4QtWZNLNqgN+h6xvMAwMDJRhTk4O7QmAsALgIUtNTfX09Jw1a5bB ikzKTKXzFXtK17Tl5eXqHH+LXbt2VVdXWy95584dWhhAy/EzEABbtbW1v/zyy7Rp03S6+w4RMhka Gnr06NG6ujqbkhgyZIi3t3dCQoJWq+3Tp09wcLDkm40bN8bFxUVFRW3btk2v1//999/ffPONRqP5 +OOPaWcALcQ3KwBsZWdnV1ZWhoeH25emT59uMplyc3PtSxJBNm/eXFhYuGLFitjYWFmJzFyyZMmy ZctSUlImTpzo4+Pz1FNP7dy5k3uVAbQKPdgCsFVUVHTq1KnQ0NChQ4falMrKyoxG46RJk/z9/bOy sioqKiIiIqwXKC4uzs/Pr62tnTJlip+fn5vlKpa0tLTDhw/fuHFDeUjQ1KlTJdm4WbpykaoEINoc AGEFAAB0V/wMBAAACCsAAACEFQAAQFgBAAAgrAAAABBWAAAAYQUAAICwAgAACCsAAACEFQAAAMIK AAAgrAAAABBWAAAAYQUAAICwAgAAQFgBAACEFQAAAMIKAAAgrAAAABBWAAAACCsAAICwAgAAQFgB AACEFZoAAAAQVgAAAAgrAACAsAIAAEBYAQAAIKwAAADCCgAAAGEFAAAQVgAAAAgrAAAAhBUAAEBY AQAAIKwAAADCCgAAAGEFAADgQf4HAxcGby3Xy38AAAAASUVORK5CYII=