108380 2013-01-30 14:10:54 -0800 REGRESSION(r141136): Apple's internal PLT test suite doesn't finish 2013-02-06 13:13:16 -0800 1 1 1 Unclassified WebKit New Bugs 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 105667 108402 108435 1 rniwa rniwa abarth ap beidson japhet jberlin slewis webkit-bug-importer webkit.review.bot oldest_to_newest 820529 0 rniwa 2013-01-30 14:10:54 -0800 Apple's internal PLT test suite doesn't finish after r141136 820533 1 185564 rniwa 2013-01-30 14:12:09 -0800 Created attachment 185564 Temporarily disable the feature 820538 2 185564 ap 2013-01-30 14:13:35 -0800 Comment on attachment 185564 Temporarily disable the feature View in context: https://bugs.webkit.org/attachment.cgi?id=185564&action=review r=me We should make a reproducible case that's not internal. > Source/WebCore/loader/cache/CachedResourceLoader.cpp:482 > +#if PLATFORM(CHROMIUM) || PLATFORM(MAC) > // FIXME: Temporarily leave main resource caching disabled for chromium, see https://bugs.webkit.org/show_bug.cgi?id=107962 > // Ensure main resources aren't preloaded, and other main resource loads are removed from cache to prevent reuse. Please add a comment about Mac here. 820552 3 rniwa 2013-01-30 14:18:54 -0800 Committed r141306: <http://trac.webkit.org/changeset/141306> 820588 4 185564 ap 2013-01-30 14:35:37 -0800 Comment on attachment 185564 Temporarily disable the feature Clearing cq+ from a landed patch. 820688 5 webkit-bug-importer 2013-01-30 15:28:59 -0800 <rdar://problem/13119725> 821013 6 rniwa 2013-01-30 20:12:59 -0800 The patch landed here fixed the bug so we need to investigate further and come up with a reduction. 821083 7 rniwa 2013-01-30 22:02:08 -0800 It appears that WebFrameLoaderClient::dispatchDidFinishLoading or WebFrameLoaderClient::dispatchDidFailLoading is called with identifier of 0. 821565 8 jberlin 2013-01-31 08:54:30 -0800 5 tests started failing on Mountain Lion WK1 Release tests in between 141305 and 141310: http://build.webkit.org/builders/Apple%20MountainLion%20Release%20WK1%20%28Tests%29/builds/6313 http://build.webkit.org/results/Apple%20MountainLion%20Release%20WK1%20(Tests)/r141310%20(6314)/results.html http/tests/cache/cached-main-resource.html http/tests/inspector/resource-har-pages.html http/tests/loading/redirect-methods.html http/tests/misc/link-rel-icon-beforeload.html http/tests/misc/favicon-loads-with-images-disabled.html Especially for the first one, this change seems very suspect 821810 9 japhet 2013-01-31 12:09:22 -0800 (In reply to comment #8) > 5 tests started failing on Mountain Lion WK1 Release tests in between 141305 and 141310: > http://build.webkit.org/builders/Apple%20MountainLion%20Release%20WK1%20%28Tests%29/builds/6313 > http://build.webkit.org/results/Apple%20MountainLion%20Release%20WK1%20(Tests)/r141310%20(6314)/results.html > > http/tests/cache/cached-main-resource.html > http/tests/inspector/resource-har-pages.html > http/tests/loading/redirect-methods.html > http/tests/misc/link-rel-icon-beforeload.html > http/tests/misc/favicon-loads-with-images-disabled.html > > Especially for the first one, this change seems very suspect All of those (except resource-har-pages.html) are expected to change, given that their results depend on the feature disabled in r141306. It's probably best to just expect them to fail until main resource caching is re-enabled. 821869 10 jberlin 2013-01-31 12:57:58 -0800 (In reply to comment #9) > (In reply to comment #8) > > 5 tests started failing on Mountain Lion WK1 Release tests in between 141305 and 141310: > > http://build.webkit.org/builders/Apple%20MountainLion%20Release%20WK1%20%28Tests%29/builds/6313 > > http://build.webkit.org/results/Apple%20MountainLion%20Release%20WK1%20(Tests)/r141310%20(6314)/results.html > > > > http/tests/cache/cached-main-resource.html > > http/tests/inspector/resource-har-pages.html > > http/tests/loading/redirect-methods.html > > http/tests/misc/link-rel-icon-beforeload.html > > http/tests/misc/favicon-loads-with-images-disabled.html > > > > Especially for the first one, this change seems very suspect > > All of those (except resource-har-pages.html) are expected to change, given that their results depend on the feature disabled in r141306. It's probably best to just expect them to fail until main resource caching is re-enabled. Marked them as expected failures in platform/mac’s TestExpectations: http://trac.webkit.org/changeset/141469 822147 11 jberlin 2013-01-31 17:07:09 -0800 Actually, http/tests/inspector/resource-har-pages.html was changed in the checkin that enabled this feature: http://trac.webkit.org/changeset/141136 I am going to mark it as failing for now as well. 825705 12 japhet 2013-02-05 12:29:02 -0800 Has anyone had a chance to test whether this suite still fails since http://trac.webkit.org/changeset/141615 landed (with main resource caching re-enabled)? 825706 13 rniwa 2013-02-05 12:31:04 -0800 (In reply to comment #12) > Has anyone had a chance to test whether this suite still fails since http://trac.webkit.org/changeset/141615 landed (with main resource caching re-enabled)? Yes, r141615 fixed the PLT when main resource caching is enabled. My plan is to post a new patch that reverts r141306. Sorry I got distracted by other work. 825708 14 japhet 2013-02-05 12:33:07 -0800 (In reply to comment #13) > (In reply to comment #12) > > Has anyone had a chance to test whether this suite still fails since http://trac.webkit.org/changeset/141615 landed (with main resource caching re-enabled)? > > Yes, r141615 fixed the PLT when main resource caching is enabled. My plan is to post a new patch that reverts r141306. Sorry I got distracted by other work. No problem, I just wanted to make sure there weren't other regressions blocking re-enable :) 825809 15 186702 rniwa 2013-02-05 14:15:45 -0800 Created attachment 186702 Re-enable the reuse of main resource cache 825820 16 rniwa 2013-02-05 14:24:35 -0800 I'm going to wait for EWS bots to catch up. 826691 17 186702 webkit.review.bot 2013-02-06 13:13:11 -0800 Comment on attachment 186702 Re-enable the reuse of main resource cache Clearing flags on attachment: 186702 Committed r142024: <http://trac.webkit.org/changeset/142024> 826692 18 webkit.review.bot 2013-02-06 13:13:16 -0800 All reviewed patches have been landed. Closing bug. 185564 2013-01-30 14:12:09 -0800 2013-02-05 14:15:43 -0800 Temporarily disable the feature bug-108380-20130130140854.patch text/plain 1415 rniwa SW5kZXg6IFNvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2Vi Q29yZS9DaGFuZ2VMb2cJKHJldmlzaW9uIDE0MTMwNCkKKysrIFNvdXJjZS9XZWJDb3JlL0NoYW5n ZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDE1IEBACisyMDEzLTAxLTMwICBSeW9zdWtl IE5pd2EgIDxybml3YUB3ZWJraXQub3JnPgorCisgICAgICAgIEFwcGxlJ3MgaW50ZXJuYWwgUExU IHRlc3Qgc3VpdGUgZG9lc24ndCBmaW5pc2ggYWZ0ZXIgcjE0MTEzNgorICAgICAgICBodHRwczov L2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTA4MzgwCisKKyAgICAgICAgUmV2aWV3 ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgVGVtcG9yYXJpbHkgZGlzYWJsZSB0aGUg ZmVhdHVyZSB0byBzZWUgaWYgdGhhdCBmaXhlcyBpdC4KKworICAgICAgICAqIGxvYWRlci9jYWNo ZS9DYWNoZWRSZXNvdXJjZUxvYWRlci5jcHA6CisgICAgICAgIChXZWJDb3JlOjpDYWNoZWRSZXNv dXJjZUxvYWRlcjo6cmVxdWVzdFJlc291cmNlKToKKwogMjAxMy0wMS0zMCAgRmxvcmluIE1hbGl0 YSAgPGZtYWxpdGFAY2hyb21pdW0ub3JnPgogCiAgICAgICAgIFtDaHJvbWl1bV0gVW5yZXZpZXdl ZCBnYXJkZW5pbmcuCkluZGV4OiBTb3VyY2UvV2ViQ29yZS9sb2FkZXIvY2FjaGUvQ2FjaGVkUmVz b3VyY2VMb2FkZXIuY3BwCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFNvdXJjZS9XZWJDb3JlL2xvYWRlci9jYWNo ZS9DYWNoZWRSZXNvdXJjZUxvYWRlci5jcHAJKHJldmlzaW9uIDE0MTMwNCkKKysrIFNvdXJjZS9X ZWJDb3JlL2xvYWRlci9jYWNoZS9DYWNoZWRSZXNvdXJjZUxvYWRlci5jcHAJKHdvcmtpbmcgY29w eSkKQEAgLTQ3Nyw3ICs0NzcsNyBAQCBDYWNoZWRSZXNvdXJjZUhhbmRsZTxDYWNoZWRSZXNvdXJj ZT4gQ2FjCiAgICAgICAgIH0KICAgICB9CiAKLSNpZiBQTEFURk9STShDSFJPTUlVTSkKKyNpZiBQ TEFURk9STShDSFJPTUlVTSkgfHwgUExBVEZPUk0oTUFDKQogICAgIC8vIEZJWE1FOiBUZW1wb3Jh cmlseSBsZWF2ZSBtYWluIHJlc291cmNlIGNhY2hpbmcgZGlzYWJsZWQgZm9yIGNocm9taXVtLCBz ZWUgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTEwNzk2MgogICAgIC8v IEVuc3VyZSBtYWluIHJlc291cmNlcyBhcmVuJ3QgcHJlbG9hZGVkLCBhbmQgb3RoZXIgbWFpbiBy ZXNvdXJjZSBsb2FkcyBhcmUgcmVtb3ZlZCBmcm9tIGNhY2hlIHRvIHByZXZlbnQgcmV1c2UuCiAg ICAgaWYgKHR5cGUgPT0gQ2FjaGVkUmVzb3VyY2U6Ok1haW5SZXNvdXJjZSkgewo= 186702 2013-02-05 14:15:45 -0800 2013-02-06 13:13:11 -0800 Re-enable the reuse of main resource cache bug-108380-20130205141228.patch text/plain 3351 rniwa SW5kZXg6IFNvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2Vi Q29yZS9DaGFuZ2VMb2cJKHJldmlzaW9uIDE0MTkyNikKKysrIFNvdXJjZS9XZWJDb3JlL0NoYW5n ZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDE1IEBACisyMDEzLTAyLTA1ICBSeW9zdWtl IE5pd2EgIDxybml3YUB3ZWJraXQub3JnPgorCisgICAgICAgIFJFR1JFU1NJT04ocjE0MTEzNik6 IEFwcGxlJ3MgaW50ZXJuYWwgUExUIHRlc3Qgc3VpdGUgZG9lc24ndCBmaW5pc2gKKyAgICAgICAg aHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTEwODM4MAorCisgICAgICAg IFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIFJlLWVuYWJsZSB0aGUgbWFp biByZXNvdXJjZSBjYWNoZSBzaW5jZSB0aGUgcmVncmVzc2lvbiBoYWQgYmVlbiBmaXhlZCBpbiBy MTQxNjE1LgorCisgICAgICAgICogbG9hZGVyL2NhY2hlL0NhY2hlZFJlc291cmNlTG9hZGVyLmNw cDoKKyAgICAgICAgKFdlYkNvcmU6OkNhY2hlZFJlc291cmNlTG9hZGVyOjpyZXF1ZXN0UmVzb3Vy Y2UpOgorCiAyMDEzLTAyLTA1ICBOYXlhbiBLdW1hciBLICA8bmF5YW5ra0Btb3Rvcm9sYS5jb20+ CiAKICAgICAgICAgW1dFQkdMXSBSZW5hbWUgV0VCS0lUX1dFQkdMX2RlcHRoX3RleHR1cmUgdG8g V0VCR0xfZGVwdGhfdGV4dHVyZS4KSW5kZXg6IFNvdXJjZS9XZWJDb3JlL2xvYWRlci9jYWNoZS9D YWNoZWRSZXNvdXJjZUxvYWRlci5jcHAKPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gU291cmNlL1dlYkNvcmUvbG9h ZGVyL2NhY2hlL0NhY2hlZFJlc291cmNlTG9hZGVyLmNwcAkocmV2aXNpb24gMTQxOTEyKQorKysg U291cmNlL1dlYkNvcmUvbG9hZGVyL2NhY2hlL0NhY2hlZFJlc291cmNlTG9hZGVyLmNwcAkod29y a2luZyBjb3B5KQpAQCAtNDc5LDEwICs0NzksOSBAQCBDYWNoZWRSZXNvdXJjZUhhbmRsZTxDYWNo ZWRSZXNvdXJjZT4gQ2FjCiAgICAgICAgIH0KICAgICB9CiAKLSNpZiBQTEFURk9STShDSFJPTUlV TSkgfHwgUExBVEZPUk0oTUFDKQorI2lmIFBMQVRGT1JNKENIUk9NSVVNKQogICAgIC8vIEZJWE1F OiBUZW1wb3JhcmlseSBsZWF2ZSBtYWluIHJlc291cmNlIGNhY2hpbmcgZGlzYWJsZWQgZm9yIGNo cm9taXVtLCBzZWUgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTEwNzk2 MgogICAgIC8vIEVuc3VyZSBtYWluIHJlc291cmNlcyBhcmVuJ3QgcHJlbG9hZGVkLCBhbmQgb3Ro ZXIgbWFpbiByZXNvdXJjZSBsb2FkcyBhcmUgcmVtb3ZlZCBmcm9tIGNhY2hlIHRvIHByZXZlbnQg cmV1c2UuCi0gICAgLy8gRklYTUU6IFRlbXBvcmFyaWx5IGxlYXZlIG1haW4gcmVzb3VyY2UgY2Fj aGluZyBkaXNhYmxlZCBvbiBNYWMgcG9ydCBwZXIgd2Via2l0Lm9yZy9iLzEwODM4MCB1bnRpbCB3 ZSB0cmFjayBkb3duIHRoZSByb290IGNhdXNlLgogICAgIGlmICh0eXBlID09IENhY2hlZFJlc291 cmNlOjpNYWluUmVzb3VyY2UpIHsKICAgICAgICAgQVNTRVJUKHBvbGljeSAhPSBVc2UpOwogICAg ICAgICBBU1NFUlQocG9saWN5ICE9IFJldmFsaWRhdGUpOwpJbmRleDogTGF5b3V0VGVzdHMvQ2hh bmdlTG9nCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT0KLS0tIExheW91dFRlc3RzL0NoYW5nZUxvZwkocmV2aXNpb24gMTQx OTI2KQorKysgTGF5b3V0VGVzdHMvQ2hhbmdlTG9nCSh3b3JraW5nIGNvcHkpCkBAIC0xLDMgKzEs MTQgQEAKKzIwMTMtMDItMDUgIFJ5b3N1a2UgTml3YSAgPHJuaXdhQHdlYmtpdC5vcmc+CisKKyAg ICAgICAgUkVHUkVTU0lPTihyMTQxMTM2KTogQXBwbGUncyBpbnRlcm5hbCBQTFQgdGVzdCBzdWl0 ZSBkb2Vzbid0IGZpbmlzaAorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1 Zy5jZ2k/aWQ9MTA4MzgwCisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisK KyAgICAgICAgUmUtZW5hYmxlIHRlc3RzIHRoYXQgaGF2ZSBiZWVuIHRlbXBvcmFyaWx5IGRpc2Fi bGVkLgorCisgICAgICAgICogcGxhdGZvcm0vbWFjL1Rlc3RFeHBlY3RhdGlvbnM6CisKIDIwMTMt MDItMDUgIE5heWFuIEt1bWFyIEsgIDxuYXlhbmtrQG1vdG9yb2xhLmNvbT4KIAogICAgICAgICBb V0VCR0xdIFJlbmFtZSBXRUJLSVRfV0VCR0xfZGVwdGhfdGV4dHVyZSB0byBXRUJHTF9kZXB0aF90 ZXh0dXJlLgpJbmRleDogTGF5b3V0VGVzdHMvcGxhdGZvcm0vbWFjL1Rlc3RFeHBlY3RhdGlvbnMK PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PQotLS0gTGF5b3V0VGVzdHMvcGxhdGZvcm0vbWFjL1Rlc3RFeHBlY3RhdGlvbnMJ KHJldmlzaW9uIDE0MTkxMikKKysrIExheW91dFRlc3RzL3BsYXRmb3JtL21hYy9UZXN0RXhwZWN0 YXRpb25zCSh3b3JraW5nIGNvcHkpCkBAIC0xMzMyLDEwICsxMzMyLDMgQEAgd2Via2l0Lm9yZy9i LzEwODM3MCBlZGl0aW5nL3NwZWxsaW5nL3NwZQogCiB3ZWJraXQub3JnL2IvMTA4MjU3IFsgRGVi dWcgXSBjb21wb3NpdGluZy9vdmVyZmxvdy9jb21wb3NpdGVkLXNjcm9sbGluZy1jcmVhdGVzLWEt c3RhY2tpbmctY29udGFpbmVyLmh0bWwgWyBDcmFzaCBdCiB3ZWJraXQub3JnL2IvMTA4MjU3IFsg RGVidWcgXSBjb21wb3NpdGluZy9vdmVyZmxvdy9hdXRvbWF0aWNhbGx5LW9wdC1pbnRvLWNvbXBv c2l0ZWQtc2Nyb2xsaW5nLmh0bWwgWyBDcmFzaCBdCi0KLXdlYmtpdC5vcmcvYi8xMDgzODAgaHR0 cC90ZXN0cy9jYWNoZS9jYWNoZWQtbWFpbi1yZXNvdXJjZS5odG1sIFsgRmFpbHVyZSBdCi13ZWJr aXQub3JnL2IvMTA4MzgwIGh0dHAvdGVzdHMvY2FjaGUvaWZyYW1lLTMwNC1jcmFzaC5odG1sIFsg RmFpbHVyZSBdCi13ZWJraXQub3JnL2IvMTA4MzgwIGh0dHAvdGVzdHMvaW5zcGVjdG9yL3Jlc291 cmNlLWhhci1wYWdlcy5odG1sIFsgRmFpbHVyZSBdCi13ZWJraXQub3JnL2IvMTA4MzgwIGh0dHAv dGVzdHMvbG9hZGluZy9yZWRpcmVjdC1tZXRob2RzLmh0bWwgWyBGYWlsdXJlIF0KLXdlYmtpdC5v cmcvYi8xMDgzODAgaHR0cC90ZXN0cy9taXNjL2xpbmstcmVsLWljb24tYmVmb3JlbG9hZC5odG1s IFsgRmFpbHVyZSBdCi13ZWJraXQub3JnL2IvMTA4MzgwIGh0dHAvdGVzdHMvbWlzYy9mYXZpY29u LWxvYWRzLXdpdGgtaW1hZ2VzLWRpc2FibGVkLmh0bWwgWyBGYWlsdXJlIF0K