107958 2013-01-25 09:51:40 -0800 Loosen restrictions on computePreferredLogicalWidths in RenderQuote and RenderCounter 2013-01-25 11:03:08 -0800 1 1 1 Unclassified WebKit New Bugs 528+ (Nightly build) Unspecified Unspecified RESOLVED DUPLICATE 104829 P2 Normal --- 1 ojan ojan arv eric jchaffraix keishi leviw ojan.autocc tony webkit.review.bot oldest_to_newest 816678 0 ojan 2013-01-25 09:51:40 -0800 Loosen restrictions on computePreferredLogicalWidths in RenderQuote and RenderCounter 816680 1 184769 ojan 2013-01-25 09:53:27 -0800 Created attachment 184769 Patch 816685 2 ojan 2013-01-25 09:54:09 -0800 *** Bug 107913 has been marked as a duplicate of this bug. *** 816703 3 184769 jchaffraix 2013-01-25 10:08:03 -0800 Comment on attachment 184769 Patch There is a patch to add pre-layout hooks that would just remove the need for these hacks (at least for RenderCounter, RenderQuote would be next in line). I would rather not land this patch and just go the pre-layout hooks way (see bug 104829). 816714 4 ojan 2013-01-25 10:13:34 -0800 (In reply to comment #3) > (From update of attachment 184769 [details]) > There is a patch to add pre-layout hooks that would just remove the need for these hacks (at least for RenderCounter, RenderQuote would be next in line). I would rather not land this patch and just go the pre-layout hooks way (see bug 104829). Bug 104629 addresses the FIXME and can remove it. In the meantime, we currently are hitting an assert. Once bug 104629 lands, we can remove this. What's the benefit of leaving the code in it's current state? We have a test that is hitting this the setNeedsLayoutIsForbidden assert that we need to do *something* with. IMO, this effectively documents the places where we need the pre-layout hooks. 816747 5 184769 ojan 2013-01-25 10:58:11 -0800 Comment on attachment 184769 Patch Looks like Julien's patch is ready to land and will fix the RenderCounter issue. We don't currently have a test that hits the RenderQuote issue, so I'm not too bothered about putting the assert guards there. Hopefully, we can migrate the RenderQuote code shortly to use the pre-layout hook. 816754 6 ojan 2013-01-25 11:03:08 -0800 *** This bug has been marked as a duplicate of bug 104829 *** 184769 2013-01-25 09:53:27 -0800 2013-01-25 10:58:11 -0800 Patch bug-107958-20130125095018.patch text/plain 3188 ojan U3VidmVyc2lvbiBSZXZpc2lvbjogMTQwODM3CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggOWQ4MWNiMmMzYWY1NmVl ODFiOGEzNjlhMmY2YjhjZjEyMmFkOTI0OC4uNzA0YWIxMDJkZTA1NmNmZTA1NWQxZmFiNDA4M2Ri OGM4ZmFhY2JjZCAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDIwIEBACisyMDEzLTAxLTI1ICBPamFu IFZhZmFpICA8b2phbkBjaHJvbWl1bS5vcmc+CisKKyAgICAgICAgTG9vc2VuIHJlc3RyaWN0aW9u cyBvbiBjb21wdXRlUHJlZmVycmVkTG9naWNhbFdpZHRocyBpbiBSZW5kZXJRdW90ZSBhbmQgUmVu ZGVyQ291bnRlcgorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/ aWQ9MTA3OTU4CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAg ICAgVGhlc2Ugd2VyZSBtaXNzZWQgaW4gaHR0cDovL3RyYWMud2Via2l0Lm9yZy9jaGFuZ2VzZXQv MTQwNTU0LgorICAgICAgICBSZW5kZXJRdW90ZSBhbmQgUmVuZGVyQ291bnRlciBjYW4gY2FsbCBz ZXROZWVkc0xheW91dCBpbiBzb21lIGNhc2VzLgorICAgICAgICBDdXJpb3VzbHksIG9ubHkgb25l IHRlc3QgaGl0cyB0aGlzIGF0IHRoZSBtb21lbnQgYW5kIGl0IGhpdHMKKyAgICAgICAgaXQgb25s eSBvbiBDaHJvbWl1bSBNYWMuCisKKyAgICAgICAgKiByZW5kZXJpbmcvUmVuZGVyQ291bnRlci5j cHA6CisgICAgICAgIChXZWJDb3JlOjpSZW5kZXJDb3VudGVyOjpjb21wdXRlUHJlZmVycmVkTG9n aWNhbFdpZHRocyk6CisgICAgICAgICogcmVuZGVyaW5nL1JlbmRlclF1b3RlLmNwcDoKKyAgICAg ICAgKFdlYkNvcmU6OlJlbmRlclF1b3RlOjpjb21wdXRlUHJlZmVycmVkTG9naWNhbFdpZHRocyk6 CisKIDIwMTMtMDEtMjUgIEd1c3Rhdm8gTm9yb25oYSBTaWx2YSAgPGduc0Bnbm9tZS5vcmc+CiAK ICAgICAgICAgW1NvdXBdIFN0cmVhbWxpbmUgY2FuY2VsbGF0aW9uIGFuZCBjbGllbnQgY2hlY2tz CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9yZW5kZXJpbmcvUmVuZGVyQ291bnRlci5jcHAg Yi9Tb3VyY2UvV2ViQ29yZS9yZW5kZXJpbmcvUmVuZGVyQ291bnRlci5jcHAKaW5kZXggZWVjZjVm NjkwYjRhNmI4N2U5OTEzMmRjMzAxMGJiZjExNDVjMDJkMC4uMGMyYjY1NWM1YmMyYzQ1MDgwZDFh OWZhZTcxNjhmZmQ3YjlkZTM5OSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvcmVuZGVyaW5n L1JlbmRlckNvdW50ZXIuY3BwCisrKyBiL1NvdXJjZS9XZWJDb3JlL3JlbmRlcmluZy9SZW5kZXJD b3VudGVyLmNwcApAQCAtNTE5LDcgKzUxOSwyMSBAQCB2b2lkIFJlbmRlckNvdW50ZXI6OnVwZGF0 ZVRleHQoKQogCiB2b2lkIFJlbmRlckNvdW50ZXI6OmNvbXB1dGVQcmVmZXJyZWRMb2dpY2FsV2lk dGhzKGZsb2F0IGxlYWQpCiB7CisjaWZuZGVmIE5ERUJVRworICAgIC8vIEZJWE1FOiBXZSBzaG91 bGRuJ3QgYmUgbW9kaWZ5aW5nIHRoZSB0cmVlIGluIGNvbXB1dGVQcmVmZXJyZWRMb2dpY2FsV2lk dGhzLgorICAgIC8vIEluc3RlYWQsIHdlIHNob3VsZCBwcm9wZXJseSBob29rIHRoZSBhcHByb3By aWF0ZSBjaGFuZ2VzIGluIHRoZSBET00gYW5kIG1vZGlmeQorICAgIC8vIHRoZSByZW5kZXIgdHJl ZSB0aGVuLiBXaGVuIHRoYXQncyBkb25lLCB3ZSBhbHNvIHdvbid0IG5lZWQgdG8gb3ZlcnJpZGUK KyAgICAvLyBjb21wdXRlUHJlZmVycmVkTG9naWNhbFdpZHRocyBhdCBhbGwuCisgICAgYm9vbCBv bGRTZXROZWVkc0xheW91dElzRm9yYmlkZGVuID0gaXNTZXROZWVkc0xheW91dEZvcmJpZGRlbigp OworICAgIHNldE5lZWRzTGF5b3V0SXNGb3JiaWRkZW4oZmFsc2UpOworI2VuZGlmCisKICAgICBz ZXRUZXh0SW50ZXJuYWwob3JpZ2luYWxUZXh0KCkpOworCisjaWZuZGVmIE5ERUJVRworICAgIHNl dE5lZWRzTGF5b3V0SXNGb3JiaWRkZW4ob2xkU2V0TmVlZHNMYXlvdXRJc0ZvcmJpZGRlbik7Cisj ZW5kaWYKKwogICAgIFJlbmRlclRleHQ6OmNvbXB1dGVQcmVmZXJyZWRMb2dpY2FsV2lkdGhzKGxl YWQpOwogfQogCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9yZW5kZXJpbmcvUmVuZGVyUXVv dGUuY3BwIGIvU291cmNlL1dlYkNvcmUvcmVuZGVyaW5nL1JlbmRlclF1b3RlLmNwcAppbmRleCBk YTE2ZGY1YWE3NzM2YzA2NWFmZDlmODYyOTQ1NDA3NDE1M2VlZWI1Li41NjIxNGYzMzdmZjVhM2U5 MTAxNDRlMWQ3MzNlYTg0N2U3ZDQ5ZTIyIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9yZW5k ZXJpbmcvUmVuZGVyUXVvdGUuY3BwCisrKyBiL1NvdXJjZS9XZWJDb3JlL3JlbmRlcmluZy9SZW5k ZXJRdW90ZS5jcHAKQEAgLTI1MCw5ICsyNTAsMjMgQEAgdm9pZCBSZW5kZXJRdW90ZTo6dXBkYXRl VGV4dCgpCiAKIHZvaWQgUmVuZGVyUXVvdGU6OmNvbXB1dGVQcmVmZXJyZWRMb2dpY2FsV2lkdGhz KGZsb2F0IGxlYWQpCiB7CisjaWZuZGVmIE5ERUJVRworICAgIC8vIEZJWE1FOiBXZSBzaG91bGRu J3QgYmUgbW9kaWZ5aW5nIHRoZSB0cmVlIGluIGNvbXB1dGVQcmVmZXJyZWRMb2dpY2FsV2lkdGhz LgorICAgIC8vIEluc3RlYWQsIHdlIHNob3VsZCBwcm9wZXJseSBob29rIHRoZSBhcHByb3ByaWF0 ZSBjaGFuZ2VzIGluIHRoZSBET00gYW5kIG1vZGlmeQorICAgIC8vIHRoZSByZW5kZXIgdHJlZSB0 aGVuLiBXaGVuIHRoYXQncyBkb25lLCB3ZSBhbHNvIHdvbid0IG5lZWQgdG8gb3ZlcnJpZGUKKyAg ICAvLyBjb21wdXRlUHJlZmVycmVkTG9naWNhbFdpZHRocyBhdCBhbGwuCisgICAgYm9vbCBvbGRT ZXROZWVkc0xheW91dElzRm9yYmlkZGVuID0gaXNTZXROZWVkc0xheW91dEZvcmJpZGRlbigpOwor ICAgIHNldE5lZWRzTGF5b3V0SXNGb3JiaWRkZW4oZmFsc2UpOworI2VuZGlmCisKICAgICBpZiAo IW1fYXR0YWNoZWQpCiAgICAgICAgIGF0dGFjaFF1b3RlKCk7CiAgICAgc2V0VGV4dEludGVybmFs KG9yaWdpbmFsVGV4dCgpKTsKKworI2lmbmRlZiBOREVCVUcKKyAgICBzZXROZWVkc0xheW91dElz Rm9yYmlkZGVuKG9sZFNldE5lZWRzTGF5b3V0SXNGb3JiaWRkZW4pOworI2VuZGlmCisKICAgICBS ZW5kZXJUZXh0Ojpjb21wdXRlUHJlZmVycmVkTG9naWNhbFdpZHRocyhsZWFkKTsKIH0KIAo=