107704 2013-01-23 10:38:52 -0800 Web Inspector: MIME type errors should be "debug" level. 2013-01-24 06:10:38 -0800 1 1 1 Unclassified WebKit Web Inspector (Deprecated) 528+ (Nightly build) All All RESOLVED DUPLICATE 98492 P2 Normal --- 97978 1 mkwst mkwst apavlov keishi loislo paulirish pfeldman pmuellr vsevik web-inspector-bugs yurys oldest_to_newest 814339 0 mkwst 2013-01-23 10:38:52 -0800 Moving the "Resource interpreted as XXX but transferred as MIME type XXX" message to debug level (down from warning) seems appropriate. It's much more of a debug message than a warning (though those boundaries are blurry). 814346 1 184261 mkwst 2013-01-23 10:41:38 -0800 Created attachment 184261 Patch 815359 2 184261 pfeldman 2013-01-24 05:25:04 -0800 Comment on attachment 184261 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=184261&action=review > Source/WebCore/inspector/front-end/NetworkManager.js:185 > + WebInspector.ConsoleMessage.MessageLevel.Debug, I think that this is still a warning. It should be filtered out by source, not severity. Like I know how console.warn, console.error and console.log are processed. I can stick to some standard in my code and tune my filters accordingly. But I don't know what severity is set for the internal messages. My guess would be that they match the common sense: - warnings warn about errors browser could recover from - errors report problems browser could not recover from - debug generates verbose debugging info flow - I would not expect browser to generate Log level messages to me. I think there should be a set of checkboxes ("Network", "CSS", "JavaScript") in console that would filter by source (in addition to existing message level). 815365 3 mkwst 2013-01-24 05:34:17 -0800 (In reply to comment #2) > > Source/WebCore/inspector/front-end/NetworkManager.js:185 > > + WebInspector.ConsoleMessage.MessageLevel.Debug, > > I think that this is still a warning. It should be filtered out by source, not severity. > ... > - warnings warn about errors browser could recover from > - errors report problems browser could not recover from This makes perfect sense to me. > - debug generates verbose debugging info flow What constitutes "debug" information? Right now, the only message using it is `console.timeEnd`. Not even `console.debug()` outputs at the Debug level (which makes very little sense to me). > - I would not expect browser to generate Log level messages to me. Currently, almost nothing generates Log-level messages: `console.{debug,log,dir,dirxml,clear,trace,startgroup,endgroup,profile,count}` all output at log level, but the only "internal" message at Log level is "XHR finished loading: %s" that users can opt into. > I think there should be a set of checkboxes ("Network", "CSS", "JavaScript") in console that would filter by source (in addition to existing message level). I do think this makes sense, though I'm not at all sure how to present them. :) If that's the right solution, I'd suggest duping this bug against https://bugs.webkit.org/show_bug.cgi?id=98492 and working through UI there. 815384 4 pfeldman 2013-01-24 05:58:19 -0800 > > - debug generates verbose debugging info flow > > What constitutes "debug" information? Right now, the only message using it is `console.timeEnd`. Not even `console.debug()` outputs at the Debug level (which makes very little sense to me). I think we should fix console.debug to use proper level. > > - I would not expect browser to generate Log level messages to me. > > Currently, almost nothing generates Log-level messages: `console.{debug,log,dir,dirxml,clear,trace,startgroup,endgroup,profile,count}` all output at log level, but the only "internal" message at Log level is "XHR finished loading: %s" that users can opt into. I am not sure about this one. It looks like a debug level to me. We could tell user to set Network message's level to debug to see that. > > > I think there should be a set of checkboxes ("Network", "CSS", "JavaScript") in console that would filter by source (in addition to existing message level). > > I do think this makes sense, though I'm not at all sure how to present them. :) If that's the right solution, I'd suggest duping this bug against https://bugs.webkit.org/show_bug.cgi?id=98492 and working through UI there. Merging sounds good. I was thinking of a "Sound Mixer" view where there were vertical severity bars (one per message source). 815395 5 mkwst 2013-01-24 06:10:38 -0800 (In reply to comment #4) > I think we should fix console.debug to use proper level. I'll throw a patch up at https://bugs.webkit.org/show_bug.cgi?id=107816 in a moment. An open question I've asked there: what about `console.info`? Is that TipMessageLevel? Should we have `console.tip`? Should we kill TipMessageLevel entirely, since I have no idea what it means and we're only using it once? :) > > > - I would not expect browser to generate Log level messages to me. > > > > Currently, almost nothing generates Log-level messages: `console.{debug,log,dir,dirxml,clear,trace,startgroup,endgroup,profile,count}` all output at log level, but the only "internal" message at Log level is "XHR finished loading: %s" that users can opt into. > > I am not sure about this one. It looks like a debug level to me. We could tell user to set Network message's level to debug to see that. Yeah, I think it's debug level as well: https://bugs.webkit.org/show_bug.cgi?id=107817 > > I do think this makes sense, though I'm not at all sure how to present them. :) If that's the right solution, I'd suggest duping this bug against https://bugs.webkit.org/show_bug.cgi?id=98492 and working through UI there. > > Merging sounds good. I was thinking of a "Sound Mixer" view where there were vertical severity bars (one per message source). Hrm. That sounds complicated, but we can try it out. I'll merge this bug in and we can fiddle with a solution over there. *** This bug has been marked as a duplicate of bug 98492 *** 184261 2013-01-23 10:41:38 -0800 2013-01-24 05:25:03 -0800 Patch bug-107704-20130123193833.patch text/plain 1855 mkwst U3VidmVyc2lvbiBSZXZpc2lvbjogMTQwMzg5CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggNjk4NzFiOGUwYmYxYzg2 MGE2ZjcwM2MwMTBlMzE5ZDU3NTliNTA4Zi4uYmZhNjQyNDUwZjQ1MzM1ZTBmYzEwYmE3OGRlZjcw Njc2YTVlMDZhOCAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE2IEBACisyMDEzLTAxLTIzICBNaWtl IFdlc3QgIDxta3dzdEBjaHJvbWl1bS5vcmc+CisKKyAgICAgICAgV2ViIEluc3BlY3RvcjogTUlN RSB0eXBlIGVycm9ycyBzaG91bGQgYmUgImRlYnVnIiBsZXZlbC4KKyAgICAgICAgaHR0cHM6Ly9i dWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTEwNzcwNAorCisgICAgICAgIFJldmlld2Vk IGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIFRoaXMgcGF0Y2ggY2hhbmdlcyB0aGUgbGV2 ZWwgb2YgdGhlIE1JTUUgdHlwZSBlcnJvciBtZXNzYWdlIHRvCisgICAgICAgICJkZWJ1ZyIsIGRv d24gZnJvbSAid2FybmluZyIuCisKKyAgICAgICAgKiBpbnNwZWN0b3IvZnJvbnQtZW5kL05ldHdv cmtNYW5hZ2VyLmpzOgorICAgICAgICAoV2ViSW5zcGVjdG9yLk5ldHdvcmtEaXNwYXRjaGVyLnBy b3RvdHlwZS5fdXBkYXRlTmV0d29ya1JlcXVlc3RXaXRoUmVzcG9uc2UpOgorCiAyMDEzLTAxLTIx ICBLZW50YXJvIEhhcmEgIDxoYXJha2VuQGNocm9taXVtLm9yZz4KIAogICAgICAgICBbVjhdIFNj cmlwdFN0YXRlOjppc29sYXRlKCkgc2hvdWxkIHVzZSBDb250ZXh0OjpHZXRJc29sYXRlKCkKZGlm ZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL2luc3BlY3Rvci9mcm9udC1lbmQvTmV0d29ya01hbmFn ZXIuanMgYi9Tb3VyY2UvV2ViQ29yZS9pbnNwZWN0b3IvZnJvbnQtZW5kL05ldHdvcmtNYW5hZ2Vy LmpzCmluZGV4IDVmMzU3NmE3YTA5Y2E1MTVlNTkwNmU0MjYxMWI2ZjdmMjcyOWEwMzcuLjBlMDVm MTgxNWNmZGZlOWIzYzBiMWMyYTI2MzAzNzA5ZWViMGI0MjEgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9X ZWJDb3JlL2luc3BlY3Rvci9mcm9udC1lbmQvTmV0d29ya01hbmFnZXIuanMKKysrIGIvU291cmNl L1dlYkNvcmUvaW5zcGVjdG9yL2Zyb250LWVuZC9OZXR3b3JrTWFuYWdlci5qcwpAQCAtMTgyLDcg KzE4Miw3IEBAIFdlYkluc3BlY3Rvci5OZXR3b3JrRGlzcGF0Y2hlci5wcm90b3R5cGUgPSB7CiAK ICAgICAgICAgaWYgKCF0aGlzLl9taW1lVHlwZUlzQ29uc2lzdGVudFdpdGhUeXBlKG5ldHdvcmtS ZXF1ZXN0KSkgewogICAgICAgICAgICAgV2ViSW5zcGVjdG9yLmNvbnNvbGUuYWRkTWVzc2FnZShX ZWJJbnNwZWN0b3IuQ29uc29sZU1lc3NhZ2UuY3JlYXRlKFdlYkluc3BlY3Rvci5Db25zb2xlTWVz c2FnZS5NZXNzYWdlU291cmNlLk5ldHdvcmssCi0gICAgICAgICAgICAgICAgV2ViSW5zcGVjdG9y LkNvbnNvbGVNZXNzYWdlLk1lc3NhZ2VMZXZlbC5XYXJuaW5nLAorICAgICAgICAgICAgICAgIFdl Ykluc3BlY3Rvci5Db25zb2xlTWVzc2FnZS5NZXNzYWdlTGV2ZWwuRGVidWcsCiAgICAgICAgICAg ICAgICAgV2ViSW5zcGVjdG9yLlVJU3RyaW5nKCJSZXNvdXJjZSBpbnRlcnByZXRlZCBhcyAlcyBi dXQgdHJhbnNmZXJyZWQgd2l0aCBNSU1FIHR5cGUgJXM6IFwiJXNcIi4iLCBuZXR3b3JrUmVxdWVz dC50eXBlLnRpdGxlKCksIG5ldHdvcmtSZXF1ZXN0Lm1pbWVUeXBlLCBuZXR3b3JrUmVxdWVzdC51 cmwpLAogICAgICAgICAgICAgICAgIFdlYkluc3BlY3Rvci5Db25zb2xlTWVzc2FnZS5NZXNzYWdl VHlwZS5Mb2csCiAgICAgICAgICAgICAgICAgIiIsCg==