107694 2013-01-23 07:50:21 -0800 [Qt][WK1] Remember denied permission for notifications 2013-01-30 01:29:54 -0800 1 1 1 Unclassified WebKit WebKit Qt 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 107449 1 allan.jensen allan.jensen jturcotte webkit.review.bot oldest_to_newest 814208 0 allan.jensen 2013-01-23 07:50:21 -0800 We currently only remember granted permissions for notifications. While the basic permission level for the application is the same without a user permission, it means the webpage can ask over and over after the user specifically denied it. 814214 1 184236 allan.jensen 2013-01-23 08:00:46 -0800 Created attachment 184236 Patch 815401 2 184236 jturcotte 2013-01-24 06:15:49 -0800 Comment on attachment 184236 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=184236&action=review > Source/WebKit/qt/WebCoreSupport/NotificationPresenterClientQt.cpp:424 > - callback->handleEvent(Notification::permissionString(NotificationClient::PermissionAllowed)); > + callback->handleEvent(Notification::permissionString(permission)); Is this a patch split artifact? 815410 3 184236 jturcotte 2013-01-24 06:22:38 -0800 Comment on attachment 184236 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=184236&action=review >> Source/WebKit/qt/WebCoreSupport/NotificationPresenterClientQt.cpp:424 >> + callback->handleEvent(Notification::permissionString(permission)); > > Is this a patch split artifact? Looks good to me otherwise, please remove this before landing. 815420 4 allan.jensen 2013-01-24 06:34:52 -0800 (In reply to comment #2) > (From update of attachment 184236 [details]) > View in context: https://bugs.webkit.org/attachment.cgi?id=184236&action=review > > > Source/WebKit/qt/WebCoreSupport/NotificationPresenterClientQt.cpp:424 > > - callback->handleEvent(Notification::permissionString(NotificationClient::PermissionAllowed)); > > + callback->handleEvent(Notification::permissionString(permission)); > > Is this a patch split artifact? No that is correct. This method was renamed to be able to both approve and reject permissions. 815425 5 184236 webkit.review.bot 2013-01-24 06:41:07 -0800 Comment on attachment 184236 Patch Rejecting attachment 184236 from commit-queue. Failed to run "['/mnt/git/webkit-commit-queue/Tools/Scripts/webkit-patch', '--status-host=queues.webkit.org', '--bot-id=gce-cq-04', 'apply-attachment', '--no-update', '--non-interactive', 184236, '--port=chromium-xvfb']" exit_code: 2 cwd: /mnt/git/webkit-commit-queue Last 500 characters of output: create file /tmp/pp3OGHLx : No space left on device patch: **** Can't create file /tmp/ppNkY7VA : No space left on device patch: **** Can't create file /tmp/ppR4mo8A : No space left on device patch: **** Can't create file /tmp/pp1eYnHA : No space left on device patch: **** Can't create file /tmp/ppzAoqwB : No space left on device Failed to run "[u'/mnt/git/webkit-commit-queue/Tools/Scripts/svn-apply', '--force', '--reviewer', 'Jocelyn Turcotte']" exit_code: 2 cwd: /mnt/git/webkit-commit-queue Full output: http://queues.webkit.org/results/16110081 815434 6 jturcotte 2013-01-24 06:49:00 -0800 (In reply to comment #4) > No that is correct. This method was renamed to be able to both approve and reject permissions. Alright, I see it now. 819944 7 184236 allan.jensen 2013-01-30 01:29:50 -0800 Comment on attachment 184236 Patch Clearing flags on attachment: 184236 Committed r141233: <http://trac.webkit.org/changeset/141233> 819945 8 allan.jensen 2013-01-30 01:29:54 -0800 All reviewed patches have been landed. Closing bug. 184236 2013-01-23 08:00:46 -0800 2013-01-30 01:29:50 -0800 Patch bug-107694-20130123165701.patch text/plain 7861 allan.jensen U3VidmVyc2lvbiBSZXZpc2lvbjogMTQwNTM3CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0L3F0 L0NoYW5nZUxvZyBiL1NvdXJjZS9XZWJLaXQvcXQvQ2hhbmdlTG9nCmluZGV4IGMzZGU4ZjgzYzk5 YzY5YmM5ZmJjNGI0ZWNkZGU1Y2FjODAwOWRjNmMuLjViN2YyMWMxYTYyNzQ2YjIyMDlkNzhiMTQx NGRmZDc1MTE3MWI5N2QgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQvcXQvQ2hhbmdlTG9nCisr KyBiL1NvdXJjZS9XZWJLaXQvcXQvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMjQgQEAKKzIwMTMtMDEt MjMgIEFsbGFuIFNhbmRmZWxkIEplbnNlbiAgPGFsbGFuLmplbnNlbkBkaWdpYS5jb20+CisKKyAg ICAgICAgW1F0XVtXSzFdIFJlbWVtYmVyIGRlbmllZCBwZXJtaXNzaW9uIGZvciBub3RpZmljYXRp b25zIAorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTA3 Njk0CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgU3Rv cmUgZGVuaWVkIHBlcm1pc3Npb25zLiBBY2NvcmRpbmcgdG8gdGhlIHNwZWNpZmljYXRpb24sIHdl IHNob3VsZAorICAgICAgICBhc2sgdGhlIHVzZXIgYWdhaW4gaWYgaGUgaGFzIGFscmVhZHkgZ3Jh bnRlZCBvciBkZW5pZWQgcGVybWlzc2lvbi4KKworICAgICAgICAqIFdlYkNvcmVTdXBwb3J0L05v dGlmaWNhdGlvblByZXNlbnRlckNsaWVudFF0LmNwcDoKKyAgICAgICAgKFdlYkNvcmU6Ok5vdGlm aWNhdGlvblByZXNlbnRlckNsaWVudFF0OjpyZXF1ZXN0UGVybWlzc2lvbik6CisgICAgICAgIChX ZWJDb3JlOjpOb3RpZmljYXRpb25QcmVzZW50ZXJDbGllbnRRdDo6c2V0Tm90aWZpY2F0aW9uc0Fs bG93ZWRGb3JGcmFtZSk6CisgICAgICAgICogV2ViQ29yZVN1cHBvcnQvTm90aWZpY2F0aW9uUHJl c2VudGVyQ2xpZW50UXQuaDoKKyAgICAgICAgKE5vdGlmaWNhdGlvblByZXNlbnRlckNsaWVudFF0 KToKKyAgICAgICAgKiBXZWJDb3JlU3VwcG9ydC9RV2ViUGFnZUFkYXB0ZXIuY3BwOgorICAgICAg ICAoUVdlYlBhZ2VBZGFwdGVyOjpzZXROb3RpZmljYXRpb25zQWxsb3dlZEZvckZyYW1lKToKKyAg ICAgICAgKiBXZWJDb3JlU3VwcG9ydC9RV2ViUGFnZUFkYXB0ZXIuaDoKKyAgICAgICAgKiBXaWRn ZXRBcGkvcXdlYnBhZ2UuY3BwOgorICAgICAgICAoUVdlYlBhZ2U6OnNldEZlYXR1cmVQZXJtaXNz aW9uKToKKwogMjAxMy0wMS0yMiAgQW5kZXJzIENhcmxzc29uICA8YW5kZXJzY2FAYXBwbGUuY29t PgogCiAgICAgICAgIFVzZSBhIHBsYXRmb3JvbSBzdHJhdGVneSBmb3IgbG9jYWwgc3RvcmFnZQpk aWZmIC0tZ2l0IGEvU291cmNlL1dlYktpdC9xdC9XZWJDb3JlU3VwcG9ydC9Ob3RpZmljYXRpb25Q cmVzZW50ZXJDbGllbnRRdC5jcHAgYi9Tb3VyY2UvV2ViS2l0L3F0L1dlYkNvcmVTdXBwb3J0L05v dGlmaWNhdGlvblByZXNlbnRlckNsaWVudFF0LmNwcAppbmRleCBkM2E2ZDc0ZTFkYWRiMDFhZmY1 NzRlMDQxOTFkN2UyOTljNDFmNzVjLi5mNjgxNmNmMTZkMTE5MzE0YTVkZGVlMzRhY2E5OWQzN2I0 YWE5ZDFjIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViS2l0L3F0L1dlYkNvcmVTdXBwb3J0L05vdGlm aWNhdGlvblByZXNlbnRlckNsaWVudFF0LmNwcAorKysgYi9Tb3VyY2UvV2ViS2l0L3F0L1dlYkNv cmVTdXBwb3J0L05vdGlmaWNhdGlvblByZXNlbnRlckNsaWVudFF0LmNwcApAQCAtMzEwLDYgKzMx MCwxMyBAQCB2b2lkIE5vdGlmaWNhdGlvblByZXNlbnRlckNsaWVudFF0OjpyZXF1ZXN0UGVybWlz c2lvbihTY3JpcHRFeGVjdXRpb25Db250ZXh0KiBjbwogICAgIGlmIChkdW1wTm90aWZpY2F0aW9u KQogICAgICAgICBwcmludGYoIkRFU0tUT1AgTk9USUZJQ0FUSU9OIFBFUk1JU1NJT04gUkVRVUVT VEVEOiAlc1xuIiwgUVN0cmluZyhjb250ZXh0LT5zZWN1cml0eU9yaWdpbigpLT50b1N0cmluZygp KS50b1V0ZjgoKS5jb25zdERhdGEoKSk7CiAKKyAgICBOb3RpZmljYXRpb25DbGllbnQ6OlBlcm1p c3Npb24gcGVybWlzc2lvbiA9IGNoZWNrUGVybWlzc2lvbihjb250ZXh0KTsKKyAgICBpZiAocGVy bWlzc2lvbiAhPSBOb3RpZmljYXRpb25DbGllbnQ6OlBlcm1pc3Npb25Ob3RBbGxvd2VkKSB7Cisg ICAgICAgIGlmIChjYWxsYmFjaykKKyAgICAgICAgICAgIGNhbGxiYWNrLT5oYW5kbGVFdmVudCgp OworICAgICAgICByZXR1cm47CisgICAgfQorCiAgICAgUUhhc2g8U2NyaXB0RXhlY3V0aW9uQ29u dGV4dCosIENhbGxiYWNrc0luZm8gPjo6aXRlcmF0b3IgaXRlciA9IG1fcGVuZGluZ1Blcm1pc3Np b25SZXF1ZXN0cy5maW5kKGNvbnRleHQpOwogICAgIGlmIChpdGVyICE9IG1fcGVuZGluZ1Blcm1p c3Npb25SZXF1ZXN0cy5lbmQoKSkKICAgICAgICAgaXRlci52YWx1ZSgpLm1fdm9pZENhbGxiYWNr cy5hcHBlbmQoY2FsbGJhY2spOwpAQCAtMzMzLDYgKzM0MCwxMyBAQCB2b2lkIE5vdGlmaWNhdGlv blByZXNlbnRlckNsaWVudFF0OjpyZXF1ZXN0UGVybWlzc2lvbihTY3JpcHRFeGVjdXRpb25Db250 ZXh0KiBjbwogICAgIGlmIChkdW1wTm90aWZpY2F0aW9uKQogICAgICAgICBwcmludGYoIkRFU0tU T1AgTk9USUZJQ0FUSU9OIFBFUk1JU1NJT04gUkVRVUVTVEVEOiAlc1xuIiwgUVN0cmluZyhjb250 ZXh0LT5zZWN1cml0eU9yaWdpbigpLT50b1N0cmluZygpKS50b1V0ZjgoKS5jb25zdERhdGEoKSk7 CiAKKyAgICBOb3RpZmljYXRpb25DbGllbnQ6OlBlcm1pc3Npb24gcGVybWlzc2lvbiA9IGNoZWNr UGVybWlzc2lvbihjb250ZXh0KTsKKyAgICBpZiAocGVybWlzc2lvbiAhPSBOb3RpZmljYXRpb25D bGllbnQ6OlBlcm1pc3Npb25Ob3RBbGxvd2VkKSB7CisgICAgICAgIGlmIChjYWxsYmFjaykKKyAg ICAgICAgICAgIGNhbGxiYWNrLT5oYW5kbGVFdmVudChOb3RpZmljYXRpb246OnBlcm1pc3Npb25T dHJpbmcocGVybWlzc2lvbikpOworICAgICAgICByZXR1cm47CisgICAgfQorCiAgICAgUUhhc2g8 U2NyaXB0RXhlY3V0aW9uQ29udGV4dCosIENhbGxiYWNrc0luZm8gPjo6aXRlcmF0b3IgaXRlciA9 IG1fcGVuZGluZ1Blcm1pc3Npb25SZXF1ZXN0cy5maW5kKGNvbnRleHQpOwogICAgIGlmIChpdGVy ICE9IG1fcGVuZGluZ1Blcm1pc3Npb25SZXF1ZXN0cy5lbmQoKSkKICAgICAgICAgaXRlci52YWx1 ZSgpLm1fY2FsbGJhY2tzLmFwcGVuZChjYWxsYmFjayk7CkBAIC0zNzgsOSArMzkyLDE0IEBAIHZv aWQgTm90aWZpY2F0aW9uUHJlc2VudGVyQ2xpZW50UXQ6OmNhbmNlbFJlcXVlc3RzRm9yUGVybWlz c2lvbihTY3JpcHRFeGVjdXRpb25DCiAgICAgcGFnZS0+bm90aWZpY2F0aW9uc1Blcm1pc3Npb25S ZXF1ZXN0Q2FuY2VsbGVkKGZyYW1lKTsKIH0KIAotdm9pZCBOb3RpZmljYXRpb25QcmVzZW50ZXJD bGllbnRRdDo6YWxsb3dOb3RpZmljYXRpb25Gb3JGcmFtZShGcmFtZSogZnJhbWUpCit2b2lkIE5v dGlmaWNhdGlvblByZXNlbnRlckNsaWVudFF0OjpzZXROb3RpZmljYXRpb25zQWxsb3dlZEZvckZy YW1lKEZyYW1lKiBmcmFtZSwgYm9vbCBhbGxvd2VkKQogewotICAgIG1fY2FjaGVkUGVybWlzc2lv bnMuaW5zZXJ0KGZyYW1lLT5kb2N1bWVudCgpLCBOb3RpZmljYXRpb25DbGllbnQ6OlBlcm1pc3Np b25BbGxvd2VkKTsKKyAgICBBU1NFUlQoZnJhbWUtPmRvY3VtZW50KCkpOworICAgIGlmICghZnJh bWUtPmRvY3VtZW50KCkpCisgICAgICAgIHJldHVybjsKKworICAgIE5vdGlmaWNhdGlvbkNsaWVu dDo6UGVybWlzc2lvbiBwZXJtaXNzaW9uID0gYWxsb3dlZCA/IE5vdGlmaWNhdGlvbkNsaWVudDo6 UGVybWlzc2lvbkFsbG93ZWQgOiBOb3RpZmljYXRpb25DbGllbnQ6OlBlcm1pc3Npb25EZW5pZWQ7 CisgICAgbV9jYWNoZWRQZXJtaXNzaW9ucy5pbnNlcnQoZnJhbWUtPmRvY3VtZW50KCksIHBlcm1p c3Npb24pOwogCiAgICAgUUhhc2g8U2NyaXB0RXhlY3V0aW9uQ29udGV4dCosICBDYWxsYmFja3NJ bmZvPjo6aXRlcmF0b3IgaXRlciA9IG1fcGVuZGluZ1Blcm1pc3Npb25SZXF1ZXN0cy5iZWdpbigp OwogICAgIHdoaWxlIChpdGVyICE9IG1fcGVuZGluZ1Blcm1pc3Npb25SZXF1ZXN0cy5lbmQoKSkg ewpAQCAtNDAyLDcgKzQyMSw3IEBAIHZvaWQgTm90aWZpY2F0aW9uUHJlc2VudGVyQ2xpZW50UXQ6 OmFsbG93Tm90aWZpY2F0aW9uRm9yRnJhbWUoRnJhbWUqIGZyYW1lKQogICAgIFFMaXN0PFJlZlB0 cjxOb3RpZmljYXRpb25QZXJtaXNzaW9uQ2FsbGJhY2s+ID4mIGNhbGxiYWNrcyA9IGl0ZXIudmFs dWUoKS5tX2NhbGxiYWNrczsKICAgICBRX0ZPUkVBQ0goY29uc3QgUmVmUHRyPE5vdGlmaWNhdGlv blBlcm1pc3Npb25DYWxsYmFjaz4mIGNhbGxiYWNrLCBjYWxsYmFja3MpIHsKICAgICAgICAgaWYg KGNhbGxiYWNrKQotICAgICAgICAgICAgY2FsbGJhY2stPmhhbmRsZUV2ZW50KE5vdGlmaWNhdGlv bjo6cGVybWlzc2lvblN0cmluZyhOb3RpZmljYXRpb25DbGllbnQ6OlBlcm1pc3Npb25BbGxvd2Vk KSk7CisgICAgICAgICAgICBjYWxsYmFjay0+aGFuZGxlRXZlbnQoTm90aWZpY2F0aW9uOjpwZXJt aXNzaW9uU3RyaW5nKHBlcm1pc3Npb24pKTsKICAgICB9CiAjZW5kaWYKICAgICBtX3BlbmRpbmdQ ZXJtaXNzaW9uUmVxdWVzdHMucmVtb3ZlKGl0ZXIua2V5KCkpOwpkaWZmIC0tZ2l0IGEvU291cmNl L1dlYktpdC9xdC9XZWJDb3JlU3VwcG9ydC9Ob3RpZmljYXRpb25QcmVzZW50ZXJDbGllbnRRdC5o IGIvU291cmNlL1dlYktpdC9xdC9XZWJDb3JlU3VwcG9ydC9Ob3RpZmljYXRpb25QcmVzZW50ZXJD bGllbnRRdC5oCmluZGV4IDJjNTJmNDM1YTBhZDUwOWUzMWFiYzk4YTIyNjQxYWZhOWExY2Q4YjIu LjQ3MGMwYjRjMTVjNTU5OGRiMDY5ZGE3OGQxZmNjN2ZhOGYzOWMzMWMgMTAwNjQ0Ci0tLSBhL1Nv dXJjZS9XZWJLaXQvcXQvV2ViQ29yZVN1cHBvcnQvTm90aWZpY2F0aW9uUHJlc2VudGVyQ2xpZW50 UXQuaAorKysgYi9Tb3VyY2UvV2ViS2l0L3F0L1dlYkNvcmVTdXBwb3J0L05vdGlmaWNhdGlvblBy ZXNlbnRlckNsaWVudFF0LmgKQEAgLTEwMSw3ICsxMDEsNyBAQCBwdWJsaWM6CiAKICAgICB2b2lk IGNhbmNlbChOb3RpZmljYXRpb25XcmFwcGVyKik7CiAKLSAgICB2b2lkIGFsbG93Tm90aWZpY2F0 aW9uRm9yRnJhbWUoRnJhbWUqKTsKKyAgICB2b2lkIHNldE5vdGlmaWNhdGlvbnNBbGxvd2VkRm9y RnJhbWUoRnJhbWUqLCBib29sIGFsbG93ZWQpOwogCiAgICAgc3RhdGljIGJvb2wgZHVtcE5vdGlm aWNhdGlvbjsKIApkaWZmIC0tZ2l0IGEvU291cmNlL1dlYktpdC9xdC9XZWJDb3JlU3VwcG9ydC9R V2ViUGFnZUFkYXB0ZXIuY3BwIGIvU291cmNlL1dlYktpdC9xdC9XZWJDb3JlU3VwcG9ydC9RV2Vi UGFnZUFkYXB0ZXIuY3BwCmluZGV4IDYzZjQ0MmE3MGNlMWRlMTBlYzcyYzAyZWI2ZWZkZTI1OTRh Y2QyZjguLjhkZmI0ZmY3YTY5NzM4ZDNiMjQ1YzgwYmZjYWU2MDQ3NGM2MWU3OGMgMTAwNjQ0Ci0t LSBhL1NvdXJjZS9XZWJLaXQvcXQvV2ViQ29yZVN1cHBvcnQvUVdlYlBhZ2VBZGFwdGVyLmNwcAor KysgYi9Tb3VyY2UvV2ViS2l0L3F0L1dlYkNvcmVTdXBwb3J0L1FXZWJQYWdlQWRhcHRlci5jcHAK QEAgLTEyMjgsOSArMTIyOCw5IEBAIFFTdHJpbmcgUVdlYlBhZ2VBZGFwdGVyOjpjb250ZXh0TWVu dUl0ZW1UYWdGb3JBY3Rpb24oUVdlYlBhZ2VBZGFwdGVyOjpNZW51QWN0aW9uCiB9CiAKICNpZiBF TkFCTEUoTk9USUZJQ0FUSU9OUykgfHwgRU5BQkxFKExFR0FDWV9OT1RJRklDQVRJT05TKQotdm9p ZCBRV2ViUGFnZUFkYXB0ZXI6OmFsbG93Tm90aWZpY2F0aW9uc0ZvckZyYW1lKFFXZWJGcmFtZUFk YXB0ZXIqIGZyYW1lKQordm9pZCBRV2ViUGFnZUFkYXB0ZXI6OnNldE5vdGlmaWNhdGlvbnNBbGxv d2VkRm9yRnJhbWUoUVdlYkZyYW1lQWRhcHRlciogZnJhbWUsIGJvb2wgYWxsb3dlZCkKIHsKLSAg ICBOb3RpZmljYXRpb25QcmVzZW50ZXJDbGllbnRRdDo6bm90aWZpY2F0aW9uUHJlc2VudGVyKCkt PmFsbG93Tm90aWZpY2F0aW9uRm9yRnJhbWUoZnJhbWUtPmZyYW1lKTsKKyAgICBOb3RpZmljYXRp b25QcmVzZW50ZXJDbGllbnRRdDo6bm90aWZpY2F0aW9uUHJlc2VudGVyKCktPnNldE5vdGlmaWNh dGlvbnNBbGxvd2VkRm9yRnJhbWUoZnJhbWUtPmZyYW1lLCBhbGxvd2VkKTsKIH0KIAogdm9pZCBR V2ViUGFnZUFkYXB0ZXI6OmFkZE5vdGlmaWNhdGlvblByZXNlbnRlckNsaWVudCgpCmRpZmYgLS1n aXQgYS9Tb3VyY2UvV2ViS2l0L3F0L1dlYkNvcmVTdXBwb3J0L1FXZWJQYWdlQWRhcHRlci5oIGIv U291cmNlL1dlYktpdC9xdC9XZWJDb3JlU3VwcG9ydC9RV2ViUGFnZUFkYXB0ZXIuaAppbmRleCAy MmE1MjEwOTlhZjAzYzkzNGZiOWY0NjY4MGM2N2FlY2RjNTdmYmRjLi4zN2IzMzkyY2Q2NzMyZTMz YTY4OTY5MzU4YjJiMmMyMDJkYmY0NTBiIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViS2l0L3F0L1dl YkNvcmVTdXBwb3J0L1FXZWJQYWdlQWRhcHRlci5oCisrKyBiL1NvdXJjZS9XZWJLaXQvcXQvV2Vi Q29yZVN1cHBvcnQvUVdlYlBhZ2VBZGFwdGVyLmgKQEAgLTMxMiw3ICszMTIsNyBAQCBwdWJsaWM6 CiAgICAgdm9pZCBzZXRHZW9sb2NhdGlvbkVuYWJsZWRGb3JGcmFtZShRV2ViRnJhbWVBZGFwdGVy KiwgYm9vbCk7CiAjZW5kaWYKICNpZiBFTkFCTEUoTk9USUZJQ0FUSU9OUykgfHwgRU5BQkxFKExF R0FDWV9OT1RJRklDQVRJT05TKQotICAgIHZvaWQgYWxsb3dOb3RpZmljYXRpb25zRm9yRnJhbWUo UVdlYkZyYW1lQWRhcHRlciopOworICAgIHZvaWQgc2V0Tm90aWZpY2F0aW9uc0FsbG93ZWRGb3JG cmFtZShRV2ViRnJhbWVBZGFwdGVyKiwgYm9vbCBhbGxvd2VkKTsKICAgICB2b2lkIGFkZE5vdGlm aWNhdGlvblByZXNlbnRlckNsaWVudCgpOwogI2lmbmRlZiBRVF9OT19TWVNURU1UUkFZSUNPTgog ICAgIGJvb2wgaGFzU3lzdGVtVHJheUljb24oKSBjb25zdDsKZGlmZiAtLWdpdCBhL1NvdXJjZS9X ZWJLaXQvcXQvV2lkZ2V0QXBpL3F3ZWJwYWdlLmNwcCBiL1NvdXJjZS9XZWJLaXQvcXQvV2lkZ2V0 QXBpL3F3ZWJwYWdlLmNwcAppbmRleCBmOWNlYzNlNTQ3MzI2ZTIzODZkZWI1ZjY3ZDFhYzA5MTdl NDM4YmE0Li5hMWZlNDllMTM3OTI0MTBjMmUzOWUxMzM3YzNkZTFkM2M0M2ZmMjFmIDEwMDY0NAot LS0gYS9Tb3VyY2UvV2ViS2l0L3F0L1dpZGdldEFwaS9xd2VicGFnZS5jcHAKKysrIGIvU291cmNl L1dlYktpdC9xdC9XaWRnZXRBcGkvcXdlYnBhZ2UuY3BwCkBAIC0xNTg0LDExICsxNTg0LDE1IEBA IGJvb2wgUVdlYlBhZ2U6OnNob3VsZEludGVycnVwdEphdmFTY3JpcHQoKQogCiB2b2lkIFFXZWJQ YWdlOjpzZXRGZWF0dXJlUGVybWlzc2lvbihRV2ViRnJhbWUqIGZyYW1lLCBGZWF0dXJlIGZlYXR1 cmUsIFBlcm1pc3Npb25Qb2xpY3kgcG9saWN5KQogeworI2lmICFFTkFCTEUoTk9USUZJQ0FUSU9O UykgJiYgIUVOQUJMRShMRUdBQ1lfTk9USUZJQ0FUSU9OUykgJiYgIUVOQUJMRShHRU9MT0NBVElP TikKKyAgICBRX1VOVVNFRChmcmFtZSk7CisgICAgUV9VTlVTRUQocG9saWN5KTsKKyNlbmRpZgog ICAgIHN3aXRjaCAoZmVhdHVyZSkgewogICAgIGNhc2UgTm90aWZpY2F0aW9uczoKICNpZiBFTkFC TEUoTk9USUZJQ0FUSU9OUykgfHwgRU5BQkxFKExFR0FDWV9OT1RJRklDQVRJT05TKQotICAgICAg ICBpZiAocG9saWN5ID09IFBlcm1pc3Npb25HcmFudGVkQnlVc2VyKQotICAgICAgICAgICAgZC0+ YWxsb3dOb3RpZmljYXRpb25zRm9yRnJhbWUoZnJhbWUtPmQpOworICAgICAgICBpZiAocG9saWN5 ICE9IFBlcm1pc3Npb25Vbmtub3duKQorICAgICAgICAgICAgZC0+c2V0Tm90aWZpY2F0aW9uc0Fs bG93ZWRGb3JGcmFtZShmcmFtZS0+ZCwgKHBvbGljeSA9PSBQZXJtaXNzaW9uR3JhbnRlZEJ5VXNl cikpOwogI2VuZGlmCiAgICAgICAgIGJyZWFrOwogICAgIGNhc2UgR2VvbG9jYXRpb246Cg==