107261 2013-01-18 04:53:33 -0800 Crash in AccessibilityTableCell::parentTable() 2013-01-21 08:59:12 -0800 1 1 1 Unclassified WebKit Accessibility 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Major --- 106903 1 svillar jdiggs aboxhall apinheiro buildbot cfleizach dmazzoni jdiggs mario rniwa svillar webkit.review.bot zan oldest_to_newest 810485 0 svillar 2013-01-18 04:53:33 -0800 It's quite easy to get a crash when performing browsing actions on pages including tables. I always get one when doing things like: 1- go to www.amazon.com 2- input some text in the search box and click on "Go" 3- sroll down to the end of the list and click on "Next Page" you'd get a crash like this one (release webkitgtk build): Program received signal SIGSEGV, Segmentation fault. 0x00007ffff510a14b in WebCore::AccessibilityTableCell::parentTable() const () from ~/opt/gnome3/lib64/libwebkitgtk-3.0.so.0 (gdb) bt #0 0x00007ffff510a14b in WebCore::AccessibilityTableCell::parentTable() const () from ~/opt/gnome3/lib64/libwebkitgtk-3.0.so.0 #1 0x00007ffff510a09d in WebCore::AccessibilityTableCell::isTableCell() const () from ~/opt/gnome3/lib64/libwebkitgtk-3.0.so.0 #2 0x00007ffff510a0dd in WebCore::AccessibilityTableCell::roleValue() const () from ~/opt/gnome3/lib64/libwebkitgtk-3.0.so.0 #3 0x00007ffff5f8d106 in webkitAccessibleDetach () from ~/opt/gnome3/lib64/libwebkitgtk-3.0.so.0 #4 0x00007ffff510de3c in WebCore::AXObjectCache::remove(unsigned int) () from ~/opt/gnome3/lib64/libwebkitgtk-3.0.so.0 #5 0x00007ffff510e05e in WebCore::AXObjectCache::remove(WebCore::RenderObject*) () from ~/opt/gnome3/lib64/libwebkitgtk-3.0.so.0 #6 0x00007ffff58bb4ac in WebCore::RenderObject::willBeDestroyed() () from ~/opt/gnome3/lib64/libwebkitgtk-3.0.so.0 #7 0x00007ffff57dbd5d in WebCore::RenderBlock::willBeDestroyed() () from ~/opt/gnome3/lib64/libwebkitgtk-3.0.so.0 #9 0x00007ffff58b1b04 in WebCore::RenderObjectChildList::destroyLeftoverChildren() () from ~/opt/gnome3/lib64/libwebkitgtk-3.0.so.0 #10 0x00007ffff58bb1fa in WebCore::RenderObject::willBeDestroyed() () from ~/opt/gnome3/lib64/libwebkitgtk-3.0.so.0 #11 0x00007ffff58b9e5d in WebCore::RenderObject::destroy() () from ~/opt/gnome3/lib64/libwebkitgtk-3.0.so.0 #12 0x00007ffff58b1b04 in WebCore::RenderObjectChildList::destroyLeftoverChildren() () from ~/opt/gnome3/lib64/libwebkitgtk-3.0.so.0 #13 0x00007ffff58bb1fa in WebCore::RenderObject::willBeDestroyed() () from ~/opt/gnome3/lib64/libwebkitgtk-3.0.so.0 #14 0x00007ffff58b9e5d in WebCore::RenderObject::destroy() () from ~/opt/gnome3/lib64/libwebkitgtk-3.0.so.0 #15 0x00007ffff58b1b04 in WebCore::RenderObjectChildList::destroyLeftoverChildren() () from ~/opt/gnome3/lib64/libwebkitgtk-3.0.so.0 #16 0x00007ffff57dbc7c in WebCore::RenderBlock::willBeDestroyed() () from ~/opt/gnome3/lib64/libwebkitgtk-3.0.so.0 #17 0x00007ffff58b9e5d in WebCore::RenderObject::destroy() () from ~/opt/gnome3/lib64/libwebkitgtk-3.0.so.0 #18 0x00007ffff58b1b04 in WebCore::RenderObjectChildList::destroyLeftoverChildren() () from ~/opt/gnome3/lib64/libwebkitgtk-3.0.so.0 #19 0x00007ffff57dbc7c in WebCore::RenderBlock::willBeDestroyed() () from ~/opt/gnome3/lib64/libwebkitgtk-3.0.so.0 #20 0x00007ffff58b9e5d in WebCore::RenderObject::destroy() () from ~/opt/gnome3/lib64/libwebkitgtk-3.0.so.0 #21 0x00007ffff58b1b04 in WebCore::RenderObjectChildList::destroyLeftoverChildren() () from ~/opt/gnome3/lib64/libwebkitgtk-3.0.so.0 #22 0x00007ffff57dbc7c in WebCore::RenderBlock::willBeDestroyed() () from ~/opt/gnome3/lib64/libwebkitgtk-3.0.so.0 #23 0x00007ffff58b9e5d in WebCore::RenderObject::destroy() () from ~/opt/gnome3/lib64/libwebkitgtk-3.0.so.0 #24 0x00007ffff5346ac2 in WebCore::Node::detach() () from ~/opt/gnome3/lib64/libwebkitgtk-3.0.so.0 #25 0x00007ffff52d6b6e in WebCore::ContainerNode::detach() () from ~/opt/gnome3/lib64/libwebkitgtk-3.0.so.0 #26 0x00007ffff5322734 in WebCore::Element::detach() () from ~/opt/gnome3/lib64/libwebkitgtk-3.0.so.0 #27 0x00007ffff53232cc in WebCore::Element::recalcStyle(WebCore::Node::StyleChange) () from ~/opt/gnome3/lib64/libwebkitgtk-3.0.so.0 #28 0x00007ffff5322fe5 in WebCore::Element::recalcStyle(WebCore::Node::StyleChange) () from ~/opt/gnome3/lib64/libwebkitgtk-3.0.so.0 #29 0x00007ffff5322fe5 in WebCore::Element::recalcStyle(WebCore::Node::StyleChange) () from ~/opt/gnome3/lib64/libwebkitgtk-3.0.so.0 #30 0x00007ffff5322fe5 in WebCore::Element::recalcStyle(WebCore::Node::StyleChange) () from ~/opt/gnome3/lib64/libwebkitgtk-3.0.so.0 #31 0x00007ffff5322fe5 in WebCore::Element::recalcStyle(WebCore::Node::StyleChange) () from ~/opt/gnome3/lib64/libwebkitgtk-3.0.so.0 #32 0x00007ffff5322fe5 in WebCore::Element::recalcStyle(WebCore::Node::StyleChange) () from ~/opt/gnome3/lib64/libwebkitgtk-3.0.so.0 #33 0x00007ffff5322fe5 in WebCore::Element::recalcStyle(WebCore::Node::StyleChange) () from ~/opt/gnome3/lib64/libwebkitgtk-3.0.so.0 #34 0x00007ffff52f72db in WebCore::Document::recalcStyle(WebCore::Node::StyleChange) () from ~/opt/gnome3/lib64/libwebkitgtk-3.0.so.0 #35 0x00007ffff52f76ce in WebCore::Document::updateStyleIfNeeded() () from ~/opt/gnome3/lib64/libwebkitgtk-3.0.so.0 #36 0x00007ffff52f8212 in WebCore::Document::updateLayout() () from ~/opt/gnome3/lib64/libwebkitgtk-3.0.so.0 #37 0x00007ffff52fa939 in WebCore::Document::updateLayoutIgnorePendingStylesheets() () from ~/opt/gnome3/lib64/libwebkitgtk-3.0.so.0 #38 0x00007ffff572590b in WebCore::DOMWindow::scrollTo(int, int) const () from ~/opt/gnome3/lib64/libwebkitgtk-3.0.so.0 #39 0x00007ffff5af5848 in WebCore::jsDOMWindowPrototypeFunctionScrollTo(JSC::ExecState*) () from ~/opt/gnome3/lib64/libwebkitgtk-3.0.so.0 810486 1 183426 svillar 2013-01-18 04:55:58 -0800 Created attachment 183426 Patch 810496 2 183426 svillar 2013-01-18 05:27:39 -0800 Comment on attachment 183426 Patch Actually I'm no longer setting it for review, because it looked like an ad hoc fix. The crashes are still there in some other cases even if the patch is applied. 810531 3 cfleizach 2013-01-18 06:24:54 -0800 I think the isTableCell call can rely solely on roleValue() and we could Do the same thing we just did for table rows, which is determine the role up front and cache it 810533 4 jdiggs 2013-01-18 06:30:40 -0800 (In reply to comment #3) > I think the isTableCell call can rely solely on roleValue() and we could > Do the same thing we just did for table rows, which is determine the role up front and cache it Cool. I'll give that a try. Thanks! I'm also working on creating a layout test for this bug. 810610 5 183461 jdiggs 2013-01-18 08:05:06 -0800 Created attachment 183461 Patch 810612 6 jdiggs 2013-01-18 08:05:59 -0800 It's taking longer than I thought to create this layout test. :( So tossing the proposed patch at EWS in the meantime. 810616 7 cfleizach 2013-01-18 08:09:22 -0800 I think the concept looks good. 810715 8 jdiggs 2013-01-18 09:33:40 -0800 (In reply to comment #7) > I think the concept looks good. And while the EWS takes its time and spits up, I ran the mac tests. Looks like we have a similar issue with search-when-element-starts-in-table.html. I'll fix that and submit a new patch. 810724 9 183461 buildbot 2013-01-18 09:41:56 -0800 Comment on attachment 183461 Patch Attachment 183461 did not pass mac-ews (mac): Output: http://queues.webkit.org/results/15939679 New failing tests: platform/mac/accessibility/search-when-element-starts-in-table.html 810764 10 183493 jdiggs 2013-01-18 10:03:52 -0800 Created attachment 183493 Patch 810765 11 183493 jdiggs 2013-01-18 10:09:07 -0800 Comment on attachment 183493 Patch Chris, this addresses the regression on the mac. I'm having problems coming up with a reliable crasher Layout Test. Given that we have a bunch of table tests to ensure this doesn't introduce a regression, and given that non-AT users have been complaining quite a bit about this one.... How essential is it that I create a new layout test in order to get this fix committed? 810767 12 cfleizach 2013-01-18 10:13:36 -0800 (In reply to comment #11) > (From update of attachment 183493 [details]) > Chris, this addresses the regression on the mac. > > I'm having problems coming up with a reliable crasher Layout Test. Given that we have a bunch of table tests to ensure this doesn't introduce a regression, and given that non-AT users have been complaining quite a bit about this one.... How essential is it that I create a new layout test in order to get this fix committed? looking at the BT, it looks like if you listen for a scroll to event, then delete an entire table, after having accessed the whole table through accessibility, it should occur it seems like as soon as webkitAccessibleDetach calls roleValue() on a tableCell who's parent is already gone, you should hit it. perhaps having a reference to the table cell and then deleting the parent... it's also possible this one fixed it? or have you been reproducing on a build after this? http://trac.webkit.org/changeset/139444 810770 13 jdiggs 2013-01-18 10:16:17 -0800 (In reply to comment #12) > it's also possible this one fixed it? or have you been reproducing on a build after this? > > http://trac.webkit.org/changeset/139444 I can reproduce with git master. :( 810809 14 jdiggs 2013-01-18 10:39:04 -0800 (In reply to comment #12) > looking at the BT, it looks like if you listen for a scroll to event, then delete an entire table, after having accessed the whole table through accessibility, it should occur Brilliant! I don't even have to listen for (or even have) that event. Thanks!! 810840 15 183509 jdiggs 2013-01-18 10:59:21 -0800 Created attachment 183509 Same fix; now with layout test. 811218 16 jdiggs 2013-01-18 17:54:51 -0800 (In reply to comment #7) > I think the concept looks good. How about the code and layout test? :) I'm not sure what's holding up the EFL bot but all the other EWS bots are green. 811601 17 svillar 2013-01-20 03:37:47 -0800 *** Bug 106431 has been marked as a duplicate of this bug. *** 812200 18 183509 cfleizach 2013-01-21 08:54:31 -0800 Comment on attachment 183509 Same fix; now with layout test. r=me 812203 19 183509 webkit.review.bot 2013-01-21 08:59:07 -0800 Comment on attachment 183509 Same fix; now with layout test. Clearing flags on attachment: 183509 Committed r140340: <http://trac.webkit.org/changeset/140340> 812204 20 webkit.review.bot 2013-01-21 08:59:12 -0800 All reviewed patches have been landed. Closing bug. 183426 2013-01-18 04:55:58 -0800 2013-01-18 08:05:01 -0800 Patch bug-107261-20130118135256.patch text/plain 1738 svillar U3VidmVyc2lvbiBSZXZpc2lvbjogMTQwMTE1CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggZmNhZTc4MzI4NWUyZTI2 ZjdjMTMxZDc0YmI2OTA2MDg1YTY1MzE5YS4uYzQ4MmU0MmQ2NmNhZDBmYzRjYjJlODBmZjhjNWQz MjczZDFkYjdiZCAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE2IEBACisyMDEzLTAxLTE4ICBTZXJn aW8gVmlsbGFyIFNlbmluICA8c3ZpbGxhckBpZ2FsaWEuY29tPgorCisgICAgICAgIENyYXNoIGlu IEFjY2Vzc2liaWxpdHlUYWJsZUNlbGw6OnBhcmVudFRhYmxlKCkKKyAgICAgICAgaHR0cHM6Ly9i dWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTEwNzI2MQorCisgICAgICAgIFJldmlld2Vk IGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIENoZWNrIHRoYXQgdGhlIGFjY2Vzc2libGUg Y2VsbCBvYmplY3QgaXMgbm90IGJlaW5nIGRlc3Ryb3llZCBiZWZvcmUKKyAgICAgICAgdHJ5aW5n IHRvIGdldCBpdHMgcGFyZW50IHRhYmxlLgorCisgICAgICAgICogYWNjZXNzaWJpbGl0eS9BY2Nl c3NpYmlsaXR5VGFibGVDZWxsLmNwcDoKKyAgICAgICAgKFdlYkNvcmU6OkFjY2Vzc2liaWxpdHlU YWJsZUNlbGw6OnBhcmVudFRhYmxlKToKKwogMjAxMy0wMS0xOCAgVGFrYXNoaSBTYWthbW90byAg PHRhc2FrQGdvb2dsZS5jb20+CiAKICAgICAgICAgSW1wbGVtZW50IENTU0hvc3RSdWxlIGZvciBA aG9zdCBALXJ1bGVzLgpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYkNvcmUvYWNjZXNzaWJpbGl0eS9B Y2Nlc3NpYmlsaXR5VGFibGVDZWxsLmNwcCBiL1NvdXJjZS9XZWJDb3JlL2FjY2Vzc2liaWxpdHkv QWNjZXNzaWJpbGl0eVRhYmxlQ2VsbC5jcHAKaW5kZXggZjJiMWM5NThiODk5ZGYzMDhmYTJmZmVk MjYxNjdlNWUyNDAxNGU5NC4uY2Q4YTViNWFmMjQ3OTQzMDFmNTI4N2ZkNGNiM2JhMWY1MTQxNmQw YyAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvYWNjZXNzaWJpbGl0eS9BY2Nlc3NpYmlsaXR5 VGFibGVDZWxsLmNwcAorKysgYi9Tb3VyY2UvV2ViQ29yZS9hY2Nlc3NpYmlsaXR5L0FjY2Vzc2li aWxpdHlUYWJsZUNlbGwuY3BwCkBAIC03NCw3ICs3NCwxMSBAQCBBY2Nlc3NpYmlsaXR5T2JqZWN0 KiBBY2Nlc3NpYmlsaXR5VGFibGVDZWxsOjpwYXJlbnRUYWJsZSgpIGNvbnN0CiB7CiAgICAgaWYg KCFtX3JlbmRlcmVyIHx8ICFtX3JlbmRlcmVyLT5pc1RhYmxlQ2VsbCgpKQogICAgICAgICByZXR1 cm4gMDsKLSAgICAKKworICAgIC8vIENoZWNrIHRoYXQgdGhlIG9iamVjdCBpcyBub3QgYmVpbmcg ZGVzdHJveWVkLgorICAgIGlmICghYXhPYmplY3RDYWNoZSgpKQorICAgICAgICByZXR1cm4gMDsK KwogICAgIC8vIERvIG5vdCB1c2UgZ2V0T3JDcmVhdGUuIHBhcmVudFRhYmxlKCkgY2FuIGJlIGNh bGxlZCB3aGlsZSB0aGUgcmVuZGVyIHRyZWUgaXMgYmVpbmcgbW9kaWZpZWQgCiAgICAgLy8gYnkg amF2YXNjcmlwdCwgYW5kIGNyZWF0aW5nIGEgdGFibGUgZWxlbWVudCBtYXkgdHJ5IHRvIGFjY2Vz cyB0aGUgcmVuZGVyIHRyZWUgd2hpbGUgaW4gYSBiYWQgc3RhdGUuCiAgICAgLy8gQnkgdXNpbmcg b25seSBnZXQoKSBpbXBsaWVzIHRoYXQgdGhlIEFYVGFibGUgbXVzdCBiZSBjcmVhdGVkIGJlZm9y ZSBBWFRhYmxlQ2VsbHMuIFRoaXMgc2hvdWxkCg== 183461 2013-01-18 08:05:06 -0800 2013-01-18 10:03:46 -0800 Patch bug-107261-20130118110204.patch text/plain 3273 jdiggs U3VidmVyc2lvbiBSZXZpc2lvbjogMTQwMTMxCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggY2ZiMmJjY2YyNDBhNDhm ZTliZDk2MGRmOTJiNDdkMDIzZmZhMzRiMS4uZDhiNWYxNTlhOTVhNGRlNjRjN2QwYmNlYTZlMDcx YTNhZjQ3ZGFiNCAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDIyIEBACisyMDEzLTAxLTE4ICBKb2Fu bWFyaWUgRGlnZ3MgIDxqZGlnZ3NAaWdhbGlhLmNvbT4KKworICAgICAgICBDcmFzaCBpbiBBY2Nl c3NpYmlsaXR5VGFibGVDZWxsOjpwYXJlbnRUYWJsZSgpCisgICAgICAgIGh0dHBzOi8vYnVncy53 ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xMDcyNjEKKworICAgICAgICBSZXZpZXdlZCBieSBO T0JPRFkgKE9PUFMhKS4KKworICAgICAgICBHZXR0aW5nIHRoZSBwYXJlbnQgdGFibGUgaW4gb3Jk ZXIgdG8gZ2V0IHRoZSByb2xlIHZhbHVlIHNob3VsZCBub3QgYmUKKyAgICAgICAgZG9uZSB3aGVu IG9iamVjdHMgYXJlIGJlaW5nIGRlc3Ryb3llZC4gQWxzbywgaXQgZG9lcyBub3Qgc2VlbSBzYWZl IHRvCisgICAgICAgIGFzc3VtZSB3ZSBoYXZlIGFuIEFYT2JqZWN0Q2FjaGUuCisKKyAgICAgICAg Tm8gbmV3IHRlc3RzIChPT1BTISkuCisKKyAgICAgICAgKiBhY2Nlc3NpYmlsaXR5L0FjY2Vzc2li aWxpdHlUYWJsZUNlbGwuY3BwOgorICAgICAgICAoV2ViQ29yZTo6QWNjZXNzaWJpbGl0eVRhYmxl Q2VsbDo6cGFyZW50VGFibGUpOiBCZSBzdXJlIHdlIGhhdmUgYW4gQVhPYmplY3RDYWNoZS4KKyAg ICAgICAgKFdlYkNvcmU6OkFjY2Vzc2liaWxpdHlUYWJsZUNlbGw6OmRldGVybWluZUFjY2Vzc2li aWxpdHlSb2xlKTogTW92ZSB0aGUgcm9sZVZhbHVlKCkgbG9naWMgaGVyZS4KKyAgICAgICAgKiBh Y2Nlc3NpYmlsaXR5L0FjY2Vzc2liaWxpdHlUYWJsZUNlbGwuaDoKKyAgICAgICAgKEFjY2Vzc2li aWxpdHlUYWJsZUNlbGwpOgorCiAyMDEzLTAxLTE4ICBZdXJ5IFNlbWlraGF0c2t5ICA8eXVyeXNA Y2hyb21pdW0ub3JnPgogCiAgICAgICAgIFVucmV2aWV3ZWQuIEZpeCBRdCBtaW5pbWFsIGNvbXBp bGF0aW9uIGFmdGVyIHIxNDAxMjcKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL2FjY2Vzc2li aWxpdHkvQWNjZXNzaWJpbGl0eVRhYmxlQ2VsbC5jcHAgYi9Tb3VyY2UvV2ViQ29yZS9hY2Nlc3Np YmlsaXR5L0FjY2Vzc2liaWxpdHlUYWJsZUNlbGwuY3BwCmluZGV4IGYyYjFjOTU4Yjg5OWRmMzA4 ZmEyZmZlZDI2MTY3ZTVlMjQwMTRlOTQuLjFjOGNhNWQ2MGY0MDgxYjQ2NjlhN2UzMzlmYWU2MGNi ODQ2YTRkMGIgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJDb3JlL2FjY2Vzc2liaWxpdHkvQWNjZXNz aWJpbGl0eVRhYmxlQ2VsbC5jcHAKKysrIGIvU291cmNlL1dlYkNvcmUvYWNjZXNzaWJpbGl0eS9B Y2Nlc3NpYmlsaXR5VGFibGVDZWxsLmNwcApAQCAtNzQsNiArNzQsMTAgQEAgQWNjZXNzaWJpbGl0 eU9iamVjdCogQWNjZXNzaWJpbGl0eVRhYmxlQ2VsbDo6cGFyZW50VGFibGUoKSBjb25zdAogewog ICAgIGlmICghbV9yZW5kZXJlciB8fCAhbV9yZW5kZXJlci0+aXNUYWJsZUNlbGwoKSkKICAgICAg ICAgcmV0dXJuIDA7CisKKyAgICAvLyBJZiB0aGUgZG9jdW1lbnQgbm8gbG9uZ2VyIGV4aXN0cywg d2UgbWlnaHQgbm90IGhhdmUgYW4gYXhPYmplY3RDYWNoZS4KKyAgICBpZiAoIWF4T2JqZWN0Q2Fj aGUoKSkKKyAgICAgICAgcmV0dXJuIDA7CiAgICAgCiAgICAgLy8gRG8gbm90IHVzZSBnZXRPckNy ZWF0ZS4gcGFyZW50VGFibGUoKSBjYW4gYmUgY2FsbGVkIHdoaWxlIHRoZSByZW5kZXIgdHJlZSBp cyBiZWluZyBtb2RpZmllZCAKICAgICAvLyBieSBqYXZhc2NyaXB0LCBhbmQgY3JlYXRpbmcgYSB0 YWJsZSBlbGVtZW50IG1heSB0cnkgdG8gYWNjZXNzIHRoZSByZW5kZXIgdHJlZSB3aGlsZSBpbiBh IGJhZCBzdGF0ZS4KQEAgLTkyLDEwICs5NiwxMCBAQCBib29sIEFjY2Vzc2liaWxpdHlUYWJsZUNl bGw6OmlzVGFibGVDZWxsKCkgY29uc3QKICAgICByZXR1cm4gdHJ1ZTsKIH0KICAgICAKLUFjY2Vz c2liaWxpdHlSb2xlIEFjY2Vzc2liaWxpdHlUYWJsZUNlbGw6OnJvbGVWYWx1ZSgpIGNvbnN0CitB Y2Nlc3NpYmlsaXR5Um9sZSBBY2Nlc3NpYmlsaXR5VGFibGVDZWxsOjpkZXRlcm1pbmVBY2Nlc3Np YmlsaXR5Um9sZSgpCiB7CiAgICAgaWYgKCFpc1RhYmxlQ2VsbCgpKQotICAgICAgICByZXR1cm4g QWNjZXNzaWJpbGl0eVJlbmRlck9iamVjdDo6cm9sZVZhbHVlKCk7CisgICAgICAgIHJldHVybiBB Y2Nlc3NpYmlsaXR5UmVuZGVyT2JqZWN0OjpkZXRlcm1pbmVBY2Nlc3NpYmlsaXR5Um9sZSgpOwog ICAgIAogICAgIHJldHVybiBDZWxsUm9sZTsKIH0KZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3Jl L2FjY2Vzc2liaWxpdHkvQWNjZXNzaWJpbGl0eVRhYmxlQ2VsbC5oIGIvU291cmNlL1dlYkNvcmUv YWNjZXNzaWJpbGl0eS9BY2Nlc3NpYmlsaXR5VGFibGVDZWxsLmgKaW5kZXggMDQzMDcxNTU3Zjgw ZjNkYTA3NWJjZDMyMzlmNWE4N2NmMzA0NDY5Ny4uOTM0MTYzNGE5NWIwMTdmZTRlZmUxNThkZDFk OTExOWRmNTc2MDQ4YyAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvYWNjZXNzaWJpbGl0eS9B Y2Nlc3NpYmlsaXR5VGFibGVDZWxsLmgKKysrIGIvU291cmNlL1dlYkNvcmUvYWNjZXNzaWJpbGl0 eS9BY2Nlc3NpYmlsaXR5VGFibGVDZWxsLmgKQEAgLTQyLDcgKzQyLDYgQEAgcHVibGljOgogICAg IHZpcnR1YWwgfkFjY2Vzc2liaWxpdHlUYWJsZUNlbGwoKTsKICAgICAKICAgICB2aXJ0dWFsIGJv b2wgaXNUYWJsZUNlbGwoKSBjb25zdDsKLSAgICB2aXJ0dWFsIEFjY2Vzc2liaWxpdHlSb2xlIHJv bGVWYWx1ZSgpIGNvbnN0OwogICAgIAogICAgIHZpcnR1YWwgYm9vbCBhY2Nlc3NpYmlsaXR5SXNJ Z25vcmVkKCkgY29uc3Q7CiAKQEAgLTU0LDYgKzUzLDcgQEAgcHVibGljOgogcHJvdGVjdGVkOgog ICAgIHZpcnR1YWwgQWNjZXNzaWJpbGl0eU9iamVjdCogcGFyZW50VGFibGUoKSBjb25zdDsKICAg ICBpbnQgbV9yb3dJbmRleDsKKyAgICB2aXJ0dWFsIEFjY2Vzc2liaWxpdHlSb2xlIGRldGVybWlu ZUFjY2Vzc2liaWxpdHlSb2xlKCk7CiAKIHByaXZhdGU6CiAgICAgLy8gSWYgYSB0YWJsZSBjZWxs IGlzIG5vdCBleHBvc2VkIGFzIGEgdGFibGUgY2VsbCwgYSBUSCBlbGVtZW50IGNhbiBzZXJ2ZSBh cyBpdHMgdGl0bGUgVUkgZWxlbWVudC4K 183493 2013-01-18 10:03:52 -0800 2013-01-18 10:59:17 -0800 Patch bug-107261-20130118130050.patch text/plain 3924 jdiggs U3VidmVyc2lvbiBSZXZpc2lvbjogMTQwMTY0CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggYWE0ODYwYTg3OTI2ZDg1 MDRjOWQyZDQxNzdiOWY1YWU3YTJkNTM3Yi4uNGI0ZGQwZjY2YjdiMzhjNTg0OGM2ZTVkZWY1M2Zk ZTliNTk4MmNjZSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDI4IEBACisyMDEzLTAxLTE4ICBKb2Fu bWFyaWUgRGlnZ3MgIDxqZGlnZ3NAaWdhbGlhLmNvbT4KKworICAgICAgICBDcmFzaCBpbiBBY2Nl c3NpYmlsaXR5VGFibGVDZWxsOjpwYXJlbnRUYWJsZSgpCisgICAgICAgIGh0dHBzOi8vYnVncy53 ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xMDcyNjEKKworICAgICAgICBSZXZpZXdlZCBieSBO T0JPRFkgKE9PUFMhKS4KKworICAgICAgICBHZXR0aW5nIHRoZSBwYXJlbnQgdGFibGUgaW4gb3Jk ZXIgdG8gZ2V0IHRoZSByb2xlIHZhbHVlIHNob3VsZCBub3QgYmUKKyAgICAgICAgZG9uZSB3aGVu IG9iamVjdHMgYXJlIGJlaW5nIGRlc3Ryb3llZC4gQWxzbywgaXQgZG9lcyBub3Qgc2VlbSBzYWZl IHRvCisgICAgICAgIGFzc3VtZSB3ZSBoYXZlIGFuIEFYT2JqZWN0Q2FjaGUuCisKKyAgICAgICAg TW92aW5nIHRoZSBsb2dpYyBmcm9tIHJvbGVWYWx1ZSgpIHRvIGRldGVybWluZUFjY2Vzc2liaWxp dHlSb2xlKCkgaGFzCisgICAgICAgIHRoZSBzaWRlIGVmZmVjdCBvZiBub3QgYmVpbmcgYWJsZSB0 byB2ZXJpZnkgdGhlIGNlbGwgaXMgaW4gYW4gQVhUYWJsZQorICAgICAgICB3aGVuIHRoYXQgQVhU YWJsZSBoYXMgbm90IHlldCBiZWVuIGNyZWF0ZWQuIFRoZXJlZm9yZSBpc1RhYmxlQ2VsbCgpCisg ICAgICAgIHNob3VsZCBsb29rIHRvIHNlZSBpZiBpdCBpcyB0aGUgZGVzY2VuZGFudCBvZiBhbiBB WFJvdy4KKworICAgICAgICBObyBuZXcgdGVzdHMgYXMgdGhpcyBmdW5jdGlvbmFsaXR5IGlzIGFs cmVhZHkgY292ZXJlZCBieSBvdGhlciB0ZXN0cy4KKworICAgICAgICAqIGFjY2Vzc2liaWxpdHkv QWNjZXNzaWJpbGl0eVRhYmxlQ2VsbC5jcHA6CisgICAgICAgIChXZWJDb3JlOjpBY2Nlc3NpYmls aXR5VGFibGVDZWxsOjpwYXJlbnRUYWJsZSk6CisgICAgICAgIChXZWJDb3JlOjpBY2Nlc3NpYmls aXR5VGFibGVDZWxsOjppc1RhYmxlQ2VsbCk6CisgICAgICAgIChXZWJDb3JlOjpBY2Nlc3NpYmls aXR5VGFibGVDZWxsOjpkZXRlcm1pbmVBY2Nlc3NpYmlsaXR5Um9sZSk6CisgICAgICAgICogYWNj ZXNzaWJpbGl0eS9BY2Nlc3NpYmlsaXR5VGFibGVDZWxsLmg6CisgICAgICAgIChBY2Nlc3NpYmls aXR5VGFibGVDZWxsKToKKwogMjAxMy0wMS0xOCAgSm9lIE1hc29uICA8am1hc29uQHJpbS5jb20+ CiAKICAgICAgICAgW0JsYWNrQmVycnldIE9ubHkgY2xlYXIgY3JlZGVudGlhbHMgd2hlbiBwdXJn ZUNyZWRlbnRpYWxzIGlzIGNhbGxlZApkaWZmIC0tZ2l0IGEvU291cmNlL1dlYkNvcmUvYWNjZXNz aWJpbGl0eS9BY2Nlc3NpYmlsaXR5VGFibGVDZWxsLmNwcCBiL1NvdXJjZS9XZWJDb3JlL2FjY2Vz c2liaWxpdHkvQWNjZXNzaWJpbGl0eVRhYmxlQ2VsbC5jcHAKaW5kZXggZjJiMWM5NThiODk5ZGYz MDhmYTJmZmVkMjYxNjdlNWUyNDAxNGU5NC4uYjMwNDA5YmYyZTVmYWZlNDUyZGRhYjJjMmYyZTA1 YTczMjZkYjg0MSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvYWNjZXNzaWJpbGl0eS9BY2Nl c3NpYmlsaXR5VGFibGVDZWxsLmNwcAorKysgYi9Tb3VyY2UvV2ViQ29yZS9hY2Nlc3NpYmlsaXR5 L0FjY2Vzc2liaWxpdHlUYWJsZUNlbGwuY3BwCkBAIC03NCw2ICs3NCwxMCBAQCBBY2Nlc3NpYmls aXR5T2JqZWN0KiBBY2Nlc3NpYmlsaXR5VGFibGVDZWxsOjpwYXJlbnRUYWJsZSgpIGNvbnN0CiB7 CiAgICAgaWYgKCFtX3JlbmRlcmVyIHx8ICFtX3JlbmRlcmVyLT5pc1RhYmxlQ2VsbCgpKQogICAg ICAgICByZXR1cm4gMDsKKworICAgIC8vIElmIHRoZSBkb2N1bWVudCBubyBsb25nZXIgZXhpc3Rz LCB3ZSBtaWdodCBub3QgaGF2ZSBhbiBheE9iamVjdENhY2hlLgorICAgIGlmICghYXhPYmplY3RD YWNoZSgpKQorICAgICAgICByZXR1cm4gMDsKICAgICAKICAgICAvLyBEbyBub3QgdXNlIGdldE9y Q3JlYXRlLiBwYXJlbnRUYWJsZSgpIGNhbiBiZSBjYWxsZWQgd2hpbGUgdGhlIHJlbmRlciB0cmVl IGlzIGJlaW5nIG1vZGlmaWVkIAogICAgIC8vIGJ5IGphdmFzY3JpcHQsIGFuZCBjcmVhdGluZyBh IHRhYmxlIGVsZW1lbnQgbWF5IHRyeSB0byBhY2Nlc3MgdGhlIHJlbmRlciB0cmVlIHdoaWxlIGlu IGEgYmFkIHN0YXRlLgpAQCAtODUsMTcgKzg5LDE3IEBAIEFjY2Vzc2liaWxpdHlPYmplY3QqIEFj Y2Vzc2liaWxpdHlUYWJsZUNlbGw6OnBhcmVudFRhYmxlKCkgY29uc3QKICAgICAKIGJvb2wgQWNj ZXNzaWJpbGl0eVRhYmxlQ2VsbDo6aXNUYWJsZUNlbGwoKSBjb25zdAogewotICAgIEFjY2Vzc2li aWxpdHlPYmplY3QqIHRhYmxlID0gcGFyZW50VGFibGUoKTsKLSAgICBpZiAoIXRhYmxlIHx8ICF0 YWJsZS0+aXNBY2Nlc3NpYmlsaXR5VGFibGUoKSkKKyAgICBBY2Nlc3NpYmlsaXR5T2JqZWN0KiBw YXJlbnQgPSBwYXJlbnRPYmplY3RVbmlnbm9yZWQoKTsKKyAgICBpZiAoIXBhcmVudCB8fCAhcGFy ZW50LT5pc1RhYmxlUm93KCkpCiAgICAgICAgIHJldHVybiBmYWxzZTsKICAgICAKICAgICByZXR1 cm4gdHJ1ZTsKIH0KICAgICAKLUFjY2Vzc2liaWxpdHlSb2xlIEFjY2Vzc2liaWxpdHlUYWJsZUNl bGw6OnJvbGVWYWx1ZSgpIGNvbnN0CitBY2Nlc3NpYmlsaXR5Um9sZSBBY2Nlc3NpYmlsaXR5VGFi bGVDZWxsOjpkZXRlcm1pbmVBY2Nlc3NpYmlsaXR5Um9sZSgpCiB7CiAgICAgaWYgKCFpc1RhYmxl Q2VsbCgpKQotICAgICAgICByZXR1cm4gQWNjZXNzaWJpbGl0eVJlbmRlck9iamVjdDo6cm9sZVZh bHVlKCk7CisgICAgICAgIHJldHVybiBBY2Nlc3NpYmlsaXR5UmVuZGVyT2JqZWN0OjpkZXRlcm1p bmVBY2Nlc3NpYmlsaXR5Um9sZSgpOwogICAgIAogICAgIHJldHVybiBDZWxsUm9sZTsKIH0KZGlm ZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL2FjY2Vzc2liaWxpdHkvQWNjZXNzaWJpbGl0eVRhYmxl Q2VsbC5oIGIvU291cmNlL1dlYkNvcmUvYWNjZXNzaWJpbGl0eS9BY2Nlc3NpYmlsaXR5VGFibGVD ZWxsLmgKaW5kZXggMDQzMDcxNTU3ZjgwZjNkYTA3NWJjZDMyMzlmNWE4N2NmMzA0NDY5Ny4uOTM0 MTYzNGE5NWIwMTdmZTRlZmUxNThkZDFkOTExOWRmNTc2MDQ4YyAxMDA2NDQKLS0tIGEvU291cmNl L1dlYkNvcmUvYWNjZXNzaWJpbGl0eS9BY2Nlc3NpYmlsaXR5VGFibGVDZWxsLmgKKysrIGIvU291 cmNlL1dlYkNvcmUvYWNjZXNzaWJpbGl0eS9BY2Nlc3NpYmlsaXR5VGFibGVDZWxsLmgKQEAgLTQy LDcgKzQyLDYgQEAgcHVibGljOgogICAgIHZpcnR1YWwgfkFjY2Vzc2liaWxpdHlUYWJsZUNlbGwo KTsKICAgICAKICAgICB2aXJ0dWFsIGJvb2wgaXNUYWJsZUNlbGwoKSBjb25zdDsKLSAgICB2aXJ0 dWFsIEFjY2Vzc2liaWxpdHlSb2xlIHJvbGVWYWx1ZSgpIGNvbnN0OwogICAgIAogICAgIHZpcnR1 YWwgYm9vbCBhY2Nlc3NpYmlsaXR5SXNJZ25vcmVkKCkgY29uc3Q7CiAKQEAgLTU0LDYgKzUzLDcg QEAgcHVibGljOgogcHJvdGVjdGVkOgogICAgIHZpcnR1YWwgQWNjZXNzaWJpbGl0eU9iamVjdCog cGFyZW50VGFibGUoKSBjb25zdDsKICAgICBpbnQgbV9yb3dJbmRleDsKKyAgICB2aXJ0dWFsIEFj Y2Vzc2liaWxpdHlSb2xlIGRldGVybWluZUFjY2Vzc2liaWxpdHlSb2xlKCk7CiAKIHByaXZhdGU6 CiAgICAgLy8gSWYgYSB0YWJsZSBjZWxsIGlzIG5vdCBleHBvc2VkIGFzIGEgdGFibGUgY2VsbCwg YSBUSCBlbGVtZW50IGNhbiBzZXJ2ZSBhcyBpdHMgdGl0bGUgVUkgZWxlbWVudC4K 183509 2013-01-18 10:59:21 -0800 2013-01-21 08:59:07 -0800 Same fix; now with layout test. bug-107261-20130118135620.patch text/plain 6601 jdiggs U3VidmVyc2lvbiBSZXZpc2lvbjogMTQwMTc3CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggMzI3ODhjZTk0ODU3MjRk NGEzYjM2MzBiOGJmZmFmNGQzNDQyNmQ5NS4uZmFkYzE5YTI5MWE1ZDQ1Y2JiNjQ5OWUyMDg1YjQx NDY2NGU3MmU0MiAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDI4IEBACisyMDEzLTAxLTE4ICBKb2Fu bWFyaWUgRGlnZ3MgIDxqZGlnZ3NAaWdhbGlhLmNvbT4KKworICAgICAgICBDcmFzaCBpbiBBY2Nl c3NpYmlsaXR5VGFibGVDZWxsOjpwYXJlbnRUYWJsZSgpCisgICAgICAgIGh0dHBzOi8vYnVncy53 ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xMDcyNjEKKworICAgICAgICBSZXZpZXdlZCBieSBO T0JPRFkgKE9PUFMhKS4KKworICAgICAgICBUZXN0OiBhY2Nlc3NpYmlsaXR5L3RhYmxlLWRlc3Ry b3llZC1jcmFzaC5odG1sCisKKyAgICAgICAgR2V0dGluZyB0aGUgcGFyZW50IHRhYmxlIGluIG9y ZGVyIHRvIGdldCB0aGUgcm9sZSB2YWx1ZSBzaG91bGQgbm90IGJlCisgICAgICAgIGRvbmUgd2hl biBvYmplY3RzIGFyZSBiZWluZyBkZXN0cm95ZWQuIEFsc28sIGl0IGRvZXMgbm90IHNlZW0gc2Fm ZSB0bworICAgICAgICBhc3N1bWUgd2UgaGF2ZSBhbiBBWE9iamVjdENhY2hlLgorCisgICAgICAg IE1vdmluZyB0aGUgbG9naWMgZnJvbSByb2xlVmFsdWUoKSB0byBkZXRlcm1pbmVBY2Nlc3NpYmls aXR5Um9sZSgpIGhhcworICAgICAgICB0aGUgc2lkZSBlZmZlY3Qgb2Ygbm90IGJlaW5nIGFibGUg dG8gdmVyaWZ5IHRoZSBjZWxsIGlzIGluIGFuIEFYVGFibGUKKyAgICAgICAgd2hlbiB0aGF0IEFY VGFibGUgaGFzIG5vdCB5ZXQgYmVlbiBjcmVhdGVkLiBUaGVyZWZvcmUgaXNUYWJsZUNlbGwoKQor ICAgICAgICBzaG91bGQgbG9vayB0byBzZWUgaWYgaXQgaXMgdGhlIGRlc2NlbmRhbnQgb2YgYW4g QVhSb3cuCisKKyAgICAgICAgKiBhY2Nlc3NpYmlsaXR5L0FjY2Vzc2liaWxpdHlUYWJsZUNlbGwu Y3BwOgorICAgICAgICAoV2ViQ29yZTo6QWNjZXNzaWJpbGl0eVRhYmxlQ2VsbDo6cGFyZW50VGFi bGUpOgorICAgICAgICAoV2ViQ29yZTo6QWNjZXNzaWJpbGl0eVRhYmxlQ2VsbDo6aXNUYWJsZUNl bGwpOgorICAgICAgICAoV2ViQ29yZTo6QWNjZXNzaWJpbGl0eVRhYmxlQ2VsbDo6ZGV0ZXJtaW5l QWNjZXNzaWJpbGl0eVJvbGUpOgorICAgICAgICAqIGFjY2Vzc2liaWxpdHkvQWNjZXNzaWJpbGl0 eVRhYmxlQ2VsbC5oOgorICAgICAgICAoQWNjZXNzaWJpbGl0eVRhYmxlQ2VsbCk6CisKIDIwMTMt MDEtMTggIFRlcnJ5IEFuZGVyc29uICA8dGRhbmRlcnNvbkBjaHJvbWl1bS5vcmc+CiAKICAgICAg ICAgU2Nyb2xsIGdlc3R1cmVzIHNob3VsZCBub3QgY3JlYXRlIHdoZWVsIGV2ZW50cwpkaWZmIC0t Z2l0IGEvU291cmNlL1dlYkNvcmUvYWNjZXNzaWJpbGl0eS9BY2Nlc3NpYmlsaXR5VGFibGVDZWxs LmNwcCBiL1NvdXJjZS9XZWJDb3JlL2FjY2Vzc2liaWxpdHkvQWNjZXNzaWJpbGl0eVRhYmxlQ2Vs bC5jcHAKaW5kZXggZjJiMWM5NThiODk5ZGYzMDhmYTJmZmVkMjYxNjdlNWUyNDAxNGU5NC4uYjMw NDA5YmYyZTVmYWZlNDUyZGRhYjJjMmYyZTA1YTczMjZkYjg0MSAxMDA2NDQKLS0tIGEvU291cmNl L1dlYkNvcmUvYWNjZXNzaWJpbGl0eS9BY2Nlc3NpYmlsaXR5VGFibGVDZWxsLmNwcAorKysgYi9T b3VyY2UvV2ViQ29yZS9hY2Nlc3NpYmlsaXR5L0FjY2Vzc2liaWxpdHlUYWJsZUNlbGwuY3BwCkBA IC03NCw2ICs3NCwxMCBAQCBBY2Nlc3NpYmlsaXR5T2JqZWN0KiBBY2Nlc3NpYmlsaXR5VGFibGVD ZWxsOjpwYXJlbnRUYWJsZSgpIGNvbnN0CiB7CiAgICAgaWYgKCFtX3JlbmRlcmVyIHx8ICFtX3Jl bmRlcmVyLT5pc1RhYmxlQ2VsbCgpKQogICAgICAgICByZXR1cm4gMDsKKworICAgIC8vIElmIHRo ZSBkb2N1bWVudCBubyBsb25nZXIgZXhpc3RzLCB3ZSBtaWdodCBub3QgaGF2ZSBhbiBheE9iamVj dENhY2hlLgorICAgIGlmICghYXhPYmplY3RDYWNoZSgpKQorICAgICAgICByZXR1cm4gMDsKICAg ICAKICAgICAvLyBEbyBub3QgdXNlIGdldE9yQ3JlYXRlLiBwYXJlbnRUYWJsZSgpIGNhbiBiZSBj YWxsZWQgd2hpbGUgdGhlIHJlbmRlciB0cmVlIGlzIGJlaW5nIG1vZGlmaWVkIAogICAgIC8vIGJ5 IGphdmFzY3JpcHQsIGFuZCBjcmVhdGluZyBhIHRhYmxlIGVsZW1lbnQgbWF5IHRyeSB0byBhY2Nl c3MgdGhlIHJlbmRlciB0cmVlIHdoaWxlIGluIGEgYmFkIHN0YXRlLgpAQCAtODUsMTcgKzg5LDE3 IEBAIEFjY2Vzc2liaWxpdHlPYmplY3QqIEFjY2Vzc2liaWxpdHlUYWJsZUNlbGw6OnBhcmVudFRh YmxlKCkgY29uc3QKICAgICAKIGJvb2wgQWNjZXNzaWJpbGl0eVRhYmxlQ2VsbDo6aXNUYWJsZUNl bGwoKSBjb25zdAogewotICAgIEFjY2Vzc2liaWxpdHlPYmplY3QqIHRhYmxlID0gcGFyZW50VGFi bGUoKTsKLSAgICBpZiAoIXRhYmxlIHx8ICF0YWJsZS0+aXNBY2Nlc3NpYmlsaXR5VGFibGUoKSkK KyAgICBBY2Nlc3NpYmlsaXR5T2JqZWN0KiBwYXJlbnQgPSBwYXJlbnRPYmplY3RVbmlnbm9yZWQo KTsKKyAgICBpZiAoIXBhcmVudCB8fCAhcGFyZW50LT5pc1RhYmxlUm93KCkpCiAgICAgICAgIHJl dHVybiBmYWxzZTsKICAgICAKICAgICByZXR1cm4gdHJ1ZTsKIH0KICAgICAKLUFjY2Vzc2liaWxp dHlSb2xlIEFjY2Vzc2liaWxpdHlUYWJsZUNlbGw6OnJvbGVWYWx1ZSgpIGNvbnN0CitBY2Nlc3Np YmlsaXR5Um9sZSBBY2Nlc3NpYmlsaXR5VGFibGVDZWxsOjpkZXRlcm1pbmVBY2Nlc3NpYmlsaXR5 Um9sZSgpCiB7CiAgICAgaWYgKCFpc1RhYmxlQ2VsbCgpKQotICAgICAgICByZXR1cm4gQWNjZXNz aWJpbGl0eVJlbmRlck9iamVjdDo6cm9sZVZhbHVlKCk7CisgICAgICAgIHJldHVybiBBY2Nlc3Np YmlsaXR5UmVuZGVyT2JqZWN0OjpkZXRlcm1pbmVBY2Nlc3NpYmlsaXR5Um9sZSgpOwogICAgIAog ICAgIHJldHVybiBDZWxsUm9sZTsKIH0KZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL2FjY2Vz c2liaWxpdHkvQWNjZXNzaWJpbGl0eVRhYmxlQ2VsbC5oIGIvU291cmNlL1dlYkNvcmUvYWNjZXNz aWJpbGl0eS9BY2Nlc3NpYmlsaXR5VGFibGVDZWxsLmgKaW5kZXggMDQzMDcxNTU3ZjgwZjNkYTA3 NWJjZDMyMzlmNWE4N2NmMzA0NDY5Ny4uOTM0MTYzNGE5NWIwMTdmZTRlZmUxNThkZDFkOTExOWRm NTc2MDQ4YyAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvYWNjZXNzaWJpbGl0eS9BY2Nlc3Np YmlsaXR5VGFibGVDZWxsLmgKKysrIGIvU291cmNlL1dlYkNvcmUvYWNjZXNzaWJpbGl0eS9BY2Nl c3NpYmlsaXR5VGFibGVDZWxsLmgKQEAgLTQyLDcgKzQyLDYgQEAgcHVibGljOgogICAgIHZpcnR1 YWwgfkFjY2Vzc2liaWxpdHlUYWJsZUNlbGwoKTsKICAgICAKICAgICB2aXJ0dWFsIGJvb2wgaXNU YWJsZUNlbGwoKSBjb25zdDsKLSAgICB2aXJ0dWFsIEFjY2Vzc2liaWxpdHlSb2xlIHJvbGVWYWx1 ZSgpIGNvbnN0OwogICAgIAogICAgIHZpcnR1YWwgYm9vbCBhY2Nlc3NpYmlsaXR5SXNJZ25vcmVk KCkgY29uc3Q7CiAKQEAgLTU0LDYgKzUzLDcgQEAgcHVibGljOgogcHJvdGVjdGVkOgogICAgIHZp cnR1YWwgQWNjZXNzaWJpbGl0eU9iamVjdCogcGFyZW50VGFibGUoKSBjb25zdDsKICAgICBpbnQg bV9yb3dJbmRleDsKKyAgICB2aXJ0dWFsIEFjY2Vzc2liaWxpdHlSb2xlIGRldGVybWluZUFjY2Vz c2liaWxpdHlSb2xlKCk7CiAKIHByaXZhdGU6CiAgICAgLy8gSWYgYSB0YWJsZSBjZWxsIGlzIG5v dCBleHBvc2VkIGFzIGEgdGFibGUgY2VsbCwgYSBUSCBlbGVtZW50IGNhbiBzZXJ2ZSBhcyBpdHMg dGl0bGUgVUkgZWxlbWVudC4KZGlmZiAtLWdpdCBhL0xheW91dFRlc3RzL0NoYW5nZUxvZyBiL0xh eW91dFRlc3RzL0NoYW5nZUxvZwppbmRleCBjZmIwNGFlNmQwZGFkM2U2MDY5YjYwMWRmMTRhMTY0 NWM2NzVkYTMxLi5mMTlhOTk0NTJmZGY3OTdmMDlhNDJmNmM2MWZjZDdlODk0NGU5ZGE1IDEwMDY0 NAotLS0gYS9MYXlvdXRUZXN0cy9DaGFuZ2VMb2cKKysrIGIvTGF5b3V0VGVzdHMvQ2hhbmdlTG9n CkBAIC0xLDMgKzEsMTcgQEAKKzIwMTMtMDEtMTggIEpvYW5tYXJpZSBEaWdncyAgPGpkaWdnc0Bp Z2FsaWEuY29tPgorCisgICAgICAgIENyYXNoIGluIEFjY2Vzc2liaWxpdHlUYWJsZUNlbGw6OnBh cmVudFRhYmxlKCkKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dp P2lkPTEwNzI2MQorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAg ICAgIEdldHRpbmcgdGhlIHBhcmVudCB0YWJsZSBpbiBvcmRlciB0byBnZXQgdGhlIHJvbGUgdmFs dWUgc2hvdWxkIG5vdCBiZQorICAgICAgICBkb25lIHdoZW4gb2JqZWN0cyBhcmUgYmVpbmcgZGVz dHJveWVkLiBBbHNvLCBpdCBkb2VzIG5vdCBzZWVtIHNhZmUgdG8KKyAgICAgICAgYXNzdW1lIHdl IGhhdmUgYW4gQVhPYmplY3RDYWNoZS4KKworICAgICAgICAqIGFjY2Vzc2liaWxpdHkvdGFibGUt ZGVzdHJveWVkLWNyYXNoLWV4cGVjdGVkLnR4dDogQWRkZWQuCisgICAgICAgICogYWNjZXNzaWJp bGl0eS90YWJsZS1kZXN0cm95ZWQtY3Jhc2guaHRtbDogQWRkZWQuCisKIDIwMTMtMDEtMTggIFRl cnJ5IEFuZGVyc29uICA8dGRhbmRlcnNvbkBjaHJvbWl1bS5vcmc+CiAKICAgICAgICAgU2Nyb2xs IGdlc3R1cmVzIHNob3VsZCBub3QgY3JlYXRlIHdoZWVsIGV2ZW50cwpkaWZmIC0tZ2l0IGEvTGF5 b3V0VGVzdHMvYWNjZXNzaWJpbGl0eS90YWJsZS1kZXN0cm95ZWQtY3Jhc2gtZXhwZWN0ZWQudHh0 IGIvTGF5b3V0VGVzdHMvYWNjZXNzaWJpbGl0eS90YWJsZS1kZXN0cm95ZWQtY3Jhc2gtZXhwZWN0 ZWQudHh0Cm5ldyBmaWxlIG1vZGUgMTAwNjQ0CmluZGV4IDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAw MDAwMDAwMDAwMDAwMDAwMDAuLjlhYTBhZmQ4OTExN2MzNjYwNDg5MmI4NzBkMDZlMmNjN2QyOGVk YzYKLS0tIC9kZXYvbnVsbAorKysgYi9MYXlvdXRUZXN0cy9hY2Nlc3NpYmlsaXR5L3RhYmxlLWRl c3Ryb3llZC1jcmFzaC1leHBlY3RlZC50eHQKQEAgLTAsMCArMSw5IEBACitUaGlzIHRlc3RzIHRo YXQgd2UgZG8gbm90IGNyYXNoIHdoZW4gYSB0YWJsZSBpcyBkZXN0cm95ZWQuCisKK09uIHN1Y2Nl c3MsIHlvdSB3aWxsIHNlZSBhIHNlcmllcyBvZiAiUEFTUyIgbWVzc2FnZXMsIGZvbGxvd2VkIGJ5 ICJURVNUIENPTVBMRVRFIi4KKworCitQQVNTIHN1Y2Nlc3NmdWxseVBhcnNlZCBpcyB0cnVlCisK K1RFU1QgQ09NUExFVEUKKwpkaWZmIC0tZ2l0IGEvTGF5b3V0VGVzdHMvYWNjZXNzaWJpbGl0eS90 YWJsZS1kZXN0cm95ZWQtY3Jhc2guaHRtbCBiL0xheW91dFRlc3RzL2FjY2Vzc2liaWxpdHkvdGFi bGUtZGVzdHJveWVkLWNyYXNoLmh0bWwKbmV3IGZpbGUgbW9kZSAxMDA2NDQKaW5kZXggMDAwMDAw MDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMC4uYTIyZDI4YzI2M2EyZTkzZDE1MWZi MDVjMWJlOWZlZDJjMWQ2OGE5NAotLS0gL2Rldi9udWxsCisrKyBiL0xheW91dFRlc3RzL2FjY2Vz c2liaWxpdHkvdGFibGUtZGVzdHJveWVkLWNyYXNoLmh0bWwKQEAgLTAsMCArMSwzNiBAQAorPCFE T0NUWVBFIEhUTUwgUFVCTElDICItLy9JRVRGLy9EVEQgSFRNTC8vRU4iPgorPGh0bWw+Cis8aGVh ZD4KKzxzY3JpcHQ+CisgICAgZnVuY3Rpb24gY3JlYXRlQVhPYmplY3RzKGFjY2Vzc2liaWxpdHlP YmplY3QpIHsKKyAgICAgICAgdmFyIGNvdW50ID0gYWNjZXNzaWJpbGl0eU9iamVjdC5jaGlsZHJl bkNvdW50OworICAgICAgICBmb3IgKHZhciBpID0gMDsgaSA8IGNvdW50OyArK2kpCisgICAgICAg ICAgICBjcmVhdGVBWE9iamVjdHMoYWNjZXNzaWJpbGl0eU9iamVjdC5jaGlsZEF0SW5kZXgoaSkp OworICAgIH0KKzwvc2NyaXB0PgorPHNjcmlwdCBzcmM9Ii4uL2Zhc3QvanMvcmVzb3VyY2VzL2pz LXRlc3QtcHJlLmpzIj48L3NjcmlwdD4KKzwvaGVhZD4KKzxib2R5IGlkPSJib2R5Ij4KKzx0YWJs ZSBpZD0idGFibGUiPgorICA8dHIgaWQ9InJvdyI+PHRkIGlkPSJjZWxsIj5mb288L3RkPjwvdHI+ CisgIDx0cj48dGQ+YmFyPC90ZD48L3RyPgorPC90YWJsZT4KKzxzY3JpcHQ+CisKKyAgICBkZXNj cmlwdGlvbigiVGhpcyB0ZXN0cyB0aGF0IHdlIGRvIG5vdCBjcmFzaCB3aGVuIGEgdGFibGUgaXMg ZGVzdHJveWVkLiIpOworCisgICAgaWYgKHdpbmRvdy5hY2Nlc3NpYmlsaXR5Q29udHJvbGxlcikg eworICAgICAgICBkb2N1bWVudC5ib2R5LmZvY3VzKCk7CisgICAgICAgIHZhciBib2R5ID0gYWNj ZXNzaWJpbGl0eUNvbnRyb2xsZXIuZm9jdXNlZEVsZW1lbnQ7CisgICAgICAgIGNyZWF0ZUFYT2Jq ZWN0cyhib2R5KTsKKyAgICB9CisKKyAgICB2YXIgZWxlbWVudCA9IGRvY3VtZW50LmdldEVsZW1l bnRCeUlkKCJ0YWJsZSIpOworICAgIGVsZW1lbnQucGFyZW50Tm9kZS5yZW1vdmVDaGlsZChlbGVt ZW50KTsKKworPC9zY3JpcHQ+CisKKzxzY3JpcHQgc3JjPSIuLi9mYXN0L2pzL3Jlc291cmNlcy9q cy10ZXN0LXBvc3QuanMiPjwvc2NyaXB0PgorPC9ib2R5PgorPC9odG1sPgorCg==