<?xml version="1.0" encoding="UTF-8" standalone="yes" ?>
<!DOCTYPE bugzilla SYSTEM "https://bugs.webkit.org/page.cgi?id=bugzilla.dtd">

<bugzilla version="5.0.4.1"
          urlbase="https://bugs.webkit.org/"
          
          maintainer="admin@webkit.org"
>

    <bug>
          <bug_id>107132</bug_id>
          
          <creation_ts>2013-01-17 08:29:39 -0800</creation_ts>
          <short_desc>[Chromium] Give webkit_support a chance to reset state between layout test runs</short_desc>
          <delta_ts>2013-02-14 08:41:55 -0800</delta_ts>
          <reporter_accessible>1</reporter_accessible>
          <cclist_accessible>1</cclist_accessible>
          <classification_id>1</classification_id>
          <classification>Unclassified</classification>
          <product>WebKit</product>
          <component>Tools / Tests</component>
          <version>528+ (Nightly build)</version>
          <rep_platform>All</rep_platform>
          <op_sys>All</op_sys>
          <bug_status>RESOLVED</bug_status>
          <resolution>WONTFIX</resolution>
          
          
          <bug_file_loc></bug_file_loc>
          <status_whiteboard></status_whiteboard>
          <keywords></keywords>
          <priority>P2</priority>
          <bug_severity>Normal</bug_severity>
          <target_milestone>---</target_milestone>
          <dependson>107916</dependson>
          <blocked>82948</blocked>
    
    <blocked>106457</blocked>
          <everconfirmed>1</everconfirmed>
          <reporter name="Darin Fisher (:fishd, Google)">fishd</reporter>
          <assigned_to name="Mark Pilgrim (Google)">pilgrim</assigned_to>
          <cc>abarth</cc>
    
    <cc>dglazkov</cc>
    
    <cc>fishd</cc>
    
    <cc>jsbell</cc>
    
    <cc>peter+ews</cc>
    
    <cc>pilgrim</cc>
    
    <cc>webkit.review.bot</cc>
          

      

      

      

          <comment_sort_order>oldest_to_newest</comment_sort_order>  
          <long_desc isprivate="0" >
    <commentid>809351</commentid>
    <comment_count>0</comment_count>
    <who name="Darin Fisher (:fishd, Google)">fishd</who>
    <bug_when>2013-01-17 08:29:39 -0800</bug_when>
    <thetext>[Chromium] Give webkit_support a chance to reset state between layout test runs

We currently only have need for this on OS(ANDROID), but now it would be useful
to have a hook for resetting state on all platforms.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>809352</commentid>
    <comment_count>1</comment_count>
    <who name="Darin Fisher (:fishd, Google)">fishd</who>
    <bug_when>2013-01-17 08:30:44 -0800</bug_when>
    <thetext>Corresponding Chromium patch:
https://codereview.chromium.org/11946027/</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>809356</commentid>
    <comment_count>2</comment_count>
      <attachid>183195</attachid>
    <who name="Darin Fisher (:fishd, Google)">fishd</who>
    <bug_when>2013-01-17 08:34:12 -0800</bug_when>
    <thetext>Created attachment 183195
v1 patch

The Chromium side of this change needs to land first.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>809357</commentid>
    <comment_count>3</comment_count>
    <who name="Darin Fisher (:fishd, Google)">fishd</who>
    <bug_when>2013-01-17 08:35:14 -0800</bug_when>
    <thetext>(And, I need to also do a DEPS roll.)</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>809360</commentid>
    <comment_count>4</comment_count>
      <attachid>183195</attachid>
    <who name="WebKit Review Bot">webkit.review.bot</who>
    <bug_when>2013-01-17 08:36:36 -0800</bug_when>
    <thetext>Comment on attachment 183195
v1 patch

Attachment 183195 did not pass chromium-ews (chromium-xvfb):
Output: http://queues.webkit.org/results/15940134</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>809365</commentid>
    <comment_count>5</comment_count>
      <attachid>183195</attachid>
    <who name="Peter Beverloo (cr-android ews)">peter+ews</who>
    <bug_when>2013-01-17 08:41:40 -0800</bug_when>
    <thetext>Comment on attachment 183195
v1 patch

Attachment 183195 did not pass cr-android-ews (chromium-android):
Output: http://queues.webkit.org/results/15941066</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>814967</commentid>
    <comment_count>6</comment_count>
      <attachid>184382</attachid>
    <who name="Mark Pilgrim (Google)">pilgrim</who>
    <bug_when>2013-01-23 19:20:48 -0800</bug_when>
    <thetext>Created attachment 184382
Patch</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>814968</commentid>
    <comment_count>7</comment_count>
      <attachid>184382</attachid>
    <who name="Mark Pilgrim (Google)">pilgrim</who>
    <bug_when>2013-01-23 19:21:30 -0800</bug_when>
    <thetext>Comment on attachment 184382
Patch

Chromium patch has landed and DEPS have been rolled. Resubmitting identical patch against ToT.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>815064</commentid>
    <comment_count>8</comment_count>
      <attachid>184382</attachid>
    <who name="WebKit Review Bot">webkit.review.bot</who>
    <bug_when>2013-01-23 21:53:39 -0800</bug_when>
    <thetext>Comment on attachment 184382
Patch

Clearing flags on attachment: 184382

Committed r140653: &lt;http://trac.webkit.org/changeset/140653&gt;</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>815065</commentid>
    <comment_count>9</comment_count>
    <who name="WebKit Review Bot">webkit.review.bot</who>
    <bug_when>2013-01-23 21:53:42 -0800</bug_when>
    <thetext>All reviewed patches have been landed.  Closing bug.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>816233</commentid>
    <comment_count>10</comment_count>
    <who name="WebKit Review Bot">webkit.review.bot</who>
    <bug_when>2013-01-24 22:28:08 -0800</bug_when>
    <thetext>Re-opened since this is blocked by bug 107916</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>833108</commentid>
    <comment_count>11</comment_count>
    <who name="Mark Pilgrim (Google)">pilgrim</who>
    <bug_when>2013-02-14 08:41:55 -0800</bug_when>
    <thetext>Made unnecessary by taking a different approach in http://src.chromium.org/viewvc/chrome?view=rev&amp;revision=181641</thetext>
  </long_desc>
      
          <attachment
              isobsolete="1"
              ispatch="1"
              isprivate="0"
          >
            <attachid>183195</attachid>
            <date>2013-01-17 08:34:12 -0800</date>
            <delta_ts>2013-01-23 19:20:46 -0800</delta_ts>
            <desc>v1 patch</desc>
            <filename>wk_patch_1.txt</filename>
            <type>text/plain</type>
            <size>1536</size>
            <attacher name="Darin Fisher (:fishd, Google)">fishd</attacher>
            
              <data encoding="base64">SW5kZXg6IFRvb2xzL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09
PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBUb29scy9DaGFuZ2VMb2cJKHJl
dmlzaW9uIDEzOTk4MCkKKysrIFRvb2xzL0NoYW5nZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwz
ICsxLDEzIEBACisyMDEzLTAxLTE3ICBEYXJpbiBGaXNoZXIgIDxkYXJpbkBjaHJvbWl1bS5vcmc+
CisKKyAgICAgICAgR2l2ZSB3ZWJraXRfc3VwcG9ydCBhIGNoYW5jZSB0byByZXNldCBzdGF0ZSBi
ZXR3ZWVuIGxheW91dCB0ZXN0IHJ1bnMKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcv
c2hvd19idWcuY2dpP2lkPTEwNzEzMgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09Q
UyEpLgorCisgICAgICAgICogRHVtcFJlbmRlclRyZWUvY2hyb21pdW0vVGVzdFNoZWxsLmNwcDoK
KyAgICAgICAgKFRlc3RTaGVsbDo6cmVzZXRUZXN0Q29udHJvbGxlcik6IENhbGwgd2Via2l0X3N1
cHBvcnQ6OlJlc2V0VGVzdEVudmlyb25tZW50KCkKKwogMjAxMy0wMS0xNyAgWmFuIERvYmVyc2Vr
ICA8emRvYmVyc2VrQGlnYWxpYS5jb20+CiAKICAgICAgICAgW0dUS11bRUZMXSBOV1JUIHNob3Vs
ZCBjaGVjayB0aGF0IFh2ZmIgaXMgaW5zdGFsbGVkCkluZGV4OiBUb29scy9EdW1wUmVuZGVyVHJl
ZS9jaHJvbWl1bS9UZXN0U2hlbGwuY3BwCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09
PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFRvb2xzL0R1bXBSZW5kZXJU
cmVlL2Nocm9taXVtL1Rlc3RTaGVsbC5jcHAJKHJldmlzaW9uIDEzOTk4MCkKKysrIFRvb2xzL0R1
bXBSZW5kZXJUcmVlL2Nocm9taXVtL1Rlc3RTaGVsbC5jcHAJKHdvcmtpbmcgY29weSkKQEAgLTMz
Miw5ICszMzIsNiBAQCB2b2lkIFRlc3RTaGVsbDo6cmVzZXRUZXN0Q29udHJvbGxlcigpCiAjaWYg
RU5BQkxFKE5PVElGSUNBVElPTlMpIHx8IEVOQUJMRShMRUdBQ1lfTk9USUZJQ0FUSU9OUykKICAg
ICBtX25vdGlmaWNhdGlvblByZXNlbnRlci0+cmVzZXQoKTsKICNlbmRpZgotI2lmIE9TKEFORFJP
SUQpCi0gICAgd2Via2l0X3N1cHBvcnQ6OlJlbGVhc2VNZWRpYVJlc291cmNlcygpOwotI2VuZGlm
CiAgICAgbV9kcnREZXZUb29sc0FnZW50LT5yZXNldCgpOwogICAgIGlmIChtX2RydERldlRvb2xz
Q2xpZW50KQogICAgICAgICBtX2RydERldlRvb2xzQ2xpZW50LT5yZXNldCgpOwpAQCAtMzQ0LDYg
KzM0MSw4IEBAIHZvaWQgVGVzdFNoZWxsOjpyZXNldFRlc3RDb250cm9sbGVyKCkKICAgICB3ZWJW
aWV3KCktPm1haW5GcmFtZSgpLT5jbGVhck9wZW5lcigpOwogICAgIFdlYlRlc3RpbmdTdXBwb3J0
OjpyZXNldEludGVybmFsc09iamVjdCh3ZWJWaWV3KCktPm1haW5GcmFtZSgpKTsKICAgICBXZWJD
YWNoZTo6Y2xlYXIoKTsKKworICAgIHdlYmtpdF9zdXBwb3J0OjpSZXNldFRlc3RFbnZpcm9ubWVu
dCgpOwogfQogCiB2b2lkIFRlc3RTaGVsbDo6bG9hZFVSTChjb25zdCBXZWJVUkwmIHVybCkK
</data>

          </attachment>
          <attachment
              isobsolete="0"
              ispatch="1"
              isprivate="0"
          >
            <attachid>184382</attachid>
            <date>2013-01-23 19:20:48 -0800</date>
            <delta_ts>2013-01-23 21:53:38 -0800</delta_ts>
            <desc>Patch</desc>
            <filename>bug-107132-20130123221740.patch</filename>
            <type>text/plain</type>
            <size>1781</size>
            <attacher name="Mark Pilgrim (Google)">pilgrim</attacher>
            
              <data encoding="base64">SW5kZXg6IFRvb2xzL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09
PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBUb29scy9DaGFuZ2VMb2cJKHJl
dmlzaW9uIDE0MDYzNCkKKysrIFRvb2xzL0NoYW5nZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwz
ICsxLDE3IEBACisyMDEzLTAxLTIzICBNYXJrIFBpbGdyaW0gIDxwaWxncmltQGNocm9taXVtLm9y
Zz4KKworICAgICAgICBbQ2hyb21pdW1dIEdpdmUgd2Via2l0X3N1cHBvcnQgYSBjaGFuY2UgdG8g
cmVzZXQgc3RhdGUgYmV0d2VlbiBsYXlvdXQgdGVzdCBydW5zCisgICAgICAgIGh0dHBzOi8vYnVn
cy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xMDcxMzIKKworICAgICAgICBSZXZpZXdlZCBi
eSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBXZSBjdXJyZW50bHkgb25seSBoYXZlIG5lZWQg
Zm9yIHRoaXMgb24gT1MoQU5EUk9JRCksIGJ1dCBub3cgaXQKKyAgICAgICAgd291bGQgYmUgdXNl
ZnVsIHRvIGhhdmUgYSBob29rIGZvciByZXNldHRpbmcgc3RhdGUgb24gYWxsCisgICAgICAgIHBs
YXRmb3Jtcy4gV2lsbCBzb29uIGJlIHVzaW5nIHRoaXMgZm9yIElEQkZhY3RvcnkgaW5pdGlhbGl6
YXRpb24uCisKKyAgICAgICAgKiBEdW1wUmVuZGVyVHJlZS9jaHJvbWl1bS9UZXN0U2hlbGwuY3Bw
OgorICAgICAgICAoVGVzdFNoZWxsOjpyZXNldFRlc3RDb250cm9sbGVyKTogQ2FsbCB3ZWJraXRf
c3VwcG9ydDo6UmVzZXRUZXN0RW52aXJvbm1lbnQoKQorCiAyMDEzLTAxLTIzICBNYXJrIFBpbGdy
aW0gIDxwaWxncmltQGNocm9taXVtLm9yZz4KIAogICAgICAgICBbQ2hyb21pdW1dIFJlbW92ZSB1
bnVzZWQgaGVhZGVyIGZpbGVzIGluIGNocm9taXVtL3B1YmxpYy9wbGF0Zm9ybS8KSW5kZXg6IFRv
b2xzL0R1bXBSZW5kZXJUcmVlL2Nocm9taXVtL1Rlc3RTaGVsbC5jcHAKPT09PT09PT09PT09PT09
PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0g
VG9vbHMvRHVtcFJlbmRlclRyZWUvY2hyb21pdW0vVGVzdFNoZWxsLmNwcAkocmV2aXNpb24gMTQw
NjM0KQorKysgVG9vbHMvRHVtcFJlbmRlclRyZWUvY2hyb21pdW0vVGVzdFNoZWxsLmNwcAkod29y
a2luZyBjb3B5KQpAQCAtMzM0LDkgKzMzNCw2IEBAIHZvaWQgVGVzdFNoZWxsOjpyZXNldFRlc3RD
b250cm9sbGVyKCkKICNpZiBFTkFCTEUoTk9USUZJQ0FUSU9OUykgfHwgRU5BQkxFKExFR0FDWV9O
T1RJRklDQVRJT05TKQogICAgIG1fbm90aWZpY2F0aW9uUHJlc2VudGVyLT5yZXNldCgpOwogI2Vu
ZGlmCi0jaWYgT1MoQU5EUk9JRCkKLSAgICB3ZWJraXRfc3VwcG9ydDo6UmVsZWFzZU1lZGlhUmVz
b3VyY2VzKCk7Ci0jZW5kaWYKICAgICBtX2RydERldlRvb2xzQWdlbnQtPnJlc2V0KCk7CiAgICAg
aWYgKG1fZHJ0RGV2VG9vbHNDbGllbnQpCiAgICAgICAgIG1fZHJ0RGV2VG9vbHNDbGllbnQtPnJl
c2V0KCk7CkBAIC0zNDYsNiArMzQzLDggQEAgdm9pZCBUZXN0U2hlbGw6OnJlc2V0VGVzdENvbnRy
b2xsZXIoKQogICAgIHdlYlZpZXcoKS0+bWFpbkZyYW1lKCktPmNsZWFyT3BlbmVyKCk7CiAgICAg
V2ViVGVzdGluZ1N1cHBvcnQ6OnJlc2V0SW50ZXJuYWxzT2JqZWN0KHdlYlZpZXcoKS0+bWFpbkZy
YW1lKCkpOwogICAgIFdlYkNhY2hlOjpjbGVhcigpOworCisgICAgd2Via2l0X3N1cHBvcnQ6OlJl
c2V0VGVzdEVudmlyb25tZW50KCk7CiB9CiAKIHZvaWQgVGVzdFNoZWxsOjpsb2FkVVJMKGNvbnN0
IFdlYlVSTCYgdXJsKQo=
</data>

          </attachment>
      

    </bug>

</bugzilla>