107084 2013-01-16 19:06:34 -0800 Coordinated Graphics: Remove redundant behaviors in LayerTreeRenderer. 2013-01-17 14:56:37 -0800 1 1 1 Unclassified WebKit Layout and Rendering 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 103854 1 dongseong.hwang dongseong.hwang noam webkit.review.bot zeno oldest_to_newest 808979 0 dongseong.hwang 2013-01-16 19:06:34 -0800 There are two changes. 1. It is redundant to call GraphicsLayer::removeFromParent() or GraphicsLayer::removeAllChildren() before deleting GraphicsLayer, because the destructor of GraphicsLayerTextureMapper does those. 2. LayerTreeRenderer::setRootLayerID() does not need to remove all children of rootLayer because this method can be called only once. 808981 1 183096 dongseong.hwang 2013-01-16 19:08:55 -0800 Created attachment 183096 Patch 809126 2 183096 noam 2013-01-16 23:41:21 -0800 Comment on attachment 183096 Patch I would consider this trivial; Allowing myself to r+. 809833 3 183096 webkit.review.bot 2013-01-17 14:56:33 -0800 Comment on attachment 183096 Patch Clearing flags on attachment: 183096 Committed r140053: <http://trac.webkit.org/changeset/140053> 809834 4 webkit.review.bot 2013-01-17 14:56:37 -0800 All reviewed patches have been landed. Closing bug. 183096 2013-01-16 19:08:55 -0800 2013-01-17 14:56:33 -0800 Patch bug-107084-20130117120552.patch text/plain 2675 dongseong.hwang U3VidmVyc2lvbiBSZXZpc2lvbjogMTM5ODIxCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0Mi9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViS2l0Mi9DaGFuZ2VMb2cKaW5kZXggMTNkYjcxNzljMTYwODc1 NDYyYTgwYjAwYzM1NDg4YzUyOWE4NDhiOS4uMGVlZWU0NzRkMTExNzlmY2Y5MmQ0MWRiZWRkZGVl M2MyZTNjNmI5YyAxMDA2NDQKLS0tIGEvU291cmNlL1dlYktpdDIvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJLaXQyL0NoYW5nZUxvZwpAQCAtMSw1ICsxLDI0IEBACiAyMDEzLTAxLTE2ICBIdWFu ZyBEb25nc3VuZyAgPGx1eHRlbGxhQGNvbXBhbnkxMDAubmV0PgogCisgICAgICAgIENvb3JkaW5h dGVkIEdyYXBoaWNzOiBSZW1vdmUgcmVkdW5kYW50IGJlaGF2aW9ycyBpbiBMYXllclRyZWVSZW5k ZXJlci4KKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTEw NzA4NAorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIFRo ZXJlIGFyZSB0d28gY2hhbmdlcy4KKyAgICAgICAgMS4gSXQgaXMgcmVkdW5kYW50IHRvIGNhbGwg R3JhcGhpY3NMYXllcjo6cmVtb3ZlRnJvbVBhcmVudCgpIG9yCisgICAgICAgIEdyYXBoaWNzTGF5 ZXI6OnJlbW92ZUFsbENoaWxkcmVuKCkgYmVmb3JlIGRlbGV0aW5nIEdyYXBoaWNzTGF5ZXIsIGJl Y2F1c2UgdGhlCisgICAgICAgIGRlc3RydWN0b3Igb2YgR3JhcGhpY3NMYXllclRleHR1cmVNYXBw ZXIgcmVtb3ZlcyBhIHBhcmVudCBhbmQgYWxsIGNoaWxkcmVuLgorICAgICAgICAyLiBMYXllclRy ZWVSZW5kZXJlcjo6c2V0Um9vdExheWVySUQoKSBkb2VzIG5vdCBuZWVkIHRvIHJlbW92ZSBhbGwg Y2hpbGRyZW4gb2YKKyAgICAgICAgcm9vdExheWVyIGJlY2F1c2UgdGhpcyBtZXRob2QgY2FuIGJl IGNhbGxlZCBvbmx5IG9uY2UuCisKKyAgICAgICAgKiBVSVByb2Nlc3MvQ29vcmRpbmF0ZWRHcmFw aGljcy9MYXllclRyZWVSZW5kZXJlci5jcHA6CisgICAgICAgIChXZWJLaXQ6OkxheWVyVHJlZVJl bmRlcmVyOjpkZWxldGVMYXllcik6CisgICAgICAgIChXZWJLaXQ6OkxheWVyVHJlZVJlbmRlcmVy OjpzZXRSb290TGF5ZXJJRCk6CisgICAgICAgIChXZWJLaXQ6OkxheWVyVHJlZVJlbmRlcmVyOjpw dXJnZUdMUmVzb3VyY2VzKToKKworMjAxMy0wMS0xNiAgSHVhbmcgRG9uZ3N1bmcgIDxsdXh0ZWxs YUBjb21wYW55MTAwLm5ldD4KKwogICAgICAgICBbVGV4bWFwXSBSZWZhY3RvciBjb2RlIHJlbGF0 ZWQgdG8gZGVidWcgYm9yZGVyIGFuZCByZXBhaW50IGNvdW50LgogICAgICAgICBodHRwczovL2J1 Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTA1Nzg3CiAKZGlmZiAtLWdpdCBhL1NvdXJj ZS9XZWJLaXQyL1VJUHJvY2Vzcy9Db29yZGluYXRlZEdyYXBoaWNzL0xheWVyVHJlZVJlbmRlcmVy LmNwcCBiL1NvdXJjZS9XZWJLaXQyL1VJUHJvY2Vzcy9Db29yZGluYXRlZEdyYXBoaWNzL0xheWVy VHJlZVJlbmRlcmVyLmNwcAppbmRleCBhOWY1MTgwZDU2YjZmNWU1MGFhZjQ5NWY1NGE2YjcwMDdm N2JiZmZkLi40NWNjODEzNTk3NmEzYWQ0MmNjNTgxODRlZWYxZWE0ZjRmYWMwY2U5IDEwMDY0NAot LS0gYS9Tb3VyY2UvV2ViS2l0Mi9VSVByb2Nlc3MvQ29vcmRpbmF0ZWRHcmFwaGljcy9MYXllclRy ZWVSZW5kZXJlci5jcHAKKysrIGIvU291cmNlL1dlYktpdDIvVUlQcm9jZXNzL0Nvb3JkaW5hdGVk R3JhcGhpY3MvTGF5ZXJUcmVlUmVuZGVyZXIuY3BwCkBAIC0zNzQsNyArMzc0LDYgQEAgdm9pZCBM YXllclRyZWVSZW5kZXJlcjo6ZGVsZXRlTGF5ZXIoQ29vcmRpbmF0ZWRMYXllcklEIGxheWVySUQp CiAgICAgT3duUHRyPEdyYXBoaWNzTGF5ZXI+IGxheWVyID0gbV9sYXllcnMudGFrZShsYXllcklE KTsKICAgICBBU1NFUlQobGF5ZXIpOwogCi0gICAgbGF5ZXItPnJlbW92ZUZyb21QYXJlbnQoKTsK ICAgICBtX3BlbmRpbmdTeW5jQmFja2luZ1N0b3Jlcy5yZW1vdmUodG9UZXh0dXJlTWFwcGVyTGF5 ZXIobGF5ZXIuZ2V0KCkpKTsKICAgICBtX2ZpeGVkTGF5ZXJzLnJlbW92ZShsYXllcklEKTsKICNp ZiBVU0UoR1JBUEhJQ1NfU1VSRkFDRSkKQEAgLTM4OCw5ICszODcsOSBAQCB2b2lkIExheWVyVHJl ZVJlbmRlcmVyOjpzZXRSb290TGF5ZXJJRChDb29yZGluYXRlZExheWVySUQgbGF5ZXJJRCkKICAg ICBBU1NFUlQobV9yb290TGF5ZXJJRCA9PSBJbnZhbGlkQ29vcmRpbmF0ZWRMYXllcklEKTsKIAog ICAgIG1fcm9vdExheWVySUQgPSBsYXllcklEOwotICAgIG1fcm9vdExheWVyLT5yZW1vdmVBbGxD aGlsZHJlbigpOwogCiAgICAgR3JhcGhpY3NMYXllciogbGF5ZXIgPSBsYXllckJ5SUQobGF5ZXJJ RCk7CisgICAgQVNTRVJUKG1fcm9vdExheWVyLT5jaGlsZHJlbigpLmlzRW1wdHkoKSk7CiAgICAg bV9yb290TGF5ZXItPmFkZENoaWxkKGxheWVyKTsKIH0KIApAQCAtNjQ0LDcgKzY0Myw2IEBAIHZv aWQgTGF5ZXJUcmVlUmVuZGVyZXI6OnB1cmdlR0xSZXNvdXJjZXMoKQogICAgIG1fc3VyZmFjZUJh Y2tpbmdTdG9yZXMuY2xlYXIoKTsKICNlbmRpZgogCi0gICAgbV9yb290TGF5ZXItPnJlbW92ZUFs bENoaWxkcmVuKCk7CiAgICAgbV9yb290TGF5ZXIuY2xlYXIoKTsKICAgICBtX3Jvb3RMYXllcklE ID0gSW52YWxpZENvb3JkaW5hdGVkTGF5ZXJJRDsKICAgICBtX2xheWVycy5jbGVhcigpOwo=