106929 2013-01-15 11:12:03 -0800 Text Autosizing: extend preOrderTraversal to handle different traversal modes 2013-03-01 02:50:16 -0800 1 1 1 Unclassified WebKit New Bugs 528+ (Nightly build) Unspecified Unspecified RESOLVED WONTFIX P2 Normal --- 84186 106792 0 timvolodine webkit-unassigned darin eric jchaffraix johnme kenneth ojan.autocc timvolodine webkit.review.bot oldest_to_newest 807481 0 timvolodine 2013-01-15 11:12:03 -0800 Text Autosizing: extend preOrderTraversal to handle different traversal modes 807486 1 182813 timvolodine 2013-01-15 11:13:31 -0800 Created attachment 182813 Patch 807535 2 182813 johnme 2013-01-15 11:55:21 -0800 Comment on attachment 182813 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=182813&action=review Cool, this is a nice cleanup and lets us do more powerful traversals (like bug 106792 is trying to do). Kenneth/Julien, does this look good? > Source/WebCore/rendering/TextAutosizer.cpp:299 > + (renderer == container) ? NormalTraversal : SkipDescendantsOfContainers); Nit: WebKit doesn't often wrap long lines (except comments). Perhaps break this into two lines, where the first line sets a temporary |traversalMode| variable? > Source/WebCore/rendering/TextAutosizer.h:60 > + enum TraversalMode { Nit: perhaps TraversalFilter would be clearer? Don't mind, your call... 807538 3 182813 johnme 2013-01-15 11:57:48 -0800 Comment on attachment 182813 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=182813&action=review > Source/WebCore/ChangeLog:8 > + No new tests (OOPS!). Please change this to e.g. "Existing tests confirm that there is no change in functionality." to confirm that you have thought about this. 807660 4 182813 jchaffraix 2013-01-15 13:50:08 -0800 Comment on attachment 182813 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=182813&action=review I would need more context to understand how this patch helps in any ways. Adding an extra parameter doesn't seem to be much of a win compared keeping separated methods as it makes the code easier to misread or misuse but also makes the code less readable (more parameters and your traversal function becomes a swiss-knife function) >> Source/WebCore/rendering/TextAutosizer.cpp:299 >> + (renderer == container) ? NormalTraversal : SkipDescendantsOfContainers); > > Nit: WebKit doesn't often wrap long lines (except comments). Perhaps break this into two lines, where the first line sets a temporary |traversalMode| variable? This seems to be a change in behavior as you could skip descendants where you didn't before: you will only skip descendants if renderer == container && isAutosizingContainer(renderer) where it used to be only isAutosizingContainer(renderer) > Source/WebCore/rendering/TextAutosizer.cpp:-366 > - if (current == stayWithin || !isAutosizingContainer(current)) You removed the stayWithin check which means that you can potentially continue iterating if (current == stayWithin) > Source/WebCore/rendering/TextAutosizer.cpp:367 > + bool skipChildren = (mode == SkipDescendants) || (mode == SkipDescendantsOfContainers && isAutosizingContainer(current)); Per our style guide: Precede boolean values with words like "is" and "did". I think |shouldSkipChildren| would be more readable. > Source/WebCore/rendering/TextAutosizer.cpp:371 > + RenderObject* child = current->firstChild(); > + if (child) if (RenderObject* child = current->firstChild()) return child; > Source/WebCore/rendering/TextAutosizer.cpp:379 > + RenderObject* sibling = ancestor->nextSibling(); > + if (sibling) Again it should be on one line. > Source/WebCore/rendering/TextAutosizer.h:62 > + SkipDescendants, This new mode is not explained anywhere nor used. I would be more supportive to postpone adding it until it's actually used. 807696 5 182813 darin 2013-01-15 14:28:53 -0800 Comment on attachment 182813 Patch Why are you doing this? I don’t agree that this is a step in the right direction. This is makes render tree traversal less like the traversal we do for the DOM tree. But instead we want it to be more like the DOM tree traversal. I really like the work Antti has done in NodeTraversal.h and I’d like to see our render tree traversal use similar patterns. 807697 6 darin 2013-01-15 14:29:16 -0800 (In reply to comment #4) > I would need more context to understand how this patch helps in any ways. Adding an extra parameter doesn't seem to be much of a win compared keeping separated methods as it makes the code easier to misread or misuse but also makes the code less readable (more parameters and your traversal function becomes a swiss-knife function) I agree with this 100%. 807819 7 182813 johnme 2013-01-15 16:45:21 -0800 Comment on attachment 182813 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=182813&action=review (In reply to comment #5) > This is makes render tree traversal less like the traversal we do for the DOM tree. But instead we want it to be more like the DOM tree traversal. I really like the work Antti has done in NodeTraversal.h and I’d like to see our render tree traversal use similar patterns. There may have been a slight mis-communication: this wasn't modifying the core render tree traversal functions defined in RenderObject.h, but merely Text Autosizing's private traversal function. But I agree that we should try to stay in sync with the core traversal functions, and avoid unnecessary duplication. (In reply to comment #4) > I would need more context to understand how this patch helps in any ways. Agree, more explanation would have been helpful. The current patch to bug 106792 uses a custom tree traversal function because it wants to traverse the descendants of a container, skipping descendants of renderers that are themselves containers (so far this is identical to nextInPreOrderSkippingDescendantsOfContainers), but it also wants to skip descendants of <a> elements. Currently nextInPreOrderSkippingDescendantsOfContainers doesn't provide any easy way of skipping arbitrary subtrees, and it seemed a feature that might be useful in other places too, so I suggested that Tim make nextInPreOrderSkippingDescendantsOfContainers slightly more flexible. In hindsight I realise that this was unnecessary, as I'd forgotten that RenderObject.h provides nextInPreOrderAfterChildren(stayWithin) which has exactly the functionality needed for this case. So this patch can probably be dropped. Instead, to reduce duplication, at some point we might want to reimplement nextInPreOrderSkippingDescendantsOfContainers as simply: RenderObject* TextAutosizer::nextInPreOrderSkippingDescendantsOfContainers(const RenderObject* current, const RenderObject* stayWithin) { if (current == stayWithin || !isAutosizingContainer(current)) return current->nextInPreOrder(stayWithin); return current->nextInPreOrderAfterChildren(stayWithin); } >> Source/WebCore/rendering/TextAutosizer.cpp:-366 >> - if (current == stayWithin || !isAutosizingContainer(current)) > > You removed the stayWithin check which means that you can potentially continue iterating if (current == stayWithin) For the record, no, this stayWithin check was because while we normally want to skip descendants of containers, we usually start a traversal by passing in a container as |current|, and in that specific case we didn't want to skip descendants of containers (because the whole point is to traverse the container). Instead Tim used NormalTraversal when starting the traversals above, so this special case was no longer necessary which is arguably cleaner (though might make it easier to misuse the traversal?). The stayWithin check in the for loop below is the one that actually enforces the stayWithin. 812113 8 timvolodine 2013-01-21 06:49:26 -0800 decided to take a different approach, closing this bug. the simplified implementation of nextInPreOrderSkippingDescendantsOfContainers (as outlined above) is now covered in https://bugs.webkit.org/show_bug.cgi?id=107446. 844981 9 182813 eric 2013-03-01 02:50:16 -0800 Comment on attachment 182813 Patch Cleared review? from attachment 182813 so that this bug does not appear in http://webkit.org/pending-review. If you would like this patch reviewed, please attach it to a new bug (or re-open this bug before marking it for review again). 182813 2013-01-15 11:13:31 -0800 2013-03-01 02:50:16 -0800 Patch bug-106929-20130115191032.patch text/plain 6185 timvolodine U3VidmVyc2lvbiBSZXZpc2lvbjogMTM5Njk2CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggMThhZmJlNTIwYjYxNWIz MmI1NWE0NDgzMmExNmE5YWYzNjJkMWMwZi4uMjM4YjVjNTA2MTNmYWU5NTc3MzhiOGFhMjM1NThj YTQzNDI4NGZjMSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE5IEBACisyMDEzLTAxLTE1ICBUaW0g Vm9sb2RpbmUgIDx0aW12b2xvZGluZUBjaHJvbWl1bS5vcmc+CisKKyAgICAgICAgVGV4dCBBdXRv c2l6aW5nOiBleHRlbmQgcHJlT3JkZXJUcmF2ZXJzYWwgdG8gaGFuZGxlIGRpZmZlcmVudCB0cmF2 ZXJzYWwgbW9kZXMKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dp P2lkPTEwNjkyOQorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAg ICAgIE5vIG5ldyB0ZXN0cyAoT09QUyEpLgorCisgICAgICAgICogcmVuZGVyaW5nL1RleHRBdXRv c2l6ZXIuY3BwOgorICAgICAgICAoV2ViQ29yZTo6VGV4dEF1dG9zaXplcjo6cHJvY2Vzc0NvbnRh aW5lcik6CisgICAgICAgIChXZWJDb3JlOjpUZXh0QXV0b3NpemVyOjpjb250YWluZXJDb250YWlu c09uZU9mVGFncyk6CisgICAgICAgIChXZWJDb3JlOjpUZXh0QXV0b3NpemVyOjptZWFzdXJlRGVz Y2VuZGFudFRleHRXaWR0aCk6CisgICAgICAgIChXZWJDb3JlOjpUZXh0QXV0b3NpemVyOjpuZXh0 SW5QcmVPcmRlcik6CisgICAgICAgICogcmVuZGVyaW5nL1RleHRBdXRvc2l6ZXIuaDoKKwogMjAx My0wMS0xNCAgTGV2aSBXZWludHJhdWIgIDxsZXZpd0BjaHJvbWl1bS5vcmc+CiAKICAgICAgICAg Um9sbGluZyBvdXQgcjEzOTYxOC4gQXBwZWFycyB0byBiZSBjYXVzaW5nIHNwb3JhZGljIGNyYXNo ZXMgb24gRGVidWcgYm90cy4KZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL3JlbmRlcmluZy9U ZXh0QXV0b3NpemVyLmNwcCBiL1NvdXJjZS9XZWJDb3JlL3JlbmRlcmluZy9UZXh0QXV0b3NpemVy LmNwcAppbmRleCBjZDFiNWZhZjM4OTg2ZDJjMjRlNmY4ZDZkNGIxNjRhZWFjMGNkOWJiLi5iOTRi ZDc5MzgzOWY1OTgzYzgwNTUwZGI4MWE4ZGY1N2JjZDI3N2ExIDEwMDY0NAotLS0gYS9Tb3VyY2Uv V2ViQ29yZS9yZW5kZXJpbmcvVGV4dEF1dG9zaXplci5jcHAKKysrIGIvU291cmNlL1dlYkNvcmUv cmVuZGVyaW5nL1RleHRBdXRvc2l6ZXIuY3BwCkBAIC0xNDEsNyArMTQxLDcgQEAgdm9pZCBUZXh0 QXV0b3NpemVyOjpwcm9jZXNzQ29udGFpbmVyKGZsb2F0IG11bHRpcGxpZXIsIFJlbmRlckJsb2Nr KiBjb250YWluZXIsIGMKIAogICAgIGZsb2F0IGxvY2FsTXVsdGlwbGllciA9IGNvbnRhaW5lclNo b3VsZEJlQXV0b3NpemVkKGNvbnRhaW5lcikgPyBtdWx0aXBsaWVyOiAxOwogCi0gICAgUmVuZGVy T2JqZWN0KiBkZXNjZW5kYW50ID0gbmV4dEluUHJlT3JkZXJTa2lwcGluZ0Rlc2NlbmRhbnRzT2ZD b250YWluZXJzKHN1YnRyZWVSb290LCBzdWJ0cmVlUm9vdCk7CisgICAgUmVuZGVyT2JqZWN0KiBk ZXNjZW5kYW50ID0gbmV4dEluUHJlT3JkZXIoc3VidHJlZVJvb3QsIHN1YnRyZWVSb290LCBOb3Jt YWxUcmF2ZXJzYWwpOwogICAgIHdoaWxlIChkZXNjZW5kYW50KSB7CiAgICAgICAgIGlmIChkZXNj ZW5kYW50LT5pc1RleHQoKSkgewogICAgICAgICAgICAgaWYgKGxvY2FsTXVsdGlwbGllciAhPSBk ZXNjZW5kYW50LT5zdHlsZSgpLT50ZXh0QXV0b3NpemluZ011bHRpcGxpZXIoKSkgewpAQCAtMTU2 LDcgKzE1Niw3IEBAIHZvaWQgVGV4dEF1dG9zaXplcjo6cHJvY2Vzc0NvbnRhaW5lcihmbG9hdCBt dWx0aXBsaWVyLCBSZW5kZXJCbG9jayogY29udGFpbmVyLCBjCiAgICAgICAgICAgICBlbHNlCiAg ICAgICAgICAgICAgICAgcHJvY2Vzc0NvbnRhaW5lcihtdWx0aXBsaWVyLCBkZXNjZW5kYW50Qmxv Y2ssIGJsb2NrQ29udGFpbmluZ0FsbFRleHQsIGRlc2NlbmRhbnRCbG9jaywgd2luZG93SW5mbyk7 CiAgICAgICAgIH0KLSAgICAgICAgZGVzY2VuZGFudCA9IG5leHRJblByZU9yZGVyU2tpcHBpbmdE ZXNjZW5kYW50c09mQ29udGFpbmVycyhkZXNjZW5kYW50LCBzdWJ0cmVlUm9vdCk7CisgICAgICAg IGRlc2NlbmRhbnQgPSBuZXh0SW5QcmVPcmRlcihkZXNjZW5kYW50LCBzdWJ0cmVlUm9vdCwgU2tp cERlc2NlbmRhbnRzT2ZDb250YWluZXJzKTsKICAgICB9CiB9CiAKQEAgLTI5NSw3ICsyOTUsOCBA QCBib29sIFRleHRBdXRvc2l6ZXI6OmNvbnRhaW5lckNvbnRhaW5zT25lT2ZUYWdzKGNvbnN0IFJl bmRlckJsb2NrKiBjb250YWluZXIsIGNvbgogICAgICAgICAgICAgaWYgKHRhZ3MuY29udGFpbnMo dG9FbGVtZW50KHJlbmRlcmVyTm9kZSktPnRhZ1FOYW1lKCkpKQogICAgICAgICAgICAgICAgIHJl dHVybiB0cnVlOwogICAgICAgICB9Ci0gICAgICAgIHJlbmRlcmVyID0gbmV4dEluUHJlT3JkZXJT a2lwcGluZ0Rlc2NlbmRhbnRzT2ZDb250YWluZXJzKHJlbmRlcmVyLCBjb250YWluZXIpOworICAg ICAgICByZW5kZXJlciA9IG5leHRJblByZU9yZGVyKHJlbmRlcmVyLCBjb250YWluZXIsCisgICAg ICAgICAgICAocmVuZGVyZXIgPT0gY29udGFpbmVyKSA/IE5vcm1hbFRyYXZlcnNhbCA6IFNraXBE ZXNjZW5kYW50c09mQ29udGFpbmVycyk7CiAgICAgfQogCiAgICAgcmV0dXJuIGZhbHNlOwpAQCAt MzQ2LDcgKzM0Nyw3IEBAIHZvaWQgVGV4dEF1dG9zaXplcjo6bWVhc3VyZURlc2NlbmRhbnRUZXh0 V2lkdGgoY29uc3QgUmVuZGVyQmxvY2sqIGNvbnRhaW5lciwgY29uCiB7CiAgICAgYm9vbCBza2lw TG9jYWxUZXh0ID0gIWNvbnRhaW5lclNob3VsZEJlQXV0b3NpemVkKGNvbnRhaW5lcik7CiAKLSAg ICBSZW5kZXJPYmplY3QqIGRlc2NlbmRhbnQgPSBuZXh0SW5QcmVPcmRlclNraXBwaW5nRGVzY2Vu ZGFudHNPZkNvbnRhaW5lcnMoY29udGFpbmVyLCBjb250YWluZXIpOworICAgIFJlbmRlck9iamVj dCogZGVzY2VuZGFudCA9IG5leHRJblByZU9yZGVyKGNvbnRhaW5lciwgY29udGFpbmVyLCBOb3Jt YWxUcmF2ZXJzYWwpOwogICAgIHdoaWxlIChkZXNjZW5kYW50KSB7CiAgICAgICAgIGlmICghc2tp cExvY2FsVGV4dCAmJiBkZXNjZW5kYW50LT5pc1RleHQoKSkgewogICAgICAgICAgICAgdGV4dFdp ZHRoICs9IHRvUmVuZGVyVGV4dChkZXNjZW5kYW50KS0+cmVuZGVyZWRUZXh0TGVuZ3RoKCkgKiBk ZXNjZW5kYW50LT5zdHlsZSgpLT5zcGVjaWZpZWRGb250U2l6ZSgpOwpAQCAtMzU3LDIwICszNTgs MjUgQEAgdm9pZCBUZXh0QXV0b3NpemVyOjptZWFzdXJlRGVzY2VuZGFudFRleHRXaWR0aChjb25z dCBSZW5kZXJCbG9jayogY29udGFpbmVyLCBjb24KICAgICAgICAgfQogICAgICAgICBpZiAodGV4 dFdpZHRoID49IG1pblRleHRXaWR0aCkKICAgICAgICAgICAgIHJldHVybjsKLSAgICAgICAgZGVz Y2VuZGFudCA9IG5leHRJblByZU9yZGVyU2tpcHBpbmdEZXNjZW5kYW50c09mQ29udGFpbmVycyhk ZXNjZW5kYW50LCBjb250YWluZXIpOworICAgICAgICBkZXNjZW5kYW50ID0gbmV4dEluUHJlT3Jk ZXIoZGVzY2VuZGFudCwgY29udGFpbmVyLCBTa2lwRGVzY2VuZGFudHNPZkNvbnRhaW5lcnMpOwog ICAgIH0KIH0KIAotUmVuZGVyT2JqZWN0KiBUZXh0QXV0b3NpemVyOjpuZXh0SW5QcmVPcmRlclNr aXBwaW5nRGVzY2VuZGFudHNPZkNvbnRhaW5lcnMoY29uc3QgUmVuZGVyT2JqZWN0KiBjdXJyZW50 LCBjb25zdCBSZW5kZXJPYmplY3QqIHN0YXlXaXRoaW4pCitSZW5kZXJPYmplY3QqIFRleHRBdXRv c2l6ZXI6Om5leHRJblByZU9yZGVyKGNvbnN0IFJlbmRlck9iamVjdCogY3VycmVudCwgY29uc3Qg UmVuZGVyT2JqZWN0KiBzdGF5V2l0aGluLCBjb25zdCBUcmF2ZXJzYWxNb2RlIG1vZGUpCiB7Ci0g ICAgaWYgKGN1cnJlbnQgPT0gc3RheVdpdGhpbiB8fCAhaXNBdXRvc2l6aW5nQ29udGFpbmVyKGN1 cnJlbnQpKQotICAgICAgICBmb3IgKFJlbmRlck9iamVjdCogY2hpbGQgPSBjdXJyZW50LT5maXJz dENoaWxkKCk7IGNoaWxkOyBjaGlsZCA9IGNoaWxkLT5uZXh0U2libGluZygpKQorICAgIGJvb2wg c2tpcENoaWxkcmVuID0gKG1vZGUgPT0gU2tpcERlc2NlbmRhbnRzKSB8fCAobW9kZSA9PSBTa2lw RGVzY2VuZGFudHNPZkNvbnRhaW5lcnMgJiYgaXNBdXRvc2l6aW5nQ29udGFpbmVyKGN1cnJlbnQp KTsKKworICAgIGlmICghc2tpcENoaWxkcmVuKSB7CisgICAgICAgIFJlbmRlck9iamVjdCogY2hp bGQgPSBjdXJyZW50LT5maXJzdENoaWxkKCk7CisgICAgICAgIGlmIChjaGlsZCkKICAgICAgICAg ICAgIHJldHVybiBjaGlsZDsKKyAgICB9CiAKICAgICBmb3IgKGNvbnN0IFJlbmRlck9iamVjdCog YW5jZXN0b3IgPSBjdXJyZW50OyBhbmNlc3RvcjsgYW5jZXN0b3IgPSBhbmNlc3Rvci0+cGFyZW50 KCkpIHsKICAgICAgICAgaWYgKGFuY2VzdG9yID09IHN0YXlXaXRoaW4pCiAgICAgICAgICAgICBy ZXR1cm4gMDsKLSAgICAgICAgZm9yIChSZW5kZXJPYmplY3QqIHNpYmxpbmcgPSBhbmNlc3Rvci0+ bmV4dFNpYmxpbmcoKTsgc2libGluZzsgc2libGluZyA9IHNpYmxpbmctPm5leHRTaWJsaW5nKCkp CisgICAgICAgIFJlbmRlck9iamVjdCogc2libGluZyA9IGFuY2VzdG9yLT5uZXh0U2libGluZygp OworICAgICAgICBpZiAoc2libGluZykKICAgICAgICAgICAgIHJldHVybiBzaWJsaW5nOwogICAg IH0KIApkaWZmIC0tZ2l0IGEvU291cmNlL1dlYkNvcmUvcmVuZGVyaW5nL1RleHRBdXRvc2l6ZXIu aCBiL1NvdXJjZS9XZWJDb3JlL3JlbmRlcmluZy9UZXh0QXV0b3NpemVyLmgKaW5kZXggMTY4YTI4 NWI5NThhOTQ4ZTg4YWI2MDBlMGIxNzNkMDk1ODIyOTQ2MC4uYWRmMTFkZjdiNTA1MmY2N2VjNTY4 NzVkNzRkZjk5ZjE4ZGU3ZWI3ZiAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvcmVuZGVyaW5n L1RleHRBdXRvc2l6ZXIuaAorKysgYi9Tb3VyY2UvV2ViQ29yZS9yZW5kZXJpbmcvVGV4dEF1dG9z aXplci5oCkBAIC01Nyw2ICs1NywxMSBAQCBwcml2YXRlOgogICAgICAgICBGaXJzdFRvTGFzdCwK ICAgICAgICAgTGFzdFRvRmlyc3QKICAgICB9OworICAgIGVudW0gVHJhdmVyc2FsTW9kZSB7Cisg ICAgICAgIE5vcm1hbFRyYXZlcnNhbCwKKyAgICAgICAgU2tpcERlc2NlbmRhbnRzLAorICAgICAg ICBTa2lwRGVzY2VuZGFudHNPZkNvbnRhaW5lcnMKKyAgICB9OwogCiAgICAgZXhwbGljaXQgVGV4 dEF1dG9zaXplcihEb2N1bWVudCopOwogCkBAIC03NSw4ICs4MCw5IEBAIHByaXZhdGU6CiAgICAg c3RhdGljIGJvb2wgY2x1c3RlclNob3VsZEJlQXV0b3NpemVkKGNvbnN0IFJlbmRlckJsb2NrKiBi bG9ja0NvbnRhaW5pbmdBbGxUZXh0LCBmbG9hdCBibG9ja1dpZHRoKTsKICAgICBzdGF0aWMgdm9p ZCBtZWFzdXJlRGVzY2VuZGFudFRleHRXaWR0aChjb25zdCBSZW5kZXJCbG9jayogY29udGFpbmVy LCBjb25zdCBSZW5kZXJCbG9jayogYmxvY2tDb250YWluaW5nQWxsVGV4dCwgZmxvYXQgbWluVGV4 dFdpZHRoLCBmbG9hdCYgdGV4dFdpZHRoKTsKIAotICAgIC8vIFVzZSB0byB0cmF2ZXJzZSB0aGUg dHJlZSBvZiBkZXNjZW5kYW50cywgZXhjbHVkaW5nIGRlc2NlbmRhbnRzIG9mIGNvbnRhaW5lcnMg KGJ1dCByZXR1cm5pbmcgdGhlIGNvbnRhaW5lcnMgdGhlbXNlbHZlcykuCi0gICAgc3RhdGljIFJl bmRlck9iamVjdCogbmV4dEluUHJlT3JkZXJTa2lwcGluZ0Rlc2NlbmRhbnRzT2ZDb250YWluZXJz KGNvbnN0IFJlbmRlck9iamVjdCosIGNvbnN0IFJlbmRlck9iamVjdCogc3RheVdpdGhpbik7Cisg ICAgLy8gVXNlIHRvIHRyYXZlcnNlIHRoZSB0cmVlIG9mIGRlc2NlbmRhbnRzLCBvcHRpb25hbGx5 IHNraXBwaW5nIGRlc2NlbmRhbnRzIG9yIGRlc2NlbmRhbnRzIG9mIGNvbnRhaW5lcnMKKyAgICAv LyBkZXBlbmRpbmcgb24gdGhlIHRyYXZlcnNhbCBtb2RlLgorICAgIHN0YXRpYyBSZW5kZXJPYmpl Y3QqIG5leHRJblByZU9yZGVyKGNvbnN0IFJlbmRlck9iamVjdCogY3VycmVudCwgY29uc3QgUmVu ZGVyT2JqZWN0KiBzdGF5V2l0aGluLCBjb25zdCBUcmF2ZXJzYWxNb2RlKTsKIAogICAgIHN0YXRp YyBjb25zdCBSZW5kZXJCbG9jayogZmluZERlZXBlc3RCbG9ja0NvbnRhaW5pbmdBbGxUZXh0KGNv bnN0IFJlbmRlckJsb2NrKiBjbHVzdGVyKTsKIAo=