<?xml version="1.0" encoding="UTF-8" standalone="yes" ?>
<!DOCTYPE bugzilla SYSTEM "https://bugs.webkit.org/page.cgi?id=bugzilla.dtd">

<bugzilla version="5.0.4.1"
          urlbase="https://bugs.webkit.org/"
          
          maintainer="admin@webkit.org"
>

    <bug>
          <bug_id>106924</bug_id>
          
          <creation_ts>2013-01-15 10:50:18 -0800</creation_ts>
          <short_desc>[GTK] GTK does not expose heading level correctly. Was: accessibility/heading-level.html is failing</short_desc>
          <delta_ts>2013-09-30 01:54:11 -0700</delta_ts>
          <reporter_accessible>1</reporter_accessible>
          <cclist_accessible>1</cclist_accessible>
          <classification_id>1</classification_id>
          <classification>Unclassified</classification>
          <product>WebKit</product>
          <component>WebKitGTK</component>
          <version>528+ (Nightly build)</version>
          <rep_platform>Unspecified</rep_platform>
          <op_sys>Unspecified</op_sys>
          <bug_status>RESOLVED</bug_status>
          <resolution>FIXED</resolution>
          
          
          <bug_file_loc></bug_file_loc>
          <status_whiteboard></status_whiteboard>
          <keywords>Gtk, LayoutTestFailure</keywords>
          <priority>P2</priority>
          <bug_severity>Normal</bug_severity>
          <target_milestone>---</target_milestone>
          
          <blocked>98347</blocked>
    
    <blocked>112000</blocked>
          <everconfirmed>1</everconfirmed>
          <reporter name="Zan Dobersek">zan</reporter>
          <assigned_to name="Nobody">webkit-unassigned</assigned_to>
          <cc>cfleizach</cc>
    
    <cc>jcraig</cc>
    
    <cc>jdiggs</cc>
    
    <cc>k.czech</cc>
    
    <cc>l.gajowy</cc>
    
    <cc>mario</cc>
    
    <cc>zan</cc>
          

      

      

      

          <comment_sort_order>oldest_to_newest</comment_sort_order>  
          <long_desc isprivate="0" >
    <commentid>807454</commentid>
    <comment_count>0</comment_count>
    <who name="Zan Dobersek">zan</who>
    <bug_when>2013-01-15 10:50:18 -0800</bug_when>
    <thetext>The accessibility/heading-level.html test is failing since it&apos;s been added in r139534.
http://trac.webkit.org/changeset/139534

--- /home/slave/webkitgtk/gtk-linux-64-release/build/layout-test-results/accessibility/heading-level-expected.txt
+++ /home/slave/webkitgtk/gtk-linux-64-release/build/layout-test-results/accessibility/heading-level-actual.txt
@@ -3,24 +3,24 @@
 On success, you will see a series of &quot;PASS&quot; messages, followed by &quot;TEST COMPLETE&quot;.
 
 
-PASS: level is 1.
-PASS: level is 2.
-PASS: level is 3.
-PASS: level is 4.
-PASS: level is 5.
-PASS: level is 6.
-PASS: level is 1.
-PASS: level is 2.
-PASS: level is 3.
-PASS: level is 4.
-PASS: level is 5.
-PASS: level is 6.
-PASS: level is 1.
-PASS: level is 2.
-PASS: level is 3.
-PASS: level is 4.
-PASS: level is 5.
-PASS: level is 6.
+FAIL: level is 0 for &lt;h1 class=&quot;ex&quot; data-expected=&quot;1&quot; id=&quot;ex0&quot;&gt;X&lt;/h1&gt;, expected 1.
+FAIL: level is 0 for &lt;h2 class=&quot;ex&quot; data-expected=&quot;2&quot; id=&quot;ex1&quot;&gt;X&lt;/h2&gt;, expected 2.
+FAIL: level is 0 for &lt;h3 class=&quot;ex&quot; data-expected=&quot;3&quot; id=&quot;ex2&quot;&gt;X&lt;/h3&gt;, expected 3.
+FAIL: level is 0 for &lt;h4 class=&quot;ex&quot; data-expected=&quot;4&quot; id=&quot;ex3&quot;&gt;X&lt;/h4&gt;, expected 4.
+FAIL: level is 0 for &lt;h5 class=&quot;ex&quot; data-expected=&quot;5&quot; id=&quot;ex4&quot;&gt;X&lt;/h5&gt;, expected 5.
+FAIL: level is 0 for &lt;h6 class=&quot;ex&quot; data-expected=&quot;6&quot; id=&quot;ex5&quot;&gt;X&lt;/h6&gt;, expected 6.
+FAIL: level is 0 for &lt;h6 class=&quot;ex&quot; role=&quot;heading&quot; data-expected=&quot;1&quot; aria-level=&quot;1&quot; id=&quot;ex6&quot;&gt;X&lt;/h6&gt;, expected 1.
+FAIL: level is 0 for &lt;h5 class=&quot;ex&quot; role=&quot;heading&quot; data-expected=&quot;2&quot; aria-level=&quot;2&quot; id=&quot;ex7&quot;&gt;X&lt;/h5&gt;, expected 2.
+FAIL: level is 0 for &lt;h4 class=&quot;ex&quot; role=&quot;heading&quot; data-expected=&quot;3&quot; aria-level=&quot;3&quot; id=&quot;ex8&quot;&gt;X&lt;/h4&gt;, expected 3.
+FAIL: level is 0 for &lt;h3 class=&quot;ex&quot; role=&quot;heading&quot; data-expected=&quot;4&quot; aria-level=&quot;4&quot; id=&quot;ex9&quot;&gt;X&lt;/h3&gt;, expected 4.
+FAIL: level is 0 for &lt;h2 class=&quot;ex&quot; role=&quot;heading&quot; data-expected=&quot;5&quot; aria-level=&quot;5&quot; id=&quot;ex10&quot;&gt;X&lt;/h2&gt;, expected 5.
+FAIL: level is 0 for &lt;h1 class=&quot;ex&quot; role=&quot;heading&quot; data-expected=&quot;6&quot; aria-level=&quot;6&quot; id=&quot;ex11&quot;&gt;X&lt;/h1&gt;, expected 6.
+FAIL: level is 0 for &lt;div class=&quot;ex&quot; role=&quot;heading&quot; data-expected=&quot;1&quot; aria-level=&quot;1&quot; id=&quot;ex12&quot;&gt;X&lt;/div&gt;, expected 1.
+FAIL: level is 0 for &lt;div class=&quot;ex&quot; role=&quot;heading&quot; data-expected=&quot;2&quot; aria-level=&quot;2&quot; id=&quot;ex13&quot;&gt;X&lt;/div&gt;, expected 2.
+FAIL: level is 0 for &lt;div class=&quot;ex&quot; role=&quot;heading&quot; data-expected=&quot;3&quot; aria-level=&quot;3&quot; id=&quot;ex14&quot;&gt;X&lt;/div&gt;, expected 3.
+FAIL: level is 0 for &lt;div class=&quot;ex&quot; role=&quot;heading&quot; data-expected=&quot;4&quot; aria-level=&quot;4&quot; id=&quot;ex15&quot;&gt;X&lt;/div&gt;, expected 4.
+FAIL: level is 0 for &lt;div class=&quot;ex&quot; role=&quot;heading&quot; data-expected=&quot;5&quot; aria-level=&quot;5&quot; id=&quot;ex16&quot;&gt;X&lt;/div&gt;, expected 5.
+FAIL: level is 0 for &lt;div class=&quot;ex&quot; role=&quot;heading&quot; data-expected=&quot;6&quot; aria-level=&quot;6&quot; id=&quot;ex17&quot;&gt;X&lt;/div&gt;, expected 6.
 PASS successfullyParsed is true
 
 TEST COMPLETE</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>855150</commentid>
    <comment_count>1</comment_count>
    <who name="Lukasz Gajowy">l.gajowy</who>
    <bug_when>2013-03-14 05:47:46 -0700</bug_when>
    <thetext>Generally proposed solution in atk/AccessibilityUIElementAtk.cpp  (AccessibilityUIElement::intValue) may not be accurate for this test.

Couple of modifications require to pass it:

1) by adding aria-valuenow=&quot;x&quot; attribute in every heading, where x is equal to data-expected.
2) by updating an interfaceMask on ATK_VALUE interface where element&apos;s role is HeadingRole
3) by making isARIARange() method from AccessibilityNodeObject.cpp return true in case of meeting HeadingRole or UnknownRole.

This solution raises the following questions:
- Can we consider Heading element as a Range.
- It seems calling valueForRange is not appropriate for this test. Heading is not a Range type element.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>864606</commentid>
    <comment_count>2</comment_count>
    <who name="James Craig">jcraig</who>
    <bug_when>2013-03-27 09:15:37 -0700</bug_when>
    <thetext>&gt; 1) by adding aria-valuenow=&quot;x&quot; attribute in every heading, where x is equal to data-expected.

Don&apos;t do that. It&apos;s expected that the level is determined by the tagname (or nesting) in HTML, and by the aria-level property in ARIA. Adding valuenow would be an invalid ARIA test case, because it&apos;s only allowed on range widgets, and heading inherits from structure, not widget.

http://www.w3.org/WAI/PF/aria/rdf_model.svg

&gt; This solution raises the following questions:
&gt; - Can we consider Heading element as a Range.

I woud say no.

&gt; - It seems calling valueForRange is not appropriate for this test. Heading is not a Range type element.

The test just calls the intValue property, so I don&apos;t think there is a problem with the test. Value for a heading is it&apos;s level. That said, it seems like a logical suggestion that intValue should not call valueForRange(). Perhaps rename the accessor method value(), or use a different method in this case.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>885920</commentid>
    <comment_count>3</comment_count>
    <who name="James Craig">jcraig</who>
    <bug_when>2013-05-07 12:34:57 -0700</bug_when>
    <thetext>Updating the title to be more accurate.

From: &quot;accessibility/heading-level.html is failing&quot; 
To: &quot;GTK does not expose heading level correctly.&quot;</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>931224</commentid>
    <comment_count>4</comment_count>
    <who name="Mario Sanchez Prada">mario</who>
    <bug_when>2013-09-20 01:57:51 -0700</bug_when>
    <thetext>*** Bug 121556 has been marked as a duplicate of this bug. ***</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>931226</commentid>
    <comment_count>5</comment_count>
    <who name="Mario Sanchez Prada">mario</who>
    <bug_when>2013-09-20 02:03:49 -0700</bug_when>
    <thetext>(In reply to comment #3)
&gt; Updating the title to be more accurate.
&gt; 
&gt; From: &quot;accessibility/heading-level.html is failing&quot; 
&gt; To: &quot;GTK does not expose heading level correctly.&quot;

Actually, GTK is exposing the heading level already as a &quot;level&quot; object attribute for the AtkObject. The only problem is that DRT/WKTR are not reading that value when we call to intValue(), which at the moment only works for accessible objects implementing the AtkValue interface.

However, it seems clear to me (and I hope Joanie will agree), that headings should not implement the AtkValue interface, since they don&apos;t match the use case for that (e.g. what would be the &apos;minimum increment&apos;, &apos;maximum value&apos; and &apos;minimum value&apos;?), so perhaps the best option is just to tweak our DRT/WKTR to do something similar to what chromium decided to do back in the day in SVN r139658: to consider headings as special cases in the intValue() function, so we check the &quot;level&quot; object property for the heading objects.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>931240</commentid>
    <comment_count>6</comment_count>
      <attachid>212140</attachid>
    <who name="Mario Sanchez Prada">mario</who>
    <bug_when>2013-09-20 02:50:42 -0700</bug_when>
    <thetext>Created attachment 212140
Patch proposal

This patch would implement that idea and, ideally, will make the test pass.

However, adding those mappings in DRT/WKTR unveiled another issue that does not quite allow us to get it right yet. This is the output I&apos;m getting now, with this patch applied on top of another patch for bug 121602 and bug 121558 (as the test will crash now without that):

    This tests that headings have a level matching the implicit default value or explicitly defined aria-level value.
    
    On success, you will see a series of &quot;PASS&quot; messages, followed by &quot;TEST COMPLETE&quot;.
    
    
    PASS: level is 1.
    FAIL: level is 0 for &lt;h2 class=&quot;ex&quot; data-expected=&quot;2&quot; id=&quot;ex1&quot;&gt;X&lt;/h2&gt;, expected 2.
    FAIL: level is 0 for &lt;h3 class=&quot;ex&quot; data-expected=&quot;3&quot; id=&quot;ex2&quot;&gt;X&lt;/h3&gt;, expected 3.
    FAIL: level is 0 for &lt;h4 class=&quot;ex&quot; data-expected=&quot;4&quot; id=&quot;ex3&quot;&gt;X&lt;/h4&gt;, expected 4.
    FAIL: level is 0 for &lt;h5 class=&quot;ex&quot; data-expected=&quot;5&quot; id=&quot;ex4&quot;&gt;X&lt;/h5&gt;, expected 5.
    FAIL: level is 0 for &lt;h6 class=&quot;ex&quot; data-expected=&quot;6&quot; id=&quot;ex5&quot;&gt;X&lt;/h6&gt;, expected 6.
    FAIL: level is 0 for &lt;h6 class=&quot;ex&quot; data-expected=&quot;1&quot; aria-level=&quot;1&quot; id=&quot;ex6&quot;&gt;X&lt;/h6&gt;, expected 1.
    FAIL: level is 0 for &lt;h5 class=&quot;ex&quot; data-expected=&quot;2&quot; aria-level=&quot;2&quot; id=&quot;ex7&quot;&gt;X&lt;/h5&gt;, expected 2.
    FAIL: level is 0 for &lt;h4 class=&quot;ex&quot; data-expected=&quot;3&quot; aria-level=&quot;3&quot; id=&quot;ex8&quot;&gt;X&lt;/h4&gt;, expected 3.
    FAIL: level is 0 for &lt;h3 class=&quot;ex&quot; data-expected=&quot;4&quot; aria-level=&quot;4&quot; id=&quot;ex9&quot;&gt;X&lt;/h3&gt;, expected 4.
    FAIL: level is 0 for &lt;h2 class=&quot;ex&quot; data-expected=&quot;5&quot; aria-level=&quot;5&quot; id=&quot;ex10&quot;&gt;X&lt;/h2&gt;, expected 5.
    FAIL: level is 0 for &lt;h1 class=&quot;ex&quot; data-expected=&quot;6&quot; aria-level=&quot;6&quot; id=&quot;ex11&quot;&gt;X&lt;/h1&gt;, expected 6.
    FAIL: level is 0 for &lt;h6 class=&quot;ex&quot; role=&quot;heading&quot; data-expected=&quot;1&quot; aria-level=&quot;1&quot; id=&quot;ex12&quot;&gt;X&lt;/h6&gt;, expected 1.
    FAIL: level is 0 for &lt;h5 class=&quot;ex&quot; role=&quot;heading&quot; data-expected=&quot;2&quot; aria-level=&quot;2&quot; id=&quot;ex13&quot;&gt;X&lt;/h5&gt;, expected 2.
    FAIL: level is 0 for &lt;h4 class=&quot;ex&quot; role=&quot;heading&quot; data-expected=&quot;3&quot; aria-level=&quot;3&quot; id=&quot;ex14&quot;&gt;X&lt;/h4&gt;, expected 3.
    FAIL: level is 0 for &lt;h3 class=&quot;ex&quot; role=&quot;heading&quot; data-expected=&quot;4&quot; aria-level=&quot;4&quot; id=&quot;ex15&quot;&gt;X&lt;/h3&gt;, expected 4.
    FAIL: level is 0 for &lt;h2 class=&quot;ex&quot; role=&quot;heading&quot; data-expected=&quot;5&quot; aria-level=&quot;5&quot; id=&quot;ex16&quot;&gt;X&lt;/h2&gt;, expected 5.
    FAIL: level is 0 for &lt;h1 class=&quot;ex&quot; role=&quot;heading&quot; data-expected=&quot;6&quot; aria-level=&quot;6&quot; id=&quot;ex17&quot;&gt;X&lt;/h1&gt;, expected 6.
    FAIL: level is 0 for &lt;div class=&quot;ex&quot; role=&quot;heading&quot; data-expected=&quot;1&quot; aria-level=&quot;1&quot; id=&quot;ex18&quot;&gt;X&lt;/div&gt;, expected 1.
    FAIL: level is 0 for &lt;div class=&quot;ex&quot; role=&quot;heading&quot; data-expected=&quot;2&quot; aria-level=&quot;2&quot; id=&quot;ex19&quot;&gt;X&lt;/div&gt;, expected 2.
    FAIL: level is 0 for &lt;div class=&quot;ex&quot; role=&quot;heading&quot; data-expected=&quot;3&quot; aria-level=&quot;3&quot; id=&quot;ex20&quot;&gt;X&lt;/div&gt;, expected 3.
    FAIL: level is 0 for &lt;div class=&quot;ex&quot; role=&quot;heading&quot; data-expected=&quot;4&quot; aria-level=&quot;4&quot; id=&quot;ex21&quot;&gt;X&lt;/div&gt;, expected 4.
    FAIL: level is 0 for &lt;div class=&quot;ex&quot; role=&quot;heading&quot; data-expected=&quot;5&quot; aria-level=&quot;5&quot; id=&quot;ex22&quot;&gt;X&lt;/div&gt;, expected 5.
    FAIL: level is 0 for &lt;div class=&quot;ex&quot; role=&quot;heading&quot; data-expected=&quot;6&quot; aria-level=&quot;6&quot; id=&quot;ex23&quot;&gt;X&lt;/div&gt;, expected 6.
    PASS successfullyParsed is true
    
    TEST COMPLETE
    
    #EOF


The interesting part of this is that the proper value will be returned when calling intValue() *as long as* we do not hide the heading at the end of each iteration in the for loop for the test:

    &lt;script&gt;
    [...]
        var examples = document.querySelectorAll(&apos;.ex&apos;);
        for (var i = 0, c = examples.length; i &lt; c; i++) {
            var el = examples[i];
            el.id = &apos;ex&apos; + i;
            var axElement = accessibilityController.accessibleElementById(el.id);
            var result = document.getElementById(&apos;console&apos;);

            // Test AXLevel.
            if (axElement.intValue == parseInt(el.getAttribute(&apos;data-expected&apos;))) {
                result.innerText += &quot;PASS: level is &quot; + axElement.intValue + &quot;.\n&quot;;
            } else {
                result.innerText += &quot;FAIL: level is &quot; + axElement.intValue + &quot; for &quot; + el.outerHTML + &quot;, expected &quot; + parseInt(el.getAttribute(&apos;data-expected&apos;)) + &quot;.\n&quot;;
            }
            el.style.display = &apos;none&apos;; // Hide each example after verification.
        }
    }
    &lt;/script&gt;


If we remove the &quot;el.style.display = &apos;none&apos;;&quot; line we will get the proper values on each call to intValue() as expected, but leaving it there will show the weird behaviour we could see above. After some investigation, I found that the problem seems to be that such an stament forces to update the layout, ultimately causing (at least on GTK/EFL) to invalidate the AtkObjects we had wrapped inside the AccessibilityUIElement objects, hence early returning for every object after the first one in intValue(), due to the &quot;if (!m_element || !ATK_IS_OBJECT(m_element)) return 0.0f;&quot; statement.

So, it seems to me like there&apos;s yet another weird bug happening that we need to get fixed before being able to actually fix this patch, even if the best solution is just the proposed one of considering heading roles in the implementation of DRT/WKTR&apos;s intValue() functions. I&apos;ll try to work on that asap and will file a bug blocking this one when ready when I know better what&apos;s going on.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>931294</commentid>
    <comment_count>7</comment_count>
    <who name="Joanmarie Diggs">jdiggs</who>
    <bug_when>2013-09-20 06:02:23 -0700</bug_when>
    <thetext>(In reply to comment #5)
 
&gt; However, it seems clear to me (and I hope Joanie will agree), that headings should not implement the AtkValue interface

I do agree. Most enthusiastically. :)</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>931310</commentid>
    <comment_count>8</comment_count>
    <who name="Mario Sanchez Prada">mario</who>
    <bug_when>2013-09-20 06:33:02 -0700</bug_when>
    <thetext>(In reply to comment #6)
&gt; [...]
&gt; So, it seems to me like there&apos;s yet another weird bug happening that we 
&gt; need to get fixed before being able to actually fix this patch, even if
&gt; the best solution is just the proposed one of considering heading roles
&gt; in the implementation of DRT/WKTR&apos;s intValue() functions. I&apos;ll try to
&gt; work on that asap and will file a bug blocking this one when ready when
&gt; I know better what&apos;s going on.

It seems that the problem was caused by a call to coreObject-&gt;helpText() in webkitAccessibleGetAttributes, in the ATK wrapper, which was causing a text computation under the element just for the sake of exposing the &apos;aria-help&apos; attribute, which ended up altering the a11y tree and getting this weird result.

Fortunately, we can just remove that &apos;aria-help&apos; mapping from there since it&apos;s wrong in the first place, and once we do that this tests will pass gracefully, assuming that the patch attached here is approved.

For the removal of the &apos;aria-help&apos; mapping I filed bug 121675 and provided a patch there, so now setting the dependency here and moving on.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>932552</commentid>
    <comment_count>9</comment_count>
      <attachid>212466</attachid>
    <who name="Mario Sanchez Prada">mario</who>
    <bug_when>2013-09-24 07:32:27 -0700</bug_when>
    <thetext>Created attachment 212466
Patch proposal

(In reply to comment #8)
&gt; [...]
&gt; It seems that the problem was caused by a call to coreObject-&gt;helpText() in 
&gt; webkitAccessibleGetAttributes, in the ATK wrapper, which was causing a text
&gt; computation under the element just for the sake of exposing the &apos;aria-help&apos;
&gt; attribute, which ended up altering the a11y tree and getting this weird
&gt; result.
&gt; 
&gt; Fortunately, we can just remove that &apos;aria-help&apos; mapping from there since
&gt; it&apos;s wrong in the first place, and once we do that this tests will pass
&gt; gracefully, assuming that the patch attached here is approved.
&gt; 
&gt; For the removal of the &apos;aria-help&apos; mapping I filed bug 121675 and provided
&gt; a patch there, so now setting the dependency here and moving on.

It seems that this accessibility/heading-level.html test is not crashing anymore but just failing, since removing that call to coreObject-&gt;helpText() from there do not cause the segfault to happen anymore in the context of this test. So, I&apos;m now proposing a new patch that is basically the previous one + the removal of the test from TestExpectations file.

However, a problem related to trying to use the WebCore&apos;s accessibility API when the render tree is not stable (needing a layout update) still remains, since the layout test proposed with the current patch for bug 121558 still crashes in GTK. But that&apos;s a separate issue anyway (even if it was detected through this bug in the first place), so I&apos;d rather keep it separate and work on it there instead.

So, please review this patch for this specific thing. I&apos;ll keep working in that other potential crash in bug 121558. Thanks!</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>932587</commentid>
    <comment_count>10</comment_count>
      <attachid>212466</attachid>
    <who name="chris fleizach">cfleizach</who>
    <bug_when>2013-09-24 09:05:00 -0700</bug_when>
    <thetext>Comment on attachment 212466
Patch proposal

View in context: https://bugs.webkit.org/attachment.cgi?id=212466&amp;action=review

r- for some style considerations. thanks

&gt; Tools/DumpRenderTree/atk/AccessibilityUIElementAtk.cpp:618
&gt; +        GValue value = { 0, { { 0 } } };

can you use G_VALUE_INIT here?

&gt; Tools/DumpRenderTree/atk/AccessibilityUIElementAtk.cpp:621
&gt; +            return 0.0f;

style guidelines say not to append &quot;f&quot; to literals

&gt; Tools/DumpRenderTree/atk/AccessibilityUIElementAtk.cpp:632
&gt; +        if (!ok)

this should be if (ok)... then you can let the failure case fall through to the final return value

&gt; Tools/DumpRenderTree/atk/AccessibilityUIElementAtk.cpp:633
&gt; +            return 0.0f;

ditto

&gt; Tools/DumpRenderTree/atk/AccessibilityUIElementAtk.cpp:636
&gt; +    return 0.0f;

ditto

&gt; Tools/WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp:789
&gt; +            return 0.0f;

ditto about .f

&gt; Tools/WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp:799
&gt; +        double headingLevelValue = headingLevel.toDouble(&amp;ok);

ditto about comments from DRT</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>932911</commentid>
    <comment_count>11</comment_count>
      <attachid>212545</attachid>
    <who name="Mario Sanchez Prada">mario</who>
    <bug_when>2013-09-25 02:21:34 -0700</bug_when>
    <thetext>Created attachment 212545
Patch proposal

(In reply to comment #10)
&gt; (From update of attachment 212466 [details])
&gt; View in context: https://bugs.webkit.org/attachment.cgi?id=212466&amp;action=review
&gt; 
&gt; r- for some style considerations. thanks
&gt; 
Sorry about those. It just a consequence of &quot;expanding&quot; the current function, which contained the errors already and I did not realize about it.

Now attaching a new patch. I&apos;ll be also filing a new bug to normalize those files so we don&apos;t use that anymore, to avoid issues/confusino when people modify these files in the future.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>933979</commentid>
    <comment_count>12</comment_count>
    <who name="Mario Sanchez Prada">mario</who>
    <bug_when>2013-09-27 09:58:40 -0700</bug_when>
    <thetext>Committed r156551: &lt;http://trac.webkit.org/changeset/156551&gt;</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>934494</commentid>
    <comment_count>13</comment_count>
    <who name="Krzysztof Czech">k.czech</who>
    <bug_when>2013-09-30 01:54:11 -0700</bug_when>
    <thetext>*** Bug 112000 has been marked as a duplicate of this bug. ***</thetext>
  </long_desc>
      
          <attachment
              isobsolete="1"
              ispatch="1"
              isprivate="0"
          >
            <attachid>212140</attachid>
            <date>2013-09-20 02:50:42 -0700</date>
            <delta_ts>2013-09-24 07:32:27 -0700</delta_ts>
            <desc>Patch proposal</desc>
            <filename>0001-2013-09-20-Mario-Sanchez-Prada-mario.prada-samsung.c.patch</filename>
            <type>text/plain</type>
            <size>5297</size>
            <attacher name="Mario Sanchez Prada">mario</attacher>
            
              <data encoding="base64">RnJvbSA5ZWNmYTM4ODNjNDc5OTE1ZWY4Y2FkZTA5NTFkYTliMzI5YjM0NGM0IE1vbiBTZXAgMTcg
MDA6MDA6MDAgMjAwMQpGcm9tOiBNYXJpbyBTYW5jaGV6IFByYWRhIDxtYXJpby5wcmFkYUBzYW1z
dW5nLmNvbT4KRGF0ZTogRnJpLCAyMCBTZXAgMjAxMyAxMDowNzoyMiArMDEwMApTdWJqZWN0OiBb
UEFUQ0hdIDIwMTMtMDktMjAgIE1hcmlvIFNhbmNoZXogUHJhZGEgIDxtYXJpby5wcmFkYUBzYW1z
dW5nLmNvbT4KCiAgICAgICAgW0dUS10gR1RLIGRvZXMgbm90IGV4cG9zZSBoZWFkaW5nIGxldmVs
IGNvcnJlY3RseS4gV2FzOiBhY2Nlc3NpYmlsaXR5L2hlYWRpbmctbGV2ZWwuaHRtbCBpcyBmYWls
aW5nCiAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTEwNjky
NAoKICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KCiAgICAgICAgQ29uc2lkZXIg
aGVhZGluZ3MgbGV2ZWxzIGFzIHZhbHVlcyB0byBiZSByZXR1cm5lZCBpbiBpbnRWYWx1ZSgpCiAg
ICAgICAgYm90aCBpbiBEUlQgYW5kIFdLVFIsIHNvIHdlIGNhbiBzaGFyZSBtb3JlIHRlc3RzIHdp
dGggb3RoZXIgcG9ydHMuCgogICAgICAgICogRHVtcFJlbmRlclRyZWUvYXRrL0FjY2Vzc2liaWxp
dHlVSUVsZW1lbnRBdGsuY3BwOgogICAgICAgIChBY2Nlc3NpYmlsaXR5VUlFbGVtZW50OjppbnRW
YWx1ZSk6IENvbnNpZGVyIGhlYWRpbmdzIHRvby4KICAgICAgICAqIFdlYktpdFRlc3RSdW5uZXIv
SW5qZWN0ZWRCdW5kbGUvYXRrL0FjY2Vzc2liaWxpdHlVSUVsZW1lbnRBdGsuY3BwOgogICAgICAg
IChXVFI6OkFjY2Vzc2liaWxpdHlVSUVsZW1lbnQ6OmludFZhbHVlKTogRGl0dG8uCi0tLQogVG9v
bHMvQ2hhbmdlTG9nICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgfCAgIDE1ICsr
KysrKysrKysrCiAuLi4vYXRrL0FjY2Vzc2liaWxpdHlVSUVsZW1lbnRBdGsuY3BwICAgICAgICAg
ICAgICB8ICAgMjggKysrKysrKysrKysrKysrLS0tLS0KIC4uLi9hdGsvQWNjZXNzaWJpbGl0eVVJ
RWxlbWVudEF0ay5jcHAgICAgICAgICAgICAgIHwgICAyNCArKysrKysrKysrKysrLS0tLQogMyBm
aWxlcyBjaGFuZ2VkLCA1NSBpbnNlcnRpb25zKCspLCAxMiBkZWxldGlvbnMoLSkKCmRpZmYgLS1n
aXQgYS9Ub29scy9DaGFuZ2VMb2cgYi9Ub29scy9DaGFuZ2VMb2cKaW5kZXggYjU2NzY1OC4uMDY1
ZDdjNyAxMDA2NDQKLS0tIGEvVG9vbHMvQ2hhbmdlTG9nCisrKyBiL1Rvb2xzL0NoYW5nZUxvZwpA
QCAtMSwzICsxLDE4IEBACisyMDEzLTA5LTIwICBNYXJpbyBTYW5jaGV6IFByYWRhICA8bWFyaW8u
cHJhZGFAc2Ftc3VuZy5jb20+CisKKyAgICAgICAgW0dUS10gR1RLIGRvZXMgbm90IGV4cG9zZSBo
ZWFkaW5nIGxldmVsIGNvcnJlY3RseS4gV2FzOiBhY2Nlc3NpYmlsaXR5L2hlYWRpbmctbGV2ZWwu
aHRtbCBpcyBmYWlsaW5nCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVn
LmNnaT9pZD0xMDY5MjQKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKwor
ICAgICAgICBDb25zaWRlciBoZWFkaW5ncyBsZXZlbHMgYXMgdmFsdWVzIHRvIGJlIHJldHVybmVk
IGluIGludFZhbHVlKCkKKyAgICAgICAgYm90aCBpbiBEUlQgYW5kIFdLVFIsIHNvIHdlIGNhbiBz
aGFyZSBtb3JlIHRlc3RzIHdpdGggb3RoZXIgcG9ydHMuCisKKyAgICAgICAgKiBEdW1wUmVuZGVy
VHJlZS9hdGsvQWNjZXNzaWJpbGl0eVVJRWxlbWVudEF0ay5jcHA6CisgICAgICAgIChBY2Nlc3Np
YmlsaXR5VUlFbGVtZW50OjppbnRWYWx1ZSk6IENvbnNpZGVyIGhlYWRpbmdzIHRvby4KKyAgICAg
ICAgKiBXZWJLaXRUZXN0UnVubmVyL0luamVjdGVkQnVuZGxlL2F0ay9BY2Nlc3NpYmlsaXR5VUlF
bGVtZW50QXRrLmNwcDoKKyAgICAgICAgKFdUUjo6QWNjZXNzaWJpbGl0eVVJRWxlbWVudDo6aW50
VmFsdWUpOiBEaXR0by4KKwogMjAxMy0wOS0xNyAgWXVUZWggU2hlbiAgPHNoZW55dXRlQGhvdG1h
aWwuY29tPgogCiAgICAgICAgIEJyb3dzZXJNYXJzaGFsLmggYnVpbGQgZmFpbApkaWZmIC0tZ2l0
IGEvVG9vbHMvRHVtcFJlbmRlclRyZWUvYXRrL0FjY2Vzc2liaWxpdHlVSUVsZW1lbnRBdGsuY3Bw
IGIvVG9vbHMvRHVtcFJlbmRlclRyZWUvYXRrL0FjY2Vzc2liaWxpdHlVSUVsZW1lbnRBdGsuY3Bw
CmluZGV4IDdiNjcxYTguLjAxOGYzNjYgMTAwNjQ0Ci0tLSBhL1Rvb2xzL0R1bXBSZW5kZXJUcmVl
L2F0ay9BY2Nlc3NpYmlsaXR5VUlFbGVtZW50QXRrLmNwcAorKysgYi9Ub29scy9EdW1wUmVuZGVy
VHJlZS9hdGsvQWNjZXNzaWJpbGl0eVVJRWxlbWVudEF0ay5jcHAKQEAgLTYwMywxNSArNjAzLDI5
IEBAIEpTU3RyaW5nUmVmIEFjY2Vzc2liaWxpdHlVSUVsZW1lbnQ6Om9yaWVudGF0aW9uKCkgY29u
c3QKIAogZG91YmxlIEFjY2Vzc2liaWxpdHlVSUVsZW1lbnQ6OmludFZhbHVlKCkgY29uc3QKIHsK
LSAgICBHVmFsdWUgdmFsdWUgPSB7IDAsIHsgeyAwIH0gfSB9OwotCi0gICAgaWYgKCFBVEtfSVNf
VkFMVUUobV9lbGVtZW50KSkKKyAgICBpZiAoIW1fZWxlbWVudCB8fCAhQVRLX0lTX09CSkVDVCht
X2VsZW1lbnQpKQogICAgICAgICByZXR1cm4gMC4wZjsKIAotICAgIGF0a192YWx1ZV9nZXRfY3Vy
cmVudF92YWx1ZShBVEtfVkFMVUUobV9lbGVtZW50KSwgJnZhbHVlKTsKLSAgICBpZiAoIUdfVkFM
VUVfSE9MRFNfRkxPQVQoJnZhbHVlKSkKLSAgICAgICAgcmV0dXJuIDAuMGY7Ci0gICAgcmV0dXJu
IGdfdmFsdWVfZ2V0X2Zsb2F0KCZ2YWx1ZSk7CisgICAgaWYgKEFUS19JU19WQUxVRShtX2VsZW1l
bnQpKSB7CisgICAgICAgIEdWYWx1ZSB2YWx1ZSA9IHsgMCwgeyB7IDAgfSB9IH07CisgICAgICAg
IGF0a192YWx1ZV9nZXRfY3VycmVudF92YWx1ZShBVEtfVkFMVUUobV9lbGVtZW50KSwgJnZhbHVl
KTsKKyAgICAgICAgaWYgKCFHX1ZBTFVFX0hPTERTX0ZMT0FUKCZ2YWx1ZSkpCisgICAgICAgICAg
ICByZXR1cm4gMC4wZjsKKyAgICAgICAgcmV0dXJuIGdfdmFsdWVfZ2V0X2Zsb2F0KCZ2YWx1ZSk7
CisgICAgfQorCisgICAgLy8gQ29uc2lkZXIgaGVhZGluZ3MgYXMgYW4gc3BlY2lhbCBjYXNlIHdo
ZW4gcmV0dXJuaW5nIHRoZSAiaW50IHZhbHVlIiBvZgorICAgIC8vIGFuIEFjY2Vzc2liaWxpdHlV
SUVsZW1lbnQsIHNvIHdlIGNhbiByZXVzZSBzb21lIHRlc3RzIHRvIGNoZWNrIHRoZSBsZXZlbAor
ICAgIC8vIGJvdGggZm9yIEhUTUwgaGVhZGluZ3MgYW5kIG9iamVjdHMgd2l0aCB0aGUgYXJpYS1s
ZXZlbCBhdHRyaWJ1dGUuCisgICAgaWYgKGF0a19vYmplY3RfZ2V0X3JvbGUoQVRLX09CSkVDVCht
X2VsZW1lbnQpKSA9PSBBVEtfUk9MRV9IRUFESU5HKSB7CisgICAgICAgIFN0cmluZyBoZWFkaW5n
TGV2ZWwgPSBnZXRBdHRyaWJ1dGVTZXRWYWx1ZUZvcklkKEFUS19PQkpFQ1QobV9lbGVtZW50KSwg
ImxldmVsIik7CisgICAgICAgIGJvb2wgb2s7CisgICAgICAgIGRvdWJsZSBoZWFkaW5nTGV2ZWxW
YWx1ZSA9IGhlYWRpbmdMZXZlbC50b0RvdWJsZSgmb2spOworICAgICAgICBpZiAoIW9rKQorICAg
ICAgICAgICAgcmV0dXJuIDAuMGY7CisgICAgICAgIHJldHVybiBoZWFkaW5nTGV2ZWxWYWx1ZTsK
KyAgICB9CisgICAgcmV0dXJuIDAuMGY7CiB9CiAKIGRvdWJsZSBBY2Nlc3NpYmlsaXR5VUlFbGVt
ZW50OjptaW5WYWx1ZSgpCmRpZmYgLS1naXQgYS9Ub29scy9XZWJLaXRUZXN0UnVubmVyL0luamVj
dGVkQnVuZGxlL2F0ay9BY2Nlc3NpYmlsaXR5VUlFbGVtZW50QXRrLmNwcCBiL1Rvb2xzL1dlYktp
dFRlc3RSdW5uZXIvSW5qZWN0ZWRCdW5kbGUvYXRrL0FjY2Vzc2liaWxpdHlVSUVsZW1lbnRBdGsu
Y3BwCmluZGV4IDRhNGVlMDcuLmIxZGVlNmUgMTAwNjQ0Ci0tLSBhL1Rvb2xzL1dlYktpdFRlc3RS
dW5uZXIvSW5qZWN0ZWRCdW5kbGUvYXRrL0FjY2Vzc2liaWxpdHlVSUVsZW1lbnRBdGsuY3BwCisr
KyBiL1Rvb2xzL1dlYktpdFRlc3RSdW5uZXIvSW5qZWN0ZWRCdW5kbGUvYXRrL0FjY2Vzc2liaWxp
dHlVSUVsZW1lbnRBdGsuY3BwCkBAIC03NjYsMTIgKzc2NiwyNiBAQCBkb3VibGUgQWNjZXNzaWJp
bGl0eVVJRWxlbWVudDo6aW50VmFsdWUoKSBjb25zdAogICAgIGlmICghbV9lbGVtZW50IHx8ICFB
VEtfSVNfT0JKRUNUKG1fZWxlbWVudC5nZXQoKSkpCiAgICAgICAgIHJldHVybiAwLjBmOwogCi0g
ICAgR1ZhbHVlIHZhbHVlID0gR19WQUxVRV9JTklUOwotICAgIGF0a192YWx1ZV9nZXRfY3VycmVu
dF92YWx1ZShBVEtfVkFMVUUobV9lbGVtZW50LmdldCgpKSwgJnZhbHVlKTsKLSAgICBpZiAoIUdf
VkFMVUVfSE9MRFNfRkxPQVQoJnZhbHVlKSkKLSAgICAgICAgcmV0dXJuIDAuMGY7CisgICAgaWYg
KEFUS19JU19WQUxVRShtX2VsZW1lbnQuZ2V0KCkpKSB7CisgICAgICAgIEdWYWx1ZSB2YWx1ZSA9
IEdfVkFMVUVfSU5JVDsKKyAgICAgICAgYXRrX3ZhbHVlX2dldF9jdXJyZW50X3ZhbHVlKEFUS19W
QUxVRShtX2VsZW1lbnQuZ2V0KCkpLCAmdmFsdWUpOworICAgICAgICBpZiAoIUdfVkFMVUVfSE9M
RFNfRkxPQVQoJnZhbHVlKSkKKyAgICAgICAgICAgIHJldHVybiAwLjBmOworICAgICAgICByZXR1
cm4gZ192YWx1ZV9nZXRfZmxvYXQoJnZhbHVlKTsKKyAgICB9CiAKLSAgICByZXR1cm4gZ192YWx1
ZV9nZXRfZmxvYXQoJnZhbHVlKTsKKyAgICAvLyBDb25zaWRlciBoZWFkaW5ncyBhcyBhbiBzcGVj
aWFsIGNhc2Ugd2hlbiByZXR1cm5pbmcgdGhlICJpbnQgdmFsdWUiIG9mCisgICAgLy8gYW4gQWNj
ZXNzaWJpbGl0eVVJRWxlbWVudCwgc28gd2UgY2FuIHJldXNlIHNvbWUgdGVzdHMgdG8gY2hlY2sg
dGhlIGxldmVsCisgICAgLy8gYm90aCBmb3IgSFRNTCBoZWFkaW5ncyBhbmQgb2JqZWN0cyB3aXRo
IHRoZSBhcmlhLWxldmVsIGF0dHJpYnV0ZS4KKyAgICBpZiAoYXRrX29iamVjdF9nZXRfcm9sZShB
VEtfT0JKRUNUKG1fZWxlbWVudC5nZXQoKSkpID09IEFUS19ST0xFX0hFQURJTkcpIHsKKyAgICAg
ICAgU3RyaW5nIGhlYWRpbmdMZXZlbCA9IGdldEF0dHJpYnV0ZVNldFZhbHVlRm9ySWQoQVRLX09C
SkVDVChtX2VsZW1lbnQuZ2V0KCkpLCAibGV2ZWwiKTsKKyAgICAgICAgYm9vbCBvazsKKyAgICAg
ICAgZG91YmxlIGhlYWRpbmdMZXZlbFZhbHVlID0gaGVhZGluZ0xldmVsLnRvRG91YmxlKCZvayk7
CisgICAgICAgIGlmICghb2spCisgICAgICAgICAgICByZXR1cm4gMC4wZjsKKyAgICAgICAgcmV0
dXJuIGhlYWRpbmdMZXZlbFZhbHVlOworICAgIH0KKyAgICByZXR1cm4gMC4wZjsKIH0KIAogZG91
YmxlIEFjY2Vzc2liaWxpdHlVSUVsZW1lbnQ6Om1pblZhbHVlKCkKLS0gCjEuNy4xMC40Cgo=
</data>

          </attachment>
          <attachment
              isobsolete="1"
              ispatch="1"
              isprivate="0"
          >
            <attachid>212466</attachid>
            <date>2013-09-24 07:32:27 -0700</date>
            <delta_ts>2013-09-25 02:21:34 -0700</delta_ts>
            <desc>Patch proposal</desc>
            <filename>0001-GTK-GTK-does-not-expose-heading-level-correctly.-Was.patch</filename>
            <type>text/plain</type>
            <size>6539</size>
            <attacher name="Mario Sanchez Prada">mario</attacher>
            
              <data encoding="base64">RnJvbSBjZGY2MDBkZTQ3MDQ0Yjk5OTZiMGU0MTcyYTFlYmQzMTE2M2M1YThlIE1vbiBTZXAgMTcg
MDA6MDA6MDAgMjAwMQpGcm9tOiBNYXJpbyBTYW5jaGV6IFByYWRhIDxtYXJpby5wcmFkYUBzYW1z
dW5nLmNvbT4KRGF0ZTogVHVlLCAyNCBTZXAgMjAxMyAxNToyMjo0OCArMDEwMApTdWJqZWN0OiBb
UEFUQ0hdIFtHVEtdIEdUSyBkb2VzIG5vdCBleHBvc2UgaGVhZGluZyBsZXZlbCBjb3JyZWN0bHku
IFdhczoKIGFjY2Vzc2liaWxpdHkvaGVhZGluZy1sZXZlbC5odG1sIGlzIGZhaWxpbmcKIGh0dHBz
Oi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xMDY5MjQKCi0tLQogTGF5b3V0VGVz
dHMvQ2hhbmdlTG9nICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgfCAgIDExICsrKysrKysr
CiBMYXlvdXRUZXN0cy9wbGF0Zm9ybS9ndGsvVGVzdEV4cGVjdGF0aW9ucyAgICAgICAgICB8ICAg
IDIgLS0KIFRvb2xzL0NoYW5nZUxvZyAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAg
IHwgICAxNSArKysrKysrKysrKwogLi4uL2F0ay9BY2Nlc3NpYmlsaXR5VUlFbGVtZW50QXRrLmNw
cCAgICAgICAgICAgICAgfCAgIDI4ICsrKysrKysrKysrKysrKy0tLS0tCiAuLi4vYXRrL0FjY2Vz
c2liaWxpdHlVSUVsZW1lbnRBdGsuY3BwICAgICAgICAgICAgICB8ICAgMjQgKysrKysrKysrKysr
Ky0tLS0KIDUgZmlsZXMgY2hhbmdlZCwgNjYgaW5zZXJ0aW9ucygrKSwgMTQgZGVsZXRpb25zKC0p
CgpkaWZmIC0tZ2l0IGEvTGF5b3V0VGVzdHMvQ2hhbmdlTG9nIGIvTGF5b3V0VGVzdHMvQ2hhbmdl
TG9nCmluZGV4IDdhZDU5NTUuLjBjMGJlMjUgMTAwNjQ0Ci0tLSBhL0xheW91dFRlc3RzL0NoYW5n
ZUxvZworKysgYi9MYXlvdXRUZXN0cy9DaGFuZ2VMb2cKQEAgLTEsMyArMSwxNCBAQAorMjAxMy0w
OS0yNCAgTWFyaW8gU2FuY2hleiBQcmFkYSAgPG1hcmlvLnByYWRhQHNhbXN1bmcuY29tPgorCisg
ICAgICAgIFtHVEtdIEdUSyBkb2VzIG5vdCBleHBvc2UgaGVhZGluZyBsZXZlbCBjb3JyZWN0bHku
IFdhczogYWNjZXNzaWJpbGl0eS9oZWFkaW5nLWxldmVsLmh0bWwgaXMgZmFpbGluZworICAgICAg
ICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTA2OTI0CisKKyAgICAg
ICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgUmVtb3ZlZCBhY2Nlc2li
aWxpdHkvaGVhZGluZy1sZXZlbC5odG1sIGZyb20gZmFpbHVyZSBleHBlY3RhdGlvbnMuCisKKyAg
ICAgICAgKiBwbGF0Zm9ybS9ndGsvVGVzdEV4cGVjdGF0aW9uczogUmVtb3ZlZCB0ZXN0IG5vdyBw
YXNzaW5nLgorCiAyMDEzLTA5LTIyICBDb21taXQgUXVldWUgIDxjb21taXQtcXVldWVAd2Via2l0
Lm9yZz4KIAogICAgICAgICBVbnJldmlld2VkLCByb2xsaW5nIG91dCByMTU2MjU3LgpkaWZmIC0t
Z2l0IGEvTGF5b3V0VGVzdHMvcGxhdGZvcm0vZ3RrL1Rlc3RFeHBlY3RhdGlvbnMgYi9MYXlvdXRU
ZXN0cy9wbGF0Zm9ybS9ndGsvVGVzdEV4cGVjdGF0aW9ucwppbmRleCBmNWZiNjQzLi45MzlkNWJh
IDEwMDY0NAotLS0gYS9MYXlvdXRUZXN0cy9wbGF0Zm9ybS9ndGsvVGVzdEV4cGVjdGF0aW9ucwor
KysgYi9MYXlvdXRUZXN0cy9wbGF0Zm9ybS9ndGsvVGVzdEV4cGVjdGF0aW9ucwpAQCAtMTI0MCw4
ICsxMjQwLDYgQEAgd2Via2l0Lm9yZy9iLzg1NTIyIGh0dHAvdGVzdHMvc2VjdXJpdHkvc2FuZGJv
eGVkLWlmcmFtZS1mb3JtLXRvcC5odG1sIFsgU2tpcCBdCiAKIHdlYmtpdC5vcmcvYi8xMDYzMTYg
YWNjZXNzaWJpbGl0eS9yZW5kZXItY291bnRlci10ZXh0Lmh0bWwgWyBGYWlsdXJlIF0KIAotd2Vi
a2l0Lm9yZy9iLzEwNjkyNCBhY2Nlc3NpYmlsaXR5L2hlYWRpbmctbGV2ZWwuaHRtbCBbIEZhaWx1
cmUgXQotCiB3ZWJraXQub3JnL2IvMTAzOTI3IGh0dHAvdGVzdHMvdzNjL3dlYnBlcmYvc3VibWlz
c2lvbi9JbnRlbC9yZXNvdXJjZS10aW1pbmcvdGVzdF9yZXNvdXJjZV90aW1pbmdfY3Jvc3Nfb3Jp
Z2luX3Jlc291cmNlX3JlcXVlc3QuaHRtbCBbIEZhaWx1cmUgXQogd2Via2l0Lm9yZy9iLzEwMzky
NyBodHRwL3Rlc3RzL3czYy93ZWJwZXJmL3N1Ym1pc3Npb24vSW50ZWwvcmVzb3VyY2UtdGltaW5n
L3Rlc3RfcmVzb3VyY2VfdGltaW5nX3RpbWluZ19hbGxvd19jcm9zc19vcmlnaW5fcmVzb3VyY2Vf
cmVxdWVzdC5odG1sIFsgRmFpbHVyZSBdCiB3ZWJraXQub3JnL2IvMTAzOTI3IGh0dHAvdGVzdHMv
dzNjL3dlYnBlcmYvc3VibWlzc2lvbi9Hb29nbGUvcmVzb3VyY2UtdGltaW5nL2h0bWwvdGVzdF9y
ZXNvdXJjZV9hdHRyaWJ1dGVfb3JkZXIuaHRtbCBbIEZhaWx1cmUgXQpkaWZmIC0tZ2l0IGEvVG9v
bHMvQ2hhbmdlTG9nIGIvVG9vbHMvQ2hhbmdlTG9nCmluZGV4IDExMGEwMWIuLjRmYTc5M2MgMTAw
NjQ0Ci0tLSBhL1Rvb2xzL0NoYW5nZUxvZworKysgYi9Ub29scy9DaGFuZ2VMb2cKQEAgLTEsMyAr
MSwxOCBAQAorMjAxMy0wOS0yNCAgTWFyaW8gU2FuY2hleiBQcmFkYSAgPG1hcmlvLnByYWRhQHNh
bXN1bmcuY29tPgorCisgICAgICAgIFtHVEtdIEdUSyBkb2VzIG5vdCBleHBvc2UgaGVhZGluZyBs
ZXZlbCBjb3JyZWN0bHkuIFdhczogYWNjZXNzaWJpbGl0eS9oZWFkaW5nLWxldmVsLmh0bWwgaXMg
ZmFpbGluZworICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9
MTA2OTI0CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAg
Q29uc2lkZXIgaGVhZGluZ3MgbGV2ZWxzIGFzIHZhbHVlcyB0byBiZSByZXR1cm5lZCBpbiBpbnRW
YWx1ZSgpCisgICAgICAgIGJvdGggaW4gRFJUIGFuZCBXS1RSLCBzbyB3ZSBjYW4gc2hhcmUgbW9y
ZSB0ZXN0cyB3aXRoIG90aGVyIHBvcnRzLgorCisgICAgICAgICogRHVtcFJlbmRlclRyZWUvYXRr
L0FjY2Vzc2liaWxpdHlVSUVsZW1lbnRBdGsuY3BwOgorICAgICAgICAoQWNjZXNzaWJpbGl0eVVJ
RWxlbWVudDo6aW50VmFsdWUpOiBDb25zaWRlciBoZWFkaW5ncyB0b28uCisgICAgICAgICogV2Vi
S2l0VGVzdFJ1bm5lci9JbmplY3RlZEJ1bmRsZS9hdGsvQWNjZXNzaWJpbGl0eVVJRWxlbWVudEF0
ay5jcHA6CisgICAgICAgIChXVFI6OkFjY2Vzc2liaWxpdHlVSUVsZW1lbnQ6OmludFZhbHVlKTog
RGl0dG8uCisKIDIwMTMtMDktMjAgIE1hcmsgUm93ZSAgPG1yb3dlQGFwcGxlLmNvbT4KIAogICAg
ICAgICA8aHR0cHM6Ly93ZWJraXQub3JnL2IvOTAwOTA+IGJ1aWxkLXdlYmtpdCBzaG91bGQgdmVy
aWZ5IHRoYXQgeW91ciB0b29scyBhcmUgdXAtdG8tZGF0ZQpkaWZmIC0tZ2l0IGEvVG9vbHMvRHVt
cFJlbmRlclRyZWUvYXRrL0FjY2Vzc2liaWxpdHlVSUVsZW1lbnRBdGsuY3BwIGIvVG9vbHMvRHVt
cFJlbmRlclRyZWUvYXRrL0FjY2Vzc2liaWxpdHlVSUVsZW1lbnRBdGsuY3BwCmluZGV4IDU5ZTA3
NzguLjk5MTNmMjUgMTAwNjQ0Ci0tLSBhL1Rvb2xzL0R1bXBSZW5kZXJUcmVlL2F0ay9BY2Nlc3Np
YmlsaXR5VUlFbGVtZW50QXRrLmNwcAorKysgYi9Ub29scy9EdW1wUmVuZGVyVHJlZS9hdGsvQWNj
ZXNzaWJpbGl0eVVJRWxlbWVudEF0ay5jcHAKQEAgLTYxMSwxNSArNjExLDI5IEBAIEpTU3RyaW5n
UmVmIEFjY2Vzc2liaWxpdHlVSUVsZW1lbnQ6Om9yaWVudGF0aW9uKCkgY29uc3QKIAogZG91Ymxl
IEFjY2Vzc2liaWxpdHlVSUVsZW1lbnQ6OmludFZhbHVlKCkgY29uc3QKIHsKLSAgICBHVmFsdWUg
dmFsdWUgPSB7IDAsIHsgeyAwIH0gfSB9OwotCi0gICAgaWYgKCFBVEtfSVNfVkFMVUUobV9lbGVt
ZW50KSkKKyAgICBpZiAoIW1fZWxlbWVudCB8fCAhQVRLX0lTX09CSkVDVChtX2VsZW1lbnQpKQog
ICAgICAgICByZXR1cm4gMC4wZjsKIAotICAgIGF0a192YWx1ZV9nZXRfY3VycmVudF92YWx1ZShB
VEtfVkFMVUUobV9lbGVtZW50KSwgJnZhbHVlKTsKLSAgICBpZiAoIUdfVkFMVUVfSE9MRFNfRkxP
QVQoJnZhbHVlKSkKLSAgICAgICAgcmV0dXJuIDAuMGY7Ci0gICAgcmV0dXJuIGdfdmFsdWVfZ2V0
X2Zsb2F0KCZ2YWx1ZSk7CisgICAgaWYgKEFUS19JU19WQUxVRShtX2VsZW1lbnQpKSB7CisgICAg
ICAgIEdWYWx1ZSB2YWx1ZSA9IHsgMCwgeyB7IDAgfSB9IH07CisgICAgICAgIGF0a192YWx1ZV9n
ZXRfY3VycmVudF92YWx1ZShBVEtfVkFMVUUobV9lbGVtZW50KSwgJnZhbHVlKTsKKyAgICAgICAg
aWYgKCFHX1ZBTFVFX0hPTERTX0ZMT0FUKCZ2YWx1ZSkpCisgICAgICAgICAgICByZXR1cm4gMC4w
ZjsKKyAgICAgICAgcmV0dXJuIGdfdmFsdWVfZ2V0X2Zsb2F0KCZ2YWx1ZSk7CisgICAgfQorCisg
ICAgLy8gQ29uc2lkZXIgaGVhZGluZ3MgYXMgYW4gc3BlY2lhbCBjYXNlIHdoZW4gcmV0dXJuaW5n
IHRoZSAiaW50IHZhbHVlIiBvZgorICAgIC8vIGFuIEFjY2Vzc2liaWxpdHlVSUVsZW1lbnQsIHNv
IHdlIGNhbiByZXVzZSBzb21lIHRlc3RzIHRvIGNoZWNrIHRoZSBsZXZlbAorICAgIC8vIGJvdGgg
Zm9yIEhUTUwgaGVhZGluZ3MgYW5kIG9iamVjdHMgd2l0aCB0aGUgYXJpYS1sZXZlbCBhdHRyaWJ1
dGUuCisgICAgaWYgKGF0a19vYmplY3RfZ2V0X3JvbGUoQVRLX09CSkVDVChtX2VsZW1lbnQpKSA9
PSBBVEtfUk9MRV9IRUFESU5HKSB7CisgICAgICAgIFN0cmluZyBoZWFkaW5nTGV2ZWwgPSBnZXRB
dHRyaWJ1dGVTZXRWYWx1ZUZvcklkKEFUS19PQkpFQ1QobV9lbGVtZW50KSwgImxldmVsIik7Cisg
ICAgICAgIGJvb2wgb2s7CisgICAgICAgIGRvdWJsZSBoZWFkaW5nTGV2ZWxWYWx1ZSA9IGhlYWRp
bmdMZXZlbC50b0RvdWJsZSgmb2spOworICAgICAgICBpZiAoIW9rKQorICAgICAgICAgICAgcmV0
dXJuIDAuMGY7CisgICAgICAgIHJldHVybiBoZWFkaW5nTGV2ZWxWYWx1ZTsKKyAgICB9CisgICAg
cmV0dXJuIDAuMGY7CiB9CiAKIGRvdWJsZSBBY2Nlc3NpYmlsaXR5VUlFbGVtZW50OjptaW5WYWx1
ZSgpCmRpZmYgLS1naXQgYS9Ub29scy9XZWJLaXRUZXN0UnVubmVyL0luamVjdGVkQnVuZGxlL2F0
ay9BY2Nlc3NpYmlsaXR5VUlFbGVtZW50QXRrLmNwcCBiL1Rvb2xzL1dlYktpdFRlc3RSdW5uZXIv
SW5qZWN0ZWRCdW5kbGUvYXRrL0FjY2Vzc2liaWxpdHlVSUVsZW1lbnRBdGsuY3BwCmluZGV4IGUx
OGFkOTEuLmFkNDhiMGUgMTAwNjQ0Ci0tLSBhL1Rvb2xzL1dlYktpdFRlc3RSdW5uZXIvSW5qZWN0
ZWRCdW5kbGUvYXRrL0FjY2Vzc2liaWxpdHlVSUVsZW1lbnRBdGsuY3BwCisrKyBiL1Rvb2xzL1dl
YktpdFRlc3RSdW5uZXIvSW5qZWN0ZWRCdW5kbGUvYXRrL0FjY2Vzc2liaWxpdHlVSUVsZW1lbnRB
dGsuY3BwCkBAIC03ODIsMTIgKzc4MiwyNiBAQCBkb3VibGUgQWNjZXNzaWJpbGl0eVVJRWxlbWVu
dDo6aW50VmFsdWUoKSBjb25zdAogICAgIGlmICghbV9lbGVtZW50IHx8ICFBVEtfSVNfT0JKRUNU
KG1fZWxlbWVudC5nZXQoKSkpCiAgICAgICAgIHJldHVybiAwLjBmOwogCi0gICAgR1ZhbHVlIHZh
bHVlID0gR19WQUxVRV9JTklUOwotICAgIGF0a192YWx1ZV9nZXRfY3VycmVudF92YWx1ZShBVEtf
VkFMVUUobV9lbGVtZW50LmdldCgpKSwgJnZhbHVlKTsKLSAgICBpZiAoIUdfVkFMVUVfSE9MRFNf
RkxPQVQoJnZhbHVlKSkKLSAgICAgICAgcmV0dXJuIDAuMGY7CisgICAgaWYgKEFUS19JU19WQUxV
RShtX2VsZW1lbnQuZ2V0KCkpKSB7CisgICAgICAgIEdWYWx1ZSB2YWx1ZSA9IEdfVkFMVUVfSU5J
VDsKKyAgICAgICAgYXRrX3ZhbHVlX2dldF9jdXJyZW50X3ZhbHVlKEFUS19WQUxVRShtX2VsZW1l
bnQuZ2V0KCkpLCAmdmFsdWUpOworICAgICAgICBpZiAoIUdfVkFMVUVfSE9MRFNfRkxPQVQoJnZh
bHVlKSkKKyAgICAgICAgICAgIHJldHVybiAwLjBmOworICAgICAgICByZXR1cm4gZ192YWx1ZV9n
ZXRfZmxvYXQoJnZhbHVlKTsKKyAgICB9CiAKLSAgICByZXR1cm4gZ192YWx1ZV9nZXRfZmxvYXQo
JnZhbHVlKTsKKyAgICAvLyBDb25zaWRlciBoZWFkaW5ncyBhcyBhbiBzcGVjaWFsIGNhc2Ugd2hl
biByZXR1cm5pbmcgdGhlICJpbnQgdmFsdWUiIG9mCisgICAgLy8gYW4gQWNjZXNzaWJpbGl0eVVJ
RWxlbWVudCwgc28gd2UgY2FuIHJldXNlIHNvbWUgdGVzdHMgdG8gY2hlY2sgdGhlIGxldmVsCisg
ICAgLy8gYm90aCBmb3IgSFRNTCBoZWFkaW5ncyBhbmQgb2JqZWN0cyB3aXRoIHRoZSBhcmlhLWxl
dmVsIGF0dHJpYnV0ZS4KKyAgICBpZiAoYXRrX29iamVjdF9nZXRfcm9sZShBVEtfT0JKRUNUKG1f
ZWxlbWVudC5nZXQoKSkpID09IEFUS19ST0xFX0hFQURJTkcpIHsKKyAgICAgICAgU3RyaW5nIGhl
YWRpbmdMZXZlbCA9IGdldEF0dHJpYnV0ZVNldFZhbHVlRm9ySWQoQVRLX09CSkVDVChtX2VsZW1l
bnQuZ2V0KCkpLCAibGV2ZWwiKTsKKyAgICAgICAgYm9vbCBvazsKKyAgICAgICAgZG91YmxlIGhl
YWRpbmdMZXZlbFZhbHVlID0gaGVhZGluZ0xldmVsLnRvRG91YmxlKCZvayk7CisgICAgICAgIGlm
ICghb2spCisgICAgICAgICAgICByZXR1cm4gMC4wZjsKKyAgICAgICAgcmV0dXJuIGhlYWRpbmdM
ZXZlbFZhbHVlOworICAgIH0KKyAgICByZXR1cm4gMC4wZjsKIH0KIAogZG91YmxlIEFjY2Vzc2li
aWxpdHlVSUVsZW1lbnQ6Om1pblZhbHVlKCkKLS0gCjEuNy4xMC40Cgo=
</data>
<flag name="review"
          id="234700"
          type_id="1"
          status="-"
          setter="cfleizach"
    />
          </attachment>
          <attachment
              isobsolete="0"
              ispatch="1"
              isprivate="0"
          >
            <attachid>212545</attachid>
            <date>2013-09-25 02:21:34 -0700</date>
            <delta_ts>2013-09-27 09:14:11 -0700</delta_ts>
            <desc>Patch proposal</desc>
            <filename>0001-GTK-GTK-does-not-expose-heading-level-correctly.-Was.patch</filename>
            <type>text/plain</type>
            <size>7102</size>
            <attacher name="Mario Sanchez Prada">mario</attacher>
            
              <data encoding="base64">RnJvbSBlNzg5YzYyYWJiODYwZjc3MDMzNzcxNDdhMDk1NDY4MzMzM2UwY2M2IE1vbiBTZXAgMTcg
MDA6MDA6MDAgMjAwMQpGcm9tOiBNYXJpbyBTYW5jaGV6IFByYWRhIDxtYXJpby5wcmFkYUBzYW1z
dW5nLmNvbT4KRGF0ZTogV2VkLCAyNSBTZXAgMjAxMyAwOTo0OToyNiArMDEwMApTdWJqZWN0OiBb
UEFUQ0hdIFtHVEtdIEdUSyBkb2VzIG5vdCBleHBvc2UgaGVhZGluZyBsZXZlbCBjb3JyZWN0bHku
IFdhczoKIGFjY2Vzc2liaWxpdHkvaGVhZGluZy1sZXZlbC5odG1sIGlzIGZhaWxpbmcKIGh0dHBz
Oi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xMDY5MjQKClJldmlld2VkIGJ5IE5P
Qk9EWSAoT09QUyEpLgoKVG9vbHM6CgpDb25zaWRlciBoZWFkaW5ncyBsZXZlbHMgYXMgdmFsdWVz
IHRvIGJlIHJldHVybmVkIGluIGludFZhbHVlKCkKYm90aCBpbiBEUlQgYW5kIFdLVFIsIHNvIHdl
IGNhbiBzaGFyZSBtb3JlIHRlc3RzIHdpdGggb3RoZXIgcG9ydHMuCgoqIER1bXBSZW5kZXJUcmVl
L2F0ay9BY2Nlc3NpYmlsaXR5VUlFbGVtZW50QXRrLmNwcDoKKEFjY2Vzc2liaWxpdHlVSUVsZW1l
bnQ6OmludFZhbHVlKTogQ29uc2lkZXIgaGVhZGluZ3MgdG9vLgoqIFdlYktpdFRlc3RSdW5uZXIv
SW5qZWN0ZWRCdW5kbGUvYXRrL0FjY2Vzc2liaWxpdHlVSUVsZW1lbnRBdGsuY3BwOgooV1RSOjpB
Y2Nlc3NpYmlsaXR5VUlFbGVtZW50OjppbnRWYWx1ZSk6IERpdHRvLgoKTGF5b3V0VGVzdHM6CgpS
ZW1vdmVkIGFjY2VzaWJpbGl0eS9oZWFkaW5nLWxldmVsLmh0bWwgZnJvbSBmYWlsdXJlIGV4cGVj
dGF0aW9ucy4KCiogcGxhdGZvcm0vZ3RrL1Rlc3RFeHBlY3RhdGlvbnM6IFJlbW92ZWQgdGVzdCBu
b3cgcGFzc2luZy4KLS0tCiBMYXlvdXRUZXN0cy9DaGFuZ2VMb2cgICAgICAgICAgICAgICAgICAg
ICAgICAgICAgICB8ICAgMTEgKysrKysrKysKIExheW91dFRlc3RzL3BsYXRmb3JtL2d0ay9UZXN0
RXhwZWN0YXRpb25zICAgICAgICAgIHwgICAgMiAtLQogVG9vbHMvQ2hhbmdlTG9nICAgICAgICAg
ICAgICAgICAgICAgICAgICAgICAgICAgICAgfCAgIDE1ICsrKysrKysrKysrCiAuLi4vYXRrL0Fj
Y2Vzc2liaWxpdHlVSUVsZW1lbnRBdGsuY3BwICAgICAgICAgICAgICB8ICAgMjcgKysrKysrKysr
KysrKysrLS0tLS0KIC4uLi9hdGsvQWNjZXNzaWJpbGl0eVVJRWxlbWVudEF0ay5jcHAgICAgICAg
ICAgICAgIHwgICAyNSArKysrKysrKysrKysrLS0tLS0KIDUgZmlsZXMgY2hhbmdlZCwgNjUgaW5z
ZXJ0aW9ucygrKSwgMTUgZGVsZXRpb25zKC0pCgpkaWZmIC0tZ2l0IGEvTGF5b3V0VGVzdHMvQ2hh
bmdlTG9nIGIvTGF5b3V0VGVzdHMvQ2hhbmdlTG9nCmluZGV4IDdhZDU5NTUuLmQ4MWNlZGYgMTAw
NjQ0Ci0tLSBhL0xheW91dFRlc3RzL0NoYW5nZUxvZworKysgYi9MYXlvdXRUZXN0cy9DaGFuZ2VM
b2cKQEAgLTEsMyArMSwxNCBAQAorMjAxMy0wOS0yNSAgTWFyaW8gU2FuY2hleiBQcmFkYSAgPG1h
cmlvLnByYWRhQHNhbXN1bmcuY29tPgorCisgICAgICAgIFtHVEtdIEdUSyBkb2VzIG5vdCBleHBv
c2UgaGVhZGluZyBsZXZlbCBjb3JyZWN0bHkuIFdhczogYWNjZXNzaWJpbGl0eS9oZWFkaW5nLWxl
dmVsLmh0bWwgaXMgZmFpbGluZworICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93
X2J1Zy5jZ2k/aWQ9MTA2OTI0CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISku
CisKKyAgICAgICAgUmVtb3ZlZCBhY2Nlc2liaWxpdHkvaGVhZGluZy1sZXZlbC5odG1sIGZyb20g
ZmFpbHVyZSBleHBlY3RhdGlvbnMuCisKKyAgICAgICAgKiBwbGF0Zm9ybS9ndGsvVGVzdEV4cGVj
dGF0aW9uczogUmVtb3ZlZCB0ZXN0IG5vdyBwYXNzaW5nLgorCiAyMDEzLTA5LTIyICBDb21taXQg
UXVldWUgIDxjb21taXQtcXVldWVAd2Via2l0Lm9yZz4KIAogICAgICAgICBVbnJldmlld2VkLCBy
b2xsaW5nIG91dCByMTU2MjU3LgpkaWZmIC0tZ2l0IGEvTGF5b3V0VGVzdHMvcGxhdGZvcm0vZ3Rr
L1Rlc3RFeHBlY3RhdGlvbnMgYi9MYXlvdXRUZXN0cy9wbGF0Zm9ybS9ndGsvVGVzdEV4cGVjdGF0
aW9ucwppbmRleCBmNWZiNjQzLi45MzlkNWJhIDEwMDY0NAotLS0gYS9MYXlvdXRUZXN0cy9wbGF0
Zm9ybS9ndGsvVGVzdEV4cGVjdGF0aW9ucworKysgYi9MYXlvdXRUZXN0cy9wbGF0Zm9ybS9ndGsv
VGVzdEV4cGVjdGF0aW9ucwpAQCAtMTI0MCw4ICsxMjQwLDYgQEAgd2Via2l0Lm9yZy9iLzg1NTIy
IGh0dHAvdGVzdHMvc2VjdXJpdHkvc2FuZGJveGVkLWlmcmFtZS1mb3JtLXRvcC5odG1sIFsgU2tp
cCBdCiAKIHdlYmtpdC5vcmcvYi8xMDYzMTYgYWNjZXNzaWJpbGl0eS9yZW5kZXItY291bnRlci10
ZXh0Lmh0bWwgWyBGYWlsdXJlIF0KIAotd2Via2l0Lm9yZy9iLzEwNjkyNCBhY2Nlc3NpYmlsaXR5
L2hlYWRpbmctbGV2ZWwuaHRtbCBbIEZhaWx1cmUgXQotCiB3ZWJraXQub3JnL2IvMTAzOTI3IGh0
dHAvdGVzdHMvdzNjL3dlYnBlcmYvc3VibWlzc2lvbi9JbnRlbC9yZXNvdXJjZS10aW1pbmcvdGVz
dF9yZXNvdXJjZV90aW1pbmdfY3Jvc3Nfb3JpZ2luX3Jlc291cmNlX3JlcXVlc3QuaHRtbCBbIEZh
aWx1cmUgXQogd2Via2l0Lm9yZy9iLzEwMzkyNyBodHRwL3Rlc3RzL3czYy93ZWJwZXJmL3N1Ym1p
c3Npb24vSW50ZWwvcmVzb3VyY2UtdGltaW5nL3Rlc3RfcmVzb3VyY2VfdGltaW5nX3RpbWluZ19h
bGxvd19jcm9zc19vcmlnaW5fcmVzb3VyY2VfcmVxdWVzdC5odG1sIFsgRmFpbHVyZSBdCiB3ZWJr
aXQub3JnL2IvMTAzOTI3IGh0dHAvdGVzdHMvdzNjL3dlYnBlcmYvc3VibWlzc2lvbi9Hb29nbGUv
cmVzb3VyY2UtdGltaW5nL2h0bWwvdGVzdF9yZXNvdXJjZV9hdHRyaWJ1dGVfb3JkZXIuaHRtbCBb
IEZhaWx1cmUgXQpkaWZmIC0tZ2l0IGEvVG9vbHMvQ2hhbmdlTG9nIGIvVG9vbHMvQ2hhbmdlTG9n
CmluZGV4IDExMGEwMWIuLmQzMDAxNGYgMTAwNjQ0Ci0tLSBhL1Rvb2xzL0NoYW5nZUxvZworKysg
Yi9Ub29scy9DaGFuZ2VMb2cKQEAgLTEsMyArMSwxOCBAQAorMjAxMy0wOS0yNSAgTWFyaW8gU2Fu
Y2hleiBQcmFkYSAgPG1hcmlvLnByYWRhQHNhbXN1bmcuY29tPgorCisgICAgICAgIFtHVEtdIEdU
SyBkb2VzIG5vdCBleHBvc2UgaGVhZGluZyBsZXZlbCBjb3JyZWN0bHkuIFdhczogYWNjZXNzaWJp
bGl0eS9oZWFkaW5nLWxldmVsLmh0bWwgaXMgZmFpbGluZworICAgICAgICBodHRwczovL2J1Z3Mu
d2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTA2OTI0CisKKyAgICAgICAgUmV2aWV3ZWQgYnkg
Tk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgQ29uc2lkZXIgaGVhZGluZ3MgbGV2ZWxzIGFzIHZh
bHVlcyB0byBiZSByZXR1cm5lZCBpbiBpbnRWYWx1ZSgpCisgICAgICAgIGJvdGggaW4gRFJUIGFu
ZCBXS1RSLCBzbyB3ZSBjYW4gc2hhcmUgbW9yZSB0ZXN0cyB3aXRoIG90aGVyIHBvcnRzLgorCisg
ICAgICAgICogRHVtcFJlbmRlclRyZWUvYXRrL0FjY2Vzc2liaWxpdHlVSUVsZW1lbnRBdGsuY3Bw
OgorICAgICAgICAoQWNjZXNzaWJpbGl0eVVJRWxlbWVudDo6aW50VmFsdWUpOiBDb25zaWRlciBo
ZWFkaW5ncyB0b28uCisgICAgICAgICogV2ViS2l0VGVzdFJ1bm5lci9JbmplY3RlZEJ1bmRsZS9h
dGsvQWNjZXNzaWJpbGl0eVVJRWxlbWVudEF0ay5jcHA6CisgICAgICAgIChXVFI6OkFjY2Vzc2li
aWxpdHlVSUVsZW1lbnQ6OmludFZhbHVlKTogRGl0dG8uCisKIDIwMTMtMDktMjAgIE1hcmsgUm93
ZSAgPG1yb3dlQGFwcGxlLmNvbT4KIAogICAgICAgICA8aHR0cHM6Ly93ZWJraXQub3JnL2IvOTAw
OTA+IGJ1aWxkLXdlYmtpdCBzaG91bGQgdmVyaWZ5IHRoYXQgeW91ciB0b29scyBhcmUgdXAtdG8t
ZGF0ZQpkaWZmIC0tZ2l0IGEvVG9vbHMvRHVtcFJlbmRlclRyZWUvYXRrL0FjY2Vzc2liaWxpdHlV
SUVsZW1lbnRBdGsuY3BwIGIvVG9vbHMvRHVtcFJlbmRlclRyZWUvYXRrL0FjY2Vzc2liaWxpdHlV
SUVsZW1lbnRBdGsuY3BwCmluZGV4IDU5ZTA3NzguLjEzZDc3NDcgMTAwNjQ0Ci0tLSBhL1Rvb2xz
L0R1bXBSZW5kZXJUcmVlL2F0ay9BY2Nlc3NpYmlsaXR5VUlFbGVtZW50QXRrLmNwcAorKysgYi9U
b29scy9EdW1wUmVuZGVyVHJlZS9hdGsvQWNjZXNzaWJpbGl0eVVJRWxlbWVudEF0ay5jcHAKQEAg
LTYxMSwxNSArNjExLDI4IEBAIEpTU3RyaW5nUmVmIEFjY2Vzc2liaWxpdHlVSUVsZW1lbnQ6Om9y
aWVudGF0aW9uKCkgY29uc3QKIAogZG91YmxlIEFjY2Vzc2liaWxpdHlVSUVsZW1lbnQ6OmludFZh
bHVlKCkgY29uc3QKIHsKLSAgICBHVmFsdWUgdmFsdWUgPSB7IDAsIHsgeyAwIH0gfSB9OworICAg
IGlmICghbV9lbGVtZW50IHx8ICFBVEtfSVNfT0JKRUNUKG1fZWxlbWVudCkpCisgICAgICAgIHJl
dHVybiAwOwogCi0gICAgaWYgKCFBVEtfSVNfVkFMVUUobV9lbGVtZW50KSkKLSAgICAgICAgcmV0
dXJuIDAuMGY7CisgICAgaWYgKEFUS19JU19WQUxVRShtX2VsZW1lbnQpKSB7CisgICAgICAgIEdW
YWx1ZSB2YWx1ZSA9IEdfVkFMVUVfSU5JVDsKKyAgICAgICAgYXRrX3ZhbHVlX2dldF9jdXJyZW50
X3ZhbHVlKEFUS19WQUxVRShtX2VsZW1lbnQpLCAmdmFsdWUpOworICAgICAgICBpZiAoIUdfVkFM
VUVfSE9MRFNfRkxPQVQoJnZhbHVlKSkKKyAgICAgICAgICAgIHJldHVybiAwOworICAgICAgICBy
ZXR1cm4gZ192YWx1ZV9nZXRfZmxvYXQoJnZhbHVlKTsKKyAgICB9CiAKLSAgICBhdGtfdmFsdWVf
Z2V0X2N1cnJlbnRfdmFsdWUoQVRLX1ZBTFVFKG1fZWxlbWVudCksICZ2YWx1ZSk7Ci0gICAgaWYg
KCFHX1ZBTFVFX0hPTERTX0ZMT0FUKCZ2YWx1ZSkpCi0gICAgICAgIHJldHVybiAwLjBmOwotICAg
IHJldHVybiBnX3ZhbHVlX2dldF9mbG9hdCgmdmFsdWUpOworICAgIC8vIENvbnNpZGVyIGhlYWRp
bmdzIGFzIGFuIHNwZWNpYWwgY2FzZSB3aGVuIHJldHVybmluZyB0aGUgImludCB2YWx1ZSIgb2YK
KyAgICAvLyBhbiBBY2Nlc3NpYmlsaXR5VUlFbGVtZW50LCBzbyB3ZSBjYW4gcmV1c2Ugc29tZSB0
ZXN0cyB0byBjaGVjayB0aGUgbGV2ZWwKKyAgICAvLyBib3RoIGZvciBIVE1MIGhlYWRpbmdzIGFu
ZCBvYmplY3RzIHdpdGggdGhlIGFyaWEtbGV2ZWwgYXR0cmlidXRlLgorICAgIGlmIChhdGtfb2Jq
ZWN0X2dldF9yb2xlKEFUS19PQkpFQ1QobV9lbGVtZW50KSkgPT0gQVRLX1JPTEVfSEVBRElORykg
eworICAgICAgICBTdHJpbmcgaGVhZGluZ0xldmVsID0gZ2V0QXR0cmlidXRlU2V0VmFsdWVGb3JJ
ZChBVEtfT0JKRUNUKG1fZWxlbWVudCksICJsZXZlbCIpOworICAgICAgICBib29sIG9rOworICAg
ICAgICBkb3VibGUgaGVhZGluZ0xldmVsVmFsdWUgPSBoZWFkaW5nTGV2ZWwudG9Eb3VibGUoJm9r
KTsKKyAgICAgICAgaWYgKG9rKQorICAgICAgICAgICAgcmV0dXJuIGhlYWRpbmdMZXZlbFZhbHVl
OworICAgIH0KKyAgICByZXR1cm4gMDsKIH0KIAogZG91YmxlIEFjY2Vzc2liaWxpdHlVSUVsZW1l
bnQ6Om1pblZhbHVlKCkKZGlmZiAtLWdpdCBhL1Rvb2xzL1dlYktpdFRlc3RSdW5uZXIvSW5qZWN0
ZWRCdW5kbGUvYXRrL0FjY2Vzc2liaWxpdHlVSUVsZW1lbnRBdGsuY3BwIGIvVG9vbHMvV2ViS2l0
VGVzdFJ1bm5lci9JbmplY3RlZEJ1bmRsZS9hdGsvQWNjZXNzaWJpbGl0eVVJRWxlbWVudEF0ay5j
cHAKaW5kZXggZTE4YWQ5MS4uNmNmNzAwNyAxMDA2NDQKLS0tIGEvVG9vbHMvV2ViS2l0VGVzdFJ1
bm5lci9JbmplY3RlZEJ1bmRsZS9hdGsvQWNjZXNzaWJpbGl0eVVJRWxlbWVudEF0ay5jcHAKKysr
IGIvVG9vbHMvV2ViS2l0VGVzdFJ1bm5lci9JbmplY3RlZEJ1bmRsZS9hdGsvQWNjZXNzaWJpbGl0
eVVJRWxlbWVudEF0ay5jcHAKQEAgLTc4MCwxNCArNzgwLDI3IEBAIGRvdWJsZSBBY2Nlc3NpYmls
aXR5VUlFbGVtZW50OjpjbGlja1BvaW50WSgpCiBkb3VibGUgQWNjZXNzaWJpbGl0eVVJRWxlbWVu
dDo6aW50VmFsdWUoKSBjb25zdAogewogICAgIGlmICghbV9lbGVtZW50IHx8ICFBVEtfSVNfT0JK
RUNUKG1fZWxlbWVudC5nZXQoKSkpCi0gICAgICAgIHJldHVybiAwLjBmOworICAgICAgICByZXR1
cm4gMDsKIAotICAgIEdWYWx1ZSB2YWx1ZSA9IEdfVkFMVUVfSU5JVDsKLSAgICBhdGtfdmFsdWVf
Z2V0X2N1cnJlbnRfdmFsdWUoQVRLX1ZBTFVFKG1fZWxlbWVudC5nZXQoKSksICZ2YWx1ZSk7Ci0g
ICAgaWYgKCFHX1ZBTFVFX0hPTERTX0ZMT0FUKCZ2YWx1ZSkpCi0gICAgICAgIHJldHVybiAwLjBm
OworICAgIGlmIChBVEtfSVNfVkFMVUUobV9lbGVtZW50LmdldCgpKSkgeworICAgICAgICBHVmFs
dWUgdmFsdWUgPSBHX1ZBTFVFX0lOSVQ7CisgICAgICAgIGF0a192YWx1ZV9nZXRfY3VycmVudF92
YWx1ZShBVEtfVkFMVUUobV9lbGVtZW50LmdldCgpKSwgJnZhbHVlKTsKKyAgICAgICAgaWYgKCFH
X1ZBTFVFX0hPTERTX0ZMT0FUKCZ2YWx1ZSkpCisgICAgICAgICAgICByZXR1cm4gMDsKKyAgICAg
ICAgcmV0dXJuIGdfdmFsdWVfZ2V0X2Zsb2F0KCZ2YWx1ZSk7CisgICAgfQogCi0gICAgcmV0dXJu
IGdfdmFsdWVfZ2V0X2Zsb2F0KCZ2YWx1ZSk7CisgICAgLy8gQ29uc2lkZXIgaGVhZGluZ3MgYXMg
YW4gc3BlY2lhbCBjYXNlIHdoZW4gcmV0dXJuaW5nIHRoZSAiaW50IHZhbHVlIiBvZgorICAgIC8v
IGFuIEFjY2Vzc2liaWxpdHlVSUVsZW1lbnQsIHNvIHdlIGNhbiByZXVzZSBzb21lIHRlc3RzIHRv
IGNoZWNrIHRoZSBsZXZlbAorICAgIC8vIGJvdGggZm9yIEhUTUwgaGVhZGluZ3MgYW5kIG9iamVj
dHMgd2l0aCB0aGUgYXJpYS1sZXZlbCBhdHRyaWJ1dGUuCisgICAgaWYgKGF0a19vYmplY3RfZ2V0
X3JvbGUoQVRLX09CSkVDVChtX2VsZW1lbnQuZ2V0KCkpKSA9PSBBVEtfUk9MRV9IRUFESU5HKSB7
CisgICAgICAgIFN0cmluZyBoZWFkaW5nTGV2ZWwgPSBnZXRBdHRyaWJ1dGVTZXRWYWx1ZUZvcklk
KEFUS19PQkpFQ1QobV9lbGVtZW50LmdldCgpKSwgImxldmVsIik7CisgICAgICAgIGJvb2wgb2s7
CisgICAgICAgIGRvdWJsZSBoZWFkaW5nTGV2ZWxWYWx1ZSA9IGhlYWRpbmdMZXZlbC50b0RvdWJs
ZSgmb2spOworICAgICAgICBpZiAob2spCisgICAgICAgICAgICByZXR1cm4gaGVhZGluZ0xldmVs
VmFsdWU7CisgICAgfQorICAgIHJldHVybiAwOwogfQogCiBkb3VibGUgQWNjZXNzaWJpbGl0eVVJ
RWxlbWVudDo6bWluVmFsdWUoKQotLSAKMS43LjEwLjQKCg==
</data>
<flag name="review"
          id="234784"
          type_id="1"
          status="+"
          setter="cfleizach"
    />
          </attachment>
      

    </bug>

</bugzilla>