106436 2013-01-09 03:11:38 -0800 [GTK] Volume button should not be shown for videos without audio 2013-01-21 08:41:05 -0800 1 1 1 Unclassified WebKit WebKitGTK 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 0 halton.huo webkit-unassigned calvaris joone pnormand webkit.review.bot oldest_to_newest 803187 0 halton.huo 2013-01-09 03:11:38 -0800 With code trunk@138776, test LayoutTests/media/video-no-audio.html, the volume control will shown which is not expected. The same thing need to be done as EFL bug #97574. 803197 1 181888 halton.huo 2013-01-09 03:27:33 -0800 Created attachment 181888 Patch 805150 2 pnormand 2013-01-11 03:58:30 -0800 The controls are being reworked in bug 83869. Not sure this patch makes sense meanwhile. Xabier, what do you think? 805386 3 calvaris 2013-01-11 10:36:23 -0800 I talked to Jon Mccann and he says that the best would be showing the mute icon and show a "no audio" tooltip when hovering the button. So I guess this will be deeply reworked. I guess it will still take some time until we finish the controls, so we could push it as a temporary solution if it does not break any test, of course. 806062 4 halton.huo 2013-01-13 20:52:43 -0800 trunk@139575 still can not pass media/video-no-audio.html, while PASS with patch #181888. 806118 5 pnormand 2013-01-13 23:46:28 -0800 Are you sure no rebaseline of the test is needed? 807902 6 halton.huo 2013-01-15 18:30:32 -0800 (In reply to comment #5) > Are you sure no rebaseline of the test is needed? Just conflict on WebCore/GNUmakefile.list.am, easy to resolve. Actually with patch for bug 83869, the DumpRenderTree will crash when run-webkit-tests LayoutTests/media/video-no-audio.html, but PASS with run-launcher. 808088 7 calvaris 2013-01-15 23:41:27 -0800 (In reply to comment #6) > (In reply to comment #5) > > Are you sure no rebaseline of the test is needed? > Just conflict on WebCore/GNUmakefile.list.am, easy to resolve. > > Actually with patch for bug 83869, the DumpRenderTree will crash when run-webkit-tests LayoutTests/media/video-no-audio.html, but PASS with run-launcher. Patch for bug 83869 is under high development, so you cannot trust it yet. 808092 8 halton.huo 2013-01-15 23:51:18 -0800 (In reply to comment #7) > Patch for bug 83869 is under high development, so you cannot trust it yet. Yes, I know, Philippe's comment made me to try whether the working bug 83869 will fix or hide this bug. I just give my try. 811785 9 halton.huo 2013-01-20 21:54:31 -0800 Ping, anyone could continue review on it? 812196 10 181888 webkit.review.bot 2013-01-21 08:41:01 -0800 Comment on attachment 181888 Patch Clearing flags on attachment: 181888 Committed r140339: <http://trac.webkit.org/changeset/140339> 812197 11 webkit.review.bot 2013-01-21 08:41:05 -0800 All reviewed patches have been landed. Closing bug. 181888 2013-01-09 03:27:33 -0800 2013-01-21 08:41:01 -0800 Patch bug-106436-20130109192746.patch text/plain 2577 halton.huo U3VidmVyc2lvbiBSZXZpc2lvbjogMTM5MTYzCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggYTI3ODI1ZDc2YzE2N2U2 NjU1NWNjMzczN2I4MmVkMmY0ZTJlMjRlMC4uN2NhYzQyN2Y4ZWFmNWI1N2Y2YmRjNDQ4MzlhOTBh ZGM2MWE3ZWMzZiAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE5IEBACisyMDEzLTAxLTA5ICBIYWx0 b24gSHVvICA8aGFsdG9uLmh1b0BpbnRlbC5jb20+CisKKyAgICAgICAgW0dUS10gVm9sdW1lIGJ1 dHRvbiBzaG91bGQgbm90IGJlIHNob3duIGZvciB2aWRlb3Mgd2l0aG91dCBhdWRpbworICAgICAg ICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTA2NDM2CisKKyAgICAg ICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgVGhlIHZvbHVtZSBjb250 cm9sIGlzIG5vIGxvbmdlciBzaG93biBmb3IgdmlkZW9zIHdpdGggbm8gYXVkaW8uCisKKyAgICAg ICAgTm8gbmV3IHRlc3RzLCB0ZXN0ZWQgYnkgbWVkaWEvdmlkZW8tbm8tYXVkaW8uaHRtbC4KKwor ICAgICAgICAqIHBsYXRmb3JtL2d0ay9SZW5kZXJUaGVtZUd0ay5jcHA6CisgICAgICAgIChXZWJD b3JlOjpSZW5kZXJUaGVtZUd0azo6aGFzT3duRGlzYWJsZWRTdGF0ZUhhbmRsaW5nRm9yKToKKyAg ICAgICAgKFdlYkNvcmUpOgorICAgICAgICAqIHBsYXRmb3JtL2d0ay9SZW5kZXJUaGVtZUd0ay5o OgorCiAyMDEzLTAxLTA4ICBUb255IEdlbnRpbGNvcmUgIDx0b255Z0BjaHJvbWl1bS5vcmc+CiAK ICAgICAgICAgUmVtb3ZlIGEgZmV3IHVudXNlZCBpbmNsdWRlcyBmcm9tIEhUTUxUcmVlQnVpbGRl cgpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vZ3RrL1JlbmRlclRoZW1lR3Rr LmNwcCBiL1NvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL2d0ay9SZW5kZXJUaGVtZUd0ay5jcHAKaW5k ZXggMDBhZWEyNTY0ZjQ0YjRlNzBhZWI3YjAyNzM3MzJiYWYzYjU2ZTMzOC4uODFlYjVhYTk0Y2M0 YjhjNjJkMWJjY2EyM2RkMWVjNmEzNGRhNzA4NyAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUv cGxhdGZvcm0vZ3RrL1JlbmRlclRoZW1lR3RrLmNwcAorKysgYi9Tb3VyY2UvV2ViQ29yZS9wbGF0 Zm9ybS9ndGsvUmVuZGVyVGhlbWVHdGsuY3BwCkBAIC01MTMsNiArNTEzLDExIEBAIGJvb2wgUmVu ZGVyVGhlbWVHdGs6OnBhaW50TWVkaWFCdXR0b24oUmVuZGVyT2JqZWN0KiByZW5kZXJPYmplY3Qs IEdyYXBoaWNzQ29udGV4CiAgICAgcmV0dXJuIGZhbHNlOwogfQogCitib29sIFJlbmRlclRoZW1l R3RrOjpoYXNPd25EaXNhYmxlZFN0YXRlSGFuZGxpbmdGb3IoQ29udHJvbFBhcnQgcGFydCkgY29u c3QKK3sKKyAgICByZXR1cm4gKHBhcnQgIT0gTWVkaWFNdXRlQnV0dG9uUGFydCk7Cit9CisKIGJv b2wgUmVuZGVyVGhlbWVHdGs6OnBhaW50TWVkaWFGdWxsc2NyZWVuQnV0dG9uKFJlbmRlck9iamVj dCogcmVuZGVyT2JqZWN0LCBjb25zdCBQYWludEluZm8mIHBhaW50SW5mbywgY29uc3QgSW50UmVj dCYgcmVjdCkKIHsKICAgICByZXR1cm4gcGFpbnRNZWRpYUJ1dHRvbihyZW5kZXJPYmplY3QsIHBh aW50SW5mby5jb250ZXh0LCByZWN0LCBHVEtfU1RPQ0tfRlVMTFNDUkVFTik7CmRpZmYgLS1naXQg YS9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9ndGsvUmVuZGVyVGhlbWVHdGsuaCBiL1NvdXJjZS9X ZWJDb3JlL3BsYXRmb3JtL2d0ay9SZW5kZXJUaGVtZUd0ay5oCmluZGV4IGY1NDU4OGMxZWZlODgz Nzg1ZWE4Y2UzODIwODM2MzI4NWUwZjUwNzAuLjg1NjQ1ZjRmZWYzYTgxODA2ZDc5OTE2NzQzMjdm ZTMyZDYwNTllNzEgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL2d0ay9SZW5k ZXJUaGVtZUd0ay5oCisrKyBiL1NvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL2d0ay9SZW5kZXJUaGVt ZUd0ay5oCkBAIC0xNjIsNyArMTYyLDcgQEAgcHJvdGVjdGVkOgogICAgIHZvaWQgaW5pdE1lZGlh Q29sb3JzKCk7CiAgICAgdm9pZCBpbml0TWVkaWFCdXR0b25zKCk7CiAgICAgdm9pZCBhZGp1c3RN ZWRpYVNsaWRlclRodW1iU2l6ZShSZW5kZXJTdHlsZSopIGNvbnN0OwotICAgIHZpcnR1YWwgYm9v bCBoYXNPd25EaXNhYmxlZFN0YXRlSGFuZGxpbmdGb3IoQ29udHJvbFBhcnQpIGNvbnN0IHsgcmV0 dXJuIHRydWU7IH0KKyAgICB2aXJ0dWFsIGJvb2wgaGFzT3duRGlzYWJsZWRTdGF0ZUhhbmRsaW5n Rm9yKENvbnRyb2xQYXJ0KSBjb25zdDsKICAgICB2aXJ0dWFsIGJvb2wgcGFpbnRNZWRpYUZ1bGxz Y3JlZW5CdXR0b24oUmVuZGVyT2JqZWN0KiwgY29uc3QgUGFpbnRJbmZvJiwgY29uc3QgSW50UmVj dCYpOwogICAgIHZpcnR1YWwgYm9vbCBwYWludE1lZGlhUGxheUJ1dHRvbihSZW5kZXJPYmplY3Qq LCBjb25zdCBQYWludEluZm8mLCBjb25zdCBJbnRSZWN0Jik7CiAgICAgdmlydHVhbCBib29sIHBh aW50TWVkaWFNdXRlQnV0dG9uKFJlbmRlck9iamVjdCosIGNvbnN0IFBhaW50SW5mbyYsIGNvbnN0 IEludFJlY3QmKTsK