106341 2013-01-08 10:26:09 -0800 [GTK][WK2] accessibility/label-for-control-hittest.html is failing 2013-05-21 06:16:01 -0700 1 1 1 Unclassified WebKit WebKitGTK 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED Gtk, LayoutTestFailure P2 Normal --- 98347 1 zan webkit-unassigned commit-queue k.czech mario mrobinson oldest_to_newest 802340 0 zan 2013-01-08 10:26:09 -0800 The accessibility/label-for-control-hittest.html layout test is failing on GTK WK2 port. Here's the diff: --- /home/zan/Dev/webkit/webkit/WebKitBuild/Release/layout-test-results/accessibility/label-for-control-hittest-expected.txt +++ /home/zan/Dev/webkit/webkit/WebKitBuild/Release/layout-test-results/accessibility/label-for-control-hittest-actual.txt @@ -4,7 +4,7 @@ On success, you will see a series of "PASS" messages, followed by "TEST COMPLETE". -PASS control.role is 'AXRole: AXCheckBox' +FAIL control.role should be AXRole: AXCheckBox. Threw exception TypeError: 'null' is not an object (evaluating 'control.role') PASS successfullyParsed is true TEST COMPLETE 860139 1 194201 k.czech 2013-03-21 01:47:14 -0700 Created attachment 194201 Patch 860316 2 194201 mrobinson 2013-03-21 07:28:41 -0700 Comment on attachment 194201 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=194201&action=review > Tools/WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp:308 > + return AccessibilityUIElement::create(atk_component_ref_accessible_at_point(ATK_COMPONENT(m_element), x, y, ATK_XY_WINDOW)); Just noticed that AccessibilityUIElement seems to be leaking every single element that it wraps. That seems unrelated though. 878383 3 194201 mario 2013-04-19 05:31:29 -0700 Comment on attachment 194201 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=194201&action=review >> Tools/WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp:308 >> + return AccessibilityUIElement::create(atk_component_ref_accessible_at_point(ATK_COMPONENT(m_element), x, y, ATK_XY_WINDOW)); > > Just noticed that AccessibilityUIElement seems to be leaking every single element that it wraps. That seems unrelated though. Hmm... that's right. It seems we either would need to make PlatformUIElement a smart pointer or just to add some code in ~AccessibilityUIElement for ATK so we get rid of the reference to the AtkObject* owned by this class. 891684 4 202405 k.czech 2013-05-21 03:30:22 -0700 Created attachment 202405 Patch 891685 5 k.czech 2013-05-21 03:36:21 -0700 AccessibilityUIElement::create(atk_component_ref_accessible_at_point(ATK_COMPONENT(m_element), x, y, ATK_XY_WINDOW)); > > > > Just noticed that AccessibilityUIElement seems to be leaking every single element that it wraps. That seems unrelated though. > > Hmm... that's right. It seems we either would need to make PlatformUIElement a smart pointer or just to add some code in ~AccessibilityUIElement for ATK so we get rid of the reference to the AtkObject* owned by this class. Patch correcting this failure has been proposed ( see 112913) and already landed. 891739 6 202405 commit-queue 2013-05-21 06:15:58 -0700 Comment on attachment 202405 Patch Clearing flags on attachment: 202405 Committed r150439: <http://trac.webkit.org/changeset/150439> 891740 7 commit-queue 2013-05-21 06:16:01 -0700 All reviewed patches have been landed. Closing bug. 194201 2013-03-21 01:47:14 -0700 2013-05-21 03:30:22 -0700 Patch a11y-label-for-control-hittest.patch text/plain 3063 k.czech ZGlmZiAtLWdpdCBhL0xheW91dFRlc3RzL0NoYW5nZUxvZyBiL0xheW91dFRlc3RzL0NoYW5nZUxv ZwppbmRleCA5YjNiZGQ0Li5hNTY0ZGU2IDEwMDY0NAotLS0gYS9MYXlvdXRUZXN0cy9DaGFuZ2VM b2cKKysrIGIvTGF5b3V0VGVzdHMvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTUgQEAKKzIwMTMtMDMt MjEgIEtyenlzenRvZiBDemVjaCAgPGsuY3plY2hAc2Ftc3VuZy5jb20+CisKKyAgICAgICAgW0dU S11bV0syXSBhY2Nlc3NpYmlsaXR5L2xhYmVsLWZvci1jb250cm9sLWhpdHRlc3QuaHRtbCBpcyBm YWlsaW5nCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0x MDYzNDEKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBG aXhpbmcgZmFpbGluZyB0ZXN0LiBUaGUgcmVhc29uIG9mIGZhaWx1cmUgaXMgbWlzc2luZworICAg ICAgICBwb3NzaWJpbGl0eSBvZiBnZXR0aW5nIGFjY2Vzc2liaWxpdHkgb2JqZWN0IGF0IGV4YWN0 IHBvc2l0aW9uLgorCisgICAgICAgICogcGxhdGZvcm0vZ3RrLXdrMi9UZXN0RXhwZWN0YXRpb25z OgorCiAyMDEzLTAzLTIwICBaZW5vIEFsYmlzc2VyICA8emVub0B3ZWJraXQub3JnPgogCiAgICAg ICAgIFtRdF0gVW5yZXZpZXdlZCByZWJhc2VsaW5pbmcgYWZ0ZXIgcjE0NjIwNi4KZGlmZiAtLWdp dCBhL0xheW91dFRlc3RzL3BsYXRmb3JtL2d0ay13azIvVGVzdEV4cGVjdGF0aW9ucyBiL0xheW91 dFRlc3RzL3BsYXRmb3JtL2d0ay13azIvVGVzdEV4cGVjdGF0aW9ucwppbmRleCA2N2Y1MzBmLi42 NDcyMWIxIDEwMDY0NAotLS0gYS9MYXlvdXRUZXN0cy9wbGF0Zm9ybS9ndGstd2syL1Rlc3RFeHBl Y3RhdGlvbnMKKysrIGIvTGF5b3V0VGVzdHMvcGxhdGZvcm0vZ3RrLXdrMi9UZXN0RXhwZWN0YXRp b25zCkBAIC0zMDMsNyArMzAzLDYgQEAgd2Via2l0Lm9yZy9iLzEwNjMzNiBhY2Nlc3NpYmlsaXR5 L2FyaWEtZGVzY3JpYmVkYnktb24taW5wdXQuaHRtbCBbIEZhaWx1cmUgXQogd2Via2l0Lm9yZy9i LzEwNjMzNyBhY2Nlc3NpYmlsaXR5L2FyaWEtaGVscC5odG1sIFsgRmFpbHVyZSBdCiB3ZWJraXQu b3JnL2IvMTA2MzM4IGFjY2Vzc2liaWxpdHkvYXJpYS1oaWRkZW4tdXBkYXRlcy1hbGxkZXNjZW5k YW50cy5odG1sIFsgRmFpbHVyZSBdCiB3ZWJraXQub3JnL2IvMTA2MzQwIGFjY2Vzc2liaWxpdHkv aW1nLWZhbGxzYmFjay10by10aXRsZS5odG1sIFsgRmFpbHVyZSBdCi13ZWJraXQub3JnL2IvMTA2 MzQxIGFjY2Vzc2liaWxpdHkvbGFiZWwtZm9yLWNvbnRyb2wtaGl0dGVzdC5odG1sIFsgRmFpbHVy ZSBdCiB3ZWJraXQub3JnL2IvMTA2MzQyIGFjY2Vzc2liaWxpdHkvbGFuZ3VhZ2UtYXR0cmlidXRl Lmh0bWwgWyBGYWlsdXJlIF0KIHdlYmtpdC5vcmcvYi8xMDYzNDMgYWNjZXNzaWJpbGl0eS9sb2Fk aW5nLWlmcmFtZS1zZW5kcy1ub3RpZmljYXRpb24uaHRtbCBbIEZhaWx1cmUgXQogd2Via2l0Lm9y Zy9iLzEwNjM0NCBhY2Nlc3NpYmlsaXR5L3BsYWNlaG9sZGVyLmh0bWwgWyBGYWlsdXJlIF0KZGlm ZiAtLWdpdCBhL1Rvb2xzL0NoYW5nZUxvZyBiL1Rvb2xzL0NoYW5nZUxvZwppbmRleCA4ZDY3Zjdi Li5iNGFjYTA2IDEwMDY0NAotLS0gYS9Ub29scy9DaGFuZ2VMb2cKKysrIGIvVG9vbHMvQ2hhbmdl TG9nCkBAIC0xLDMgKzEsMTUgQEAKKzIwMTMtMDMtMjEgIEtyenlzenRvZiBDemVjaCAgPGsuY3pl Y2hAc2Ftc3VuZy5jb20+CisKKyAgICAgICAgW0dUS11bV0syXSBhY2Nlc3NpYmlsaXR5L2xhYmVs LWZvci1jb250cm9sLWhpdHRlc3QuaHRtbCBpcyBmYWlsaW5nCisgICAgICAgIGh0dHBzOi8vYnVn cy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xMDYzNDEKKworICAgICAgICBSZXZpZXdlZCBi eSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBBZGRzIHN1cHBvcnQgZm9yIHJldHJpZXZpbmcg YWNjZXNzaWJpbGl0eSBlbGVtZW50IGF0IGV4YWN0IHBvaW50LgorCisgICAgICAgICogV2ViS2l0 VGVzdFJ1bm5lci9JbmplY3RlZEJ1bmRsZS9hdGsvQWNjZXNzaWJpbGl0eVVJRWxlbWVudEF0ay5j cHA6CisgICAgICAgIChXVFI6OkFjY2Vzc2liaWxpdHlVSUVsZW1lbnQ6OmVsZW1lbnRBdFBvaW50 KToKKwogMjAxMy0wMy0yMCAgS3J6eXN6dG9mIEN6ZWNoICA8ay5jemVjaEBzYW1zdW5nLmNvbT4K IAogICAgICAgICBbR1RLXSBhY2Nlc3NpYmlsaXR5L2FyaWEtc2Nyb2xsYmFyLXJvbGUuaHRtbCBp cyBmYWlsaW5nCmRpZmYgLS1naXQgYS9Ub29scy9XZWJLaXRUZXN0UnVubmVyL0luamVjdGVkQnVu ZGxlL2F0ay9BY2Nlc3NpYmlsaXR5VUlFbGVtZW50QXRrLmNwcCBiL1Rvb2xzL1dlYktpdFRlc3RS dW5uZXIvSW5qZWN0ZWRCdW5kbGUvYXRrL0FjY2Vzc2liaWxpdHlVSUVsZW1lbnRBdGsuY3BwCmlu ZGV4IDM2MWQxMWIuLjk3YjA0MTggMTAwNjQ0Ci0tLSBhL1Rvb2xzL1dlYktpdFRlc3RSdW5uZXIv SW5qZWN0ZWRCdW5kbGUvYXRrL0FjY2Vzc2liaWxpdHlVSUVsZW1lbnRBdGsuY3BwCisrKyBiL1Rv b2xzL1dlYktpdFRlc3RSdW5uZXIvSW5qZWN0ZWRCdW5kbGUvYXRrL0FjY2Vzc2liaWxpdHlVSUVs ZW1lbnRBdGsuY3BwCkBAIC0zMDIsOCArMzAyLDEwIEBAIGludCBBY2Nlc3NpYmlsaXR5VUlFbGVt ZW50OjpjaGlsZHJlbkNvdW50KCkKIAogUGFzc1JlZlB0cjxBY2Nlc3NpYmlsaXR5VUlFbGVtZW50 PiBBY2Nlc3NpYmlsaXR5VUlFbGVtZW50OjplbGVtZW50QXRQb2ludChpbnQgeCwgaW50IHkpCiB7 Ci0gICAgLy8gRklYTUU6IGltcGxlbWVudAotICAgIHJldHVybiAwOworICAgIGlmICghbV9lbGVt ZW50IHx8ICFBVEtfSVNfT0JKRUNUKG1fZWxlbWVudCkpCisgICAgICAgIHJldHVybiAwOworCisg ICAgcmV0dXJuIEFjY2Vzc2liaWxpdHlVSUVsZW1lbnQ6OmNyZWF0ZShhdGtfY29tcG9uZW50X3Jl Zl9hY2Nlc3NpYmxlX2F0X3BvaW50KEFUS19DT01QT05FTlQobV9lbGVtZW50KSwgeCwgeSwgQVRL X1hZX1dJTkRPVykpOwogfQogCiB1bnNpZ25lZCBBY2Nlc3NpYmlsaXR5VUlFbGVtZW50OjppbmRl eE9mQ2hpbGQoQWNjZXNzaWJpbGl0eVVJRWxlbWVudCogZWxlbWVudCkK 202405 2013-05-21 03:30:22 -0700 2013-05-21 06:15:58 -0700 Patch a11y-label-for-control-hittest.patch text/plain 3261 k.czech ZGlmZiAtLWdpdCBhL0xheW91dFRlc3RzL0NoYW5nZUxvZyBiL0xheW91dFRlc3RzL0NoYW5nZUxv ZwppbmRleCBlOGZiNzRmLi44ZTg3NmY3IDEwMDY0NAotLS0gYS9MYXlvdXRUZXN0cy9DaGFuZ2VM b2cKKysrIGIvTGF5b3V0VGVzdHMvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTUgQEAKKzIwMTMtMDUt MjEgIEtyenlzenRvZiBDemVjaCAgPGsuY3plY2hAc2Ftc3VuZy5jb20+CisKKyAgICAgICAgW0dU S11bV0syXSBhY2Nlc3NpYmlsaXR5L2xhYmVsLWZvci1jb250cm9sLWhpdHRlc3QuaHRtbCBpcyBm YWlsaW5nCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0x MDYzNDEKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBG aXhpbmcgZmFpbGluZyB0ZXN0LiBUaGUgcmVhc29uIG9mIGZhaWx1cmUgaXMgbWlzc2luZworICAg ICAgICBwb3NzaWJpbGl0eSBvZiBnZXR0aW5nIGFjY2Vzc2liaWxpdHkgb2JqZWN0IGF0IGV4YWN0 IHBvc2l0aW9uLiAKKworICAgICAgICAqIHBsYXRmb3JtL2d0ay13azIvVGVzdEV4cGVjdGF0aW9u czoKKwogMjAxMy0wNS0yMSAgUnlvc3VrZSBOaXdhICA8cm5pd2FAd2Via2l0Lm9yZz4KIAogICAg ICAgICBbTWFjXSBzdmcvYmF0aWsvcGFpbnRzL3BhdHRlcm5SZWdpb25zLXBvc2l0aW9uZWQtb2Jq ZWN0cy5zdmcgaXMgZmxha3kKZGlmZiAtLWdpdCBhL0xheW91dFRlc3RzL3BsYXRmb3JtL2d0ay13 azIvVGVzdEV4cGVjdGF0aW9ucyBiL0xheW91dFRlc3RzL3BsYXRmb3JtL2d0ay13azIvVGVzdEV4 cGVjdGF0aW9ucwppbmRleCBjZmNmYjdkLi42ODQ1MmNlIDEwMDY0NAotLS0gYS9MYXlvdXRUZXN0 cy9wbGF0Zm9ybS9ndGstd2syL1Rlc3RFeHBlY3RhdGlvbnMKKysrIGIvTGF5b3V0VGVzdHMvcGxh dGZvcm0vZ3RrLXdrMi9UZXN0RXhwZWN0YXRpb25zCkBAIC0zMDMsNyArMzAzLDYgQEAgd2Via2l0 Lm9yZy9iLzEwNjMzNiBhY2Nlc3NpYmlsaXR5L2FyaWEtZGVzY3JpYmVkYnktb24taW5wdXQuaHRt bCBbIEZhaWx1cmUgXQogd2Via2l0Lm9yZy9iLzEwNjMzNyBhY2Nlc3NpYmlsaXR5L2FyaWEtaGVs cC5odG1sIFsgRmFpbHVyZSBdCiB3ZWJraXQub3JnL2IvMTA2MzM4IGFjY2Vzc2liaWxpdHkvYXJp YS1oaWRkZW4tdXBkYXRlcy1hbGxkZXNjZW5kYW50cy5odG1sIFsgRmFpbHVyZSBdCiB3ZWJraXQu b3JnL2IvMTA2MzQwIGFjY2Vzc2liaWxpdHkvaW1nLWZhbGxzYmFjay10by10aXRsZS5odG1sIFsg RmFpbHVyZSBdCi13ZWJraXQub3JnL2IvMTA2MzQxIGFjY2Vzc2liaWxpdHkvbGFiZWwtZm9yLWNv bnRyb2wtaGl0dGVzdC5odG1sIFsgRmFpbHVyZSBdCiB3ZWJraXQub3JnL2IvMTA2MzQzIGFjY2Vz c2liaWxpdHkvbG9hZGluZy1pZnJhbWUtc2VuZHMtbm90aWZpY2F0aW9uLmh0bWwgWyBGYWlsdXJl IF0KIHdlYmtpdC5vcmcvYi8xMDYzNDQgYWNjZXNzaWJpbGl0eS9wbGFjZWhvbGRlci5odG1sIFsg RmFpbHVyZSBdCiB3ZWJraXQub3JnL2IvMTA2MzQ2IGFjY2Vzc2liaWxpdHkvc3ZnLXJlbW90ZS1l bGVtZW50Lmh0bWwgWyBUaW1lb3V0IF0KZGlmZiAtLWdpdCBhL1Rvb2xzL0NoYW5nZUxvZyBiL1Rv b2xzL0NoYW5nZUxvZwppbmRleCAwN2Y2ZTEyLi5iMTIzODRjIDEwMDY0NAotLS0gYS9Ub29scy9D aGFuZ2VMb2cKKysrIGIvVG9vbHMvQ2hhbmdlTG9nCkBAIC0xLDUgKzEsMTcgQEAKIDIwMTMtMDUt MjEgIEtyenlzenRvZiBDemVjaCAgPGsuY3plY2hAc2Ftc3VuZy5jb20+CiAKKyAgICAgICAgW0dU S11bV0syXSBhY2Nlc3NpYmlsaXR5L2xhYmVsLWZvci1jb250cm9sLWhpdHRlc3QuaHRtbCBpcyBm YWlsaW5nCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0x MDYzNDEKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBB ZGRzIHN1cHBvcnQgZm9yIHJldHJpZXZpbmcgYWNjZXNzaWJpbGl0eSBlbGVtZW50IGF0IGV4YWN0 IHBvaW50LgorCisgICAgICAgICogV2ViS2l0VGVzdFJ1bm5lci9JbmplY3RlZEJ1bmRsZS9hdGsv QWNjZXNzaWJpbGl0eVVJRWxlbWVudEF0ay5jcHA6CisgICAgICAgIChXVFI6OkFjY2Vzc2liaWxp dHlVSUVsZW1lbnQ6OmVsZW1lbnRBdFBvaW50KToKKworMjAxMy0wNS0yMSAgS3J6eXN6dG9mIEN6 ZWNoICA8ay5jemVjaEBzYW1zdW5nLmNvbT4KKwogICAgICAgICBbQVRLXSBbV2ViS2l0Ml0gQWNj ZXNzaWJpbGl0eVVJRWxlbWVudCBvZnRlbiBsZWFrcyBpdHMgQXRrT2JqZWN0CiAgICAgICAgIGh0 dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xMTI5MTMKIApkaWZmIC0tZ2l0 IGEvVG9vbHMvV2ViS2l0VGVzdFJ1bm5lci9JbmplY3RlZEJ1bmRsZS9hdGsvQWNjZXNzaWJpbGl0 eVVJRWxlbWVudEF0ay5jcHAgYi9Ub29scy9XZWJLaXRUZXN0UnVubmVyL0luamVjdGVkQnVuZGxl L2F0ay9BY2Nlc3NpYmlsaXR5VUlFbGVtZW50QXRrLmNwcAppbmRleCBjOTBlYTBmLi42MjU2MTdm IDEwMDY0NAotLS0gYS9Ub29scy9XZWJLaXRUZXN0UnVubmVyL0luamVjdGVkQnVuZGxlL2F0ay9B Y2Nlc3NpYmlsaXR5VUlFbGVtZW50QXRrLmNwcAorKysgYi9Ub29scy9XZWJLaXRUZXN0UnVubmVy L0luamVjdGVkQnVuZGxlL2F0ay9BY2Nlc3NpYmlsaXR5VUlFbGVtZW50QXRrLmNwcApAQCAtMzE2 LDggKzMxNiwxMSBAQCBpbnQgQWNjZXNzaWJpbGl0eVVJRWxlbWVudDo6Y2hpbGRyZW5Db3VudCgp CiAKIFBhc3NSZWZQdHI8QWNjZXNzaWJpbGl0eVVJRWxlbWVudD4gQWNjZXNzaWJpbGl0eVVJRWxl bWVudDo6ZWxlbWVudEF0UG9pbnQoaW50IHgsIGludCB5KQogewotICAgIC8vIEZJWE1FOiBpbXBs ZW1lbnQKLSAgICByZXR1cm4gMDsKKyAgICBpZiAoIW1fZWxlbWVudCB8fCAhQVRLX0lTX09CSkVD VChtX2VsZW1lbnQuZ2V0KCkpKQorICAgICAgICByZXR1cm4gMDsKKworICAgIEdSZWZQdHI8QXRr T2JqZWN0PiBvYmplY3RBdFBvaW50ID0gYWRvcHRHUmVmKGF0a19jb21wb25lbnRfcmVmX2FjY2Vz c2libGVfYXRfcG9pbnQoQVRLX0NPTVBPTkVOVChtX2VsZW1lbnQuZ2V0KCkpLCB4LCB5LCBBVEtf WFlfV0lORE9XKSk7CisgICAgcmV0dXJuIG9iamVjdEF0UG9pbnQgPyBBY2Nlc3NpYmlsaXR5VUlF bGVtZW50OjpjcmVhdGUob2JqZWN0QXRQb2ludC5nZXQoKSkgOiAwOwogfQogCiB1bnNpZ25lZCBB Y2Nlc3NpYmlsaXR5VUlFbGVtZW50OjppbmRleE9mQ2hpbGQoQWNjZXNzaWJpbGl0eVVJRWxlbWVu dCogZWxlbWVudCkK