106182 2013-01-05 11:07:10 -0800 Regression(r138786): Causes webaudio tests to crash 2013-01-07 05:30:05 -0800 1 1 1 Unclassified WebKit WebCore Misc. 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 105293 1 cdumez cdumez d-r eric.carlson feature-media-reviews mrobinson pnormand webkit.review.bot oldest_to_newest 800933 0 cdumez 2013-01-05 11:07:10 -0800 <http://trac.webkit.org/changeset/138786> is causing webaudio tests to crash when using gstreamer 0.10.36: crash log for WebProcess (pid <unknown>): STDOUT: Timed out waiting for initial response from web process STDERR: #PROCESS UNRESPONSIVE - WebProcess Tests failing: http://build.webkit.org/results/EFL%20Linux%2064-bit%20Debug%20WK2/r138834%20%287688%29/results.html 800986 1 cdumez 2013-01-05 13:37:23 -0800 backtrace: http://pastebin.com/TB3mKWeW 800989 2 cdumez 2013-01-05 13:46:05 -0800 GST_DEBUG=webkit*:5 trace crash log for WebProcess (pid <unknown>): STDOUT: Timed out waiting for initial response from web process STDERR: 0:00:02.940318621 ^[[333m 4184^[[00m 0x102c990 ^[[36mDEBUG ^[[00m ^[[00m webkitwebaudiosrc /home/chris/unencrypted/WebKit/Source/WebCore/platform/audio/gstreamer/WebKitWebAudioSourceGStreamer.cpp:430:webKitWebAudioSrcChangeState:<webkitwebaudiosrc0>^[[00m PLAYING->PAUSED STDERR: #PROCESS UNRESPONSIVE - WebProcess 800990 3 cdumez 2013-01-05 13:51:35 -0800 Better backtrace with gstreamer debug symbols: http://pastebin.com/naBeKqHi 800992 4 181445 cdumez 2013-01-05 14:26:44 -0800 Created attachment 181445 Patch I found the part of the patch that caused the regression. I'm proposing a partial revert since the part in question does not seem essential. 800994 5 cdumez 2013-01-05 14:46:12 -0800 Of course, feel free to reassign and make a proper fix if you prefer not to revert this part. I am also happy to test patches if needed. 801061 6 pnormand 2013-01-06 01:59:06 -0800 I don't have time to test the patch now but if it works with gst 1.0 I'd be fine marking it r+. Those changes were made based on the gst 1.0 docs of gstbasesrc IIRC so if the revert doesn't work with 1.0 you can use ifdefs. The test timeouts were due to the source element never going to PLAYING BTW, maybe the ChangeLog can mention that. Thanks! 801062 7 cdumez 2013-01-06 02:22:49 -0800 (In reply to comment #6) > I don't have time to test the patch now but if it works with gst 1.0 I'd be fine marking it r+. > > Those changes were made based on the gst 1.0 docs of gstbasesrc IIRC so if the revert doesn't work with 1.0 you can use ifdefs. > > The test timeouts were due to the source element never going to PLAYING BTW, maybe the ChangeLog can mention that. Thanks! I haven't tested with gstreamer 1.0. It would be good if someone using GTK port could. I'll update the Changelog. 801063 8 181455 cdumez 2013-01-06 02:28:18 -0800 Created attachment 181455 Patch Update Changelog. 801076 9 181461 cdumez 2013-01-06 09:30:20 -0800 Created attachment 181461 Patch Update Changelog again. As it turns out, the regression does not affect gstreamer 0.10.x only. I have built webkitgtk with web audio support on and I can reproduce the same issue (unresponsive WebProcess). My patch works fine on webkitgtk / gstreamer 1.0 and webkitefl / gstreamer 0.10. 801203 10 cdumez 2013-01-07 01:15:16 -0800 Temporarily skipping those test cases for WK2 EFL until this regression is fixed: http://trac.webkit.org/changeset/138930 801243 11 181461 cdumez 2013-01-07 05:23:25 -0800 Comment on attachment 181461 Patch Clearing cq for now. I'll update the patch to unskip the test cases. 801245 12 cdumez 2013-01-07 05:27:46 -0800 Committed r138935: <http://trac.webkit.org/changeset/138935> 181445 2013-01-05 14:26:44 -0800 2013-01-06 02:28:18 -0800 Patch 106182_gstreamer_fix.patch text/plain 2079 cdumez ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZyBiL1NvdXJjZS9XZWJDb3JlL0No YW5nZUxvZwppbmRleCAxNjFhY2E3Li4zYWQ5YWFlIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29y ZS9DaGFuZ2VMb2cKKysrIGIvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMjAg QEAKKzIwMTMtMDEtMDUgIENocmlzdG9waGUgRHVtZXogIDxjaHJpc3RvcGhlLmR1bWV6QGludGVs LmNvbT4KKworICAgICAgICBSZWdyZXNzaW9uKHIxMzg3ODYpOiBDYXVzZXMgd2ViYXVkaW8gdGVz dHMgdG8gY3Jhc2gKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dp P2lkPTEwNjE4MgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAg ICAgIFBhcnRpYWxseSByZXZlcnQgcjEzODc4NiBzaW5jZSBpdCBjYXVzZXMgY3Jhc2hlcyB3aXRo IGdzdHJlYW1lcgorICAgICAgICAwLjEwLnggZHVlIHRvIHRoZSBXZWJQcm9jZXNzIGJlY29taW5n IHVucmVzcG9uc2l2ZS4KKworICAgICAgICBPbmx5IHRoZSBjaGFuZ2VzIHRvIHdlYktpdFdlYkF1 ZGlvU3JjQ2hhbmdlU3RhdGUoKSB3ZXJlIHJldmVydGVkLgorCisgICAgICAgIE5vIG5ldyB0ZXN0 cywgYWxyZWFkeSBjb3ZlcmVkIGJ5IGV4aXN0aW5nIHRlc3RzLgorCisgICAgICAgICogcGxhdGZv cm0vYXVkaW8vZ3N0cmVhbWVyL1dlYktpdFdlYkF1ZGlvU291cmNlR1N0cmVhbWVyLmNwcDoKKyAg ICAgICAgKHdlYktpdFdlYkF1ZGlvU3JjQ2hhbmdlU3RhdGUpOgorCiAyMDEzLTAxLTA1ICBaZW5v IEFsYmlzc2VyICA8emVub0B3ZWJraXQub3JnPgogCiAgICAgICAgIFtUZXhtYXBdIFRleHR1cmVN YXBwZXJHTCBzaG91bGQgcmVzZXQgQVJSQVlfQlVGRkVSIGFmdGVyIHBhaW50aW5nLgpkaWZmIC0t Z2l0IGEvU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vYXVkaW8vZ3N0cmVhbWVyL1dlYktpdFdlYkF1 ZGlvU291cmNlR1N0cmVhbWVyLmNwcCBiL1NvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL2F1ZGlvL2dz dHJlYW1lci9XZWJLaXRXZWJBdWRpb1NvdXJjZUdTdHJlYW1lci5jcHAKaW5kZXggZTc1MWE3NC4u OTA0OTI1NSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vYXVkaW8vZ3N0cmVh bWVyL1dlYktpdFdlYkF1ZGlvU291cmNlR1N0cmVhbWVyLmNwcAorKysgYi9Tb3VyY2UvV2ViQ29y ZS9wbGF0Zm9ybS9hdWRpby9nc3RyZWFtZXIvV2ViS2l0V2ViQXVkaW9Tb3VyY2VHU3RyZWFtZXIu Y3BwCkBAIC00MTksMTUgKzQxOSwxMSBAQCBzdGF0aWMgR3N0U3RhdGVDaGFuZ2VSZXR1cm4gd2Vi S2l0V2ViQXVkaW9TcmNDaGFuZ2VTdGF0ZShHc3RFbGVtZW50KiBlbGVtZW50LCBHcwogICAgIHN3 aXRjaCAodHJhbnNpdGlvbikgewogICAgIGNhc2UgR1NUX1NUQVRFX0NIQU5HRV9SRUFEWV9UT19Q QVVTRUQ6CiAgICAgICAgIEdTVF9ERUJVR19PQkpFQ1Qoc3JjLCAiUkVBRFktPlBBVVNFRCIpOwot ICAgICAgICByZXR1cm5WYWx1ZSA9IEdTVF9TVEFURV9DSEFOR0VfTk9fUFJFUk9MTDsKLSAgICAg ICAgYnJlYWs7Ci0gICAgY2FzZSBHU1RfU1RBVEVfQ0hBTkdFX1BBVVNFRF9UT19QTEFZSU5HOgot ICAgICAgICBHU1RfREVCVUdfT0JKRUNUKHNyYywgIlBBVVNFRC0+UExBWUlORyIpOwogICAgICAg ICBpZiAoIWdzdF90YXNrX3N0YXJ0KHNyYy0+cHJpdi0+dGFzay5nZXQoKSkpCiAgICAgICAgICAg ICByZXR1cm5WYWx1ZSA9IEdTVF9TVEFURV9DSEFOR0VfRkFJTFVSRTsKICAgICAgICAgYnJlYWs7 Ci0gICAgY2FzZSBHU1RfU1RBVEVfQ0hBTkdFX1BMQVlJTkdfVE9fUEFVU0VEOgotICAgICAgICBH U1RfREVCVUdfT0JKRUNUKHNyYywgIlBMQVlJTkctPlBBVVNFRCIpOworICAgIGNhc2UgR1NUX1NU QVRFX0NIQU5HRV9QQVVTRURfVE9fUkVBRFk6CisgICAgICAgIEdTVF9ERUJVR19PQkpFQ1Qoc3Jj LCAiUEFVU0VELT5SRUFEWSIpOwogICAgICAgICBpZiAoIWdzdF90YXNrX2pvaW4oc3JjLT5wcml2 LT50YXNrLmdldCgpKSkKICAgICAgICAgICAgIHJldHVyblZhbHVlID0gR1NUX1NUQVRFX0NIQU5H RV9GQUlMVVJFOwogICAgICAgICBicmVhazsK 181455 2013-01-06 02:28:18 -0800 2013-01-06 09:30:20 -0800 Patch 106182_gstreamer_fix.patch text/plain 2163 cdumez ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZyBiL1NvdXJjZS9XZWJDb3JlL0No YW5nZUxvZwppbmRleCA0MDhhYTQzLi4yZTQ2MzA3IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29y ZS9DaGFuZ2VMb2cKKysrIGIvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMjEg QEAKKzIwMTMtMDEtMDUgIENocmlzdG9waGUgRHVtZXogIDxjaHJpc3RvcGhlLmR1bWV6QGludGVs LmNvbT4KKworICAgICAgICBSZWdyZXNzaW9uKHIxMzg3ODYpOiBDYXVzZXMgd2ViYXVkaW8gdGVz dHMgdG8gY3Jhc2gKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dp P2lkPTEwNjE4MgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAg ICAgIFBhcnRpYWxseSByZXZlcnQgcjEzODc4NiBzaW5jZSBpdCBjYXVzZXMgY3Jhc2hlcyB3aXRo IGdzdHJlYW1lcgorICAgICAgICAwLjEwLnguIFRoZSBXZWJQcm9jZXNzIHdvdWxkIGFjdHVhbGx5 IGJlY29tZSB1bnJlc3BvbnNpdmUgZHVlCisgICAgICAgIHRvIHNvdXJjZSBlbGVtZW50IG5ldmVy IGdvaW5nIHRvIFBMQVlJTkcgc3RhdGUuCisKKyAgICAgICAgT25seSB0aGUgY2hhbmdlcyB0byB3 ZWJLaXRXZWJBdWRpb1NyY0NoYW5nZVN0YXRlKCkgd2VyZSByZXZlcnRlZC4KKworICAgICAgICBO byBuZXcgdGVzdHMsIGFscmVhZHkgY292ZXJlZCBieSBleGlzdGluZyB0ZXN0cy4KKworICAgICAg ICAqIHBsYXRmb3JtL2F1ZGlvL2dzdHJlYW1lci9XZWJLaXRXZWJBdWRpb1NvdXJjZUdTdHJlYW1l ci5jcHA6CisgICAgICAgICh3ZWJLaXRXZWJBdWRpb1NyY0NoYW5nZVN0YXRlKToKKwogMjAxMy0w MS0wNSAgUnlvc3VrZSBOaXdhICA8cm5pd2FAd2Via2l0Lm9yZz4KIAogICAgICAgICBSRUdSRVNT SU9OOiBbTWFjXSBJbnRlcm1pdHRlbnQgY3Jhc2hlcyBpbiBBWE9iamVjdENhY2hlOjpub3RpZmlj YXRpb25Qb3N0VGltZXJGaXJlZApkaWZmIC0tZ2l0IGEvU291cmNlL1dlYkNvcmUvcGxhdGZvcm0v YXVkaW8vZ3N0cmVhbWVyL1dlYktpdFdlYkF1ZGlvU291cmNlR1N0cmVhbWVyLmNwcCBiL1NvdXJj ZS9XZWJDb3JlL3BsYXRmb3JtL2F1ZGlvL2dzdHJlYW1lci9XZWJLaXRXZWJBdWRpb1NvdXJjZUdT dHJlYW1lci5jcHAKaW5kZXggZTc1MWE3NC4uOTA0OTI1NSAxMDA2NDQKLS0tIGEvU291cmNlL1dl YkNvcmUvcGxhdGZvcm0vYXVkaW8vZ3N0cmVhbWVyL1dlYktpdFdlYkF1ZGlvU291cmNlR1N0cmVh bWVyLmNwcAorKysgYi9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9hdWRpby9nc3RyZWFtZXIvV2Vi S2l0V2ViQXVkaW9Tb3VyY2VHU3RyZWFtZXIuY3BwCkBAIC00MTksMTUgKzQxOSwxMSBAQCBzdGF0 aWMgR3N0U3RhdGVDaGFuZ2VSZXR1cm4gd2ViS2l0V2ViQXVkaW9TcmNDaGFuZ2VTdGF0ZShHc3RF bGVtZW50KiBlbGVtZW50LCBHcwogICAgIHN3aXRjaCAodHJhbnNpdGlvbikgewogICAgIGNhc2Ug R1NUX1NUQVRFX0NIQU5HRV9SRUFEWV9UT19QQVVTRUQ6CiAgICAgICAgIEdTVF9ERUJVR19PQkpF Q1Qoc3JjLCAiUkVBRFktPlBBVVNFRCIpOwotICAgICAgICByZXR1cm5WYWx1ZSA9IEdTVF9TVEFU RV9DSEFOR0VfTk9fUFJFUk9MTDsKLSAgICAgICAgYnJlYWs7Ci0gICAgY2FzZSBHU1RfU1RBVEVf Q0hBTkdFX1BBVVNFRF9UT19QTEFZSU5HOgotICAgICAgICBHU1RfREVCVUdfT0JKRUNUKHNyYywg IlBBVVNFRC0+UExBWUlORyIpOwogICAgICAgICBpZiAoIWdzdF90YXNrX3N0YXJ0KHNyYy0+cHJp di0+dGFzay5nZXQoKSkpCiAgICAgICAgICAgICByZXR1cm5WYWx1ZSA9IEdTVF9TVEFURV9DSEFO R0VfRkFJTFVSRTsKICAgICAgICAgYnJlYWs7Ci0gICAgY2FzZSBHU1RfU1RBVEVfQ0hBTkdFX1BM QVlJTkdfVE9fUEFVU0VEOgotICAgICAgICBHU1RfREVCVUdfT0JKRUNUKHNyYywgIlBMQVlJTkct PlBBVVNFRCIpOworICAgIGNhc2UgR1NUX1NUQVRFX0NIQU5HRV9QQVVTRURfVE9fUkVBRFk6Cisg ICAgICAgIEdTVF9ERUJVR19PQkpFQ1Qoc3JjLCAiUEFVU0VELT5SRUFEWSIpOwogICAgICAgICBp ZiAoIWdzdF90YXNrX2pvaW4oc3JjLT5wcml2LT50YXNrLmdldCgpKSkKICAgICAgICAgICAgIHJl dHVyblZhbHVlID0gR1NUX1NUQVRFX0NIQU5HRV9GQUlMVVJFOwogICAgICAgICBicmVhazsK 181461 2013-01-06 09:30:20 -0800 2013-01-07 05:30:05 -0800 Patch 106182_gstreamer_fix.patch text/plain 2159 cdumez ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZyBiL1NvdXJjZS9XZWJDb3JlL0No YW5nZUxvZwppbmRleCA0MDhhYTQzLi40ZGM5YmNiIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29y ZS9DaGFuZ2VMb2cKKysrIGIvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMjEg QEAKKzIwMTMtMDEtMDUgIENocmlzdG9waGUgRHVtZXogIDxjaHJpc3RvcGhlLmR1bWV6QGludGVs LmNvbT4KKworICAgICAgICBSZWdyZXNzaW9uKHIxMzg3ODYpOiBDYXVzZXMgd2ViYXVkaW8gdGVz dHMgdG8gY3Jhc2gKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dp P2lkPTEwNjE4MgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAg ICAgIFBhcnRpYWxseSByZXZlcnQgcjEzODc4NiBzaW5jZSBpdCBjYXVzZXMgY3Jhc2hlcyBpbiB3 ZWJhdWRpbworICAgICAgICB0ZXN0cy4gVGhlIFdlYlByb2Nlc3Mgd291bGQgYWN0dWFsbHkgYmVj b21lIHVucmVzcG9uc2l2ZSBkdWUKKyAgICAgICAgdG8gc291cmNlIGVsZW1lbnQgbmV2ZXIgZ29p bmcgdG8gUExBWUlORyBzdGF0ZS4KKworICAgICAgICBPbmx5IHRoZSBjaGFuZ2VzIHRvIHdlYktp dFdlYkF1ZGlvU3JjQ2hhbmdlU3RhdGUoKSB3ZXJlIHJldmVydGVkLgorCisgICAgICAgIE5vIG5l dyB0ZXN0cywgYWxyZWFkeSBjb3ZlcmVkIGJ5IGV4aXN0aW5nIHRlc3RzLgorCisgICAgICAgICog cGxhdGZvcm0vYXVkaW8vZ3N0cmVhbWVyL1dlYktpdFdlYkF1ZGlvU291cmNlR1N0cmVhbWVyLmNw cDoKKyAgICAgICAgKHdlYktpdFdlYkF1ZGlvU3JjQ2hhbmdlU3RhdGUpOgorCiAyMDEzLTAxLTA1 ICBSeW9zdWtlIE5pd2EgIDxybml3YUB3ZWJraXQub3JnPgogCiAgICAgICAgIFJFR1JFU1NJT046 IFtNYWNdIEludGVybWl0dGVudCBjcmFzaGVzIGluIEFYT2JqZWN0Q2FjaGU6Om5vdGlmaWNhdGlv blBvc3RUaW1lckZpcmVkCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9hdWRp by9nc3RyZWFtZXIvV2ViS2l0V2ViQXVkaW9Tb3VyY2VHU3RyZWFtZXIuY3BwIGIvU291cmNlL1dl YkNvcmUvcGxhdGZvcm0vYXVkaW8vZ3N0cmVhbWVyL1dlYktpdFdlYkF1ZGlvU291cmNlR1N0cmVh bWVyLmNwcAppbmRleCBlNzUxYTc0Li45MDQ5MjU1IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29y ZS9wbGF0Zm9ybS9hdWRpby9nc3RyZWFtZXIvV2ViS2l0V2ViQXVkaW9Tb3VyY2VHU3RyZWFtZXIu Y3BwCisrKyBiL1NvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL2F1ZGlvL2dzdHJlYW1lci9XZWJLaXRX ZWJBdWRpb1NvdXJjZUdTdHJlYW1lci5jcHAKQEAgLTQxOSwxNSArNDE5LDExIEBAIHN0YXRpYyBH c3RTdGF0ZUNoYW5nZVJldHVybiB3ZWJLaXRXZWJBdWRpb1NyY0NoYW5nZVN0YXRlKEdzdEVsZW1l bnQqIGVsZW1lbnQsIEdzCiAgICAgc3dpdGNoICh0cmFuc2l0aW9uKSB7CiAgICAgY2FzZSBHU1Rf U1RBVEVfQ0hBTkdFX1JFQURZX1RPX1BBVVNFRDoKICAgICAgICAgR1NUX0RFQlVHX09CSkVDVChz cmMsICJSRUFEWS0+UEFVU0VEIik7Ci0gICAgICAgIHJldHVyblZhbHVlID0gR1NUX1NUQVRFX0NI QU5HRV9OT19QUkVST0xMOwotICAgICAgICBicmVhazsKLSAgICBjYXNlIEdTVF9TVEFURV9DSEFO R0VfUEFVU0VEX1RPX1BMQVlJTkc6Ci0gICAgICAgIEdTVF9ERUJVR19PQkpFQ1Qoc3JjLCAiUEFV U0VELT5QTEFZSU5HIik7CiAgICAgICAgIGlmICghZ3N0X3Rhc2tfc3RhcnQoc3JjLT5wcml2LT50 YXNrLmdldCgpKSkKICAgICAgICAgICAgIHJldHVyblZhbHVlID0gR1NUX1NUQVRFX0NIQU5HRV9G QUlMVVJFOwogICAgICAgICBicmVhazsKLSAgICBjYXNlIEdTVF9TVEFURV9DSEFOR0VfUExBWUlO R19UT19QQVVTRUQ6Ci0gICAgICAgIEdTVF9ERUJVR19PQkpFQ1Qoc3JjLCAiUExBWUlORy0+UEFV U0VEIik7CisgICAgY2FzZSBHU1RfU1RBVEVfQ0hBTkdFX1BBVVNFRF9UT19SRUFEWToKKyAgICAg ICAgR1NUX0RFQlVHX09CSkVDVChzcmMsICJQQVVTRUQtPlJFQURZIik7CiAgICAgICAgIGlmICgh Z3N0X3Rhc2tfam9pbihzcmMtPnByaXYtPnRhc2suZ2V0KCkpKQogICAgICAgICAgICAgcmV0dXJu VmFsdWUgPSBHU1RfU1RBVEVfQ0hBTkdFX0ZBSUxVUkU7CiAgICAgICAgIGJyZWFrOwo=