106167 2013-01-04 23:14:06 -0800 Seamless: IFrame's padding isn't taken into account when calculating its height. 2013-01-06 11:20:11 -0800 1 1 1 Unclassified WebKit WebCore Misc. 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 45950 1 mkwst mkwst eric ojan.autocc ojan robert tabatkins webkit.review.bot oldest_to_newest 800862 0 mkwst 2013-01-04 23:14:06 -0800 fast/frames/seamless/seamless-border.html contains two failures, both demonstrating that seamless IFrames don't correctly calculate their height when padding is applied to the frame. Width is correctly calculated, but the padding is ignored when calculating height. 800867 1 eric 2013-01-04 23:18:37 -0800 Presumably this code is layoutSeamlessly is what you need to change: FrameView* childFrameView = static_cast<FrameView*>(widget()); if (childFrameView) // Widget should never be null during layout(), but just in case. setLogicalHeight(childFrameView->contentsHeight() + borderTop() + borderBottom()); void RenderFrameBase::layoutWithFlattening(bool hasFixedWidth, bool hasFixedHeight) likely also gets it wrong. There are frame flattening tests in fast/frames/flattening if you feel so inclined. 800868 2 eric 2013-01-04 23:18:53 -0800 seamless and frameflattening share a lot of code. frame-flattening is a mobile-only feature. 800870 3 mkwst 2013-01-04 23:20:22 -0800 I'll certainly take a look at the flattening code as well. Makes sense to fix both in the same patch, if they're both incorrect. Thanks for the pointer! 800874 4 eric 2013-01-04 23:22:46 -0800 Flattening's behavior is slightly different wrt scrollbars. Flattening is not so much about displaying the content seamlessly, as expanding the iframe enough to that the user never has to see nested scrollbars. Dealing with nested frames on mobile is a pain. :) Speaking of which... I suspect that seamless may have some scrolling bugs as well if we go looking. 800902 5 mkwst 2013-01-05 04:43:15 -0800 Fixing RenderIFrame::layoutSeamlessly is trivial; I'll put up a patch as soon as the patch for https://bugs.webkit.org/show_bug.cgi?id=90827 lands (looks like the CQ is wedged), as this fix depends on that one. Flattening seems disabled on the Chromium port, but I'll see if I can poke at it on the mac port in a separate patch. Neither vertical nor horizontal padding is accounted for in RenderFrameBase::layoutWithFlattening; It seems like the right thing to do, though, so I'll take care of both in https://bugs.webkit.org/show_bug.cgi?id=106174. 800939 6 181441 mkwst 2013-01-05 11:37:05 -0800 Created attachment 181441 Patch 800940 7 mkwst 2013-01-05 11:38:27 -0800 (In reply to comment #5) > Fixing RenderIFrame::layoutSeamlessly is trivial; I'll put up a patch as soon as the patch for https://bugs.webkit.org/show_bug.cgi?id=90827 lands (looks like the CQ is wedged), as this fix depends on that one. webkit-patch is, happily, clever enough to upload a patch even though the previous patch hasn't landed yet(!). I'm not going to throw this to the bots until it's in, but the change is pretty clear regardless. 801048 8 181454 mkwst 2013-01-06 00:17:32 -0800 Created attachment 181454 Patch 801049 9 mkwst 2013-01-06 00:18:08 -0800 Hrm. It apparently hit the bots anyway. Uploading the same patch again for EWS now that the previous patch landed. 801051 10 181454 eric 2013-01-06 00:25:09 -0800 Comment on attachment 181454 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=181454&action=review > Source/WebCore/rendering/RenderIFrame.cpp:134 > + // Replaced elements normally do not respect padding, but seamless elements should: we'll add > + // both padding and border to the child's logical height here. Is this true? I don't know what the expected behavior is? 801052 11 mkwst 2013-01-06 00:32:45 -0800 (In reply to comment #10) > (From update of attachment 181454 [details]) > View in context: https://bugs.webkit.org/attachment.cgi?id=181454&action=review > > > Source/WebCore/rendering/RenderIFrame.cpp:134 > > + // Replaced elements normally do not respect padding, but seamless elements should: we'll add > > + // both padding and border to the child's logical height here. > > Is this true? I don't know what the expected behavior is? Hrm. Which part of this are you questioning? :) I thought that dropping the padding-related FIXME here was the point of the patch; did I misunderstand your comments? 801053 12 181454 eric 2013-01-06 00:47:08 -0800 Comment on attachment 181454 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=181454&action=review >>> Source/WebCore/rendering/RenderIFrame.cpp:134 >>> + // both padding and border to the child's logical height here. >> >> Is this true? I don't know what the expected behavior is? > > Hrm. Which part of this are you questioning? :) > > I thought that dropping the padding-related FIXME here was the point of the patch; did I misunderstand your comments? Yeah, I guess I'm just re-asking the FIXME. :) I don't know if they should or not? 801054 13 eric 2013-01-06 00:48:52 -0800 Tab knows the answers to these questions. :) 801055 14 mkwst 2013-01-06 00:55:50 -0800 (In reply to comment #12) > (From update of attachment 181454 [details]) > View in context: https://bugs.webkit.org/attachment.cgi?id=181454&action=review > > >>> Source/WebCore/rendering/RenderIFrame.cpp:134 > >>> + // both padding and border to the child's logical height here. > >> > >> Is this true? I don't know what the expected behavior is? > > > > Hrm. Which part of this are you questioning? :) > > > > I thought that dropping the padding-related FIXME here was the point of the patch; did I misunderstand your comments? > > Yeah, I guess I'm just re-asking the FIXME. :) I don't know if they should or not? The spec only talks about setting the "intrinsic height" of the frame via the child's height. I'm pretty sure that doesn't include padding or borders. Given that non-seamless frames respect padding (http://software.hixie.ch/utilities/js/live-dom-viewer/?saved=2058), it seems like the right thing to do for seamless frames as well. That said, yes, Tab will know better than I. :) 801056 15 181454 eric 2013-01-06 01:14:05 -0800 Comment on attachment 181454 Patch If non-seamless iframes respect padding, than it's definitely a bug that seamless ones don't! 801057 16 mkwst 2013-01-06 01:39:32 -0800 (In reply to comment #15) > (From update of attachment 181454 [details]) > If non-seamless iframes respect padding, than it's definitely a bug that seamless ones don't! Or the non-seamless behavior is a bug. :) I think this patch is correct. If it turns out that we're doing the wrong thing with IFrames in general, I'll poke at it in a separate patch. 801059 17 181454 webkit.review.bot 2013-01-06 01:44:32 -0800 Comment on attachment 181454 Patch Clearing flags on attachment: 181454 Committed r138917: <http://trac.webkit.org/changeset/138917> 801060 18 webkit.review.bot 2013-01-06 01:44:37 -0800 All reviewed patches have been landed. Closing bug. 801079 19 eric 2013-01-06 10:52:11 -0800 (In reply to comment #16) > (In reply to comment #15) > > (From update of attachment 181454 [details] [details]) > > If non-seamless iframes respect padding, than it's definitely a bug that seamless ones don't! > > Or the non-seamless behavior is a bug. :) > > I think this patch is correct. If it turns out that we're doing the wrong thing with IFrames in general, I'll poke at it in a separate patch. The non seamless behavior is easy to confirm in other browsers 801083 20 mkwst 2013-01-06 11:20:11 -0800 (In reply to comment #19) > (In reply to comment #16) > > (In reply to comment #15) > > > (From update of attachment 181454 [details] [details] [details]) > > > If non-seamless iframes respect padding, than it's definitely a bug that seamless ones don't! > > > > Or the non-seamless behavior is a bug. :) > > > > I think this patch is correct. If it turns out that we're doing the wrong thing with IFrames in general, I'll poke at it in a separate patch. > > The non seamless behavior is easy to confirm in other browsers Works in Firefox. 181441 2013-01-05 11:37:05 -0800 2013-01-06 00:17:27 -0800 Patch bug-106167-20130105203410.patch text/plain 4244 mkwst U3VidmVyc2lvbiBSZXZpc2lvbjogMTM4ODg2CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggZDEwYmVkZDU1N2Y1ZDQy NGI5ZjQyNTliYmIyNGQ4ZTdjODBlMjIwOS4uM2QzNTZhYWVjMDVkODIxMjI3YmViNzExMWFkZTBl ZjFhZmFiMGQ1MiAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSw1ICsxLDIwIEBACiAyMDEzLTAxLTA1ICBNaWtl IFdlc3QgIDxta3dzdEBjaHJvbWl1bS5vcmc+CiAKKyAgICAgICAgU2VhbWxlc3M6IElGcmFtZSdz IHBhZGRpbmcgaXNuJ3QgdGFrZW4gaW50byBhY2NvdW50IHdoZW4gY2FsY3VsYXRpbmcgaXRzIGhl aWdodC4KKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTEw NjE2NworCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIElG cmFtZXMgcmVuZGVyZWQgc2VhbWxlc3NseSBkb24ndCBjdXJyZW50bHkgY2FsY3VsYXRlIHRoZWly IGhlaWdodAorICAgICAgICBjb3JyZWN0bHkgd2hlbiBwYWRkaW5nIGlzIGFwcGxpZWQgdG8gdGhl IGZyYW1lIGl0c2VsZi4gVGhpcyBwYXRjaCBhZGRzCisgICAgICAgIHBhZGRpbmcgY2FsY3VsYXRp b25zIHRvIFJlbmRlcklGcmFtZTo6bGF5b3V0U2VhbWxlc3NseSB0byBlbnN1cmUgdGhhdAorICAg ICAgICB0aGUgc2VhbWxlc3MgZnJhbWUgaXMgY29ycmVjdGx5IHNpemVkLgorCisgICAgICAgICog cmVuZGVyaW5nL1JlbmRlcklGcmFtZS5jcHA6CisgICAgICAgIChXZWJDb3JlOjpSZW5kZXJJRnJh bWU6OmxheW91dFNlYW1sZXNzbHkpOgorCisyMDEzLTAxLTA1ICBNaWtlIFdlc3QgIDxta3dzdEBj aHJvbWl1bS5vcmc+CisKICAgICAgICAgc2VhbWxlc3MgaWZyYW1lcyBkb24ndCB0YWtlIGJvcmRl ciBpbnRvIGFjY291bnQgcHJvcGVybHkgYW5kIG1ha2UgdGhlIGlmcmFtZSB0b28gc21hbGwuCiAg ICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD05MDgyNwogCmRp ZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9yZW5kZXJpbmcvUmVuZGVySUZyYW1lLmNwcCBiL1Nv dXJjZS9XZWJDb3JlL3JlbmRlcmluZy9SZW5kZXJJRnJhbWUuY3BwCmluZGV4IGQ0N2EyMDg5MTQz NWFlNmNiNmM5ZTBmZTJjOWZlM2U1NTU0ZjU1YTAuLmRlNzRhOTI0NDExMzdmN2U4ZmIyMDZmNmY2 ZDlkNDU4MTQxNzY5MjMgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJDb3JlL3JlbmRlcmluZy9SZW5k ZXJJRnJhbWUuY3BwCisrKyBiL1NvdXJjZS9XZWJDb3JlL3JlbmRlcmluZy9SZW5kZXJJRnJhbWUu Y3BwCkBAIC0xMzAsMTEgKzEzMCwxMSBAQCB2b2lkIFJlbmRlcklGcmFtZTo6bGF5b3V0U2VhbWxl c3NseSgpCiAgICAgdXBkYXRlV2lkZ2V0UG9zaXRpb24oKTsgLy8gVGVsbCB0aGUgV2lkZ2V0IGFi b3V0IG91ciBuZXcgd2lkdGgvaGVpZ2h0IChpdCB3aWxsIGFsc28gbGF5b3V0IHRoZSBjaGlsZCBk b2N1bWVudCkuCiAKICAgICAvLyBMYXlpbmcgb3V0IG91ciBraWRzIGlzIG5vcm1hbGx5IHJlc3Bv bnNpYmxlIGZvciBhZGp1c3Rpbmcgb3VyIGhlaWdodCwgc28gd2Ugc2V0IGl0IGhlcmUuCi0gICAg Ly8gUmVwbGFjZWQgZWxlbWVudHMgZG8gbm90IHJlc3BlY3QgcGFkZGluZywgc28gd2UganVzdCBh ZGQgYm9yZGVyIHRvIHRoZSBjaGlsZCdzIGhlaWdodC4KLSAgICAvLyBGSVhNRTogSXQncyBwb3Nz aWJsZSB0aGF0IHNlYW1sZXNzIGlmcmFtZXMgKHNpbmNlIHRoZXkgYWN0IGxpa2UgZGl2cykgKnNo b3VsZCogcmVzcGVjdCBwYWRkaW5nLgorICAgIC8vIFJlcGxhY2VkIGVsZW1lbnRzIG5vcm1hbGx5 IGRvIG5vdCByZXNwZWN0IHBhZGRpbmcsIGJ1dCBzZWFtbGVzcyBlbGVtZW50cyBzaG91bGQ6IHdl J2xsIGFkZAorICAgIC8vIGJvdGggcGFkZGluZyBhbmQgYm9yZGVyIHRvIHRoZSBjaGlsZCdzIGxv Z2ljYWwgaGVpZ2h0IGhlcmUuCiAgICAgRnJhbWVWaWV3KiBjaGlsZEZyYW1lVmlldyA9IHN0YXRp Y19jYXN0PEZyYW1lVmlldyo+KHdpZGdldCgpKTsKICAgICBpZiAoY2hpbGRGcmFtZVZpZXcpIC8v IFdpZGdldCBzaG91bGQgbmV2ZXIgYmUgbnVsbCBkdXJpbmcgbGF5b3V0KCksIGJ1dCBqdXN0IGlu IGNhc2UuCi0gICAgICAgIHNldExvZ2ljYWxIZWlnaHQoY2hpbGRGcmFtZVZpZXctPmNvbnRlbnRz SGVpZ2h0KCkgKyBib3JkZXJUb3AoKSArIGJvcmRlckJvdHRvbSgpKTsKKyAgICAgICAgc2V0TG9n aWNhbEhlaWdodChjaGlsZEZyYW1lVmlldy0+Y29udGVudHNIZWlnaHQoKSArIGJvcmRlclRvcCgp ICsgYm9yZGVyQm90dG9tKCkgKyBwYWRkaW5nVG9wKCkgKyBwYWRkaW5nQm90dG9tKCkpOwogICAg IHVwZGF0ZUxvZ2ljYWxIZWlnaHQoKTsKIAogICAgIHVwZGF0ZVdpZGdldFBvc2l0aW9uKCk7IC8v IE5vdGlmeSB0aGUgV2lkZ2V0IG9mIG91ciBmaW5hbCBoZWlnaHQuCmRpZmYgLS1naXQgYS9MYXlv dXRUZXN0cy9DaGFuZ2VMb2cgYi9MYXlvdXRUZXN0cy9DaGFuZ2VMb2cKaW5kZXggNGIzYzU0ZWMx ZWZhZjc0OWNlYzdiZTRiZjQ5YTAxYjM0MWU1MjRjZi4uYjcxMGVjNWYzZWMxMGJiNmY1NjE0ZWRj OTQ1MDBmNGJhYTE3M2MzMyAxMDA2NDQKLS0tIGEvTGF5b3V0VGVzdHMvQ2hhbmdlTG9nCisrKyBi L0xheW91dFRlc3RzL0NoYW5nZUxvZwpAQCAtMSw1ICsxLDE1IEBACiAyMDEzLTAxLTA1ICBNaWtl IFdlc3QgIDxta3dzdEBjaHJvbWl1bS5vcmc+CiAKKyAgICAgICAgU2VhbWxlc3M6IElGcmFtZSdz IHBhZGRpbmcgaXNuJ3QgdGFrZW4gaW50byBhY2NvdW50IHdoZW4gY2FsY3VsYXRpbmcgaXRzIGhl aWdodC4KKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTEw NjE2NworCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgICog ZmFzdC9mcmFtZXMvc2VhbWxlc3Mvc2VhbWxlc3MtYm9yZGVyLXBhZGRpbmctZXhwZWN0ZWQudHh0 OgorICAgICAgICAgICAgQWRqdXN0cyB0aGUgcHJldmlvdXNseSBmYWlsaW5nIGV4cGVjdGF0aW9u cyB0byB0aGUgY29ycmVjdCB2YWx1ZXMuCisKKzIwMTMtMDEtMDUgIE1pa2UgV2VzdCAgPG1rd3N0 QGNocm9taXVtLm9yZz4KKwogICAgICAgICBzZWFtbGVzcyBpZnJhbWVzIGRvbid0IHRha2UgYm9y ZGVyIGludG8gYWNjb3VudCBwcm9wZXJseSBhbmQgbWFrZSB0aGUgaWZyYW1lIHRvbyBzbWFsbC4K ICAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTkwODI3CiAK ZGlmZiAtLWdpdCBhL0xheW91dFRlc3RzL2Zhc3QvZnJhbWVzL3NlYW1sZXNzL3NlYW1sZXNzLWJv cmRlci1wYWRkaW5nLWV4cGVjdGVkLnR4dCBiL0xheW91dFRlc3RzL2Zhc3QvZnJhbWVzL3NlYW1s ZXNzL3NlYW1sZXNzLWJvcmRlci1wYWRkaW5nLWV4cGVjdGVkLnR4dAppbmRleCA3ODAyYTBmYTNk OTBkYmUzM2RmNDU4OTQ2MTFjODQwNTBmZWE4ZTQwLi5iYjcxYzNhZTFmZTMwMjVjNGJiZGU5YWMy ODljZjUzNGJhMjE1ZTQ3IDEwMDY0NAotLS0gYS9MYXlvdXRUZXN0cy9mYXN0L2ZyYW1lcy9zZWFt bGVzcy9zZWFtbGVzcy1ib3JkZXItcGFkZGluZy1leHBlY3RlZC50eHQKKysrIGIvTGF5b3V0VGVz dHMvZmFzdC9mcmFtZXMvc2VhbWxlc3Mvc2VhbWxlc3MtYm9yZGVyLXBhZGRpbmctZXhwZWN0ZWQu dHh0CkBAIC00LDcgKzQsNyBAQCBQQVNTIG5vdGhpbmcuZ2V0Qm91bmRpbmdDbGllbnRSZWN0KCku aGVpZ2h0IGlzIDEwMAogUEFTUyBoYXNib3JkZXIuZ2V0Qm91bmRpbmdDbGllbnRSZWN0KCkud2lk dGggaXMgMTAyCiBQQVNTIGhhc2JvcmRlci5nZXRCb3VuZGluZ0NsaWVudFJlY3QoKS5oZWlnaHQg aXMgMTAyCiBQQVNTIGhhc3BhZGRpbmcuZ2V0Qm91bmRpbmdDbGllbnRSZWN0KCkud2lkdGggaXMg MTA0Ci1GQUlMIGhhc3BhZGRpbmcuZ2V0Qm91bmRpbmdDbGllbnRSZWN0KCkuaGVpZ2h0IHNob3Vs ZCBiZSAxMDQuIFdhcyAxMDAuCitQQVNTIGhhc3BhZGRpbmcuZ2V0Qm91bmRpbmdDbGllbnRSZWN0 KCkuaGVpZ2h0IGlzIDEwNAogUEFTUyBoYXNib3RoLmdldEJvdW5kaW5nQ2xpZW50UmVjdCgpLndp ZHRoIGlzIDEwNgotRkFJTCBoYXNib3RoLmdldEJvdW5kaW5nQ2xpZW50UmVjdCgpLmhlaWdodCBz aG91bGQgYmUgMTA2LiBXYXMgMTAyLgorUEFTUyBoYXNib3RoLmdldEJvdW5kaW5nQ2xpZW50UmVj dCgpLmhlaWdodCBpcyAxMDYKICAgICAgIAo= 181454 2013-01-06 00:17:32 -0800 2013-01-06 01:44:32 -0800 Patch bug-106167-20130106091437.patch text/plain 4244 mkwst U3VidmVyc2lvbiBSZXZpc2lvbjogMTM4ODg2CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggZDEwYmVkZDU1N2Y1ZDQy NGI5ZjQyNTliYmIyNGQ4ZTdjODBlMjIwOS4uM2QzNTZhYWVjMDVkODIxMjI3YmViNzExMWFkZTBl ZjFhZmFiMGQ1MiAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSw1ICsxLDIwIEBACiAyMDEzLTAxLTA1ICBNaWtl IFdlc3QgIDxta3dzdEBjaHJvbWl1bS5vcmc+CiAKKyAgICAgICAgU2VhbWxlc3M6IElGcmFtZSdz IHBhZGRpbmcgaXNuJ3QgdGFrZW4gaW50byBhY2NvdW50IHdoZW4gY2FsY3VsYXRpbmcgaXRzIGhl aWdodC4KKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTEw NjE2NworCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIElG cmFtZXMgcmVuZGVyZWQgc2VhbWxlc3NseSBkb24ndCBjdXJyZW50bHkgY2FsY3VsYXRlIHRoZWly IGhlaWdodAorICAgICAgICBjb3JyZWN0bHkgd2hlbiBwYWRkaW5nIGlzIGFwcGxpZWQgdG8gdGhl IGZyYW1lIGl0c2VsZi4gVGhpcyBwYXRjaCBhZGRzCisgICAgICAgIHBhZGRpbmcgY2FsY3VsYXRp b25zIHRvIFJlbmRlcklGcmFtZTo6bGF5b3V0U2VhbWxlc3NseSB0byBlbnN1cmUgdGhhdAorICAg ICAgICB0aGUgc2VhbWxlc3MgZnJhbWUgaXMgY29ycmVjdGx5IHNpemVkLgorCisgICAgICAgICog cmVuZGVyaW5nL1JlbmRlcklGcmFtZS5jcHA6CisgICAgICAgIChXZWJDb3JlOjpSZW5kZXJJRnJh bWU6OmxheW91dFNlYW1sZXNzbHkpOgorCisyMDEzLTAxLTA1ICBNaWtlIFdlc3QgIDxta3dzdEBj aHJvbWl1bS5vcmc+CisKICAgICAgICAgc2VhbWxlc3MgaWZyYW1lcyBkb24ndCB0YWtlIGJvcmRl ciBpbnRvIGFjY291bnQgcHJvcGVybHkgYW5kIG1ha2UgdGhlIGlmcmFtZSB0b28gc21hbGwuCiAg ICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD05MDgyNwogCmRp ZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9yZW5kZXJpbmcvUmVuZGVySUZyYW1lLmNwcCBiL1Nv dXJjZS9XZWJDb3JlL3JlbmRlcmluZy9SZW5kZXJJRnJhbWUuY3BwCmluZGV4IGQ0N2EyMDg5MTQz NWFlNmNiNmM5ZTBmZTJjOWZlM2U1NTU0ZjU1YTAuLmRlNzRhOTI0NDExMzdmN2U4ZmIyMDZmNmY2 ZDlkNDU4MTQxNzY5MjMgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJDb3JlL3JlbmRlcmluZy9SZW5k ZXJJRnJhbWUuY3BwCisrKyBiL1NvdXJjZS9XZWJDb3JlL3JlbmRlcmluZy9SZW5kZXJJRnJhbWUu Y3BwCkBAIC0xMzAsMTEgKzEzMCwxMSBAQCB2b2lkIFJlbmRlcklGcmFtZTo6bGF5b3V0U2VhbWxl c3NseSgpCiAgICAgdXBkYXRlV2lkZ2V0UG9zaXRpb24oKTsgLy8gVGVsbCB0aGUgV2lkZ2V0IGFi b3V0IG91ciBuZXcgd2lkdGgvaGVpZ2h0IChpdCB3aWxsIGFsc28gbGF5b3V0IHRoZSBjaGlsZCBk b2N1bWVudCkuCiAKICAgICAvLyBMYXlpbmcgb3V0IG91ciBraWRzIGlzIG5vcm1hbGx5IHJlc3Bv bnNpYmxlIGZvciBhZGp1c3Rpbmcgb3VyIGhlaWdodCwgc28gd2Ugc2V0IGl0IGhlcmUuCi0gICAg Ly8gUmVwbGFjZWQgZWxlbWVudHMgZG8gbm90IHJlc3BlY3QgcGFkZGluZywgc28gd2UganVzdCBh ZGQgYm9yZGVyIHRvIHRoZSBjaGlsZCdzIGhlaWdodC4KLSAgICAvLyBGSVhNRTogSXQncyBwb3Nz aWJsZSB0aGF0IHNlYW1sZXNzIGlmcmFtZXMgKHNpbmNlIHRoZXkgYWN0IGxpa2UgZGl2cykgKnNo b3VsZCogcmVzcGVjdCBwYWRkaW5nLgorICAgIC8vIFJlcGxhY2VkIGVsZW1lbnRzIG5vcm1hbGx5 IGRvIG5vdCByZXNwZWN0IHBhZGRpbmcsIGJ1dCBzZWFtbGVzcyBlbGVtZW50cyBzaG91bGQ6IHdl J2xsIGFkZAorICAgIC8vIGJvdGggcGFkZGluZyBhbmQgYm9yZGVyIHRvIHRoZSBjaGlsZCdzIGxv Z2ljYWwgaGVpZ2h0IGhlcmUuCiAgICAgRnJhbWVWaWV3KiBjaGlsZEZyYW1lVmlldyA9IHN0YXRp Y19jYXN0PEZyYW1lVmlldyo+KHdpZGdldCgpKTsKICAgICBpZiAoY2hpbGRGcmFtZVZpZXcpIC8v IFdpZGdldCBzaG91bGQgbmV2ZXIgYmUgbnVsbCBkdXJpbmcgbGF5b3V0KCksIGJ1dCBqdXN0IGlu IGNhc2UuCi0gICAgICAgIHNldExvZ2ljYWxIZWlnaHQoY2hpbGRGcmFtZVZpZXctPmNvbnRlbnRz SGVpZ2h0KCkgKyBib3JkZXJUb3AoKSArIGJvcmRlckJvdHRvbSgpKTsKKyAgICAgICAgc2V0TG9n aWNhbEhlaWdodChjaGlsZEZyYW1lVmlldy0+Y29udGVudHNIZWlnaHQoKSArIGJvcmRlclRvcCgp ICsgYm9yZGVyQm90dG9tKCkgKyBwYWRkaW5nVG9wKCkgKyBwYWRkaW5nQm90dG9tKCkpOwogICAg IHVwZGF0ZUxvZ2ljYWxIZWlnaHQoKTsKIAogICAgIHVwZGF0ZVdpZGdldFBvc2l0aW9uKCk7IC8v IE5vdGlmeSB0aGUgV2lkZ2V0IG9mIG91ciBmaW5hbCBoZWlnaHQuCmRpZmYgLS1naXQgYS9MYXlv dXRUZXN0cy9DaGFuZ2VMb2cgYi9MYXlvdXRUZXN0cy9DaGFuZ2VMb2cKaW5kZXggNGIzYzU0ZWMx ZWZhZjc0OWNlYzdiZTRiZjQ5YTAxYjM0MWU1MjRjZi4uYjcxMGVjNWYzZWMxMGJiNmY1NjE0ZWRj OTQ1MDBmNGJhYTE3M2MzMyAxMDA2NDQKLS0tIGEvTGF5b3V0VGVzdHMvQ2hhbmdlTG9nCisrKyBi L0xheW91dFRlc3RzL0NoYW5nZUxvZwpAQCAtMSw1ICsxLDE1IEBACiAyMDEzLTAxLTA1ICBNaWtl IFdlc3QgIDxta3dzdEBjaHJvbWl1bS5vcmc+CiAKKyAgICAgICAgU2VhbWxlc3M6IElGcmFtZSdz IHBhZGRpbmcgaXNuJ3QgdGFrZW4gaW50byBhY2NvdW50IHdoZW4gY2FsY3VsYXRpbmcgaXRzIGhl aWdodC4KKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTEw NjE2NworCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgICog ZmFzdC9mcmFtZXMvc2VhbWxlc3Mvc2VhbWxlc3MtYm9yZGVyLXBhZGRpbmctZXhwZWN0ZWQudHh0 OgorICAgICAgICAgICAgQWRqdXN0cyB0aGUgcHJldmlvdXNseSBmYWlsaW5nIGV4cGVjdGF0aW9u cyB0byB0aGUgY29ycmVjdCB2YWx1ZXMuCisKKzIwMTMtMDEtMDUgIE1pa2UgV2VzdCAgPG1rd3N0 QGNocm9taXVtLm9yZz4KKwogICAgICAgICBzZWFtbGVzcyBpZnJhbWVzIGRvbid0IHRha2UgYm9y ZGVyIGludG8gYWNjb3VudCBwcm9wZXJseSBhbmQgbWFrZSB0aGUgaWZyYW1lIHRvbyBzbWFsbC4K ICAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTkwODI3CiAK ZGlmZiAtLWdpdCBhL0xheW91dFRlc3RzL2Zhc3QvZnJhbWVzL3NlYW1sZXNzL3NlYW1sZXNzLWJv cmRlci1wYWRkaW5nLWV4cGVjdGVkLnR4dCBiL0xheW91dFRlc3RzL2Zhc3QvZnJhbWVzL3NlYW1s ZXNzL3NlYW1sZXNzLWJvcmRlci1wYWRkaW5nLWV4cGVjdGVkLnR4dAppbmRleCA3ODAyYTBmYTNk OTBkYmUzM2RmNDU4OTQ2MTFjODQwNTBmZWE4ZTQwLi5iYjcxYzNhZTFmZTMwMjVjNGJiZGU5YWMy ODljZjUzNGJhMjE1ZTQ3IDEwMDY0NAotLS0gYS9MYXlvdXRUZXN0cy9mYXN0L2ZyYW1lcy9zZWFt bGVzcy9zZWFtbGVzcy1ib3JkZXItcGFkZGluZy1leHBlY3RlZC50eHQKKysrIGIvTGF5b3V0VGVz dHMvZmFzdC9mcmFtZXMvc2VhbWxlc3Mvc2VhbWxlc3MtYm9yZGVyLXBhZGRpbmctZXhwZWN0ZWQu dHh0CkBAIC00LDcgKzQsNyBAQCBQQVNTIG5vdGhpbmcuZ2V0Qm91bmRpbmdDbGllbnRSZWN0KCku aGVpZ2h0IGlzIDEwMAogUEFTUyBoYXNib3JkZXIuZ2V0Qm91bmRpbmdDbGllbnRSZWN0KCkud2lk dGggaXMgMTAyCiBQQVNTIGhhc2JvcmRlci5nZXRCb3VuZGluZ0NsaWVudFJlY3QoKS5oZWlnaHQg aXMgMTAyCiBQQVNTIGhhc3BhZGRpbmcuZ2V0Qm91bmRpbmdDbGllbnRSZWN0KCkud2lkdGggaXMg MTA0Ci1GQUlMIGhhc3BhZGRpbmcuZ2V0Qm91bmRpbmdDbGllbnRSZWN0KCkuaGVpZ2h0IHNob3Vs ZCBiZSAxMDQuIFdhcyAxMDAuCitQQVNTIGhhc3BhZGRpbmcuZ2V0Qm91bmRpbmdDbGllbnRSZWN0 KCkuaGVpZ2h0IGlzIDEwNAogUEFTUyBoYXNib3RoLmdldEJvdW5kaW5nQ2xpZW50UmVjdCgpLndp ZHRoIGlzIDEwNgotRkFJTCBoYXNib3RoLmdldEJvdW5kaW5nQ2xpZW50UmVjdCgpLmhlaWdodCBz aG91bGQgYmUgMTA2LiBXYXMgMTAyLgorUEFTUyBoYXNib3RoLmdldEJvdW5kaW5nQ2xpZW50UmVj dCgpLmhlaWdodCBpcyAxMDYKICAgICAgIAo=