106083 2013-01-04 04:05:34 -0800 Regression(r138728): Causes crashes on the build bots 2013-01-04 05:20:35 -0800 1 1 1 Unclassified WebKit WebKit2 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 105442 1 cdumez cdumez cmarcelo gyuyoung.kim kenneth macpherson menard naginenis noam simon.fraser tmpsantos tonikitoo webkit.review.bot zeno oldest_to_newest 800136 0 cdumez 2013-01-04 04:05:34 -0800 crash log for WebKitTestRunner (pid 452): STDOUT: <empty> STDERR: SHOULD NEVER BE REACHED STDERR: /home/buildslave-1/webkit-buildslave/efl-linux-64-debug-wk2/build/Source/WebCore/platform/animation/TimingFunction.h(111) : static WTF::PassRefPtr<WebCore::CubicBezierTimingFunction> WebCore::CubicBezierTimingFunction::create(WebCore::CubicBezierTimingFunction::TimingFunctionPreset) STDERR: 1 0x7fa0674c9728 WebCore::CubicBezierTimingFunction::create(WebCore::CubicBezierTimingFunction::TimingFunctionPreset) STDERR: 2 0x7fa0642c5d1e CoreIPC::decodeTimingFunction(CoreIPC::ArgumentDecoder*, WTF::RefPtr<WebCore::TimingFunction>&) STDERR: 3 0x7fa0642c6659 CoreIPC::ArgumentCoder<WebCore::GraphicsLayerAnimation>::decode(CoreIPC::ArgumentDecoder*, WebCore::GraphicsLayerAnimation&) STDERR: 4 0x7fa0642cc879 bool CoreIPC::ArgumentDecoder::decode<WebCore::GraphicsLayerAnimation>(WebCore::GraphicsLayerAnimation&) STDERR: 5 0x7fa0642cbf02 CoreIPC::VectorArgumentCoder<false, WebCore::GraphicsLayerAnimation>::decode(CoreIPC::ArgumentDecoder*, WTF::Vector<WebCore::GraphicsLayerAnimation, 0ul>&) STDERR: 6 0x7fa0642ca6a5 bool CoreIPC::ArgumentDecoder::decode<WTF::Vector<WebCore::GraphicsLayerAnimation, 0ul> >(WTF::Vector<WebCore::GraphicsLayerAnimation, 0ul>&) STDERR: 7 0x7fa0642c6950 CoreIPC::ArgumentCoder<WebCore::GraphicsLayerAnimations>::decode(CoreIPC::ArgumentDecoder*, WebCore::GraphicsLayerAnimations&) STDERR: 8 0x7fa06456cf0f bool CoreIPC::ArgumentDecoder::decode<WebCore::GraphicsLayerAnimations>(WebCore::GraphicsLayerAnimations&) STDERR: 9 0x7fa06456cde4 CoreIPC::Arguments2<unsigned int, WebCore::GraphicsLayerAnimations>::decode(CoreIPC::ArgumentDecoder*, CoreIPC::Arguments2<unsigned int, WebCore::GraphicsLayerAnimations>&) STDERR: 10 0x7fa06456cb69 CoreIPC::ArgumentCoder<CoreIPC::Arguments2<unsigned int, WebCore::GraphicsLayerAnimations> >::decode(CoreIPC::ArgumentDecoder*, CoreIPC::Arguments2<unsigned int, WebCore::GraphicsLayerAnimations>&) STDERR: 11 0x7fa06456c7b7 bool CoreIPC::ArgumentDecoder::decode<CoreIPC::Arguments2<unsigned int, WebCore::GraphicsLayerAnimations> >(CoreIPC::Arguments2<unsigned int, WebCore::GraphicsLayerAnimations>&) STDERR: 12 0x7fa06456bef0 void CoreIPC::handleMessage<Messages::CoordinatedLayerTreeHostProxy::SetLayerAnimations, WebKit::CoordinatedLayerTreeHostProxy, void (WebKit::CoordinatedLayerTreeHostProxy::*)(unsigned int, WebCore::GraphicsLayerAnimations const&)>(CoreIPC::MessageDecoder&, WebKit::CoordinatedLayerTreeHostProxy*, void (WebKit::CoordinatedLayerTreeHostProxy::*)(unsigned int, WebCore::GraphicsLayerAnimations const&)) STDERR: 13 0x7fa06456b334 WebKit::CoordinatedLayerTreeHostProxy::didReceiveCoordinatedLayerTreeHostProxyMessage(CoreIPC::Connection*, CoreIPC::MessageID, CoreIPC::MessageDecoder&) STDERR: 14 0x7fa0642dedfb WebKit::DrawingAreaProxyImpl::didReceiveCoordinatedLayerTreeHostProxyMessage(CoreIPC::Connection*, CoreIPC::MessageID, CoreIPC::MessageDecoder&) STDERR: 15 0x7fa0643396f4 WebKit::WebPageProxy::didReceiveMessage(CoreIPC::Connection*, CoreIPC::MessageID, CoreIPC::MessageDecoder&) STDERR: 16 0x7fa06437ae8b WebKit::WebProcessProxy::didReceiveMessage(CoreIPC::Connection*, CoreIPC::MessageID, CoreIPC::MessageDecoder&) STDERR: 17 0x7fa06425c72c CoreIPC::Connection::dispatchMessage(CoreIPC::MessageID, CoreIPC::MessageDecoder&) STDERR: 18 0x7fa06425c898 CoreIPC::Connection::dispatchMessage(CoreIPC::Connection::Message<CoreIPC::MessageDecoder>&) STDERR: 19 0x7fa06425cae3 CoreIPC::Connection::dispatchOneMessage() STDERR: 20 0x7fa06426737a WTF::FunctionWrapper<void (CoreIPC::Connection::*)()>::operator()(CoreIPC::Connection*) STDERR: 21 0x7fa064267180 WTF::BoundFunctionImpl<WTF::FunctionWrapper<void (CoreIPC::Connection::*)()>, void (CoreIPC::Connection*)>::operator()() STDERR: 22 0x7fa06bba2eb2 WTF::Function<void ()>::operator()() const STDERR: 23 0x7fa067c4dd57 WebCore::RunLoop::performWork() STDERR: 24 0x7fa068737d06 WebCore::RunLoop::wakeUpEvent(void*, void*, unsigned int) STDERR: 25 0x7fa06360b621 STDERR: 26 0x7fa06360a571 STDERR: 27 0x7fa06360aab7 ecore_main_loop_begin STDERR: 28 0x434b05 WTR::TestController::platformRunUntil(bool&, double) STDERR: 29 0x41f50c WTR::TestController::runUntil(bool&, WTR::TestController::TimeoutDuration) STDERR: 30 0x426649 WTR::TestInvocation::invoke() STDERR: 31 0x41f244 WTR::TestController::runTest(char const*) STDERR: LEAK: 24 WebCoreNode 800141 1 181288 cdumez 2013-01-04 04:11:15 -0800 Created attachment 181288 Patch 800143 2 cdumez 2013-01-04 04:20:29 -0800 For reference, here is the decoding code: ///// case TimingFunction::CubicBezierFunction: { double x1, y1, x2, y2; CubicBezierTimingFunction::TimingFunctionPreset bezierPreset; if (!decoder->decodeEnum(bezierPreset)) return false; if (bezierPreset != CubicBezierTimingFunction::Custom) { timingFunction = CubicBezierTimingFunction::create(bezierPreset); return true; } if (!decoder->decodeDouble(x1)) return false; if (!decoder->decodeDouble(y1)) return false; if (!decoder->decodeDouble(x2)) return false; if (!decoder->decodeDouble(y2)) return false; timingFunction = CubicBezierTimingFunction::create(x1, y1, x2, y2); return true; } ///// As you can see, it returns early if the bezierPreset is not set custom and it does not decode the x/y parameters. Therefore, we should not encode them in the first place if bezierPreset is not set to custom. 800148 3 181288 webkit.review.bot 2013-01-04 04:51:21 -0800 Comment on attachment 181288 Patch Clearing flags on attachment: 181288 Committed r138790: <http://trac.webkit.org/changeset/138790> 800149 4 webkit.review.bot 2013-01-04 04:51:26 -0800 All reviewed patches have been landed. Closing bug. 800153 5 menard 2013-01-04 05:20:35 -0800 (In reply to comment #4) > All reviewed patches have been landed. Closing bug. Sorry about that. 181288 2013-01-04 04:11:15 -0800 2013-01-04 04:51:21 -0800 Patch 106083_bezierPreset.patch text/plain 2248 cdumez ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJLaXQyL0NoYW5nZUxvZyBiL1NvdXJjZS9XZWJLaXQyL0No YW5nZUxvZwppbmRleCA5Mzg0MTVkLi42YjQyNTVlIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViS2l0 Mi9DaGFuZ2VMb2cKKysrIGIvU291cmNlL1dlYktpdDIvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMjAg QEAKKzIwMTMtMDEtMDQgIENocmlzdG9waGUgRHVtZXogIDxjaHJpc3RvcGhlLmR1bWV6QGludGVs LmNvbT4KKworICAgICAgICBSZWdyZXNzaW9uKHIxMzg3MjgpOiBDYXVzZXMgY3Jhc2hlcyBvbiB0 aGUgYnVpbGQgYm90cworICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5j Z2k/aWQ9MTA2MDgzCisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAg ICAgICAgVXBkYXRlIGVuY29kZVRpbWluZ0Z1bmN0aW9uKCkgdG8gZW5jb2RlIHRoZSB4L3kgbWVt YmVycyBvbmx5CisgICAgICAgIGlmIHRoZSBiZXppZXJQcmVzZXQgaXMgc2V0IHRvIGN1c3RvbS4g VGhpcyBpcyBuZWVkZWQgYmVjYXVzZQorICAgICAgICBkZWNvZGVUaW1pbmdGdW5jdGlvbigpIG9u bHkgZGVjb2RlcyB4L3kgbWVtYmVycyBpZiB0aGUKKyAgICAgICAgYmV6aWVyUHJlc2V0IGlzIHNl dCB0byBjdXN0b20uCisKKyAgICAgICAgVGhpcyBmaXhlcyBhc3NlcnRpb24gaGl0cyBvbiB0aGUg ZGVidWcgYnVpbGQgYm90cy4KKworICAgICAgICAqIFNoYXJlZC9Db29yZGluYXRlZEdyYXBoaWNz L0Nvb3JkaW5hdGVkR3JhcGhpY3NBcmd1bWVudENvZGVycy5jcHA6CisgICAgICAgIChDb3JlSVBD OjplbmNvZGVUaW1pbmdGdW5jdGlvbik6CisKIDIwMTMtMDEtMDQgIENhcmxvcyBHYXJjaWEgQ2Ft cG9zICA8Y2dhcmNpYUBpZ2FsaWEuY29tPgogCiAgICAgICAgIFtTT1VQXSBDb252ZXJ0IFdlYlNv dXBSZXF1ZXN0TWFuYWdlclByb3h5IHRvIGJlIFdlYkNvbnRleHRTdXBwbGVtZW50CmRpZmYgLS1n aXQgYS9Tb3VyY2UvV2ViS2l0Mi9TaGFyZWQvQ29vcmRpbmF0ZWRHcmFwaGljcy9Db29yZGluYXRl ZEdyYXBoaWNzQXJndW1lbnRDb2RlcnMuY3BwIGIvU291cmNlL1dlYktpdDIvU2hhcmVkL0Nvb3Jk aW5hdGVkR3JhcGhpY3MvQ29vcmRpbmF0ZWRHcmFwaGljc0FyZ3VtZW50Q29kZXJzLmNwcAppbmRl eCA0ODNhNDViLi5iZTI2MWExIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViS2l0Mi9TaGFyZWQvQ29v cmRpbmF0ZWRHcmFwaGljcy9Db29yZGluYXRlZEdyYXBoaWNzQXJndW1lbnRDb2RlcnMuY3BwCisr KyBiL1NvdXJjZS9XZWJLaXQyL1NoYXJlZC9Db29yZGluYXRlZEdyYXBoaWNzL0Nvb3JkaW5hdGVk R3JhcGhpY3NBcmd1bWVudENvZGVycy5jcHAKQEAgLTU1NSwxMSArNTU1LDE0IEBAIHN0YXRpYyB2 b2lkIGVuY29kZVRpbWluZ0Z1bmN0aW9uKEFyZ3VtZW50RW5jb2RlciYgZW5jb2RlciwgY29uc3Qg VGltaW5nRnVuY3Rpb24qCiAgICAgICAgIGJyZWFrOwogICAgIGNhc2UgVGltaW5nRnVuY3Rpb246 OkN1YmljQmV6aWVyRnVuY3Rpb246IHsKICAgICAgICAgY29uc3QgQ3ViaWNCZXppZXJUaW1pbmdG dW5jdGlvbiogY3ViaWMgPSBzdGF0aWNfY2FzdDxjb25zdCBDdWJpY0JlemllclRpbWluZ0Z1bmN0 aW9uKj4odGltaW5nRnVuY3Rpb24pOwotICAgICAgICBlbmNvZGVyLmVuY29kZUVudW0oY3ViaWMt PnRpbWluZ0Z1bmN0aW9uUHJlc2V0KCkpOwotICAgICAgICBlbmNvZGVyIDw8IGN1YmljLT54MSgp OwotICAgICAgICBlbmNvZGVyIDw8IGN1YmljLT55MSgpOwotICAgICAgICBlbmNvZGVyIDw8IGN1 YmljLT54MigpOwotICAgICAgICBlbmNvZGVyIDw8IGN1YmljLT55MigpOworICAgICAgICBDdWJp Y0JlemllclRpbWluZ0Z1bmN0aW9uOjpUaW1pbmdGdW5jdGlvblByZXNldCBiZXppZXJQcmVzZXQg PSBjdWJpYy0+dGltaW5nRnVuY3Rpb25QcmVzZXQoKTsKKyAgICAgICAgZW5jb2Rlci5lbmNvZGVF bnVtKGJlemllclByZXNldCk7CisgICAgICAgIGlmIChiZXppZXJQcmVzZXQgPT0gQ3ViaWNCZXpp ZXJUaW1pbmdGdW5jdGlvbjo6Q3VzdG9tKSB7CisgICAgICAgICAgICBlbmNvZGVyIDw8IGN1Ymlj LT54MSgpOworICAgICAgICAgICAgZW5jb2RlciA8PCBjdWJpYy0+eTEoKTsKKyAgICAgICAgICAg IGVuY29kZXIgPDwgY3ViaWMtPngyKCk7CisgICAgICAgICAgICBlbmNvZGVyIDw8IGN1YmljLT55 MigpOworICAgICAgICB9CiAgICAgICAgIGJyZWFrOwogICAgIH0KICAgICBjYXNlIFRpbWluZ0Z1 bmN0aW9uOjpTdGVwc0Z1bmN0aW9uOiB7Cg==