<?xml version="1.0" encoding="UTF-8" standalone="yes" ?>
<!DOCTYPE bugzilla SYSTEM "https://bugs.webkit.org/page.cgi?id=bugzilla.dtd">

<bugzilla version="5.0.4.1"
          urlbase="https://bugs.webkit.org/"
          
          maintainer="admin@webkit.org"
>

    <bug>
          <bug_id>105816</bug_id>
          
          <creation_ts>2012-12-27 20:59:00 -0800</creation_ts>
          <short_desc>[EFL][WebGL] Add compile time support for GLES2.</short_desc>
          <delta_ts>2012-12-31 08:58:04 -0800</delta_ts>
          <reporter_accessible>1</reporter_accessible>
          <cclist_accessible>1</cclist_accessible>
          <classification_id>1</classification_id>
          <classification>Unclassified</classification>
          <product>WebKit</product>
          <component>WebKit EFL</component>
          <version>528+ (Nightly build)</version>
          <rep_platform>PC</rep_platform>
          <op_sys>Linux</op_sys>
          <bug_status>RESOLVED</bug_status>
          <resolution>FIXED</resolution>
          
          
          <bug_file_loc></bug_file_loc>
          <status_whiteboard></status_whiteboard>
          <keywords></keywords>
          <priority>P2</priority>
          <bug_severity>Normal</bug_severity>
          <target_milestone>---</target_milestone>
          <dependson>105876</dependson>
          <blocked>105659</blocked>
          <everconfirmed>1</everconfirmed>
          <reporter name="Kalyan">kalyan.kondapally</reporter>
          <assigned_to name="Kalyan">kalyan.kondapally</assigned_to>
          <cc>gyuyoung.kim</cc>
    
    <cc>kenneth</cc>
    
    <cc>laszlo.gombos</cc>
    
    <cc>lucas.de.marchi</cc>
    
    <cc>rakuco</cc>
    
    <cc>tmpsantos</cc>
    
    <cc>webkit.review.bot</cc>
          

      

      

      

          <comment_sort_order>oldest_to_newest</comment_sort_order>  
          <long_desc isprivate="0" >
    <commentid>797744</commentid>
    <comment_count>0</comment_count>
    <who name="Kalyan">kalyan.kondapally</who>
    <bug_when>2012-12-27 20:59:00 -0800</bug_when>
    <thetext>Add GLES2 compile time support in OptionsEfl.cmake and PlatformEfl.cmake.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>797768</commentid>
    <comment_count>1</comment_count>
      <attachid>180847</attachid>
    <who name="Kalyan">kalyan.kondapally</who>
    <bug_when>2012-12-27 22:54:23 -0800</bug_when>
    <thetext>Created attachment 180847
patch</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>797833</commentid>
    <comment_count>2</comment_count>
      <attachid>180847</attachid>
    <who name="Thiago Marcos P. Santos">tmpsantos</who>
    <bug_when>2012-12-28 02:15:05 -0800</bug_when>
    <thetext>Comment on attachment 180847
patch

View in context: https://bugs.webkit.org/attachment.cgi?id=180847&amp;action=review

&gt; Source/cmake/OptionsEfl.cmake:191
&gt; +        option(ENABLE_GLES2 ON)
&gt; +
&gt; +        if (ENABLE_GLES2)

This if() looks unnecessary since it will never fail. Do we need to set this option()?</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>797954</commentid>
    <comment_count>3</comment_count>
    <who name="Kalyan">kalyan.kondapally</who>
    <bug_when>2012-12-28 11:52:16 -0800</bug_when>
    <thetext>(In reply to comment #2)
&gt; (From update of attachment 180847 [details])
&gt; View in context: https://bugs.webkit.org/attachment.cgi?id=180847&amp;action=review
&gt; 
&gt; &gt; Source/cmake/OptionsEfl.cmake:191
&gt; &gt; +        option(ENABLE_GLES2 ON)
&gt; &gt; +
&gt; &gt; +        if (ENABLE_GLES2)
&gt; 
&gt; This if() looks unnecessary since it will never fail. Do we need to set this option()?

Yes,in order to enable the option (ENABLE_GLES2), we need to pass --cmakeargs=&quot;-DENABLE_GLES2=ON&quot; to the built-webkit` script, otherwise it is never set and the if condition will fail. Atleast that&apos;s how I understood the usage of option.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>798265</commentid>
    <comment_count>4</comment_count>
      <attachid>180847</attachid>
    <who name="Kalyan">kalyan.kondapally</who>
    <bug_when>2012-12-30 14:14:54 -0800</bug_when>
    <thetext>Comment on attachment 180847
patch

removing request for cq till https://bugs.webkit.org/show_bug.cgi?id=105876 is done</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>798323</commentid>
    <comment_count>5</comment_count>
      <attachid>180968</attachid>
    <who name="Kalyan">kalyan.kondapally</who>
    <bug_when>2012-12-31 04:11:25 -0800</bug_when>
    <thetext>Created attachment 180968
patch v2

rebased patch</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>798328</commentid>
    <comment_count>6</comment_count>
      <attachid>180968</attachid>
    <who name="WebKit Review Bot">webkit.review.bot</who>
    <bug_when>2012-12-31 05:00:25 -0800</bug_when>
    <thetext>Comment on attachment 180968
patch v2

Rejecting attachment 180968 from commit-queue.

Failed to run &quot;[u&apos;/mnt/git/webkit-commit-queue/Tools/Scripts/webkit-patch&apos;, u&apos;--status-host=queues.webkit.org&apos;, ...&quot; exit_code: 1 cwd: /mnt/git/webkit-commit-queue

/mnt/git/webkit-commit-queue/Source/WebCore/ChangeLog neither lists a valid reviewer nor contains the string &quot;Unreviewed&quot; or &quot;Rubber stamp&quot; (case insensitive).

Full output: http://queues.webkit.org/results/15593747</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>798329</commentid>
    <comment_count>7</comment_count>
      <attachid>180968</attachid>
    <who name="Kenneth Rohde Christiansen">kenneth</who>
    <bug_when>2012-12-31 05:02:31 -0800</bug_when>
    <thetext>Comment on attachment 180968
patch v2

View in context: https://bugs.webkit.org/attachment.cgi?id=180968&amp;action=review

&gt; Source/WebCore/ChangeLog:8
&gt; +        [EFL][WebGL] Add compile time support for GLES2.
&gt; +        https://bugs.webkit.org/show_bug.cgi?id=105816
&gt; +
&gt; +        This patch adds build support for GLES2.
&gt; +        GLES2 support can be enabled during compile time by passing -DENABLE_GLES2=ON as
&gt; +        cmake config parameter. GLES2 options is not enabled by default. This patch doesn&apos;t

missing reviewer (OOPS!) part</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>798368</commentid>
    <comment_count>8</comment_count>
      <attachid>180977</attachid>
    <who name="Kalyan">kalyan.kondapally</who>
    <bug_when>2012-12-31 08:35:33 -0800</bug_when>
    <thetext>Created attachment 180977
patchv3</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>798369</commentid>
    <comment_count>9</comment_count>
      <attachid>180977</attachid>
    <who name="WebKit Review Bot">webkit.review.bot</who>
    <bug_when>2012-12-31 08:57:58 -0800</bug_when>
    <thetext>Comment on attachment 180977
patchv3

Clearing flags on attachment: 180977

Committed r138598: &lt;http://trac.webkit.org/changeset/138598&gt;</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>798370</commentid>
    <comment_count>10</comment_count>
    <who name="WebKit Review Bot">webkit.review.bot</who>
    <bug_when>2012-12-31 08:58:04 -0800</bug_when>
    <thetext>All reviewed patches have been landed.  Closing bug.</thetext>
  </long_desc>
      
          <attachment
              isobsolete="1"
              ispatch="1"
              isprivate="0"
          >
            <attachid>180847</attachid>
            <date>2012-12-27 22:54:23 -0800</date>
            <delta_ts>2012-12-31 04:11:25 -0800</delta_ts>
            <desc>patch</desc>
            <filename>confighelp.patch</filename>
            <type>text/plain</type>
            <size>4374</size>
            <attacher name="Kalyan">kalyan.kondapally</attacher>
            
              <data encoding="base64">ZGlmZiAtLWdpdCBDaGFuZ2VMb2cgQ2hhbmdlTG9nCmluZGV4IGVhYzUyZTUuLmQ2Y2E4MzYgMTAw
NjQ0Ci0tLSBDaGFuZ2VMb2cKKysrIENoYW5nZUxvZwpAQCAtMSw1ICsxLDIwIEBACiAyMDEyLTEy
LTI3ICBLb25kYXBhbGx5IEthbHlhbiAgPGthbHlhbi5rb25kYXBhbGx5QGludGVsLmNvbT4KIAor
ICAgICAgICBbRUZMXVtXZWJHTF0gQWRkIGNvbXBpbGUgdGltZSBzdXBwb3J0IGZvciBHTEVTMi4K
KyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTEwNTgxNgor
CisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIFRoaXMgcGF0
Y2ggYWRkcyBidWlsZCBzdXBwb3J0IGZvciBHTEVTMi4KKyAgICAgICAgR0xFUzIgc3VwcG9ydCBj
YW4gYmUgZW5hYmxlZCBkdXJpbmcgY29tcGlsZSB0aW1lIGJ5IHBhc3NpbmcgLURFTkFCTEVfR0xF
UzI9T04gYXMKKyAgICAgICAgY21ha2UgY29uZmlnIHBhcmFtZXRlci4gR0xFUzIgb3B0aW9ucyBp
cyBub3QgZW5hYmxlZCBieSBkZWZhdWx0LiBUaGlzIHBhdGNoIGRvZXNuJ3QKKyAgICAgICAgYWRk
cmVzcyBhbGwgdGhlIGJ1aWxkIGlzc3VlcyByZWxhdGVkIHRvIEdMRVMyIGJ1dCBvbmx5IGFkZHMg
dGhlIG5lZWRlZCBzdXBwb3J0IGluCisgICAgICAgIE9wdGlvbnNFZmwuY21ha2UuCisKKyAgICAg
ICAgKiBTb3VyY2UvY21ha2UvT3B0aW9uc0VmbC5jbWFrZToKKworMjAxMi0xMi0yNyAgS29uZGFw
YWxseSBLYWx5YW4gIDxrYWx5YW4ua29uZGFwYWxseUBpbnRlbC5jb20+CisKICAgICAgICAgW0VG
TF1bV2ViR0xdIEltcGxlbWVudCBFR0wgc3VwcG9ydCB3aXRoIEdMWC4KICAgICAgICAgaHR0cHM6
Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTEwNTYwMgogCmRpZmYgLS1naXQgU291
cmNlL1dlYkNvcmUvQ2hhbmdlTG9nIFNvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZwppbmRleCBkMDYz
ZTgxLi5hN2ExYWNhIDEwMDY0NAotLS0gU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBTb3Vy
Y2UvV2ViQ29yZS9DaGFuZ2VMb2cKQEAgLTEsNSArMSwxOCBAQAogMjAxMi0xMi0yNyAgS29uZGFw
YWxseSBLYWx5YW4gIDxrYWx5YW4ua29uZGFwYWxseUBpbnRlbC5jb20+CiAKKyAgICAgICAgW0VG
TF1bV2ViR0xdIEFkZCBjb21waWxlIHRpbWUgc3VwcG9ydCBmb3IgR0xFUzIuCisgICAgICAgIGh0
dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xMDU4MTYKKworICAgICAgICBU
aGlzIHBhdGNoIGFkZHMgYnVpbGQgc3VwcG9ydCBmb3IgR0xFUzIuCisgICAgICAgIEdMRVMyIHN1
cHBvcnQgY2FuIGJlIGVuYWJsZWQgZHVyaW5nIGNvbXBpbGUgdGltZSBieSBwYXNzaW5nIC1ERU5B
QkxFX0dMRVMyPU9OIGFzCisgICAgICAgIGNtYWtlIGNvbmZpZyBwYXJhbWV0ZXIuIEdMRVMyIG9w
dGlvbnMgaXMgbm90IGVuYWJsZWQgYnkgZGVmYXVsdC4gVGhpcyBwYXRjaCBkb2Vzbid0CisgICAg
ICAgIGFkZHJlc3MgYWxsIHRoZSBidWlsZCBpc3N1ZXMgcmVsYXRlZCB0byBHTEVTMiBidXQgb25s
eSBhZGRzIHRoZSBuZWVkZWQgc3VwcG9ydCBpbgorICAgICAgICBQbGF0Zm9ybUVmbC5jbWFrZS4K
KworICAgICAgICAqIFBsYXRmb3JtRWZsLmNtYWtlOgorCisyMDEyLTEyLTI3ICBLb25kYXBhbGx5
IEthbHlhbiAgPGthbHlhbi5rb25kYXBhbGx5QGludGVsLmNvbT4KKwogICAgICAgICBbRUZMXVtX
ZWJHTF0gQWRkIE9QRU5HTF9FU18yIGNoZWNrcy4KICAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtp
dC5vcmcvc2hvd19idWcuY2dpP2lkPTEwNTgwNQogCmRpZmYgLS1naXQgU291cmNlL1dlYkNvcmUv
UGxhdGZvcm1FZmwuY21ha2UgU291cmNlL1dlYkNvcmUvUGxhdGZvcm1FZmwuY21ha2UKaW5kZXgg
ZTdlNDY5Yy4uMmZjZmNjMiAxMDA2NDQKLS0tIFNvdXJjZS9XZWJDb3JlL1BsYXRmb3JtRWZsLmNt
YWtlCisrKyBTb3VyY2UvV2ViQ29yZS9QbGF0Zm9ybUVmbC5jbWFrZQpAQCAtMjc0LDcgKzI3NCw2
IEBAIGlmIChXVEZfVVNFXzNEX0dSQVBISUNTKQogICAgIGVuZGlmICgpCiAKICAgICBsaXN0KEFQ
UEVORCBXZWJDb3JlX1NPVVJDRVMKLSAgICAgICAgcGxhdGZvcm0vZ3JhcGhpY3MvT3BlbkdMU2hp
bXMuY3BwCiAgICAgICAgIHBsYXRmb3JtL2dyYXBoaWNzL2NhaXJvL0RyYXdpbmdCdWZmZXJDYWly
by5jcHAKICAgICAgICAgcGxhdGZvcm0vZ3JhcGhpY3MvZWZsL0dyYXBoaWNzQ29udGV4dDNERWZs
LmNwcAogICAgICAgICBwbGF0Zm9ybS9ncmFwaGljcy9lZmwvR3JhcGhpY3NDb250ZXh0M0RQcml2
YXRlLmNwcApAQCAtMjgyLDcgKzI4MSw2IEBAIGlmIChXVEZfVVNFXzNEX0dSQVBISUNTKQogICAg
ICAgICBwbGF0Zm9ybS9ncmFwaGljcy9vcGVuZ2wvRXh0ZW5zaW9uczNET3BlbkdMQ29tbW9uLmNw
cAogICAgICAgICBwbGF0Zm9ybS9ncmFwaGljcy9vcGVuZ2wvR0xQbGF0Zm9ybUNvbnRleHQuY3Bw
CiAgICAgICAgIHBsYXRmb3JtL2dyYXBoaWNzL29wZW5nbC9HTFBsYXRmb3JtU3VyZmFjZS5jcHAK
LSAgICAgICAgcGxhdGZvcm0vZ3JhcGhpY3Mvb3BlbmdsL0dyYXBoaWNzQ29udGV4dDNET3BlbkdM
LmNwcAogICAgICAgICBwbGF0Zm9ybS9ncmFwaGljcy9vcGVuZ2wvR3JhcGhpY3NDb250ZXh0M0RP
cGVuR0xDb21tb24uY3BwCiAgICAgICAgIHBsYXRmb3JtL2dyYXBoaWNzL3N1cmZhY2VzL0dyYXBo
aWNzU3VyZmFjZS5jcHAKICAgICAgICAgcGxhdGZvcm0vZ3JhcGhpY3Mvc3VyZmFjZXMvZ2x4L0dy
YXBoaWNzU3VyZmFjZUdMWC5jcHAKQEAgLTI5Myw2ICsyOTEsNyBAQCBpZiAoV1RGX1VTRV8zRF9H
UkFQSElDUykKIAogICAgIGlmIChXVEZfVVNFX0VHTCkKICAgICAgICAgbGlzdChBUFBFTkQgV2Vi
Q29yZV9TT1VSQ0VTCisgICAgICAgICAgICBwbGF0Zm9ybS9ncmFwaGljcy9zdXJmYWNlcy9lZ2wv
RUdMQ29uZmlnSGVscGVyLmNwcAogICAgICAgICAgICAgcGxhdGZvcm0vZ3JhcGhpY3Mvc3VyZmFj
ZXMvZWdsL0VHTFN1cmZhY2UuY3BwCiAgICAgICAgICAgICBwbGF0Zm9ybS9ncmFwaGljcy9zdXJm
YWNlcy9lZ2wvRUdMQ29udGV4dC5jcHAKICAgICAgICAgKQpAQCAtMzA1LDYgKzMwNCwxOSBAQCBp
ZiAoV1RGX1VTRV8zRF9HUkFQSElDUykKICAgICAgICAgKQogICAgIGVuZGlmICgpCiAKKyAgICBp
ZiAoV1RGX1VTRV9PUEVOR0xfRVNfMikKKyAgICAgICAgbGlzdChBUFBFTkQgV2ViQ29yZV9TT1VS
Q0VTCisgICAgICAgICAgICBwbGF0Zm9ybS9ncmFwaGljcy9vcGVuZ2wvRXh0ZW5zaW9uczNET3Bl
bkdMRVMuY3BwCisgICAgICAgICAgICBwbGF0Zm9ybS9ncmFwaGljcy9vcGVuZ2wvR3JhcGhpY3ND
b250ZXh0M0RPcGVuR0xFUy5jcHAKKyAgICAgICAgKQorICAgIGVsc2UgKCkKKyAgICAgICAgbGlz
dChBUFBFTkQgV2ViQ29yZV9TT1VSQ0VTCisgICAgICAgICAgICBwbGF0Zm9ybS9ncmFwaGljcy9v
cGVuZ2wvRXh0ZW5zaW9uczNET3BlbkdMLmNwcAorICAgICAgICAgICAgcGxhdGZvcm0vZ3JhcGhp
Y3Mvb3BlbmdsL0dyYXBoaWNzQ29udGV4dDNET3BlbkdMLmNwcAorICAgICAgICAgICAgcGxhdGZv
cm0vZ3JhcGhpY3MvT3BlbkdMU2hpbXMuY3BwCisgICAgICAgICkKKyAgICBlbmRpZiAoKQorCiAg
ICAgbGlzdChBUFBFTkQgV2ViQ29yZV9MSUJSQVJJRVMKICAgICAgICAgJHtYMTFfWDExX0xJQn0K
ICAgICAgICAgJHtYMTFfWGNvbXBvc2l0ZV9MSUJ9CmRpZmYgLS1naXQgU291cmNlL2NtYWtlL09w
dGlvbnNFZmwuY21ha2UgU291cmNlL2NtYWtlL09wdGlvbnNFZmwuY21ha2UKaW5kZXggZmUyMDJl
Zi4uMTgxNjcxZiAxMDA2NDQKLS0tIFNvdXJjZS9jbWFrZS9PcHRpb25zRWZsLmNtYWtlCisrKyBT
b3VyY2UvY21ha2UvT3B0aW9uc0VmbC5jbWFrZQpAQCAtMTg2LDYgKzE4NiwxNiBAQCBpZiAoRU5B
QkxFX1dFQkdMIE9SIFdURl9VU0VfVElMRURfQkFDS0lOR19TVE9SRSkKICAgICBpZiAoRUdMX0ZP
VU5EKQogICAgICAgICBzZXQoV1RGX1VTRV9FR0wgMSkKICAgICAgICAgYWRkX2RlZmluaXRpb25z
KC1EV1RGX1VTRV9FR0w9MSkKKyAgICAgICAgb3B0aW9uKEVOQUJMRV9HTEVTMiBPTikKKworICAg
ICAgICBpZiAoRU5BQkxFX0dMRVMyKQorICAgICAgICAgICAgZmluZF9wYWNrYWdlKEdMRVMgUkVR
VUlSRUQpCisgICAgICAgIGVuZGlmICgpCisKKyAgICAgICAgaWYgKE9QRU5HTEVTMl9GT1VORCkK
KyAgICAgICAgICAgIHNldChXVEZfVVNFX09QRU5HTF9FU18yIDEpCisgICAgICAgICAgICBhZGRf
ZGVmaW5pdGlvbnMoLURXVEZfVVNFX09QRU5HTF9FU18yPTEpCisgICAgICAgIGVuZGlmICgpCiAg
ICAgIGVsc2VpZiAoT1BFTkdMWF9GT1VORCkKICAgICAgICAgIHNldChXVEZfVVNFX0dMWCAxKQog
ICAgICAgICAgYWRkX2RlZmluaXRpb25zKC1EV1RGX1VTRV9HTFg9MSkK
</data>

          </attachment>
          <attachment
              isobsolete="1"
              ispatch="1"
              isprivate="0"
          >
            <attachid>180968</attachid>
            <date>2012-12-31 04:11:25 -0800</date>
            <delta_ts>2012-12-31 08:35:33 -0800</delta_ts>
            <desc>patch v2</desc>
            <filename>gles2compile.patch</filename>
            <type>text/plain</type>
            <size>3998</size>
            <attacher name="Kalyan">kalyan.kondapally</attacher>
            
              <data encoding="base64">ZGlmZiAtLWdpdCBDaGFuZ2VMb2cgQ2hhbmdlTG9nCmluZGV4IDI5ZTk2ZmMuLjEwMDg0MDUgMTAw
NjQ0Ci0tLSBDaGFuZ2VMb2cKKysrIENoYW5nZUxvZwpAQCAtMSwzICsxLDE4IEBACisyMDEyLTEy
LTMxICBLb25kYXBhbGx5IEthbHlhbiAgPGthbHlhbi5rb25kYXBhbGx5QGludGVsLmNvbT4KKwor
ICAgICAgICBbRUZMXVtXZWJHTF0gQWRkIGNvbXBpbGUgdGltZSBzdXBwb3J0IGZvciBHTEVTMi4K
KyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTEwNTgxNgor
CisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIFRoaXMgcGF0
Y2ggYWRkcyBidWlsZCBzdXBwb3J0IGZvciBHTEVTMi4KKyAgICAgICAgR0xFUzIgc3VwcG9ydCBj
YW4gYmUgZW5hYmxlZCBkdXJpbmcgY29tcGlsZSB0aW1lIGJ5IHBhc3NpbmcgLURFTkFCTEVfR0xF
UzI9T04gYXMKKyAgICAgICAgY21ha2UgY29uZmlnIHBhcmFtZXRlci4gR0xFUzIgb3B0aW9ucyBp
cyBub3QgZW5hYmxlZCBieSBkZWZhdWx0LiBUaGlzIHBhdGNoIGRvZXNuJ3QKKyAgICAgICAgYWRk
cmVzcyBhbGwgdGhlIGJ1aWxkIGlzc3VlcyByZWxhdGVkIHRvIEdMRVMyIGJ1dCBvbmx5IGFkZHMg
dGhlIG5lZWRlZCBzdXBwb3J0IGluCisgICAgICAgIE9wdGlvbnNFZmwuY21ha2UuCisKKyAgICAg
ICAgKiBTb3VyY2UvY21ha2UvT3B0aW9uc0VmbC5jbWFrZToKKwogMjAxMi0xMi0zMCAgS29uZGFw
YWxseSBLYWx5YW4gIDxrYWx5YW4ua29uZGFwYWxseUBpbnRlbC5jb20+CiAKICAgICAgICAgW0VG
TF0gW1dlYkdMXSBSZW5hbWUgRUdMQ29uZmlnSGVscGVyIGFzIEVHTENvbmZpZ1NlbGVjdG9yLgpk
aWZmIC0tZ2l0IFNvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZyBTb3VyY2UvV2ViQ29yZS9DaGFuZ2VM
b2cKaW5kZXggOTE0MWMyNS4uYmIzMjA5NSAxMDA2NDQKLS0tIFNvdXJjZS9XZWJDb3JlL0NoYW5n
ZUxvZworKysgU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTYgQEAKKzIwMTIt
MTItMzEgIEtvbmRhcGFsbHkgS2FseWFuICA8a2FseWFuLmtvbmRhcGFsbHlAaW50ZWwuY29tPgor
CisgICAgICAgIFtFRkxdW1dlYkdMXSBBZGQgY29tcGlsZSB0aW1lIHN1cHBvcnQgZm9yIEdMRVMy
LgorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTA1ODE2
CisKKyAgICAgICAgVGhpcyBwYXRjaCBhZGRzIGJ1aWxkIHN1cHBvcnQgZm9yIEdMRVMyLgorICAg
ICAgICBHTEVTMiBzdXBwb3J0IGNhbiBiZSBlbmFibGVkIGR1cmluZyBjb21waWxlIHRpbWUgYnkg
cGFzc2luZyAtREVOQUJMRV9HTEVTMj1PTiBhcworICAgICAgICBjbWFrZSBjb25maWcgcGFyYW1l
dGVyLiBHTEVTMiBvcHRpb25zIGlzIG5vdCBlbmFibGVkIGJ5IGRlZmF1bHQuIFRoaXMgcGF0Y2gg
ZG9lc24ndAorICAgICAgICBhZGRyZXNzIGFsbCB0aGUgYnVpbGQgaXNzdWVzIHJlbGF0ZWQgdG8g
R0xFUzIgYnV0IG9ubHkgYWRkcyB0aGUgbmVlZGVkIHN1cHBvcnQgaW4KKyAgICAgICAgUGxhdGZv
cm1FZmwuY21ha2UuCisKKyAgICAgICAgKiBQbGF0Zm9ybUVmbC5jbWFrZToKKwogMjAxMi0xMi0z
MCAgS29uZGFwYWxseSBLYWx5YW4gIDxrYWx5YW4ua29uZGFwYWxseUBpbnRlbC5jb20+CiAKICAg
ICAgICAgW0VGTF0gW1dlYkdMXSBNaW5vciBjbGVhbnVwIGluIFBsYXRmb3JtQ29udGV4dC4KZGlm
ZiAtLWdpdCBTb3VyY2UvV2ViQ29yZS9QbGF0Zm9ybUVmbC5jbWFrZSBTb3VyY2UvV2ViQ29yZS9Q
bGF0Zm9ybUVmbC5jbWFrZQppbmRleCA3MTJkYjBhLi5lODY5NzA2IDEwMDY0NAotLS0gU291cmNl
L1dlYkNvcmUvUGxhdGZvcm1FZmwuY21ha2UKKysrIFNvdXJjZS9XZWJDb3JlL1BsYXRmb3JtRWZs
LmNtYWtlCkBAIC0yNzQsMTUgKzI3NCwxMiBAQCBpZiAoV1RGX1VTRV8zRF9HUkFQSElDUykKICAg
ICBlbmRpZiAoKQogCiAgICAgbGlzdChBUFBFTkQgV2ViQ29yZV9TT1VSQ0VTCi0gICAgICAgIHBs
YXRmb3JtL2dyYXBoaWNzL09wZW5HTFNoaW1zLmNwcAogICAgICAgICBwbGF0Zm9ybS9ncmFwaGlj
cy9jYWlyby9EcmF3aW5nQnVmZmVyQ2Fpcm8uY3BwCiAgICAgICAgIHBsYXRmb3JtL2dyYXBoaWNz
L2VmbC9HcmFwaGljc0NvbnRleHQzREVmbC5jcHAKICAgICAgICAgcGxhdGZvcm0vZ3JhcGhpY3Mv
ZWZsL0dyYXBoaWNzQ29udGV4dDNEUHJpdmF0ZS5jcHAKLSAgICAgICAgcGxhdGZvcm0vZ3JhcGhp
Y3Mvb3BlbmdsL0V4dGVuc2lvbnMzRE9wZW5HTC5jcHAKICAgICAgICAgcGxhdGZvcm0vZ3JhcGhp
Y3Mvb3BlbmdsL0V4dGVuc2lvbnMzRE9wZW5HTENvbW1vbi5jcHAKICAgICAgICAgcGxhdGZvcm0v
Z3JhcGhpY3Mvb3BlbmdsL0dMUGxhdGZvcm1Db250ZXh0LmNwcAogICAgICAgICBwbGF0Zm9ybS9n
cmFwaGljcy9vcGVuZ2wvR0xQbGF0Zm9ybVN1cmZhY2UuY3BwCi0gICAgICAgIHBsYXRmb3JtL2dy
YXBoaWNzL29wZW5nbC9HcmFwaGljc0NvbnRleHQzRE9wZW5HTC5jcHAKICAgICAgICAgcGxhdGZv
cm0vZ3JhcGhpY3Mvb3BlbmdsL0dyYXBoaWNzQ29udGV4dDNET3BlbkdMQ29tbW9uLmNwcAogICAg
ICAgICBwbGF0Zm9ybS9ncmFwaGljcy9zdXJmYWNlcy9HcmFwaGljc1N1cmZhY2UuY3BwCiAgICAg
ICAgIHBsYXRmb3JtL2dyYXBoaWNzL3N1cmZhY2VzL2dseC9HcmFwaGljc1N1cmZhY2VHTFguY3Bw
CkBAIC0zMDYsNiArMzAzLDE5IEBAIGlmIChXVEZfVVNFXzNEX0dSQVBISUNTKQogICAgICAgICAp
CiAgICAgZW5kaWYgKCkKIAorICAgIGlmIChXVEZfVVNFX09QRU5HTF9FU18yKQorICAgICAgICBs
aXN0KEFQUEVORCBXZWJDb3JlX1NPVVJDRVMKKyAgICAgICAgICAgIHBsYXRmb3JtL2dyYXBoaWNz
L29wZW5nbC9FeHRlbnNpb25zM0RPcGVuR0xFUy5jcHAKKyAgICAgICAgICAgIHBsYXRmb3JtL2dy
YXBoaWNzL29wZW5nbC9HcmFwaGljc0NvbnRleHQzRE9wZW5HTEVTLmNwcAorICAgICAgICApCisg
ICAgZWxzZSAoKQorICAgICAgICBsaXN0KEFQUEVORCBXZWJDb3JlX1NPVVJDRVMKKyAgICAgICAg
ICAgIHBsYXRmb3JtL2dyYXBoaWNzL29wZW5nbC9FeHRlbnNpb25zM0RPcGVuR0wuY3BwCisgICAg
ICAgICAgICBwbGF0Zm9ybS9ncmFwaGljcy9vcGVuZ2wvR3JhcGhpY3NDb250ZXh0M0RPcGVuR0wu
Y3BwCisgICAgICAgICAgICBwbGF0Zm9ybS9ncmFwaGljcy9PcGVuR0xTaGltcy5jcHAKKyAgICAg
ICAgKQorICAgIGVuZGlmICgpCisKICAgICBsaXN0KEFQUEVORCBXZWJDb3JlX0xJQlJBUklFUwog
ICAgICAgICAke1gxMV9YMTFfTElCfQogICAgICAgICAke1gxMV9YY29tcG9zaXRlX0xJQn0KZGlm
ZiAtLWdpdCBTb3VyY2UvY21ha2UvT3B0aW9uc0VmbC5jbWFrZSBTb3VyY2UvY21ha2UvT3B0aW9u
c0VmbC5jbWFrZQppbmRleCBmZTIwMmVmLi4xODE2NzFmIDEwMDY0NAotLS0gU291cmNlL2NtYWtl
L09wdGlvbnNFZmwuY21ha2UKKysrIFNvdXJjZS9jbWFrZS9PcHRpb25zRWZsLmNtYWtlCkBAIC0x
ODYsNiArMTg2LDE2IEBAIGlmIChFTkFCTEVfV0VCR0wgT1IgV1RGX1VTRV9USUxFRF9CQUNLSU5H
X1NUT1JFKQogICAgIGlmIChFR0xfRk9VTkQpCiAgICAgICAgIHNldChXVEZfVVNFX0VHTCAxKQog
ICAgICAgICBhZGRfZGVmaW5pdGlvbnMoLURXVEZfVVNFX0VHTD0xKQorICAgICAgICBvcHRpb24o
RU5BQkxFX0dMRVMyIE9OKQorCisgICAgICAgIGlmIChFTkFCTEVfR0xFUzIpCisgICAgICAgICAg
ICBmaW5kX3BhY2thZ2UoR0xFUyBSRVFVSVJFRCkKKyAgICAgICAgZW5kaWYgKCkKKworICAgICAg
ICBpZiAoT1BFTkdMRVMyX0ZPVU5EKQorICAgICAgICAgICAgc2V0KFdURl9VU0VfT1BFTkdMX0VT
XzIgMSkKKyAgICAgICAgICAgIGFkZF9kZWZpbml0aW9ucygtRFdURl9VU0VfT1BFTkdMX0VTXzI9
MSkKKyAgICAgICAgZW5kaWYgKCkKICAgICAgZWxzZWlmIChPUEVOR0xYX0ZPVU5EKQogICAgICAg
ICAgc2V0KFdURl9VU0VfR0xYIDEpCiAgICAgICAgICBhZGRfZGVmaW5pdGlvbnMoLURXVEZfVVNF
X0dMWD0xKQo=
</data>
<flag name="review"
          id="198413"
          type_id="1"
          status="+"
          setter="kenneth"
    />
    <flag name="commit-queue"
          id="198414"
          type_id="3"
          status="-"
          setter="webkit.review.bot"
    />
          </attachment>
          <attachment
              isobsolete="0"
              ispatch="1"
              isprivate="0"
          >
            <attachid>180977</attachid>
            <date>2012-12-31 08:35:33 -0800</date>
            <delta_ts>2012-12-31 08:57:58 -0800</delta_ts>
            <desc>patchv3</desc>
            <filename>gles2changes.patch</filename>
            <type>text/plain</type>
            <size>4095</size>
            <attacher name="Kalyan">kalyan.kondapally</attacher>
            
              <data encoding="base64">ZGlmZiAtLWdpdCBDaGFuZ2VMb2cgQ2hhbmdlTG9nCmluZGV4IGNjNTVlOTEuLmYyOTNkNTkgMTAw
NjQ0Ci0tLSBDaGFuZ2VMb2cKKysrIENoYW5nZUxvZwpAQCAtMSwzICsxLDE4IEBACisyMDEyLTEy
LTMxICBLb25kYXBhbGx5IEthbHlhbiAgPGthbHlhbi5rb25kYXBhbGx5QGludGVsLmNvbT4KKwor
ICAgICAgICBbRUZMXVtXZWJHTF0gQWRkIGNvbXBpbGUgdGltZSBzdXBwb3J0IGZvciBHTEVTMi4K
KyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTEwNTgxNgor
CisgICAgICAgIFJldmlld2VkIGJ5IEtlbm5ldGggUm9oZGUgQ2hyaXN0aWFuc2VuLgorCisgICAg
ICAgIFRoaXMgcGF0Y2ggYWRkcyBidWlsZCBzdXBwb3J0IGZvciBHTEVTMi4KKyAgICAgICAgR0xF
UzIgc3VwcG9ydCBjYW4gYmUgZW5hYmxlZCBkdXJpbmcgY29tcGlsZSB0aW1lIGJ5IHBhc3Npbmcg
LURFTkFCTEVfR0xFUzI9T04gYXMKKyAgICAgICAgY21ha2UgY29uZmlnIHBhcmFtZXRlci4gR0xF
UzIgb3B0aW9ucyBpcyBub3QgZW5hYmxlZCBieSBkZWZhdWx0LiBUaGlzIHBhdGNoIGRvZXNuJ3QK
KyAgICAgICAgYWRkcmVzcyBhbGwgdGhlIGJ1aWxkIGlzc3VlcyByZWxhdGVkIHRvIEdMRVMyIGJ1
dCBvbmx5IGFkZHMgdGhlIG5lZWRlZCBzdXBwb3J0IGluCisgICAgICAgIE9wdGlvbnNFZmwuY21h
a2UuCisKKyAgICAgICAgKiBTb3VyY2UvY21ha2UvT3B0aW9uc0VmbC5jbWFrZToKKwogMjAxMi0x
Mi0zMSAgQ2FybG9zIEdhcmNpYSBDYW1wb3MgIDxjZ2FyY2lhQGlnYWxpYS5jb20+CiAKICAgICAg
ICAgW0dUS10gTW92ZSBJbWFnZURpZmYgdG8gdGhlIFRvb2xzIGRpcmVjdG9yeSByb290CmRpZmYg
LS1naXQgU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nIFNvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpp
bmRleCAzMjZiNTQyLi43ZmM5ZWEzIDEwMDY0NAotLS0gU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9n
CisrKyBTb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKQEAgLTEsMyArMSwxOCBAQAorMjAxMi0xMi0z
MSAgS29uZGFwYWxseSBLYWx5YW4gIDxrYWx5YW4ua29uZGFwYWxseUBpbnRlbC5jb20+CisKKyAg
ICAgICAgW0VGTF1bV2ViR0xdIEFkZCBjb21waWxlIHRpbWUgc3VwcG9ydCBmb3IgR0xFUzIuCisg
ICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xMDU4MTYKKwor
ICAgICAgICBSZXZpZXdlZCBieSBLZW5uZXRoIFJvaGRlIENocmlzdGlhbnNlbi4KKworICAgICAg
ICBUaGlzIHBhdGNoIGFkZHMgYnVpbGQgc3VwcG9ydCBmb3IgR0xFUzIuCisgICAgICAgIEdMRVMy
IHN1cHBvcnQgY2FuIGJlIGVuYWJsZWQgZHVyaW5nIGNvbXBpbGUgdGltZSBieSBwYXNzaW5nIC1E
RU5BQkxFX0dMRVMyPU9OIGFzCisgICAgICAgIGNtYWtlIGNvbmZpZyBwYXJhbWV0ZXIuIEdMRVMy
IG9wdGlvbnMgaXMgbm90IGVuYWJsZWQgYnkgZGVmYXVsdC4gVGhpcyBwYXRjaCBkb2Vzbid0Cisg
ICAgICAgIGFkZHJlc3MgYWxsIHRoZSBidWlsZCBpc3N1ZXMgcmVsYXRlZCB0byBHTEVTMiBidXQg
b25seSBhZGRzIHRoZSBuZWVkZWQgc3VwcG9ydCBpbgorICAgICAgICBQbGF0Zm9ybUVmbC5jbWFr
ZS4KKworICAgICAgICAqIFBsYXRmb3JtRWZsLmNtYWtlOgorCiAyMDEyLTEyLTMxICBBbmR5IENo
ZW4gIDxhbmRjaGVuQHJpbS5jb20+CiAKICAgICAgICAgW0JsYWNrQmVycnldIFRoZSBIVE1MNSB2
aWRlbyBmdWxsc2NyZWVuIHRpbWUgaW5kaWNhdG9yIG9uIHRoZSByaWdodCBjdXRzIGNsaXBwZWQg
d2hlbiB0aGUgdmlkZW8gaXMgbG9uZ2VyIHRoYW4gMSBob3VyCmRpZmYgLS1naXQgU291cmNlL1dl
YkNvcmUvUGxhdGZvcm1FZmwuY21ha2UgU291cmNlL1dlYkNvcmUvUGxhdGZvcm1FZmwuY21ha2UK
aW5kZXggNzEyZGIwYS4uZTg2OTcwNiAxMDA2NDQKLS0tIFNvdXJjZS9XZWJDb3JlL1BsYXRmb3Jt
RWZsLmNtYWtlCisrKyBTb3VyY2UvV2ViQ29yZS9QbGF0Zm9ybUVmbC5jbWFrZQpAQCAtMjc0LDE1
ICsyNzQsMTIgQEAgaWYgKFdURl9VU0VfM0RfR1JBUEhJQ1MpCiAgICAgZW5kaWYgKCkKIAogICAg
IGxpc3QoQVBQRU5EIFdlYkNvcmVfU09VUkNFUwotICAgICAgICBwbGF0Zm9ybS9ncmFwaGljcy9P
cGVuR0xTaGltcy5jcHAKICAgICAgICAgcGxhdGZvcm0vZ3JhcGhpY3MvY2Fpcm8vRHJhd2luZ0J1
ZmZlckNhaXJvLmNwcAogICAgICAgICBwbGF0Zm9ybS9ncmFwaGljcy9lZmwvR3JhcGhpY3NDb250
ZXh0M0RFZmwuY3BwCiAgICAgICAgIHBsYXRmb3JtL2dyYXBoaWNzL2VmbC9HcmFwaGljc0NvbnRl
eHQzRFByaXZhdGUuY3BwCi0gICAgICAgIHBsYXRmb3JtL2dyYXBoaWNzL29wZW5nbC9FeHRlbnNp
b25zM0RPcGVuR0wuY3BwCiAgICAgICAgIHBsYXRmb3JtL2dyYXBoaWNzL29wZW5nbC9FeHRlbnNp
b25zM0RPcGVuR0xDb21tb24uY3BwCiAgICAgICAgIHBsYXRmb3JtL2dyYXBoaWNzL29wZW5nbC9H
TFBsYXRmb3JtQ29udGV4dC5jcHAKICAgICAgICAgcGxhdGZvcm0vZ3JhcGhpY3Mvb3BlbmdsL0dM
UGxhdGZvcm1TdXJmYWNlLmNwcAotICAgICAgICBwbGF0Zm9ybS9ncmFwaGljcy9vcGVuZ2wvR3Jh
cGhpY3NDb250ZXh0M0RPcGVuR0wuY3BwCiAgICAgICAgIHBsYXRmb3JtL2dyYXBoaWNzL29wZW5n
bC9HcmFwaGljc0NvbnRleHQzRE9wZW5HTENvbW1vbi5jcHAKICAgICAgICAgcGxhdGZvcm0vZ3Jh
cGhpY3Mvc3VyZmFjZXMvR3JhcGhpY3NTdXJmYWNlLmNwcAogICAgICAgICBwbGF0Zm9ybS9ncmFw
aGljcy9zdXJmYWNlcy9nbHgvR3JhcGhpY3NTdXJmYWNlR0xYLmNwcApAQCAtMzA2LDYgKzMwMywx
OSBAQCBpZiAoV1RGX1VTRV8zRF9HUkFQSElDUykKICAgICAgICAgKQogICAgIGVuZGlmICgpCiAK
KyAgICBpZiAoV1RGX1VTRV9PUEVOR0xfRVNfMikKKyAgICAgICAgbGlzdChBUFBFTkQgV2ViQ29y
ZV9TT1VSQ0VTCisgICAgICAgICAgICBwbGF0Zm9ybS9ncmFwaGljcy9vcGVuZ2wvRXh0ZW5zaW9u
czNET3BlbkdMRVMuY3BwCisgICAgICAgICAgICBwbGF0Zm9ybS9ncmFwaGljcy9vcGVuZ2wvR3Jh
cGhpY3NDb250ZXh0M0RPcGVuR0xFUy5jcHAKKyAgICAgICAgKQorICAgIGVsc2UgKCkKKyAgICAg
ICAgbGlzdChBUFBFTkQgV2ViQ29yZV9TT1VSQ0VTCisgICAgICAgICAgICBwbGF0Zm9ybS9ncmFw
aGljcy9vcGVuZ2wvRXh0ZW5zaW9uczNET3BlbkdMLmNwcAorICAgICAgICAgICAgcGxhdGZvcm0v
Z3JhcGhpY3Mvb3BlbmdsL0dyYXBoaWNzQ29udGV4dDNET3BlbkdMLmNwcAorICAgICAgICAgICAg
cGxhdGZvcm0vZ3JhcGhpY3MvT3BlbkdMU2hpbXMuY3BwCisgICAgICAgICkKKyAgICBlbmRpZiAo
KQorCiAgICAgbGlzdChBUFBFTkQgV2ViQ29yZV9MSUJSQVJJRVMKICAgICAgICAgJHtYMTFfWDEx
X0xJQn0KICAgICAgICAgJHtYMTFfWGNvbXBvc2l0ZV9MSUJ9CmRpZmYgLS1naXQgU291cmNlL2Nt
YWtlL09wdGlvbnNFZmwuY21ha2UgU291cmNlL2NtYWtlL09wdGlvbnNFZmwuY21ha2UKaW5kZXgg
NmFhMDdlMC4uNDk0NTE4NiAxMDA2NDQKLS0tIFNvdXJjZS9jbWFrZS9PcHRpb25zRWZsLmNtYWtl
CisrKyBTb3VyY2UvY21ha2UvT3B0aW9uc0VmbC5jbWFrZQpAQCAtMTg3LDYgKzE4NywxNiBAQCBp
ZiAoRU5BQkxFX1dFQkdMIE9SIFdURl9VU0VfVElMRURfQkFDS0lOR19TVE9SRSkKICAgICBpZiAo
RUdMX0ZPVU5EKQogICAgICAgICBzZXQoV1RGX1VTRV9FR0wgMSkKICAgICAgICAgYWRkX2RlZmlu
aXRpb25zKC1EV1RGX1VTRV9FR0w9MSkKKyAgICAgICAgb3B0aW9uKEVOQUJMRV9HTEVTMiBPTikK
KworICAgICAgICBpZiAoRU5BQkxFX0dMRVMyKQorICAgICAgICAgICAgZmluZF9wYWNrYWdlKEdM
RVMgUkVRVUlSRUQpCisgICAgICAgIGVuZGlmICgpCisKKyAgICAgICAgaWYgKE9QRU5HTEVTMl9G
T1VORCkKKyAgICAgICAgICAgIHNldChXVEZfVVNFX09QRU5HTF9FU18yIDEpCisgICAgICAgICAg
ICBhZGRfZGVmaW5pdGlvbnMoLURXVEZfVVNFX09QRU5HTF9FU18yPTEpCisgICAgICAgIGVuZGlm
ICgpCiAgICAgIGVsc2VpZiAoT1BFTkdMWF9GT1VORCkKICAgICAgICAgIHNldChXVEZfVVNFX0dM
WCAxKQogICAgICAgICAgYWRkX2RlZmluaXRpb25zKC1EV1RGX1VTRV9HTFg9MSkK
</data>

          </attachment>
      

    </bug>

</bugzilla>