105677 2012-12-22 04:46:25 -0800 [EFL [WebGL] GLES2 detection is broken. 2012-12-24 02:04:54 -0800 1 1 1 Unclassified WebKit WebKit EFL 528+ (Nightly build) PC Linux RESOLVED FIXED P2 Normal --- 105659 1 kalyan.kondapally kalyan.kondapally gyuyoung.kim kenneth laszlo.gombos lucas.de.marchi rakuco webkit.review.bot oldest_to_newest 796666 0 kalyan.kondapally 2012-12-22 04:46:25 -0800 We use the logic in FindGLES.cmake to detect GLES2 support during compile time. OPENGLES2_FOUND is never set, even though OPENGLES2_INCLUDE_DIR and OPENGLES2_LIBRARY contain right information. The name passed to find_package_handle_standard_args seems to be the issue here. GLES2 should be changed OPENGLES2. Will update a patch with the correction. 796669 1 180603 kalyan.kondapally 2012-12-22 05:36:48 -0800 Created attachment 180603 patch 796923 2 180603 kenneth 2012-12-24 01:57:25 -0800 Comment on attachment 180603 patch Looks ok to me, but I have to trust you on this one 796924 3 180603 webkit.review.bot 2012-12-24 02:04:49 -0800 Comment on attachment 180603 patch Clearing flags on attachment: 180603 Committed r138437: <http://trac.webkit.org/changeset/138437> 796925 4 webkit.review.bot 2012-12-24 02:04:54 -0800 All reviewed patches have been landed. Closing bug. 180603 2012-12-22 05:36:48 -0800 2012-12-24 02:04:49 -0800 patch gles2fix.patch text/plain 1445 kalyan.kondapally ZGlmZiAtLWdpdCBDaGFuZ2VMb2cgQ2hhbmdlTG9nCmluZGV4IGRmOWVjMTQuLjNhZjAzYWMgMTAw NjQ0Ci0tLSBDaGFuZ2VMb2cKKysrIENoYW5nZUxvZwpAQCAtMSwzICsxLDE3IEBACisyMDEyLTEy LTIyICBLb25kYXBhbGx5IEthbHlhbiAgPGthbHlhbi5rb25kYXBhbGx5QGludGVsLmNvbT4KKwor ICAgICAgICBbRUZMIFtXZWJHTF0gR0xFUzIgZGV0ZWN0aW9uIGlzIGJyb2tlbi4KKyAgICAgICAg aHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTEwNTY3NworCisgICAgICAg IFdlIHVzZSB0aGUgbG9naWMgaW4gRmluZEdMRVMuY21ha2UgdG8gZGV0ZWN0IEdMRVMyIHN1cHBv cnQgZHVyaW5nIGNvbXBpbGUgdGltZS4KKyAgICAgICAgT1BFTkdMRVMyX0ZPVU5EIGlzIG5ldmVy IHNldCwgZXZlbiB0aG91Z2ggT1BFTkdMRVMyX0lOQ0xVREVfRElSIGFuZCBPUEVOR0xFUzJfTElC UkFSWQorICAgICAgICBjb250YWluIHJpZ2h0IGluZm9ybWF0aW9uLiBUaGUgbmFtZSBwYXNzZWQg dG8gZmluZF9wYWNrYWdlX2hhbmRsZV9zdGFuZGFyZF9hcmdzIHNlZW1zIHRvIGJlIHRoZSBpc3N1 ZSBoZXJlLgorICAgICAgICBUaGlzIHBhdGNoIGNoYW5nZXMgdGhlIG5hbWUgcGFzc2VkIHRvIGZp bmRfcGFja2FnZV9oYW5kbGVfc3RhbmRhcmRfYXJncyB0byBPUEVOR0xFUzIuCisKKyAgICAgICAg UmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgKiBTb3VyY2UvY21ha2UvRmlu ZEdMRVMuY21ha2U6CisKIDIwMTItMTItMjEgIEVsbGlvdHQgU3ByZWhuICA8ZXNwcmVobkBjaHJv bWl1bS5vcmc+CiAKICAgICAgICAgUmVwbGFjZSBkb2N1bWVudEZyYWdtZW50SXNTaGFkb3dSb290 IHdpdGggaXNUcmVlU2NvcGUKZGlmZiAtLWdpdCBTb3VyY2UvY21ha2UvRmluZEdMRVMuY21ha2Ug U291cmNlL2NtYWtlL0ZpbmRHTEVTLmNtYWtlCmluZGV4IDFhOWQ2MDIuLjFmOGRhZWIgMTAwNjQ0 Ci0tLSBTb3VyY2UvY21ha2UvRmluZEdMRVMuY21ha2UKKysrIFNvdXJjZS9jbWFrZS9GaW5kR0xF Uy5jbWFrZQpAQCAtMzMsNiArMzMsNiBAQCBmaW5kX3BhdGgoT1BFTkdMRVMyX0lOQ0xVREVfRElS IE5BTUVTIEdMRVMyL2dsMi5oKQogZmluZF9saWJyYXJ5KE9QRU5HTEVTMl9MSUJSQVJZIE5BTUVT IEdMRVN2MikKIAogaW5jbHVkZShGaW5kUGFja2FnZUhhbmRsZVN0YW5kYXJkQXJncykKLUZJTkRf UEFDS0FHRV9IQU5ETEVfU1RBTkRBUkRfQVJHUyhHTEVTdjIgREVGQVVMVF9NU0cgT1BFTkdMRVMy X0lOQ0xVREVfRElSIE9QRU5HTEVTMl9MSUJSQVJZKQorRklORF9QQUNLQUdFX0hBTkRMRV9TVEFO REFSRF9BUkdTKE9QRU5HTEVTMiBERUZBVUxUX01TRyBPUEVOR0xFUzJfSU5DTFVERV9ESVIgT1BF TkdMRVMyX0xJQlJBUlkpCiAKIG1hcmtfYXNfYWR2YW5jZWQoT1BFTkdMRVMyX0lOQ0xVREVfRElS IE9QRU5HTEVTMl9MSUJSQVJZKQo=