105436 2012-12-19 07:56:58 -0800 [GTK][AC] setOpacity doesn't work for GraphicsLayerClutter 2013-01-21 12:24:19 -0800 1 1 1 Unclassified WebKit WebKitGTK 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 105699 0 kevin.cs.oh webkit-unassigned gustavo joone mrobinson webkit.review.bot oldest_to_newest 794674 0 kevin.cs.oh 2012-12-19 07:56:58 -0800 All panels in http://www.webkit.org/blog-files/3d-transforms/poster-circle.html should be transparent, but they aren't. 794685 1 180170 kevin.cs.oh 2012-12-19 08:18:55 -0800 Created attachment 180170 Patch 797058 2 180170 joone 2012-12-24 15:27:19 -0800 Comment on attachment 180170 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=180170&action=review > Source/WebCore/platform/graphics/clutter/GraphicsLayerActor.cpp:597 > +void graphicsLayerActorSetOpacity(GraphicsLayerActor* layer, float value) I don't think we need to add this method. > Source/WebCore/platform/graphics/clutter/GraphicsLayerClutter.cpp:280 > + graphicsLayerActorSetOpacity(primaryLayer(), m_opacity); How about calling clutter_actor_set_opacity directly? 797352 3 180758 kevin.cs.oh 2012-12-26 11:04:31 -0800 Created attachment 180758 Patch 797353 4 180170 kevin.cs.oh 2012-12-26 11:07:40 -0800 Comment on attachment 180170 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=180170&action=review Thanks for the comment! >> Source/WebCore/platform/graphics/clutter/GraphicsLayerActor.cpp:597 >> +void graphicsLayerActorSetOpacity(GraphicsLayerActor* layer, float value) > > I don't think we need to add this method. Done. I moved this part of the function into GraphicsLayerClutter::updateOpacityOnLayer. >> Source/WebCore/platform/graphics/clutter/GraphicsLayerClutter.cpp:280 >> + graphicsLayerActorSetOpacity(primaryLayer(), m_opacity); > > How about calling clutter_actor_set_opacity directly? Done. 812254 5 180758 gustavo 2013-01-21 10:33:03 -0800 Comment on attachment 180758 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=180758&action=review > Source/WebCore/ChangeLog:9 > + Added GraphicsLayerClutter::setOpacity & other stuff. Most codes to set opacity > + to GraphicsLayerClutter are taken from mac port. '& other stuff' doesn't add anything, maybe say 'and wire it to the layer sync mechanism.'? Also I'd say "Based on Mac's GraphicsLayer implementation" instead of the other sentence. 812292 6 183810 kevin.cs.oh 2013-01-21 11:39:02 -0800 Created attachment 183810 Patch 812331 7 183810 webkit.review.bot 2013-01-21 12:24:15 -0800 Comment on attachment 183810 Patch Clearing flags on attachment: 183810 Committed r140350: <http://trac.webkit.org/changeset/140350> 812332 8 webkit.review.bot 2013-01-21 12:24:19 -0800 All reviewed patches have been landed. Closing bug. 180170 2012-12-19 08:18:55 -0800 2012-12-26 11:07:40 -0800 Patch bug-105436-20121220011611.patch text/plain 5586 kevin.cs.oh U3VidmVyc2lvbiBSZXZpc2lvbjogMTM4MTQ0CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggNjI1MmIyYTVlYjExMzkx ZTc3ZDIyN2ZkMjQyNmY4MjNiOGNkOTYxYy4uMTg2ODEzZWQ4YmU1MzFkYTE1MTZmYjMxMDY5ZTRj ODc3NTQyOTg1ZiAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDI1IEBACisyMDEyLTEyLTE5ICBDaGFu Z1Nlb2sgT2ggIDxzaGl2YW1pZG93QGdtYWlsLmNvbT4KKworICAgICAgICBbR1RLXVtBQ10gc2V0 T3BhY2l0eSBkb2Vzbid0IHdvcmsgZm9yIEdyYXBoaWNzTGF5ZXJDbHV0dGVyCisgICAgICAgIGh0 dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xMDU0MzYKKworICAgICAgICBS ZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBBZGRlZCBHcmFwaGljc0xheWVy Q2x1dHRlcjo6c2V0T3BhY2l0eSAmIG90aGVyIHN0dWZmLiBNb3N0IGNvZGVzIHRvIHNldCBvcGFj aXR5CisgICAgICAgIHRvIEdyYXBoaWNzTGF5ZXJDbHV0dGVyIGFyZSB0YWtlbiBmcm9tIG1hYyBw b3J0LgorCisgICAgICAgIE5vIG5ldyB0ZXN0cyBzaW5jZSB0aGlzIHBhdGNoIGNhbiBiZSBjb3Zl cmVkIGJ5IGFscmVhZHkgZXhpc3RpbmcgZ3RrIGFjIHRlc3RzLgorCisgICAgICAgICogcGxhdGZv cm0vZ3JhcGhpY3MvY2x1dHRlci9HcmFwaGljc0xheWVyQWN0b3IuY3BwOgorICAgICAgICAoZ3Jh cGhpY3NMYXllckFjdG9yU2V0T3BhY2l0eSk6CisgICAgICAgICogcGxhdGZvcm0vZ3JhcGhpY3Mv Y2x1dHRlci9HcmFwaGljc0xheWVyQWN0b3IuaDoKKyAgICAgICAgKiBwbGF0Zm9ybS9ncmFwaGlj cy9jbHV0dGVyL0dyYXBoaWNzTGF5ZXJDbHV0dGVyLmNwcDoKKyAgICAgICAgKFdlYkNvcmU6Okdy YXBoaWNzTGF5ZXJDbHV0dGVyOjpzZXRPcGFjaXR5KToKKyAgICAgICAgKFdlYkNvcmUpOgorICAg ICAgICAoV2ViQ29yZTo6R3JhcGhpY3NMYXllckNsdXR0ZXI6OnVwZGF0ZU9wYWNpdHlPbkxheWVy KToKKyAgICAgICAgKFdlYkNvcmU6OkdyYXBoaWNzTGF5ZXJDbHV0dGVyOjpjb21taXRMYXllckNo YW5nZXNCZWZvcmVTdWJsYXllcnMpOgorICAgICAgICAqIHBsYXRmb3JtL2dyYXBoaWNzL2NsdXR0 ZXIvR3JhcGhpY3NMYXllckNsdXR0ZXIuaDoKKwogMjAxMi0xMi0xOSAgQWxleGFuZGVyIFBhdmxv diAgPGFwYXZsb3ZAY2hyb21pdW0ub3JnPgogCiAgICAgICAgIFdlYiBJbnNwZWN0b3I6IFtSRUdS RVNTSU9OXSBUaGUgbGFzdCByZW1lbWJlcmVkIHRhYiBpcyBub3QgcmVzdG9yZWQgd2hlbiB0aGUg U2V0dGluZ3MgZGlhbG9nIGlzIG9wZW5lZApkaWZmIC0tZ2l0IGEvU291cmNlL1dlYkNvcmUvcGxh dGZvcm0vZ3JhcGhpY3MvY2x1dHRlci9HcmFwaGljc0xheWVyQWN0b3IuY3BwIGIvU291cmNlL1dl YkNvcmUvcGxhdGZvcm0vZ3JhcGhpY3MvY2x1dHRlci9HcmFwaGljc0xheWVyQWN0b3IuY3BwCmlu ZGV4IDg5YTcxZDdjZDY0MGQ4ZjlmODlhN2FlYmE0YmZhNWQ4NTJhZDM5NzUuLjAzNzJkZThjZDMz NWJjOGIxZDgwNmE1ZjFhMzlkMDg2ODRiYTUxY2UgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJDb3Jl L3BsYXRmb3JtL2dyYXBoaWNzL2NsdXR0ZXIvR3JhcGhpY3NMYXllckFjdG9yLmNwcAorKysgYi9T b3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9ncmFwaGljcy9jbHV0dGVyL0dyYXBoaWNzTGF5ZXJBY3Rv ci5jcHAKQEAgLTU5NCw0ICs1OTQsOSBAQCBnYm9vbGVhbiBncmFwaGljc0xheWVyQWN0b3JHZXRE cmF3c0NvbnRlbnQoR3JhcGhpY3NMYXllckFjdG9yKiBsYXllcikKICAgICByZXR1cm4gbGF5ZXIt PnByaXYtPmRyYXdzQ29udGVudDsKIH0KIAordm9pZCBncmFwaGljc0xheWVyQWN0b3JTZXRPcGFj aXR5KEdyYXBoaWNzTGF5ZXJBY3RvciogbGF5ZXIsIGZsb2F0IHZhbHVlKQoreworICAgIGNsdXR0 ZXJfYWN0b3Jfc2V0X29wYWNpdHkoQ0xVVFRFUl9BQ1RPUihsYXllciksIHN0YXRpY19jYXN0PGd1 aW50OD4ocm91bmRmKHZhbHVlICogMjU1KSkpOworfQorCiAjZW5kaWYgLy8gVVNFKEFDQ0VMRVJB VEVEX0NPTVBPU0lUSU5HKQpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vZ3Jh cGhpY3MvY2x1dHRlci9HcmFwaGljc0xheWVyQWN0b3IuaCBiL1NvdXJjZS9XZWJDb3JlL3BsYXRm b3JtL2dyYXBoaWNzL2NsdXR0ZXIvR3JhcGhpY3NMYXllckFjdG9yLmgKaW5kZXggZDk2NWRhZmIw MzY0ZDAwNDdjMzA5NDhjZjk1OGUzNDZjYjY3YjhjYS4uNzA1MWM2MTdmZGVmNTYzMDZmZmU0Yzlj OTVlNTY5NWU2ODc4NTk1ZCAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vZ3Jh cGhpY3MvY2x1dHRlci9HcmFwaGljc0xheWVyQWN0b3IuaAorKysgYi9Tb3VyY2UvV2ViQ29yZS9w bGF0Zm9ybS9ncmFwaGljcy9jbHV0dGVyL0dyYXBoaWNzTGF5ZXJBY3Rvci5oCkBAIC05NSw2ICs5 NSw3IEBAIHZvaWQgZ3JhcGhpY3NMYXllckFjdG9yU2V0TGF5ZXJUeXBlKEdyYXBoaWNzTGF5ZXJB Y3RvciosIFdlYkNvcmU6OkdyYXBoaWNzTGF5ZXJDCiB2b2lkIGdyYXBoaWNzTGF5ZXJBY3RvclNl dFN1YmxheWVycyhHcmFwaGljc0xheWVyQWN0b3IqLCBXZWJDb3JlOjpHcmFwaGljc0xheWVyQWN0 b3JMaXN0Jik7CiBnYm9vbGVhbiBncmFwaGljc0xheWVyQWN0b3JHZXREcmF3c0NvbnRlbnQoR3Jh cGhpY3NMYXllckFjdG9yKik7CiB2b2lkIGdyYXBoaWNzTGF5ZXJBY3RvclNldERyYXdzQ29udGVu dChHcmFwaGljc0xheWVyQWN0b3IqLCBnYm9vbGVhbiBkcmF3c0NvbnRlbnQpOwordm9pZCBncmFw aGljc0xheWVyQWN0b3JTZXRPcGFjaXR5KEdyYXBoaWNzTGF5ZXJBY3RvciosIGZsb2F0IHZhbHVl KTsKIAogR19FTkRfREVDTFMKIApkaWZmIC0tZ2l0IGEvU291cmNlL1dlYkNvcmUvcGxhdGZvcm0v Z3JhcGhpY3MvY2x1dHRlci9HcmFwaGljc0xheWVyQ2x1dHRlci5jcHAgYi9Tb3VyY2UvV2ViQ29y ZS9wbGF0Zm9ybS9ncmFwaGljcy9jbHV0dGVyL0dyYXBoaWNzTGF5ZXJDbHV0dGVyLmNwcAppbmRl eCAxOTM5YTBhYWY4NDU3YzYyOTgwODE1YTU4ZTc0YTYyMWIwNzkxYzVjLi43ZjU4NWViN2IzZGEx YTI5YjY0NzM1YTlmNDUzNWUwYmJhZTc3ZjZmIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9w bGF0Zm9ybS9ncmFwaGljcy9jbHV0dGVyL0dyYXBoaWNzTGF5ZXJDbHV0dGVyLmNwcAorKysgYi9T b3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9ncmFwaGljcy9jbHV0dGVyL0dyYXBoaWNzTGF5ZXJDbHV0 dGVyLmNwcApAQCAtMTUyLDYgKzE1MiwxNiBAQCB2b2lkIEdyYXBoaWNzTGF5ZXJDbHV0dGVyOjpz ZXRBbmNob3JQb2ludChjb25zdCBGbG9hdFBvaW50M0QmIHBvaW50KQogICAgIG5vdGVMYXllclBy b3BlcnR5Q2hhbmdlZChHZW9tZXRyeUNoYW5nZWQpOwogfQogCit2b2lkIEdyYXBoaWNzTGF5ZXJD bHV0dGVyOjpzZXRPcGFjaXR5KGZsb2F0IG9wYWNpdHkpCit7CisgICAgZmxvYXQgY2xhbXBlZE9w YWNpdHkgPSBzdGQ6Om1heCgwLjBmLCBzdGQ6Om1pbihvcGFjaXR5LCAxLjBmKSk7CisgICAgaWYg KGNsYW1wZWRPcGFjaXR5ID09IG1fb3BhY2l0eSkKKyAgICAgICAgcmV0dXJuOworCisgICAgR3Jh cGhpY3NMYXllcjo6c2V0T3BhY2l0eShjbGFtcGVkT3BhY2l0eSk7CisgICAgbm90ZUxheWVyUHJv cGVydHlDaGFuZ2VkKE9wYWNpdHlDaGFuZ2VkKTsKK30KKwogdm9pZCBHcmFwaGljc0xheWVyQ2x1 dHRlcjo6c2V0UG9zaXRpb24oY29uc3QgRmxvYXRQb2ludCYgcG9pbnQpCiB7CiAgICAgaWYgKHBv aW50ID09IG1fcG9zaXRpb24pCkBAIC0yNjUsNiArMjc1LDExIEBAIHZvaWQgR3JhcGhpY3NMYXll ckNsdXR0ZXI6OnJlcGFpbnRMYXllckRpcnR5UmVjdHMoKQogICAgIG1fZGlydHlSZWN0cy5jbGVh cigpOwogfQogCit2b2lkIEdyYXBoaWNzTGF5ZXJDbHV0dGVyOjp1cGRhdGVPcGFjaXR5T25MYXll cigpCit7CisgICAgZ3JhcGhpY3NMYXllckFjdG9yU2V0T3BhY2l0eShwcmltYXJ5TGF5ZXIoKSwg bV9vcGFjaXR5KTsKK30KKwogRmxvYXRQb2ludCBHcmFwaGljc0xheWVyQ2x1dHRlcjo6Y29tcHV0 ZVBvc2l0aW9uUmVsYXRpdmVUb0Jhc2UoZmxvYXQmIHBhZ2VTY2FsZSkgY29uc3QKIHsKICAgICBw YWdlU2NhbGUgPSAxOwpAQCAtMzY4LDYgKzM4Myw5IEBAIHZvaWQgR3JhcGhpY3NMYXllckNsdXR0 ZXI6OmNvbW1pdExheWVyQ2hhbmdlc0JlZm9yZVN1YmxheWVycyhmbG9hdCBwYWdlU2NhbGVGYWN0 CiAKICAgICBpZiAobV91bmNvbW1pdHRlZENoYW5nZXMgJiBEaXJ0eVJlY3RzQ2hhbmdlZCkKICAg ICAgICAgcmVwYWludExheWVyRGlydHlSZWN0cygpOworCisgICAgaWYgKG1fdW5jb21taXR0ZWRD aGFuZ2VzICYgT3BhY2l0eUNoYW5nZWQpCisgICAgICAgIHVwZGF0ZU9wYWNpdHlPbkxheWVyKCk7 CiB9CiAKIHZvaWQgR3JhcGhpY3NMYXllckNsdXR0ZXI6OnVwZGF0ZUdlb21ldHJ5KGZsb2F0IHBh Z2VTY2FsZUZhY3RvciwgY29uc3QgRmxvYXRQb2ludCYgcG9zaXRpb25SZWxhdGl2ZVRvQmFzZSkK ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL2dyYXBoaWNzL2NsdXR0ZXIvR3Jh cGhpY3NMYXllckNsdXR0ZXIuaCBiL1NvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL2dyYXBoaWNzL2Ns dXR0ZXIvR3JhcGhpY3NMYXllckNsdXR0ZXIuaAppbmRleCBkZjYwODY4NzVmNWQzN2IzNzg4MWJm ZjQyMTQxMzBjYjQwMjA3NjI0Li5mMjM1NTdlZDJiOTc5MGIxMWRmYzI0YzgwYTQzNzFmYmM2YjIz YWRmIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9ncmFwaGljcy9jbHV0dGVy L0dyYXBoaWNzTGF5ZXJDbHV0dGVyLmgKKysrIGIvU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vZ3Jh cGhpY3MvY2x1dHRlci9HcmFwaGljc0xheWVyQ2x1dHRlci5oCkBAIC02OSw2ICs2OSw3IEBAIHB1 YmxpYzoKIAogICAgIHZpcnR1YWwgdm9pZCBzZXREcmF3c0NvbnRlbnQoYm9vbCk7CiAgICAgdmly dHVhbCB2b2lkIHNldEFuY2hvclBvaW50KGNvbnN0IEZsb2F0UG9pbnQzRCYpOworICAgIHZpcnR1 YWwgdm9pZCBzZXRPcGFjaXR5KGZsb2F0KTsKICAgICB2aXJ0dWFsIHZvaWQgc2V0UG9zaXRpb24o Y29uc3QgRmxvYXRQb2ludCYpOwogICAgIHZpcnR1YWwgdm9pZCBzZXRTaXplKGNvbnN0IEZsb2F0 U2l6ZSYpOwogCkBAIC04Nyw2ICs4OCw4IEBAIHByaXZhdGU6CiAgICAgdm9pZCBjb21taXRMYXll ckNoYW5nZXNCZWZvcmVTdWJsYXllcnMoZmxvYXQgcGFnZVNjYWxlRmFjdG9yLCBjb25zdCBGbG9h dFBvaW50JiBwb3NpdGlvblJlbGF0aXZlVG9CYXNlKTsKICAgICB2b2lkIGNvbW1pdExheWVyQ2hh bmdlc0FmdGVyU3VibGF5ZXJzKCk7CiAKKyAgICB2b2lkIHVwZGF0ZU9wYWNpdHlPbkxheWVyKCk7 CisKICAgICB2aXJ0dWFsIHZvaWQgcGxhdGZvcm1DbHV0dGVyTGF5ZXJBbmltYXRpb25TdGFydGVk KGRvdWJsZSBiZWdpblRpbWUpOwogICAgIHZpcnR1YWwgdm9pZCBwbGF0Zm9ybUNsdXR0ZXJMYXll clBhaW50Q29udGVudHMoR3JhcGhpY3NDb250ZXh0JiwgY29uc3QgSW50UmVjdCYgY2xpcCk7CiAK 180758 2012-12-26 11:04:31 -0800 2013-01-21 12:20:59 -0800 Patch bug-105436-20121227040143.patch text/plain 3907 kevin.cs.oh U3VidmVyc2lvbiBSZXZpc2lvbjogMTM4NDc5CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggMDg2OGI4NDE0ZjZkNTBm ODZhMzQ5NjZmNDY4NmZmMzIwNWIzMDY1NS4uOTM1NmMyMTFiNzlkNWJmNzc5YmY3MDEwMTcwNjhk NzA3NWUxOGNkOSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDIyIEBACisyMDEyLTEyLTI2ICBDaGFu Z1Nlb2sgT2ggIDxzaGl2YW1pZG93QGdtYWlsLmNvbT4KKworICAgICAgICBbR1RLXVtBQ10gc2V0 T3BhY2l0eSBkb2Vzbid0IHdvcmsgZm9yIEdyYXBoaWNzTGF5ZXJDbHV0dGVyCisgICAgICAgIGh0 dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xMDU0MzYKKworICAgICAgICBS ZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBBZGRlZCBHcmFwaGljc0xheWVy Q2x1dHRlcjo6c2V0T3BhY2l0eSAmIG90aGVyIHN0dWZmLiBNb3N0IGNvZGVzIHRvIHNldCBvcGFj aXR5CisgICAgICAgIHRvIEdyYXBoaWNzTGF5ZXJDbHV0dGVyIGFyZSB0YWtlbiBmcm9tIG1hYyBw b3J0LgorCisgICAgICAgIE5vIG5ldyB0ZXN0cyBzaW5jZSB0aGlzIHBhdGNoIGNhbiBiZSBjb3Zl cmVkIGJ5IGFscmVhZHkgZXhpc3RpbmcgZ3RrIGFjIHRlc3RzLgorCisgICAgICAgICogcGxhdGZv cm0vZ3JhcGhpY3MvY2x1dHRlci9HcmFwaGljc0xheWVyQ2x1dHRlci5jcHA6CisgICAgICAgIChX ZWJDb3JlOjpHcmFwaGljc0xheWVyQ2x1dHRlcjo6c2V0T3BhY2l0eSk6CisgICAgICAgIChXZWJD b3JlKToKKyAgICAgICAgKFdlYkNvcmU6OkdyYXBoaWNzTGF5ZXJDbHV0dGVyOjp1cGRhdGVPcGFj aXR5T25MYXllcik6CisgICAgICAgIChXZWJDb3JlOjpHcmFwaGljc0xheWVyQ2x1dHRlcjo6Y29t bWl0TGF5ZXJDaGFuZ2VzQmVmb3JlU3VibGF5ZXJzKToKKyAgICAgICAgKiBwbGF0Zm9ybS9ncmFw aGljcy9jbHV0dGVyL0dyYXBoaWNzTGF5ZXJDbHV0dGVyLmg6CisKIDIwMTItMTItMjYgIFl1cnkg U2VtaWtoYXRza3kgIDx5dXJ5c0BjaHJvbWl1bS5vcmc+CiAKICAgICAgICAgV2ViIEluc3BlY3Rv cjogZXh0cmFjdCBKUyBoZWFwIHByb2ZpbGVyIHNwZWNpZmljcyBpbnRvIEpTSGVhcFNuYXBzaG90 LmpzCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9ncmFwaGljcy9jbHV0dGVy L0dyYXBoaWNzTGF5ZXJDbHV0dGVyLmNwcCBiL1NvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL2dyYXBo aWNzL2NsdXR0ZXIvR3JhcGhpY3NMYXllckNsdXR0ZXIuY3BwCmluZGV4IDE5MzlhMGFhZjg0NTdj NjI5ODA4MTVhNThlNzRhNjIxYjA3OTFjNWMuLjljN2FiNGZkZmVmZjA2Y2U0ZDIyYWJhN2QxMGVi OGZhNGVlMzkwYmQgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL2dyYXBoaWNz L2NsdXR0ZXIvR3JhcGhpY3NMYXllckNsdXR0ZXIuY3BwCisrKyBiL1NvdXJjZS9XZWJDb3JlL3Bs YXRmb3JtL2dyYXBoaWNzL2NsdXR0ZXIvR3JhcGhpY3NMYXllckNsdXR0ZXIuY3BwCkBAIC0xNTIs NiArMTUyLDE2IEBAIHZvaWQgR3JhcGhpY3NMYXllckNsdXR0ZXI6OnNldEFuY2hvclBvaW50KGNv bnN0IEZsb2F0UG9pbnQzRCYgcG9pbnQpCiAgICAgbm90ZUxheWVyUHJvcGVydHlDaGFuZ2VkKEdl b21ldHJ5Q2hhbmdlZCk7CiB9CiAKK3ZvaWQgR3JhcGhpY3NMYXllckNsdXR0ZXI6OnNldE9wYWNp dHkoZmxvYXQgb3BhY2l0eSkKK3sKKyAgICBmbG9hdCBjbGFtcGVkT3BhY2l0eSA9IHN0ZDo6bWF4 KDAuMGYsIHN0ZDo6bWluKG9wYWNpdHksIDEuMGYpKTsKKyAgICBpZiAoY2xhbXBlZE9wYWNpdHkg PT0gbV9vcGFjaXR5KQorICAgICAgICByZXR1cm47CisKKyAgICBHcmFwaGljc0xheWVyOjpzZXRP cGFjaXR5KGNsYW1wZWRPcGFjaXR5KTsKKyAgICBub3RlTGF5ZXJQcm9wZXJ0eUNoYW5nZWQoT3Bh Y2l0eUNoYW5nZWQpOworfQorCiB2b2lkIEdyYXBoaWNzTGF5ZXJDbHV0dGVyOjpzZXRQb3NpdGlv bihjb25zdCBGbG9hdFBvaW50JiBwb2ludCkKIHsKICAgICBpZiAocG9pbnQgPT0gbV9wb3NpdGlv bikKQEAgLTI2NSw2ICsyNzUsMTEgQEAgdm9pZCBHcmFwaGljc0xheWVyQ2x1dHRlcjo6cmVwYWlu dExheWVyRGlydHlSZWN0cygpCiAgICAgbV9kaXJ0eVJlY3RzLmNsZWFyKCk7CiB9CiAKK3ZvaWQg R3JhcGhpY3NMYXllckNsdXR0ZXI6OnVwZGF0ZU9wYWNpdHlPbkxheWVyKCkKK3sKKyAgICBjbHV0 dGVyX2FjdG9yX3NldF9vcGFjaXR5KENMVVRURVJfQUNUT1IocHJpbWFyeUxheWVyKCkpLCBzdGF0 aWNfY2FzdDxndWludDg+KHJvdW5kZihtX29wYWNpdHkgKiAyNTUpKSk7Cit9CisKIEZsb2F0UG9p bnQgR3JhcGhpY3NMYXllckNsdXR0ZXI6OmNvbXB1dGVQb3NpdGlvblJlbGF0aXZlVG9CYXNlKGZs b2F0JiBwYWdlU2NhbGUpIGNvbnN0CiB7CiAgICAgcGFnZVNjYWxlID0gMTsKQEAgLTM2OCw2ICsz ODMsOSBAQCB2b2lkIEdyYXBoaWNzTGF5ZXJDbHV0dGVyOjpjb21taXRMYXllckNoYW5nZXNCZWZv cmVTdWJsYXllcnMoZmxvYXQgcGFnZVNjYWxlRmFjdAogCiAgICAgaWYgKG1fdW5jb21taXR0ZWRD aGFuZ2VzICYgRGlydHlSZWN0c0NoYW5nZWQpCiAgICAgICAgIHJlcGFpbnRMYXllckRpcnR5UmVj dHMoKTsKKworICAgIGlmIChtX3VuY29tbWl0dGVkQ2hhbmdlcyAmIE9wYWNpdHlDaGFuZ2VkKQor ICAgICAgICB1cGRhdGVPcGFjaXR5T25MYXllcigpOwogfQogCiB2b2lkIEdyYXBoaWNzTGF5ZXJD bHV0dGVyOjp1cGRhdGVHZW9tZXRyeShmbG9hdCBwYWdlU2NhbGVGYWN0b3IsIGNvbnN0IEZsb2F0 UG9pbnQmIHBvc2l0aW9uUmVsYXRpdmVUb0Jhc2UpCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29y ZS9wbGF0Zm9ybS9ncmFwaGljcy9jbHV0dGVyL0dyYXBoaWNzTGF5ZXJDbHV0dGVyLmggYi9Tb3Vy Y2UvV2ViQ29yZS9wbGF0Zm9ybS9ncmFwaGljcy9jbHV0dGVyL0dyYXBoaWNzTGF5ZXJDbHV0dGVy LmgKaW5kZXggZGY2MDg2ODc1ZjVkMzdiMzc4ODFiZmY0MjE0MTMwY2I0MDIwNzYyNC4uZjIzNTU3 ZWQyYjk3OTBiMTFkZmMyNGM4MGE0MzcxZmJjNmIyM2FkZiAxMDA2NDQKLS0tIGEvU291cmNlL1dl YkNvcmUvcGxhdGZvcm0vZ3JhcGhpY3MvY2x1dHRlci9HcmFwaGljc0xheWVyQ2x1dHRlci5oCisr KyBiL1NvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL2dyYXBoaWNzL2NsdXR0ZXIvR3JhcGhpY3NMYXll ckNsdXR0ZXIuaApAQCAtNjksNiArNjksNyBAQCBwdWJsaWM6CiAKICAgICB2aXJ0dWFsIHZvaWQg c2V0RHJhd3NDb250ZW50KGJvb2wpOwogICAgIHZpcnR1YWwgdm9pZCBzZXRBbmNob3JQb2ludChj b25zdCBGbG9hdFBvaW50M0QmKTsKKyAgICB2aXJ0dWFsIHZvaWQgc2V0T3BhY2l0eShmbG9hdCk7 CiAgICAgdmlydHVhbCB2b2lkIHNldFBvc2l0aW9uKGNvbnN0IEZsb2F0UG9pbnQmKTsKICAgICB2 aXJ0dWFsIHZvaWQgc2V0U2l6ZShjb25zdCBGbG9hdFNpemUmKTsKIApAQCAtODcsNiArODgsOCBA QCBwcml2YXRlOgogICAgIHZvaWQgY29tbWl0TGF5ZXJDaGFuZ2VzQmVmb3JlU3VibGF5ZXJzKGZs b2F0IHBhZ2VTY2FsZUZhY3RvciwgY29uc3QgRmxvYXRQb2ludCYgcG9zaXRpb25SZWxhdGl2ZVRv QmFzZSk7CiAgICAgdm9pZCBjb21taXRMYXllckNoYW5nZXNBZnRlclN1YmxheWVycygpOwogCisg ICAgdm9pZCB1cGRhdGVPcGFjaXR5T25MYXllcigpOworCiAgICAgdmlydHVhbCB2b2lkIHBsYXRm b3JtQ2x1dHRlckxheWVyQW5pbWF0aW9uU3RhcnRlZChkb3VibGUgYmVnaW5UaW1lKTsKICAgICB2 aXJ0dWFsIHZvaWQgcGxhdGZvcm1DbHV0dGVyTGF5ZXJQYWludENvbnRlbnRzKEdyYXBoaWNzQ29u dGV4dCYsIGNvbnN0IEludFJlY3QmIGNsaXApOwogCg== 183810 2013-01-21 11:39:02 -0800 2013-01-21 12:24:15 -0800 Patch bug-105436-20130122043556.patch text/plain 3895 kevin.cs.oh U3VidmVyc2lvbiBSZXZpc2lvbjogMTQwMzQ3CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggNmEzZjBiYjI1ZDdmMzJk OTg0YmI1YTBhYTNiOTczNGFmNDA3NTNlMS4uMDk2OTk4YmMzZGVhZTZmZDhhODY1ZTViOGI0Yjdl Y2JjODI3NDgzNCAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSw1ICsxLDIzIEBACiAyMDEzLTAxLTIxICBDaGFu Z1Nlb2sgT2ggIDxzaGl2YW1pZG93QGdtYWlsLmNvbT4KIAorICAgICAgICBbR1RLXVtBQ10gc2V0 T3BhY2l0eSBkb2Vzbid0IHdvcmsgZm9yIEdyYXBoaWNzTGF5ZXJDbHV0dGVyCisgICAgICAgIGh0 dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xMDU0MzYKKworICAgICAgICBS ZXZpZXdlZCBieSBHdXN0YXZvIE5vcm9uaGEgU2lsdmEuCisKKyAgICAgICAgSW1wbGVtZW50IEdy YXBoaWNzTGF5ZXJDbHV0dGVyOjpzZXRPcGFjaXR5IGJhc2VkIG9uIE1hYydzIEdyYXBoaWNzTGF5 ZXIgaW1wbGVtZW50YXRpb24uCisKKyAgICAgICAgTm8gbmV3IHRlc3RzIHNpbmNlIHRoaXMgcGF0 Y2ggY2FuIGJlIGNvdmVyZWQgYnkgYWxyZWFkeSBleGlzdGluZyBndGsgYWMgdGVzdHMuCisKKyAg ICAgICAgKiBwbGF0Zm9ybS9ncmFwaGljcy9jbHV0dGVyL0dyYXBoaWNzTGF5ZXJDbHV0dGVyLmNw cDoKKyAgICAgICAgKFdlYkNvcmU6OkdyYXBoaWNzTGF5ZXJDbHV0dGVyOjpzZXRPcGFjaXR5KToK KyAgICAgICAgKFdlYkNvcmUpOgorICAgICAgICAoV2ViQ29yZTo6R3JhcGhpY3NMYXllckNsdXR0 ZXI6OnVwZGF0ZU9wYWNpdHlPbkxheWVyKToKKyAgICAgICAgKFdlYkNvcmU6OkdyYXBoaWNzTGF5 ZXJDbHV0dGVyOjpjb21taXRMYXllckNoYW5nZXNCZWZvcmVTdWJsYXllcnMpOgorICAgICAgICAq IHBsYXRmb3JtL2dyYXBoaWNzL2NsdXR0ZXIvR3JhcGhpY3NMYXllckNsdXR0ZXIuaDoKKworMjAx My0wMS0yMSAgQ2hhbmdTZW9rIE9oICA8c2hpdmFtaWRvd0BnbWFpbC5jb20+CisKICAgICAgICAg W1RleG1hcF1bR1RLXSBUaGUgcG9zdGVyLWNpcmNsZSBkb2Vzbid0IGFwcGVhci4KICAgICAgICAg aHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTEwNjY3MgogCmRpZmYgLS1n aXQgYS9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9ncmFwaGljcy9jbHV0dGVyL0dyYXBoaWNzTGF5 ZXJDbHV0dGVyLmNwcCBiL1NvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL2dyYXBoaWNzL2NsdXR0ZXIv R3JhcGhpY3NMYXllckNsdXR0ZXIuY3BwCmluZGV4IDE5MzlhMGFhZjg0NTdjNjI5ODA4MTVhNThl NzRhNjIxYjA3OTFjNWMuLjljN2FiNGZkZmVmZjA2Y2U0ZDIyYWJhN2QxMGViOGZhNGVlMzkwYmQg MTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL2dyYXBoaWNzL2NsdXR0ZXIvR3Jh cGhpY3NMYXllckNsdXR0ZXIuY3BwCisrKyBiL1NvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL2dyYXBo aWNzL2NsdXR0ZXIvR3JhcGhpY3NMYXllckNsdXR0ZXIuY3BwCkBAIC0xNTIsNiArMTUyLDE2IEBA IHZvaWQgR3JhcGhpY3NMYXllckNsdXR0ZXI6OnNldEFuY2hvclBvaW50KGNvbnN0IEZsb2F0UG9p bnQzRCYgcG9pbnQpCiAgICAgbm90ZUxheWVyUHJvcGVydHlDaGFuZ2VkKEdlb21ldHJ5Q2hhbmdl ZCk7CiB9CiAKK3ZvaWQgR3JhcGhpY3NMYXllckNsdXR0ZXI6OnNldE9wYWNpdHkoZmxvYXQgb3Bh Y2l0eSkKK3sKKyAgICBmbG9hdCBjbGFtcGVkT3BhY2l0eSA9IHN0ZDo6bWF4KDAuMGYsIHN0ZDo6 bWluKG9wYWNpdHksIDEuMGYpKTsKKyAgICBpZiAoY2xhbXBlZE9wYWNpdHkgPT0gbV9vcGFjaXR5 KQorICAgICAgICByZXR1cm47CisKKyAgICBHcmFwaGljc0xheWVyOjpzZXRPcGFjaXR5KGNsYW1w ZWRPcGFjaXR5KTsKKyAgICBub3RlTGF5ZXJQcm9wZXJ0eUNoYW5nZWQoT3BhY2l0eUNoYW5nZWQp OworfQorCiB2b2lkIEdyYXBoaWNzTGF5ZXJDbHV0dGVyOjpzZXRQb3NpdGlvbihjb25zdCBGbG9h dFBvaW50JiBwb2ludCkKIHsKICAgICBpZiAocG9pbnQgPT0gbV9wb3NpdGlvbikKQEAgLTI2NSw2 ICsyNzUsMTEgQEAgdm9pZCBHcmFwaGljc0xheWVyQ2x1dHRlcjo6cmVwYWludExheWVyRGlydHlS ZWN0cygpCiAgICAgbV9kaXJ0eVJlY3RzLmNsZWFyKCk7CiB9CiAKK3ZvaWQgR3JhcGhpY3NMYXll ckNsdXR0ZXI6OnVwZGF0ZU9wYWNpdHlPbkxheWVyKCkKK3sKKyAgICBjbHV0dGVyX2FjdG9yX3Nl dF9vcGFjaXR5KENMVVRURVJfQUNUT1IocHJpbWFyeUxheWVyKCkpLCBzdGF0aWNfY2FzdDxndWlu dDg+KHJvdW5kZihtX29wYWNpdHkgKiAyNTUpKSk7Cit9CisKIEZsb2F0UG9pbnQgR3JhcGhpY3NM YXllckNsdXR0ZXI6OmNvbXB1dGVQb3NpdGlvblJlbGF0aXZlVG9CYXNlKGZsb2F0JiBwYWdlU2Nh bGUpIGNvbnN0CiB7CiAgICAgcGFnZVNjYWxlID0gMTsKQEAgLTM2OCw2ICszODMsOSBAQCB2b2lk IEdyYXBoaWNzTGF5ZXJDbHV0dGVyOjpjb21taXRMYXllckNoYW5nZXNCZWZvcmVTdWJsYXllcnMo ZmxvYXQgcGFnZVNjYWxlRmFjdAogCiAgICAgaWYgKG1fdW5jb21taXR0ZWRDaGFuZ2VzICYgRGly dHlSZWN0c0NoYW5nZWQpCiAgICAgICAgIHJlcGFpbnRMYXllckRpcnR5UmVjdHMoKTsKKworICAg IGlmIChtX3VuY29tbWl0dGVkQ2hhbmdlcyAmIE9wYWNpdHlDaGFuZ2VkKQorICAgICAgICB1cGRh dGVPcGFjaXR5T25MYXllcigpOwogfQogCiB2b2lkIEdyYXBoaWNzTGF5ZXJDbHV0dGVyOjp1cGRh dGVHZW9tZXRyeShmbG9hdCBwYWdlU2NhbGVGYWN0b3IsIGNvbnN0IEZsb2F0UG9pbnQmIHBvc2l0 aW9uUmVsYXRpdmVUb0Jhc2UpCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9n cmFwaGljcy9jbHV0dGVyL0dyYXBoaWNzTGF5ZXJDbHV0dGVyLmggYi9Tb3VyY2UvV2ViQ29yZS9w bGF0Zm9ybS9ncmFwaGljcy9jbHV0dGVyL0dyYXBoaWNzTGF5ZXJDbHV0dGVyLmgKaW5kZXggZGY2 MDg2ODc1ZjVkMzdiMzc4ODFiZmY0MjE0MTMwY2I0MDIwNzYyNC4uZjIzNTU3ZWQyYjk3OTBiMTFk ZmMyNGM4MGE0MzcxZmJjNmIyM2FkZiAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvcGxhdGZv cm0vZ3JhcGhpY3MvY2x1dHRlci9HcmFwaGljc0xheWVyQ2x1dHRlci5oCisrKyBiL1NvdXJjZS9X ZWJDb3JlL3BsYXRmb3JtL2dyYXBoaWNzL2NsdXR0ZXIvR3JhcGhpY3NMYXllckNsdXR0ZXIuaApA QCAtNjksNiArNjksNyBAQCBwdWJsaWM6CiAKICAgICB2aXJ0dWFsIHZvaWQgc2V0RHJhd3NDb250 ZW50KGJvb2wpOwogICAgIHZpcnR1YWwgdm9pZCBzZXRBbmNob3JQb2ludChjb25zdCBGbG9hdFBv aW50M0QmKTsKKyAgICB2aXJ0dWFsIHZvaWQgc2V0T3BhY2l0eShmbG9hdCk7CiAgICAgdmlydHVh bCB2b2lkIHNldFBvc2l0aW9uKGNvbnN0IEZsb2F0UG9pbnQmKTsKICAgICB2aXJ0dWFsIHZvaWQg c2V0U2l6ZShjb25zdCBGbG9hdFNpemUmKTsKIApAQCAtODcsNiArODgsOCBAQCBwcml2YXRlOgog ICAgIHZvaWQgY29tbWl0TGF5ZXJDaGFuZ2VzQmVmb3JlU3VibGF5ZXJzKGZsb2F0IHBhZ2VTY2Fs ZUZhY3RvciwgY29uc3QgRmxvYXRQb2ludCYgcG9zaXRpb25SZWxhdGl2ZVRvQmFzZSk7CiAgICAg dm9pZCBjb21taXRMYXllckNoYW5nZXNBZnRlclN1YmxheWVycygpOwogCisgICAgdm9pZCB1cGRh dGVPcGFjaXR5T25MYXllcigpOworCiAgICAgdmlydHVhbCB2b2lkIHBsYXRmb3JtQ2x1dHRlckxh eWVyQW5pbWF0aW9uU3RhcnRlZChkb3VibGUgYmVnaW5UaW1lKTsKICAgICB2aXJ0dWFsIHZvaWQg cGxhdGZvcm1DbHV0dGVyTGF5ZXJQYWludENvbnRlbnRzKEdyYXBoaWNzQ29udGV4dCYsIGNvbnN0 IEludFJlY3QmIGNsaXApOwogCg==