105287 2012-12-18 07:08:36 -0800 [EFL] Allow the build system to detect EGL support 2012-12-18 10:01:37 -0800 1 1 1 Unclassified WebKit WebKit EFL 528+ (Nightly build) PC Linux RESOLVED FIXED P2 Normal --- 105286 1 kalyan.kondapally kalyan.kondapally gyuyoung.kim laszlo.gombos lucas.de.marchi rakuco tmpsantos webkit.review.bot oldest_to_newest 793605 0 kalyan.kondapally 2012-12-18 07:08:36 -0800 Currently, we don't have any way to determine if EGL is supported by the build. We probably would need something like FindEGL.cmake unless something is already included in cmake distributions. 793634 1 179939 kalyan.kondapally 2012-12-18 07:50:22 -0800 Created attachment 179939 patch 793649 2 179939 tmpsantos 2012-12-18 08:00:29 -0800 Comment on attachment 179939 patch View in context: https://bugs.webkit.org/attachment.cgi?id=179939&action=review I'm fine on landing a FindSomething without actually using it if the is a imminent use case. > ChangeLog:4 > + [EFL] Allow the build system to detect EGL support. > + https://bugs.webkit.org/show_bug.cgi?id=105287. Nit, we don't use dots at the end here. > Source/cmake/FindEGL.cmake:36 > + > +include(FindPackageHandleStandardArgs) Where is the FIND_PACKAGE_HANDLE_STANDARD_ARGS? 793652 3 tmpsantos 2012-12-18 08:01:40 -0800 (In reply to comment #2) > (From update of attachment 179939 [details]) > View in context: https://bugs.webkit.org/attachment.cgi?id=179939&action=review > > I'm fine on landing a FindSomething without actually using it if the is a imminent use case. > > > ChangeLog:4 > > + [EFL] Allow the build system to detect EGL support. > > + https://bugs.webkit.org/show_bug.cgi?id=105287. > > Nit, we don't use dots at the end here. > > > Source/cmake/FindEGL.cmake:36 > > + > > +include(FindPackageHandleStandardArgs) > > Where is the FIND_PACKAGE_HANDLE_STANDARD_ARGS? Sorry, the FIND_PACKAGE_HANDLE_STANDARD_ARGS was cropped from my "review window" somehow. But it should be uppercase because is a macro, not a built-in cmake command. 793654 4 tmpsantos 2012-12-18 08:05:12 -0800 (In reply to comment #3) > (In reply to comment #2) > > (From update of attachment 179939 [details] [details]) > > View in context: https://bugs.webkit.org/attachment.cgi?id=179939&action=review > > > > I'm fine on landing a FindSomething without actually using it if the is a imminent use case. > > > > > ChangeLog:4 > > > + [EFL] Allow the build system to detect EGL support. > > > + https://bugs.webkit.org/show_bug.cgi?id=105287. > > > > Nit, we don't use dots at the end here. > > > > > Source/cmake/FindEGL.cmake:36 > > > + > > > +include(FindPackageHandleStandardArgs) > > > > Where is the FIND_PACKAGE_HANDLE_STANDARD_ARGS? > > Sorry, the FIND_PACKAGE_HANDLE_STANDARD_ARGS was cropped from my "review window" somehow. But it should be uppercase because is a macro, not a built-in cmake command. The order of the parameters of the FIND_PACKAGE_HANDLE_STANDARD_ARGS is also wrong. 793700 5 179954 kalyan.kondapally 2012-12-18 08:46:50 -0800 Created attachment 179954 reviewpatch After our discussion, we agree that the order doesn't matter. 793736 6 179954 laszlo.gombos 2012-12-18 09:40:55 -0800 Comment on attachment 179954 reviewpatch lgtm. 793766 7 179954 webkit.review.bot 2012-12-18 10:01:31 -0800 Comment on attachment 179954 reviewpatch Clearing flags on attachment: 179954 Committed r138033: <http://trac.webkit.org/changeset/138033> 793769 8 webkit.review.bot 2012-12-18 10:01:37 -0800 All reviewed patches have been landed. Closing bug. 179939 2012-12-18 07:50:22 -0800 2012-12-18 08:46:50 -0800 patch findegl.patch text/plain 2745 kalyan.kondapally ZGlmZiAtLWdpdCBDaGFuZ2VMb2cgQ2hhbmdlTG9nCmluZGV4IDExNmNmMDUuLjBjMDIzNTcgMTAw NjQ0Ci0tLSBDaGFuZ2VMb2cKKysrIENoYW5nZUxvZwpAQCAtMSwzICsxLDE2IEBACisyMDEyLTEy LTE4ICBLb25kYXBhbGx5IEthbHlhbiAgPGthbHlhbi5rb25kYXBhbGx5QGludGVsLmNvbT4KKwor ICAgICAgICBbRUZMXSBBbGxvdyB0aGUgYnVpbGQgc3lzdGVtIHRvIGRldGVjdCBFR0wgc3VwcG9y dC4KKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTEwNTI4 Ny4KKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBDdXJy ZW50bHksIHdlIGRvbid0IGhhdmUgYW55IHdheSB0byBkZXRlcm1pbmUgaWYgRUdMIGlzIHN1cHBv cnRlZCBieSB0aGUgYnVpbGQuCisgICAgICAgIFRoaXMgcGF0Y2ggYWRkcyBzdXBwb3J0IGZvciB0 aGlzLiBUaGUgcGF0Y2ggZG9lc24ndCBtYWtlIGFueSBjaGFuZ2VzIHRvIHRha2UgdGhpcyBpbnRv CisgICAgICAgIHVzZS4gVGhpcyB3aWxsIGJlIGRvbmUgaW4gYW5vdGhlciBwYXRjaC4KKworICAg ICAgICAqIFNvdXJjZS9jbWFrZS9GaW5kRUdMLmNtYWtlOgorCiAyMDEyLTEyLTA2ICBSaWNrIEJ5 ZXJzICA8cmJ5ZXJzQGNocm9taXVtLm9yZz4KIAogICAgICAgICBDU1MgY3Vyc29yIHByb3BlcnR5 IHNob3VsZCBzdXBwb3J0IHdlYmtpdC1pbWFnZS1zZXQKZGlmZiAtLWdpdCBTb3VyY2UvY21ha2Uv RmluZEVHTC5jbWFrZSBTb3VyY2UvY21ha2UvRmluZEVHTC5jbWFrZQpuZXcgZmlsZSBtb2RlIDEw MDY0NAppbmRleCAwMDAwMDAwLi42OTg0OTNlCi0tLSAvZGV2L251bGwKKysrIFNvdXJjZS9jbWFr ZS9GaW5kRUdMLmNtYWtlCkBAIC0wLDAgKzEsMzcgQEAKKyMgLSBUcnkgdG8gRmluZCBFR0wKKyMg T25jZSBkb25lLCB0aGlzIHdpbGwgZGVmaW5lCisjCisjICBFR0xfRk9VTkQgLSBzeXN0ZW0gaGFz IEVHTCBpbnN0YWxsZWQuCisjICBFR0xfSU5DTFVERV9ESVIgLSBkaXJlY3RvcmllcyB3aGljaCBj b250YWluIHRoZSBFR0wgaGVhZGVycy4KKyMgIEVHTF9MSUJSQVJZIC0gbGlicmFyaWVzIHJlcXVp cmVkIHRvIGxpbmsgYWdhaW5zdCBFR0wuCisjCisjIENvcHlyaWdodCAoQykgMjAxMiBJbnRlbCBD b3Jwb3JhdGlvbi4gQWxsIHJpZ2h0cyByZXNlcnZlZC4KKyMKKyMgUmVkaXN0cmlidXRpb24gYW5k IHVzZSBpbiBzb3VyY2UgYW5kIGJpbmFyeSBmb3Jtcywgd2l0aCBvciB3aXRob3V0CisjIG1vZGlm aWNhdGlvbiwgYXJlIHBlcm1pdHRlZCBwcm92aWRlZCB0aGF0IHRoZSBmb2xsb3dpbmcgY29uZGl0 aW9ucworIyBhcmUgbWV0OgorIyAxLiAgUmVkaXN0cmlidXRpb25zIG9mIHNvdXJjZSBjb2RlIG11 c3QgcmV0YWluIHRoZSBhYm92ZSBjb3B5cmlnaHQKKyMgICAgIG5vdGljZSwgdGhpcyBsaXN0IG9m IGNvbmRpdGlvbnMgYW5kIHRoZSBmb2xsb3dpbmcgZGlzY2xhaW1lci4KKyMgMi4gIFJlZGlzdHJp YnV0aW9ucyBpbiBiaW5hcnkgZm9ybSBtdXN0IHJlcHJvZHVjZSB0aGUgYWJvdmUgY29weXJpZ2h0 CisjICAgICBub3RpY2UsIHRoaXMgbGlzdCBvZiBjb25kaXRpb25zIGFuZCB0aGUgZm9sbG93aW5n IGRpc2NsYWltZXIgaW4gdGhlCisjICAgICBkb2N1bWVudGF0aW9uIGFuZC9vciBvdGhlciBtYXRl cmlhbHMgcHJvdmlkZWQgd2l0aCB0aGUgZGlzdHJpYnV0aW9uLgorIworIyBUSElTIFNPRlRXQVJF IElTIFBST1ZJREVEIEJZIFRIRSBDT1BZUklHSFQgSE9MREVSIEFORCBJVFMgQ09OVFJJQlVUT1JT IGBgQVMKKyMgSVMnJyBBTkQgQU5ZIEVYUFJFU1MgT1IgSU1QTElFRCBXQVJSQU5USUVTLCBJTkNM VURJTkcsIEJVVCBOT1QgTElNSVRFRCBUTywKKyMgVEhFIElNUExJRUQgV0FSUkFOVElFUyBPRiBN RVJDSEFOVEFCSUxJVFkgQU5EIEZJVE5FU1MgRk9SIEEgUEFSVElDVUxBUgorIyBQVVJQT1NFIEFS RSBESVNDTEFJTUVELiBJTiBOTyBFVkVOVCBTSEFMTCBUSEUgQ09QWVJJR0hUIEhPTERFUiBPUiBJ VFMKKyMgQ09OVFJJQlVUT1JTIEJFIExJQUJMRSBGT1IgQU5ZIERJUkVDVCwgSU5ESVJFQ1QsIElO Q0lERU5UQUwsIFNQRUNJQUwsCisjIEVYRU1QTEFSWSwgT1IgQ09OU0VRVUVOVElBTCBEQU1BR0VT IChJTkNMVURJTkcsIEJVVCBOT1QgTElNSVRFRCBUTywKKyMgUFJPQ1VSRU1FTlQgT0YgU1VCU1RJ VFVURSBHT09EUyBPUiBTRVJWSUNFUzsgTE9TUyBPRiBVU0UsIERBVEEsIE9SIFBST0ZJVFM7Cisj IE9SIEJVU0lORVNTIElOVEVSUlVQVElPTikgSE9XRVZFUiBDQVVTRUQgQU5EIE9OIEFOWSBUSEVP UlkgT0YgTElBQklMSVRZLAorIyBXSEVUSEVSIElOIENPTlRSQUNULCBTVFJJQ1QgTElBQklMSVRZ LCBPUiBUT1JUIChJTkNMVURJTkcgTkVHTElHRU5DRSBPUgorIyBPVEhFUldJU0UpIEFSSVNJTkcg SU4gQU5ZIFdBWSBPVVQgT0YgVEhFIFVTRSBPRiBUSElTIFNPRlRXQVJFLCBFVkVOIElGCisjIEFE VklTRUQgT0YgVEhFIFBPU1NJQklMSVRZIE9GIFNVQ0ggREFNQUdFLgorCitmaW5kX3BhdGgoRUdM X0lOQ0xVREVfRElSIE5BTUVTIEVHTC9lZ2wuaCkKKworc2V0KEVHTF9OQU1FUyAke0VHTF9OQU1F U30gZWdsIEVHTCkKK2ZpbmRfbGlicmFyeShFR0xfTElCUkFSWSBOQU1FUyAke0VHTF9OQU1FU30p CisKK2luY2x1ZGUoRmluZFBhY2thZ2VIYW5kbGVTdGFuZGFyZEFyZ3MpCitmaW5kX3BhY2thZ2Vf aGFuZGxlX3N0YW5kYXJkX2FyZ3MoRUdMIERFRkFVTFRfTVNHIEVHTF9MSUJSQVJZIEVHTF9JTkNM VURFX0RJUikK 179954 2012-12-18 08:46:50 -0800 2012-12-18 10:01:30 -0800 reviewpatch reviewfix.patch text/plain 2744 kalyan.kondapally ZGlmZiAtLWdpdCBDaGFuZ2VMb2cgQ2hhbmdlTG9nCmluZGV4IDExNmNmMDUuLmY3ZjllMDEgMTAw NjQ0Ci0tLSBDaGFuZ2VMb2cKKysrIENoYW5nZUxvZwpAQCAtMSwzICsxLDE2IEBACisyMDEyLTEy LTE4ICBLb25kYXBhbGx5IEthbHlhbiAgPGthbHlhbi5rb25kYXBhbGx5QGludGVsLmNvbT4KKwor ICAgICAgICBbRUZMXSBBbGxvdyB0aGUgYnVpbGQgc3lzdGVtIHRvIGRldGVjdCBFR0wgc3VwcG9y dC4KKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTEwNTI4 NworCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIEN1cnJl bnRseSwgd2UgZG9uJ3QgaGF2ZSBhbnkgd2F5IHRvIGRldGVybWluZSBpZiBFR0wgaXMgc3VwcG9y dGVkIGJ5IHRoZSBidWlsZC4KKyAgICAgICAgVGhpcyBwYXRjaCBhZGRzIHN1cHBvcnQgZm9yIHRo aXMuIFRoZSBwYXRjaCBkb2Vzbid0IG1ha2UgYW55IGNoYW5nZXMgdG8gdGFrZSB0aGlzIGludG8K KyAgICAgICAgdXNlLiBUaGlzIHdpbGwgYmUgZG9uZSBpbiBhbm90aGVyIHBhdGNoLgorCisgICAg ICAgICogU291cmNlL2NtYWtlL0ZpbmRFR0wuY21ha2U6CisKIDIwMTItMTItMDYgIFJpY2sgQnll cnMgIDxyYnllcnNAY2hyb21pdW0ub3JnPgogCiAgICAgICAgIENTUyBjdXJzb3IgcHJvcGVydHkg c2hvdWxkIHN1cHBvcnQgd2Via2l0LWltYWdlLXNldApkaWZmIC0tZ2l0IFNvdXJjZS9jbWFrZS9G aW5kRUdMLmNtYWtlIFNvdXJjZS9jbWFrZS9GaW5kRUdMLmNtYWtlCm5ldyBmaWxlIG1vZGUgMTAw NjQ0CmluZGV4IDAwMDAwMDAuLjUyNmM1YmEKLS0tIC9kZXYvbnVsbAorKysgU291cmNlL2NtYWtl L0ZpbmRFR0wuY21ha2UKQEAgLTAsMCArMSwzNyBAQAorIyAtIFRyeSB0byBGaW5kIEVHTAorIyBP bmNlIGRvbmUsIHRoaXMgd2lsbCBkZWZpbmUKKyMKKyMgIEVHTF9GT1VORCAtIHN5c3RlbSBoYXMg RUdMIGluc3RhbGxlZC4KKyMgIEVHTF9JTkNMVURFX0RJUiAtIGRpcmVjdG9yaWVzIHdoaWNoIGNv bnRhaW4gdGhlIEVHTCBoZWFkZXJzLgorIyAgRUdMX0xJQlJBUlkgLSBsaWJyYXJpZXMgcmVxdWly ZWQgdG8gbGluayBhZ2FpbnN0IEVHTC4KKyMKKyMgQ29weXJpZ2h0IChDKSAyMDEyIEludGVsIENv cnBvcmF0aW9uLiBBbGwgcmlnaHRzIHJlc2VydmVkLgorIworIyBSZWRpc3RyaWJ1dGlvbiBhbmQg dXNlIGluIHNvdXJjZSBhbmQgYmluYXJ5IGZvcm1zLCB3aXRoIG9yIHdpdGhvdXQKKyMgbW9kaWZp Y2F0aW9uLCBhcmUgcGVybWl0dGVkIHByb3ZpZGVkIHRoYXQgdGhlIGZvbGxvd2luZyBjb25kaXRp b25zCisjIGFyZSBtZXQ6CisjIDEuICBSZWRpc3RyaWJ1dGlvbnMgb2Ygc291cmNlIGNvZGUgbXVz dCByZXRhaW4gdGhlIGFib3ZlIGNvcHlyaWdodAorIyAgICAgbm90aWNlLCB0aGlzIGxpc3Qgb2Yg Y29uZGl0aW9ucyBhbmQgdGhlIGZvbGxvd2luZyBkaXNjbGFpbWVyLgorIyAyLiAgUmVkaXN0cmli dXRpb25zIGluIGJpbmFyeSBmb3JtIG11c3QgcmVwcm9kdWNlIHRoZSBhYm92ZSBjb3B5cmlnaHQK KyMgICAgIG5vdGljZSwgdGhpcyBsaXN0IG9mIGNvbmRpdGlvbnMgYW5kIHRoZSBmb2xsb3dpbmcg ZGlzY2xhaW1lciBpbiB0aGUKKyMgICAgIGRvY3VtZW50YXRpb24gYW5kL29yIG90aGVyIG1hdGVy aWFscyBwcm92aWRlZCB3aXRoIHRoZSBkaXN0cmlidXRpb24uCisjCisjIFRISVMgU09GVFdBUkUg SVMgUFJPVklERUQgQlkgVEhFIENPUFlSSUdIVCBIT0xERVIgQU5EIElUUyBDT05UUklCVVRPUlMg YGBBUworIyBJUycnIEFORCBBTlkgRVhQUkVTUyBPUiBJTVBMSUVEIFdBUlJBTlRJRVMsIElOQ0xV RElORywgQlVUIE5PVCBMSU1JVEVEIFRPLAorIyBUSEUgSU1QTElFRCBXQVJSQU5USUVTIE9GIE1F UkNIQU5UQUJJTElUWSBBTkQgRklUTkVTUyBGT1IgQSBQQVJUSUNVTEFSCisjIFBVUlBPU0UgQVJF IERJU0NMQUlNRUQuIElOIE5PIEVWRU5UIFNIQUxMIFRIRSBDT1BZUklHSFQgSE9MREVSIE9SIElU UworIyBDT05UUklCVVRPUlMgQkUgTElBQkxFIEZPUiBBTlkgRElSRUNULCBJTkRJUkVDVCwgSU5D SURFTlRBTCwgU1BFQ0lBTCwKKyMgRVhFTVBMQVJZLCBPUiBDT05TRVFVRU5USUFMIERBTUFHRVMg KElOQ0xVRElORywgQlVUIE5PVCBMSU1JVEVEIFRPLAorIyBQUk9DVVJFTUVOVCBPRiBTVUJTVElU VVRFIEdPT0RTIE9SIFNFUlZJQ0VTOyBMT1NTIE9GIFVTRSwgREFUQSwgT1IgUFJPRklUUzsKKyMg T1IgQlVTSU5FU1MgSU5URVJSVVBUSU9OKSBIT1dFVkVSIENBVVNFRCBBTkQgT04gQU5ZIFRIRU9S WSBPRiBMSUFCSUxJVFksCisjIFdIRVRIRVIgSU4gQ09OVFJBQ1QsIFNUUklDVCBMSUFCSUxJVFks IE9SIFRPUlQgKElOQ0xVRElORyBORUdMSUdFTkNFIE9SCisjIE9USEVSV0lTRSkgQVJJU0lORyBJ TiBBTlkgV0FZIE9VVCBPRiBUSEUgVVNFIE9GIFRISVMgU09GVFdBUkUsIEVWRU4gSUYKKyMgQURW SVNFRCBPRiBUSEUgUE9TU0lCSUxJVFkgT0YgU1VDSCBEQU1BR0UuCisKK2ZpbmRfcGF0aChFR0xf SU5DTFVERV9ESVIgTkFNRVMgRUdML2VnbC5oKQorCitzZXQoRUdMX05BTUVTICR7RUdMX05BTUVT fSBlZ2wgRUdMKQorZmluZF9saWJyYXJ5KEVHTF9MSUJSQVJZIE5BTUVTICR7RUdMX05BTUVTfSkK KworaW5jbHVkZShGaW5kUGFja2FnZUhhbmRsZVN0YW5kYXJkQXJncykKK0ZJTkRfUEFDS0FHRV9I QU5ETEVfU1RBTkRBUkRfQVJHUyhFR0wgREVGQVVMVF9NU0cgRUdMX0lOQ0xVREVfRElSIEVHTF9M SUJSQVJZKQo=