105282 2012-12-18 05:55:45 -0800 Date.prototype.toJSON does not execute steps 1-2 2019-09-13 17:26:16 -0700 1 1 1 Unclassified WebKit JavaScriptCore 528+ (Nightly build) All All RESOLVED FIXED InRadar P2 Normal --- 0 andre.bargull webkit-unassigned ashvayka barraclough commit-queue ews-feeder ews-watchlist fpizlo keith_miller mark.lam msaboff oliver ross.kirsling saam tzagallo webkit-bug-importer oldest_to_newest 793580 0 andre.bargull 2012-12-18 05:55:45 -0800 test case: --- > this.toISOString = function(){print("global toISOString")} function () {print("global toISOString");} > Date.prototype.toJSON.call(null) global toISOString > Date.prototype.toJSON.call(void 0) global toISOString > Date.prototype.toJSON.call({ valueOf: function(){print("ToPrimitive(valueOf) called"); return 0}, toISOString: function(){print("toISOString called")} }) toISOString called --- [ES5.1 - 15.9.5.44 Date.prototype.toJSON] steps 1-2 aren't executed properly: - the first two calls should raise a TypeError because ToObject() is called with an incompatible argument (step 1 of 15.9.5.44) - the last call should invoke the supplied valueOf() function (step 2 of 15.9.5.44) 1541704 1 ashvayka 2019-06-04 12:53:48 -0700 As of build 246014, ToPrimitive is called with proper hint, but `this` value is still resolved using sloppy mode semantics, resulting in ToObject being called on global object. Test262: https://github.com/tc39/test262/pull/2190 1541707 2 371320 ashvayka 2019-06-04 12:56:38 -0700 Created attachment 371320 Patch 1545737 3 372364 ashvayka 2019-06-18 12:53:53 -0700 Created attachment 372364 Patch With test262 imported, this patch now fixes a test. 1545744 4 372364 oliver 2019-06-18 12:57:22 -0700 Comment on attachment 372364 Patch lgtm (I wonder if the spec changed at some point?) 1545759 5 372364 ashvayka 2019-06-18 13:22:00 -0700 Comment on attachment 372364 Patch Yes, but in a subtle way: ES5 introduced strict mode for built-in functions. 1545762 6 372364 ews-feeder 2019-06-18 13:22:30 -0700 Comment on attachment 372364 Patch Rejecting attachment 372364 from review queue. oliver@nerget.com does not have reviewer permissions according to https://trac.webkit.org/browser/trunk/Tools/Scripts/webkitpy/common/config/contributors.json. - If you do not have reviewer rights please read http://webkit.org/coding/contributing.html for instructions on how to use bugzilla flags. - If you have reviewer rights please correct the error in Tools/Scripts/webkitpy/common/config/contributors.json by adding yourself to the file (no review needed). The commit-queue restarts itself every 2 hours. After restart the commit-queue will correctly respect your reviewer rights. 1545765 7 372364 ews-feeder 2019-06-18 13:23:05 -0700 Comment on attachment 372364 Patch Rejecting attachment 372364 from commit-queue. shvaikalesh@gmail.com does not have committer permissions according to https://trac.webkit.org/browser/trunk/Tools/Scripts/webkitpy/common/config/contributors.json. - If you do not have committer rights please read http://webkit.org/coding/contributing.html for instructions on how to use bugzilla flags. - If you have committer rights please correct the error in Tools/Scripts/webkitpy/common/config/contributors.json by adding yourself to the file (no review needed). The commit-queue restarts itself every 2 hours. After restart the commit-queue will correctly respect your committer rights. 1545783 8 oliver 2019-06-18 13:47:56 -0700 (In reply to ews-feeder from comment #6) > Comment on attachment 372364 [details] > Patch > > Rejecting attachment 372364 [details] from review queue. > > oliver@nerget.com does not have reviewer permissions according to > https://trac.webkit.org/browser/trunk/Tools/Scripts/webkitpy/common/config/ > contributors.json. > Oh boo, I guess that list never got updated. 1545788 9 ashvayka 2019-06-18 13:55:48 -0700 (In reply to Oliver Hunt from comment #8) > (In reply to ews-feeder from comment #6) > > Comment on attachment 372364 [details] > > Patch > > > > Rejecting attachment 372364 [details] from review queue. > > > > oliver@nerget.com does not have reviewer permissions according to > > https://trac.webkit.org/browser/trunk/Tools/Scripts/webkitpy/common/config/ > > contributors.json. > > > > Oh boo, I guess that list never got updated. Completely my fault: I attempted commit-queue+ and miserably failed. I guess re-review would help. 1570335 10 372364 ross.kirsling 2019-09-12 12:39:58 -0700 Comment on attachment 372364 Patch Just noticed this now. r=me but I think you'll need to rebase expectations.yaml. 1570419 11 378688 ashvayka 2019-09-12 16:22:27 -0700 Created attachment 378688 Patch Rebase patch and simplify std::isfinite check. 1570420 12 ashvayka 2019-09-12 16:23:14 -0700 Thank you for review. I took the liberty of tweaking time value finiteness check (step 3 of https://tc39.es/ecma262/#sec-date.prototype.tojson). While it removes weird isInt32() call, it doesn't justifies making a separate patch IMO. 1570438 13 ross.kirsling 2019-09-12 17:25:36 -0700 (In reply to Alexey Shvayka from comment #12) > Thank you for review. > > I took the liberty of tweaking time value finiteness check (step 3 of > https://tc39.es/ecma262/#sec-date.prototype.tojson). > While it removes weird isInt32() call, it doesn't justifies making a > separate patch IMO. Yeah, that seems fine -- guess it's trying to avoid calling std::isfinite unnecessarily, but that should just amount to `return true` for integral types anyway. 1570449 14 378688 mark.lam 2019-09-12 17:46:15 -0700 Comment on attachment 378688 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=378688&action=review > Source/JavaScriptCore/ChangeLog:8 > + Resolve `this` value using strict mode semantics. Can you add a link to the relevant piece of the spec for this change? 1570465 15 378688 mark.lam 2019-09-12 18:48:46 -0700 Comment on attachment 378688 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=378688&action=review >> Source/JavaScriptCore/ChangeLog:8 >> + Resolve `this` value using strict mode semantics. > > Can you add a link to the relevant piece of the spec for this change? nit: Please also describe what the issue is and why the fix works (if not obvious) here in the ChangeLog. I think the description in https://bugs.webkit.org/show_bug.cgi?id=105282#c0 covers this quite well. We prefer to make the ChangeLog as descriptive as possible so that if we need to investigate why a change was made, it provides the intent of the author. Granted, this info may also be present in the bugzilla, but often, the thinking about an issue changes over the period when the issue is being investigated. Capturing the final understanding on the nature of bug and its fix in the ChangeLog makes it more digestible than having to splunk through the bugzilla comment trail. Secondly, in my personal experience, when I have to write a descriptive ChangeLog, it forces me to make sure that I really understand what I'm changing, and serves as a sanity check to prevent bugs from creeping in. So, please add a descriptive ChangeLog, plus a link to the relevant section of the spec for reference. Thanks. 1570749 16 378761 ashvayka 2019-09-13 16:38:37 -0700 Created attachment 378761 Patch Set reviewer and add descriptive ChangeLog. 1570750 17 378761 mark.lam 2019-09-13 16:40:30 -0700 Comment on attachment 378761 Patch Thanks. 1570770 18 378761 commit-queue 2019-09-13 17:24:30 -0700 Comment on attachment 378761 Patch Clearing flags on attachment: 378761 Committed r249861: <https://trac.webkit.org/changeset/249861> 1570771 19 commit-queue 2019-09-13 17:24:32 -0700 All reviewed patches have been landed. Closing bug. 1570772 20 webkit-bug-importer 2019-09-13 17:25:21 -0700 <rdar://problem/55358552> 1570774 21 ashvayka 2019-09-13 17:26:16 -0700 (In reply to Ross Kirsling from comment #13) > > Yeah, that seems fine -- guess it's trying to avoid calling std::isfinite > unnecessarily, but that should just amount to `return true` for integral > types anyway. Thanks, it didn't occur to me that std::isfinite might be slow. I've benchmarked code path that is largely dependent on finiteness check performance with: ``` const date = new Date(NaN); for (let i = 0; i < 1e6; ++i) date.toJSON(); ``` Proposed tweak and trunk did perform equally (within 1%). (In reply to Mark Lam from comment #15) > > Secondly, in my personal experience, when I have to write a descriptive > ChangeLog, it forces me to make sure that I really understand what I'm > changing, and serves as a sanity check to prevent bugs from creeping in. Thank you for detailed explanation. As outside contributor, I find ChangeLogs extremely useful as sources of motivation for some classes like JSCell or CustomGetterSetter. Also, descriptive ChangeLog for this patch in particular is highly important, because first comment and bug title are quite different from what the patch fixes. 371320 2019-06-04 12:56:38 -0700 2019-06-18 12:53:49 -0700 Patch bug-105282-20190604225637.patch text/plain 1418 ashvayka SW5kZXg6IFNvdXJjZS9KYXZhU2NyaXB0Q29yZS9DaGFuZ2VMb2cKPT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gU291 cmNlL0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwkocmV2aXNpb24gMjQ2MDc2KQorKysgU291cmNl L0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDE1IEBA CisyMDE5LTA2LTA0ICBBbGVrc2V5IFNodmF5a2EgIDxzaHZhaWthbGVzaEBnbWFpbC5jb20+CisK KyAgICAgICAgRGF0ZS5wcm90b3R5cGUudG9KU09OIGRvZXMgbm90IGV4ZWN1dGUgc3RlcHMgMS0y CisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xMDUyODIK KworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBSZXNvbHZl IGB0aGlzYCB2YWx1ZSB1c2luZyBzdHJpY3QgbW9kZSBzZW1hbnRpY3MuCisKKyAgICAgICAgKiBy dW50aW1lL0RhdGVQcm90b3R5cGUuY3BwOgorICAgICAgICAoSlNDOjpkYXRlUHJvdG9GdW5jVG9K U09OKTogUmVtb3ZlIHRvVGhpcyBjYWxsLgorCiAyMDE5LTA2LTA0ICBUYWRldSBaYWdhbGxvICA8 dHphZ2FsbG9AYXBwbGUuY29tPgogCiAgICAgICAgIEFyZ3VtZW50IGVsaW1pbmF0aW9uIHNob3Vs ZCBjaGVjayB0cmFuc2l0aXZlIGRlcGVuZGVudHMgZm9yIGludGVyZmVyZW5jZQpJbmRleDogU291 cmNlL0phdmFTY3JpcHRDb3JlL3J1bnRpbWUvRGF0ZVByb3RvdHlwZS5jcHAKPT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQot LS0gU291cmNlL0phdmFTY3JpcHRDb3JlL3J1bnRpbWUvRGF0ZVByb3RvdHlwZS5jcHAJKHJldmlz aW9uIDI0NjA2NykKKysrIFNvdXJjZS9KYXZhU2NyaXB0Q29yZS9ydW50aW1lL0RhdGVQcm90b3R5 cGUuY3BwCSh3b3JraW5nIGNvcHkpCkBAIC0xMTQ1LDcgKzExNDUsNyBAQCBFbmNvZGVkSlNWYWx1 ZSBKU0NfSE9TVF9DQUxMIGRhdGVQcm90b0Z1CiAgICAgVk0mIHZtID0gZXhlYy0+dm0oKTsKICAg ICBhdXRvIHNjb3BlID0gREVDTEFSRV9USFJPV19TQ09QRSh2bSk7CiAgICAgSlNWYWx1ZSB0aGlz VmFsdWUgPSBleGVjLT50aGlzVmFsdWUoKTsKLSAgICBKU09iamVjdCogb2JqZWN0ID0ganNDYXN0 PEpTT2JqZWN0Kj4odGhpc1ZhbHVlLnRvVGhpcyhleGVjLCBOb3RTdHJpY3RNb2RlKSk7CisgICAg SlNPYmplY3QqIG9iamVjdCA9IHRoaXNWYWx1ZS50b09iamVjdChleGVjKTsKICAgICBSRVRVUk5f SUZfRVhDRVBUSU9OKHNjb3BlLCBlbmNvZGVkSlNWYWx1ZSgpKTsKIAogICAgIEpTVmFsdWUgdGlt ZVZhbHVlID0gb2JqZWN0LT50b1ByaW1pdGl2ZShleGVjLCBQcmVmZXJOdW1iZXIpOwo= 372364 2019-06-18 12:53:53 -0700 2019-09-12 16:22:21 -0700 Patch bug-105282-20190618225352.patch text/plain 2958 ashvayka SW5kZXg6IEpTVGVzdHMvQ2hhbmdlTG9nCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIEpTVGVzdHMvQ2hhbmdlTG9n CShyZXZpc2lvbiAyNDY1NjApCisrKyBKU1Rlc3RzL0NoYW5nZUxvZwkod29ya2luZyBjb3B5KQpA QCAtMSwzICsxLDEyIEBACisyMDE5LTA2LTE4ICBBbGV4ZXkgU2h2YXlrYSAgPHNodmFpa2FsZXNo QGdtYWlsLmNvbT4KKworICAgICAgICBEYXRlLnByb3RvdHlwZS50b0pTT04gZG9lcyBub3QgZXhl Y3V0ZSBzdGVwcyAxLTIKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcu Y2dpP2lkPTEwNTI4MgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisg ICAgICAgICogdGVzdDI2Mi9leHBlY3RhdGlvbnMueWFtbDogTWFyayAyIHRlc3QgY2FzZXMgYXMg cGFzc2luZy4KKwogMjAxOS0wNi0xOCAgVGFkZXUgWmFnYWxsbyAgPHR6YWdhbGxvQGFwcGxlLmNv bT4KIAogICAgICAgICBERkcgY29kZSBzaG91bGQgbm90IHJlaWZ5IHRoZSBuYW1lcyBvZiBidWls dGluIGZ1bmN0aW9ucyB3aXRoIHByaXZhdGUgbmFtZXMKSW5kZXg6IEpTVGVzdHMvdGVzdDI2Mi9l eHBlY3RhdGlvbnMueWFtbAo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBKU1Rlc3RzL3Rlc3QyNjIvZXhwZWN0YXRp b25zLnlhbWwJKHJldmlzaW9uIDI0NjU1OCkKKysrIEpTVGVzdHMvdGVzdDI2Mi9leHBlY3RhdGlv bnMueWFtbAkod29ya2luZyBjb3B5KQpAQCAtODczLDkgKzg3Myw2IEBAIHRlc3QvYnVpbHQtaW5z L0RhdGUvcHJvdG90eXBlL3RvRGF0ZVN0cmkKIHRlc3QvYnVpbHQtaW5zL0RhdGUvcHJvdG90eXBl L3RvSlNPTi9pbnZva2UtcmVzdWx0LmpzOgogICBkZWZhdWx0OiAnVHlwZUVycm9yOiB0b0lTT1N0 cmluZyBkaWQgbm90IHJldHVybiBhIHByaW1pdGl2ZSB2YWx1ZScKICAgc3RyaWN0IG1vZGU6ICdU eXBlRXJyb3I6IHRvSVNPU3RyaW5nIGRpZCBub3QgcmV0dXJuIGEgcHJpbWl0aXZlIHZhbHVlJwot dGVzdC9idWlsdC1pbnMvRGF0ZS9wcm90b3R5cGUvdG9KU09OL3RvLW9iamVjdC5qczoKLSAgZGVm YXVsdDogJ1Rlc3QyNjJFcnJvcjogRXhwZWN0ZWQgYSBUeXBlRXJyb3IgdG8gYmUgdGhyb3duIGJ1 dCBubyBleGNlcHRpb24gd2FzIHRocm93biBhdCBhbGwnCi0gIHN0cmljdCBtb2RlOiAnVGVzdDI2 MkVycm9yOiBFeHBlY3RlZCBhIFR5cGVFcnJvciB0byBiZSB0aHJvd24gYnV0IG5vIGV4Y2VwdGlv biB3YXMgdGhyb3duIGF0IGFsbCcKIHRlc3QvYnVpbHQtaW5zL0RhdGUvcHJvdG90eXBlL3RvSlNP Ti90by1wcmltaXRpdmUtc3ltYm9sLmpzOgogICBkZWZhdWx0OiAnVHlwZUVycm9yOiB0b0lTT1N0 cmluZyBkaWQgbm90IHJldHVybiBhIHByaW1pdGl2ZSB2YWx1ZScKICAgc3RyaWN0IG1vZGU6ICdU eXBlRXJyb3I6IHRvSVNPU3RyaW5nIGRpZCBub3QgcmV0dXJuIGEgcHJpbWl0aXZlIHZhbHVlJwpJ bmRleDogU291cmNlL0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3Vy Y2UvSmF2YVNjcmlwdENvcmUvQ2hhbmdlTG9nCShyZXZpc2lvbiAyNDY1NTgpCisrKyBTb3VyY2Uv SmF2YVNjcmlwdENvcmUvQ2hhbmdlTG9nCSh3b3JraW5nIGNvcHkpCkBAIC0xLDMgKzEsMTUgQEAK KzIwMTktMDYtMTggIEFsZXhleSBTaHZheWthICA8c2h2YWlrYWxlc2hAZ21haWwuY29tPgorCisg ICAgICAgIERhdGUucHJvdG90eXBlLnRvSlNPTiBkb2VzIG5vdCBleGVjdXRlIHN0ZXBzIDEtMgor ICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTA1MjgyCisK KyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgUmVzb2x2ZSBg dGhpc2AgdmFsdWUgdXNpbmcgc3RyaWN0IG1vZGUgc2VtYW50aWNzLgorCisgICAgICAgICogcnVu dGltZS9EYXRlUHJvdG90eXBlLmNwcDoKKyAgICAgICAgKEpTQzo6ZGF0ZVByb3RvRnVuY1RvSlNP Tik6IFJlbW92ZSB0b1RoaXMgY2FsbC4KKwogMjAxOS0wNi0xOCAgVGFkZXUgWmFnYWxsbyAgPHR6 YWdhbGxvQGFwcGxlLmNvbT4KIAogICAgICAgICBERkcgY29kZSBzaG91bGQgbm90IHJlaWZ5IHRo ZSBuYW1lcyBvZiBidWlsdGluIGZ1bmN0aW9ucyB3aXRoIHByaXZhdGUgbmFtZXMKSW5kZXg6IFNv dXJjZS9KYXZhU2NyaXB0Q29yZS9ydW50aW1lL0RhdGVQcm90b3R5cGUuY3BwCj09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0K LS0tIFNvdXJjZS9KYXZhU2NyaXB0Q29yZS9ydW50aW1lL0RhdGVQcm90b3R5cGUuY3BwCShyZXZp c2lvbiAyNDY1NTgpCisrKyBTb3VyY2UvSmF2YVNjcmlwdENvcmUvcnVudGltZS9EYXRlUHJvdG90 eXBlLmNwcAkod29ya2luZyBjb3B5KQpAQCAtMTE0NSw3ICsxMTQ1LDcgQEAgRW5jb2RlZEpTVmFs dWUgSlNDX0hPU1RfQ0FMTCBkYXRlUHJvdG9GdQogICAgIFZNJiB2bSA9IGV4ZWMtPnZtKCk7CiAg ICAgYXV0byBzY29wZSA9IERFQ0xBUkVfVEhST1dfU0NPUEUodm0pOwogICAgIEpTVmFsdWUgdGhp c1ZhbHVlID0gZXhlYy0+dGhpc1ZhbHVlKCk7Ci0gICAgSlNPYmplY3QqIG9iamVjdCA9IGpzQ2Fz dDxKU09iamVjdCo+KHRoaXNWYWx1ZS50b1RoaXMoZXhlYywgTm90U3RyaWN0TW9kZSkpOworICAg IEpTT2JqZWN0KiBvYmplY3QgPSB0aGlzVmFsdWUudG9PYmplY3QoZXhlYyk7CiAgICAgUkVUVVJO X0lGX0VYQ0VQVElPTihzY29wZSwgZW5jb2RlZEpTVmFsdWUoKSk7CiAKICAgICBKU1ZhbHVlIHRp bWVWYWx1ZSA9IG9iamVjdC0+dG9QcmltaXRpdmUoZXhlYywgUHJlZmVyTnVtYmVyKTsK 378688 2019-09-12 16:22:27 -0700 2019-09-13 16:38:31 -0700 Patch bug-105282-20190913022225.patch text/plain 3218 ashvayka SW5kZXg6IEpTVGVzdHMvQ2hhbmdlTG9nCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIEpTVGVzdHMvQ2hhbmdlTG9n CShyZXZpc2lvbiAyNDk4MTgpCisrKyBKU1Rlc3RzL0NoYW5nZUxvZwkod29ya2luZyBjb3B5KQpA QCAtMSwzICsxLDEyIEBACisyMDE5LTA5LTEyICBBbGV4ZXkgU2h2YXlrYSAgPHNodmFpa2FsZXNo QGdtYWlsLmNvbT4KKworICAgICAgICBEYXRlLnByb3RvdHlwZS50b0pTT04gZG9lcyBub3QgZXhl Y3V0ZSBzdGVwcyAxLTIKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcu Y2dpP2lkPTEwNTI4MgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisg ICAgICAgICogdGVzdDI2Mi9leHBlY3RhdGlvbnMueWFtbDogTWFyayAyIHRlc3QgY2FzZXMgYXMg cGFzc2luZy4KKwogMjAxOS0wOS0xMiAgTWFyayBMYW0gIDxtYXJrLmxhbUBhcHBsZS5jb20+CiAK ICAgICAgICAgSGFyZGVuIEpTQyBhZ2FpbnN0IHRoZSBhYnVzZSBvZiBydW50aW1lIG9wdGlvbnMu CkluZGV4OiBKU1Rlc3RzL3Rlc3QyNjIvZXhwZWN0YXRpb25zLnlhbWwKPT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0g SlNUZXN0cy90ZXN0MjYyL2V4cGVjdGF0aW9ucy55YW1sCShyZXZpc2lvbiAyNDk4MTgpCisrKyBK U1Rlc3RzL3Rlc3QyNjIvZXhwZWN0YXRpb25zLnlhbWwJKHdvcmtpbmcgY29weSkKQEAgLTg1OCw5 ICs4NTgsNiBAQCB0ZXN0L2J1aWx0LWlucy9EYXRlL3Byb3RvLWZyb20tY3Rvci1yZWFsCiB0ZXN0 L2J1aWx0LWlucy9EYXRlL3Byb3RvLWZyb20tY3Rvci1yZWFsbS16ZXJvLmpzOgogICBkZWZhdWx0 OiAnVHlwZUVycm9yOiBUeXBlIGVycm9yJwogICBzdHJpY3QgbW9kZTogJ1R5cGVFcnJvcjogVHlw ZSBlcnJvcicKLXRlc3QvYnVpbHQtaW5zL0RhdGUvcHJvdG90eXBlL3RvSlNPTi90by1vYmplY3Qu anM6Ci0gIGRlZmF1bHQ6ICdUZXN0MjYyRXJyb3I6IEV4cGVjdGVkIGEgVHlwZUVycm9yIHRvIGJl IHRocm93biBidXQgbm8gZXhjZXB0aW9uIHdhcyB0aHJvd24gYXQgYWxsJwotICBzdHJpY3QgbW9k ZTogJ1Rlc3QyNjJFcnJvcjogRXhwZWN0ZWQgYSBUeXBlRXJyb3IgdG8gYmUgdGhyb3duIGJ1dCBu byBleGNlcHRpb24gd2FzIHRocm93biBhdCBhbGwnCiB0ZXN0L2J1aWx0LWlucy9FcnJvci9wcm90 by1mcm9tLWN0b3ItcmVhbG0uanM6CiAgIGRlZmF1bHQ6ICdUZXN0MjYyRXJyb3I6IEV4cGVjdGVk IFNhbWVWYWx1ZSjDgsKrRXJyb3LDgsK7LCDDgsKrRXJyb3LDgsK7KSB0byBiZSB0cnVlJwogICBz dHJpY3QgbW9kZTogJ1Rlc3QyNjJFcnJvcjogRXhwZWN0ZWQgU2FtZVZhbHVlKMOCwqtFcnJvcsOC wrssIMOCwqtFcnJvcsOCwrspIHRvIGJlIHRydWUnCkluZGV4OiBTb3VyY2UvSmF2YVNjcmlwdENv cmUvQ2hhbmdlTG9nCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFNvdXJjZS9KYXZhU2NyaXB0Q29yZS9DaGFuZ2VM b2cJKHJldmlzaW9uIDI0OTgxOCkKKysrIFNvdXJjZS9KYXZhU2NyaXB0Q29yZS9DaGFuZ2VMb2cJ KHdvcmtpbmcgY29weSkKQEAgLTEsMyArMSwxNSBAQAorMjAxOS0wOS0xMiAgQWxleGV5IFNodmF5 a2EgIDxzaHZhaWthbGVzaEBnbWFpbC5jb20+CisKKyAgICAgICAgRGF0ZS5wcm90b3R5cGUudG9K U09OIGRvZXMgbm90IGV4ZWN1dGUgc3RlcHMgMS0yCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJr aXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xMDUyODIKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JP RFkgKE9PUFMhKS4KKworICAgICAgICBSZXNvbHZlIGB0aGlzYCB2YWx1ZSB1c2luZyBzdHJpY3Qg bW9kZSBzZW1hbnRpY3MuCisKKyAgICAgICAgKiBydW50aW1lL0RhdGVQcm90b3R5cGUuY3BwOgor ICAgICAgICAoSlNDOjpkYXRlUHJvdG9GdW5jVG9KU09OKTogUmVtb3ZlIHRvVGhpcyBjYWxsIGFu ZCBzaW1wbGlmeSBzdGQ6OmlzZmluaXRlIGNoZWNrLgorCiAyMDE5LTA5LTEyICBNYXJrIExhbSAg PG1hcmsubGFtQGFwcGxlLmNvbT4KIAogICAgICAgICBIYXJkZW4gSlNDIGFnYWluc3QgdGhlIGFi dXNlIG9mIHJ1bnRpbWUgb3B0aW9ucy4KSW5kZXg6IFNvdXJjZS9KYXZhU2NyaXB0Q29yZS9ydW50 aW1lL0RhdGVQcm90b3R5cGUuY3BwCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFNvdXJjZS9KYXZhU2NyaXB0Q29y ZS9ydW50aW1lL0RhdGVQcm90b3R5cGUuY3BwCShyZXZpc2lvbiAyNDk4MTgpCisrKyBTb3VyY2Uv SmF2YVNjcmlwdENvcmUvcnVudGltZS9EYXRlUHJvdG90eXBlLmNwcAkod29ya2luZyBjb3B5KQpA QCAtMTE0OSwxMiArMTE0OSwxMiBAQCBFbmNvZGVkSlNWYWx1ZSBKU0NfSE9TVF9DQUxMIGRhdGVQ cm90b0Z1CiAgICAgVk0mIHZtID0gZXhlYy0+dm0oKTsKICAgICBhdXRvIHNjb3BlID0gREVDTEFS RV9USFJPV19TQ09QRSh2bSk7CiAgICAgSlNWYWx1ZSB0aGlzVmFsdWUgPSBleGVjLT50aGlzVmFs dWUoKTsKLSAgICBKU09iamVjdCogb2JqZWN0ID0ganNDYXN0PEpTT2JqZWN0Kj4odGhpc1ZhbHVl LnRvVGhpcyhleGVjLCBOb3RTdHJpY3RNb2RlKSk7CisgICAgSlNPYmplY3QqIG9iamVjdCA9IHRo aXNWYWx1ZS50b09iamVjdChleGVjKTsKICAgICBSRVRVUk5fSUZfRVhDRVBUSU9OKHNjb3BlLCBl bmNvZGVkSlNWYWx1ZSgpKTsKIAogICAgIEpTVmFsdWUgdGltZVZhbHVlID0gb2JqZWN0LT50b1By aW1pdGl2ZShleGVjLCBQcmVmZXJOdW1iZXIpOwogICAgIFJFVFVSTl9JRl9FWENFUFRJT04oc2Nv cGUsIGVuY29kZWRKU1ZhbHVlKCkpOwotICAgIGlmICh0aW1lVmFsdWUuaXNOdW1iZXIoKSAmJiAh KHRpbWVWYWx1ZS5pc0ludDMyKCkgfHwgc3RkOjppc2Zpbml0ZSh0aW1lVmFsdWUuYXNEb3VibGUo KSkpKQorICAgIGlmICh0aW1lVmFsdWUuaXNOdW1iZXIoKSAmJiAhc3RkOjppc2Zpbml0ZSh0aW1l VmFsdWUuYXNOdW1iZXIoKSkpCiAgICAgICAgIHJldHVybiBKU1ZhbHVlOjplbmNvZGUoanNOdWxs KCkpOwogCiAgICAgSlNWYWx1ZSB0b0lTT1ZhbHVlID0gb2JqZWN0LT5nZXQoZXhlYywgdm0ucHJv cGVydHlOYW1lcy0+dG9JU09TdHJpbmcpOwo= 378761 2019-09-13 16:38:37 -0700 2019-09-13 17:24:30 -0700 Patch bug-105282-20190914023835.patch text/plain 3535 ashvayka SW5kZXg6IEpTVGVzdHMvQ2hhbmdlTG9nCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIEpTVGVzdHMvQ2hhbmdlTG9n CShyZXZpc2lvbiAyNDk4MTgpCisrKyBKU1Rlc3RzL0NoYW5nZUxvZwkod29ya2luZyBjb3B5KQpA QCAtMSwzICsxLDEyIEBACisyMDE5LTA5LTEzICBBbGV4ZXkgU2h2YXlrYSAgPHNodmFpa2FsZXNo QGdtYWlsLmNvbT4KKworICAgICAgICBEYXRlLnByb3RvdHlwZS50b0pTT04gZG9lcyBub3QgZXhl Y3V0ZSBzdGVwcyAxLTIKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcu Y2dpP2lkPTEwNTI4MgorCisgICAgICAgIFJldmlld2VkIGJ5IFJvc3MgS2lyc2xpbmcuCisKKyAg ICAgICAgKiB0ZXN0MjYyL2V4cGVjdGF0aW9ucy55YW1sOiBNYXJrIDIgdGVzdCBjYXNlcyBhcyBw YXNzaW5nLgorCiAyMDE5LTA5LTEyICBNYXJrIExhbSAgPG1hcmsubGFtQGFwcGxlLmNvbT4KIAog ICAgICAgICBIYXJkZW4gSlNDIGFnYWluc3QgdGhlIGFidXNlIG9mIHJ1bnRpbWUgb3B0aW9ucy4K SW5kZXg6IEpTVGVzdHMvdGVzdDI2Mi9leHBlY3RhdGlvbnMueWFtbAo9PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBK U1Rlc3RzL3Rlc3QyNjIvZXhwZWN0YXRpb25zLnlhbWwJKHJldmlzaW9uIDI0OTgxOCkKKysrIEpT VGVzdHMvdGVzdDI2Mi9leHBlY3RhdGlvbnMueWFtbAkod29ya2luZyBjb3B5KQpAQCAtODU4LDkg Kzg1OCw2IEBAIHRlc3QvYnVpbHQtaW5zL0RhdGUvcHJvdG8tZnJvbS1jdG9yLXJlYWwKIHRlc3Qv YnVpbHQtaW5zL0RhdGUvcHJvdG8tZnJvbS1jdG9yLXJlYWxtLXplcm8uanM6CiAgIGRlZmF1bHQ6 ICdUeXBlRXJyb3I6IFR5cGUgZXJyb3InCiAgIHN0cmljdCBtb2RlOiAnVHlwZUVycm9yOiBUeXBl IGVycm9yJwotdGVzdC9idWlsdC1pbnMvRGF0ZS9wcm90b3R5cGUvdG9KU09OL3RvLW9iamVjdC5q czoKLSAgZGVmYXVsdDogJ1Rlc3QyNjJFcnJvcjogRXhwZWN0ZWQgYSBUeXBlRXJyb3IgdG8gYmUg dGhyb3duIGJ1dCBubyBleGNlcHRpb24gd2FzIHRocm93biBhdCBhbGwnCi0gIHN0cmljdCBtb2Rl OiAnVGVzdDI2MkVycm9yOiBFeHBlY3RlZCBhIFR5cGVFcnJvciB0byBiZSB0aHJvd24gYnV0IG5v IGV4Y2VwdGlvbiB3YXMgdGhyb3duIGF0IGFsbCcKIHRlc3QvYnVpbHQtaW5zL0Vycm9yL3Byb3Rv LWZyb20tY3Rvci1yZWFsbS5qczoKICAgZGVmYXVsdDogJ1Rlc3QyNjJFcnJvcjogRXhwZWN0ZWQg U2FtZVZhbHVlKMOCwqtFcnJvcsOCwrssIMOCwqtFcnJvcsOCwrspIHRvIGJlIHRydWUnCiAgIHN0 cmljdCBtb2RlOiAnVGVzdDI2MkVycm9yOiBFeHBlY3RlZCBTYW1lVmFsdWUow4LCq0Vycm9yw4LC uywgw4LCq0Vycm9yw4LCuykgdG8gYmUgdHJ1ZScKSW5kZXg6IFNvdXJjZS9KYXZhU2NyaXB0Q29y ZS9DaGFuZ2VMb2cKPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PQotLS0gU291cmNlL0phdmFTY3JpcHRDb3JlL0NoYW5nZUxv ZwkocmV2aXNpb24gMjQ5ODE4KQorKysgU291cmNlL0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwko d29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDE4IEBACisyMDE5LTA5LTEzICBBbGV4ZXkgU2h2YXlr YSAgPHNodmFpa2FsZXNoQGdtYWlsLmNvbT4KKworICAgICAgICBEYXRlLnByb3RvdHlwZS50b0pT T04gZG9lcyBub3QgZXhlY3V0ZSBzdGVwcyAxLTIKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtp dC5vcmcvc2hvd19idWcuY2dpP2lkPTEwNTI4MgorCisgICAgICAgIFJldmlld2VkIGJ5IFJvc3Mg S2lyc2xpbmcuCisKKyAgICAgICAgQWNjb3JkaW5nIHRvIGh0dHBzOi8vdGMzOS5lcy9lY21hMjYy LyNzZWMtYnVpbHQtaW4tZnVuY3Rpb24tb2JqZWN0cywgYnVpbHQtaW4gbWV0aG9kcyBtdXN0IGJl CisgICAgICAgIHN0cmljdCBtb2RlIGZ1bmN0aW9ucy4gQmVmb3JlIHRoaXMgY2hhbmdlLCBgdGhp c2AgdmFsdWUgaW4gRGF0ZS5wcm90b3R5cGUudG9KU09OIHdhcyByZXNvbHZlZAorICAgICAgICB1 c2luZyBzbG9wcHkgbW9kZSBzZW1hbnRpY3MsIHJlc3VsdGluZyBpbiBgdG9JU09TdHJpbmdgIGJl aW5nIGNhbGxlZCBvbiBnbG9iYWwgb2JqZWN0IGlmIGB0aGlzYAorICAgICAgICB2YWx1ZSBlcXVh bHMgYG51bGxgIG9yIGB1bmRlZmluZWRgLgorCisgICAgICAgICogcnVudGltZS9EYXRlUHJvdG90 eXBlLmNwcDoKKyAgICAgICAgKEpTQzo6ZGF0ZVByb3RvRnVuY1RvSlNPTik6IFJlc29sdmUgdGhp c1ZhbHVlIHVzaW5nIHN0cmljdCBzZW1hbnRpY3MgYW5kIHNpbXBsaWZ5IHN0ZDo6aXNmaW5pdGUg Y2hlY2suCisKIDIwMTktMDktMTIgIE1hcmsgTGFtICA8bWFyay5sYW1AYXBwbGUuY29tPgogCiAg ICAgICAgIEhhcmRlbiBKU0MgYWdhaW5zdCB0aGUgYWJ1c2Ugb2YgcnVudGltZSBvcHRpb25zLgpJ bmRleDogU291cmNlL0phdmFTY3JpcHRDb3JlL3J1bnRpbWUvRGF0ZVByb3RvdHlwZS5jcHAKPT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PQotLS0gU291cmNlL0phdmFTY3JpcHRDb3JlL3J1bnRpbWUvRGF0ZVByb3RvdHlwZS5j cHAJKHJldmlzaW9uIDI0OTgxOCkKKysrIFNvdXJjZS9KYXZhU2NyaXB0Q29yZS9ydW50aW1lL0Rh dGVQcm90b3R5cGUuY3BwCSh3b3JraW5nIGNvcHkpCkBAIC0xMTQ5LDEyICsxMTQ5LDEyIEBAIEVu Y29kZWRKU1ZhbHVlIEpTQ19IT1NUX0NBTEwgZGF0ZVByb3RvRnUKICAgICBWTSYgdm0gPSBleGVj LT52bSgpOwogICAgIGF1dG8gc2NvcGUgPSBERUNMQVJFX1RIUk9XX1NDT1BFKHZtKTsKICAgICBK U1ZhbHVlIHRoaXNWYWx1ZSA9IGV4ZWMtPnRoaXNWYWx1ZSgpOwotICAgIEpTT2JqZWN0KiBvYmpl Y3QgPSBqc0Nhc3Q8SlNPYmplY3QqPih0aGlzVmFsdWUudG9UaGlzKGV4ZWMsIE5vdFN0cmljdE1v ZGUpKTsKKyAgICBKU09iamVjdCogb2JqZWN0ID0gdGhpc1ZhbHVlLnRvT2JqZWN0KGV4ZWMpOwog ICAgIFJFVFVSTl9JRl9FWENFUFRJT04oc2NvcGUsIGVuY29kZWRKU1ZhbHVlKCkpOwogCiAgICAg SlNWYWx1ZSB0aW1lVmFsdWUgPSBvYmplY3QtPnRvUHJpbWl0aXZlKGV4ZWMsIFByZWZlck51bWJl cik7CiAgICAgUkVUVVJOX0lGX0VYQ0VQVElPTihzY29wZSwgZW5jb2RlZEpTVmFsdWUoKSk7Ci0g ICAgaWYgKHRpbWVWYWx1ZS5pc051bWJlcigpICYmICEodGltZVZhbHVlLmlzSW50MzIoKSB8fCBz dGQ6OmlzZmluaXRlKHRpbWVWYWx1ZS5hc0RvdWJsZSgpKSkpCisgICAgaWYgKHRpbWVWYWx1ZS5p c051bWJlcigpICYmICFzdGQ6OmlzZmluaXRlKHRpbWVWYWx1ZS5hc051bWJlcigpKSkKICAgICAg ICAgcmV0dXJuIEpTVmFsdWU6OmVuY29kZShqc051bGwoKSk7CiAKICAgICBKU1ZhbHVlIHRvSVNP VmFsdWUgPSBvYmplY3QtPmdldChleGVjLCB2bS5wcm9wZXJ0eU5hbWVzLT50b0lTT1N0cmluZyk7 Cg==