105087 2012-12-15 05:44:35 -0800 Some Math.pow test262 tests fail with MinGW-w64 2013-01-02 08:15:36 -0800 1 1 1 Unclassified WebKit JavaScriptCore 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 103747 0 net147 webkit-unassigned barraclough hausmann kai.koehne mhahnenberg sam webkit.review.bot oldest_to_newest 792093 0 net147 2012-12-15 05:44:35 -0800 The following test262 tests fail with the latest MinGW-w64 runtime: -S15.8.2.13_A14 Checking if Math.pow(x,y) equals to +Infinity, where x is -Infinity and y>0 -S15.8.2.13_A16 Checking if Math.pow(x,y) equals to +0, where x is -Infinity and y<0 -S15.8.2.13_A20 Checking if Math.pow(x,y) equals to +0, where x is -0 and y>0 and y is NOT an odd integer -S15.8.2.13_A22 Checking if Math.pow(x,y) equals to +Infinity, where x is -0 and y<0 and y is NOT an odd integer This is due to different behavior of pow() with the MinGW-w64 runtime compared with other C runtimes. I have already fixed this issue in Google V8 (http://code.google.com/p/v8/source/browse/trunk/src/assembler.cc?spec=svn13185&r=13185#1397). 792095 1 179590 net147 2012-12-15 05:51:21 -0800 Created attachment 179590 Patch 792097 2 webkit.review.bot 2012-12-15 05:53:40 -0800 Attachment 179590 did not pass style-queue: Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/JavaScriptCore/ChangeLog', u'Source..." exit_code: 1 Source/JavaScriptCore/runtime/MathObject.cpp:236: Should have only a single space after a punctuation in a comment. [whitespace/comments] [5] Source/JavaScriptCore/runtime/MathObject.cpp:245: y_int is incorrectly named. Don't use underscores in your identifier names. [readability/naming/underscores] [4] Source/JavaScriptCore/runtime/MathObject.cpp:246: More than one command on the same line in if [whitespace/parens] [4] Total errors found: 3 in 2 files If any of these errors are false positives, please file a bug against check-webkit-style. 792098 3 179592 net147 2012-12-15 05:55:44 -0800 Created attachment 179592 Patch 792099 4 webkit.review.bot 2012-12-15 05:58:02 -0800 Attachment 179592 did not pass style-queue: Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/JavaScriptCore/ChangeLog', u'Source..." exit_code: 1 Source/JavaScriptCore/runtime/MathObject.cpp:236: Should have only a single space after a punctuation in a comment. [whitespace/comments] [5] Source/JavaScriptCore/runtime/MathObject.cpp:246: More than one command on the same line in if [whitespace/parens] [4] Total errors found: 2 in 2 files If any of these errors are false positives, please file a bug against check-webkit-style. 792100 5 179593 net147 2012-12-15 06:00:05 -0800 Created attachment 179593 Patch 792563 6 179593 hausmann 2012-12-17 01:42:52 -0800 Comment on attachment 179593 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=179593&action=review > Source/JavaScriptCore/runtime/MathObject.cpp:235 > +#ifdef __MINGW64_VERSION_MAJOR I think this should be #if COMPILER(MINGW64) > Source/JavaScriptCore/runtime/MathObject.cpp:244 > + if ((x == 0.0 || isinf(x)) && isfinite(y)) { > + double f; > + if (modf(y, &f) != 0.0) > + return ((x == 0.0) ^ (y > 0.0)) ? std::numeric_limits<double>::infinity() : 0.0; > + } > + > + if (x == 2.0) { Isn't it dangerous to compare doubles to constants like that? Shouldn't it be done as a range comparison using a epsilon? 792579 7 179707 net147 2012-12-17 02:13:05 -0800 Created attachment 179707 Patch 792581 8 net147 2012-12-17 02:19:56 -0800 The special cases apply only to exact values so it is fine in my opinion. 792604 9 hausmann 2012-12-17 03:29:10 -0800 Upstream "discussion" about the behavioral difference: http://comments.gmane.org/gmane.comp.gnu.mingw.w64.general/4658 792610 10 179707 webkit.review.bot 2012-12-17 03:51:02 -0800 Comment on attachment 179707 Patch Clearing flags on attachment: 179707 Committed r137895: <http://trac.webkit.org/changeset/137895> 792611 11 webkit.review.bot 2012-12-17 03:51:07 -0800 All reviewed patches have been landed. Closing bug. 797740 12 sam 2012-12-27 20:35:54 -0800 I don't think this is the best way to do this. The preferred method is to add a function to MathExtras.h which implements pow correctly and call that, so that we don't litter the code with #ifdefs. 798189 13 net147 2012-12-29 18:58:51 -0800 (In reply to comment #12) > I don't think this is the best way to do this. The preferred method is to add a function to MathExtras.h which implements pow correctly and call that, so that we don't litter the code with #ifdefs. According to the bug life cycle, this bug is fixed. Feel free to commit such a change separately. 798672 14 hausmann 2013-01-02 08:15:36 -0800 I've filed bug #105925 to address Sam's (valid) comment. 179590 2012-12-15 05:51:21 -0800 2012-12-15 05:55:44 -0800 Patch bug-105087.patch text/plain 1858 net147 SW5kZXg6IFNvdXJjZS9KYXZhU2NyaXB0Q29yZS9DaGFuZ2VMb2cKPT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gU291 cmNlL0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwkocmV2aXNpb24gMTM3Nzk2KQorKysgU291cmNl L0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDIzIEBA CisyMDEyLTEyLTE1ICBKb25hdGhhbiBMaXUgIDxuZXQxNDdAZ21haWwuY29tPgorCisgICAgICAg IEZpeCBNYXRoLnBvdyBpbXBsZW1lbnRhdGlvbiB3aXRoIE1pbkdXLXc2NAorICAgICAgICBodHRw czovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTA1MDg3CisKKyAgICAgICAgUmV2 aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgVGhlIE1pbkdXLXc2NCBydW50aW1l IGhhcyBkaWZmZXJlbnQgYmVoYXZpb3VyIGZvciBwb3coKQorICAgICAgICBjb21wYXJlZCB0byBv dGhlciBDIHJ1bnRpbWVzLiBUaGlzIHJlc3VsdHMgaW4gdGhlIGZvbGxvd2luZworICAgICAgICB0 ZXN0MjYyIHRlc3RzIGZhaWxpbmcgd2l0aCB0aGUgbGF0ZXN0IE1pbkdXLXc2NCBydW50aW1lOgor ICAgICAgICAtIFMxNS44LjIuMTNfQTE0CisgICAgICAgIC0gUzE1LjguMi4xM19BMTYKKyAgICAg ICAgLSBTMTUuOC4yLjEzX0EyMAorICAgICAgICAtIFMxNS44LjIuMTNfQTIyCisKKyAgICAgICAg SGFuZGxlIHRoZSBzcGVjaWFsIGNhc2VzIHRoYXQgYXJlIGRpZmZlcmVudCB3aXRoIE1pbkdXLXc2 NC4KKworICAgICAgICAqIHJ1bnRpbWUvTWF0aE9iamVjdC5jcHA6CisgICAgICAgIChKU0M6Om1h dGhQb3cpOgorCiAyMDEyLTEyLTEzICBGaWxpcCBQaXpsbyAgPGZwaXpsb0BhcHBsZS5jb20+CiAK ICAgICAgICAgQXR0ZW1wdCB0byByYXRpb25hbGl6ZSBhbmQgc2ltcGxpZnkgV1RGOjpiaW5hcnlT ZWFyY2gKSW5kZXg6IFNvdXJjZS9KYXZhU2NyaXB0Q29yZS9ydW50aW1lL01hdGhPYmplY3QuY3Bw Cj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT0KLS0tIFNvdXJjZS9KYXZhU2NyaXB0Q29yZS9ydW50aW1lL01hdGhPYmplY3Qu Y3BwCShyZXZpc2lvbiAxMzc3OTYpCisrKyBTb3VyY2UvSmF2YVNjcmlwdENvcmUvcnVudGltZS9N YXRoT2JqZWN0LmNwcAkod29ya2luZyBjb3B5KQpAQCAtMjMyLDYgKzIzMiwyMSBAQCBzdGF0aWMg QUxXQVlTX0lOTElORSBkb3VibGUgbWF0aFBvdyhkb3ViCiAKIEFMV0FZU19JTkxJTkUgZG91Ymxl IG1hdGhQb3coZG91YmxlIHgsIGRvdWJsZSB5KQogeworI2lmZGVmIF9fTUlOR1c2NF9WRVJTSU9O X01BSk9SCisgICAgLy8gTWluR1ctdzY0IGhhcyBhIGN1c3RvbSBpbXBsZW1lbnRhdGlvbiBmb3Ig cG93LiAgVGhpcyBoYW5kbGVzIGNlcnRhaW4KKyAgICAvLyBzcGVjaWFsIGNhc2VzIHRoYXQgYXJl IGRpZmZlcmVudC4KKyAgICBpZiAoKHggPT0gMC4wIHx8IGlzaW5mKHgpKSAmJiBpc2Zpbml0ZSh5 KSkgeworICAgICAgICBkb3VibGUgZjsKKyAgICAgICAgaWYgKG1vZGYoeSwgJmYpICE9IDAuMCkK KyAgICAgICAgICAgIHJldHVybiAoKHggPT0gMC4wKSBeICh5ID4gMC4wKSkgPyBzdGQ6Om51bWVy aWNfbGltaXRzPGRvdWJsZT46OmluZmluaXR5KCkgOiAwLjA7CisgICAgfQorCisgICAgaWYgKHgg PT0gMi4wKSB7CisgICAgICAgIGludCB5X2ludCA9IHN0YXRpY19jYXN0PGludD4oeSk7CisgICAg ICAgIGlmICh5ID09IHlfaW50KSByZXR1cm4gbGRleHAoMS4wLCB5X2ludCk7CisgICAgfQorI2Vu ZGlmCisKICAgICByZXR1cm4gcG93KHgsIHkpOwogfQogCg== 179592 2012-12-15 05:55:44 -0800 2012-12-15 06:00:05 -0800 Patch bug-105087.patch text/plain 1855 net147 SW5kZXg6IFNvdXJjZS9KYXZhU2NyaXB0Q29yZS9DaGFuZ2VMb2cKPT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gU291 cmNlL0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwkocmV2aXNpb24gMTM3Nzk2KQorKysgU291cmNl L0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDIzIEBA CisyMDEyLTEyLTE1ICBKb25hdGhhbiBMaXUgIDxuZXQxNDdAZ21haWwuY29tPgorCisgICAgICAg IEZpeCBNYXRoLnBvdyBpbXBsZW1lbnRhdGlvbiB3aXRoIE1pbkdXLXc2NAorICAgICAgICBodHRw czovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTA1MDg3CisKKyAgICAgICAgUmV2 aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgVGhlIE1pbkdXLXc2NCBydW50aW1l IGhhcyBkaWZmZXJlbnQgYmVoYXZpb3VyIGZvciBwb3coKQorICAgICAgICBjb21wYXJlZCB0byBv dGhlciBDIHJ1bnRpbWVzLiBUaGlzIHJlc3VsdHMgaW4gdGhlIGZvbGxvd2luZworICAgICAgICB0 ZXN0MjYyIHRlc3RzIGZhaWxpbmcgd2l0aCB0aGUgbGF0ZXN0IE1pbkdXLXc2NCBydW50aW1lOgor ICAgICAgICAtIFMxNS44LjIuMTNfQTE0CisgICAgICAgIC0gUzE1LjguMi4xM19BMTYKKyAgICAg ICAgLSBTMTUuOC4yLjEzX0EyMAorICAgICAgICAtIFMxNS44LjIuMTNfQTIyCisKKyAgICAgICAg SGFuZGxlIHRoZSBzcGVjaWFsIGNhc2VzIHRoYXQgYXJlIGRpZmZlcmVudCB3aXRoIE1pbkdXLXc2 NC4KKworICAgICAgICAqIHJ1bnRpbWUvTWF0aE9iamVjdC5jcHA6CisgICAgICAgIChKU0M6Om1h dGhQb3cpOgorCiAyMDEyLTEyLTEzICBGaWxpcCBQaXpsbyAgPGZwaXpsb0BhcHBsZS5jb20+CiAK ICAgICAgICAgQXR0ZW1wdCB0byByYXRpb25hbGl6ZSBhbmQgc2ltcGxpZnkgV1RGOjpiaW5hcnlT ZWFyY2gKSW5kZXg6IFNvdXJjZS9KYXZhU2NyaXB0Q29yZS9ydW50aW1lL01hdGhPYmplY3QuY3Bw Cj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT0KLS0tIFNvdXJjZS9KYXZhU2NyaXB0Q29yZS9ydW50aW1lL01hdGhPYmplY3Qu Y3BwCShyZXZpc2lvbiAxMzc3OTYpCisrKyBTb3VyY2UvSmF2YVNjcmlwdENvcmUvcnVudGltZS9N YXRoT2JqZWN0LmNwcAkod29ya2luZyBjb3B5KQpAQCAtMjMyLDYgKzIzMiwyMSBAQCBzdGF0aWMg QUxXQVlTX0lOTElORSBkb3VibGUgbWF0aFBvdyhkb3ViCiAKIEFMV0FZU19JTkxJTkUgZG91Ymxl IG1hdGhQb3coZG91YmxlIHgsIGRvdWJsZSB5KQogeworI2lmZGVmIF9fTUlOR1c2NF9WRVJTSU9O X01BSk9SCisgICAgLy8gTWluR1ctdzY0IGhhcyBhIGN1c3RvbSBpbXBsZW1lbnRhdGlvbiBmb3Ig cG93LiAgVGhpcyBoYW5kbGVzIGNlcnRhaW4KKyAgICAvLyBzcGVjaWFsIGNhc2VzIHRoYXQgYXJl IGRpZmZlcmVudC4KKyAgICBpZiAoKHggPT0gMC4wIHx8IGlzaW5mKHgpKSAmJiBpc2Zpbml0ZSh5 KSkgeworICAgICAgICBkb3VibGUgZjsKKyAgICAgICAgaWYgKG1vZGYoeSwgJmYpICE9IDAuMCkK KyAgICAgICAgICAgIHJldHVybiAoKHggPT0gMC4wKSBeICh5ID4gMC4wKSkgPyBzdGQ6Om51bWVy aWNfbGltaXRzPGRvdWJsZT46OmluZmluaXR5KCkgOiAwLjA7CisgICAgfQorCisgICAgaWYgKHgg PT0gMi4wKSB7CisgICAgICAgIGludCB5SW50ID0gc3RhdGljX2Nhc3Q8aW50Pih5KTsKKyAgICAg ICAgaWYgKHkgPT0geUludCkgcmV0dXJuIGxkZXhwKDEuMCwgeUludCk7CisgICAgfQorI2VuZGlm CisKICAgICByZXR1cm4gcG93KHgsIHkpOwogfQogCg== 179593 2012-12-15 06:00:05 -0800 2012-12-17 02:13:05 -0800 Patch bug-105087.patch text/plain 1867 net147 SW5kZXg6IFNvdXJjZS9KYXZhU2NyaXB0Q29yZS9DaGFuZ2VMb2cKPT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gU291 cmNlL0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwkocmV2aXNpb24gMTM3Nzk2KQorKysgU291cmNl L0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDIzIEBA CisyMDEyLTEyLTE1ICBKb25hdGhhbiBMaXUgIDxuZXQxNDdAZ21haWwuY29tPgorCisgICAgICAg IEZpeCBNYXRoLnBvdyBpbXBsZW1lbnRhdGlvbiB3aXRoIE1pbkdXLXc2NAorICAgICAgICBodHRw czovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTA1MDg3CisKKyAgICAgICAgUmV2 aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgVGhlIE1pbkdXLXc2NCBydW50aW1l IGhhcyBkaWZmZXJlbnQgYmVoYXZpb3VyIGZvciBwb3coKQorICAgICAgICBjb21wYXJlZCB0byBv dGhlciBDIHJ1bnRpbWVzLiBUaGlzIHJlc3VsdHMgaW4gdGhlIGZvbGxvd2luZworICAgICAgICB0 ZXN0MjYyIHRlc3RzIGZhaWxpbmcgd2l0aCB0aGUgbGF0ZXN0IE1pbkdXLXc2NCBydW50aW1lOgor ICAgICAgICAtIFMxNS44LjIuMTNfQTE0CisgICAgICAgIC0gUzE1LjguMi4xM19BMTYKKyAgICAg ICAgLSBTMTUuOC4yLjEzX0EyMAorICAgICAgICAtIFMxNS44LjIuMTNfQTIyCisKKyAgICAgICAg SGFuZGxlIHRoZSBzcGVjaWFsIGNhc2VzIHRoYXQgYXJlIGRpZmZlcmVudCB3aXRoIE1pbkdXLXc2 NC4KKworICAgICAgICAqIHJ1bnRpbWUvTWF0aE9iamVjdC5jcHA6CisgICAgICAgIChKU0M6Om1h dGhQb3cpOgorCiAyMDEyLTEyLTEzICBGaWxpcCBQaXpsbyAgPGZwaXpsb0BhcHBsZS5jb20+CiAK ICAgICAgICAgQXR0ZW1wdCB0byByYXRpb25hbGl6ZSBhbmQgc2ltcGxpZnkgV1RGOjpiaW5hcnlT ZWFyY2gKSW5kZXg6IFNvdXJjZS9KYXZhU2NyaXB0Q29yZS9ydW50aW1lL01hdGhPYmplY3QuY3Bw Cj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT0KLS0tIFNvdXJjZS9KYXZhU2NyaXB0Q29yZS9ydW50aW1lL01hdGhPYmplY3Qu Y3BwCShyZXZpc2lvbiAxMzc3OTYpCisrKyBTb3VyY2UvSmF2YVNjcmlwdENvcmUvcnVudGltZS9N YXRoT2JqZWN0LmNwcAkod29ya2luZyBjb3B5KQpAQCAtMjMyLDYgKzIzMiwyMiBAQCBzdGF0aWMg QUxXQVlTX0lOTElORSBkb3VibGUgbWF0aFBvdyhkb3ViCiAKIEFMV0FZU19JTkxJTkUgZG91Ymxl IG1hdGhQb3coZG91YmxlIHgsIGRvdWJsZSB5KQogeworI2lmZGVmIF9fTUlOR1c2NF9WRVJTSU9O X01BSk9SCisgICAgLy8gTWluR1ctdzY0IGhhcyBhIGN1c3RvbSBpbXBsZW1lbnRhdGlvbiBmb3Ig cG93LgorICAgIC8vIFRoaXMgaGFuZGxlcyBjZXJ0YWluIHNwZWNpYWwgY2FzZXMgdGhhdCBhcmUg ZGlmZmVyZW50LgorICAgIGlmICgoeCA9PSAwLjAgfHwgaXNpbmYoeCkpICYmIGlzZmluaXRlKHkp KSB7CisgICAgICAgIGRvdWJsZSBmOworICAgICAgICBpZiAobW9kZih5LCAmZikgIT0gMC4wKQor ICAgICAgICAgICAgcmV0dXJuICgoeCA9PSAwLjApIF4gKHkgPiAwLjApKSA/IHN0ZDo6bnVtZXJp Y19saW1pdHM8ZG91YmxlPjo6aW5maW5pdHkoKSA6IDAuMDsKKyAgICB9CisKKyAgICBpZiAoeCA9 PSAyLjApIHsKKyAgICAgICAgaW50IHlJbnQgPSBzdGF0aWNfY2FzdDxpbnQ+KHkpOworICAgICAg ICBpZiAoeSA9PSB5SW50KQorICAgICAgICAgICAgcmV0dXJuIGxkZXhwKDEuMCwgeUludCk7Cisg ICAgfQorI2VuZGlmCisKICAgICByZXR1cm4gcG93KHgsIHkpOwogfQogCg== 179707 2012-12-17 02:13:05 -0800 2012-12-17 03:51:02 -0800 Patch bug-105087.patch text/plain 1852 net147 SW5kZXg6IFNvdXJjZS9KYXZhU2NyaXB0Q29yZS9DaGFuZ2VMb2cKPT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gU291 cmNlL0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwkocmV2aXNpb24gMTM3ODg2KQorKysgU291cmNl L0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDIzIEBA CisyMDEyLTEyLTE3ICBKb25hdGhhbiBMaXUgIDxuZXQxNDdAZ21haWwuY29tPgorCisgICAgICAg IEZpeCBNYXRoLnBvdyBpbXBsZW1lbnRhdGlvbiB3aXRoIE1pbkdXLXc2NAorICAgICAgICBodHRw czovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTA1MDg3CisKKyAgICAgICAgUmV2 aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgVGhlIE1pbkdXLXc2NCBydW50aW1l IGhhcyBkaWZmZXJlbnQgYmVoYXZpb3VyIGZvciBwb3coKQorICAgICAgICBjb21wYXJlZCB0byBv dGhlciBDIHJ1bnRpbWVzLiBUaGlzIHJlc3VsdHMgaW4gdGhlIGZvbGxvd2luZworICAgICAgICB0 ZXN0MjYyIHRlc3RzIGZhaWxpbmcgd2l0aCB0aGUgbGF0ZXN0IE1pbkdXLXc2NCBydW50aW1lOgor ICAgICAgICAtIFMxNS44LjIuMTNfQTE0CisgICAgICAgIC0gUzE1LjguMi4xM19BMTYKKyAgICAg ICAgLSBTMTUuOC4yLjEzX0EyMAorICAgICAgICAtIFMxNS44LjIuMTNfQTIyCisKKyAgICAgICAg SGFuZGxlIHRoZSBzcGVjaWFsIGNhc2VzIHRoYXQgYXJlIGRpZmZlcmVudCB3aXRoIE1pbkdXLXc2 NC4KKworICAgICAgICAqIHJ1bnRpbWUvTWF0aE9iamVjdC5jcHA6CisgICAgICAgIChKU0M6Om1h dGhQb3cpOgorCiAyMDEyLTEyLTE2ICBGaWxpcCBQaXpsbyAgPGZwaXpsb0BhcHBsZS5jb20+CiAK ICAgICAgICAgQnl0ZWNvZGUgZHVtcGluZyBzaG91bGQgc2hvdyByYXJlIGNhc2UgcHJvZmlsZXMK SW5kZXg6IFNvdXJjZS9KYXZhU2NyaXB0Q29yZS9ydW50aW1lL01hdGhPYmplY3QuY3BwCj09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT0KLS0tIFNvdXJjZS9KYXZhU2NyaXB0Q29yZS9ydW50aW1lL01hdGhPYmplY3QuY3BwCShy ZXZpc2lvbiAxMzc4ODYpCisrKyBTb3VyY2UvSmF2YVNjcmlwdENvcmUvcnVudGltZS9NYXRoT2Jq ZWN0LmNwcAkod29ya2luZyBjb3B5KQpAQCAtMjMyLDYgKzIzMiwyMiBAQCBzdGF0aWMgQUxXQVlT X0lOTElORSBkb3VibGUgbWF0aFBvdyhkb3ViCiAKIEFMV0FZU19JTkxJTkUgZG91YmxlIG1hdGhQ b3coZG91YmxlIHgsIGRvdWJsZSB5KQogeworI2lmIENPTVBJTEVSKE1JTkdXNjQpCisgICAgLy8g TWluR1ctdzY0IGhhcyBhIGN1c3RvbSBpbXBsZW1lbnRhdGlvbiBmb3IgcG93LgorICAgIC8vIFRo aXMgaGFuZGxlcyBjZXJ0YWluIHNwZWNpYWwgY2FzZXMgdGhhdCBhcmUgZGlmZmVyZW50LgorICAg IGlmICgoeCA9PSAwLjAgfHwgaXNpbmYoeCkpICYmIGlzZmluaXRlKHkpKSB7CisgICAgICAgIGRv dWJsZSBmOworICAgICAgICBpZiAobW9kZih5LCAmZikgIT0gMC4wKQorICAgICAgICAgICAgcmV0 dXJuICgoeCA9PSAwLjApIF4gKHkgPiAwLjApKSA/IHN0ZDo6bnVtZXJpY19saW1pdHM8ZG91Ymxl Pjo6aW5maW5pdHkoKSA6IDAuMDsKKyAgICB9CisKKyAgICBpZiAoeCA9PSAyLjApIHsKKyAgICAg ICAgaW50IHlJbnQgPSBzdGF0aWNfY2FzdDxpbnQ+KHkpOworICAgICAgICBpZiAoeSA9PSB5SW50 KQorICAgICAgICAgICAgcmV0dXJuIGxkZXhwKDEuMCwgeUludCk7CisgICAgfQorI2VuZGlmCisK ICAgICByZXR1cm4gcG93KHgsIHkpOwogfQogCg==