105044 2012-12-14 11:55:47 -0800 REGRESSION (r137607): Cannot download files, stuck in “Preparing to download” 2012-12-18 05:06:02 -0800 1 1 1 Unclassified WebKit Page Loading 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 ap japhet andersca beidson cdumez japhet naginenis svetloslav svillar tmpsantos webkit.review.bot oldest_to_newest 791738 0 ap 2012-12-14 11:55:47 -0800 Downloads no longer work in Safari, and probably in other WebKit based browsers too. Steps to reproduce: go to nightlies.webkit.org, click on a link to download a nightly. <rdar://problem/12239483> 791740 1 ap 2012-12-14 11:57:25 -0800 What happens here is that we are getting a ResourceHandle::cancel() call now. Anders is going to address this symptom by making ResourceHandle::cancel() a no-op once download has been started, but the change in ResourceLoader behavior is unexpected, and possibly wrong. 791771 2 andersca 2012-12-14 12:34:28 -0800 *** Bug 105050 has been marked as a duplicate of this bug. *** 791772 3 179515 andersca 2012-12-14 12:35:49 -0800 Created attachment 179515 Patch 791775 4 179515 ap 2012-12-14 12:43:59 -0800 Comment on attachment 179515 Patch Please keep the bug open for Nate to investigate. 791778 5 ap 2012-12-14 12:46:06 -0800 *** Bug 105033 has been marked as a duplicate of this bug. *** 791781 6 andersca 2012-12-14 12:50:07 -0800 Committed r137763: <http://trac.webkit.org/changeset/137763> 792676 7 tmpsantos 2012-12-17 06:19:57 -0800 (In reply to comment #6) > Committed r137763: <http://trac.webkit.org/changeset/137763> Do you have a webkit-wise fix for this? I'm having the same issue on EFL since r137607. 792747 8 179748 japhet 2012-12-17 08:34:00 -0800 Created attachment 179748 Fix the regression It appears that in r137607 we call DocumentLoader::mainReceivedError(), which now calls MainResourceLoader::cancel(), which cancels the CachedResource load, which cancels the ResourceLoader, which cancels the ResourceHandle. Calling directly into ResourceLoader::didFail() instead is a bit of a layering violation, but it emulates the old behavior quite well. Strictly speaking, it isn't necessary to make downloads work, but if we don't, the loader objects (ResourceLoader, CachedResource, MainResourceLoader) will be left alive but useless until the associated DocumentLoader is detached. 793455 9 svillar 2012-12-18 01:30:44 -0800 (In reply to comment #8) > Created an attachment (id=179748) [details] > Fix the regression > > It appears that in r137607 we call DocumentLoader::mainReceivedError(), which now calls MainResourceLoader::cancel(), which cancels the CachedResource load, which cancels the ResourceLoader, which cancels the ResourceHandle. > > Calling directly into ResourceLoader::didFail() instead is a bit of a layering violation, but it emulates the old behavior quite well. Strictly speaking, it isn't necessary to make downloads work, but if we don't, the loader objects (ResourceLoader, CachedResource, MainResourceLoader) will be left alive but useless until the associated DocumentLoader is detached. LGTM, BTW doesn't this regression mean that we lack some test? 793563 10 179748 webkit.review.bot 2012-12-18 05:05:56 -0800 Comment on attachment 179748 Fix the regression Clearing flags on attachment: 179748 Committed r138012: <http://trac.webkit.org/changeset/138012> 793564 11 webkit.review.bot 2012-12-18 05:06:02 -0800 All reviewed patches have been landed. Closing bug. 179515 2012-12-14 12:35:49 -0800 2012-12-17 08:34:00 -0800 Patch bug-105044-20121214123308.patch text/plain 1933 andersca U3VidmVyc2lvbiBSZXZpc2lvbjogMTM3NzU2CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggODRjZDdkYjk2NTk1MTMz NDEzNDViYmJjZThhMDNhNzk5ZjE1OTQ4Yy4uZTcxMGM4ZGRhMzVhNWIyZWFlYmU2MTYxMzc4ZTI3 YzBiZTBhMDg4OSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE2IEBACisyMDEyLTEyLTE0ICBBbmRl cnMgQ2FybHNzb24gIDxhbmRlcnNjYUBhcHBsZS5jb20+CisKKyAgICAgICAgUkVHUkVTU0lPTiAo cjEzNzYwNyk6IENhbm5vdCBkb3dubG9hZCBmaWxlcywgc3R1Y2sgaW4gIlByZXBhcmluZyB0byBk b3dubG9hZCIKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lk PTEwNTA0NAorICAgICAgICA8cmRhcjovL3Byb2JsZW0vMTI4Nzk2NTc+CisKKyAgICAgICAgUmV2 aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgTWFrZSBSZXNvdXJjZUhhbmRsZTo6 Y2FuY2VsIHJldHVybiBlYXJseSBpZiB0aGUgaGFuZGxlIGhhcyBiZWVuIGNvbnZlcnRlZCB0byBh IGRvd25sb2FkLgorCisgICAgICAgICogcGxhdGZvcm0vbmV0d29yay9tYWMvUmVzb3VyY2VIYW5k bGVNYWMubW06CisgICAgICAgIChXZWJDb3JlOjpSZXNvdXJjZUhhbmRsZTo6Y2FuY2VsKToKKwog MjAxMi0xMi0xNCAgTWljaGVsYW5nZWxvIERlIFNpbW9uZSAgPG1pY2hlbGFuZ2Vsb0B3ZWJraXQu b3JnPgogCiAgICAgICAgIFtDU1MgU2hhZGVyc10gUmVtb3ZlIGNvZGUgZm9yIHRoZSBvdGhlciBt ZXNoIGJveCB0eXBlcyAoYm9yZGVyLWJveCB8IHBhZGRpbmctYm94IHwgY29udGVudC1ib3gpCmRp ZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9uZXR3b3JrL21hYy9SZXNvdXJjZUhh bmRsZU1hYy5tbSBiL1NvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL25ldHdvcmsvbWFjL1Jlc291cmNl SGFuZGxlTWFjLm1tCmluZGV4IDQzMmRkYTAxZDRmMDBiYTNmYzU5MWNhYjdjNjg1OGNmNDI0YzJi NDIuLjE5ZTRjODViYjAxMTY5NDQ3N2UwY2ZkYjU2OGViMjFkMmNkNDU5ZWEgMTAwNjQ0Ci0tLSBh L1NvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL25ldHdvcmsvbWFjL1Jlc291cmNlSGFuZGxlTWFjLm1t CisrKyBiL1NvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL25ldHdvcmsvbWFjL1Jlc291cmNlSGFuZGxl TWFjLm1tCkBAIC0yODgsNiArMjg4LDEyIEBAIHZvaWQgUmVzb3VyY2VIYW5kbGU6OmNhbmNlbCgp CiB7CiAgICAgTE9HKE5ldHdvcmssICJIYW5kbGUgJXAgY2FuY2VsIGNvbm5lY3Rpb24gJXAiLCB0 aGlzLCBkLT5tX2Nvbm5lY3Rpb24uZ2V0KCkpOwogCisgICAgaWYgKCFkLT5tX3Byb3h5KSB7Cisg ICAgICAgIC8vIElmIHRoZSBwcm94eSBpcyBudWxsLCB0aGUgY29ubmVjdGlvbiBoYXMgYmVlbiBo YW5kZWQgb2ZmIHRvIE5TVVJMRG93bmxvYWQsIHNvIFJlc291cmNlSGFuZGxlIHNob3VsZCBub3Qg Y2FuY2VsIGl0LgorICAgICAgICAvLyBGSVhNRTogV2Ugc2hvdWxkIGRvIHdoYXQgd2UgZG8gaW4g dGhlIENGTmV0d29yayBwb3J0IGFuZCBudWxsIG91dCB0aGUgTlNVUkxDb25uZWN0aW9uIG9iamVj dCBpbnN0ZWFkLgorICAgICAgICByZXR1cm47CisgICAgfQorCiAgICAgLy8gTGVha3Mgd2VyZSBz ZWVuIG9uIEhUVFAgdGVzdHMgd2l0aG91dCB0aGlzOyBjYW4gYmUgcmVtb3ZlZCBvbmNlIDxyZGFy Oi8vcHJvYmxlbS82ODg2OTM3PiBpcyBmaXhlZC4KICAgICBpZiAoZC0+bV9jdXJyZW50TWFjQ2hh bGxlbmdlKQogICAgICAgICBbW2QtPm1fY3VycmVudE1hY0NoYWxsZW5nZSBzZW5kZXJdIGNhbmNl bEF1dGhlbnRpY2F0aW9uQ2hhbGxlbmdlOmQtPm1fY3VycmVudE1hY0NoYWxsZW5nZV07Cg== 179748 2012-12-17 08:34:00 -0800 2012-12-18 05:05:56 -0800 Fix the regression download.txt text/plain 2767 japhet SW5kZXg6IFNvdXJjZS9XZWJDb3JlL2xvYWRlci9NYWluUmVzb3VyY2VMb2FkZXIuY3BwCj09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT0KLS0tIFNvdXJjZS9XZWJDb3JlL2xvYWRlci9NYWluUmVzb3VyY2VMb2FkZXIuY3BwCShy ZXZpc2lvbiAxMzc5MDgpCisrKyBTb3VyY2UvV2ViQ29yZS9sb2FkZXIvTWFpblJlc291cmNlTG9h ZGVyLmNwcAkod29ya2luZyBjb3B5KQpAQCAtMzE5LDggKzMxOSw4IEBACiAgICAgICAgIGZyYW1l TG9hZGVyKCktPmNsaWVudCgpLT5jb252ZXJ0TWFpblJlc291cmNlTG9hZFRvRG93bmxvYWQodGhp cywgcmVxdWVzdCwgcik7CiAKICAgICAgICAgLy8gSXQgbWlnaHQgaGF2ZSBnb25lIG1pc3NpbmcK LSAgICAgICAgaWYgKGZyYW1lTG9hZGVyKCkpCi0gICAgICAgICAgICByZWNlaXZlZEVycm9yKGlu dGVycnVwdGVkRm9yUG9saWN5Q2hhbmdlRXJyb3IoKSk7CisgICAgICAgIGlmIChsb2FkZXIoKSkK KyAgICAgICAgICAgIGxvYWRlcigpLT5kaWRGYWlsKGludGVycnVwdGVkRm9yUG9saWN5Q2hhbmdl RXJyb3IoKSk7CiAgICAgICAgIHJldHVybjsKICAgICB9CiAgICAgY2FzZSBQb2xpY3lJZ25vcmU6 CkluZGV4OiBTb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9uZXR3b3JrL21hYy9SZXNvdXJjZUhhbmRs ZU1hYy5tbQo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9uZXR3b3JrL21h Yy9SZXNvdXJjZUhhbmRsZU1hYy5tbQkocmV2aXNpb24gMTM3OTA4KQorKysgU291cmNlL1dlYkNv cmUvcGxhdGZvcm0vbmV0d29yay9tYWMvUmVzb3VyY2VIYW5kbGVNYWMubW0JKHdvcmtpbmcgY29w eSkKQEAgLTI4OCwxMiArMjg4LDYgQEAKIHsKICAgICBMT0coTmV0d29yaywgIkhhbmRsZSAlcCBj YW5jZWwgY29ubmVjdGlvbiAlcCIsIHRoaXMsIGQtPm1fY29ubmVjdGlvbi5nZXQoKSk7CiAKLSAg ICBpZiAoIWQtPm1fcHJveHkpIHsKLSAgICAgICAgLy8gSWYgdGhlIHByb3h5IGlzIG51bGwsIHRo ZSBjb25uZWN0aW9uIGhhcyBiZWVuIGhhbmRlZCBvZmYgdG8gTlNVUkxEb3dubG9hZCwgc28gUmVz b3VyY2VIYW5kbGUgc2hvdWxkIG5vdCBjYW5jZWwgaXQuCi0gICAgICAgIC8vIEZJWE1FOiBXZSBz aG91bGQgZG8gd2hhdCB3ZSBkbyBpbiB0aGUgQ0ZOZXR3b3JrIHBvcnQgYW5kIG51bGwgb3V0IHRo ZSBOU1VSTENvbm5lY3Rpb24gb2JqZWN0IGluc3RlYWQuCi0gICAgICAgIHJldHVybjsKLSAgICB9 Ci0KICAgICAvLyBMZWFrcyB3ZXJlIHNlZW4gb24gSFRUUCB0ZXN0cyB3aXRob3V0IHRoaXM7IGNh biBiZSByZW1vdmVkIG9uY2UgPHJkYXI6Ly9wcm9ibGVtLzY4ODY5Mzc+IGlzIGZpeGVkLgogICAg IGlmIChkLT5tX2N1cnJlbnRNYWNDaGFsbGVuZ2UpCiAgICAgICAgIFtbZC0+bV9jdXJyZW50TWFj Q2hhbGxlbmdlIHNlbmRlcl0gY2FuY2VsQXV0aGVudGljYXRpb25DaGFsbGVuZ2U6ZC0+bV9jdXJy ZW50TWFjQ2hhbGxlbmdlXTsKSW5kZXg6IFNvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZwo9PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09Ci0tLSBTb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cJKHJldmlzaW9uIDEzNzkwOSkKKysrIFNv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDIzIEBACisy MDEyLTEyLTE3ICBOYXRlIENoYXBpbiAgPGphcGhldEBjaHJvbWl1bS5vcmc+CisKKyAgICAgICAg UkVHUkVTU0lPTiAocjEzNzYwNyk6IENhbm5vdCBkb3dubG9hZCBmaWxlcywgc3R1Y2sgaW4g4oCc UHJlcGFyaW5nIHRvIGRvd25sb2Fk4oCdCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3Jn L3Nob3dfYnVnLmNnaT9pZD0xMDUwNDQKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9P UFMhKS4KKworICAgICAgICBUaGUgd29yayBkb25lIGJ5IERvY3VtZW50TG9hZGVyOjptYWluUmVj ZWl2ZWRFcnJvcigpIGNoYW5nZWQgc3VidGx5IGluIHIxMzc2MDcsCisgICAgICAgIHN1Y2ggdGhh dCBpdCBjYW5jZWxzIHRoZSBSZXNvdXJjZUhhbmRsZS4gV2Ugd2FudCB0byB0cmVhdCBzd2l0Y2hp bmcgdG8gYSBkb3dubG9hZAorICAgICAgICBsaWtlIGEgZmFpbHVyZSwgd2hlcmUgV2ViQ29yZSBh c3N1bWVzIHRoYXQgdGhlIGxvYWQgaXMgZmluaXNoZWQsIGFuZCBubworICAgICAgICBjYW5jZWxs YXRpb24gaXMgcmVxdWlyZWQuCisKKyAgICAgICAgTm8gbmV3IHRlc3RzLCB0ZXN0ZWQgbWFudWFs bHkgYnkgdmVyaWZ5aW5nIHRoYXQgZG93bmxvYWRpbmcgZmlsZXMgd29ya3MgaW4KKyAgICAgICAg U2FmYXJpIE1hYy4KKworICAgICAgICAqIGxvYWRlci9NYWluUmVzb3VyY2VMb2FkZXIuY3BwOgor ICAgICAgICAoV2ViQ29yZTo6TWFpblJlc291cmNlTG9hZGVyOjpjb250aW51ZUFmdGVyQ29udGVu dFBvbGljeSk6CisgICAgICAgICogcGxhdGZvcm0vbmV0d29yay9tYWMvUmVzb3VyY2VIYW5kbGVN YWMubW06CisgICAgICAgIChXZWJDb3JlOjpSZXNvdXJjZUhhbmRsZTo6Y2FuY2VsKTogUmVtb3Zl IHRoZSB3b3JrYXJvdW5kIGFkZGVkIGluIHIxMzc3NjMuCisKIDIwMTItMTItMTcgIEFuZHJlYXMg S2xpbmcgIDxha2xpbmdAYXBwbGUuY29tPgogCiAgICAgICAgIEF0dHJpYnV0ZTogUmVtb3ZlIHVu dXNlZCBjb25zdHJ1Y3RvciBhbmQgaXNOdWxsKCkuCg==