104787 2012-12-12 02:33:03 -0800 [EFL][GTK] spelling-unified-emulation.html fails - word "zzz" cannot be found by enchant 2013-01-11 06:59:39 -0800 1 1 1 Unclassified WebKit Tools / Tests 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 104528 1 g.czajkowski g.czajkowski mario morrita mrobinson shinyak tony webkit.review.bot oldest_to_newest 789379 0 g.czajkowski 2012-12-12 02:33:03 -0800 Hi, There is another test which fails for both EFL and GTK+ WebKit ports. This est has been added in bug 70299, it allows legacy text check emulation in unified text check interface. It fails due to word "zzz" which cannot be found by enchant library, checked for en_US dictionary, see result of command: echo "zzz" | enchant -l Can we replace the problematic sound of snoring with a different phrase? That change will allow to test unified text checking by EFL and GTK+ WebKit ports. I will upload patch as soon as I get your opinions. Thanks 789496 1 mario 2012-12-12 06:29:05 -0800 (In reply to comment #0) > Hi, > > There is another test which fails for both EFL and GTK+ WebKit ports. > This est has been added in bug 70299, it allows legacy text check emulation in unified text check interface. > > It fails due to word "zzz" which cannot be found by enchant library, checked for en_US dictionary, see result of command: echo "zzz" | enchant -l > Can we replace the problematic sound of snoring with a different phrase? That change will allow to test unified text checking by EFL and GTK+ WebKit ports. I'm not 100% sure about how they used this 'zzz' string but I guess it could be to test the following situation: "a test case containing a valid word which contains a bad word as a substring" ...assuming that 'zz' is expected to be invalid while 'zzz' should be valid. If that's the case, and after checking that indeed 'zzz' is not considered valid by enchant with a en_US dictionary, I think there shouldn't be any big issue in changing that string with something different. Perhaps the words 'buzz' or 'buzzer' might be valid in case we don't want to change the 'zz' lines. > I will upload patch as soon as I get your opinions. I think it doesn't hurts to change this as long as the same kind of situations keep being tested 789516 2 g.czajkowski 2012-12-12 07:27:02 -0800 (In reply to comment #1) > (In reply to comment #0) > > Hi, > > > > There is another test which fails for both EFL and GTK+ WebKit ports. > > This est has been added in bug 70299, it allows legacy text check emulation in unified text check interface. > > > > It fails due to word "zzz" which cannot be found by enchant library, checked for en_US dictionary, see result of command: echo "zzz" | enchant -l > > Can we replace the problematic sound of snoring with a different phrase? That change will allow to test unified text checking by EFL and GTK+ WebKit ports. > > I'm not 100% sure about how they used this 'zzz' string but I guess it could be to test the following situation: > > "a test case containing a valid word which contains a bad word as a substring" > > ...assuming that 'zz' is expected to be invalid while 'zzz' should be valid. The word "zzz" is tested in two ways: 1) single "zzz" word is verified - it's expected to valid 2) sentence "I would like to sleep, zzz" is verified - it's expected to be valid too. > > > I will upload patch as soon as I get your opinions. > > I think it doesn't hurts to change this as long as the same kind of situations keep being tested Thanks, for your opinion 789549 3 179045 g.czajkowski 2012-12-12 07:56:37 -0800 Created attachment 179045 replace problemtaic "zzz" with "buzz" 790005 4 179045 morrita 2012-12-12 15:54:03 -0800 Comment on attachment 179045 replace problemtaic "zzz" with "buzz" fair enough. 790336 5 179045 webkit.review.bot 2012-12-12 23:58:30 -0800 Comment on attachment 179045 replace problemtaic "zzz" with "buzz" Clearing flags on attachment: 179045 Committed r137571: <http://trac.webkit.org/changeset/137571> 790337 6 webkit.review.bot 2012-12-12 23:58:34 -0800 All reviewed patches have been landed. Closing bug. 179045 2012-12-12 07:56:37 -0800 2012-12-12 23:58:30 -0800 replace problemtaic "zzz" with "buzz" spelling-unified-emulation-zzz.patch text/plain 2848 g.czajkowski ZGlmZiAtLWdpdCBhL0xheW91dFRlc3RzL0NoYW5nZUxvZyBiL0xheW91dFRlc3RzL0NoYW5nZUxv ZwppbmRleCAyNjY4NTljLi5hYzJkNTI5IDEwMDY0NAotLS0gYS9MYXlvdXRUZXN0cy9DaGFuZ2VM b2cKKysrIGIvTGF5b3V0VGVzdHMvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTggQEAKKzIwMTItMTIt MTIgIEdyemVnb3J6IEN6YWprb3dza2kgIDxnLmN6YWprb3dza2lAc2Ftc3VuZy5jb20+CisKKyAg ICAgICAgW0VGTF1bR1RLXSBzcGVsbGluZy11bmlmaWVkLWVtdWxhdGlvbi5odG1sIGZhaWxzIC0g d29yZCAienp6IiBjYW5ub3QgYmUgZm91bmQgYnkgZW5jaGFudAorICAgICAgICBodHRwczovL2J1 Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTA0Nzg3CisKKyAgICAgICAgUmV2aWV3ZWQg YnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgUmVwbGFjZSB0aGUgInp6eiIgd29yZCB3aXRo ICJidXp6Ii4KKyAgICAgICAgVGhlIHByb2JsZW1hdGljIHNvdW5kIG9mIHNub3JpbmcgY2FuIG5v dCBiZSBmb3VuZCBieSBlbmNoYW50IChzcGVsbGNoZWNrZXIgYmFja2VuZAorICAgICAgICBmb3Ig RUZMIGFuZCBHVEsrIFdlYktpdCBwb3J0cykgYXMgdGhpcyB3b3JkIGRvZXNuJ3QgZXhpc3QgaW4g RW5nbGlzaCBkaWN0aW9uYXJ5LgorCisgICAgICAgICogZWRpdGluZy9zcGVsbGluZy9zcGVsbGlu Zy11bmlmaWVkLWVtdWxhdGlvbi1leHBlY3RlZC50eHQ6CisgICAgICAgICogZWRpdGluZy9zcGVs bGluZy9zcGVsbGluZy11bmlmaWVkLWVtdWxhdGlvbi5odG1sOgorICAgICAgICAqIHBsYXRmb3Jt L2VmbC13azIvVGVzdEV4cGVjdGF0aW9uczoKKwogMjAxMi0xMS0yOSAgWXVyeSBTZW1pa2hhdHNr eSAgPHl1cnlzQGNocm9taXVtLm9yZz4KIAogICAgICAgICBXZWIgSW5zcGVjdG9yOiBIZWFwIHNu YXBzaG90IGNyYXNoZXMgb24gYW55IHBhZ2UgaW4gTWFjT1MgQ2FuYXJ5CmRpZmYgLS1naXQgYS9M YXlvdXRUZXN0cy9lZGl0aW5nL3NwZWxsaW5nL3NwZWxsaW5nLXVuaWZpZWQtZW11bGF0aW9uLWV4 cGVjdGVkLnR4dCBiL0xheW91dFRlc3RzL2VkaXRpbmcvc3BlbGxpbmcvc3BlbGxpbmctdW5pZmll ZC1lbXVsYXRpb24tZXhwZWN0ZWQudHh0CmluZGV4IDQ5MGU0MDkuLmM2Mzk4ODkgMTAwNjQ0Ci0t LSBhL0xheW91dFRlc3RzL2VkaXRpbmcvc3BlbGxpbmcvc3BlbGxpbmctdW5pZmllZC1lbXVsYXRp b24tZXhwZWN0ZWQudHh0CisrKyBiL0xheW91dFRlc3RzL2VkaXRpbmcvc3BlbGxpbmcvc3BlbGxp bmctdW5pZmllZC1lbXVsYXRpb24tZXhwZWN0ZWQudHh0CkBAIC0yOCw0ICsyOCw0IEBAIFBBU1Mg bnVtTWFya2VkIGlzIGxlbmd0aAogUEFTUyBzdWNjZXNzZnVsbHlQYXJzZWQgaXMgdHJ1ZQogCiBU RVNUIENPTVBMRVRFCi1JIHdvdWxkIGxpa2UgdG8gc2xlZXAsIHp6ei4KK0kgd291bGQgbGlrZSB0 byBzbGVlcCwgYnV6ei4KZGlmZiAtLWdpdCBhL0xheW91dFRlc3RzL2VkaXRpbmcvc3BlbGxpbmcv c3BlbGxpbmctdW5pZmllZC1lbXVsYXRpb24uaHRtbCBiL0xheW91dFRlc3RzL2VkaXRpbmcvc3Bl bGxpbmcvc3BlbGxpbmctdW5pZmllZC1lbXVsYXRpb24uaHRtbAppbmRleCAwNWQyNmRlLi41NmQ3 MWI1IDEwMDY0NAotLS0gYS9MYXlvdXRUZXN0cy9lZGl0aW5nL3NwZWxsaW5nL3NwZWxsaW5nLXVu aWZpZWQtZW11bGF0aW9uLmh0bWwKKysrIGIvTGF5b3V0VGVzdHMvZWRpdGluZy9zcGVsbGluZy9z cGVsbGluZy11bmlmaWVkLWVtdWxhdGlvbi5odG1sCkBAIC00Miw4ICs0Miw4IEBAIHZhciB0ZXN0 RGF0YSA9IFsKICAgICB7IHRleHQ6ICd6eiBhcHBsZSBvcmFuZ2UnLCBtYXJrZWQ6IFsnenonXSB9 LAogICAgIHsgdGV4dDogJ2FwcGxlIHp6IG9yYW5nZScsIG1hcmtlZDogWyd6eiddIH0sCiAgICAg eyB0ZXh0OiAnYXBwbGUgb3JhbmdlIHp6JywgbWFya2VkOiBbJ3p6J10gfSwKLSAgICB7IHRleHQ6 ICd6enonLCBtYXJrZWQ6IFtdIH0sCi0gICAgeyB0ZXh0OiAnSSB3b3VsZCBsaWtlIHRvIHNsZWVw LCB6enonLCBtYXJrZWQ6IFtdIH0KKyAgICB7IHRleHQ6ICdidXp6JywgbWFya2VkOiBbXSB9LAor ICAgIHsgdGV4dDogJ0kgd291bGQgbGlrZSB0byBzbGVlcCwgYnV6eicsIG1hcmtlZDogW10gfQog XTsKIAogdmFyIG51bU1hcmtlZDsKZGlmZiAtLWdpdCBhL0xheW91dFRlc3RzL3BsYXRmb3JtL2Vm bC13azIvVGVzdEV4cGVjdGF0aW9ucyBiL0xheW91dFRlc3RzL3BsYXRmb3JtL2VmbC13azIvVGVz dEV4cGVjdGF0aW9ucwppbmRleCA1Mjc4MGU1Li5hZGQxYTQ3IDEwMDY0NAotLS0gYS9MYXlvdXRU ZXN0cy9wbGF0Zm9ybS9lZmwtd2syL1Rlc3RFeHBlY3RhdGlvbnMKKysrIGIvTGF5b3V0VGVzdHMv cGxhdGZvcm0vZWZsLXdrMi9UZXN0RXhwZWN0YXRpb25zCkBAIC0zMDMsOSArMzAzLDYgQEAgQnVn KEVGTCkgZmFzdC9ldmVudHMvdG91Y2gvYmFzaWMtc2luZ2xlLXRvdWNoLWV2ZW50cy5odG1sIFsg RmFpbHVyZSBdCiBCdWcoRUZMKSBlZGl0aW5nL3NwZWxsaW5nL2dyYW1tYXItZWRpdC13b3JkLmh0 bWwgWyBGYWlsdXJlIF0KIEJ1ZyhFRkwpIGVkaXRpbmcvc3BlbGxpbmcvbWFya2Vycy5odG1sIFsg RmFpbHVyZSBdCiAKLSMgVW5pZmllZCB0ZXh0IGNoZWNraW5nIGlzIGZhaWxpbmcKLUJ1ZyhFRkwp IGVkaXRpbmcvc3BlbGxpbmcvc3BlbGxpbmctdW5pZmllZC1lbXVsYXRpb24uaHRtbCBbIEZhaWx1 cmUgXQotCiAjIFdlYktpdFRlc3RSdW5uZXIgbmVlZHMgYW4gaW1wbGVtZW50YXRpb24gZm9yIGV2 ZW50U2VuZGVyLnNjaGVkdWxlQXN5bmNocm9ub3VzS2V5RG93bgogd2Via2l0Lm9yZy9iLzkzOTc5 IGZhc3QvbXV0YXRpb24vZW5kLW9mLXRhc2stZGVsaXZlcnkuaHRtbCBbIEZhaWx1cmUgXQogCg==