104724 2012-12-11 14:59:34 -0800 Pre-painting should not paint out-of-view fixed position elements 2012-12-12 11:39:20 -0800 1 1 1 Unclassified WebKit Layout and Rendering 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 102543 1 wangxianzhu wangxianzhu bdakin eric jamesr ojan.autocc simon.fraser webkit.review.bot oldest_to_newest 788830 0 wangxianzhu 2012-12-11 14:59:34 -0800 Out-of-view fixed position elements are not composited. In RenderLayer::paintLayer(), such elements will be painted when pre-paint out-of-view parts. This causes residues when the part scrolls into the viewport. Patch of bug 102543 provides a way to determine if a non-composited fixed position element is out-of-view so not to be painted in pre-paining. 789118 1 jamesr 2012-12-11 19:22:34 -0800 I see the same bug in Safari running a WebKit nightly 789120 2 jamesr 2012-12-11 19:26:14 -0800 For instance load up http://software.hixie.ch/utilities/js/live-dom-viewer/saved/2012, click "Rendered view", and scroll down. I see lots of red on Version 6.0.2 (8536.26.17, 537+) WebKit r137338 789131 3 simon.fraser 2012-12-11 19:52:38 -0800 Not sure what pre-painting is. 789147 4 jamesr 2012-12-11 20:46:51 -0800 Painting things not currently in the visible viewport. On mac, I think this is done via the tile caching logic. 789167 5 178958 wangxianzhu 2012-12-11 21:28:01 -0800 Created attachment 178958 Patch 789172 6 wangxianzhu 2012-12-11 21:31:04 -0800 Actually I didn't reproduce the issue with the added test case when the fix was not applied. I wonder what the correct way is to test prepainting behavior. 789197 7 jamesr 2012-12-11 22:14:23 -0800 The scroll will generate an invalidation before the test completes. I don't know of any way to see the results of off-main-thread scrolling in a layout test. 789199 8 bdakin 2012-12-11 22:17:29 -0800 (In reply to comment #0) > Out-of-view fixed position elements are not composited. In RenderLayer::paintLayer(), such elements will be painted when pre-paint out-of-view parts. This causes residues when the part scrolls into the viewport. Patch of bug 102543 provides a way to determine if a non-composited fixed position element is out-of-view so not to be painted in pre-paining. Can you provide a manual test that reproduces this bug? I am just curious to see it. 789212 9 jamesr 2012-12-11 22:27:17 -0800 (In reply to comment #8) > (In reply to comment #0) > > Out-of-view fixed position elements are not composited. In RenderLayer::paintLayer(), such elements will be painted when pre-paint out-of-view parts. This causes residues when the part scrolls into the viewport. Patch of bug 102543 provides a way to determine if a non-composited fixed position element is out-of-view so not to be painted in pre-paining. > > Can you provide a manual test that reproduces this bug? I am just curious to see it. See comment #2 789216 10 bdakin 2012-12-11 22:31:58 -0800 (In reply to comment #9) > (In reply to comment #8) > > (In reply to comment #0) > > > Out-of-view fixed position elements are not composited. In RenderLayer::paintLayer(), such elements will be painted when pre-paint out-of-view parts. This causes residues when the part scrolls into the viewport. Patch of bug 102543 provides a way to determine if a non-composited fixed position element is out-of-view so not to be painted in pre-paining. > > > > Can you provide a manual test that reproduces this bug? I am just curious to see it. > > See comment #2 Thanks! 789705 11 179082 wangxianzhu 2012-12-12 10:58:18 -0800 Created attachment 179082 Use manual test 789708 12 179082 jamesr 2012-12-12 11:02:04 -0800 Comment on attachment 179082 Use manual test R=me 789751 13 179082 webkit.review.bot 2012-12-12 11:39:16 -0800 Comment on attachment 179082 Use manual test Clearing flags on attachment: 179082 Committed r137492: <http://trac.webkit.org/changeset/137492> 789752 14 webkit.review.bot 2012-12-12 11:39:20 -0800 All reviewed patches have been landed. Closing bug. 178958 2012-12-11 21:28:01 -0800 2012-12-12 10:58:16 -0800 Patch bug-104724-20121212052522.patch text/plain 5927 wangxianzhu U3VidmVyc2lvbiBSZXZpc2lvbjogMTM3NDA5CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggMjU4ZmUzY2IwMTdiMmVj YTc0NGUzMDJiZjU4NTk5MzhlNTgyOTRjYS4uOWMxOGU4MzA0NzYyZWUyYTE5MzExODhiOWRlODJh MGU0NTM2ZDdlMCAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE1IEBACisyMDEyLTEyLTExICBYaWFu emh1IFdhbmcgIDx3YW5neGlhbnpodUBjaHJvbWl1bS5vcmc+CisKKyAgICAgICAgW0Nocm9taXVt XSBQcmUtcGFpbnRpbmcgc2hvdWxkIG5vdCBwYWludCBvdXQtb2YtdmlldyBmaXhlZCBwb3NpdGlv biBlbGVtZW50cworICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/ aWQ9MTA0NzI0CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAg ICAgVGVzdDogY29tcG9zaXRpbmcvZml4ZWQtcG9zaXRpb24tb3V0LW9mLXZpZXctc2Nyb2xsLXBy ZXBhaW50Lmh0bWwKKworICAgICAgICAqIHJlbmRlcmluZy9SZW5kZXJMYXllci5jcHA6CisgICAg ICAgIChXZWJDb3JlOjpSZW5kZXJMYXllcjo6cGFpbnRMYXllcik6IERvbid0IHBhaW50IG91dC1v Zi12aWV3IGZpeGVkIHBvc2l0aW9uIGVsZW1lbnRzLgorCiAyMDEyLTEyLTExICBYaW5hemh1IFdh bmcgIDx3YW5neGlhbnpodUBjaHJvbWl1bS5vcmc+CiAKICAgICAgICAgU2Nyb2xsaW5nQ29vcmRp bmF0b3I6Omhhc1Zpc2libGVTbG93UmVwYWludEZpeGVkT2JqZWN0KCkgc2hvdWxkIGV4Y2x1ZGUg b3V0LW9mLXZpZXcgZml4ZWQgcG9zaXRpb24gZWxlbWVudHMKZGlmZiAtLWdpdCBhL1NvdXJjZS9X ZWJDb3JlL3JlbmRlcmluZy9SZW5kZXJMYXllci5jcHAgYi9Tb3VyY2UvV2ViQ29yZS9yZW5kZXJp bmcvUmVuZGVyTGF5ZXIuY3BwCmluZGV4IDJjOWU1MGRjMTRjZWYxZTUyNGU0ZWZmZTU3YTQ4MTA2 YTAxZDFlNDcuLmUxNzY5ZjBhOTY5MTFiMTZiMmYyMmE0Mzk2ZTRlOWJiNmFlNTJjZTkgMTAwNjQ0 Ci0tLSBhL1NvdXJjZS9XZWJDb3JlL3JlbmRlcmluZy9SZW5kZXJMYXllci5jcHAKKysrIGIvU291 cmNlL1dlYkNvcmUvcmVuZGVyaW5nL1JlbmRlckxheWVyLmNwcApAQCAtMzE0Niw2ICszMTQ2LDEw IEBAIHZvaWQgUmVuZGVyTGF5ZXI6OnBhaW50TGF5ZXIoR3JhcGhpY3NDb250ZXh0KiBjb250ZXh0 LCBjb25zdCBMYXllclBhaW50aW5nSW5mbyYKICAgICAgICAgICAgIC8vIElmIHRoaXMgUmVuZGVy TGF5ZXIgc2hvdWxkIHBhaW50IGludG8gaXRzIGJhY2tpbmcsIHRoYXQgd2lsbCBiZSBkb25lIHZp YSBSZW5kZXJMYXllckJhY2tpbmc6OnBhaW50SW50b0xheWVyKCkuCiAgICAgICAgICAgICByZXR1 cm47CiAgICAgICAgIH0KKyAgICB9IGVsc2UgaWYgKGNvbXBvc2l0b3IoKS0+Zml4ZWRQb3NpdGlv bkxheWVyTm90Q29tcG9zaXRlZFJlYXNvbih0aGlzKSA9PSBSZW5kZXJMYXllckNvbXBvc2l0b3I6 OkxheWVyQm91bmRzT3V0T2ZWaWV3KSB7CisgICAgICAgIC8vIERvbid0IHBhaW50IG91dC1vZi12 aWV3IGZpeGVkIHBvc2l0aW9uIGxheWVycyAod2hlbiBkb2luZyBwcmVwYWludGluZykgYmVjYXVz ZSB0aGV5IHdpbGwgbmV2ZXIgYmUgdmlzaWJsZQorICAgICAgICAvLyB1bmxlc3MgdGhlaXIgcG9z aXRpb24gb3Igdmlld3BvcnQgc2l6ZSBpcyBjaGFuZ2VkLgorICAgICAgICByZXR1cm47CiAgICAg fQogI2VuZGlmCiAKZGlmZiAtLWdpdCBhL0xheW91dFRlc3RzL0NoYW5nZUxvZyBiL0xheW91dFRl c3RzL0NoYW5nZUxvZwppbmRleCAxODg5YjU4N2E3MjFlZjQ1MmQ3MWEzYzZjNTMwMGZhY2ExMjc3 NTFmLi5mM2U3YmRjMGQ5ZmY4Nzg5N2ZjZWYxNzA5ZTRkM2NjMWI3N2ZjNjJlIDEwMDY0NAotLS0g YS9MYXlvdXRUZXN0cy9DaGFuZ2VMb2cKKysrIGIvTGF5b3V0VGVzdHMvQ2hhbmdlTG9nCkBAIC0x LDUgKzEsMTcgQEAKIDIwMTItMTItMTEgIFhpYW56aHUgV2FuZyAgPHdhbmd4aWFuemh1QGNocm9t aXVtLm9yZz4KIAorICAgICAgICBbQ2hyb21pdW1dIFByZS1wYWludGluZyBzaG91bGQgbm90IHBh aW50IG91dC1vZi12aWV3IGZpeGVkIHBvc2l0aW9uIGVsZW1lbnRzCisgICAgICAgIGh0dHBzOi8v YnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xMDQ3MjQKKworICAgICAgICBSZXZpZXdl ZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBFbnN1cmVzIG91dC1vZi12aWV3IGZpeGVk IHBvc2l0aW9uIGVsZW1lbnRzIGFyZSBub3Qgc2hvd24gd2hlbiBwYWdlIGlzIHNjcm9sbGVkLgor CisgICAgICAgICogY29tcG9zaXRpbmcvZml4ZWQtcG9zaXRpb24tb3V0LW9mLXZpZXctc2Nyb2xs LXByZXBhaW50LWV4cGVjdGVkLmh0bWw6IEFkZGVkLgorICAgICAgICAqIGNvbXBvc2l0aW5nL2Zp eGVkLXBvc2l0aW9uLW91dC1vZi12aWV3LXNjcm9sbC1wcmVwYWludC5odG1sOiBBZGRlZC4KKwor MjAxMi0xMi0xMSAgWGlhbnpodSBXYW5nICA8d2FuZ3hpYW56aHVAY2hyb21pdW0ub3JnPgorCiAg ICAgICAgIFNjcm9sbGluZ0Nvb3JkaW5hdG9yOjpoYXNWaXNpYmxlU2xvd1JlcGFpbnRGaXhlZE9i amVjdCgpIHNob3VsZCBleGNsdWRlIG91dC1vZi12aWV3IGZpeGVkIHBvc2l0aW9uIGVsZW1lbnRz CiAgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xMDI1NDMK IApkaWZmIC0tZ2l0IGEvTGF5b3V0VGVzdHMvY29tcG9zaXRpbmcvZml4ZWQtcG9zaXRpb24tb3V0 LW9mLXZpZXctc2Nyb2xsLXByZXBhaW50LWV4cGVjdGVkLmh0bWwgYi9MYXlvdXRUZXN0cy9jb21w b3NpdGluZy9maXhlZC1wb3NpdGlvbi1vdXQtb2Ytdmlldy1zY3JvbGwtcHJlcGFpbnQtZXhwZWN0 ZWQuaHRtbApuZXcgZmlsZSBtb2RlIDEwMDY0NAppbmRleCAwMDAwMDAwMDAwMDAwMDAwMDAwMDAw MDAwMDAwMDAwMDAwMDAwMDAwLi5lOWZjZTg4ZmIwYWIyZGVkNmY0M2RjMDZkMDViZmZkM2FhMzAx NDFiCi0tLSAvZGV2L251bGwKKysrIGIvTGF5b3V0VGVzdHMvY29tcG9zaXRpbmcvZml4ZWQtcG9z aXRpb24tb3V0LW9mLXZpZXctc2Nyb2xsLXByZXBhaW50LWV4cGVjdGVkLmh0bWwKQEAgLTAsMCAr MSw1NCBAQAorPCFET0NUWVBFIGh0bWw+CisKKzxodG1sPgorPGhlYWQ+CisgIDxzdHlsZT4KKyAg ICBib2R5IHsKKyAgICAgIHdpZHRoOiAyMDAwcHg7CisgICAgICBoZWlnaHQ6IDIwMDBweDsKKyAg ICAgIG1hcmdpbjogMHB4OworICAgICAgcGFkZGluZzogMHB4OworICAgIH0KKyAgICAuZml4ZWQg eworICAgICAgcG9zaXRpb246IGZpeGVkOworICAgICAgd2lkdGg6IDEwMHB4OworICAgICAgaGVp Z2h0OiAxMDBweDsKKyAgICAgIGJhY2tncm91bmQtY29sb3I6IHJlZDsKKyAgICB9CisgICAgLm1h aW4geworICAgICAgd2lkdGg6IDgwMHB4OworICAgICAgaGVpZ2h0OiA2MDBweDsKKyAgICAgIGJh Y2tncm91bmQtY29sb3I6IGJsdWU7CisgICAgfQorICA8L3N0eWxlPgorCisgIDxzY3JpcHQgdHlw ZT0idGV4dC9qYXZhc2NyaXB0Ij4KKyAgICBpZiAod2luZG93LmludGVybmFscykgeworICAgICAg d2luZG93LmludGVybmFscy5zZXR0aW5ncy5zZXRFbmFibGVDb21wb3NpdGluZ0ZvckZpeGVkUG9z aXRpb24odHJ1ZSk7CisgICAgICB3aW5kb3cuaW50ZXJuYWxzLnNldHRpbmdzLnNldEZpeGVkUG9z aXRpb25DcmVhdGVzU3RhY2tpbmdDb250ZXh0KHRydWUpOworICAgIH0KKworICAgIGlmICh3aW5k b3cudGVzdFJ1bm5lcikgeworICAgICAgdGVzdFJ1bm5lci53YWl0VW50aWxEb25lKCk7CisKKyAg ICAgIHdpbmRvdy5hZGRFdmVudExpc3RlbmVyKCJsb2FkIiwgZnVuY3Rpb24oKSB7CisgICAgICAg IHdpbmRvdy5zZXRUaW1lb3V0KGZ1bmN0aW9uKCkgeworICAgICAgICAgIHdpbmRvdy5zY3JvbGxU bygyMDAsIDIwMCk7CisgICAgICAgICAgdGVzdFJ1bm5lci5ub3RpZnlEb25lKCk7CisgICAgICAg IH0sIDEwMCk7CisgICAgICB9LCBmYWxzZSk7CisgICAgfQorICA8L3NjcmlwdD4KKzwvaGVhZD4K KworPGJvZHk+CisgIDxkaXYgY2xhc3M9Im1haW4iPjwvZGl2PgorCisgIDwhLS0gVGhlIHRlc3Qg Y2FzZSBzaG91bGQgYmUgZGlzcGxheWVkIGFzIGlmIHRoZXJlIGFyZSBubyBvdXQtb2YtdmlldyBm aXhlZCBwb3NpdGlvbiBlbGVtZW50cy4gLS0+CisKKyAgPCEtLSBUaGlzIG9uZSB0cmlnZ2VycyBj b21wb3NpdGluZyBvZiB0aGUgcGFnZS4gLS0+CisgIDxkaXYgY2xhc3M9ImZpeGVkIiBzdHlsZT0i dG9wOiAwcHg7IGxlZnQ6IDBweCI+PC9kaXY+Cis8L2JvZHk+Cis8L2h0bWw+CisKKwpkaWZmIC0t Z2l0IGEvTGF5b3V0VGVzdHMvY29tcG9zaXRpbmcvZml4ZWQtcG9zaXRpb24tb3V0LW9mLXZpZXct c2Nyb2xsLXByZXBhaW50Lmh0bWwgYi9MYXlvdXRUZXN0cy9jb21wb3NpdGluZy9maXhlZC1wb3Np dGlvbi1vdXQtb2Ytdmlldy1zY3JvbGwtcHJlcGFpbnQuaHRtbApuZXcgZmlsZSBtb2RlIDEwMDY0 NAppbmRleCAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwLi41Y2EzMzkx ZjVjN2ZhZWEwZGU3YTY1YTFjMmJhOGE0YzEzNzMwYmIwCi0tLSAvZGV2L251bGwKKysrIGIvTGF5 b3V0VGVzdHMvY29tcG9zaXRpbmcvZml4ZWQtcG9zaXRpb24tb3V0LW9mLXZpZXctc2Nyb2xsLXBy ZXBhaW50Lmh0bWwKQEAgLTAsMCArMSw1NiBAQAorPCFET0NUWVBFIGh0bWw+CisKKzxodG1sPgor PGhlYWQ+CisgIDxzdHlsZT4KKyAgICBib2R5IHsKKyAgICAgIHdpZHRoOiAyMDAwcHg7CisgICAg ICBoZWlnaHQ6IDIwMDBweDsKKyAgICAgIG1hcmdpbjogMHB4OworICAgICAgcGFkZGluZzogMHB4 OworICAgIH0KKyAgICAuZml4ZWQgeworICAgICAgcG9zaXRpb246IGZpeGVkOworICAgICAgd2lk dGg6IDEwMHB4OworICAgICAgaGVpZ2h0OiAxMDBweDsKKyAgICAgIGJhY2tncm91bmQtY29sb3I6 IHJlZDsKKyAgICAgIHotb3JkZXI6IDE7CisgICAgfQorICAgIC5tYWluIHsKKyAgICAgIHdpZHRo OiA4MDBweDsKKyAgICAgIGhlaWdodDogNjAwcHg7CisgICAgICBiYWNrZ3JvdW5kLWNvbG9yOiBi bHVlOworICAgIH0KKyAgPC9zdHlsZT4KKworICA8c2NyaXB0IHR5cGU9InRleHQvamF2YXNjcmlw dCI+CisgICAgaWYgKHdpbmRvdy5pbnRlcm5hbHMpIHsKKyAgICAgIHdpbmRvdy5pbnRlcm5hbHMu c2V0dGluZ3Muc2V0RW5hYmxlQ29tcG9zaXRpbmdGb3JGaXhlZFBvc2l0aW9uKHRydWUpOworICAg ICAgd2luZG93LmludGVybmFscy5zZXR0aW5ncy5zZXRGaXhlZFBvc2l0aW9uQ3JlYXRlc1N0YWNr aW5nQ29udGV4dCh0cnVlKTsKKyAgICB9CisKKyAgICBpZiAod2luZG93LnRlc3RSdW5uZXIpIHsK KyAgICAgIHRlc3RSdW5uZXIud2FpdFVudGlsRG9uZSgpOworCisgICAgICB3aW5kb3cuYWRkRXZl bnRMaXN0ZW5lcigibG9hZCIsIGZ1bmN0aW9uKCkgeworICAgICAgICB3aW5kb3cuc2V0VGltZW91 dChmdW5jdGlvbigpIHsKKyAgICAgICAgICB3aW5kb3cuc2Nyb2xsVG8oMjAwLCAyMDApOworICAg ICAgICAgIHRlc3RSdW5uZXIubm90aWZ5RG9uZSgpOworICAgICAgICB9LCAxMDApOworICAgICAg fSwgZmFsc2UpOworICAgIH0KKyAgPC9zY3JpcHQ+Cis8L2hlYWQ+CisKKzxib2R5PgorICA8ZGl2 IGNsYXNzPSJtYWluIj48L2Rpdj4KKworICA8IS0tIE91dCBvZiB2aWV3IGZpeGVkIGVsZW1lbnRz IC0tPgorICA8ZGl2IGNsYXNzPSJmaXhlZCI+PC9kaXY+CisgIDxkaXYgY2xhc3M9ImZpeGVkIiBz dHlsZT0idG9wOiAwcHg7IGxlZnQ6IDgwMHB4Ij48L2Rpdj4KKworICA8IS0tIFRoaXMgb25lIHRy aWdnZXJzIGNvbXBvc2l0aW5nIG9mIHRoZSBwYWdlLiAtLT4KKyAgPGRpdiBjbGFzcz0iZml4ZWQi IHN0eWxlPSJ0b3A6IDBweDsgbGVmdDogMHB4Ij48L2Rpdj4KKzwvYm9keT4KKzwvaHRtbD4KKwo= 179082 2012-12-12 10:58:18 -0800 2012-12-12 11:39:16 -0800 Use manual test bug-104724-20121212185539.patch text/plain 3794 wangxianzhu U3VidmVyc2lvbiBSZXZpc2lvbjogMTM3NDA5CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggMjU4ZmUzY2IwMTdiMmVj YTc0NGUzMDJiZjU4NTk5MzhlNTgyOTRjYS4uMDk4OWM4NTEyZGJmOTQ4Y2JhZjdkOWMxN2JjODVm ZDkzMjIwYmM2ZSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE1IEBACisyMDEyLTEyLTExICBYaWFu emh1IFdhbmcgIDx3YW5neGlhbnpodUBjaHJvbWl1bS5vcmc+CisKKyAgICAgICAgUHJlLXBhaW50 aW5nIHNob3VsZCBub3QgcGFpbnQgb3V0LW9mLXZpZXcgZml4ZWQgcG9zaXRpb24gZWxlbWVudHMK KyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTEwNDcyNAor CisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIFRlc3Q6IE1h bnVhbFRlc3RzL2NvbXBvc2l0aW5nL2ZpeGVkLXBvc2l0aW9uLW91dC1vZi12aWV3LXNjcm9sbC1w cmVwYWludC5odG1sCisKKyAgICAgICAgKiByZW5kZXJpbmcvUmVuZGVyTGF5ZXIuY3BwOgorICAg ICAgICAoV2ViQ29yZTo6UmVuZGVyTGF5ZXI6OnBhaW50TGF5ZXIpOiBEb24ndCBwYWludCBvdXQt b2YtdmlldyBmaXhlZCBwb3NpdGlvbiBlbGVtZW50cy4KKwogMjAxMi0xMi0xMSAgWGluYXpodSBX YW5nICA8d2FuZ3hpYW56aHVAY2hyb21pdW0ub3JnPgogCiAgICAgICAgIFNjcm9sbGluZ0Nvb3Jk aW5hdG9yOjpoYXNWaXNpYmxlU2xvd1JlcGFpbnRGaXhlZE9iamVjdCgpIHNob3VsZCBleGNsdWRl IG91dC1vZi12aWV3IGZpeGVkIHBvc2l0aW9uIGVsZW1lbnRzCmRpZmYgLS1naXQgYS9Tb3VyY2Uv V2ViQ29yZS9yZW5kZXJpbmcvUmVuZGVyTGF5ZXIuY3BwIGIvU291cmNlL1dlYkNvcmUvcmVuZGVy aW5nL1JlbmRlckxheWVyLmNwcAppbmRleCAyYzllNTBkYzE0Y2VmMWU1MjRlNGVmZmU1N2E0ODEw NmEwMWQxZTQ3Li5lMTc2OWYwYTk2OTExYjE2YjJmMjJhNDM5NmU0ZTliYjZhZTUyY2U5IDEwMDY0 NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9yZW5kZXJpbmcvUmVuZGVyTGF5ZXIuY3BwCisrKyBiL1Nv dXJjZS9XZWJDb3JlL3JlbmRlcmluZy9SZW5kZXJMYXllci5jcHAKQEAgLTMxNDYsNiArMzE0Niwx MCBAQCB2b2lkIFJlbmRlckxheWVyOjpwYWludExheWVyKEdyYXBoaWNzQ29udGV4dCogY29udGV4 dCwgY29uc3QgTGF5ZXJQYWludGluZ0luZm8mCiAgICAgICAgICAgICAvLyBJZiB0aGlzIFJlbmRl ckxheWVyIHNob3VsZCBwYWludCBpbnRvIGl0cyBiYWNraW5nLCB0aGF0IHdpbGwgYmUgZG9uZSB2 aWEgUmVuZGVyTGF5ZXJCYWNraW5nOjpwYWludEludG9MYXllcigpLgogICAgICAgICAgICAgcmV0 dXJuOwogICAgICAgICB9CisgICAgfSBlbHNlIGlmIChjb21wb3NpdG9yKCktPmZpeGVkUG9zaXRp b25MYXllck5vdENvbXBvc2l0ZWRSZWFzb24odGhpcykgPT0gUmVuZGVyTGF5ZXJDb21wb3NpdG9y OjpMYXllckJvdW5kc091dE9mVmlldykgeworICAgICAgICAvLyBEb24ndCBwYWludCBvdXQtb2Yt dmlldyBmaXhlZCBwb3NpdGlvbiBsYXllcnMgKHdoZW4gZG9pbmcgcHJlcGFpbnRpbmcpIGJlY2F1 c2UgdGhleSB3aWxsIG5ldmVyIGJlIHZpc2libGUKKyAgICAgICAgLy8gdW5sZXNzIHRoZWlyIHBv c2l0aW9uIG9yIHZpZXdwb3J0IHNpemUgaXMgY2hhbmdlZC4KKyAgICAgICAgcmV0dXJuOwogICAg IH0KICNlbmRpZgogCmRpZmYgLS1naXQgYS9DaGFuZ2VMb2cgYi9DaGFuZ2VMb2cKaW5kZXggM2Qx YzE1ZDQyNjdmMDI3OTllMDhlNTgzOTM5YTI5YzEzMzdiZjA4Ny4uY2NmMDFmMDIzZTNhOTEyYWM3 YmFlNWUyMWQ5ZWU0YWM3MGUxNTNmOCAxMDA2NDQKLS0tIGEvQ2hhbmdlTG9nCisrKyBiL0NoYW5n ZUxvZwpAQCAtMSwzICsxLDE0IEBACisyMDEyLTEyLTEyICBYaWFuemh1IFdhbmcgIDx3YW5neGlh bnpodUBjaHJvbWl1bS5vcmc+CisKKyAgICAgICAgUHJlLXBhaW50aW5nIHNob3VsZCBub3QgcGFp bnQgb3V0LW9mLXZpZXcgZml4ZWQgcG9zaXRpb24gZWxlbWVudHMKKyAgICAgICAgaHR0cHM6Ly9i dWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTEwNDcyNAorCisgICAgICAgIFJldmlld2Vk IGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIE5ldyBtYW51YWwgdGVzdC4KKworICAgICAg ICAqIE1hbnVhbFRlc3RzL2NvbXBvc2l0aW5nL2ZpeGVkLXBvc2l0aW9uLW91dC1vZi12aWV3LXNj cm9sbC1wcmVwYWludC5odG1sOiBBZGRlZC4KKwogMjAxMi0xMi0xMSAgWGlhbnpodSBXYW5nICA8 d2FuZ3hpYW56aHVAY2hyb21pdW0ub3JnPgogCiAgICAgICAgIEFkZCB3aW5kb3cuaW50ZXJuYWxz Lm1haW5UaHJlYWRTY3JvbGxSZWFzb25zQXNUZXh0IGZvciB0ZXN0aW5nIHNsb3cgc2Nyb2xsaW5n CmRpZmYgLS1naXQgYS9NYW51YWxUZXN0cy9jb21wb3NpdGluZy9maXhlZC1wb3NpdGlvbi1vdXQt b2Ytdmlldy1zY3JvbGwtcHJlcGFpbnQuaHRtbCBiL01hbnVhbFRlc3RzL2NvbXBvc2l0aW5nL2Zp eGVkLXBvc2l0aW9uLW91dC1vZi12aWV3LXNjcm9sbC1wcmVwYWludC5odG1sCm5ldyBmaWxlIG1v ZGUgMTAwNjQ0CmluZGV4IDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAu LjViMDU1NDhkMDZiMmMwNDAyMjJkOTM0M2ViM2VlODk5NGYxNGVmODcKLS0tIC9kZXYvbnVsbAor KysgYi9NYW51YWxUZXN0cy9jb21wb3NpdGluZy9maXhlZC1wb3NpdGlvbi1vdXQtb2Ytdmlldy1z Y3JvbGwtcHJlcGFpbnQuaHRtbApAQCAtMCwwICsxLDM3IEBACis8IURPQ1RZUEUgaHRtbD4KKzxo dG1sPgorPGhlYWQ+CisgIDxzdHlsZT4KKyAgICBib2R5IHsKKyAgICAgIGhlaWdodDogMjAwMHB4 OworICAgICAgbWFyZ2luOiAwcHg7CisgICAgICBwYWRkaW5nOiAwcHg7CisgICAgfQorICAgIC5t YWluIHsKKyAgICAgIHBvc2l0aW9uOiBmaXhlZDsKKyAgICB9CisgICAgLmZpeGVkIHsKKyAgICAg IHBvc2l0aW9uOiBmaXhlZDsKKyAgICAgIHdpZHRoOiAxMDAlOworICAgICAgaGVpZ2h0OiAxMDBw eDsKKyAgICAgIGxlZnQ6IDBweDsKKyAgICAgIGJvdHRvbTogLTEwMHB4OworICAgICAgYmFja2dy b3VuZC1jb2xvcjogcmVkOworICAgIH0KKyAgPC9zdHlsZT4KKzwvaGVhZD4KKworPGJvZHk+Cisg IDxkaXYgY2xhc3M9Im1haW4iPgorICAgIFRoaXMgdGVzdCBpcyBhcHBsaWNhYmxlIG9uIHBsYXRm b3JtcyB0aGF0IGRvIGFjY2VsZXJhdGVkIGNvbXBvc2l0aW5nLCBjYW4gcHJlcGFpbnQgb3V0LW9m LXZpZXcgY29udGVudHMgYW5kIGNhbiBzY3JvbGwgdGhlIGNvbnRlbnRzIGludG8gdGhlIHZpZXdw b3J0IHdpdGhvdXQgcmVwYWludGluZyB0aGVtLjxwPgorICAgIFRoZSBmb2xsb3dpbmcgc2V0dGlu Z3MgbmVlZCB0byBiZSBlbmFibGVkOjxwPgorICAgIC0gYWNjZWxlcmF0ZWRDb21wb3NpdGluZ0Zv ckZpeGVkUG9zaXRpb25FbmFibGVkPGJyPgorICAgIC0gZml4ZWRQb3NpdGlvbkNyZWF0ZXNTdGFj a2luZ0NvbnRleHQ8cD4KKyAgICBUbyB0ZXN0LCBzY3JvbGwgdGhlIHBhZ2UgdXAgYW5kIGRvd24u IFRoZSB0ZXN0IHBhc3NlcyBpZiB0aGVyZSBpcyBubyB0ZW1wb3Jhcnkgb3IgcGVybWFuZW50IHJl ZCBpbiB0aGUgcGFnZS4KKyAgPC9kaXY+CisKKyAgPCEtLSBBbiBvdXQtb2YtdmlldyBmaXhlZCBl bGVtZW50IHRoYXQgc2hvdWxkIGJlIG5ldmVyIHZpc2libGUgLS0+CisgIDxkaXYgY2xhc3M9ImZp eGVkIj48L2Rpdj4KKzwvYm9keT4KKzwvaHRtbD4KKwo=