104701 2012-12-11 12:25:38 -0800 nrwt isn't rejecting unrecognized expectations 2012-12-11 12:55:11 -0800 1 1 1 Unclassified WebKit New Bugs 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 dpranke dpranke abarth adamk eric ojan rniwa webkit.review.bot oldest_to_newest 788666 0 dpranke 2012-12-11 12:25:38 -0800 nrwt isn't rejecting unrecognized expectations 788670 1 178847 dpranke 2012-12-11 12:27:03 -0800 Created attachment 178847 Patch 788673 2 178847 ojan 2012-12-11 12:29:51 -0800 Comment on attachment 178847 Patch Can you also fix the cases where these exist in TestExpectations to avoid adding a bunch of linter errors? 788691 3 dpranke 2012-12-11 12:50:38 -0800 Yeah, I believe aklein fixed the chromium files, but I will fix the others. 788697 4 dpranke 2012-12-11 12:55:11 -0800 Committed r137343: <http://trac.webkit.org/changeset/137343> 178847 2012-12-11 12:27:03 -0800 2012-12-11 12:29:51 -0800 Patch bug-104701-20121211122424.patch text/plain 3787 dpranke U3VidmVyc2lvbiBSZXZpc2lvbjogMTM3MzM0CmRpZmYgLS1naXQgYS9Ub29scy9DaGFuZ2VMb2cg Yi9Ub29scy9DaGFuZ2VMb2cKaW5kZXggMzRkY2EwMGM2YzkzYjVjZWMxNzI2Yjk5OGJjODljZGYz YTA1MzEzMC4uNTRlNTQ0Yjg1MjBiMjkxODAwNGU0ZjdlOThlMTliN2YwYWY0MjAyZCAxMDA2NDQK LS0tIGEvVG9vbHMvQ2hhbmdlTG9nCisrKyBiL1Rvb2xzL0NoYW5nZUxvZwpAQCAtMSwzICsxLDIy IEBACisyMDEyLTEyLTExICBEaXJrIFByYW5rZSAgPGRwcmFua2VAY2hyb21pdW0ub3JnPgorCisg ICAgICAgIG5yd3QgaXNuJ3QgcmVqZWN0aW5nIHVucmVjb2duaXplZCBleHBlY3RhdGlvbnMKKyAg ICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTEwNDcwMQorCisg ICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIE5SV1QgaXMgc2ls ZW50bHkgaWdub3JpbmcgdW5yZWNvZ25pemVkIGV4cGVjdGF0aW9ucyBsaWtlICJUZXh0IgorICAg ICAgICBhbmQgIkF1ZGlvIiAobGFyZ2VseSBiZWNhdXNlIEkgaGF2ZW4ndCBmdWxseSByZW1vdmVk IHN1cHBvcnQgZm9yCisgICAgICAgIHRoZSBvbGQgc3ludGF4IGFuZCBrZXl3b3JkcyBhbmQgcmVz dHJ1Y3R1cmVkIHRoZSBjb2RlIHRvIGRvIHRoZQorICAgICAgICBwcm9wZXIgY2hlY2tpbmcpLiBU ZW1wb3JhcmlseSBjaGFuZ2UgdGhlIHRva2VuaXplciB0byByZWplY3QKKyAgICAgICAgdW5yZWNv Z25pemVkIGV4cGVjdGF0aW9ucyB1bnRpbCBJIGNhbiBtYWtlIHRob3NlIGNoYW5nZXMuCisKKyAg ICAgICAgKiBTY3JpcHRzL3dlYmtpdHB5L2xheW91dF90ZXN0cy9tb2RlbHMvdGVzdF9leHBlY3Rh dGlvbnMucHk6CisgICAgICAgIChUZXN0RXhwZWN0YXRpb25QYXJzZXIuX3Rva2VuaXplX2xpbmUp OgorICAgICAgICAqIFNjcmlwdHMvd2Via2l0cHkvbGF5b3V0X3Rlc3RzL21vZGVscy90ZXN0X2V4 cGVjdGF0aW9uc191bml0dGVzdC5weToKKyAgICAgICAgKEV4cGVjdGF0aW9uU3ludGF4VGVzdHMu dGVzdF91bmtub3duX2V4cGVjdGF0aW9uKToKKyAgICAgICAgKFRlc3RFeHBlY3RhdGlvblNlcmlh bGl6YXRpb25UZXN0cy5kaXNhYmxlZF90ZXN0X3N0cmluZ193aGl0ZXNwYWNlX3N0cmlwcGluZyk6 CisKIDIwMTItMTItMTEgIE1hcnRpbiBSb2JpbnNvbiAgPG1yb2JpbnNvbkBpZ2FsaWEuY29tPgog CiAgICAgICAgIFtHVEtdIFNwdXJpb3VzIHN0ZGVyciBvdXRwdXQgZnJvbSB0aGUgZXZlbnQgc2Vu ZGVyCmRpZmYgLS1naXQgYS9Ub29scy9TY3JpcHRzL3dlYmtpdHB5L2xheW91dF90ZXN0cy9tb2Rl bHMvdGVzdF9leHBlY3RhdGlvbnMucHkgYi9Ub29scy9TY3JpcHRzL3dlYmtpdHB5L2xheW91dF90 ZXN0cy9tb2RlbHMvdGVzdF9leHBlY3RhdGlvbnMucHkKaW5kZXggMTgxODc1ZDkyMDlmNDU5MjAw M2U4ZGFjNGRjMDA5ODc0Yzg3Yzc4My4uYTZmZmRjYjVmNTJjYjBmYzZmMzEyNDE1NDczNDFhODgx YTA3NDIzZSAxMDA2NDQKLS0tIGEvVG9vbHMvU2NyaXB0cy93ZWJraXRweS9sYXlvdXRfdGVzdHMv bW9kZWxzL3Rlc3RfZXhwZWN0YXRpb25zLnB5CisrKyBiL1Rvb2xzL1NjcmlwdHMvd2Via2l0cHkv bGF5b3V0X3Rlc3RzL21vZGVscy90ZXN0X2V4cGVjdGF0aW9ucy5weQpAQCAtMzI5LDYgKzMyOSw4 IEBAIGNsYXNzIFRlc3RFeHBlY3RhdGlvblBhcnNlcihvYmplY3QpOgogICAgICAgICAgICAgZWxp ZiBzdGF0ZSA9PSAnZXhwZWN0YXRpb25zJzoKICAgICAgICAgICAgICAgICBpZiB0b2tlbiBpbiAo J1JlYmFzZWxpbmUnLCAnU2tpcCcsICdTbG93JywgJ1dvbnRGaXgnKToKICAgICAgICAgICAgICAg ICAgICAgbW9kaWZpZXJzLmFwcGVuZCh0b2tlbi51cHBlcigpKQorICAgICAgICAgICAgICAgIGVs aWYgdG9rZW4gbm90IGluIGNscy5fZXhwZWN0YXRpb25fdG9rZW5zOgorICAgICAgICAgICAgICAg ICAgICB3YXJuaW5ncy5hcHBlbmQoJ1VucmVjb2duaXplZCBleHBlY3RhdGlvbiAiJXMiJyAlIHRv a2VuKQogICAgICAgICAgICAgICAgIGVsc2U6CiAgICAgICAgICAgICAgICAgICAgIGV4cGVjdGF0 aW9ucy5hcHBlbmQoY2xzLl9leHBlY3RhdGlvbl90b2tlbnMuZ2V0KHRva2VuLCB0b2tlbikpCiAg ICAgICAgICAgICBlbGlmIHN0YXRlID09ICduYW1lX2ZvdW5kJzoKZGlmZiAtLWdpdCBhL1Rvb2xz L1NjcmlwdHMvd2Via2l0cHkvbGF5b3V0X3Rlc3RzL21vZGVscy90ZXN0X2V4cGVjdGF0aW9uc191 bml0dGVzdC5weSBiL1Rvb2xzL1NjcmlwdHMvd2Via2l0cHkvbGF5b3V0X3Rlc3RzL21vZGVscy90 ZXN0X2V4cGVjdGF0aW9uc191bml0dGVzdC5weQppbmRleCA0MGY5Y2I1MGFlNmFiOTA5MmI5Mzg1 NmZiNTUwNDBkMDI1ZjA0YzFjLi5iM2IwYWVhNmE2OGNmOWNjMGEwNTFkMmFiYTIxZDEyMTQyOWIz MWEzIDEwMDY0NAotLS0gYS9Ub29scy9TY3JpcHRzL3dlYmtpdHB5L2xheW91dF90ZXN0cy9tb2Rl bHMvdGVzdF9leHBlY3RhdGlvbnNfdW5pdHRlc3QucHkKKysrIGIvVG9vbHMvU2NyaXB0cy93ZWJr aXRweS9sYXlvdXRfdGVzdHMvbW9kZWxzL3Rlc3RfZXhwZWN0YXRpb25zX3VuaXR0ZXN0LnB5CkBA IC0zNDYsNyArMzQ2LDcgQEAgY2xhc3MgRXhwZWN0YXRpb25TeW50YXhUZXN0cyhCYXNlKToKICAg ICAgICAgc2VsZi5hc3NlcnRfdG9rZW5pemVfZXhwKCdbIEZvbyBdIGZvby5odG1sICcsIG1vZGlm aWVycz1bJ0ZvbycsICdTS0lQJ10sIGV4cGVjdGF0aW9ucz1bJ1BBU1MnXSkKIAogICAgIGRlZiB0 ZXN0X3Vua25vd25fZXhwZWN0YXRpb24oc2VsZik6Ci0gICAgICAgIHNlbGYuYXNzZXJ0X3Rva2Vu aXplX2V4cCgnZm9vLmh0bWwgWyBBdWRpbyBdJywgZXhwZWN0YXRpb25zPVsnQXVkaW8nXSkKKyAg ICAgICAgc2VsZi5hc3NlcnRfdG9rZW5pemVfZXhwKCdmb28uaHRtbCBbIEF1ZGlvIF0nLCB3YXJu aW5ncz1bJ1VucmVjb2duaXplZCBleHBlY3RhdGlvbiAiQXVkaW8iJ10pCiAKICAgICBkZWYgdGVz dF9za2lwKHNlbGYpOgogICAgICAgICBzZWxmLmFzc2VydF90b2tlbml6ZV9leHAoJ2Zvby5odG1s IFsgU2tpcCBdJywgbW9kaWZpZXJzPVsnU0tJUCddLCBleHBlY3RhdGlvbnM9WydQQVNTJ10pCkBA IC02OTUsNyArNjk1LDggQEAgY2xhc3MgVGVzdEV4cGVjdGF0aW9uU2VyaWFsaXphdGlvblRlc3Rz KHVuaXR0ZXN0LlRlc3RDYXNlKToKICAgICAgICAgc2VyaWFsaXplZCA9IFRlc3RFeHBlY3RhdGlv bnMubGlzdF90b19zdHJpbmcobGluZXMsIHNlbGYuX2NvbnZlcnRlciwgcmVjb25zdGl0dXRlX29u bHlfdGhlc2U9cmVjb25zdGl0dXRlX29ubHlfdGhlc2UpCiAgICAgICAgIHNlbGYuYXNzZXJ0RXF1 YWwoc2VyaWFsaXplZCwgIkJ1Zyh4KSBbIFhQIFJlbGVhc2UgXSBZYXkgWyBJbWFnZU9ubHlGYWls dXJlIF1cbk5heSIpCiAKLSAgICBkZWYgdGVzdF9zdHJpbmdfd2hpdGVzcGFjZV9zdHJpcHBpbmco c2VsZik6CisgICAgZGVmIGRpc2FibGVkX3Rlc3Rfc3RyaW5nX3doaXRlc3BhY2Vfc3RyaXBwaW5n KHNlbGYpOgorICAgICAgICAjIEZJWE1FOiBSZS1lbmFibGUgdGhpcyB0ZXN0IG9uY2Ugd2UgcmV3 b3JrIHRoZSBjb2RlIHRvIG5vIGxvbmdlciBzdXBwb3J0IHRoZSBvbGQgc3ludGF4LgogICAgICAg ICBzZWxmLmFzc2VydF9yb3VuZF90cmlwKCdcbicsICcnKQogICAgICAgICBzZWxmLmFzc2VydF9y b3VuZF90cmlwKCcgIFsgRk9PIF0gYmFyIFsgQkFaIF0nLCAnWyBGT08gXSBiYXIgWyBCQVogXScp CiAgICAgICAgIHNlbGYuYXNzZXJ0X3JvdW5kX3RyaXAoJ1sgRk9PIF0gICAgYmFyIFsgQkFaIF0n LCAnWyBGT08gXSBiYXIgWyBCQVogXScpCg==