104682 2012-12-11 10:11:44 -0800 [Skia] Graphics context uses stroke style from previous renderings 2013-05-10 15:30:24 -0700 1 1 1 Unclassified WebKit Layout and Rendering 528+ (Nightly build) Unspecified Unspecified RESOLVED WONTFIX P2 Normal --- 96408 100546 93509 1 bruno.abinader bruno.abinader darin eric ktf.kim laszlo.gombos ojan.autocc schenney webkit.review.bot oldest_to_newest 788549 0 178827 bruno.abinader 2012-12-11 10:11:44 -0800 Created attachment 178827 Layout test results (before) While implementing a fix for bug 96408, I discovered that Skia wasn't properly resetting the graphics context, in special the stroke style/pattern, and thus using the one from last stroke style set. Please see attached the screenshots of fast/css3-text/css3-text-decoration/text-decoration-style.html layout test results before and after the fix proposed for this bug. You can notice the Ahem font character boundaries gets the text decoration stroke style when using "dashed" and "dotted" styles. 788551 1 178828 bruno.abinader 2012-12-11 10:12:19 -0800 Created attachment 178828 Layout test results (after) 788561 2 178830 bruno.abinader 2012-12-11 10:18:27 -0800 Created attachment 178830 Patch Proposed patch. 788569 3 178830 eflews.bot 2012-12-11 10:24:16 -0800 Comment on attachment 178830 Patch Attachment 178830 did not pass efl-ews (efl): Output: http://queues.webkit.org/results/15257744 788573 4 178831 bruno.abinader 2012-12-11 10:27:42 -0800 Created attachment 178831 Patch Proposed patch (2) - removes a variable that gets unused after changes. 788580 5 bruno.abinader 2012-12-11 10:32:37 -0800 Note for reviewers: I am not certain whether make the graphics context save and then later restore its state for all platforms or just for Skia, as this _might_ affect overall performance (I have no reason to state that paintDecoration function can act as a bottleneck). Also, I am not a Skia specialist so there might be a clever solution for this. Thoughts? 792728 6 bruno.abinader 2012-12-17 08:02:50 -0800 Just found out the same issue happens on Cairo/EFL port, so the "general" approach seems more proper (as seen on screenshots from bug 94110). 807765 7 178831 darin 2013-01-15 15:46:26 -0800 Comment on attachment 178831 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=178831&action=review > Source/WebCore/rendering/InlineTextBox.cpp:969 > + // FIXME: This fixes a rendering issue in Skia - rect drawing uses stroke style from previous > + // rendering artifact. > + context->save(); Doesn’t make sense that this is Skia-specific. It’s the job of the GraphicsContext class to abstract things like this and make them work the same across multiple graphics systems. If it works on other platforms and is broken on Skia, it’s likely a bug in the GraphicsContext implementation, not something that should require changing this code. Doing a save/restore every time we paint a decoration on an inline text box will likely be a measurable performance regression, so we only want to make that change if we absolutely have to. This bug needs further investigation. 807768 8 darin 2013-01-15 15:47:21 -0800 I understand that both Skia and Cairo show this bug, but we need to find out if the Mac platform using CG shows it, and if not, why not. There is probably a more efficient way to fix this than adding an unconditional save/restore. 808285 9 bruno.abinader 2013-01-16 05:05:07 -0800 (In reply to comment #8) > I understand that both Skia and Cairo show this bug, but we need to find out if the Mac platform using CG shows it, and if not, why not. There is probably a more efficient way to fix this than adding an unconditional save/restore. Agreed, Darin, I understand this could reduce overall performance, however I am curious whether we go for a platform-specific approach or a platform-agnostic one, as the bug appears in more than one platform. As for the Mac tests, I do not have a Mac of my own, so I'm afraid I am unable to provide such results, anyone volunteers? :) 808441 10 darin 2013-01-16 09:45:16 -0800 (In reply to comment #9) > I am curious whether we go for a platform-specific approach or a platform-agnostic one, as the bug appears in more than one platform. It’s the job of the GraphicsContext class to provide an interface that works the same across multiple platforms. If it’s not doing that successfully, we should fix that first before we make any changes to the client code using GraphicsContext. 886309 11 bruno.abinader 2013-05-08 05:57:16 -0700 Skia-specific. 886313 12 bruno.abinader 2013-05-08 06:10:59 -0700 FYI: This issue is now handled in http://crbug.com/229579 887645 13 schenney 2013-05-10 15:30:24 -0700 It seems like a general error, not just Skia specific. I don't know why it works on Mac. As with the other calls to updateGraphcisContext in InlineTextBox, the one for if (textDecorations != TDNONE && paintInfo.phase != PaintPhaseSelection) { should also use a GraphicsContextStateSaver. The paintDecorations code scribbles all over the state and does not restore it before returning. 178827 2012-12-11 10:11:44 -0800 2012-12-11 10:11:44 -0800 Layout test results (before) text-decoration-style-before.png image/png 7235 bruno.abinader iVBORw0KGgoAAAANSUhEUgAAAyAAAAJYCAIAAAAVFBUnAAAAKXRFWHRjaGVja3N1bQBiMjY0NzU0 OTYzYTZhMzMxM2ExZDEwZTk0NDA2NTExYjfVckMAABvVSURBVHic7d3tddvY1QZQ0HEB04E4jYRU A2nBaiEFZEhOCkgHWXY6SAoYARUkFURkB1OB8f7ACl+NE8ngvUeEDu/eP7g04Bxc8AAkH4P4WI3j 2AEAEOfD0gsAAHBrBCwAgGACFgBAMAELACCYgAUAEEzAAgAIJmABAAT7+NITq9XqmssBAJDOS9cT tQcLACCYgAUAEEzAAgAIJmABAAR78SD3b7gnNADAzLMA7cECAAgmYAEABBOwAACCCVgAAMEELACA YAIWAEAwAQsAIJiABQAQbO6FRl/R9/0wDGW1x+Ox67r1et1Ibdd1m81mu90WFNb0ealxW+tzxm0y Y5+XGre1PmfcJjP2ealxM/Y5l5iA1fd9WbMeHx+7rnt4eGiktu/7cRyL30jFfV5q3KR9PhwOBYXw dna7XTvv36SfGz6fZ6p5vbkEBKyu67bb7X6/Lyjs+77runZqy6rOivu81LhJ+7zb7crmMH1kTEve Qu3UpZp1lKt22T4XS/f+Tfq54fN5psrXm4hjsAAAgglYAADBBCwAgGACFgBAMAELACCYgAUAEEzA AgAIJmABAASLudAoAO/T4XCouTnBarVqqramVxlrF+nzbrcrHjQRAQvglrkzwUwZ7y7Q4J0JEvET IQBAMAELACCYgAUAEMwxWE04Ho/H47HsQMhhGO7u7sIXCYrZnrkltudbJWA1YXoDj+NYUPv09FRW CG/E9swtsT3fqpiA5TTgi6Q7lfd0OqXrcyOnATdrvV6XnYtUdt4TvCnb802KCVhOA56ptdNxnQYM QJtiAtYwDGV7R06nU1e6ZyVj7TAMm82moPBcnuv16vNt1+rzdWr1+Tq1+nyd2so+JxIQsKY9DWU/ A09dbqp2alcBfb6oVp+vU6vP16nV5+vU6vN1aov7nMvqpQZ9c+yLw+gAAGYGJNfBAgAIJmABAAQT sAAAgglYAADBBCwAgGACFgBAMAELACCYgAUAEGzuldxr7tcLANAUe7AAAIIJWAAAwQQsAIBgAhYA QLDVS3eBBgCgjD1YAADBBCwAgGACFgBAMAELACCYgAUAEEzAAgAIJmABAAQTsAAAgglYAADBBCwA gGACFgBAMAELACCYgAUAEEzAAgAIJmABAAQTsAAAgglYAADBBCwAgGACFgBAsI8vPbFara65HAAA 6Yzj+D+n24MFABDsxT1Yk5dyGQBAy17/re87Aeu79QAArfnuHig/EQIABPv+HqyJ3woBAGb+smcP FgBAMAELACCYgAUAEEzAAgAIJmABAAQTsAAAgglYAADB5l4HC9rh7gW8N65ECOmsXnrfTt8x4zie /3hpFn3fD8NQNvzxeOy6br1eN1Lbdd1ms9lutwWFNX1eatzW+pxxm8zY56XGba3PGbfJjH1eatyM fX4nZgakgD1Yfd/3fV/WrMfHx67rHh4eGqnt+34cx+I3UnGflxo3aZ8Ph0NBIbyd3W7Xzvs36eeG z+eZal5vLjE/EW632/1+X1DY933Xde3UllWdFfd5qXGT9nm325XNYfrImJa8hdqpSzXrKFftsn0u lu79m/Rzw+fzTJWvNxEHuQMABBOwAACCCVgAAMEELACAYAIWAEAwAQsAIJiABQAQTMACAAjmXoQA t+xwONTcnKDm1pwZa2t6lbF2kT7vdrviQRMRsABumTsTzJTx7gIN3pkgEQEL4JbZg3WRjHuh0q1f e7AASM8erJky7oWyB+s9c5A7AEAwe7CacDwej8dj2W7kYRju7u7CFwmK2Z65JbbnWyVgNWF6A4/j WFD79PRUVghvxPbMLbE936qYgOUgyoukOxDydDql63MjB1E2a71elx3JUXbUCLwp2/NNiglYDqKc qbWDGR1ECUCb7MFaoLap03GXqq3ZgzUMQ1mfT6dTV7qOMtYOw7DZbAoKz+W5Xq8+33atPl+ntrLP iQQErGlPQ5nj8dh13Xq9bqS267rtdlvWsb7vi/cGZ+xVfZ9rCssOa5g+NZqq1efr1OrzdWr1+Tq1 NbEhkdVLDZr2HIzjeP7jqssFAPD+zAxIroMFABBMwAIACCZgAQAEE7AAAIIJWAAAwQQsAIBgAhYA QDABCwAg2Nwrudfc7QQAoCn2YAEABPv+Hiw3yQEAuMh3ApZfBgEALuUnQgCAYCu/AAIAxLIHCwAg mIAFABBMwAIACCZgAQAEE7AAAIIJWAAAwQQsAIBgAhYAQDABCwAgmIAFABBMwAIACCZgAQAEE7AA AIIJWAAAwQQsAIBgAhYAQDABCwAgmIAFABBMwAIACPbxpSdWq9VLT43jOH+AV+ZjzuZszuZszuZs zuaces4vzcoeLACAYAIWAEAwAQsAIJiABQAQbPXSwVnfHNJ10eFgAAA3aWZAsgcLACCYgAUAEEzA AgAIJmABAAQTsAAAgglYAADBBCwAgGACFgBAsI/1s+j7fhiGstrj8dh13Xq9bqS267rNZrPdbgsK a/q81LgZ+9x13Xa77fv+/Pd0TbnHx8c5U/b7/X6/PxwO03/e3993Xbfb7eZM2W6357/3+/1qter7 frvdfvjw4U9/+tN+v++6bhiG51PO/0/f99PyjON4f3+/Wq1Wq9Uvv/wyZ8p+v9/tdj///HPXddPc uq776aef5k+Zlmea8/wpNct86VjPp9zf39/f37/S1VemLNXnby5seJFpmzz/Pc1qt9vNmdJa7eXd /X8Zx83Y50RiAtb5g+BS00fVw8NDI7V934/jWBx0ivu81LgZ+3w2BaDj8XgOeXOm9H1/OBweHx+n 0cdxnLLanCnH4/F8ReDzlM1mM018fcp5ecZx/GYJvztlms95LU/LMz3OnDItzzTn+VNqlvnSsZ5P mfo8p6vvpM+Pj4+bzWba2Or991Wn50xps7ZGxnEz9vk9C7hVzpRhz0n2ItOHyHlvwc3X1vQqY23q Pj//x9nMP/b7/fmr8dLy87fvpYM+X/IrL3PNHzXLXPNH0j5/swzz1ZS3Vlsj47gZ+/xOzAxIAtZV azO+GTKu39Zeb2t9bm39tvZ6W+tza+v3BsLZzID08aX61nblAQB818yA9GLAgjbV/Luq5qivjLU1 lvr3a8b1WyPj622tz0uNm7HPuQhYEKbmw6612hoZx22tz63V1sg4bsY+X5/rYAEABBOw4Df2+33x P7Baq62RcdzW+txabY2M42bscy5+IoQwZefU5K3dJzw1vUZrfc64TWbsc2vrd6nXe30CFsAte/5d eL5a6flq2q9MKas6Tzkej9PEi6oOh8N0F4erLfPzq/wPw3A4HAruTND3/fnU/UvvMVBWVb/Mx+Nx qWWuuTNBIgIW/EbNv6synjnlrKv5kvZ5esnnWzM9v4b+61O2223/2zsTXDSf7tnZ7BeN/s2dEt56 mc9X+R+G4flV/i+9W8AUO8ruMfD8Kv8XjT4llbJlXq/XU3nBMp/7XLDMX758Kb4HWi4CFoSp+fJu rbZGxnEX7PNUPn29bbfb89zmTNnv99O36UVV439uVHVpVciUpMt8tbEWX+aHh4cWfh/sXrmS+3w1 v6duE17tt6a2plcZazP2GQDqOYsQfmO/3xcns9Zqa2Qct7U+t1ZbI+O4Gfuci58IIUzGM6cyng20 1Lit9TnjNpmxz62t33Z+YRCwmnA8Hs9n9FxqGIa7u7vwRYJi0/Z8/s/9fj8dq3s+O+yVKfDe2J5v VUzAOofZK5/qeTqd0p2eushpwNMb+OvXr8MwdF23Wq02m815eV6f8u9///vp6Sldn4s/fWr+XXU+ R6mR2ho1ff7mC6n7X/defWlKxvVbI+Prba3PtudbFbkHq+z01GnPSsGpnqfT6ddffy07PbX7z9Z5 5WWuOQ24ss9d102ZY7vdfvjw4aeffjrv0Hp9ymq1StfnpU4Drvmwa622xjcf7v+9GHOmFGitzxlf b8Y+255v1YsB65sdAK+fbDhtHwWnev7yyy/nOcyvOk/54YcfCqq22+3zXW5XXub1el22zOdu6/N3 p6zX661/YN2u+g/3dj7ief9sz+nMDEgvXqZhfsDa7/fDMJR9n33+/LnruoeHh0Zq+77fbDZlbwZ9 ni+kz3MOgPhmyhQo26l9PuVSNX2eppQt53RxxYeHB31+t6+3tT53tudsZgakgJ8In+++utT5uJ92 aov3rOjzRbWxfZ55SMTd3d16vW6ntqtQ0+fi/79y3Nb6nHGbzNjn4v+/ctyMfc4lYA8WAEAjZgYk FxoFAAgmYAEABBOwAACCCVgAAMEELACAYAIWAEAwAQsAIJiABQAQbO6V3J9fVuuii45+cz2u15mz OZuzOZuzOZuzOeed85k9WAAAwQQsAIBgAhYAQDABCwAg2Oqi47wAAPgue7AAAIIJWAAAwQQsAIBg AhYAQDABCwAgmIAFABBMwAIACCZgAQAEE7AAAIIJWAAAwQQsAIBgAhYAQDABCwAgmIAFABBMwAIA CCZgAQAEE7AAAIIJWAAAwQQsAIBgH196YrVavVI2juMr/7NnPetZz3rWs5717K0++8r/eWYPFgBA MAELACCYgAUAEEzAAgAItnrp4KzXj/YCAGjQzIBkDxYAQDABCwAg2Is/EQIAUMYeLACAYAIWAEAw AQsAIJiABQAQbO7Nnh0LDwBw1etg7ff7538fDofD4TBzSmu1NTKOm7HPXddtt9v38ziO4/39/f98 fP3Z6zz++c9/Ln7MOO4ij5Xb8/RW8jjnsUbGcTP2OYs3+YlwHMdvAt2cKW3W1sg47vvv83a73W63 x+Ox67pLH//1r3/t9/vw2nEcX3/85z//OdV+9/+MrZ0eHx8fCx7/+te/pht3wT4Xb8/7/b74+6zv +6Zqa9T0ealxM/Y5mfEFM/+3cRx3u91ut3vlf1AbIuO4Gft8Hr3gcbPZnBdb7ds9Zhy3vna8uvMC q31TGcfN2OdAMwNSwL0Ia3b6TT+C9H3fSG1NrzLW6vNt19bIOG5rfW6ttkbGcTP2+Z2YGZA+vlT/ SqKCG9bsR0aB+g/oXOMupbXXuxTb83XcQDibGZBeDFjz1bRp2kvRTm2NpTbHjOu3xg28+a8m45dK xvXb2utdiu35OnItbY2AgFWjfsNqp7ZGxnEz1rYm45dKxvXb2utdiu35OjKGwjILByx4b9p589fL +KWScf229nqXYnu+jlxLWyPsJ8KaDaud2hoZx83bZ+bI+KWScf229nqXYnu+joyhsMyLAes6V3Iv O0csb23GkFQjY5/befPXy/ilknH9tvZ6l2J7vo5cS/s/XfVK7nAz9vv9Dbz/r6OmVxlrl1L/eqfb G1z6OP0j5+Zrx2fX99/tdvPvBzDNYfr7d7/73UW139xXoLi2ZtxhGAqq6mvv7+/TvQfLBASsmjf/ dNXsdmprLPXFkHH91sj4BbyUjCEp4/qtfw8+Pj52XXfp43QF+ZuvHf9zlf/VarXb7S66N8B5DtMd AsruLlAw7vjbOxOU1Z57deXa1WqV7j1YxlmEaWprZBw3Y21rMv4sknH91rzeaY/OVHvpfTDX63VB VbraDx8+/P73v//w4cPXr19//vnn6e85j9Mcpr8/ffo05eCZtc8fLx33+WPNuHd3d6vVqmzcmtqv X79m/HdOgYArucMtqf/ybqe2RsZxW+tza7U1Mo6bsc/vxPWu5J5xBWfcsDKOm7fPzFG/fnONu5TW Xu9SbM/XcQPhbGZAWvgnwoxnAjqLcL6Mfb6BN//VZPxSybh+W3u9S7E9X0eupa3hLMImHI/H53ll v98fDofpFJj5Uxqx3+/bef9XqulVfe3zr5b5j13Cz/el+twa2/N1tLNNhp1F+PyE1fmPq9Vqs9mU neqZsbbm1NbK03Gfnp6eT+n7/uvXr3Om1Iy7YJ8rt+f690ULMn7x932fbv1m7HNGGfvc2vacS0zA mk4x7S4/abPm9NTWamseu657eHg4T9ntdt8syZwpiXpVcxpwO2/+est+IZX9i3+pm4jXyPjFn5Ht +Tra2SZfPAZr/lmEz1d22UmbHt/6calTiBd8LH5LPN+eeV1Nl/R5Pn2+Dn2+jhvo0vWu5L7f7+/v 76fxzo07HA5zpgzD0FTt8ymXPnZdVzlu2XIej8cvX75k7HOZ83zKVtPzyw7dfO3ktW6+TJ/nP+rz dWr1+Tq1NX3OJSBgbbfbzWbzTYIbx3HOlLu7u6ZqX9kR+F01fT5PKVjOjOu3ps819vt98R77pLWL fFAm7ZU+v/9afb5ObSMBy4VGAQDmcrNnAIBlvLgHCwCAMvZgAQAEE7AAAIIJWAAAwQQsAIBgH196 wmUaAAC+4TINAADLeHEP1jdez2ue9axnPetZz3rWs408O4c9WAAAwQQsAIBgAhYAQDABCwAgmHsR AgAEswcLACCYgAUAEEzAAgAIJmABAAQTsAAAgglYAADBBCwAgGACFgBAMAELACCYgAUAEEzAAgAI JmABAAQTsAAAgglYAADBBCwAgGACFgBAMAELACCYgAUAEEzAAgAIJmABAAQTsAAAgglYAADBBCwA gGACFgBAMAELACCYgAUAEEzAAgAIJmABAAT7WFy5Z7aaNZRx3KWUvdK//OUv//jHP8pqf/31167r fvjhh0Zqu667u7tbr9cFhcfj8XQ6lQ261LgL9vkPf/jDH//4x4LCvu+HYSgb9Hg8dl1X3Od0tV3X bTab7XZbUFjT56XGzdjn1EoCVvE3Wdd1fd8Xl2esrbHIoJXjZuzz3//+95oPSngL4zgWB6y+78u+ zB4fH7uue3h4aKS27/txHIuDTnGflxo3Y59TW43jeM3xpm/Qsu/R1mprZBx3qdpPnz6dTqeyN//n z5+70g+djLV933ddV/zFkK52wT7f3d19+fKloLbmvTB1aepYC7UZP68yrt+lvo8WV74Hq8FmFajp Uv2b8PrjLqVmaX/88ccff/yxbA7Tx007tRm/VGpql+0zkNq1fyJsTcaQlHH9ZgyFANwwe7DeVsaQ lHH95lpaAG6ePVhvK2NIyrh+M4ZCAG6YPVhvK2NIyrh+cy0tADfPHqy3lTEkZVy/GUMhADfMHqy3 lTEkZVy/uZYWgJtnD9bbyhiSMq7fjKEQ3sLT09PpdCp7L0xX626nNuOlUmpqF+zz3d1dQWF29mC9 rYwhKeP6zbW08HZOp9MwDDU3JzgcDk3V1vQqY+0ifd5sNsWD5mUP1tvKGJIyrt+MoRDewt3dXfF9 3zLeXcCdCeZb9s4EBYXZ2YP1tjKGpIzrN9fSwttxZ4L56j9jc9W6M8GV2YP1tjKGpIzrN2MoBOCG 2YP1tjKGpIzrN9fSAnDz7MF6W8uGpOmPS1UOvYiki81Mx+PxeDyWHWA7DEObx3/wbtmeG1ESsD59 +nQ6nWoO0Mv1+3FN7aRm3Jo+T0P3fX/R4+fPn/u+z7V+u1bPUmnE9IU0jmNB7dPTU1khvBHbcyNK AtZ6vf7b3/6W8fTUpWprVI47lV/6OJ3pvcgyF9duNpv7+/vicXnn1ut1TXCHd8X23IKSgHU8HotP A854amtNbY2Mr3fBPtuDBcD7URKwvnz5UnBkz2S73U6/QzVSO3VsX/qzV9mglcucsbbrumEYivdg DcNQdjzE6XTqSi++l7F2GIaaIKvPM+nzdWr1+Tq1lX3OqyRg1Th/HbZTW1ZYKWmvFunztM+s7LCG 6VOjqdriXYz6fFGtPl+nVp+vU3v9n4Deg5XD5QAAYn1YegEAAG6NgAUAEEzAAgAIJmABAAQTsAAA gglYAADBBCwAgGACFgBAMAELACCYgAUAEEzAAgAIJmABAAQTsAAAgglYAADBBCwAgGACFgBAMAEL ACCYgAUAEEzAAgAIJmABAAQTsAAAgglYAADBBCwAgGACFgBAMAELACCYgAUAEEzAAgAIJmABAAQT sAAAgglYAADBBCwAgGACFgBAMAELACCYgAUAEEzAAgAIJmABAAQTsAAAgglYAADBBCwAgGACFgBA MAELACCYgAUAEEzAAgAIJmABAAQTsAAAgglYAADBBCwAgGACFgBAMAELACCYgAUAEEzAAgAIJmAB AAQTsAAAgglYAADBBCwAgGACFgBAMAELACCYgAUAEEzAAgAIJmABAAQTsAAAgglYAADBBCwAgGAC FgBAMAELACCYgAUAEEzAAgAIJmABAAQTsAAAgglYAADBBCwAgGACFgBAMAELACCYgAUAEEzAAgAI JmABAAQTsAAAgglYAADBBCwAgGACFgBAMAELACCYgAUAEEzAAgAIJmABAAQTsAAAgglYAADBBCwA gGACFgBAMAELACCYgAUAEEzAAgAIJmABAAQTsAAAgglYAADBBCwAgGACFgBAMAELACCYgAUAEEzA AgAIJmABAAQTsAAAgglYAADBBCwAgGACFgBAMAELACCYgAUAEEzAAgAIJmABAAQTsAAAgglYAADB BCwAgGACFgBAMAELACCYgAUAEEzAAgAIJmABAAQTsAAAgglYAADBBCwAgGACFgBAMAELACCYgAUA EEzAAgAIJmABAAQTsAAAgglYAADBBCwAgGACFgBAMAELACCYgAUAEEzAAgAIJmABAAQTsAAAgglY AADBBCwAgGACFgBAMAELACCYgAUAEEzAAgAIJmABAAQTsAAAgglYAADBBCwAgGACFgBAMAELACCY gAUAEEzAAgAIJmABAAQTsAAAgglYAADBBCwAgGACFgBAMAELACCYgAUAEEzAAgAIJmABAAQTsAAA gglYAADBBCwAgGACFgBAMAELACCYgAUAEEzAAgAIJmABAAQTsAAAgglYAADBBCwAgGACFgBAMAEL ACCYgAUAEEzAAgAIJmABAAQTsAAAgglYAADBBCwAgGACFgBAMAELACCYgAUAEEzAAgAIJmABAAQT sAAAgglYAADBBCwAgGACFgBAMAELACCYgAUAEEzAAgAIJmABAAQTsAAAgglYAADBBCwAgGACFgBA MAELACCYgAUAEEzAAgAIJmABAAQTsAAAgglYAADBBCwAgGACFgBAMAELACCYgAUAEEzAAgAIJmAB AAQTsAAAgglYAADBBCwAgGACFgBAMAELACCYgAUAEEzAAgAIJmABAAQTsAAAgglYAADBBCwAgGAC FgBAMAELACCYgAUAEEzAAgAIJmABAAQTsAAAgglYAADBBCwAgGACFgBAMAELACCYgAUAEEzAAgAI JmABAAQTsAAAgglYAADBBCwAgGACFgBAMAELACCYgAUAEEzAAgAIJmABAAQTsAAAgglYAADBBCwA gGACFgBAMAELACCYgAUAEEzAAgAIJmABAAQTsAAAgglYAADBBCwAgGACFgBAMAELACCYgAUAEEzA AgAIJmABAAQTsAAAgglYAADBBCwAgGACFgBAMAELACCYgAUAEEzAAgAIJmABAAQTsAAAgglYAADB BCwAgGACFgBAMAELACCYgAUAEEzAAgAIJmABAAQTsAAAgglYAADBBCwAgGACFgBAMAELACCYgAUA EEzAAgAIJmABAAQTsAAAgglYAADBBCwAgGACFgBAsP8DmJ1UVD26rUAAAAAASUVORK5CYII= 178828 2012-12-11 10:12:19 -0800 2012-12-11 10:12:19 -0800 Layout test results (after) text-decoration-style-after.png image/png 6413 bruno.abinader iVBORw0KGgoAAAANSUhEUgAAAyAAAAJYCAIAAAAVFBUnAAAAKXRFWHRjaGVja3N1bQA4NGMzYTk0 ZWNkOTFlNTA0OWFmNTNjMjg5M2RjMDAxZR4J1gsAABifSURBVHic7d1Pcuto+TZg+fx6AVkB8dkA dYaM2l4BbCFVrIA53YmBOUvg9A6gF4ClLsZwRjDDcm+gw4xR6xuoPlfqNMmRX9/Hzmtd18CVkvNI 8mNZufNafxbDMDQAAOS8ufQKAABcGwELACBMwAIACBOwAADCBCwAgDABCwAgTMACAAj74rknFovF OdcDAKA6z11P1AgWAECYgAUAECZgAQCECVgAAGHPHuT+EfeEBgCYeBagESwAgDABCwAgTMACAAgT sAAAwgQsAIAwAQsAIEzAAgAIE7AAAMKmXmj0BW3bdl1XVtv3fdM0y+VyJrVN06xWq/V6XVB4Sp8v tdy59bnGbbLGPl9quXPrc43bZI19vtRya+xzXTIBq23bsmZtt9umae7u7mZS27btMAzFH6TiPl9q uZX2ebPZFBTC53N/fz+fz2+l+w3754lOeb11CQSspmnW6/XDw0NBYdu2TdPMp7as6qC4z5dabqV9 vr+/L5vDuMsY13wOtWOXTnmP6qq9bJ+LVff5rXS/Yf880YmvtyKOwQIACBOwAADCBCwAgDABCwAg TMACAAgTsAAAwgQsAIAwAQsAICxzoVEAXqfNZnPKzQkWi8Wsak/pVY21F+nz/f198UIrImABXDN3 JpioxrsLzPDOBBXxFSEAQJiABQAQJmABAIQ5BmsW+r7v+77sQMiu625vb+OrBMVsz1wT2/O1ErBm YfwAD8NQULvb7coK4TOxPXNNbM/XKhOwnAZ8lOpO5d3v99X1eSanAc/WcrksOxep7Lwn+Kxsz1cp E7CcBjzR3E7HdRowAPOUCVhd15WNjuz3+6Z0ZKXG2q7rVqtVQeGhvK7Xq8/XXavP56nV5/PU6vN5 ak/sc0UCAWscaSj7Gnjs8qxqx3YV0OejavX5PLX6fJ5afT5PrT6fp7a4z3VZPNegj459cRgdAMDE gOQ6WAAAYQIWAECYgAUAECZgAQCECVgAAGECFgBAmIAFABAmYAEAhE29kvsp9+sFAJgVI1gAAGEC FgBAmIAFABAmYAEAhC2euws0AABljGABAIQJWAAAYQIWAECYgAUAECZgAQCECVgAAGECFgBAmIAF ABAmYAEAhAlYAABhAhYAQJiABQAQJmABAIQJWAAAYQIWAECYgAUAECZgAQCECVgAAGECFgBA2BfP PbFYLM65HgAA1RmG4X9ON4IFABD27AjW6LlcBgAwZy9/1/eJgPXJegCAufnkCJSvCAEAwj49gjXy XSEAwMRv9oxgAQCECVgAAGECFgBAmIAFABAmYAEAhAlYAABhAhYAQNjU62DBfLh7Aa+NKxFCdRbP fW7HvzHDMBx+eG4Wbdt2XVe2+L7vm6ZZLpczqW2aZrVardfrgsJT+nyp5c6tzzVukzX2+VLLnVuf a9wma+zzpZZbY59fiYkBKTCC1bZt27Zlzdput03T3N3dzaS2bdthGIo/SMV9vtRyK+3zZrMpKITP 5/7+fj6f30r3G/bPE53yeuuS+YpwvV4/PDwUFLZt2zTNfGrLqg6K+3yp5Vba5/v7+7I5jLuMcc3n UDt26ZT3qK7ay/a5WHWf30r3G/bPE534eiviIHcAgDABCwAgTMACAAgTsAAAwgQsAIAwAQsAIEzA AgAIE7AAAMLcixDgmm02m1NuTnDKrTlrrD2lVzXWXqTP9/f3xQutiIAFcM3cmWCiGu8uMMM7E1RE wAK4ZkawjlLjKFR1768RLACqZwRrohpHoYxgvWYOcgcACDOCNQt93/d9XzaM3HXd7e1tfJWgmO2Z a2J7vlYC1iyMH+BhGApqd7tdWSF8JrZnront+VplApaDKI9S3YGQ+/2+uj7P5CDK2Voul2VHcpQd NQKfle35KmUCloMoJ5rbwYwOogRgnoxgXaB2VqfjXqr2lBGsruvK+rzf75vS96jG2q7rVqtVQeGh vK7Xq8/XXavP56k9sc8VCQSscaShTN/3TdMsl8uZ1DZNs16vyzrWtm3xaHCNvTq9z6cUlh3WMO41 ZlWrz+ep1efz1OrzeWpPiQ0VWTzXoHHkYBiGww9nXS8AgNdnYkByHSwAgDABCwAgTMACAAgTsAAA wgQsAIAwAQsAIEzAAgAIE7AAAMKmXsn9lLudAADMihEsAICwT49guUkOAMBRPhGwfDMIAHAsXxEC AIQtfAMIAJBlBAsAIEzAAgAIE7AAAMIELACAMAELACBMwAIACBOwAADCBCwAgDABCwAgTMACAAgT sAAAwgQsAIAwAQsAIEzAAgAIE7AAAMIELACAMAELACBMwAIACBOwAADCvnjuicVi8dxTwzBMX8AL 8zFnczZnczZnczZnc656zs/NyggWAECYgAUAECZgAQCECVgAAGGL5w7O+uiQrqMOBwMAuEoTA5IR LACAMAELACBMwAIACBOwAADCBCwAgDABCwAgTMACAAgTsAAAwr44fRZt23ZdV1bb933TNMvlcia1 TdOsVqv1el1QeEqfL7XcSvu82WwOtW3bjj9MmTKu7XK5PKpqnNL3/YcPH25ubn76O4vFYrVaNU0z DMP4XhymjL/z+Pi4WCx+9atf/c/feXnK7e1t0zS3t7dHVR2m7Pf75XL55s2br776apzyu9/9rmma T07p+36/3x+1rKdTRhOX9XTKdrsdpxz7Sruuu2Cf1+v1fD6/le437J+nK369dckErLZty5q13W6b prm7u5tJbdu2476yrLa4z5dabqV93u12q9VqDDd93487kWEYPjllu90+Pj6+e/fuqKpxyocPH/77 3//+4he/OKpqnPL4+FhQdfo6jzvZu7u78ULGm81mnL5erz85ZZzbl19+WbbO2+12vV5PXNbTKdvt 9sOHD+/evauozx8+fBg/hj/ZWj+txs9vpfsN++eJTnm9dQkErKZp1uv1w8NDQeG4y5hPbVnVQXGf L7XcSvt8d3f38PBwmMn0H9brdd/3447j2PIxrBz+iB5VfujVmdf5o/doDDFPt5YXphxmUrDOh0VP XNZHU969e1dXn5snHStQ3ee30v2G/fNEJ77eimQCFlyfn+4FpkxZLpcfTZw4n4/GJ45a+tO8Mr3q oHidy6qe++Go+fz0j8oZ1vmV9BmowrMBy92dAQA+MjEgOYsQACBMwAIACBOwAADCBCwAgDABCwAg zGUaAK7Z0yuAbDab8Yf7+/tPTimrOkzp+36ceFTVZrMZrwl3tnV+et3/rus2m03BnQnatl0sFuNs p1eNU8qqTl/nvu8vtc6H5V43AQvg+o1hYrwC/vQpY0g6tmoMSY+Pj4ez2Y9a+pnX+XCV/67r+r4f hqHszgSHOU+vOkwZ51BwZ4IT17mg6jBl7HPBOn/zzTfF99ipi4AFcM3GVHHUdfafXj5+vKvJ9KrD lJubm4Kq8Q5IBVWRdX56MdiCOxOUrfPTK9mec51P6fNf//rX4nVeLpdPO3bFBCyA63fmq8+7M8FR 83FngqvkIHcAgDABCwAgzFeEs9D3/eGMnmN1XXd7extfJShme+aa2J6vVSZgPT1W7pyneu73++pO T73IacDjB/jHH3/suq5pmsVisVqtDuvz8pR///vfu92uuj7P5DTgeRq358MZakfZ7XZlhfCZ2J6v VXIE68yneu73+/E04IpOT73gacBN04yZY71ev3nz5uuvvz78w/TylMViUV2f53Ma8Gz99ADbiT46 +BpeA9vzVXo2YH00APByRj6cGduc8VTP5kKnAZ+4zhc5DXhufZ7PacAAnNnEgLR49onJAevh4aHr urK/Z+/fv2+a5u7ubia1bduuVquy/1T0eTp9Pk+tPp+nVp/PU6vP56k9pc+vxMSAFPiK8Onw1bEO x/3Mp7Z4ZEWfj6rV5/PU6vN5avX5PLX6fJ7amXzDEBjBAgCYiYkByXWwAADCBCwAgDABCwAgTMAC AAgTsAAAwgQsAIAwAQsAIEzAAgAIm3ol96eX1TrqoqMfXY/rZeZszuZszuZszuZszvXO+cAIFgBA mIAFABAmYAEAhAlYAABhi6OO8wIA4JOMYAEAhAlYAABhAhYAQJiABQAQJmABAIQJWAAAYQIWAECY gAUAECZgAQCECVgAAGECFgBAmIAFABAmYAEAhAlYAABhAhYAQJiABQAQJmABAIQJWAAAYQIWAEDY F889sVgsXigbhuGFX/asZz3rWc961rOevdZnX/jNAyNYAABhAhYAQJiABQAQJmABAIQtnjs46+Wj vQAAZmhiQDKCBQAQJmABAIQ9+xUhAABljGABAIQJWAAAYQIWAECYgAUAEDb1Zs+OhQcAmBiQng1Y 07Vt23VdWW3f903TLJfLmdQ2TbNardbrdUHhKX2+1HLr7XPbtuv1+tjHP//5z+/evev7Plu7Wq2+ ++67L7/88qePXdetVqtvv/325z//+ffff/8/f+flx1Nqv/vuu6+++upvf/vbb3/72z/84Q9HPf76 17/+2c9+VrDECy73gn3++uuv5/P5rXe/UbbQSy23xj7XJfAVYdu22+12KLLdbudW27btRfp8qeVW 1+eHh4c//elPu91uGIZjH//1r39tt9vz1/7zn/+8SO3f//73w+ZR8Fjdci/b51l9fqvbb9g/H1Vb /HrrEhjBappmvV4/PDwUFI5dnk9tWdVBcZ8vtdwa+3z4v2qcyVGP79+/Xy6Xh3YFaxeLxQuP33zz zaH25d/M1nZdt1gsvvzyyzdv3hz7eHt7O7a6ouVesM/F23NT4ee3xv1GY/882YmvtyKBexE+/Utw rHFPVxZma6w9pVc11s6tzzVukzX2eW7v79xe79z6PLf395R1fiVOPQbrhUQFADBPEwOSyzQAAIQJ WAAAYQIWAECYgAUAEOZK7gAAU00MSEawAK7cZrMpeByv1n31tcMw/P73vx+Goeu6w89THsc5lNU+ fbxU7X6/v0jtidd1q4iABXC12rYdL/bdNM2xj4+PjwVV1dUO//8q/2M4O+quAIffL6g9ZbmR2h9+ +OEiteM6z0HmSu4AvEJP7/g2/jz98ebmpqCqutqnV/k/6g4B4xzKaj+6u8BFam9ubi5Se3t7+6nN 9kq4kvtZa2u82m+N7+/cXu/c+jy393dur3dufZ7b++tK7o5qBwD42MSA5BgsAIAwx2DNQt/3fd+P 57wcq+u6+XxlThVsz1wT2/O1io1gPT1h9fWfJnrB01MvVbvb7dq2/fHHH499/Mc//rHb7arrc2rD 5hUa/yANRXa73XxOYqIKtudrFQhYH50GPNRwmuhlT089f+0PP/ywXC4Xi8X9/f2xj+O7XGOfuWLL 5fKhyHK5vPS6w8dsz1cpcCX3p6cB13Ka6AVPT53V6bhOAwbgykwMSJnLNHRd9zRmTff+/fumae7u 7mZS27btarUqPh1XnyfS5/PU6vN5avX5PLX6fJ7aU/r8Spx6mYbpxk3qhQT2gtVqNbfask9go89H 1urzeWr1+Ty1+nyeWn0+T21xn+sSGMECAJgJN3sGALiMZ0ewAAAoYwQLACBMwAIACBOwAADCBCwA gLDAldwBAGbCZRoAAC5j6pXcX85rnvWsZz3rWc961rMzeXYKI1gAAGECFgBAmIAFABAmYAEAhLkX IQBAmBEsAIAwAQsAIEzAAgAIE7AAAMIELACAMAELACBMwAIACBOwAADCBCwAgDABCwAgTMACAAgT sAAAwgQsAIAwAQsAIEzAAgAIE7AAAMIELACAMAELACBMwAIACBOwAADCBCwAgDABCwAgTMACAAgT sAAAwgQsAIAwAQsAIEzAAgAIE7AAAMK+KKhp27brurLl9X3fNM1yuZxJbdM0q9VqvV4XFJ7S50st t8Y+//GPf/z222/LFvr4+Ng0zc3NzUxqm6a5vb0tfn/3+33ZQi+13Av2+Ze//OVvfvObgsIaP781 7jfsn49S/HqrVhiw2rYta9Z2u22a5u7ubia1bdsOw1D8QSru86WWW2Of//KXv5yyo4TPYRiG4oBV 3ee3xv2G/fN0p7zeqpUErKZp1uv1w8NDQWHbtk3TzKe2rOqguM+XWm6Nfb69vS3+7+r9+/dN6U6n xtrxPSr+w1Bd7QX7fHt7W1A4qu7zW+N+o7F/nuzE11uvwoAFV+Pt27dv376ta4d12R3lfGr9QQKK OcgdACBMwAIACBOwAADCBCwAgDABCwAgTMACAAhzmQaA67Hb7fb7fdmFHsardc+ntsZLpZxSe8E+ n3Jdt3oJWADXY7/fd113ys0JNpvNrGpP6VWNtRfp82q1Kl5ovQQsgOvhzgTT1Xh3gRnemaBeAhbA 9XBngulqvLuAOxNUxEHuAABhAhYAQJivCK9T3/d935cdkNh13Ty/L+fVsj1zTWzPM1ESsJwGPN0F j0t4fHwsKGya5sOHD7vdrro+2+lcsfEP0jAMBbW73a6sED4T2/NMlAQspwEfq7pTef/zn/9U1+d5 ngY8H8vl8pR/VOBVsT3PQUnAchrwdHM7HddpwADQlAWst2/ffv/994vFoqB2rJpV7Wq1Kj61teu6 6l7vpWrfvn1bUDjquq5s5Gy/3zelo2411nZdd8pIoT5PpM/nqdXn89Se2Od6/d+ZL1Bxc3OzXC5v bm5mUrtcLtfr9XK5LKg9RY290ufXX6vP56nV5/PU6vN5ai/V54tbOFwOACDLdbAAAMIELACAMAEL ACBMwAIACBOwAADCBCwAgDABCwAgTMACAAgTsAAAwgQsAIAwAQsAIEzAAgAIE7AAAMIELACAMAEL ACBMwAIACBOwAADCBCwAgDABCwAgTMACAAgTsAAAwgQsAIAwAQsAIEzAAgAIE7AAAMIELACAMAEL ACBMwAIACBOwAADCBCwAgDABCwAgTMACAAgTsAAAwgQsAIAwAQsAIEzAAgAIE7AAAMIELACAMAEL ACBMwAIACBOwAADCBCwAgDABCwAgTMACAAgTsAAAwgQsAIAwAQsAIEzAAgAIE7AAAMIELACAMAEL ACBMwAIACBOwAADCBCwAgDABCwAgTMACAAgTsAAAwgQsAIAwAQsAIEzAAgAIE7AAAMIELACAMAEL ACBMwAIACBOwAADCBCwAgDABCwAgTMACAAgTsAAAwgQsAIAwAQsAIEzAAgAIE7AAAMIELACAMAEL ACBMwAIACBOwAADCBCwAgDABCwAgTMACAAgTsAAAwgQsAIAwAQsAIEzAAgAIE7AAAMIELACAMAEL ACBMwAIACBOwAADCBCwAgDABCwAgTMACAAgTsAAAwgQsAIAwAQsAIEzAAgAIE7AAAMIELACAMAEL ACBMwAIACBOwAADCBCwAgDABCwAgTMACAAgTsAAAwgQsAIAwAQsAIEzAAgAIE7AAAMIELACAMAEL ACBMwAIACBOwAADCBCwAgDABCwAgTMACAAgTsAAAwgQsAIAwAQsAIEzAAgAIE7AAAMIELACAMAEL ACBMwAIACBOwAADCBCwAgDABCwAgTMACAAgTsAAAwgQsAIAwAQsAIEzAAgAIE7AAAMIELACAMAEL ACBMwAIACBOwAADCBCwAgDABCwAgTMACAAgTsAAAwgQsAIAwAQsAIEzAAgAIE7AAAMIELACAMAEL ACBMwAIACBOwAADCBCwAgDABCwAgTMACAAgTsAAAwgQsAIAwAQsAIEzAAgAIE7AAAMIELACAMAEL ACBMwAIACBOwAADCBCwAgDABCwAgTMACAAgTsAAAwgQsAIAwAQsAIEzAAgAIE7AAAMIELACAMAEL ACBMwAIACBOwAADCBCwAgDABCwAgTMACAAgTsAAAwgQsAIAwAQsAIEzAAgAIE7AAAMIELACAMAEL ACBMwAIACBOwAADCBCwAgDABCwAgTMACAAgTsAAAwgQsAIAwAQsAIEzAAgAIE7AAAMIELACAMAEL ACBMwAIACBOwAADCBCwAgDABCwAgTMACAAgTsAAAwgQsAIAwAQsAIEzAAgAIE7AAAMIELACAMAEL ACBMwAIACBOwAADCBCwAgDABCwAgTMACAAgTsAAAwgQsAIAwAQsAIEzAAgAIE7AAAMIELACAMAEL ACBMwAIACBOwAADCBCwAgDABCwAgTMACAAgTsAAAwgQsAIAwAQsAIEzAAgAIE7AAAMIELACAMAEL ACBMwAIACBOwAADCBCwAgDABCwAgTMACAAgTsAAAwgQsAIAwAQsAIEzAAgAIE7AAAMIELACAMAEL ACBMwAIACBOwAADCBCwAgDABCwAgTMACAAgTsAAAwgQsAIAwAQsAIEzAAgAIE7AAAMIELACAMAEL ACBMwAIACBOwAADCBCwAgDABCwAgTMACAAgTsAAAwgQsAIAwAQsAIEzAAgAIE7AAAMIELACAMAEL ACBMwAIACBOwAADCBCwAgDABCwAgTMACAAgTsAAAwgQsAIAwAQsAIEzAAgAIE7AAAMIELACAMAEL ACBMwAIACPt/zBy3APlCQMoAAAAASUVORK5CYII= 178830 2012-12-11 10:18:27 -0800 2012-12-11 10:27:37 -0800 Patch bug-104682-20121211141548.patch text/plain 3218 bruno.abinader U3VidmVyc2lvbiBSZXZpc2lvbjogMTM3MzE1CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggNDM4YTQxZjYwNWY1NzBi NTU4ZjYzNTM1MTU4ZjllODFkMzk1MGQzZi4uNDdmNTlhNjY4ZWQyZGY2NzI4NDVhMjI5NGM3NDUw MDcwZGFjYzI1YiAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDIyIEBACisyMDEyLTEyLTExICBCcnVu byBkZSBPbGl2ZWlyYSBBYmluYWRlciAgPGJydW5vLmFiaW5hZGVyQGJhc3lza29tLmNvbT4KKwor ICAgICAgICBbU2tpYV0gR3JhcGhpY3MgY29udGV4dCB1c2VzIHN0cm9rZSBzdHlsZSBmcm9tIHBy ZXZpb3VzIHJlbmRlcmluZ3MKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19i dWcuY2dpP2lkPTEwNDY4MgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgor CisgICAgICAgIEZpeGVzIGFuIGlzc3VlIGluIFNraWEgd2hlcmUgdGhlIGdyYXBoaWNzIGNvbnRl eHQgd2FzIG5vdCBwcm9wZXJseSByZXNldHRpbmcKKyAgICAgICAgdGhlIHN0cm9rZSBzdHlsZSBh ZnRlciBmaW5pc2hpbmcgcmVuZGVyaW5nLCB0aHVzIHByb3BhZ2F0aW5nIHRoZSBsYXN0IHN0cm9r ZQorICAgICAgICBzdHlsZSBzZXQgdG8gbmV3ZXIgcmVuZGVyaW5ncy4gTm93IHRoZSBncmFwaGlj cyBjb250ZXh0IGlzIGFsd2F5cyBzYXZlZCBiZWZvcmUKKyAgICAgICAgc2V0dGluZyB0aGUgdGV4 dCBkZWNvcmF0aW9uIHN0cm9rZSBzdHlsZSwgYW5kIHJlc3RvcmVkIGFmdGVyIHJlbmRlcmluZy4K KworICAgICAgICBObyBuZXcgdGVzdHMuIFRoZSByZXN1bHRzIGZyb20KKyAgICAgICAgZmFzdC9j c3MzLXRleHQvY3NzMy10ZXh0LWRlY29yYXRpb24vdGV4dC1kZWNvcmF0aW9uLXN0eWxlLmh0bWwg bGF5b3V0CisgICAgICAgIHRlc3QgY29uZmlybXMgdGhlIGZpeCBmb3IgdGhpcyBpc3N1ZS4KKwor ICAgICAgICAqIHJlbmRlcmluZy9JbmxpbmVUZXh0Qm94LmNwcDoKKyAgICAgICAgKFdlYkNvcmU6 OklubGluZVRleHRCb3g6OnBhaW50RGVjb3JhdGlvbik6CisKIDIwMTItMDktMTEgIEJydW5vIGRl IE9saXZlaXJhIEFiaW5hZGVyICA8YnJ1bm8uYWJpbmFkZXJAYmFzeXNrb20uY29tPgogCiAgICAg ICAgIFtTa2lhXSBTdXBwb3J0ICJkYXNoZWQiIGFuZCAiZG90dGVkIiBzdHlsZXMgb24gdGV4dCBs aW5lIHJlbmRlcmluZwpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYkNvcmUvcmVuZGVyaW5nL0lubGlu ZVRleHRCb3guY3BwIGIvU291cmNlL1dlYkNvcmUvcmVuZGVyaW5nL0lubGluZVRleHRCb3guY3Bw CmluZGV4IDUwNjQ4ZTMwOWJmM2EwYjdiY2RmYzY4N2NhNGI1ZmVlODVkZDMzNWMuLjY4ZjJhYjhk NDc1NTc0ODU5M2JiNTY3Yzc3OGI2NzYxYjlmYzFlN2IgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJD b3JlL3JlbmRlcmluZy9JbmxpbmVUZXh0Qm94LmNwcAorKysgYi9Tb3VyY2UvV2ViQ29yZS9yZW5k ZXJpbmcvSW5saW5lVGV4dEJveC5jcHAKQEAgLTk2NCw2ICs5NjQsMTAgQEAgdm9pZCBJbmxpbmVU ZXh0Qm94OjpwYWludERlY29yYXRpb24oR3JhcGhpY3NDb250ZXh0KiBjb250ZXh0LCBjb25zdCBG bG9hdFBvaW50JgogICAgIGlmIChtX3RydW5jYXRpb24gPT0gY0Z1bGxUcnVuY2F0aW9uKQogICAg ICAgICByZXR1cm47CiAKKyAgICAvLyBGSVhNRTogVGhpcyBmaXhlcyBhIHJlbmRlcmluZyBpc3N1 ZSBpbiBTa2lhIC0gcmVjdCBkcmF3aW5nIHVzZXMgc3Ryb2tlIHN0eWxlIGZyb20gcHJldmlvdXMK KyAgICAvLyByZW5kZXJpbmcgYXJ0aWZhY3QuCisgICAgY29udGV4dC0+c2F2ZSgpOworCiAgICAg RmxvYXRQb2ludCBsb2NhbE9yaWdpbiA9IGJveE9yaWdpbjsKIAogICAgIGZsb2F0IHdpZHRoID0g bV9sb2dpY2FsV2lkdGg7CkBAIC05ODgsNyArOTkyLDYgQEAgdm9pZCBJbmxpbmVUZXh0Qm94Ojpw YWludERlY29yYXRpb24oR3JhcGhpY3NDb250ZXh0KiBjb250ZXh0LCBjb25zdCBGbG9hdFBvaW50 JgogICAgIFJlbmRlclN0eWxlKiBzdHlsZVRvVXNlID0gcmVuZGVyZXIoKS0+c3R5bGUoaXNGaXJz dExpbmVTdHlsZSgpKTsKICAgICBpbnQgYmFzZWxpbmUgPSBzdHlsZVRvVXNlLT5mb250TWV0cmlj cygpLmFzY2VudCgpOwogCi0gICAgYm9vbCBzZXRDbGlwID0gZmFsc2U7CiAgICAgaW50IGV4dHJh T2Zmc2V0ID0gMDsKICAgICBpZiAoIWxpbmVzQXJlT3BhcXVlICYmIHNoYWRvdyAmJiBzaGFkb3ct Pm5leHQoKSkgewogICAgICAgICBGbG9hdFJlY3QgY2xpcFJlY3QobG9jYWxPcmlnaW4sIEZsb2F0 U2l6ZSh3aWR0aCwgYmFzZWxpbmUgKyAyKSk7CkBAIC0xMDAxLDExICsxMDA0LDkgQEAgdm9pZCBJ bmxpbmVUZXh0Qm94OjpwYWludERlY29yYXRpb24oR3JhcGhpY3NDb250ZXh0KiBjb250ZXh0LCBj b25zdCBGbG9hdFBvaW50JgogICAgICAgICAgICAgY2xpcFJlY3QudW5pdGUoc2hhZG93UmVjdCk7 CiAgICAgICAgICAgICBleHRyYU9mZnNldCA9IG1heChleHRyYU9mZnNldCwgbWF4KDAsIHNoYWRv d1kpICsgcy0+Ymx1cigpKTsKICAgICAgICAgfQotICAgICAgICBjb250ZXh0LT5zYXZlKCk7CiAg ICAgICAgIGNvbnRleHQtPmNsaXAoY2xpcFJlY3QpOwogICAgICAgICBleHRyYU9mZnNldCArPSBi YXNlbGluZSArIDI7CiAgICAgICAgIGxvY2FsT3JpZ2luLm1vdmUoMCwgZXh0cmFPZmZzZXQpOwot ICAgICAgICBzZXRDbGlwID0gdHJ1ZTsKICAgICB9CiAKICAgICBDb2xvclNwYWNlIGNvbG9yU3Bh Y2UgPSByZW5kZXJlcigpLT5zdHlsZSgpLT5jb2xvclNwYWNlKCk7CkBAIC0xMDU3LDEwICsxMDU4 LDcgQEAgdm9pZCBJbmxpbmVUZXh0Qm94OjpwYWludERlY29yYXRpb24oR3JhcGhpY3NDb250ZXh0 KiBjb250ZXh0LCBjb25zdCBGbG9hdFBvaW50JgogICAgICAgICB9CiAgICAgfSB3aGlsZSAoc2hh ZG93KTsKIAotICAgIGlmIChzZXRDbGlwKQotICAgICAgICBjb250ZXh0LT5yZXN0b3JlKCk7Ci0g ICAgZWxzZSBpZiAoc2V0U2hhZG93KQotICAgICAgICBjb250ZXh0LT5jbGVhclNoYWRvdygpOwor ICAgIGNvbnRleHQtPnJlc3RvcmUoKTsKIH0KIAogc3RhdGljIEdyYXBoaWNzQ29udGV4dDo6RG9j dW1lbnRNYXJrZXJMaW5lU3R5bGUgbGluZVN0eWxlRm9yTWFya2VyVHlwZShEb2N1bWVudE1hcmtl cjo6TWFya2VyVHlwZSBtYXJrZXJUeXBlKQo= 178831 2012-12-11 10:27:42 -0800 2013-01-15 15:46:26 -0800 Patch bug-104682-20121211142503.patch text/plain 3731 bruno.abinader U3VidmVyc2lvbiBSZXZpc2lvbjogMTM3MzE1CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggNDM4YTQxZjYwNWY1NzBi NTU4ZjYzNTM1MTU4ZjllODFkMzk1MGQzZi4uNDdmNTlhNjY4ZWQyZGY2NzI4NDVhMjI5NGM3NDUw MDcwZGFjYzI1YiAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDIyIEBACisyMDEyLTEyLTExICBCcnVu byBkZSBPbGl2ZWlyYSBBYmluYWRlciAgPGJydW5vLmFiaW5hZGVyQGJhc3lza29tLmNvbT4KKwor ICAgICAgICBbU2tpYV0gR3JhcGhpY3MgY29udGV4dCB1c2VzIHN0cm9rZSBzdHlsZSBmcm9tIHBy ZXZpb3VzIHJlbmRlcmluZ3MKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19i dWcuY2dpP2lkPTEwNDY4MgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgor CisgICAgICAgIEZpeGVzIGFuIGlzc3VlIGluIFNraWEgd2hlcmUgdGhlIGdyYXBoaWNzIGNvbnRl eHQgd2FzIG5vdCBwcm9wZXJseSByZXNldHRpbmcKKyAgICAgICAgdGhlIHN0cm9rZSBzdHlsZSBh ZnRlciBmaW5pc2hpbmcgcmVuZGVyaW5nLCB0aHVzIHByb3BhZ2F0aW5nIHRoZSBsYXN0IHN0cm9r ZQorICAgICAgICBzdHlsZSBzZXQgdG8gbmV3ZXIgcmVuZGVyaW5ncy4gTm93IHRoZSBncmFwaGlj cyBjb250ZXh0IGlzIGFsd2F5cyBzYXZlZCBiZWZvcmUKKyAgICAgICAgc2V0dGluZyB0aGUgdGV4 dCBkZWNvcmF0aW9uIHN0cm9rZSBzdHlsZSwgYW5kIHJlc3RvcmVkIGFmdGVyIHJlbmRlcmluZy4K KworICAgICAgICBObyBuZXcgdGVzdHMuIFRoZSByZXN1bHRzIGZyb20KKyAgICAgICAgZmFzdC9j c3MzLXRleHQvY3NzMy10ZXh0LWRlY29yYXRpb24vdGV4dC1kZWNvcmF0aW9uLXN0eWxlLmh0bWwg bGF5b3V0CisgICAgICAgIHRlc3QgY29uZmlybXMgdGhlIGZpeCBmb3IgdGhpcyBpc3N1ZS4KKwor ICAgICAgICAqIHJlbmRlcmluZy9JbmxpbmVUZXh0Qm94LmNwcDoKKyAgICAgICAgKFdlYkNvcmU6 OklubGluZVRleHRCb3g6OnBhaW50RGVjb3JhdGlvbik6CisKIDIwMTItMDktMTEgIEJydW5vIGRl IE9saXZlaXJhIEFiaW5hZGVyICA8YnJ1bm8uYWJpbmFkZXJAYmFzeXNrb20uY29tPgogCiAgICAg ICAgIFtTa2lhXSBTdXBwb3J0ICJkYXNoZWQiIGFuZCAiZG90dGVkIiBzdHlsZXMgb24gdGV4dCBs aW5lIHJlbmRlcmluZwpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYkNvcmUvcmVuZGVyaW5nL0lubGlu ZVRleHRCb3guY3BwIGIvU291cmNlL1dlYkNvcmUvcmVuZGVyaW5nL0lubGluZVRleHRCb3guY3Bw CmluZGV4IDUwNjQ4ZTMwOWJmM2EwYjdiY2RmYzY4N2NhNGI1ZmVlODVkZDMzNWMuLjQyOTQzMDkx YjUwMzNmZmFmZGUzZGY4NGNhYzkyNzAzNmY3YTUyNTQgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJD b3JlL3JlbmRlcmluZy9JbmxpbmVUZXh0Qm94LmNwcAorKysgYi9Tb3VyY2UvV2ViQ29yZS9yZW5k ZXJpbmcvSW5saW5lVGV4dEJveC5jcHAKQEAgLTk2NCw2ICs5NjQsMTAgQEAgdm9pZCBJbmxpbmVU ZXh0Qm94OjpwYWludERlY29yYXRpb24oR3JhcGhpY3NDb250ZXh0KiBjb250ZXh0LCBjb25zdCBG bG9hdFBvaW50JgogICAgIGlmIChtX3RydW5jYXRpb24gPT0gY0Z1bGxUcnVuY2F0aW9uKQogICAg ICAgICByZXR1cm47CiAKKyAgICAvLyBGSVhNRTogVGhpcyBmaXhlcyBhIHJlbmRlcmluZyBpc3N1 ZSBpbiBTa2lhIC0gcmVjdCBkcmF3aW5nIHVzZXMgc3Ryb2tlIHN0eWxlIGZyb20gcHJldmlvdXMK KyAgICAvLyByZW5kZXJpbmcgYXJ0aWZhY3QuCisgICAgY29udGV4dC0+c2F2ZSgpOworCiAgICAg RmxvYXRQb2ludCBsb2NhbE9yaWdpbiA9IGJveE9yaWdpbjsKIAogICAgIGZsb2F0IHdpZHRoID0g bV9sb2dpY2FsV2lkdGg7CkBAIC05ODgsNyArOTkyLDYgQEAgdm9pZCBJbmxpbmVUZXh0Qm94Ojpw YWludERlY29yYXRpb24oR3JhcGhpY3NDb250ZXh0KiBjb250ZXh0LCBjb25zdCBGbG9hdFBvaW50 JgogICAgIFJlbmRlclN0eWxlKiBzdHlsZVRvVXNlID0gcmVuZGVyZXIoKS0+c3R5bGUoaXNGaXJz dExpbmVTdHlsZSgpKTsKICAgICBpbnQgYmFzZWxpbmUgPSBzdHlsZVRvVXNlLT5mb250TWV0cmlj cygpLmFzY2VudCgpOwogCi0gICAgYm9vbCBzZXRDbGlwID0gZmFsc2U7CiAgICAgaW50IGV4dHJh T2Zmc2V0ID0gMDsKICAgICBpZiAoIWxpbmVzQXJlT3BhcXVlICYmIHNoYWRvdyAmJiBzaGFkb3ct Pm5leHQoKSkgewogICAgICAgICBGbG9hdFJlY3QgY2xpcFJlY3QobG9jYWxPcmlnaW4sIEZsb2F0 U2l6ZSh3aWR0aCwgYmFzZWxpbmUgKyAyKSk7CkBAIC0xMDAxLDE1ICsxMDA0LDEyIEBAIHZvaWQg SW5saW5lVGV4dEJveDo6cGFpbnREZWNvcmF0aW9uKEdyYXBoaWNzQ29udGV4dCogY29udGV4dCwg Y29uc3QgRmxvYXRQb2ludCYKICAgICAgICAgICAgIGNsaXBSZWN0LnVuaXRlKHNoYWRvd1JlY3Qp OwogICAgICAgICAgICAgZXh0cmFPZmZzZXQgPSBtYXgoZXh0cmFPZmZzZXQsIG1heCgwLCBzaGFk b3dZKSArIHMtPmJsdXIoKSk7CiAgICAgICAgIH0KLSAgICAgICAgY29udGV4dC0+c2F2ZSgpOwog ICAgICAgICBjb250ZXh0LT5jbGlwKGNsaXBSZWN0KTsKICAgICAgICAgZXh0cmFPZmZzZXQgKz0g YmFzZWxpbmUgKyAyOwogICAgICAgICBsb2NhbE9yaWdpbi5tb3ZlKDAsIGV4dHJhT2Zmc2V0KTsK LSAgICAgICAgc2V0Q2xpcCA9IHRydWU7CiAgICAgfQogCiAgICAgQ29sb3JTcGFjZSBjb2xvclNw YWNlID0gcmVuZGVyZXIoKS0+c3R5bGUoKS0+Y29sb3JTcGFjZSgpOwotICAgIGJvb2wgc2V0U2hh ZG93ID0gZmFsc2U7CiAKICAgICBkbyB7CiAgICAgICAgIGlmIChzaGFkb3cpIHsKQEAgLTEwMjEs NyArMTAyMSw2IEBAIHZvaWQgSW5saW5lVGV4dEJveDo6cGFpbnREZWNvcmF0aW9uKEdyYXBoaWNz Q29udGV4dCogY29udGV4dCwgY29uc3QgRmxvYXRQb2ludCYKICAgICAgICAgICAgIGludCBzaGFk b3dYID0gaXNIb3Jpem9udGFsKCkgPyBzaGFkb3ctPngoKSA6IHNoYWRvdy0+eSgpOwogICAgICAg ICAgICAgaW50IHNoYWRvd1kgPSBpc0hvcml6b250YWwoKSA/IHNoYWRvdy0+eSgpIDogLXNoYWRv dy0+eCgpOwogICAgICAgICAgICAgY29udGV4dC0+c2V0U2hhZG93KEZsb2F0U2l6ZShzaGFkb3dY LCBzaGFkb3dZIC0gZXh0cmFPZmZzZXQpLCBzaGFkb3ctPmJsdXIoKSwgc2hhZG93LT5jb2xvcigp LCBjb2xvclNwYWNlKTsKLSAgICAgICAgICAgIHNldFNoYWRvdyA9IHRydWU7CiAgICAgICAgICAg ICBzaGFkb3cgPSBzaGFkb3ctPm5leHQoKTsKICAgICAgICAgfQogCkBAIC0xMDU3LDEwICsxMDU2 LDcgQEAgdm9pZCBJbmxpbmVUZXh0Qm94OjpwYWludERlY29yYXRpb24oR3JhcGhpY3NDb250ZXh0 KiBjb250ZXh0LCBjb25zdCBGbG9hdFBvaW50JgogICAgICAgICB9CiAgICAgfSB3aGlsZSAoc2hh ZG93KTsKIAotICAgIGlmIChzZXRDbGlwKQotICAgICAgICBjb250ZXh0LT5yZXN0b3JlKCk7Ci0g ICAgZWxzZSBpZiAoc2V0U2hhZG93KQotICAgICAgICBjb250ZXh0LT5jbGVhclNoYWRvdygpOwor ICAgIGNvbnRleHQtPnJlc3RvcmUoKTsKIH0KIAogc3RhdGljIEdyYXBoaWNzQ29udGV4dDo6RG9j dW1lbnRNYXJrZXJMaW5lU3R5bGUgbGluZVN0eWxlRm9yTWFya2VyVHlwZShEb2N1bWVudE1hcmtl cjo6TWFya2VyVHlwZSBtYXJrZXJUeXBlKQo=