104458 2012-12-08 15:37:51 -0800 [EFL] [WebGL] Path is not resized correctly 2012-12-09 14:57:53 -0800 1 1 1 Unclassified WebKit WebKit EFL 528+ (Nightly build) PC Linux RESOLVED FIXED P2 Normal --- 103105 104459 1 kalyan.kondapally kalyan.kondapally dino kenneth lucas.de.marchi webkit.review.bot oldest_to_newest 786634 0 kalyan.kondapally 2012-12-08 15:37:51 -0800 In GraphicsContext3D::paintToCanvas , we flip the contents and draw on the surface. The operations needed to flip the image(translation and scale ) are done before the rectangle with correct size is added to current path. This results in drawing pixels at wrong position. We could also combine the translation and scale operations into one by using matrix. 786638 1 kalyan.kondapally 2012-12-08 15:41:31 -0800 (In reply to comment #0) > In GraphicsContext3D::paintToCanvas , we flip the contents and draw on the surface. The operations needed to flip the image(translation and scale ) are done before the rectangle with correct size is added to current path. This results in drawing pixels at wrong position. > > We could also combine the translation and scale operations into one by using matrix. Problem can be seen with LayoutTests/fast/canvas/webgl/canvas-test.html 786647 2 178383 kalyan.kondapally 2012-12-08 16:10:29 -0800 Created attachment 178383 patch 786778 3 178383 kenneth 2012-12-09 06:34:27 -0800 Comment on attachment 178383 patch View in context: https://bugs.webkit.org/attachment.cgi?id=178383&action=review > Source/WebCore/ChangeLog:9 > + The operations done to flip the image (translation and scale ) are done before rectangle with correct size remove space before ) > Source/WebCore/ChangeLog:10 > + is added to current path. This results in updating pixels at wrong positions. . Remove the trailing " ." 786861 4 178436 kalyan.kondapally 2012-12-09 13:59:35 -0800 Created attachment 178436 patchv2 review changes 786877 5 178436 webkit.review.bot 2012-12-09 14:57:49 -0800 Comment on attachment 178436 patchv2 Clearing flags on attachment: 178436 Committed r137098: <http://trac.webkit.org/changeset/137098> 786878 6 webkit.review.bot 2012-12-09 14:57:53 -0800 All reviewed patches have been landed. Closing bug. 178383 2012-12-08 16:10:29 -0800 2012-12-09 13:59:35 -0800 patch copytosurfacefix.patch text/plain 2251 kalyan.kondapally ZGlmZiAtLWdpdCBTb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cgU291cmNlL1dlYkNvcmUvQ2hhbmdl TG9nCmluZGV4IGFhYWZiNDUuLjlhYmZmZTUgMTAwNjQ0Ci0tLSBTb3VyY2UvV2ViQ29yZS9DaGFu Z2VMb2cKKysrIFNvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE5IEBACisyMDEy LTEyLTA4ICBLb25kYXBhbGx5IEthbHlhbiAgPGthbHlhbi5rb25kYXBhbGx5QGludGVsLmNvbT4K KworICAgICAgICBbRUZMXSBbV2ViR0xdIFBhdGggaXMgbm90IHJlc2l6ZWQgY29ycmVjdGx5Lgor ICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTA0NDU4Lgor CisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIEluIEdyYXBo aWNzQ29udGV4dDNEOjpwYWludFRvQ2FudmFzLCB3ZSBmbGlwIHRoZSBjb250ZW50cyBhbmQgZHJh dyBvbiB0aGUgc3VyZmFjZS4KKyAgICAgICAgVGhlIG9wZXJhdGlvbnMgZG9uZSB0byBmbGlwIHRo ZSBpbWFnZSAodHJhbnNsYXRpb24gYW5kIHNjYWxlICkgYXJlIGRvbmUgYmVmb3JlIHJlY3Rhbmds ZSB3aXRoIGNvcnJlY3Qgc2l6ZQorICAgICAgICBpcyBhZGRlZCB0byBjdXJyZW50IHBhdGguIFRo aXMgcmVzdWx0cyBpbiB1cGRhdGluZyBwaXhlbHMgYXQgd3JvbmcgcG9zaXRpb25zLiAuCisKKyAg ICAgICAgQ292ZXJlZCBieSBleGlzdGluZyB0ZXN0cy4KKworICAgICAgICAqIHBsYXRmb3JtL2dy YXBoaWNzL2VmbC9HcmFwaGljc0NvbnRleHQzREVmbC5jcHA6CisgICAgICAgIChXZWJDb3JlOjpH cmFwaGljc0NvbnRleHQzRDo6cGFpbnRUb0NhbnZhcyk6CisKIDIwMTItMTItMDcgIEtvbmRhcGFs bHkgS2FseWFuICA8a2FseWFuLmtvbmRhcGFsbHlAaW50ZWwuY29tPgogCiAgICAgICAgIFtFRkxd IFtBQ10gSW1wbGVtZW50IEltYWdlRXh0cmFjdG9yOjpleHRyYWN0SW1hZ2UgaW4gR3JhcGhpY3ND b250ZXh0M0RFZmwuCmRpZmYgLS1naXQgU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vZ3JhcGhpY3Mv ZWZsL0dyYXBoaWNzQ29udGV4dDNERWZsLmNwcCBTb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9ncmFw aGljcy9lZmwvR3JhcGhpY3NDb250ZXh0M0RFZmwuY3BwCmluZGV4IDVjY2QxYjAuLjJkMTBhMWYg MTAwNjQ0Ci0tLSBTb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9ncmFwaGljcy9lZmwvR3JhcGhpY3ND b250ZXh0M0RFZmwuY3BwCisrKyBTb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9ncmFwaGljcy9lZmwv R3JhcGhpY3NDb250ZXh0M0RFZmwuY3BwCkBAIC0yMjMsMTQgKzIyMywxNCBAQCB2b2lkIEdyYXBo aWNzQ29udGV4dDNEOjpwYWludFRvQ2FudmFzKGNvbnN0IHVuc2lnbmVkIGNoYXIqIGltYWdlUGl4 ZWxzLCBpbnQgaW1hZwogICAgIFJlZlB0cjxjYWlyb19zdXJmYWNlX3Q+IGltYWdlU3VyZmFjZSA9 IGFkb3B0UmVmKGNhaXJvX2ltYWdlX3N1cmZhY2VfY3JlYXRlX2Zvcl9kYXRhKAogICAgICAgICBj b25zdF9jYXN0PHVuc2lnbmVkIGNoYXIqPihpbWFnZVBpeGVscyksIENBSVJPX0ZPUk1BVF9BUkdC MzIsIGltYWdlV2lkdGgsIGltYWdlSGVpZ2h0LCBpbWFnZVdpZHRoICogNCkpOwogCi0gICAgLy8g T3BlbkdMIGtlZXBzIHRoZSBwaXhlbHMgc3RvcmVkIGJvdHRvbSB1cCwgc28gd2UgbmVlZCB0byBm bGlwIHRoZSBpbWFnZSBoZXJlLgotICAgIGNhaXJvX3RyYW5zbGF0ZShjciwgMCwgaW1hZ2VIZWln aHQpOwotICAgIGNhaXJvX3NjYWxlKGNyLCAxLCAtMSk7IAorICAgIGNhaXJvX3JlY3RhbmdsZShj ciwgMCwgMCwgY2FudmFzV2lkdGgsIGNhbnZhc0hlaWdodCk7CiAKKyAgICAvLyBPcGVuR0wga2Vl cHMgdGhlIHBpeGVscyBzdG9yZWQgYm90dG9tIHVwLCBzbyB3ZSBuZWVkIHRvIGZsaXAgdGhlIGlt YWdlIGhlcmUuCisgICAgY2Fpcm9fbWF0cml4X3QgbWF0cml4OworICAgIGNhaXJvX21hdHJpeF9p bml0KCZtYXRyaXgsIDEuMCwgMC4wLCAwLjAsIC0xLjAsIDAuMCwgaW1hZ2VIZWlnaHQpOworICAg IGNhaXJvX3NldF9tYXRyaXgoY3IsICZtYXRyaXgpOwogICAgIGNhaXJvX3NldF9vcGVyYXRvcihj ciwgQ0FJUk9fT1BFUkFUT1JfU09VUkNFKTsKICAgICBjYWlyb19zZXRfc291cmNlX3N1cmZhY2Uo Y3IsIGltYWdlU3VyZmFjZS5nZXQoKSwgMCwgMCk7Ci0gICAgY2Fpcm9fcmVjdGFuZ2xlKGNyLCAw LCAwLCBjYW52YXNXaWR0aCwgLWNhbnZhc0hlaWdodCk7Ci0KICAgICBjYWlyb19maWxsKGNyKTsK ICAgICBjb250ZXh0LT5yZXN0b3JlKCk7CiB9Cg== 178436 2012-12-09 13:59:35 -0800 2012-12-09 14:57:49 -0800 patchv2 reviewchanges.patch text/plain 2261 kalyan.kondapally ZGlmZiAtLWdpdCBTb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cgU291cmNlL1dlYkNvcmUvQ2hhbmdl TG9nCmluZGV4IGFhYWZiNDUuLjljNjhiZWEgMTAwNjQ0Ci0tLSBTb3VyY2UvV2ViQ29yZS9DaGFu Z2VMb2cKKysrIFNvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE5IEBACisyMDEy LTEyLTA4ICBLb25kYXBhbGx5IEthbHlhbiAgPGthbHlhbi5rb25kYXBhbGx5QGludGVsLmNvbT4K KworICAgICAgICBbRUZMXSBbV2ViR0xdIFBhdGggaXMgbm90IHJlc2l6ZWQgY29ycmVjdGx5Lgor ICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTA0NDU4Lgor CisgICAgICAgIFJldmlld2VkIGJ5IEtlbm5ldGggUm9oZGUgQ2hyaXN0aWFuc2VuLgorCisgICAg ICAgIEluIEdyYXBoaWNzQ29udGV4dDNEOjpwYWludFRvQ2FudmFzLCB3ZSBmbGlwIHRoZSBjb250 ZW50cyBhbmQgZHJhdyBvbiB0aGUgc3VyZmFjZS4KKyAgICAgICAgVGhlIG9wZXJhdGlvbnMgZG9u ZSB0byBmbGlwIHRoZSBpbWFnZSAodHJhbnNsYXRpb24gYW5kIHNjYWxlKSBhcmUgZG9uZSBiZWZv cmUgcmVjdGFuZ2xlIHdpdGggY29ycmVjdCBzaXplCisgICAgICAgIGlzIGFkZGVkIHRvIGN1cnJl bnQgcGF0aC4gVGhpcyByZXN1bHRlZCBpbiB1cGRhdGluZyBwaXhlbHMgYXQgd3JvbmcgcG9zaXRp b25zLgorCisgICAgICAgIENvdmVyZWQgYnkgZXhpc3RpbmcgdGVzdHMuCisKKyAgICAgICAgKiBw bGF0Zm9ybS9ncmFwaGljcy9lZmwvR3JhcGhpY3NDb250ZXh0M0RFZmwuY3BwOgorICAgICAgICAo V2ViQ29yZTo6R3JhcGhpY3NDb250ZXh0M0Q6OnBhaW50VG9DYW52YXMpOgorCiAyMDEyLTEyLTA3 ICBLb25kYXBhbGx5IEthbHlhbiAgPGthbHlhbi5rb25kYXBhbGx5QGludGVsLmNvbT4KIAogICAg ICAgICBbRUZMXSBbQUNdIEltcGxlbWVudCBJbWFnZUV4dHJhY3Rvcjo6ZXh0cmFjdEltYWdlIGlu IEdyYXBoaWNzQ29udGV4dDNERWZsLgpkaWZmIC0tZ2l0IFNvdXJjZS9XZWJDb3JlL3BsYXRmb3Jt L2dyYXBoaWNzL2VmbC9HcmFwaGljc0NvbnRleHQzREVmbC5jcHAgU291cmNlL1dlYkNvcmUvcGxh dGZvcm0vZ3JhcGhpY3MvZWZsL0dyYXBoaWNzQ29udGV4dDNERWZsLmNwcAppbmRleCA1Y2NkMWIw Li4yZDEwYTFmIDEwMDY0NAotLS0gU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vZ3JhcGhpY3MvZWZs L0dyYXBoaWNzQ29udGV4dDNERWZsLmNwcAorKysgU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vZ3Jh cGhpY3MvZWZsL0dyYXBoaWNzQ29udGV4dDNERWZsLmNwcApAQCAtMjIzLDE0ICsyMjMsMTQgQEAg dm9pZCBHcmFwaGljc0NvbnRleHQzRDo6cGFpbnRUb0NhbnZhcyhjb25zdCB1bnNpZ25lZCBjaGFy KiBpbWFnZVBpeGVscywgaW50IGltYWcKICAgICBSZWZQdHI8Y2Fpcm9fc3VyZmFjZV90PiBpbWFn ZVN1cmZhY2UgPSBhZG9wdFJlZihjYWlyb19pbWFnZV9zdXJmYWNlX2NyZWF0ZV9mb3JfZGF0YSgK ICAgICAgICAgY29uc3RfY2FzdDx1bnNpZ25lZCBjaGFyKj4oaW1hZ2VQaXhlbHMpLCBDQUlST19G T1JNQVRfQVJHQjMyLCBpbWFnZVdpZHRoLCBpbWFnZUhlaWdodCwgaW1hZ2VXaWR0aCAqIDQpKTsK IAotICAgIC8vIE9wZW5HTCBrZWVwcyB0aGUgcGl4ZWxzIHN0b3JlZCBib3R0b20gdXAsIHNvIHdl IG5lZWQgdG8gZmxpcCB0aGUgaW1hZ2UgaGVyZS4KLSAgICBjYWlyb190cmFuc2xhdGUoY3IsIDAs IGltYWdlSGVpZ2h0KTsKLSAgICBjYWlyb19zY2FsZShjciwgMSwgLTEpOyAKKyAgICBjYWlyb19y ZWN0YW5nbGUoY3IsIDAsIDAsIGNhbnZhc1dpZHRoLCBjYW52YXNIZWlnaHQpOwogCisgICAgLy8g T3BlbkdMIGtlZXBzIHRoZSBwaXhlbHMgc3RvcmVkIGJvdHRvbSB1cCwgc28gd2UgbmVlZCB0byBm bGlwIHRoZSBpbWFnZSBoZXJlLgorICAgIGNhaXJvX21hdHJpeF90IG1hdHJpeDsKKyAgICBjYWly b19tYXRyaXhfaW5pdCgmbWF0cml4LCAxLjAsIDAuMCwgMC4wLCAtMS4wLCAwLjAsIGltYWdlSGVp Z2h0KTsKKyAgICBjYWlyb19zZXRfbWF0cml4KGNyLCAmbWF0cml4KTsKICAgICBjYWlyb19zZXRf b3BlcmF0b3IoY3IsIENBSVJPX09QRVJBVE9SX1NPVVJDRSk7CiAgICAgY2Fpcm9fc2V0X3NvdXJj ZV9zdXJmYWNlKGNyLCBpbWFnZVN1cmZhY2UuZ2V0KCksIDAsIDApOwotICAgIGNhaXJvX3JlY3Rh bmdsZShjciwgMCwgMCwgY2FudmFzV2lkdGgsIC1jYW52YXNIZWlnaHQpOwotCiAgICAgY2Fpcm9f ZmlsbChjcik7CiAgICAgY29udGV4dC0+cmVzdG9yZSgpOwogfQo=