104339 2012-12-06 21:29:55 -0800 Make it possible to use other types as well as class and struct as an argument of messages. 2012-12-09 15:00:43 -0800 1 1 1 Unclassified WebKit WebKit2 528+ (Nightly build) Unspecified Unspecified RESOLVED INVALID P2 Normal --- 1 dongseong.hwang dongseong.hwang andersca darin jturcotte noam sam webkit.review.bot zeno oldest_to_newest 785614 0 dongseong.hwang 2012-12-06 21:29:55 -0800 This patch changes forward_declarations_and_headers function to include headers for types in special_cases set, not to make forward declarations. We can use typedef as an argument now. It means we can use RefPtr as an argument if we define typedef from RefPtr. This patch applies this special handling to CoordinatedLayerID and CoordinatedImageBackingID. 785615 1 178155 dongseong.hwang 2012-12-06 21:31:20 -0800 Created attachment 178155 Patch 785625 2 darin 2012-12-06 21:44:41 -0800 Anders, as the creator and architect of the WebKit2 message system, is this the direction you’d like to go with this? 785627 3 dongseong.hwang 2012-12-06 21:49:35 -0800 I make this change to use RefPtr as an argument. You can see the example in https://bugs.webkit.org/attachment.cgi?id=177979&action=review I want this change to match your direction :) 785932 4 andersca 2012-12-07 09:44:58 -0800 (In reply to comment #2) > Anders, as the creator and architect of the WebKit2 message system, is this the direction you’d like to go with this? No. I think that we shouldn't use typedefs in .message.in files, because they can hide the real size of the underlying data. (This is why we always use explicitly sized types as message parameters). In addition, I'd also like to completely get rid of hard-coded types in the message generator by extending the syntax where possible. 786372 5 dongseong.hwang 2012-12-07 19:16:11 -0800 (In reply to comment #4) > (In reply to comment #2) > > Anders, as the creator and architect of the WebKit2 message system, is this the direction you’d like to go with this? > > No. I think that we shouldn't use typedefs in .message.in files, because they can hide the real size of the underlying data. (This is why we always use explicitly sized types as message parameters). I don't understand what you mean. We can not know the real size from forward declaration too, and to know the real size we should include headers. The problem I had is the c++ does not support forward declaration of typedef. btw, I agree that only POD struct is natural to use it as an argument of messages, but current default argument is class, not struct. And I agree that you don't want each class to change messages.py > In addition, I'd also like to completely get rid of hard-coded types in the message generator by extending the syntax where possible. Currently, there are three special case including headers. 1. in the case that type name does not match to header name. for example, class FooRef in Foo.h 2. in the case that type is struct, as mentioned. 3. nested class. Do you mean that all classes, which we want to use an argument of messages, must be in the same header, and the type must be class? although we must create a redundant class to wrap the type that we want to use an argument. If yes, I'll give up. 178155 2012-12-06 21:31:20 -0800 2012-12-07 09:45:06 -0800 Patch bug-104339-20121207142839.patch text/plain 6357 dongseong.hwang U3VidmVyc2lvbiBSZXZpc2lvbjogMTM2OTE5CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0Mi9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViS2l0Mi9DaGFuZ2VMb2cKaW5kZXggNDQ1NDdiNzkyYzFkY2Jk MzEwNTBjOWVjOTE3MjVlNDZiOTJjYjFlOS4uNDI0Y2E4MDA1ZWJjODRmYWVhMTEwMjViNmZjYTVj YmI3YzBlNzZkNyAxMDA2NDQKLS0tIGEvU291cmNlL1dlYktpdDIvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJLaXQyL0NoYW5nZUxvZwpAQCAtMSwzICsxLDIzIEBACisyMDEyLTEyLTA2ICBIdWFu ZyBEb25nc3VuZyAgPGx1eHRlbGxhQGNvbXBhbnkxMDAubmV0PgorCisgICAgICAgIE1ha2UgaXQg cG9zc2libGUgdG8gdXNlIG90aGVyIHR5cGVzIGFzIHdlbGwgYXMgY2xhc3MgYW5kIHN0cnVjdCBh cyBhbiBhcmd1bWVudCBvZiBtZXNzYWdlcy4KKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5v cmcvc2hvd19idWcuY2dpP2lkPTEwNDMzOQorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAo T09QUyEpLgorCisgICAgICAgIFRoaXMgcGF0Y2ggY2hhbmdlcyBmb3J3YXJkX2RlY2xhcmF0aW9u c19hbmRfaGVhZGVycyBmdW5jdGlvbiB0byBpbmNsdWRlIGhlYWRlcnMKKyAgICAgICAgZm9yIHR5 cGVzIGluIHNwZWNpYWxfY2FzZXMgc2V0LCBub3QgdG8gbWFrZSBmb3J3YXJkIGRlY2xhcmF0aW9u cy4gV2UgY2FuIHVzZQorICAgICAgICB0eXBlZGVmIGFzIGFuIGFyZ3VtZW50IG5vdy4gSXQgbWVh bnMgd2UgY2FuIHVzZSBSZWZQdHIgYXMgYW4gYXJndW1lbnQgaWYgd2UKKyAgICAgICAgZGVmaW5l IHR5cGVkZWYgZnJvbSBSZWZQdHIuCisKKyAgICAgICAgVGhpcyBwYXRjaCBhcHBsaWVzIHRoaXMg c3BlY2lhbCBoYW5kbGluZyB0byBDb29yZGluYXRlZExheWVySUQgYW5kCisgICAgICAgIENvb3Jk aW5hdGVkSW1hZ2VCYWNraW5nSUQuCisKKyAgICAgICAgKiBTY3JpcHRzL3dlYmtpdDIvbWVzc2Fn ZXMucHk6CisgICAgICAgIChmb3J3YXJkX2RlY2xhcmF0aW9uc19hbmRfaGVhZGVycyk6CisgICAg ICAgIChoZWFkZXJzX2Zvcl90eXBlKToKKyAgICAgICAgKiBVSVByb2Nlc3MvQ29vcmRpbmF0ZWRH cmFwaGljcy9MYXllclRyZWVDb29yZGluYXRvclByb3h5Lm1lc3NhZ2VzLmluOgorCiAyMDEyLTEy LTA2ICBSaWNrIEJ5ZXJzICA8cmJ5ZXJzQGNocm9taXVtLm9yZz4KIAogICAgICAgICBDU1MgY3Vy c29yIHByb3BlcnR5IHNob3VsZCBzdXBwb3J0IHdlYmtpdC1pbWFnZS1zZXQKZGlmZiAtLWdpdCBh L1NvdXJjZS9XZWJLaXQyL1NjcmlwdHMvd2Via2l0Mi9tZXNzYWdlcy5weSBiL1NvdXJjZS9XZWJL aXQyL1NjcmlwdHMvd2Via2l0Mi9tZXNzYWdlcy5weQppbmRleCA1NTk0NzhjYTljZDNlMzdhZTA1 MTQ1ZWMyMzk2OTY5MWQ0ZDViZWEyLi40ZDhjMjA4NjE0YTRlMmQ2ZmZjNWY0ZTYyOGJmNjE5ZTFm NzczZTJlIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViS2l0Mi9TY3JpcHRzL3dlYmtpdDIvbWVzc2Fn ZXMucHkKKysrIGIvU291cmNlL1dlYktpdDIvU2NyaXB0cy93ZWJraXQyL21lc3NhZ2VzLnB5CkBA IC0yNDksNiArMjQ5LDE2IEBAIGRlZiBmb3J3YXJkX2RlY2xhcmF0aW9uc19hbmRfaGVhZGVycyhy ZWNlaXZlcik6CiAKICAgICAgICAgc3BsaXQgPSB0eXBlLnNwbGl0KCc6OicpCiAKKyAgICAgICAg c3BlY2lhbF9jYXNlcyA9IGZyb3plbnNldChbCisgICAgICAgICAgICAnV2ViS2l0OjpDb29yZGlu YXRlZExheWVySUQnLAorICAgICAgICAgICAgJ1dlYktpdDo6Q29vcmRpbmF0ZWRJbWFnZUJhY2tp bmdJRCcsCisgICAgICAgIF0pCisKKyAgICAgICAgaWYgdHlwZSBpbiBzcGVjaWFsX2Nhc2VzOgor ICAgICAgICAgICAgIyBEb24ndCBmb3J3YXJkIGRlY2xhcmUgY2xhc3MuIEZvciBleGFtcGxlLCB0 eXBlZGVmLgorICAgICAgICAgICAgaGVhZGVycy51cGRhdGUoaGVhZGVyc19mb3JfdHlwZSh0eXBl KSkKKyAgICAgICAgICAgIGNvbnRpbnVlCisKICAgICAgICAgaWYgbGVuKHNwbGl0KSA9PSAyOgog ICAgICAgICAgICAgbmFtZXNwYWNlID0gc3BsaXRbMF0KICAgICAgICAgICAgIGlubmVyX3R5cGUg PSBzcGxpdFsxXQpAQCAtMzk3LDYgKzQwNyw3IEBAIGRlZiBoZWFkZXJzX2Zvcl90eXBlKHR5cGUp OgogICAgICAgICAnV2ViQ29yZTo6VGV4dENoZWNraW5nUmVzdWx0JzogWyc8V2ViQ29yZS9UZXh0 Q2hlY2tlckNsaWVudC5oPiddLAogICAgICAgICAnV2ViQ29yZTo6Vmlld3BvcnRBdHRyaWJ1dGVz JzogWyc8V2ViQ29yZS9WaWV3cG9ydEFyZ3VtZW50cy5oPiddLAogICAgICAgICAnV2ViS2l0OjpD b29yZGluYXRlZExheWVySUQnOiBbJyJDb29yZGluYXRlZExheWVySW5mby5oIiddLAorICAgICAg ICAnV2ViS2l0OjpDb29yZGluYXRlZEltYWdlQmFja2luZ0lEJzogWyciQ29vcmRpbmF0ZWRMYXll ckluZm8uaCInXSwKICAgICAgICAgJ1dlYktpdDo6SW5qZWN0ZWRCdW5kbGVVc2VyTWVzc2FnZUVu Y29kZXInOiBbXSwKICAgICAgICAgJ1dlYktpdDo6V2ViQ29udGV4dFVzZXJNZXNzYWdlRW5jb2Rl cic6IFtdLAogICAgICAgICAnV2ViS2l0OjpXZWJHZXN0dXJlRXZlbnQnOiBbJyJXZWJFdmVudC5o IiddLApkaWZmIC0tZ2l0IGEvU291cmNlL1dlYktpdDIvVUlQcm9jZXNzL0Nvb3JkaW5hdGVkR3Jh cGhpY3MvTGF5ZXJUcmVlQ29vcmRpbmF0b3JQcm94eS5tZXNzYWdlcy5pbiBiL1NvdXJjZS9XZWJL aXQyL1VJUHJvY2Vzcy9Db29yZGluYXRlZEdyYXBoaWNzL0xheWVyVHJlZUNvb3JkaW5hdG9yUHJv eHkubWVzc2FnZXMuaW4KaW5kZXggOGY3YWM1YTM3MDZhNzNjNWMzNzZhMzIxY2U2OTRlOWYwYzI2 YjVjOC4uNmM5Njc3YmVmZDA5ZTkwZjU5YWEzNmNjMjkwNGYxZDY3MzM4Y2JjNiAxMDA2NDQKLS0t IGEvU291cmNlL1dlYktpdDIvVUlQcm9jZXNzL0Nvb3JkaW5hdGVkR3JhcGhpY3MvTGF5ZXJUcmVl Q29vcmRpbmF0b3JQcm94eS5tZXNzYWdlcy5pbgorKysgYi9Tb3VyY2UvV2ViS2l0Mi9VSVByb2Nl c3MvQ29vcmRpbmF0ZWRHcmFwaGljcy9MYXllclRyZWVDb29yZGluYXRvclByb3h5Lm1lc3NhZ2Vz LmluCkBAIC0xOSwyOSArMTksMjkgQEAKIAogI2lmIFVTRShDT09SRElOQVRFRF9HUkFQSElDUykK IG1lc3NhZ2VzIC0+IExheWVyVHJlZUNvb3JkaW5hdG9yUHJveHkgewotICAgIFNldENvbXBvc2l0 aW5nTGF5ZXJTdGF0ZSh1aW50MzJfdCBpZCwgV2ViS2l0OjpDb29yZGluYXRlZExheWVySW5mbyBs YXllckluZm8pCi0gICAgU2V0Q29tcG9zaXRpbmdMYXllckNoaWxkcmVuKHVpbnQzMl90IGlkLCBW ZWN0b3I8dWludDMyX3Q+IGNoaWxkcmVuKQorICAgIFNldENvbXBvc2l0aW5nTGF5ZXJTdGF0ZShX ZWJLaXQ6OkNvb3JkaW5hdGVkTGF5ZXJJRCBsYXllcklELCBXZWJLaXQ6OkNvb3JkaW5hdGVkTGF5 ZXJJbmZvIGxheWVySW5mbykKKyAgICBTZXRDb21wb3NpdGluZ0xheWVyQ2hpbGRyZW4oV2ViS2l0 OjpDb29yZGluYXRlZExheWVySUQgbGF5ZXJJRCwgVmVjdG9yPHVpbnQzMl90PiBjaGlsZHJlbikK ICNpZiBFTkFCTEUoQ1NTX0ZJTFRFUlMpCi0gICAgU2V0Q29tcG9zaXRpbmdMYXllckZpbHRlcnMo dWludDMyX3QgaWQsIFdlYkNvcmU6OkZpbHRlck9wZXJhdGlvbnMgZmlsdGVycykKKyAgICBTZXRD b21wb3NpdGluZ0xheWVyRmlsdGVycyhXZWJLaXQ6OkNvb3JkaW5hdGVkTGF5ZXJJRCBsYXllcklE LCBXZWJDb3JlOjpGaWx0ZXJPcGVyYXRpb25zIGZpbHRlcnMpCiAjZW5kaWYKICNpZiBFTkFCTEUo Q1NTX1NIQURFUlMpCiAgICAgQ3JlYXRlQ3VzdG9tRmlsdGVyUHJvZ3JhbShpbnQgaWQsIFdlYkNv cmU6OkN1c3RvbUZpbHRlclByb2dyYW1JbmZvIHByb2dyYW1JbmZvKQogICAgIFJlbW92ZUN1c3Rv bUZpbHRlclByb2dyYW0oaW50IGlkKQogI2VuZGlmCi0gICAgU2V0Um9vdENvbXBvc2l0aW5nTGF5 ZXIodWludDMyX3QgaWQpCi0gICAgRGVsZXRlQ29tcG9zaXRpbmdMYXllcih1aW50MzJfdCBpZCkK LSAgICBDcmVhdGVUaWxlRm9yTGF5ZXIodWludDMyX3QgbGF5ZXJJRCwgdWludDMyX3QgdGlsZUlE LCBXZWJDb3JlOjpJbnRSZWN0IHRpbGVSZWN0LCBXZWJLaXQ6OlN1cmZhY2VVcGRhdGVJbmZvIHVw ZGF0ZUluZm8pCi0gICAgVXBkYXRlVGlsZUZvckxheWVyKHVpbnQzMl90IGxheWVySUQsIHVpbnQz Ml90IHRpbGVJRCwgV2ViQ29yZTo6SW50UmVjdCB0aWxlUmVjdCwgV2ViS2l0OjpTdXJmYWNlVXBk YXRlSW5mbyB1cGRhdGVJbmZvKQotICAgIFJlbW92ZVRpbGVGb3JMYXllcih1aW50MzJfdCBsYXll cklELCB1aW50MzJfdCB0aWxlSUQpCisgICAgU2V0Um9vdENvbXBvc2l0aW5nTGF5ZXIoV2ViS2l0 OjpDb29yZGluYXRlZExheWVySUQgbGF5ZXJJRCkKKyAgICBEZWxldGVDb21wb3NpdGluZ0xheWVy KFdlYktpdDo6Q29vcmRpbmF0ZWRMYXllcklEIGxheWVySUQpCisgICAgQ3JlYXRlVGlsZUZvckxh eWVyKFdlYktpdDo6Q29vcmRpbmF0ZWRMYXllcklEIGxheWVySUQsIHVpbnQzMl90IHRpbGVJRCwg V2ViQ29yZTo6SW50UmVjdCB0aWxlUmVjdCwgV2ViS2l0OjpTdXJmYWNlVXBkYXRlSW5mbyB1cGRh dGVJbmZvKQorICAgIFVwZGF0ZVRpbGVGb3JMYXllcihXZWJLaXQ6OkNvb3JkaW5hdGVkTGF5ZXJJ RCBsYXllcklELCB1aW50MzJfdCB0aWxlSUQsIFdlYkNvcmU6OkludFJlY3QgdGlsZVJlY3QsIFdl YktpdDo6U3VyZmFjZVVwZGF0ZUluZm8gdXBkYXRlSW5mbykKKyAgICBSZW1vdmVUaWxlRm9yTGF5 ZXIoV2ViS2l0OjpDb29yZGluYXRlZExheWVySUQgbGF5ZXJJRCwgdWludDMyX3QgdGlsZUlEKQog ICAgIENyZWF0ZVVwZGF0ZUF0bGFzKGludCBhdGxhc0lELCBXZWJLaXQ6OlNoYXJlYWJsZVN1cmZh Y2U6OkhhbmRsZSBoYW5kbGUpCiAgICAgUmVtb3ZlVXBkYXRlQXRsYXMoaW50IGF0bGFzSUQpCi0g ICAgQ3JlYXRlSW1hZ2VCYWNraW5nKHVpbnQ2NF90IGltYWdlSUQpCi0gICAgVXBkYXRlSW1hZ2VC YWNraW5nKHVpbnQ2NF90IGltYWdlSUQsIFdlYktpdDo6U2hhcmVhYmxlU3VyZmFjZTo6SGFuZGxl IGhhbmRsZSkKLSAgICBDbGVhckltYWdlQmFja2luZ0NvbnRlbnRzKHVpbnQ2NF90IGltYWdlSUQp Ci0gICAgUmVtb3ZlSW1hZ2VCYWNraW5nKHVpbnQ2NF90IGltYWdlSUQpCisgICAgQ3JlYXRlSW1h Z2VCYWNraW5nKFdlYktpdDo6Q29vcmRpbmF0ZWRJbWFnZUJhY2tpbmdJRCBpbWFnZUlEKQorICAg IFVwZGF0ZUltYWdlQmFja2luZyhXZWJLaXQ6OkNvb3JkaW5hdGVkSW1hZ2VCYWNraW5nSUQgaW1h Z2VJRCwgV2ViS2l0OjpTaGFyZWFibGVTdXJmYWNlOjpIYW5kbGUgaGFuZGxlKQorICAgIENsZWFy SW1hZ2VCYWNraW5nQ29udGVudHMoV2ViS2l0OjpDb29yZGluYXRlZEltYWdlQmFja2luZ0lEIGlt YWdlSUQpCisgICAgUmVtb3ZlSW1hZ2VCYWNraW5nKFdlYktpdDo6Q29vcmRpbmF0ZWRJbWFnZUJh Y2tpbmdJRCBpbWFnZUlEKQogICAgIERpZFJlbmRlckZyYW1lKFdlYkNvcmU6OkludFNpemUgY29u dGVudHNTaXplLCBXZWJDb3JlOjpJbnRSZWN0IGNvdmVyZWRSZWN0KQogICAgIERpZENoYW5nZVNj cm9sbFBvc2l0aW9uKFdlYkNvcmU6OkludFBvaW50IHBvc2l0aW9uKQotICAgIFNldExheWVyQW5p bWF0aW9ucyh1aW50MzJfdCBpZCwgV2ViQ29yZTo6R3JhcGhpY3NMYXllckFuaW1hdGlvbnMgYW5p bWF0aW9ucykKKyAgICBTZXRMYXllckFuaW1hdGlvbnMoV2ViS2l0OjpDb29yZGluYXRlZExheWVy SUQgbGF5ZXJJRCwgV2ViQ29yZTo6R3JhcGhpY3NMYXllckFuaW1hdGlvbnMgYW5pbWF0aW9ucykK ICAgICBTZXRBbmltYXRpb25zTG9ja2VkKGJvb2wgbG9ja2VkKQogCiAjaWYgRU5BQkxFKFJFUVVF U1RfQU5JTUFUSU9OX0ZSQU1FKQpAQCAtNDksOSArNDksOSBAQCBtZXNzYWdlcyAtPiBMYXllclRy ZWVDb29yZGluYXRvclByb3h5IHsKICNlbmRpZgogCiAjaWYgVVNFKEdSQVBISUNTX1NVUkZBQ0Up Ci0gICAgQ3JlYXRlQ2FudmFzKHVpbnQzMl90IGlkLCBXZWJDb3JlOjpJbnRTaXplIGNhbnZhc1Np emUsIFdlYkNvcmU6OkdyYXBoaWNzU3VyZmFjZVRva2VuIHRva2VuKQotICAgIFN5bmNDYW52YXMo dWludDMyX3QgaWQsIHVpbnQzMl90IGZyb250QnVmZmVyKQotICAgIERlc3Ryb3lDYW52YXModWlu dDMyX3QgaWQpCisgICAgQ3JlYXRlQ2FudmFzKFdlYktpdDo6Q29vcmRpbmF0ZWRMYXllcklEIGxh eWVySUQsIFdlYkNvcmU6OkludFNpemUgY2FudmFzU2l6ZSwgV2ViQ29yZTo6R3JhcGhpY3NTdXJm YWNlVG9rZW4gdG9rZW4pCisgICAgU3luY0NhbnZhcyhXZWJLaXQ6OkNvb3JkaW5hdGVkTGF5ZXJJ RCBsYXllcklELCB1aW50MzJfdCBmcm9udEJ1ZmZlcikKKyAgICBEZXN0cm95Q2FudmFzKFdlYktp dDo6Q29vcmRpbmF0ZWRMYXllcklEIGxheWVySUQpCiAjZW5kaWYKIAogICAgIFNldEJhY2tncm91 bmRDb2xvcihXZWJDb3JlOjpDb2xvciBjb2xvcikK