104234 2012-12-06 01:01:04 -0800 [CSS Regions] Remove the sanitize mechanism from LineFragmentationData 2012-12-06 16:34:56 -0800 1 1 1 Unclassified WebKit WebCore Misc. 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED AdobeTracked P2 Normal --- 57312 1 abucur abucur achicu eric ojan WebkitBugTracker webkit.review.bot oldest_to_newest 784728 0 abucur 2012-12-06 01:01:04 -0800 After http://trac.webkit.org/changeset/136793 the sanitize method is no longer needed. The if the region chain is invalidated, the blocks will be marked for full layout. 784867 1 177997 abucur 2012-12-06 05:12:32 -0800 Created attachment 177997 Patch 785339 2 177997 hyatt 2012-12-06 15:39:06 -0800 Comment on attachment 177997 Patch r=me 785402 3 177997 webkit.review.bot 2012-12-06 16:34:53 -0800 Comment on attachment 177997 Patch Clearing flags on attachment: 177997 Committed r136908: <http://trac.webkit.org/changeset/136908> 785403 4 webkit.review.bot 2012-12-06 16:34:56 -0800 All reviewed patches have been landed. Closing bug. 177997 2012-12-06 05:12:32 -0800 2012-12-06 16:34:53 -0800 Patch bug-104234-20121206150955.patch text/plain 7554 abucur U3VidmVyc2lvbiBSZXZpc2lvbjogMTM2ODI3CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggN2RiNGJjNGIxODA4NjJj ZTI5M2NkNDViYzA1Y2E2NjQyNDQ1MWJjMy4uMGM5NWI0N2ViMDhlMGMwMWJhYjFjYjdiNDc4ZTlh N2U4MzVhZWVlZCAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDI5IEBACisyMDEyLTEyLTA2ICBBbmRy ZWkgQnVjdXIgIDxhYnVjdXJAYWRvYmUuY29tPgorCisgICAgICAgIFtDU1MgUmVnaW9uc10gUmVt b3ZlIHRoZSBzYW5pdGl6ZSBtZWNoYW5pc20gZnJvbSBMaW5lRnJhZ21lbnRhdGlvbkRhdGEKKyAg ICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTEwNDIzNAorCisg ICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIFJlbW92ZSBwcmV2 aW91cyB3b3JrIHRoYXQgZW5zdXJlZCBhbiBpbnZhbGlkIHJlZ2lvbiBpcyBuZXZlciByZXR1cm5l ZCBieSB0aGUgY29udGFpbmluZ1JlZ2lvbiBnZXR0ZXIuIEFmdGVyIHIxMzY3OTMgdGhlIGJsb2Nr cyBhbHdheXMKKyAgICAgICAgcmVsYXlvdXQgY2hpbGRyZW4gaWYgdGhlIHJlZ2lvbiBjaGFpbiBj aGFuZ2VzLiBUaGlzIG1lYW5zIHRoZSBzYW5pdGl6ZSgpIG1ldGhvZCBpcyBvbmx5IG5lY2Vzc2Fy eSB3aGVuIGFsbCB0aGUgcmVnaW9ucyBhcmUgcmVtb3ZlZC4KKyAgICAgICAgVGhpcyBjYXNlIGlz IHRyZWF0ZWQgc2VwYXJhdGVseSBpbiBsYXlvdXRJbmxpbmVDaGlsZHJlbi4KKworICAgICAgICBU ZXN0czogbm8gbmV3IGZ1bmN0aW9uYWxpdHksIG5vIGJ1ZyBmaXhlZC4KKworICAgICAgICAqIHJl bmRlcmluZy9SZW5kZXJCbG9jay5jcHA6CisgICAgICAgIChXZWJDb3JlOjpSZW5kZXJCbG9jazo6 bGluZVdpZHRoRm9yUGFnaW5hdGVkTGluZUNoYW5nZWQpOgorICAgICAgICAqIHJlbmRlcmluZy9S ZW5kZXJCbG9ja0xpbmVMYXlvdXQuY3BwOgorICAgICAgICAoV2ViQ29yZTo6UmVuZGVyQmxvY2s6 OmxheW91dElubGluZUNoaWxkcmVuKToKKyAgICAgICAgKiByZW5kZXJpbmcvUm9vdElubGluZUJv eC5jcHA6CisgICAgICAgIChXZWJDb3JlOjpSb290SW5saW5lQm94Ojpjb250YWluaW5nUmVnaW9u KToKKyAgICAgICAgKFdlYkNvcmUpOgorICAgICAgICAoV2ViQ29yZTo6Um9vdElubGluZUJveDo6 c2V0Q29udGFpbmluZ1JlZ2lvbik6CisgICAgICAgICogcmVuZGVyaW5nL1Jvb3RJbmxpbmVCb3gu aDoKKyAgICAgICAgKFJvb3RJbmxpbmVCb3gpOgorICAgICAgICAoV2ViQ29yZTo6Um9vdElubGlu ZUJveDo6TGluZUZyYWdtZW50YXRpb25EYXRhOjpMaW5lRnJhZ21lbnRhdGlvbkRhdGEpOgorICAg ICAgICAoTGluZUZyYWdtZW50YXRpb25EYXRhKToKKwogMjAxMi0xMi0wNiAgVWxhbiBEZWdlbmJh ZXYgIDx1bGFuQGNocm9taXVtLm9yZz4KIAogICAgICAgICBbdjhdIEZpeCBoaWRkZW4gcHJvcGVy dHkgbmFtZSBvZiBWOEFycmF5QnVmZmVyVmlldyBmbGFnLgpkaWZmIC0tZ2l0IGEvU291cmNlL1dl YkNvcmUvcmVuZGVyaW5nL1JlbmRlckJsb2NrLmNwcCBiL1NvdXJjZS9XZWJDb3JlL3JlbmRlcmlu Zy9SZW5kZXJCbG9jay5jcHAKaW5kZXggNjcwMjcwNzEwNTM2NDI4ZDFlNjExNDQ3ZmQ0ZjU3OGIz ZDg0MDY4OS4uYzhmYjE1NDIxZDk5MjA3NWZlYjY1ZjlkODZiY2NiZGE3MDAzMDBlYSAxMDA2NDQK LS0tIGEvU291cmNlL1dlYkNvcmUvcmVuZGVyaW5nL1JlbmRlckJsb2NrLmNwcAorKysgYi9Tb3Vy Y2UvV2ViQ29yZS9yZW5kZXJpbmcvUmVuZGVyQmxvY2suY3BwCkBAIC03MjUxLDExICs3MjUxLDgg QEAgYm9vbCBSZW5kZXJCbG9jazo6bGluZVdpZHRoRm9yUGFnaW5hdGVkTGluZUNoYW5nZWQoUm9v dElubGluZUJveCogcm9vdEJveCwgTGF5b3UKICAgICAgICAgcmV0dXJuIGZhbHNlOwogCiAgICAg UmVuZGVyUmVnaW9uKiBjdXJyZW50UmVnaW9uID0gcmVnaW9uQXRCbG9ja09mZnNldChyb290Qm94 LT5saW5lVG9wV2l0aExlYWRpbmcoKSArIGxpbmVEZWx0YSk7Ci0gICAgLy8gSnVzdCBiYWlsIGlm IHdlIHN0aWxsIGRvbid0IGhhdmUgYSByZWdpb24uCi0gICAgaWYgKCFyb290Qm94LT5oYXNDb250 YWluaW5nUmVnaW9uKCkgJiYgIWN1cnJlbnRSZWdpb24pCi0gICAgICAgIHJldHVybiBmYWxzZTsK ICAgICAvLyBKdXN0IGJhaWwgaWYgdGhlIHJlZ2lvbiBkaWRuJ3QgY2hhbmdlLgotICAgIGlmIChy b290Qm94LT5oYXNDb250YWluaW5nUmVnaW9uKCkgJiYgcm9vdEJveC0+Y29udGFpbmluZ1JlZ2lv bigpID09IGN1cnJlbnRSZWdpb24pCisgICAgaWYgKHJvb3RCb3gtPmNvbnRhaW5pbmdSZWdpb24o KSA9PSBjdXJyZW50UmVnaW9uKQogICAgICAgICByZXR1cm4gZmFsc2U7CiAgICAgcmV0dXJuIHJv b3RCb3gtPnBhZ2luYXRlZExpbmVXaWR0aCgpICE9IGF2YWlsYWJsZUxvZ2ljYWxXaWR0aEZvckNv bnRlbnQoY3VycmVudFJlZ2lvbiwgb2Zmc2V0RnJvbUxvZ2ljYWxUb3BPZkZpcnN0UGFnZSgpKTsK IH0KZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL3JlbmRlcmluZy9SZW5kZXJCbG9ja0xpbmVM YXlvdXQuY3BwIGIvU291cmNlL1dlYkNvcmUvcmVuZGVyaW5nL1JlbmRlckJsb2NrTGluZUxheW91 dC5jcHAKaW5kZXggOWUwZDdiNzczMjZiNDVhMjFhOWMyZGNlOWI3ZWYxYThlY2VlOWJjYi4uMjZl OWUzODExYTliYjgwY2EyM2U1YWJiN2JjZWEzZDgzNTNjMmY3NSAxMDA2NDQKLS0tIGEvU291cmNl L1dlYkNvcmUvcmVuZGVyaW5nL1JlbmRlckJsb2NrTGluZUxheW91dC5jcHAKKysrIGIvU291cmNl L1dlYkNvcmUvcmVuZGVyaW5nL1JlbmRlckJsb2NrTGluZUxheW91dC5jcHAKQEAgLTE3MzEsOSAr MTczMSwxMSBAQCB2b2lkIFJlbmRlckJsb2NrOjpsYXlvdXRJbmxpbmVDaGlsZHJlbihib29sIHJl bGF5b3V0Q2hpbGRyZW4sIExheW91dFVuaXQmIHJlcGFpbgogICAgIGlmICh2aWV3KCktPmxheW91 dFN0YXRlKCkgJiYgdmlldygpLT5sYXlvdXRTdGF0ZSgpLT5saW5lR3JpZCgpID09IHRoaXMpCiAg ICAgICAgIGxheW91dExpbmVHcmlkQm94KCk7CiAKKyAgICBib29sIGNsZWFyTGluZXNGb3JQYWdp bmF0aW9uID0gZmlyc3RMaW5lQm94KCkgJiYgaW5SZW5kZXJGbG93VGhyZWFkKCkgJiYgIWVuY2xv c2luZ1JlbmRlckZsb3dUaHJlYWQoKS0+aGFzUmVnaW9ucygpOworCiAgICAgLy8gRmlndXJlIG91 dCBpZiB3ZSBzaG91bGQgY2xlYXIgb3V0IG91ciBsaW5lIGJveGVzLgogICAgIC8vIEZJWE1FOiBI YW5kbGUgcmVzaXplIGV2ZW50dWFsbHkhCi0gICAgYm9vbCBpc0Z1bGxMYXlvdXQgPSAhZmlyc3RM aW5lQm94KCkgfHwgc2VsZk5lZWRzTGF5b3V0KCkgfHwgcmVsYXlvdXRDaGlsZHJlbjsKKyAgICBi b29sIGlzRnVsbExheW91dCA9ICFmaXJzdExpbmVCb3goKSB8fCBzZWxmTmVlZHNMYXlvdXQoKSB8 fCByZWxheW91dENoaWxkcmVuIHx8IGNsZWFyTGluZXNGb3JQYWdpbmF0aW9uOwogICAgIExpbmVM YXlvdXRTdGF0ZSBsYXlvdXRTdGF0ZShpc0Z1bGxMYXlvdXQsIHJlcGFpbnRMb2dpY2FsVG9wLCBy ZXBhaW50TG9naWNhbEJvdHRvbSk7CiAKICAgICBpZiAoaXNGdWxsTGF5b3V0KQpkaWZmIC0tZ2l0 IGEvU291cmNlL1dlYkNvcmUvcmVuZGVyaW5nL1Jvb3RJbmxpbmVCb3guY3BwIGIvU291cmNlL1dl YkNvcmUvcmVuZGVyaW5nL1Jvb3RJbmxpbmVCb3guY3BwCmluZGV4IGZiMWFiMmFhNmQ2OGU0OTU2 ZTZkZTdiZDJlYWRiZjkwODFiN2FiNDYuLmFlNTU0YzdjNGIxYWFmYjdmODZjM2ZlZTk0N2ExODE4 ZWM3NDlhZmEgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJDb3JlL3JlbmRlcmluZy9Sb290SW5saW5l Qm94LmNwcAorKysgYi9Tb3VyY2UvV2ViQ29yZS9yZW5kZXJpbmcvUm9vdElubGluZUJveC5jcHAK QEAgLTI1MCwyOCArMjUwLDI3IEBAIHZvaWQgUm9vdElubGluZUJveDo6Y2hpbGRSZW1vdmVkKElu bGluZUJveCogYm94KQogICAgIH0KIH0KIAorUmVuZGVyUmVnaW9uKiBSb290SW5saW5lQm94Ojpj b250YWluaW5nUmVnaW9uKCkgY29uc3QKK3sKKyAgICBSZW5kZXJSZWdpb24qIHJlZ2lvbiA9IG1f ZnJhZ21lbnRhdGlvbkRhdGEgPyBtX2ZyYWdtZW50YXRpb25EYXRhLT5tX2NvbnRhaW5pbmdSZWdp b24gOiAwOworCisjaWZuZGVmIE5ERUJVRworICAgIGlmIChyZWdpb24pIHsKKyAgICAgICAgUmVu ZGVyRmxvd1RocmVhZCogZmxvd1RocmVhZCA9IGJsb2NrKCktPmVuY2xvc2luZ1JlbmRlckZsb3dU aHJlYWQoKTsKKyAgICAgICAgY29uc3QgUmVuZGVyUmVnaW9uTGlzdCYgcmVnaW9uTGlzdCA9IGZs b3dUaHJlYWQtPnJlbmRlclJlZ2lvbkxpc3QoKTsKKyAgICAgICAgQVNTRVJUKHJlZ2lvbkxpc3Qu Y29udGFpbnMocmVnaW9uKSk7CisgICAgfQorI2VuZGlmCisKKyAgICByZXR1cm4gcmVnaW9uOwor fQorCiB2b2lkIFJvb3RJbmxpbmVCb3g6OnNldENvbnRhaW5pbmdSZWdpb24oUmVuZGVyUmVnaW9u KiByZWdpb24pCiB7CiAgICAgQVNTRVJUKCFpc0RpcnR5KCkpOwogICAgIEFTU0VSVChibG9jaygp LT5pblJlbmRlckZsb3dUaHJlYWQoKSk7CiAgICAgTGluZUZyYWdtZW50YXRpb25EYXRhKiBmcmFn bWVudGF0aW9uRGF0YSAgPSBlbnN1cmVMaW5lRnJhZ21lbnRhdGlvbkRhdGEoKTsKICAgICBmcmFn bWVudGF0aW9uRGF0YS0+bV9jb250YWluaW5nUmVnaW9uID0gcmVnaW9uOwotICAgIGZyYWdtZW50 YXRpb25EYXRhLT5tX2hhc0NvbnRhaW5pbmdSZWdpb24gPSAhIXJlZ2lvbjsKLX0KLQotUm9vdElu bGluZUJveDo6TGluZUZyYWdtZW50YXRpb25EYXRhKiBSb290SW5saW5lQm94OjpMaW5lRnJhZ21l bnRhdGlvbkRhdGE6OnNhbml0aXplKGNvbnN0IFJlbmRlckJsb2NrKiBibG9jaykKLXsKLSAgICBB U1NFUlQoYmxvY2stPmluUmVuZGVyRmxvd1RocmVhZCgpKTsKLSAgICBpZiAoIW1fY29udGFpbmlu Z1JlZ2lvbikKLSAgICAgICAgcmV0dXJuIHRoaXM7Ci0KLSAgICBSZW5kZXJGbG93VGhyZWFkKiBm bG93VGhyZWFkID0gYmxvY2stPmVuY2xvc2luZ1JlbmRlckZsb3dUaHJlYWQoKTsKLSAgICBjb25z dCBSZW5kZXJSZWdpb25MaXN0JiByZWdpb25MaXN0ID0gZmxvd1RocmVhZC0+cmVuZGVyUmVnaW9u TGlzdCgpOwotICAgIC8vIEZvciBwb2ludGVyIHR5cGVzIHRoZSBoYXNoIGZ1bmN0aW9uIGlzIHxz YWZlVG9Db21wYXJlVG9FbXB0eU9yRGVsZXRlZHwuIFRoZXJlIHNob3VsZG4ndCBiZSBhbnkgcHJv YmxlbXMgaWYgbV9jb250YWluaW5nUmVnaW9uIHdhcyBkZWxldGVkLgotICAgIGlmICghcmVnaW9u TGlzdC5jb250YWlucyhtX2NvbnRhaW5pbmdSZWdpb24pKQotICAgICAgICBtX2NvbnRhaW5pbmdS ZWdpb24gPSAwOwotCi0gICAgcmV0dXJuIHRoaXM7CiB9CiAKIExheW91dFVuaXQgUm9vdElubGlu ZUJveDo6YWxpZ25Cb3hlc0luQmxvY2tEaXJlY3Rpb24oTGF5b3V0VW5pdCBoZWlnaHRPZkJsb2Nr LCBHbHlwaE92ZXJmbG93QW5kRmFsbGJhY2tGb250c01hcCYgdGV4dEJveERhdGFNYXAsIFZlcnRp Y2FsUG9zaXRpb25DYWNoZSYgdmVydGljYWxQb3NpdGlvbkNhY2hlKQpkaWZmIC0tZ2l0IGEvU291 cmNlL1dlYkNvcmUvcmVuZGVyaW5nL1Jvb3RJbmxpbmVCb3guaCBiL1NvdXJjZS9XZWJDb3JlL3Jl bmRlcmluZy9Sb290SW5saW5lQm94LmgKaW5kZXggZTdjM2U1NGI2ZmJiMDY5NGVjOWNmZTA3NTlj ODBhNWNmZjk4Mjc3Yi4uZjNlZDM2NjU3OThlOTkzMTM2YmViYmM3YjJlOThmY2NjMmNjZmY5YyAx MDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvcmVuZGVyaW5nL1Jvb3RJbmxpbmVCb3guaAorKysg Yi9Tb3VyY2UvV2ViQ29yZS9yZW5kZXJpbmcvUm9vdElubGluZUJveC5oCkBAIC02Myw4ICs2Myw3 IEBAIHB1YmxpYzoKICAgICBMYXlvdXRVbml0IHBhZ2luYXRlZExpbmVXaWR0aCgpIGNvbnN0IHsg cmV0dXJuIG1fZnJhZ21lbnRhdGlvbkRhdGEgPyBtX2ZyYWdtZW50YXRpb25EYXRhLT5tX3BhZ2lu YXRlZExpbmVXaWR0aCA6IExheW91dFVuaXQoMCk7IH0KICAgICB2b2lkIHNldFBhZ2luYXRlZExp bmVXaWR0aChMYXlvdXRVbml0IHdpZHRoKSB7IGVuc3VyZUxpbmVGcmFnbWVudGF0aW9uRGF0YSgp LT5tX3BhZ2luYXRlZExpbmVXaWR0aCA9IHdpZHRoOyB9CiAKLSAgICBSZW5kZXJSZWdpb24qIGNv bnRhaW5pbmdSZWdpb24oKSBjb25zdCB7IHJldHVybiBtX2ZyYWdtZW50YXRpb25EYXRhID8gbV9m cmFnbWVudGF0aW9uRGF0YS0+c2FuaXRpemUoYmxvY2soKSktPm1fY29udGFpbmluZ1JlZ2lvbiA6 IDA7IH0KLSAgICBib29sIGhhc0NvbnRhaW5pbmdSZWdpb24oKSBjb25zdCB7IHJldHVybiBtX2Zy YWdtZW50YXRpb25EYXRhID8gbV9mcmFnbWVudGF0aW9uRGF0YS0+bV9oYXNDb250YWluaW5nUmVn aW9uIDogZmFsc2U7IH0KKyAgICBSZW5kZXJSZWdpb24qIGNvbnRhaW5pbmdSZWdpb24oKSBjb25z dDsKICAgICB2b2lkIHNldENvbnRhaW5pbmdSZWdpb24oUmVuZGVyUmVnaW9uKik7CiAKICAgICBM YXlvdXRVbml0IHNlbGVjdGlvblRvcCgpIGNvbnN0OwpAQCAtMjI5LDIxICsyMjgsMTYgQEAgcHJp dmF0ZToKICAgICAgICAgICAgICwgbV9wYWdpbmF0aW9uU3RydXQoMCkKICAgICAgICAgICAgICwg bV9wYWdpbmF0ZWRMaW5lV2lkdGgoMCkKICAgICAgICAgICAgICwgbV9pc0ZpcnN0QWZ0ZXJQYWdl QnJlYWsoZmFsc2UpCi0gICAgICAgICAgICAsIG1faGFzQ29udGFpbmluZ1JlZ2lvbihmYWxzZSkK ICAgICAgICAgewogCiAgICAgICAgIH0KIAotICAgICAgICBMaW5lRnJhZ21lbnRhdGlvbkRhdGEq IHNhbml0aXplKGNvbnN0IFJlbmRlckJsb2NrKik7Ci0KICAgICAgICAgLy8gSXQgc2hvdWxkIG5v dCBiZSBhc3N1bWVkIHRoZSB8Y29udGFpbmluZ1JlZ2lvbnwgaXMgYWx3YXlzIHZhbGlkLgotICAg ICAgICAvLyBJdCBjYW4gYWxzbyBiZSAwIGlmIHRoZSBmbG93IGhhcyBubyByZWdpb24gY2hhaW4g b3IgYW4gaW52YWxpZCBwb2ludGVyIGlmIHRoZSByZWdpb24gaXMgbm8gbG9uZ2VyIGluIHRoZSBj aGFpbi4KLSAgICAgICAgLy8gVXNlIHxzYW5pdGl6ZXwgdG8gZmlsdGVyIGFuIGludmFsaWQgcmVn aW9uLgorICAgICAgICAvLyBJdCBjYW4gYWxzbyBiZSAwIGlmIHRoZSBmbG93IGhhcyBubyByZWdp b24gY2hhaW4uCiAgICAgICAgIFJlbmRlclJlZ2lvbiogbV9jb250YWluaW5nUmVnaW9uOwogICAg ICAgICBMYXlvdXRVbml0IG1fcGFnaW5hdGlvblN0cnV0OwogICAgICAgICBMYXlvdXRVbml0IG1f cGFnaW5hdGVkTGluZVdpZHRoOwotICAgICAgICB1bnNpZ25lZCBtX2lzRmlyc3RBZnRlclBhZ2VC cmVhayA6IDE7Ci0gICAgICAgIHVuc2lnbmVkIG1faGFzQ29udGFpbmluZ1JlZ2lvbiA6IDE7IC8v IFdlIG5lZWQgdG8ga2VlcCB0aGlzIHRvIGRpZmZlcmVudGlhdGUgYmV0d2VlbiB0aGUgY2FzZSBv ZiBhIHZvaWQgcmVnaW9uIGFuZCBhbiBpbnZhbGlkIHJlZ2lvbi4KKyAgICAgICAgYm9vbCBtX2lz Rmlyc3RBZnRlclBhZ2VCcmVhazsKICAgICB9OwogCiAgICAgT3duUHRyPExpbmVGcmFnbWVudGF0 aW9uRGF0YT4gbV9mcmFnbWVudGF0aW9uRGF0YTsK