104134 2012-12-05 09:19:42 -0800 [Qt] QWebView uses the mobile style and doesn't follow Qt's style 2012-12-06 07:02:29 -0800 1 1 1 Unclassified WebKit New Bugs 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED Qt P3 Normal --- 103747 1 jturcotte pierre.rossi hausmann jturcotte pierre.rossi webkit.review.bot oldest_to_newest 783823 0 jturcotte 2012-12-05 09:19:42 -0800 SSIA 783840 1 jturcotte 2012-12-05 09:37:53 -0800 For some reason this seems to happen only for the first QWebPage that I create. 784153 2 177836 pierre.rossi 2012-12-05 14:58:06 -0800 Created attachment 177836 Patch 784177 3 177836 pierre.rossi 2012-12-05 15:19:33 -0800 Comment on attachment 177836 Patch Simpler patch coming up... 784214 4 177836 pierre.rossi 2012-12-05 15:51:59 -0800 Comment on attachment 177836 Patch I thought I'd move the call to initializeWebKitWidgets up in QWebPage's constructor, but it's not going to be better in there because of the member initialization, and so it would boil down to the same thing. We are shooting ourselves in the foot by having QtTestBrowser always discard the first WebPage it constructs, it contributed to keep this silly mistake hidden until we merged it in Qt5... :( 784273 5 177836 kenneth 2012-12-05 16:48:29 -0800 Comment on attachment 177836 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=177836&action=review > Source/WebKit/qt/WebCoreSupport/QWebPageAdapter.cpp:172 > +void QWebPageAdapter::initWebCorePage() initialize please... consistency 784750 6 177969 pierre.rossi 2012-12-06 01:32:56 -0800 Created attachment 177969 Patch 784871 7 177969 hausmann 2012-12-06 05:24:24 -0800 Comment on attachment 177969 Patch Oops 784919 8 177969 webkit.review.bot 2012-12-06 07:02:25 -0800 Comment on attachment 177969 Patch Clearing flags on attachment: 177969 Committed r136842: <http://trac.webkit.org/changeset/136842> 784920 9 webkit.review.bot 2012-12-06 07:02:29 -0800 All reviewed patches have been landed. Closing bug. 177836 2012-12-05 14:58:06 -0800 2012-12-06 01:32:52 -0800 Patch bug-104134-20121205235840.patch text/plain 3503 pierre.rossi U3VidmVyc2lvbiBSZXZpc2lvbjogMTM2NzYyCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0L3F0 L0NoYW5nZUxvZyBiL1NvdXJjZS9XZWJLaXQvcXQvQ2hhbmdlTG9nCmluZGV4IGY3N2E3YWQ4OGU4 NzE0MmI0MTVhMGQwZGRkMDQ4OTA0YzMzNjg0YjguLjY0OGFlNmVlNGI1NDE2NmQ4YmI5NTljNTVj OTE4YTc5NzIzZDAyYWIgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQvcXQvQ2hhbmdlTG9nCisr KyBiL1NvdXJjZS9XZWJLaXQvcXQvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMjUgQEAKKzIwMTItMTIt MDUgIFBpZXJyZSBSb3NzaSAgPHBpZXJyZS5yb3NzaUBnbWFpbC5jb20+CisKKyAgICAgICAgW1F0 XSBRV2ViVmlldyB1c2VzIHRoZSBtb2JpbGUgc3R5bGUgYW5kIGRvZXNuJ3QgZm9sbG93IFF0J3Mg c3R5bGUKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTEw NDEzNAorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIEFu b3RoZXIgaXNzdWUgaW50cm9kdWNlZCBieSByMTM2MjM1LgorICAgICAgICBGaXggdGhlIG9yZGVy IG9mIGluaXRpYWxpemF0aW9uIG9mIHRoZSBzdHlsZUZhY3RvcnkgYW5kIGNyZWF0aW9uIG9mIHRo ZQorICAgICAgICBXZWJDb3JlIFBhZ2UuIFNpbmNlIHRoZSBsYXR0ZXIgaGFzIGEgUmVuZGVyVGhl bWUgbWVtYmVyIGFuZCB0aGUgY3JlYXRpb24KKyAgICAgICAgb2YgdGhlIGFwcHJvcHJpYXRlIFJl bmRlclRoZW1lIHR5cGUgKFFTdHlsZS1iYWNrZWQpIGlzIGRlcGVuZGFudCBvbiBoYXZpbmcKKyAg ICAgICAgZmlyc3QgaW5pdGlhbGl6ZWQgdGhlIHRoZW1lIGZhY3RvcnkgZnVuY3Rpb24sIHdlIG5l ZWQgdG8gcG9zdHBvbmUgdGhpcyBqdXN0CisgICAgICAgIGEgbGl0dGxlIGJpdC4KKworICAgICAg ICAqIFdlYkNvcmVTdXBwb3J0L1FXZWJQYWdlQWRhcHRlci5jcHA6CisgICAgICAgIChRV2ViUGFn ZUFkYXB0ZXI6OlFXZWJQYWdlQWRhcHRlcik6CisgICAgICAgIChRV2ViUGFnZUFkYXB0ZXI6Omlu aXRXZWJDb3JlUGFnZSk6IEFkZGVkLgorICAgICAgICAqIFdlYkNvcmVTdXBwb3J0L1FXZWJQYWdl QWRhcHRlci5oOgorICAgICAgICAqIFdpZGdldEFwaS9xd2VicGFnZS5jcHA6CisgICAgICAgIChR V2ViUGFnZVByaXZhdGU6OlFXZWJQYWdlUHJpdmF0ZSk6IGNhbGwgaW5pdFdlYkNvcmVQYWdlIGFm dGVyIGhhdmluZyBpbml0aWFsaXplZAorICAgICAgICBXZWJLaXRXaWRnZXRzIHJlbGF0ZWQgbG9n aWMgKFFTdHlsZSBob29rcyBpbiB0aGlzIGNhc2UpLgorCiAyMDEyLTEyLTA1ICBaZW5vIEFsYmlz c2VyICA8emVub0B3ZWJraXQub3JnPgogCiAgICAgICAgIFtRdF1bTWFjXSBRV2ViVmlldyBkaXNh cHBlYXJzIHdoZW4gdGhlIHN5c3RlbSB0cmllcyB0byBoaWRlIHRoZSBzY3JvbGxiYXJzLgpkaWZm IC0tZ2l0IGEvU291cmNlL1dlYktpdC9xdC9XZWJDb3JlU3VwcG9ydC9RV2ViUGFnZUFkYXB0ZXIu Y3BwIGIvU291cmNlL1dlYktpdC9xdC9XZWJDb3JlU3VwcG9ydC9RV2ViUGFnZUFkYXB0ZXIuY3Bw CmluZGV4IGNiOTNjZDlmN2MzMDc4NTM0MzliMzU4OThkOTM4ODZkN2Q3YTViZDAuLjA2ZjE5ZGZl M2VhMGYxMDExNTBiYmFhYTJmMjNiNzk2NWE3NjA0MGIgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJL aXQvcXQvV2ViQ29yZVN1cHBvcnQvUVdlYlBhZ2VBZGFwdGVyLmNwcAorKysgYi9Tb3VyY2UvV2Vi S2l0L3F0L1dlYkNvcmVTdXBwb3J0L1FXZWJQYWdlQWRhcHRlci5jcHAKQEAgLTE2NywxMCArMTY3 LDEzIEBAIFFXZWJQYWdlQWRhcHRlcjo6UVdlYlBhZ2VBZGFwdGVyKCkKICAgICAsIG5ldHdvcmtN YW5hZ2VyKDApCiB7CiAgICAgV2ViQ29yZTo6aW5pdGlhbGl6ZVdlYkNvcmVRdCgpOworfQorCit2 b2lkIFFXZWJQYWdlQWRhcHRlcjo6aW5pdFdlYkNvcmVQYWdlKCkKK3sKICNpZiBFTkFCTEUoR0VP TE9DQVRJT04pIHx8IEVOQUJMRShERVZJQ0VfT1JJRU5UQVRJT04pCiAgICAgYm9vbCB1c2VNb2Nr ID0gUVdlYlBhZ2VBZGFwdGVyOjpkcnRSdW47CiAjZW5kaWYKLQogICAgIFBhZ2U6OlBhZ2VDbGll bnRzIHBhZ2VDbGllbnRzOwogICAgIHBhZ2VDbGllbnRzLmNocm9tZUNsaWVudCA9IG5ldyBDaHJv bWVDbGllbnRRdCh0aGlzKTsKICAgICBwYWdlQ2xpZW50cy5jb250ZXh0TWVudUNsaWVudCA9IG5l dyBDb250ZXh0TWVudUNsaWVudFF0KCk7CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0L3F0L1dl YkNvcmVTdXBwb3J0L1FXZWJQYWdlQWRhcHRlci5oIGIvU291cmNlL1dlYktpdC9xdC9XZWJDb3Jl U3VwcG9ydC9RV2ViUGFnZUFkYXB0ZXIuaAppbmRleCA4N2I0ZWNkMTRhZmY1NDFhZDhmZTI3MWU5 Njk4ZGFmMzM0N2JhZGJhLi4yMWJjODZlODA0OGM5ZjI0YjY1Mjk4OTEwNDMyZTE5MzE2NDgzYzBm IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViS2l0L3F0L1dlYkNvcmVTdXBwb3J0L1FXZWJQYWdlQWRh cHRlci5oCisrKyBiL1NvdXJjZS9XZWJLaXQvcXQvV2ViQ29yZVN1cHBvcnQvUVdlYlBhZ2VBZGFw dGVyLmgKQEAgLTEzNiw2ICsxMzYsOSBAQCBwdWJsaWM6CiAgICAgLy8gdGhlIFFXZWJQYWdlQWRh cHRlciBhbmQgdGhlIFFXZWJQYWdlUHJpdmF0ZSBhcmUgaW50YWN0IHdoZW4KICAgICAvLyB2YXJp b3VzIGRlc3RydWN0aW9uIGNhbGxiYWNrcyBmcm9tIFdlYkNvcmU6OlBhZ2U6On5QYWdlKCkgaGl0 IHVzLgogICAgIHZvaWQgZGVsZXRlUGFnZSgpOworICAgIC8vIEZvciBzaW1pbGFyIHJlYXNvbnMs IHdlIGRvbid0IHdhbnQgdG8gY3JlYXRlIHRoZSBXZWJDb3JlIFBhZ2UgYmVmb3JlCisgICAgLy8g d2UgcHJvcGVybHkgaW5pdGlhbGl6ZWQgdGhlIHN0eWxlIGZhY3RvcnkgY2FsbGJhY2tzLgorICAg IHZvaWQgaW5pdFdlYkNvcmVQYWdlKCk7CiAKICAgICB2aXJ0dWFsIHZvaWQgc2hvdygpID0gMDsK ICAgICB2aXJ0dWFsIHZvaWQgc2V0Rm9jdXMoKSA9IDA7CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2Vi S2l0L3F0L1dpZGdldEFwaS9xd2VicGFnZS5jcHAgYi9Tb3VyY2UvV2ViS2l0L3F0L1dpZGdldEFw aS9xd2VicGFnZS5jcHAKaW5kZXggYzExNzZjZjY2OWFhZjA4YzBlNGRlZjYyMzFmNjI4ZTNiNmIz ZTBkOS4uMWNhMWZiNDYxMWVlN2UyMjk1MDE5ZWVhOWE0MjJjZDc4OTcwOTRlYSAxMDA2NDQKLS0t IGEvU291cmNlL1dlYktpdC9xdC9XaWRnZXRBcGkvcXdlYnBhZ2UuY3BwCisrKyBiL1NvdXJjZS9X ZWJLaXQvcXQvV2lkZ2V0QXBpL3F3ZWJwYWdlLmNwcApAQCAtMjAxLDYgKzIwMSw3IEBAIFFXZWJQ YWdlUHJpdmF0ZTo6UVdlYlBhZ2VQcml2YXRlKFFXZWJQYWdlICpxcSkKICAgICAsIG1fbGFzdERy b3BBY3Rpb24oUXQ6Oklnbm9yZUFjdGlvbikKIHsKICAgICBXZWJLaXQ6OmluaXRpYWxpemVXZWJL aXRXaWRnZXRzKCk7CisgICAgaW5pdFdlYkNvcmVQYWdlKCk7CiAgICAgbWVtc2V0KGFjdGlvbnMs IDAsIHNpemVvZihhY3Rpb25zKSk7CiAKICNpZiBFTkFCTEUoTk9USUZJQ0FUSU9OUykgfHwgRU5B QkxFKExFR0FDWV9OT1RJRklDQVRJT05TKQo= 177969 2012-12-06 01:32:56 -0800 2012-12-06 07:02:24 -0800 Patch bug-104134-20121206103024.patch text/plain 3539 pierre.rossi U3VidmVyc2lvbiBSZXZpc2lvbjogMTM2NzczCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0L3F0 L0NoYW5nZUxvZyBiL1NvdXJjZS9XZWJLaXQvcXQvQ2hhbmdlTG9nCmluZGV4IGY3N2E3YWQ4OGU4 NzE0MmI0MTVhMGQwZGRkMDQ4OTA0YzMzNjg0YjguLjU4ZmI2OTk2MjJlNjY4ZTM4YjFjZjg4ZGFm YzRiOGMwNWUzYTYzMmUgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQvcXQvQ2hhbmdlTG9nCisr KyBiL1NvdXJjZS9XZWJLaXQvcXQvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMjUgQEAKKzIwMTItMTIt MDUgIFBpZXJyZSBSb3NzaSAgPHBpZXJyZS5yb3NzaUBnbWFpbC5jb20+CisKKyAgICAgICAgW1F0 XSBRV2ViVmlldyB1c2VzIHRoZSBtb2JpbGUgc3R5bGUgYW5kIGRvZXNuJ3QgZm9sbG93IFF0J3Mg c3R5bGUKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTEw NDEzNAorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIEFu b3RoZXIgaXNzdWUgaW50cm9kdWNlZCBieSByMTM2MjM1LgorICAgICAgICBGaXggdGhlIG9yZGVy IG9mIGluaXRpYWxpemF0aW9uIG9mIHRoZSBzdHlsZUZhY3RvcnkgYW5kIGNyZWF0aW9uIG9mIHRo ZQorICAgICAgICBXZWJDb3JlIFBhZ2UuIFNpbmNlIHRoZSBsYXR0ZXIgaGFzIGEgUmVuZGVyVGhl bWUgbWVtYmVyIGFuZCB0aGUgY3JlYXRpb24KKyAgICAgICAgb2YgdGhlIGFwcHJvcHJpYXRlIFJl bmRlclRoZW1lIHR5cGUgKFFTdHlsZS1iYWNrZWQpIGlzIGRlcGVuZGFudCBvbiBoYXZpbmcKKyAg ICAgICAgZmlyc3QgaW5pdGlhbGl6ZWQgdGhlIHRoZW1lIGZhY3RvcnkgZnVuY3Rpb24sIHdlIG5l ZWQgdG8gcG9zdHBvbmUgdGhpcyBqdXN0CisgICAgICAgIGEgbGl0dGxlIGJpdC4KKworICAgICAg ICAqIFdlYkNvcmVTdXBwb3J0L1FXZWJQYWdlQWRhcHRlci5jcHA6CisgICAgICAgIChRV2ViUGFn ZUFkYXB0ZXI6OlFXZWJQYWdlQWRhcHRlcik6CisgICAgICAgIChRV2ViUGFnZUFkYXB0ZXI6Omlu aXRpYWxpemVXZWJDb3JlUGFnZSk6IEFkZGVkLgorICAgICAgICAqIFdlYkNvcmVTdXBwb3J0L1FX ZWJQYWdlQWRhcHRlci5oOgorICAgICAgICAqIFdpZGdldEFwaS9xd2VicGFnZS5jcHA6CisgICAg ICAgIChRV2ViUGFnZVByaXZhdGU6OlFXZWJQYWdlUHJpdmF0ZSk6IGNhbGwgaW5pdGlhbGl6ZVdl YkNvcmVQYWdlIG9ubHkgYWZ0ZXIgCisgICAgICAgIGhhdmluZyBpbml0aWFsaXplZCBXZWJLaXRX aWRnZXRzIHJlbGF0ZWQgbG9naWMgKFFTdHlsZSBob29rcyBpbiB0aGlzIGNhc2UpLgorCiAyMDEy LTEyLTA1ICBaZW5vIEFsYmlzc2VyICA8emVub0B3ZWJraXQub3JnPgogCiAgICAgICAgIFtRdF1b TWFjXSBRV2ViVmlldyBkaXNhcHBlYXJzIHdoZW4gdGhlIHN5c3RlbSB0cmllcyB0byBoaWRlIHRo ZSBzY3JvbGxiYXJzLgpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYktpdC9xdC9XZWJDb3JlU3VwcG9y dC9RV2ViUGFnZUFkYXB0ZXIuY3BwIGIvU291cmNlL1dlYktpdC9xdC9XZWJDb3JlU3VwcG9ydC9R V2ViUGFnZUFkYXB0ZXIuY3BwCmluZGV4IGNiOTNjZDlmN2MzMDc4NTM0MzliMzU4OThkOTM4ODZk N2Q3YTViZDAuLjU1ODhjMTFiYjQ2MzQ1YzcxODRhN2I1NmU4ZmVjYzEzOTEyODczNDIgMTAwNjQ0 Ci0tLSBhL1NvdXJjZS9XZWJLaXQvcXQvV2ViQ29yZVN1cHBvcnQvUVdlYlBhZ2VBZGFwdGVyLmNw cAorKysgYi9Tb3VyY2UvV2ViS2l0L3F0L1dlYkNvcmVTdXBwb3J0L1FXZWJQYWdlQWRhcHRlci5j cHAKQEAgLTE2NywxMCArMTY3LDEzIEBAIFFXZWJQYWdlQWRhcHRlcjo6UVdlYlBhZ2VBZGFwdGVy KCkKICAgICAsIG5ldHdvcmtNYW5hZ2VyKDApCiB7CiAgICAgV2ViQ29yZTo6aW5pdGlhbGl6ZVdl YkNvcmVRdCgpOworfQorCit2b2lkIFFXZWJQYWdlQWRhcHRlcjo6aW5pdGlhbGl6ZVdlYkNvcmVQ YWdlKCkKK3sKICNpZiBFTkFCTEUoR0VPTE9DQVRJT04pIHx8IEVOQUJMRShERVZJQ0VfT1JJRU5U QVRJT04pCiAgICAgYm9vbCB1c2VNb2NrID0gUVdlYlBhZ2VBZGFwdGVyOjpkcnRSdW47CiAjZW5k aWYKLQogICAgIFBhZ2U6OlBhZ2VDbGllbnRzIHBhZ2VDbGllbnRzOwogICAgIHBhZ2VDbGllbnRz LmNocm9tZUNsaWVudCA9IG5ldyBDaHJvbWVDbGllbnRRdCh0aGlzKTsKICAgICBwYWdlQ2xpZW50 cy5jb250ZXh0TWVudUNsaWVudCA9IG5ldyBDb250ZXh0TWVudUNsaWVudFF0KCk7CmRpZmYgLS1n aXQgYS9Tb3VyY2UvV2ViS2l0L3F0L1dlYkNvcmVTdXBwb3J0L1FXZWJQYWdlQWRhcHRlci5oIGIv U291cmNlL1dlYktpdC9xdC9XZWJDb3JlU3VwcG9ydC9RV2ViUGFnZUFkYXB0ZXIuaAppbmRleCA4 N2I0ZWNkMTRhZmY1NDFhZDhmZTI3MWU5Njk4ZGFmMzM0N2JhZGJhLi5kYmJhN2Y1YjI2OTA3ZDE2 NjU2ODE4ZDdkMmJjNDg5NTQ0NDNhMDYwIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViS2l0L3F0L1dl YkNvcmVTdXBwb3J0L1FXZWJQYWdlQWRhcHRlci5oCisrKyBiL1NvdXJjZS9XZWJLaXQvcXQvV2Vi Q29yZVN1cHBvcnQvUVdlYlBhZ2VBZGFwdGVyLmgKQEAgLTEzNiw2ICsxMzYsOSBAQCBwdWJsaWM6 CiAgICAgLy8gdGhlIFFXZWJQYWdlQWRhcHRlciBhbmQgdGhlIFFXZWJQYWdlUHJpdmF0ZSBhcmUg aW50YWN0IHdoZW4KICAgICAvLyB2YXJpb3VzIGRlc3RydWN0aW9uIGNhbGxiYWNrcyBmcm9tIFdl YkNvcmU6OlBhZ2U6On5QYWdlKCkgaGl0IHVzLgogICAgIHZvaWQgZGVsZXRlUGFnZSgpOworICAg IC8vIEZvciBzaW1pbGFyIHJlYXNvbnMsIHdlIGRvbid0IHdhbnQgdG8gY3JlYXRlIHRoZSBXZWJD b3JlIFBhZ2UgYmVmb3JlCisgICAgLy8gd2UgcHJvcGVybHkgaW5pdGlhbGl6ZWQgdGhlIHN0eWxl IGZhY3RvcnkgY2FsbGJhY2tzLgorICAgIHZvaWQgaW5pdGlhbGl6ZVdlYkNvcmVQYWdlKCk7CiAK ICAgICB2aXJ0dWFsIHZvaWQgc2hvdygpID0gMDsKICAgICB2aXJ0dWFsIHZvaWQgc2V0Rm9jdXMo KSA9IDA7CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0L3F0L1dpZGdldEFwaS9xd2VicGFnZS5j cHAgYi9Tb3VyY2UvV2ViS2l0L3F0L1dpZGdldEFwaS9xd2VicGFnZS5jcHAKaW5kZXggYzExNzZj ZjY2OWFhZjA4YzBlNGRlZjYyMzFmNjI4ZTNiNmIzZTBkOS4uZjljZWMzZTU0NzMyNmUyMzg2ZGVi NWY2N2QxYWMwOTE3ZTQzOGJhNCAxMDA2NDQKLS0tIGEvU291cmNlL1dlYktpdC9xdC9XaWRnZXRB cGkvcXdlYnBhZ2UuY3BwCisrKyBiL1NvdXJjZS9XZWJLaXQvcXQvV2lkZ2V0QXBpL3F3ZWJwYWdl LmNwcApAQCAtMjAxLDYgKzIwMSw3IEBAIFFXZWJQYWdlUHJpdmF0ZTo6UVdlYlBhZ2VQcml2YXRl KFFXZWJQYWdlICpxcSkKICAgICAsIG1fbGFzdERyb3BBY3Rpb24oUXQ6Oklnbm9yZUFjdGlvbikK IHsKICAgICBXZWJLaXQ6OmluaXRpYWxpemVXZWJLaXRXaWRnZXRzKCk7CisgICAgaW5pdGlhbGl6 ZVdlYkNvcmVQYWdlKCk7CiAgICAgbWVtc2V0KGFjdGlvbnMsIDAsIHNpemVvZihhY3Rpb25zKSk7 CiAKICNpZiBFTkFCTEUoTk9USUZJQ0FUSU9OUykgfHwgRU5BQkxFKExFR0FDWV9OT1RJRklDQVRJ T05TKQo=