104127 2012-12-05 08:34:41 -0800 [Qt] Implement SimpleFontData::platformBoundsForGlyph 2013-02-19 05:11:27 -0800 1 1 1 Unclassified WebKit Text 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 110211 1 allan.jensen allan.jensen noam webkit.review.bot oldest_to_newest 783783 0 allan.jensen 2012-12-05 08:34:41 -0800 We are missing a Qt implementation of platformBoundsForGlyph. This method is essential to working MathML and Ruby support. With this method implementated MathML is possible to enable and use. 783784 1 177760 allan.jensen 2012-12-05 08:37:04 -0800 Created attachment 177760 Patch 784856 2 177760 jturcotte 2012-12-06 04:51:49 -0800 Comment on attachment 177760 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=177760&action=review > Source/WebCore/platform/graphics/qt/SimpleFontDataQt.cpp:72 > + // Round to pixel bounds. > + return enclosingIntRect(bounds); Other platforms don't seem to round it, why do we need to? 784974 3 allan.jensen 2012-12-06 09:06:14 -0800 (In reply to comment #2) > (From update of attachment 177760 [details]) > View in context: https://bugs.webkit.org/attachment.cgi?id=177760&action=review > > > Source/WebCore/platform/graphics/qt/SimpleFontDataQt.cpp:72 > > + // Round to pixel bounds. > > + return enclosingIntRect(bounds); > > Other platforms don't seem to round it, why do we need to? Actually I followed Chromium here. They round whenever they don't have subpixel text rendering, and I think we currently use integer metrics only in Qt. I didn't see any artifacts when I ran it without rounding though, so I can't really say we need it. 792553 4 179702 allan.jensen 2012-12-17 01:34:30 -0800 Created attachment 179702 Patch Do not round so that returned width matches that of platformWidthForGlyph 799298 5 allan.jensen 2013-01-03 00:43:58 -0800 Committed r138703: <http://trac.webkit.org/changeset/138703> 177760 2012-12-05 08:37:04 -0800 2012-12-17 01:34:26 -0800 Patch bug-104127-20121205173400.patch text/plain 1895 allan.jensen U3VidmVyc2lvbiBSZXZpc2lvbjogMTM2NjUxCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggNDU0OTcxMzFmYWZkZGY0 Mzc5N2Q3OGNiMzEyZDcyNjQ3NjAyNzZiNi4uNGRiZjFiYjllNmVhNjdjMDJmYThkOTQzNDcwYTQ0 MTQ4NjIyNzQ1NyAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE1IEBACisyMDEyLTEyLTA1ICBBbGxh biBTYW5kZmVsZCBKZW5zZW4gIDxhbGxhbi5qZW5zZW5AZGlnaWEuY29tPgorCisgICAgICAgIFtR dF0gSW1wbGVtZW50IFNpbXBsZUZvbnREYXRhOjpwbGF0Zm9ybUJvdW5kc0ZvckdseXBoCisgICAg ICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xMDQxMjcKKworICAg ICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBJbXBsZW1lbnRzIHBs YXRmb3JtQm91bmRzRm9yR2x5cGggd2hpY2ggaXMgbmVjZXNzYXJ5IGZvciB3b3JraW5nIE1hdGhN TCBhbmQgUnVieS4KKworICAgICAgICAqIHBsYXRmb3JtL2dyYXBoaWNzL3F0L1NpbXBsZUZvbnRE YXRhUXQuY3BwOgorICAgICAgICAoV2ViQ29yZTo6U2ltcGxlRm9udERhdGE6OnBsYXRmb3JtQm91 bmRzRm9yR2x5cGgpOgorCiAyMDEyLTEyLTA1ICBBbmRyZXkgQWRhaWtpbiAgPGFhbmRyZXlAY2hy b21pdW0ub3JnPgogCiAgICAgICAgIFdlYiBJbnNwZWN0b3I6IFtDYW52YXNdIG5pdDogYWRkIG1v cmUgdHlwaXphdGlvbiBmb3IganMgY29tcGlsZXIKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3Jl L3BsYXRmb3JtL2dyYXBoaWNzL3F0L1NpbXBsZUZvbnREYXRhUXQuY3BwIGIvU291cmNlL1dlYkNv cmUvcGxhdGZvcm0vZ3JhcGhpY3MvcXQvU2ltcGxlRm9udERhdGFRdC5jcHAKaW5kZXggNDE1ZjAw ZDQ0NmMxOGEwOGJiYzhiZGI4YjQ3Y2I1Njg1ZDNjMTA3YS4uOGM1NjJiYjA3M2FmYjQ4YTQ1OTkw YTc4MTE4YTQ1ZmE2ZDgxNzI0NiAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvcGxhdGZvcm0v Z3JhcGhpY3MvcXQvU2ltcGxlRm9udERhdGFRdC5jcHAKKysrIGIvU291cmNlL1dlYkNvcmUvcGxh dGZvcm0vZ3JhcGhpY3MvcXQvU2ltcGxlRm9udERhdGFRdC5jcHAKQEAgLTI0LDYgKzI0LDcgQEAK ICNpbmNsdWRlICJjb25maWcuaCIKICNpbmNsdWRlICJTaW1wbGVGb250RGF0YS5oIgogCisjaW5j bHVkZSAiSW50UmVjdC5oIgogI2luY2x1ZGUgIk5vdEltcGxlbWVudGVkLmgiCiAKIG5hbWVzcGFj ZSBXZWJDb3JlIHsKQEAgLTY0LDEwICs2NSwxMSBAQCBQYXNzUmVmUHRyPFNpbXBsZUZvbnREYXRh PiBTaW1wbGVGb250RGF0YTo6Y3JlYXRlU2NhbGVkRm9udERhdGEoY29uc3QgRm9udERlc2NyaQog ICAgIHJldHVybiBTaW1wbGVGb250RGF0YTo6Y3JlYXRlKEZvbnRQbGF0Zm9ybURhdGEobV9wbGF0 Zm9ybURhdGEsIHNjYWxlZFNpemUpLCBpc0N1c3RvbUZvbnQoKSwgZmFsc2UpOwogfQogCi1GbG9h dFJlY3QgU2ltcGxlRm9udERhdGE6OnBsYXRmb3JtQm91bmRzRm9yR2x5cGgoR2x5cGgpIGNvbnN0 CitGbG9hdFJlY3QgU2ltcGxlRm9udERhdGE6OnBsYXRmb3JtQm91bmRzRm9yR2x5cGgoR2x5cGgg Z2x5cGgpIGNvbnN0CiB7Ci0gICAgbm90SW1wbGVtZW50ZWQoKTsKLSAgICByZXR1cm4gRmxvYXRS ZWN0KCk7CisgICAgUVJlY3RGIGJvdW5kcyA9IG1fcGxhdGZvcm1EYXRhLnJhd0ZvbnQoKS5ib3Vu ZGluZ1JlY3QoZ2x5cGgpOworICAgIC8vIFJvdW5kIHRvIHBpeGVsIGJvdW5kcy4KKyAgICByZXR1 cm4gZW5jbG9zaW5nSW50UmVjdChib3VuZHMpOwogfQogCiB2b2lkIFNpbXBsZUZvbnREYXRhOjpw bGF0Zm9ybUluaXQoKQo= 179702 2012-12-17 01:34:30 -0800 2013-01-02 03:02:55 -0800 Patch bug-104127-20121217103117.patch text/plain 1638 allan.jensen U3VidmVyc2lvbiBSZXZpc2lvbjogMTM3ODg1CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggYjg1ZWQxYmI2Zjc3YjJl YWI3MmIxOWE5NzY0NTJlMjZiMWE4NWE5ZS4uZDBlNzMyNWFlZjRmNTZlYjA0Yzg2M2ZjYzdhYTY4 NzJkNDU4MWM1NSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE1IEBACisyMDEyLTEyLTA1ICBBbGxh biBTYW5kZmVsZCBKZW5zZW4gIDxhbGxhbi5qZW5zZW5AZGlnaWEuY29tPgorCisgICAgICAgIFtR dF0gSW1wbGVtZW50IFNpbXBsZUZvbnREYXRhOjpwbGF0Zm9ybUJvdW5kc0ZvckdseXBoCisgICAg ICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xMDQxMjcKKworICAg ICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBJbXBsZW1lbnRzIHBs YXRmb3JtQm91bmRzRm9yR2x5cGggd2hpY2ggaXMgbmVjZXNzYXJ5IGZvciB3b3JraW5nIE1hdGhN TCBhbmQgUnVieS4KKworICAgICAgICAqIHBsYXRmb3JtL2dyYXBoaWNzL3F0L1NpbXBsZUZvbnRE YXRhUXQuY3BwOgorICAgICAgICAoV2ViQ29yZTo6U2ltcGxlRm9udERhdGE6OnBsYXRmb3JtQm91 bmRzRm9yR2x5cGgpOgorCiAyMDEyLTEyLTE3ICBLZW50YXJvIEhhcmEgIDxoYXJha2VuQGNocm9t aXVtLm9yZz4KIAogICAgICAgICBVbnJldmlld2VkLCByb2xsaW5nIG91dCByMTM2Nzk0LgpkaWZm IC0tZ2l0IGEvU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vZ3JhcGhpY3MvcXQvU2ltcGxlRm9udERh dGFRdC5jcHAgYi9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9ncmFwaGljcy9xdC9TaW1wbGVGb250 RGF0YVF0LmNwcAppbmRleCA0MTVmMDBkNDQ2YzE4YTA4YmJjOGJkYjhiNDdjYjU2ODVkM2MxMDdh Li40NDA5OWIzZWIyYzE5OGRjNDEwYmQ3NmNmMmZkMGUyNjcxNWYwOTA4IDEwMDY0NAotLS0gYS9T b3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9ncmFwaGljcy9xdC9TaW1wbGVGb250RGF0YVF0LmNwcAor KysgYi9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9ncmFwaGljcy9xdC9TaW1wbGVGb250RGF0YVF0 LmNwcApAQCAtNjQsMTAgKzY0LDkgQEAgUGFzc1JlZlB0cjxTaW1wbGVGb250RGF0YT4gU2ltcGxl Rm9udERhdGE6OmNyZWF0ZVNjYWxlZEZvbnREYXRhKGNvbnN0IEZvbnREZXNjcmkKICAgICByZXR1 cm4gU2ltcGxlRm9udERhdGE6OmNyZWF0ZShGb250UGxhdGZvcm1EYXRhKG1fcGxhdGZvcm1EYXRh LCBzY2FsZWRTaXplKSwgaXNDdXN0b21Gb250KCksIGZhbHNlKTsKIH0KIAotRmxvYXRSZWN0IFNp bXBsZUZvbnREYXRhOjpwbGF0Zm9ybUJvdW5kc0ZvckdseXBoKEdseXBoKSBjb25zdAorRmxvYXRS ZWN0IFNpbXBsZUZvbnREYXRhOjpwbGF0Zm9ybUJvdW5kc0ZvckdseXBoKEdseXBoIGdseXBoKSBj b25zdAogewotICAgIG5vdEltcGxlbWVudGVkKCk7Ci0gICAgcmV0dXJuIEZsb2F0UmVjdCgpOwor ICAgIHJldHVybiBtX3BsYXRmb3JtRGF0YS5yYXdGb250KCkuYm91bmRpbmdSZWN0KGdseXBoKTsK IH0KIAogdm9pZCBTaW1wbGVGb250RGF0YTo6cGxhdGZvcm1Jbml0KCkK