103892 2012-12-03 07:36:36 -0800 [Chromium] Fix issue with hard coded error codes in quota error 2012-12-03 12:30:52 -0800 1 1 1 Unclassified WebKit New Bugs 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 102726 1 arv arv abarth dglazkov fishd jamesr jsbell michaeln ojan tkent+wkapi webkit.review.bot oldest_to_newest 781433 0 arv 2012-12-03 07:36:36 -0800 [Chromium] Fix issue with hard coded error codes in quota error 781434 1 177252 arv 2012-12-03 07:39:01 -0800 Created attachment 177252 Patch 781448 2 arv 2012-12-03 07:45:49 -0800 This is the first step to fix this. Once this is in and a WebKit roll is done to Chrome, the next step is to use the enum names in Chrome instead of the hard coded values. The last step is to then to have these enum values get their values from ExceptionCode. 781470 3 webkit.review.bot 2012-12-03 08:10:36 -0800 Please wait for approval from abarth@webkit.org, dglazkov@chromium.org, fishd@chromium.org, jamesr@chromium.org or tkent@chromium.org before submitting, as this patch contains changes to the Chromium public API. See also https://trac.webkit.org/wiki/ChromiumWebKitAPI. 781608 4 177252 fishd 2012-12-03 10:34:29 -0800 Comment on attachment 177252 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=177252&action=review > Source/WebKit/chromium/public/WebStorageQuotaError.h:39 > + WebStorageQuotaErrorInvalidModification = 13, Note: Please be sure to update AssertMatchingEnums.cpp once there is a WebCore equivalent to these new enum values. 781664 5 arv 2012-12-03 11:05:33 -0800 (In reply to comment #4) > (From update of attachment 177252 [details]) > View in context: https://bugs.webkit.org/attachment.cgi?id=177252&action=review > > > Source/WebKit/chromium/public/WebStorageQuotaError.h:39 > > + WebStorageQuotaErrorInvalidModification = 13, > > Note: Please be sure to update AssertMatchingEnums.cpp once there is a WebCore equivalent to these new enum values. I added them now since the WebCore side has these already. 781668 6 arv 2012-12-03 11:08:18 -0800 Committed r136419: <http://trac.webkit.org/changeset/136419> 781769 7 fishd 2012-12-03 12:30:52 -0800 (In reply to comment #5) > > Note: Please be sure to update AssertMatchingEnums.cpp once there is a WebCore equivalent to these new enum values. > > I added them now since the WebCore side has these already. Cool, thanks. 177252 2012-12-03 07:39:01 -0800 2012-12-03 10:34:29 -0800 Patch bug-103892-20121203103628.patch text/plain 1560 arv U3VidmVyc2lvbiBSZXZpc2lvbjogMTM2Mzk2CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0L2No cm9taXVtL0NoYW5nZUxvZyBiL1NvdXJjZS9XZWJLaXQvY2hyb21pdW0vQ2hhbmdlTG9nCmluZGV4 IGM0ZDg5YmUzYTgxMWVlMGNmYTFhYzAyMzAwNzkzMTEwYTA3ZGNmM2YuLmUzODlmMTlmYzFmZmNj YWVhYzczMWY1OGM4MGU1YzYyZmYzYzUxNDAgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQvY2hy b21pdW0vQ2hhbmdlTG9nCisrKyBiL1NvdXJjZS9XZWJLaXQvY2hyb21pdW0vQ2hhbmdlTG9nCkBA IC0xLDMgKzEsMTYgQEAKKzIwMTItMTItMDMgIEVyaWsgQXJ2aWRzc29uICA8YXJ2QGNocm9taXVt Lm9yZz4KKworICAgICAgICBbQ2hyb21pdW1dIEZpeCBpc3N1ZSB3aXRoIGhhcmQgY29kZWQgZXJy b3IgY29kZXMgaW4gcXVvdGEgZXJyb3IKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcv c2hvd19idWcuY2dpP2lkPTEwMzg5MgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09Q UyEpLgorCisgICAgICAgIENocm9taXVtIGN1cnJlbnRseSBoYXJkIGNvZGVzIHRoZSBlbnVtIHZh bHVlcyBmb3IgUXVvdGFTdGF0dXNDb2RlLiBUbyBmaXgKKyAgICAgICAgdGhpcyB3ZSBuZWVkIHRv IGRvIGEgZmV3IGl0ZXJhdGlvbiBvZiBjaGFuZ2VzLiBUaGlzIGlzIHRoZSBmaXJzdCBzdGVwIGFu ZAorICAgICAgICBpdCBleHBvc2VzIHRoZSBlbnVtcyB0aGF0IENocm9taXVtIGRlcGVuZHMgb24u CisKKyAgICAgICAgKiBwdWJsaWMvV2ViU3RvcmFnZVF1b3RhRXJyb3IuaDoKKwogMjAxMi0xMi0w MyAgVG9tbXkgV2lkZW5mbHljaHQgIDx0b21teXdAZ29vZ2xlLmNvbT4KIAogICAgICAgICBTcGVl Y2ggUmVjb2duaXRpb24gQVBJOiBVcGRhdGUgU3BlZWNoUmVjb2duaXRpb25FdmVudCB0byBtYXRj aCB0aGUgc3BlY2lmaWNhdGlvbgpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYktpdC9jaHJvbWl1bS9w dWJsaWMvV2ViU3RvcmFnZVF1b3RhRXJyb3IuaCBiL1NvdXJjZS9XZWJLaXQvY2hyb21pdW0vcHVi bGljL1dlYlN0b3JhZ2VRdW90YUVycm9yLmgKaW5kZXggMTNlNWMwMzhiNDFkZTNhOGUyOTllNWM5 MGE1MzJhYzBkNDYxMTY5NC4uZDJjNDRjNTBhZWY4ODRmYzg1NTM1NDhlMjYxNDg5MmUzYjUwNTQx MSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYktpdC9jaHJvbWl1bS9wdWJsaWMvV2ViU3RvcmFnZVF1 b3RhRXJyb3IuaAorKysgYi9Tb3VyY2UvV2ViS2l0L2Nocm9taXVtL3B1YmxpYy9XZWJTdG9yYWdl UXVvdGFFcnJvci5oCkBAIC0zNiw2ICszNiw4IEBAIG5hbWVzcGFjZSBXZWJLaXQgewogLy8gVGhl IGVycm9yIGNvZGUgdXNlZCBmb3IgV2ViU3RvcmFnZVF1b3RhLgogZW51bSBXZWJTdG9yYWdlUXVv dGFFcnJvciB7CiAgICAgV2ViU3RvcmFnZVF1b3RhRXJyb3JOb3RTdXBwb3J0ZWQgPSA5LAorICAg IFdlYlN0b3JhZ2VRdW90YUVycm9ySW52YWxpZE1vZGlmaWNhdGlvbiA9IDEzLAorICAgIFdlYlN0 b3JhZ2VRdW90YUVycm9ySW52YWxpZEFjY2VzcyA9IDE1LAogICAgIFdlYlN0b3JhZ2VRdW90YUVy cm9yQWJvcnQgPSAyMCwKIH07CiAK