103723 2012-11-30 01:41:14 -0800 [EFL] Volume control unable to show when preload="none" and src file is remote 2013-01-11 08:39:12 -0800 1 1 1 Unclassified WebKit WebKit EFL 528+ (Nightly build) Unspecified Unspecified RESOLVED DUPLICATE 106178 P2 Major --- 0 halton.huo webkit-unassigned cdumez gyuyoung.kim laszlo.gombos lucas.de.marchi rakuco webkit.review.bot oldest_to_newest 779935 0 halton.huo 2012-11-30 01:41:14 -0800 Build EFL port on trunk@136087 and run MiniBrowser to access http://www.webmfiles.org/demo-files/, the volume control unable to show whatever preview and playing. The related html code is: <video width="560" height="320" controls="controls" preload="none"><source src="http://video.webmfiles.org/big-buck-bunny_trailer.webm" type="video/webm"></video> I dump the page locally and do changes * remove preload="none", then bug disappear * download webm file to local and change src point to local, the volume control shows up after click play, the preview still show no volume control. Another message is when this bug happens, there is error on console: ERR<16772>:ecore ecore_main.c:1509 _ecore_main_fd_handlers_bads_rem() Removing bad fds ERR<16772>:ecore ecore_main.c:1551 _ecore_main_fd_handlers_bads_rem() No bad fd found. Maybe a foreign fd from glib? I'll continue to dig out the root cause. 797761 1 180846 halton.huo 2012-12-27 22:05:25 -0800 Created attachment 180846 Patch 797762 2 180846 gyuyoung.kim 2012-12-27 22:15:55 -0800 Comment on attachment 180846 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=180846&action=review > Source/WebCore/platform/efl/RenderThemeEfl.cpp:-1084 > - return (part != MediaMuteButtonPart); Bug 97574 implemented this function before. https://bugs.webkit.org/show_bug.cgi?id=97574#c0 Did you test this case ? - media/video-no-audio.html 797765 3 halton.huo 2012-12-27 22:32:17 -0800 (In reply to comment #2) > Did you test this case ? > > - media/video-no-audio.html The mute/unmute button shows up, as well as GTK port. So my fix should be wrong solution, will continue to work out. 797799 4 180846 kenneth 2012-12-28 00:55:11 -0800 Comment on attachment 180846 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=180846&action=review > Source/WebCore/ChangeLog:9 > + > + Enable state handling for MediaMuteButtonPart so that mute/unmute button could always be shown. > + if it always should be shown why does the method then exist? 805147 5 halton.huo 2013-01-11 03:55:32 -0800 With my fix for GTK bug #106436, I suppose GTK build will have same issue. But I'm wrong(GTK does not meet this bug). The audioTracks in (https://trac.webkit.org/browser/trunk/Source/WebCore/platform/graphics/gstreamer/MediaPlayerPrivateGStreamer.cpp#L639) is always 0 with gstreamer 0.10 even start playing. With GTK build(gstreamer 1.0), audioTracks will bigger than 0 if start playing. Now I'm guessing this is bug for gstreamer0.10. Now I'm trying to build EFL port with gstreamer1.0. Ubuntu can follow the instruction at https://wiki.ubuntu.com/Novacut/GStreamer1.0. (libgstreamer1.0-dev and libgstreamer-plugins-base1.0-dev need to be installed also). 805154 6 cdumez 2013-01-11 04:02:09 -0800 (In reply to comment #5) > With my fix for GTK bug #106436, I suppose GTK build will have same issue. But I'm wrong(GTK does not meet this bug). > > The audioTracks in (https://trac.webkit.org/browser/trunk/Source/WebCore/platform/graphics/gstreamer/MediaPlayerPrivateGStreamer.cpp#L639) is always 0 with gstreamer 0.10 even start playing. With GTK build(gstreamer 1.0), audioTracks will bigger than 0 if start playing. > > Now I'm guessing this is bug for gstreamer0.10. Now I'm trying to build EFL port with gstreamer1.0. The EFL port already builds with gstreamer 1.0. It is part of jhbuild. 805158 7 cdumez 2013-01-11 04:11:57 -0800 (In reply to comment #6) > (In reply to comment #5) > > With my fix for GTK bug #106436, I suppose GTK build will have same issue. But I'm wrong(GTK does not meet this bug). > > > > The audioTracks in (https://trac.webkit.org/browser/trunk/Source/WebCore/platform/graphics/gstreamer/MediaPlayerPrivateGStreamer.cpp#L639) is always 0 with gstreamer 0.10 even start playing. With GTK build(gstreamer 1.0), audioTracks will bigger than 0 if start playing. > > > > Now I'm guessing this is bug for gstreamer0.10. Now I'm trying to build EFL port with gstreamer1.0. > > The EFL port already builds with gstreamer 1.0. It is part of jhbuild. Just pull later trunk and pass "--update-efl" to the build-webkit script. It will pull and build gstreamer 1.0. 805281 8 halton.huo 2013-01-11 08:39:12 -0800 Yes, this bug disappear with trunk@139434, so close as dup of bug #106178 *** This bug has been marked as a duplicate of bug 106178 *** 180846 2012-12-27 22:05:25 -0800 2012-12-28 00:55:11 -0800 Patch bug-103723-20121228140536.patch text/plain 2589 halton.huo U3VidmVyc2lvbiBSZXZpc2lvbjogMTM4NDkyCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggMDRmZWY0YTAzM2IxNThj ZTYxZDhhODZjNWEwYjhhNzA5NTBiY2M4ZC4uMDllZGNhYjdiYzBlNjQ4MDg5YWI1M2RkNWEwMTAy MzFiMmEyMGNmYyAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE2IEBACisyMDEyLTEyLTI3ICBIYWx0 b24gSHVvICA8aGFsdG9uLmh1b0BpbnRlbC5jb20+CisKKyAgICAgICAgW0VGTF0gVm9sdW1lIGNv bnRyb2wgdW5hYmxlIHRvIHNob3cgd2hlbiBwcmVsb2FkPSJub25lIgorICAgICAgICBodHRwczov L2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTAzNzIzCisKKyAgICAgICAgUmV2aWV3 ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgRW5hYmxlIHN0YXRlIGhhbmRsaW5nIGZv ciBNZWRpYU11dGVCdXR0b25QYXJ0IHNvIHRoYXQgbXV0ZS91bm11dGUgYnV0dG9uIGNvdWxkIGFs d2F5cyBiZSBzaG93bi4KKworICAgICAgICAqIHBsYXRmb3JtL2VmbC9SZW5kZXJUaGVtZUVmbC5j cHA6CisgICAgICAgICogcGxhdGZvcm0vZWZsL1JlbmRlclRoZW1lRWZsLmg6CisgICAgICAgIChX ZWJDb3JlOjpSZW5kZXJUaGVtZUVmbDo6aGFzT3duRGlzYWJsZWRTdGF0ZUhhbmRsaW5nRm9yKToK KwogMjAxMi0xMi0yNiAgTm8nYW0gUm9zZW50aGFsICA8bm9hbUB3ZWJraXQub3JnPgogCiAgICAg ICAgIFtUZXhtYXBdIEluc3RlYWQgb2YgaGF2aW5nIG11bHRpcGxlIHNoYWRlcnMgc291cmNlcyB3 aXRoIGxvdHMgb2YgZHVwbGljYXRpb24sIHdlIHNob3VsZCBoYXZlIG9uZSBzaGFkZXIgc291cmNl IHdpdGggTUFDUk8gdmFyaWFudHMKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL3BsYXRmb3Jt L2VmbC9SZW5kZXJUaGVtZUVmbC5jcHAgYi9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9lZmwvUmVu ZGVyVGhlbWVFZmwuY3BwCmluZGV4IDkzNmY5ODNjNmY1ZDM3MjJkNDJmMzcwMTI5M2ExMzE2ZTMw YTg3NzIuLjg0YzI5OTg4YzAyMjM4OTBhZWUxN2RiZmIwNmYxYzk1ZDE2ZTUwMDUgMTAwNjQ0Ci0t LSBhL1NvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL2VmbC9SZW5kZXJUaGVtZUVmbC5jcHAKKysrIGIv U291cmNlL1dlYkNvcmUvcGxhdGZvcm0vZWZsL1JlbmRlclRoZW1lRWZsLmNwcApAQCAtMTA3OSwx MSArMTA3OSw2IEBAIFN0cmluZyBSZW5kZXJUaGVtZUVmbDo6Zm9ybWF0TWVkaWFDb250cm9sc0N1 cnJlbnRUaW1lKGZsb2F0IGN1cnJlbnRUaW1lLCBmbG9hdCBkCiAgICAgcmV0dXJuIGZvcm1hdE1l ZGlhQ29udHJvbHNUaW1lKGN1cnJlbnRUaW1lKSArICIgLyAiICsgZm9ybWF0TWVkaWFDb250cm9s c1RpbWUoZHVyYXRpb24pOwogfQogCi1ib29sIFJlbmRlclRoZW1lRWZsOjpoYXNPd25EaXNhYmxl ZFN0YXRlSGFuZGxpbmdGb3IoQ29udHJvbFBhcnQgcGFydCkgY29uc3QKLXsKLSAgICByZXR1cm4g KHBhcnQgIT0gTWVkaWFNdXRlQnV0dG9uUGFydCk7Ci19Ci0KIGJvb2wgUmVuZGVyVGhlbWVFZmw6 OnBhaW50TWVkaWFGdWxsc2NyZWVuQnV0dG9uKFJlbmRlck9iamVjdCogb2JqZWN0LCBjb25zdCBQ YWludEluZm8mIGluZm8sIGNvbnN0IEludFJlY3QmIHJlY3QpCiB7CiAgICAgTm9kZSogbWVkaWFO b2RlID0gb2JqZWN0LT5ub2RlKCkgPyBvYmplY3QtPm5vZGUoKS0+c2hhZG93SG9zdCgpIDogMDsK ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL2VmbC9SZW5kZXJUaGVtZUVmbC5o IGIvU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vZWZsL1JlbmRlclRoZW1lRWZsLmgKaW5kZXggZjg4 MjY3YzJhNTEzOWJhY2JkZGVmNzBhODA0NTNiMjEyOGZlNTA4OS4uYTFkOWIyMTg3MTc0OWQ5ZWU4 MTg3NjY1ZjlmYmM1MTY0NDBjZmFkNyAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvcGxhdGZv cm0vZWZsL1JlbmRlclRoZW1lRWZsLmgKKysrIGIvU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vZWZs L1JlbmRlclRoZW1lRWZsLmgKQEAgLTE5MSw3ICsxOTEsNyBAQCBwdWJsaWM6CiAgICAgdmlydHVh bCBTdHJpbmcgZXh0cmFGdWxsU2NyZWVuU3R5bGVTaGVldCgpOwogI2VuZGlmCiAgICAgdmlydHVh bCBTdHJpbmcgZm9ybWF0TWVkaWFDb250cm9sc0N1cnJlbnRUaW1lKGZsb2F0IGN1cnJlbnRUaW1l LCBmbG9hdCBkdXJhdGlvbikgY29uc3Q7Ci0gICAgdmlydHVhbCBib29sIGhhc093bkRpc2FibGVk U3RhdGVIYW5kbGluZ0ZvcihDb250cm9sUGFydCkgY29uc3Q7CisgICAgdmlydHVhbCBib29sIGhh c093bkRpc2FibGVkU3RhdGVIYW5kbGluZ0ZvcihDb250cm9sUGFydCkgY29uc3QgeyByZXR1cm4g dHJ1ZTsgfTsKIAogICAgIHZpcnR1YWwgYm9vbCBwYWludE1lZGlhRnVsbHNjcmVlbkJ1dHRvbihS ZW5kZXJPYmplY3QqLCBjb25zdCBQYWludEluZm8mLCBjb25zdCBJbnRSZWN0Jik7CiAgICAgdmly dHVhbCBib29sIHBhaW50TWVkaWFQbGF5QnV0dG9uKFJlbmRlck9iamVjdCosIGNvbnN0IFBhaW50 SW5mbyYsIGNvbnN0IEludFJlY3QmKTsK