103610 2012-11-29 00:42:18 -0800 [EFL] libwebcore_efl.a fail to link when enable webgl 2012-11-30 00:55:35 -0800 1 1 1 Unclassified WebKit WebKit EFL 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 77219 0 halton.huo halton.huo cdumez gyuyoung.kim kalyan.kondapally lucas.de.marchi rakuco webkit.review.bot oldest_to_newest 778789 0 halton.huo 2012-11-29 00:42:18 -0800 Build trunk@136087 on Ubuntu 12.10 64 bit, $./Tools/Scripts/build-webkit --efl --cmakearg="-DENABLE_WEBGL=ON" [...] ../../../lib/libwebcore_efl.a(GLXSurface.cpp.o):GLXSurface.cpp:function WebCore::GLXTransportSurface::destroy(): error: undefined reference to 'XDestroyWindow' ../../../lib/libwebcore_efl.a(GLXSurface.cpp.o):GLXSurface.cpp:function WebCore::GLXPBuffer::configuration(): error: undefined reference to 'XFree' ../../../lib/libwebcore_efl.a(GLXSurface.cpp.o):GLXSurface.cpp:function WebCore::GLXPBuffer::configuration(): error: undefined reference to 'XOpenDisplay' ../../../lib/libwebcore_efl.a(GLXSurface.cpp.o):GLXSurface.cpp:function WebCore::GLXTransportSurface::configuration(): error: undefined reference to 'XRenderQueryExtension' ../../../lib/libwebcore_efl.a(GLXSurface.cpp.o):GLXSurface.cpp:function WebCore::GLXTransportSurface::configuration(): error: undefined reference to 'XRenderFindVisualFormat' [...] ../../../lib/libwebcore_efl.a(GraphicsSurfaceGLX.cpp.o):GraphicsSurfaceGLX.cpp:function WebCore::GraphicsSurface::platformGetTextureID(): error: undefined reference to 'XDefaultScreen' ../../../lib/libwebcore_efl.a(GraphicsSurfaceGLX.cpp.o):GraphicsSurfaceGLX.cpp:function WebCore::GraphicsSurface::platformGetTextureID(): error: undefined reference to 'XCompositeNameWindowPixmap' [...] It shows me X11, Xrender and XSomposite libs are not linked with libwebcore, will submit a patch later. 778803 1 176670 halton.huo 2012-11-29 01:00:34 -0800 Created attachment 176670 Patch 778821 2 176670 gyuyoung.kim 2012-11-29 01:26:47 -0800 Comment on attachment 176670 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=176670&action=review > Source/WebCore/ChangeLog:10 > + bin/DumpRenderTree What is this ? > Source/WebCore/PlatformEfl.cmake:302 > + "-lXcomposite -lXrender" IMO, it would be good if you link this libraries from FindXXX.cmake file or macro. 778850 3 halton.huo 2012-11-29 02:27:22 -0800 (In reply to comment #2) > (From update of attachment 176670 [details]) > View in context: https://bugs.webkit.org/attachment.cgi?id=176670&action=review > > > Source/WebCore/ChangeLog:10 > > + bin/DumpRenderTree > > What is this ? This link error happens when link libwebcore_efl to DumpRenderTree, I just check whether this binary generated and can be run with my patch. I'll update the comment with more specific word. > > > Source/WebCore/PlatformEfl.cmake:302 > > + "-lXcomposite -lXrender" > > IMO, it would be good if you link this libraries from FindXXX.cmake file or macro. I do this because WebCore.pri add those two libs directly. 226 use?(GRAPHICS_SURFACE) { 227 mac: LIBS += -framework IOSurface -framework CoreFoundation 228 linux-*: { 229 LIBS += -lXcomposite -lXrender 230 CONFIG *= x11 231 } 232 } After going through the FindX11.cmake, I found X11_Xcomposite_LIB and X11_Xrandr_LIB are defined, I'll use them and update the patch. 778856 4 176683 halton.huo 2012-11-29 02:35:55 -0800 Created attachment 176683 Patch 778863 5 176683 gyuyoung.kim 2012-11-29 02:44:30 -0800 Comment on attachment 176683 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=176683&action=review > Source/WebCore/ChangeLog:6 > + Reviewed by Gyuyoung Kim. I don't set r+ yet. So, remove my name here. 778869 6 176688 halton.huo 2012-11-29 02:58:00 -0800 Created attachment 176688 Patch 779502 7 176688 yael 2012-11-29 15:24:32 -0800 Comment on attachment 176688 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=176688&action=review > Source/WebCore/ChangeLog:8 > + libwebcore_efl.a should link to X11, Xcomposite and Xrender libraries when WTF_USE_3D_GRAPHICS=1 It is ENABLE_WEBGL, not WTF_USE_3D_GRAPHICS 779505 8 yael 2012-11-29 15:25:07 -0800 *** Bug 103107 has been marked as a duplicate of this bug. *** 779743 9 176887 halton.huo 2012-11-29 19:19:18 -0800 Created attachment 176887 Patch 779752 10 176887 gyuyoung.kim 2012-11-29 19:33:33 -0800 Comment on attachment 176887 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=176887&action=review > Source/WebCore/ChangeLog:10 > + Test: bin/DumpRenderTree are generated and can be run. It looks this comment is meaningless. Generally, we have been written test case place in LayoutTest. 779857 11 halton.huo 2012-11-29 23:46:07 -0800 (In reply to comment #10) > > Source/WebCore/ChangeLog:10 > > + Test: bin/DumpRenderTree are generated and can be run. > > It looks this comment is meaningless. Generally, we have been written test case place in LayoutTest. Is that acceptable that I just remove the "Test:" line? 779860 12 176887 cdumez 2012-11-29 23:53:27 -0800 Comment on attachment 176887 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=176887&action=review >> Source/WebCore/ChangeLog:10 >> + Test: bin/DumpRenderTree are generated and can be run. > > It looks this comment is meaningless. Generally, we have been written test case place in LayoutTest. Replace with something like "No new tests, no behavior change for layout tests." This is common practice. 779877 13 176909 halton.huo 2012-11-30 00:09:44 -0800 Created attachment 176909 Patch 779879 14 cdumez 2012-11-30 00:10:56 -0800 You already got r+ from Gyuyoung and only did a minor change. Do not request r? flag again, just cq? 779885 15 halton.huo 2012-11-30 00:25:56 -0800 (In reply to comment #14) > You already got r+ from Gyuyoung and only did a minor change. Do not request r? flag again, just cq? Thanks for let me know. In this case should I set the review to null or +? 779887 16 gyuyoung.kim 2012-11-30 00:28:45 -0800 (In reply to comment #15) > (In reply to comment #14) > > You already got r+ from Gyuyoung and only did a minor change. Do not request r? flag again, just cq? > Thanks for let me know. In this case should I set the review to null or +? You should not set r+. null is correct. 779888 17 cdumez 2012-11-30 00:29:09 -0800 (In reply to comment #15) > (In reply to comment #14) > > You already got r+ from Gyuyoung and only did a minor change. Do not request r? flag again, just cq? > Thanks for let me know. In this case should I set the review to null or +? Don't change anything here, the patch is on its way to land. But next time, just let leave r flag empty and set only cq? (provided that you already got r+ on a previous patch that you did minimal changes to and provided that you updated the reviewer name in the Changelog). 779907 18 176909 webkit.review.bot 2012-11-30 00:55:30 -0800 Comment on attachment 176909 Patch Clearing flags on attachment: 176909 Committed r136212: <http://trac.webkit.org/changeset/136212> 779908 19 webkit.review.bot 2012-11-30 00:55:35 -0800 All reviewed patches have been landed. Closing bug. 176670 2012-11-29 01:00:34 -0800 2012-11-29 02:35:44 -0800 Patch bug-103610-20121129170042.patch text/plain 1458 halton.huo U3VidmVyc2lvbiBSZXZpc2lvbjogMTM2MDg3CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggYmVmMTMzM2UxNTI2ZDBl MDNjNzA5ZTc0Y2M3M2Q2ZjUyYWJhOWEwZi4uOGJmNGMwMDFjNjdlM2Y0ZDc3ZDc5MTJjNzQwOWRi NzUwMzJmODYyNSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE2IEBACisyMDEyLTExLTI5ICBIYWx0 b24gSHVvICA8aGFsdG9uLmh1b0BpbnRlbC5jb20+CisKKyAgICAgICAgW0VGTF0gbGlid2ViY29y ZV9lZmwuYSBmYWlsIHRvIGxpbmsgd2hlbiBlbmFibGUgd2ViZ2wKKyAgICAgICAgaHR0cHM6Ly9i dWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTEwMzYxMAorCisgICAgICAgIFJldmlld2Vk IGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIGxpYndlYmNvcmVfZWZsLmEgc2hvdWxkIGxp bmsgdG8gWDExLCBYY29tcG9zaXRlIGFuZCBYcmVuZGVyIGxpYnJhcmllcyB3aGVuIFdURl9VU0Vf M0RfR1JBUEhJQ1M9MQorCisgICAgICAgIGJpbi9EdW1wUmVuZGVyVHJlZQorCisgICAgICAgICog UGxhdGZvcm1FZmwuY21ha2U6IEFkZCAke1gxMV9MSUJSQVJJRVN9ICItbFhjb21wb3NpdGUgLWxY cmVuZGVyIiB0byBXZWJDb3JlX0xJQlJBUklFUworCiAyMDEyLTExLTI4ICBIYXlhdG8gSXRvICA8 aGF5YXRvQGNocm9taXVtLm9yZz4KIAogICAgICAgICBOb2RlOjpjb21wYXJlRG9jdW1lbnRQb3Np dGlvbiByZXR1cm5zIHdyb25nIHZhbHVlIGZvciBhIG5vZGUgaW4gdGhlIGRpZmZlcmVudCBzaGFk b3cgdHJlZS4KZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL1BsYXRmb3JtRWZsLmNtYWtlIGIv U291cmNlL1dlYkNvcmUvUGxhdGZvcm1FZmwuY21ha2UKaW5kZXggMzFlNGM4N2RmMTNhZGEyNmIx ZjJjYzE2ZTNhNDdjYzI2OTQyZjBjMS4uNWM4OGQ3YjBhN2E4MDNiNzQxNDdkOTEyMTZjZDg4ZDQy M2VkZGZkMiAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvUGxhdGZvcm1FZmwuY21ha2UKKysr IGIvU291cmNlL1dlYkNvcmUvUGxhdGZvcm1FZmwuY21ha2UKQEAgLTI5Nyw2ICsyOTcsMTAgQEAg SUYgKFdURl9VU0VfM0RfR1JBUEhJQ1MpCiAgICAgcGxhdGZvcm0vZ3JhcGhpY3MvdGV4bWFwL1Rl eHR1cmVNYXBwZXJHTC5jcHAKICAgICBwbGF0Zm9ybS9ncmFwaGljcy90ZXhtYXAvVGV4dHVyZU1h cHBlclNoYWRlck1hbmFnZXIuY3BwCiAgICkKKyAgTElTVChBUFBFTkQgV2ViQ29yZV9MSUJSQVJJ RVMKKyAgICAke1gxMV9MSUJSQVJJRVN9CisgICAgIi1sWGNvbXBvc2l0ZSAtbFhyZW5kZXIiCisg ICkKIEVORElGICgpCiAKIEFERF9ERUZJTklUSU9OUygtRERBVEFfRElSPSIke0NNQUtFX0lOU1RB TExfUFJFRklYfS8ke0RBVEFfSU5TVEFMTF9ESVJ9IikK 176683 2012-11-29 02:35:55 -0800 2012-11-29 02:57:49 -0800 Patch bug-103610-20121129183603.patch text/plain 1533 halton.huo U3VidmVyc2lvbiBSZXZpc2lvbjogMTM2MDg3CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggYmVmMTMzM2UxNTI2ZDBl MDNjNzA5ZTc0Y2M3M2Q2ZjUyYWJhOWEwZi4uYmE1MjM4MWY1YzFmODliODQ5M2VmZTdiOTU1MDIz NWEzZjljNzE2MSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE2IEBACisyMDEyLTExLTI5ICBIYWx0 b24gSHVvICA8aGFsdG9uLmh1b0BpbnRlbC5jb20+CisKKyAgICAgICAgW0VGTF0gbGlid2ViY29y ZV9lZmwuYSBmYWlsIHRvIGxpbmsgd2hlbiBlbmFibGUgd2ViZ2wKKyAgICAgICAgaHR0cHM6Ly9i dWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTEwMzYxMAorCisgICAgICAgIFJldmlld2Vk IGJ5IEd5dXlvdW5nIEtpbS4KKworICAgICAgICBsaWJ3ZWJjb3JlX2VmbC5hIHNob3VsZCBsaW5r IHRvIFgxMSwgWGNvbXBvc2l0ZSBhbmQgWHJlbmRlciBsaWJyYXJpZXMgd2hlbiBXVEZfVVNFXzNE X0dSQVBISUNTPTEKKworICAgICAgICBUZXN0OiBiaW4vRHVtcFJlbmRlclRyZWUgYXJlIGdlbmVy YXRlZCBhbmQgY2FuIGJlIHJ1bi4KKworICAgICAgICAqIFBsYXRmb3JtRWZsLmNtYWtlOiBBcHBl bmQgJHtYMTFfWDExX0xJQn0sICR7WDExX1hjb21wb3NpdGVfTElCfSBhbmQgJHtYMTFfWHJlbmRl cl9MSUJ9IHRvIFdlYkNvcmVfTElCUkFSSUVTCisKIDIwMTItMTEtMjggIEhheWF0byBJdG8gIDxo YXlhdG9AY2hyb21pdW0ub3JnPgogCiAgICAgICAgIE5vZGU6OmNvbXBhcmVEb2N1bWVudFBvc2l0 aW9uIHJldHVybnMgd3JvbmcgdmFsdWUgZm9yIGEgbm9kZSBpbiB0aGUgZGlmZmVyZW50IHNoYWRv dyB0cmVlLgpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYkNvcmUvUGxhdGZvcm1FZmwuY21ha2UgYi9T b3VyY2UvV2ViQ29yZS9QbGF0Zm9ybUVmbC5jbWFrZQppbmRleCAzMWU0Yzg3ZGYxM2FkYTI2YjFm MmNjMTZlM2E0N2NjMjY5NDJmMGMxLi4wMWY3ZDM5YmRhODQ2MDJmN2JkMDViMzFmMTkwYzUwM2Iz OTY0NmYwIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9QbGF0Zm9ybUVmbC5jbWFrZQorKysg Yi9Tb3VyY2UvV2ViQ29yZS9QbGF0Zm9ybUVmbC5jbWFrZQpAQCAtMjk3LDYgKzI5NywxMSBAQCBJ RiAoV1RGX1VTRV8zRF9HUkFQSElDUykKICAgICBwbGF0Zm9ybS9ncmFwaGljcy90ZXhtYXAvVGV4 dHVyZU1hcHBlckdMLmNwcAogICAgIHBsYXRmb3JtL2dyYXBoaWNzL3RleG1hcC9UZXh0dXJlTWFw cGVyU2hhZGVyTWFuYWdlci5jcHAKICAgKQorICBMSVNUKEFQUEVORCBXZWJDb3JlX0xJQlJBUklF UworICAgICR7WDExX1gxMV9MSUJ9CisgICAgJHtYMTFfWGNvbXBvc2l0ZV9MSUJ9CisgICAgJHtY MTFfWHJlbmRlcl9MSUJ9CisgICkKIEVORElGICgpCiAKIEFERF9ERUZJTklUSU9OUygtRERBVEFf RElSPSIke0NNQUtFX0lOU1RBTExfUFJFRklYfS8ke0RBVEFfSU5TVEFMTF9ESVJ9IikK 176688 2012-11-29 02:58:00 -0800 2012-11-29 19:19:01 -0800 Patch bug-103610-20121129185808.patch text/plain 1535 halton.huo U3VidmVyc2lvbiBSZXZpc2lvbjogMTM2MDg3CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggYmVmMTMzM2UxNTI2ZDBl MDNjNzA5ZTc0Y2M3M2Q2ZjUyYWJhOWEwZi4uMzU5ZjEyNWVjMTBkNjkzYjE3YzlkMDFmYWIyY2M3 ZWM4NjMyZjYxOCAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE2IEBACisyMDEyLTExLTI5ICBIYWx0 b24gSHVvICA8aGFsdG9uLmh1b0BpbnRlbC5jb20+CisKKyAgICAgICAgW0VGTF0gbGlid2ViY29y ZV9lZmwuYSBmYWlsIHRvIGxpbmsgd2hlbiBlbmFibGUgd2ViZ2wKKyAgICAgICAgaHR0cHM6Ly9i dWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTEwMzYxMAorCisgICAgICAgIFJldmlld2Vk IGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIGxpYndlYmNvcmVfZWZsLmEgc2hvdWxkIGxp bmsgdG8gWDExLCBYY29tcG9zaXRlIGFuZCBYcmVuZGVyIGxpYnJhcmllcyB3aGVuIFdURl9VU0Vf M0RfR1JBUEhJQ1M9MQorCisgICAgICAgIFRlc3Q6IGJpbi9EdW1wUmVuZGVyVHJlZSBhcmUgZ2Vu ZXJhdGVkIGFuZCBjYW4gYmUgcnVuLgorCisgICAgICAgICogUGxhdGZvcm1FZmwuY21ha2U6IEFw cGVuZCAke1gxMV9YMTFfTElCfSwgJHtYMTFfWGNvbXBvc2l0ZV9MSUJ9IGFuZCAke1gxMV9YcmVu ZGVyX0xJQn0gdG8gV2ViQ29yZV9MSUJSQVJJRVMKKwogMjAxMi0xMS0yOCAgSGF5YXRvIEl0byAg PGhheWF0b0BjaHJvbWl1bS5vcmc+CiAKICAgICAgICAgTm9kZTo6Y29tcGFyZURvY3VtZW50UG9z aXRpb24gcmV0dXJucyB3cm9uZyB2YWx1ZSBmb3IgYSBub2RlIGluIHRoZSBkaWZmZXJlbnQgc2hh ZG93IHRyZWUuCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9QbGF0Zm9ybUVmbC5jbWFrZSBi L1NvdXJjZS9XZWJDb3JlL1BsYXRmb3JtRWZsLmNtYWtlCmluZGV4IDMxZTRjODdkZjEzYWRhMjZi MWYyY2MxNmUzYTQ3Y2MyNjk0MmYwYzEuLjAxZjdkMzliZGE4NDYwMmY3YmQwNWIzMWYxOTBjNTAz YjM5NjQ2ZjAgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJDb3JlL1BsYXRmb3JtRWZsLmNtYWtlCisr KyBiL1NvdXJjZS9XZWJDb3JlL1BsYXRmb3JtRWZsLmNtYWtlCkBAIC0yOTcsNiArMjk3LDExIEBA IElGIChXVEZfVVNFXzNEX0dSQVBISUNTKQogICAgIHBsYXRmb3JtL2dyYXBoaWNzL3RleG1hcC9U ZXh0dXJlTWFwcGVyR0wuY3BwCiAgICAgcGxhdGZvcm0vZ3JhcGhpY3MvdGV4bWFwL1RleHR1cmVN YXBwZXJTaGFkZXJNYW5hZ2VyLmNwcAogICApCisgIExJU1QoQVBQRU5EIFdlYkNvcmVfTElCUkFS SUVTCisgICAgJHtYMTFfWDExX0xJQn0KKyAgICAke1gxMV9YY29tcG9zaXRlX0xJQn0KKyAgICAk e1gxMV9YcmVuZGVyX0xJQn0KKyAgKQogRU5ESUYgKCkKIAogQUREX0RFRklOSVRJT05TKC1EREFU QV9ESVI9IiR7Q01BS0VfSU5TVEFMTF9QUkVGSVh9LyR7REFUQV9JTlNUQUxMX0RJUn0iKQo= 176887 2012-11-29 19:19:18 -0800 2012-11-30 00:09:32 -0800 Patch bug-103610-20121130111925.patch text/plain 1532 halton.huo U3VidmVyc2lvbiBSZXZpc2lvbjogMTM2MDg3CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggYmVmMTMzM2UxNTI2ZDBl MDNjNzA5ZTc0Y2M3M2Q2ZjUyYWJhOWEwZi4uYzE1NTU3ODFjZTdmYTUyMTVhZmYxNmM5ZTY0MTE2 MjZiOGQ5ZDA1MyAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE2IEBACisyMDEyLTExLTI5ICBIYWx0 b24gSHVvICA8aGFsdG9uLmh1b0BpbnRlbC5jb20+CisKKyAgICAgICAgW0VGTF0gbGlid2ViY29y ZV9lZmwuYSBmYWlsIHRvIGxpbmsgd2hlbiBlbmFibGUgd2ViZ2wKKyAgICAgICAgaHR0cHM6Ly9i dWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTEwMzYxMAorCisgICAgICAgIFJldmlld2Vk IGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIGxpYndlYmNvcmVfZWZsLmEgc2hvdWxkIGxp bmsgdG8gWDExLCBYY29tcG9zaXRlIGFuZCBYcmVuZGVyIGxpYnJhcmllcyB3aGVuIEVOQUJMRV9X RUJHTCBpcyBPTgorCisgICAgICAgIFRlc3Q6IGJpbi9EdW1wUmVuZGVyVHJlZSBhcmUgZ2VuZXJh dGVkIGFuZCBjYW4gYmUgcnVuLgorCisgICAgICAgICogUGxhdGZvcm1FZmwuY21ha2U6IEFwcGVu ZCAke1gxMV9YMTFfTElCfSwgJHtYMTFfWGNvbXBvc2l0ZV9MSUJ9IGFuZCAke1gxMV9YcmVuZGVy X0xJQn0gdG8gV2ViQ29yZV9MSUJSQVJJRVMKKwogMjAxMi0xMS0yOCAgSGF5YXRvIEl0byAgPGhh eWF0b0BjaHJvbWl1bS5vcmc+CiAKICAgICAgICAgTm9kZTo6Y29tcGFyZURvY3VtZW50UG9zaXRp b24gcmV0dXJucyB3cm9uZyB2YWx1ZSBmb3IgYSBub2RlIGluIHRoZSBkaWZmZXJlbnQgc2hhZG93 IHRyZWUuCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9QbGF0Zm9ybUVmbC5jbWFrZSBiL1Nv dXJjZS9XZWJDb3JlL1BsYXRmb3JtRWZsLmNtYWtlCmluZGV4IDMxZTRjODdkZjEzYWRhMjZiMWYy Y2MxNmUzYTQ3Y2MyNjk0MmYwYzEuLjAxZjdkMzliZGE4NDYwMmY3YmQwNWIzMWYxOTBjNTAzYjM5 NjQ2ZjAgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJDb3JlL1BsYXRmb3JtRWZsLmNtYWtlCisrKyBi L1NvdXJjZS9XZWJDb3JlL1BsYXRmb3JtRWZsLmNtYWtlCkBAIC0yOTcsNiArMjk3LDExIEBAIElG IChXVEZfVVNFXzNEX0dSQVBISUNTKQogICAgIHBsYXRmb3JtL2dyYXBoaWNzL3RleG1hcC9UZXh0 dXJlTWFwcGVyR0wuY3BwCiAgICAgcGxhdGZvcm0vZ3JhcGhpY3MvdGV4bWFwL1RleHR1cmVNYXBw ZXJTaGFkZXJNYW5hZ2VyLmNwcAogICApCisgIExJU1QoQVBQRU5EIFdlYkNvcmVfTElCUkFSSUVT CisgICAgJHtYMTFfWDExX0xJQn0KKyAgICAke1gxMV9YY29tcG9zaXRlX0xJQn0KKyAgICAke1gx MV9YcmVuZGVyX0xJQn0KKyAgKQogRU5ESUYgKCkKIAogQUREX0RFRklOSVRJT05TKC1EREFUQV9E SVI9IiR7Q01BS0VfSU5TVEFMTF9QUkVGSVh9LyR7REFUQV9JTlNUQUxMX0RJUn0iKQo= 176909 2012-11-30 00:09:44 -0800 2012-11-30 00:55:30 -0800 Patch bug-103610-20121130160951.patch text/plain 1526 halton.huo U3VidmVyc2lvbiBSZXZpc2lvbjogMTM2MDg3CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggYmVmMTMzM2UxNTI2ZDBl MDNjNzA5ZTc0Y2M3M2Q2ZjUyYWJhOWEwZi4uODE3M2JmZjNjMWE5NjU2NGVhZjRiZTZkMGJiMzIy NzI2YzEwZTQ1YSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE2IEBACisyMDEyLTExLTI5ICBIYWx0 b24gSHVvICA8aGFsdG9uLmh1b0BpbnRlbC5jb20+CisKKyAgICAgICAgW0VGTF0gbGlid2ViY29y ZV9lZmwuYSBmYWlsIHRvIGxpbmsgd2hlbiBlbmFibGUgd2ViZ2wKKyAgICAgICAgaHR0cHM6Ly9i dWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTEwMzYxMAorCisgICAgICAgIFJldmlld2Vk IGJ5IEd5dXlvdW5nIEtpbS4KKworICAgICAgICBsaWJ3ZWJjb3JlX2VmbC5hIHNob3VsZCBsaW5r IHRvIFgxMSwgWGNvbXBvc2l0ZSBhbmQgWHJlbmRlciBsaWJyYXJpZXMgd2hlbiBFTkFCTEVfV0VC R0wgaXMgT04KKworICAgICAgICBObyBuZXcgdGVzdHMsIG5vIGJlaGF2aW9yIGNoYW5nZSBmb3Ig bGF5b3V0IHRlc3RzLgorCisgICAgICAgICogUGxhdGZvcm1FZmwuY21ha2U6IEFwcGVuZCAke1gx MV9YMTFfTElCfSwgJHtYMTFfWGNvbXBvc2l0ZV9MSUJ9IGFuZCAke1gxMV9YcmVuZGVyX0xJQn0g dG8gV2ViQ29yZV9MSUJSQVJJRVMKKwogMjAxMi0xMS0yOCAgSGF5YXRvIEl0byAgPGhheWF0b0Bj aHJvbWl1bS5vcmc+CiAKICAgICAgICAgTm9kZTo6Y29tcGFyZURvY3VtZW50UG9zaXRpb24gcmV0 dXJucyB3cm9uZyB2YWx1ZSBmb3IgYSBub2RlIGluIHRoZSBkaWZmZXJlbnQgc2hhZG93IHRyZWUu CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9QbGF0Zm9ybUVmbC5jbWFrZSBiL1NvdXJjZS9X ZWJDb3JlL1BsYXRmb3JtRWZsLmNtYWtlCmluZGV4IDMxZTRjODdkZjEzYWRhMjZiMWYyY2MxNmUz YTQ3Y2MyNjk0MmYwYzEuLjAxZjdkMzliZGE4NDYwMmY3YmQwNWIzMWYxOTBjNTAzYjM5NjQ2ZjAg MTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJDb3JlL1BsYXRmb3JtRWZsLmNtYWtlCisrKyBiL1NvdXJj ZS9XZWJDb3JlL1BsYXRmb3JtRWZsLmNtYWtlCkBAIC0yOTcsNiArMjk3LDExIEBAIElGIChXVEZf VVNFXzNEX0dSQVBISUNTKQogICAgIHBsYXRmb3JtL2dyYXBoaWNzL3RleG1hcC9UZXh0dXJlTWFw cGVyR0wuY3BwCiAgICAgcGxhdGZvcm0vZ3JhcGhpY3MvdGV4bWFwL1RleHR1cmVNYXBwZXJTaGFk ZXJNYW5hZ2VyLmNwcAogICApCisgIExJU1QoQVBQRU5EIFdlYkNvcmVfTElCUkFSSUVTCisgICAg JHtYMTFfWDExX0xJQn0KKyAgICAke1gxMV9YY29tcG9zaXRlX0xJQn0KKyAgICAke1gxMV9YcmVu ZGVyX0xJQn0KKyAgKQogRU5ESUYgKCkKIAogQUREX0RFRklOSVRJT05TKC1EREFUQV9ESVI9IiR7 Q01BS0VfSU5TVEFMTF9QUkVGSVh9LyR7REFUQV9JTlNUQUxMX0RJUn0iKQo=