103461 2012-11-27 16:01:43 -0800 Remove ASSERT_NOT_REACHED() from IDBCursorBackendImpl::postSuccessHandlerCallback() 2012-11-27 20:54:54 -0800 1 1 1 Unclassified WebKit New Bugs 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 45110 0 michael webkit-unassigned abarth alecflett haraken jsbell webkit.review.bot oldest_to_newest 777301 0 michael 2012-11-27 16:01:43 -0800 In the Chromium port, IDBCursorBackendImpl::postSuccessHandlerCallback() is never invoked, but the ASSERT_NOT_REACHED() macro should be removed in order to allow IndexedDB to be implemented for JSC. 777314 1 176356 michael 2012-11-27 16:09:17 -0800 Created attachment 176356 Patch 777348 2 176356 alecflett 2012-11-27 16:29:13 -0800 Comment on attachment 176356 Patch if that's there, it almost always means that function is in the process of being removed. Why do you need it? 777356 3 jsbell 2012-11-27 16:34:28 -0800 (In reply to comment #2) > if that's there, it almost always means that function is in the process of being removed. Why do you need it? I think it's part of the pre-fetching logic, but let me dig in. It's possible it's not even needed any more. 777369 4 jsbell 2012-11-27 16:41:17 -0800 Yeah, Chromium code uses this to reset the prefetch cache if the success handler did anything other than continue(). It's safe to remove this ASSERT. 777490 5 176356 haraken 2012-11-27 20:41:42 -0800 Comment on attachment 176356 Patch rs=me, per the discussion in the bug. 777493 6 176356 webkit.review.bot 2012-11-27 20:54:50 -0800 Comment on attachment 176356 Patch Clearing flags on attachment: 176356 Committed r135969: <http://trac.webkit.org/changeset/135969> 777494 7 webkit.review.bot 2012-11-27 20:54:54 -0800 All reviewed patches have been landed. Closing bug. 176356 2012-11-27 16:09:17 -0800 2012-11-27 20:54:50 -0800 Patch idb-postSuccessHandlerCallback.patch text/plain 1926 michael RnJvbTogTWljaGFlbCBQcnVldHQgPG1pY2hhZWxANjhrLm9yZz4KRGF0ZTogVHVlLCAyNyBOb3Yg MjAxMiAxNTo1MToxMSAtMDgwMApTdWJqZWN0OiBSZW1vdmUgQVNTRVJUX05PVF9SRUFDSEVEKCkg ZnJvbSBJREJDdXJzb3JCYWNrZW5kSW1wbDo6cG9zdFN1Y2Nlc3NIYW5kbGVyQ2FsbGJhY2soKQoK LS0tCiBTb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cgICAgICAgICAgICAgICAgICAgICAgICAgICB8 ICAgMTQgKysrKysrKysrKysrKysKIC4uLi9Nb2R1bGVzL2luZGV4ZWRkYi9JREJDdXJzb3JCYWNr ZW5kSW1wbC5oICAgICAgIHwgICAgMiArLQogMiBmaWxlcyBjaGFuZ2VkLCAxNSBpbnNlcnRpb25z KCspLCAxIGRlbGV0aW9uKC0pCgpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9n IGIvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCmluZGV4IGNkNTgyYTEuLjNmNTU2YzQgMTAwNjQ0 Ci0tLSBhL1NvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZworKysgYi9Tb3VyY2UvV2ViQ29yZS9DaGFu Z2VMb2cKQEAgLTEsMyArMSwxNyBAQAorMjAxMi0xMS0yNyAgTWljaGFlbCBQcnVldHQgIDxtaWNo YWVsQDY4ay5vcmc+CisKKyAgICAgICAgUmVtb3ZlIEFTU0VSVF9OT1RfUkVBQ0hFRCgpIGZyb20g SURCQ3Vyc29yQmFja2VuZEltcGw6OnBvc3RTdWNjZXNzSGFuZGxlckNhbGxiYWNrKCkKKyAgICAg ICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTEwMzQ2MQorCisgICAg ICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIFRoZSBhc3NlcnRpb24g aXMgYXBwbGljYWJsZSBvbmx5IHRvIHRoZSBDaHJvbWl1bSBwb3J0LgorCisgICAgICAgIFRlc3Rz OiBzdG9yYWdlL2luZGV4ZWRkYi8qCisKKyAgICAgICAgKiBNb2R1bGVzL2luZGV4ZWRkYi9JREJD dXJzb3JCYWNrZW5kSW1wbC5oOgorICAgICAgICAoV2ViQ29yZTo6SURCQ3Vyc29yQmFja2VuZElt cGw6OnBvc3RTdWNjZXNzSGFuZGxlckNhbGxiYWNrKToKKwogMjAxMi0xMS0yNyAgRGVhbiBKYWNr c29uICA8ZGlub0BhcHBsZS5jb20+CiAKICAgICAgICAgTWFrZSB0cmFjayBsaXN0IGNvbnRyb2wg YWN0aXZlCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9Nb2R1bGVzL2luZGV4ZWRkYi9JREJD dXJzb3JCYWNrZW5kSW1wbC5oIGIvU291cmNlL1dlYkNvcmUvTW9kdWxlcy9pbmRleGVkZGIvSURC Q3Vyc29yQmFja2VuZEltcGwuaAppbmRleCAxZjc0YzMzLi5iOGI3N2VjIDEwMDY0NAotLS0gYS9T b3VyY2UvV2ViQ29yZS9Nb2R1bGVzL2luZGV4ZWRkYi9JREJDdXJzb3JCYWNrZW5kSW1wbC5oCisr KyBiL1NvdXJjZS9XZWJDb3JlL01vZHVsZXMvaW5kZXhlZGRiL0lEQkN1cnNvckJhY2tlbmRJbXBs LmgKQEAgLTYzLDcgKzYzLDcgQEAgcHVibGljOgogICAgIHZpcnR1YWwgdm9pZCBkZWxldGVGdW5j dGlvbihQYXNzUmVmUHRyPElEQkNhbGxiYWNrcz4sIEV4Y2VwdGlvbkNvZGUmKTsKICAgICB2aXJ0 dWFsIHZvaWQgcHJlZmV0Y2hDb250aW51ZShpbnQgbnVtYmVyVG9GZXRjaCwgUGFzc1JlZlB0cjxJ REJDYWxsYmFja3M+LCBFeGNlcHRpb25Db2RlJik7CiAgICAgdmlydHVhbCB2b2lkIHByZWZldGNo UmVzZXQoaW50IHVzZWRQcmVmZXRjaGVzLCBpbnQgdW51c2VkUHJlZmV0Y2hlcyk7Ci0gICAgdmly dHVhbCB2b2lkIHBvc3RTdWNjZXNzSGFuZGxlckNhbGxiYWNrKCkgeyBBU1NFUlRfTk9UX1JFQUNI RUQoKTsgfQorICAgIHZpcnR1YWwgdm9pZCBwb3N0U3VjY2Vzc0hhbmRsZXJDYWxsYmFjaygpIHsg fQogCiAgICAgUGFzc1JlZlB0cjxJREJLZXk+IGtleSgpIGNvbnN0IHsgcmV0dXJuIG1fY3Vyc29y LT5rZXkoKTsgfQogICAgIFBhc3NSZWZQdHI8SURCS2V5PiBwcmltYXJ5S2V5KCkgY29uc3QgeyBy ZXR1cm4gbV9jdXJzb3ItPnByaW1hcnlLZXkoKTsgfQotLSAKMS43LjkuNQoK