103385 2012-11-27 02:50:30 -0800 Fix world-reuse test for mac build 2012-11-27 09:59:52 -0800 1 1 1 Unclassified WebKit New Bugs 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 0 dcarney webkit-unassigned jochen webkit.review.bot oldest_to_newest 776547 0 dcarney 2012-11-27 02:50:30 -0800 Fix world-reuse test for mac build 776551 1 176217 dcarney 2012-11-27 02:53:02 -0800 Created attachment 176217 Patch 776552 2 jochen 2012-11-27 02:57:17 -0800 you probably also need to remove the wrong test expectations for jsc ports? 776554 3 dcarney 2012-11-27 03:00:01 -0800 (In reply to comment #2) > you probably also need to remove the wrong test expectations for jsc ports? they weren't added, so this just makes the expectations work for all ports. 776557 4 176217 jochen 2012-11-27 03:09:15 -0800 Comment on attachment 176217 Patch ok 776845 5 176217 abarth 2012-11-27 09:21:12 -0800 Comment on attachment 176217 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=176217&action=review We can land this patch to make the test pass, but we really should make the test harness behave the same way across ports do we don't run into this issue again. > LayoutTests/ChangeLog:9 > + Mac and chrome builds have different expectations for where > + an isolated world is executed. We should change the test harness to work the same way. 776904 6 176217 webkit.review.bot 2012-11-27 09:59:49 -0800 Comment on attachment 176217 Patch Clearing flags on attachment: 176217 Committed r135871: <http://trac.webkit.org/changeset/135871> 776905 7 webkit.review.bot 2012-11-27 09:59:52 -0800 All reviewed patches have been landed. Closing bug. 176217 2012-11-27 02:53:02 -0800 2012-11-27 09:59:49 -0800 Patch bug-103385-20121127115039.patch text/plain 1746 dcarney U3VidmVyc2lvbiBSZXZpc2lvbjogMTM1ODMxCmRpZmYgLS1naXQgYS9MYXlvdXRUZXN0cy9DaGFu Z2VMb2cgYi9MYXlvdXRUZXN0cy9DaGFuZ2VMb2cKaW5kZXggYzY3NTVkNGFhNzhkM2ExYWY3ZjE2 MDk1Njk1MWM0ODI4YzMwNGEyMy4uOThhM2Y2MzhkZTI4Y2MwOWUwMzEyNGQzM2QxMTQ1NzcwYjQx NzkxNCAxMDA2NDQKLS0tIGEvTGF5b3V0VGVzdHMvQ2hhbmdlTG9nCisrKyBiL0xheW91dFRlc3Rz L0NoYW5nZUxvZwpAQCAtMSwzICsxLDE1IEBACisyMDEyLTExLTI3ICBEYW4gQ2FybmV5ICA8ZGNh cm5leUBnb29nbGUuY29tPgorCisgICAgICAgIEZpeCB3b3JsZC1yZXVzZSB0ZXN0IGZvciBtYWMg YnVpbGQKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTEw MzM4NQorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIE1h YyBhbmQgY2hyb21lIGJ1aWxkcyBoYXZlIGRpZmZlcmVudCBleHBlY3RhdGlvbnMgZm9yIHdoZXJl CisgICAgICAgIGFuIGlzb2xhdGVkIHdvcmxkIGlzIGV4ZWN1dGVkLiAKKworICAgICAgICAqIGh0 dHAvdGVzdHMvc2VjdXJpdHkvaXNvbGF0ZWRXb3JsZC93b3JsZC1yZXVzZS5odG1sOgorCiAyMDEy LTExLTI3ICBaYW4gRG9iZXJzZWsgIDx6YW5kb2JlcnNla0BnbWFpbC5jb20+CiAKICAgICAgICAg VW5yZXZpZXdlZCBHVEsgZ2FyZGVuaW5nLgpkaWZmIC0tZ2l0IGEvTGF5b3V0VGVzdHMvaHR0cC90 ZXN0cy9zZWN1cml0eS9pc29sYXRlZFdvcmxkL3dvcmxkLXJldXNlLmh0bWwgYi9MYXlvdXRUZXN0 cy9odHRwL3Rlc3RzL3NlY3VyaXR5L2lzb2xhdGVkV29ybGQvd29ybGQtcmV1c2UuaHRtbAppbmRl eCA3YTM5Y2MwMzY5ZDMwOWJkODUyYWZjNjU4YmJiZjQ5ZDg4YThkNzliLi5iODM3YTJiNWNkN2Nh ZGZiYTRkNjgyMTJjMWYwYWIxODdlZWIwYTIxIDEwMDY0NAotLS0gYS9MYXlvdXRUZXN0cy9odHRw L3Rlc3RzL3NlY3VyaXR5L2lzb2xhdGVkV29ybGQvd29ybGQtcmV1c2UuaHRtbAorKysgYi9MYXlv dXRUZXN0cy9odHRwL3Rlc3RzL3NlY3VyaXR5L2lzb2xhdGVkV29ybGQvd29ybGQtcmV1c2UuaHRt bApAQCAtMzMsNyArMzMsNyBAQCBpZiAod2luZG93LnRlc3RSdW5uZXIpIHsKIAogICAgIC8vIElz b2xhdGVkIHdvcmxkIGV4ZWN1dGluZyBpbiBmcmFtZSBzaG91bGQgYmUgYWJsZSB0byB0byBhY2Nl c3MgcGFyZW50IGNvbnRlbnQuCiAgICAgdGVzdFJ1bm5lci5ldmFsdWF0ZVNjcmlwdEluSXNvbGF0 ZWRXb3JsZCgxLAotICAgICAgInBhcmVudC5kb2N1bWVudC5ib2R5LmFwcGVuZENoaWxkKHBhcmVu dC5kb2N1bWVudC5jcmVhdGVUZXh0Tm9kZSgnRXhwZWN0aW5nIHRydWU6ICcgKyAocGFyZW50LmZy YW1lc1swXS5kb2N1bWVudCA9PSB0aGlzLmRvY3VtZW50KSkpOyIgKworICAgICAgInBhcmVudC5k b2N1bWVudC5ib2R5LmFwcGVuZENoaWxkKHBhcmVudC5kb2N1bWVudC5jcmVhdGVUZXh0Tm9kZSgn RXhwZWN0aW5nIHRydWU6ICcgKyAhIXBhcmVudC5mcmFtZXNbMF0uZG9jdW1lbnQuZ2V0RWxlbWVu dEJ5SWQoJ291dHB1dCcpKSk7IiArCiAgICAgICAicGFyZW50LmRvY3VtZW50LmJvZHkuYXBwZW5k Q2hpbGQocGFyZW50LmRvY3VtZW50LmNyZWF0ZUVsZW1lbnQoJ2JyJykpOyIpOwogCiAgICAgZG9j dW1lbnQuYm9keS5hcHBlbmRDaGlsZChkb2N1bWVudC5jcmVhdGVUZXh0Tm9kZSgnRXhwZWN0aW5n IHVuZGVmaW5lZCx1bmRlZmluZWQ6ICcgKyByZXN1bHQpKTsK