103261 2012-11-26 08:32:52 -0800 REGRESSION(134887) [Qt][EFL][WK2] Repaint counter not working 2012-11-29 00:17:08 -0800 1 1 1 Unclassified WebKit WebKit2 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 103105 1 kenneth kenneth jesus laszlo.gombos lucas.de.marchi noam ostap73 tmpsantos zeno oldest_to_newest 775503 0 kenneth 2012-11-26 08:32:52 -0800 when running with [QT_]WEBKIT_SHOW_COMPOSITING_DEBUG_VISUALS=1 a repaint counter is shown. This shown 1, then next time 10, then next time 100, etc... This is because it cannot reuse texture between 1 and 10 and 100 and 1000, etc. The following fixes it, but something must be wrong with the texture pool, or elsewhere. --- a/Source/WebCore/platform/graphics/texmap/TextureMapperGL.cpp +++ b/Source/WebCore/platform/graphics/texmap/TextureMapperGL.cpp @@ -376,7 +376,8 @@ void TextureMapperGL::drawRepaintCounter(int value, int pointSize, const FloatPo IntRect sourceRect(IntPoint::zero(), size); IntRect targetRect(roundedIntPoint(targetPoint), size); - RefPtr<BitmapTexture> texture = acquireTextureFromPool(size); + RefPtr<BitmapTexture> texture = createTexture(); + texture->reset(size); 775596 1 kenneth 2012-11-26 10:03:00 -0800 wrong bug :/ 776487 2 noam 2012-11-27 01:47:43 -0800 MY guess is that it's not about reusing texture 2-9, but rather that it thinks it only works once the required texture changes size, which is what naturally happens when the counter goes from 9 to 10. 776524 3 176209 kenneth 2012-11-27 02:24:51 -0800 Created attachment 176209 Patch 776529 4 kenneth 2012-11-27 02:28:53 -0800 Landed in 135839, reviewed on irc. 778755 5 176209 hausmann 2012-11-29 00:16:00 -0800 Comment on attachment 176209 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=176209&action=review > Source/WebCore/ChangeLog:12 > + This method obviosly needs to bind the texture. "obviosly" -> "obviously" ;-) 778756 6 176209 hausmann 2012-11-29 00:17:08 -0800 Comment on attachment 176209 Patch Ooops, clearing review, to make it disappear from the review queue. 176209 2012-11-27 02:24:51 -0800 2012-11-29 00:17:08 -0800 Patch bug-103261-20121127112227.patch text/plain 1825 kenneth U3VidmVyc2lvbiBSZXZpc2lvbjogMTM1ODM2CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggMTc4YzRiMzQ2ODQ3YjMy Mzk3ODI3MDRjMmNiYjk1NGE0YTY1NjExOS4uZjY4YjljZDdmYWUzMDJlMGUyMjlhYjMxYTNjNjE5 MTEwMTVmNzJkMSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE5IEBACisyMDEyLTExLTI3ICBLZW5u ZXRoIFJvaGRlIENocmlzdGlhbnNlbiAgPGtlbm5ldGhAd2Via2l0Lm9yZz4KKworICAgICAgICBS RUdSRVNTSU9OKDEzNDg4NykgW1F0XVtFRkxdW1dLMl0gUmVwYWludCBjb3VudGVyIG5vdCB3b3Jr aW5nCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xMDMy NjEKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBGaXhl ZCByZWdyZXNzaW9uIGludHJvZHVjZWQgaW4gMTM0ODg3LCB3aGljaCBpbnRyb2R1Y2VkIHRoZQor ICAgICAgICB1cGRhdGVDb250ZW50c05vU3dpenpsZSBtZXRob2QgYW5kIGNhbGxlZCBpdCBkaXJl Y3RseSBmcm9tCisgICAgICAgIHRoZSByZXBhaW50IGNvdW50ZXIuCisKKyAgICAgICAgVGhpcyBt ZXRob2Qgb2J2aW9zbHkgbmVlZHMgdG8gYmluZCB0aGUgdGV4dHVyZS4KKworICAgICAgICAqIHBs YXRmb3JtL2dyYXBoaWNzL3RleG1hcC9UZXh0dXJlTWFwcGVyR0wuY3BwOgorICAgICAgICAoV2Vi Q29yZTo6Qml0bWFwVGV4dHVyZUdMOjp1cGRhdGVDb250ZW50c05vU3dpenpsZSk6CisKIDIwMTIt MTEtMjcgIEtlbnQgVGFtdXJhICA8dGtlbnRAY2hyb21pdW0ub3JnPgogCiAgICAgICAgIEltcGxl bWVudCBWYWxpZGl0eVN0YXRlOjpiYWRJbnB1dApkaWZmIC0tZ2l0IGEvU291cmNlL1dlYkNvcmUv cGxhdGZvcm0vZ3JhcGhpY3MvdGV4bWFwL1RleHR1cmVNYXBwZXJHTC5jcHAgYi9Tb3VyY2UvV2Vi Q29yZS9wbGF0Zm9ybS9ncmFwaGljcy90ZXhtYXAvVGV4dHVyZU1hcHBlckdMLmNwcAppbmRleCBk MDJhODk4NDlhNzY5MTIzNjUwODliOTliZGVkMjBhY2Y3NTJkZDA4Li5jZWZjMmI1ZmNmNjljMThi MjYyYTg3NDljZDRhZjJmYWRkZTEyOGEyIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9wbGF0 Zm9ybS9ncmFwaGljcy90ZXhtYXAvVGV4dHVyZU1hcHBlckdMLmNwcAorKysgYi9Tb3VyY2UvV2Vi Q29yZS9wbGF0Zm9ybS9ncmFwaGljcy90ZXhtYXAvVGV4dHVyZU1hcHBlckdMLmNwcApAQCAtNjkx LDYgKzY5MSw3IEBAIHZvaWQgQml0bWFwVGV4dHVyZUdMOjpkaWRSZXNldCgpCiAKIHZvaWQgQml0 bWFwVGV4dHVyZUdMOjp1cGRhdGVDb250ZW50c05vU3dpenpsZShjb25zdCB2b2lkKiBzcmNEYXRh LCBjb25zdCBJbnRSZWN0JiB0YXJnZXRSZWN0LCBjb25zdCBJbnRQb2ludCYgc291cmNlT2Zmc2V0 LCBpbnQgYnl0ZXNQZXJMaW5lLCB1bnNpZ25lZCBieXRlc1BlclBpeGVsLCBQbGF0Zm9ybTNET2Jq ZWN0IGdsRm9ybWF0KQogeworICAgIG1fY29udGV4dDNELT5iaW5kVGV4dHVyZShHcmFwaGljc0Nv bnRleHQzRDo6VEVYVFVSRV8yRCwgbV9pZCk7CiAjaWYgIWRlZmluZWQoVEVYTUFQX09QRU5HTF9F U18yKQogICAgIGlmIChkcml2ZXJTdXBwb3J0c1N1YkltYWdlKCkpIHsgLy8gRm9yIEVTIGRyaXZl cnMgdGhhdCBkb24ndCBzdXBwb3J0IHN1Yi1pbWFnZXMuCiAgICAgICAgIC8vIFVzZSB0aGUgT3Bl bkdMIHN1Yi1pbWFnZSBleHRlbnNpb24sIG5vdyB0aGF0IHdlIGtub3cgaXQncyBhdmFpbGFibGUu Cg==