103209 2012-11-25 16:41:37 -0800 [EFL] [GTK] Build break with glib >= 2.35.0 2013-01-11 06:59:39 -0800 1 1 1 Unclassified WebKit WebKit2 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 104528 0 szukw000 jussi.kukkonen gyuyoung.kim jussi.kukkonen laszlo.gombos mrobinson rakuco webkit.review.bot oldest_to_newest 775049 0 szukw000 2012-11-25 16:41:37 -0800 see patch winfried 775052 1 175896 szukw000 2012-11-25 16:48:23 -0800 Created attachment 175896 deprecated function triggered compilation stop 784386 2 laszlo.gombos 2012-12-05 17:59:16 -0800 I do not see this problem. I am using Ubuntu 12.04. Can you share a bit more about your environment ? Also a few pointers for you: - building EFL Webkit - http://trac.webkit.org/wiki/EFLWebKit (note the update-webkitefl-libs part) - contributing to WebKit (format of the patches, ChangeLog, etc) - http://www.webkit.org/coding/contributing.html 784387 3 laszlo.gombos 2012-12-05 18:00:09 -0800 Which version of glib are you using ? 786171 4 laszlo.gombos 2012-12-07 14:35:50 -0800 It seems that g_type_init() is deprecated for glib >= 2.35.0 786263 5 szukw000 2012-12-07 16:02:37 -0800 glib-2.35.2.tar.xz atk-2.7.2.tar.xz gdk-pixbuf-2.26.5.tar.xz gtk+-3.4.4.tar.xz pango-1.32.3.tar.xz Normally 'deprecated' should not stop the compilation. But here it did. winfried 788150 6 mrobinson 2012-12-11 01:10:16 -0800 You can control this error with GLIB_VERSION_MIN_REQUIRED. 788382 7 jussi.kukkonen 2012-12-11 06:14:24 -0800 I don't understand how the build breaks because of this, but I guess we'll want to add a version check anyway -- the first patch doesn't work since calling g_type_init() is still required for earlier glib versions. EFL does not seem to have GtkVersioning.h type of file so I'll just add a #if to each call location... let me know if there's a good place to add a version dependent "#define g_type_init()": that would be cleaner. 788384 8 178792 jussi.kukkonen 2012-12-11 06:18:22 -0800 Created attachment 178792 Patch 788388 9 178792 kenneth 2012-12-11 06:22:27 -0800 Comment on attachment 178792 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=178792&action=review > Source/WebKit/efl/ChangeLog:9 > + g_type_init() is deprecated from 2.35.0 onwards. Don't call it > + in that case to avoid warnings and/or build failure. and it has no replacement? 788393 10 178792 mrobinson 2012-12-11 06:38:48 -0800 Comment on attachment 178792 Patch One thing you can do instead is to add -DGLIB_VERSION_MIN_REQUIRED=GLIB_VERSION_2_32 to the compilation flags and it will disable all deprecation warnings for versions of GLib after that version. 788435 11 jussi.kukkonen 2012-12-11 07:22:50 -0800 (In reply to comment #9) > (From update of attachment 178792 [details]) > View in context: https://bugs.webkit.org/attachment.cgi?id=178792&action=review > > > Source/WebKit/efl/ChangeLog:9 > > + g_type_init() is deprecated from 2.35.0 onwards. Don't call it > > + in that case to avoid warnings and/or build failure. > > and it has no replacement? No: Earlier calling g_type_init() it was required. 2.35 and after it is not needed at all. (In reply to comment #10) > (From update of attachment 178792 [details]) > One thing you can do instead is to add -DGLIB_VERSION_MIN_REQUIRED=GLIB_VERSION_2_32 to the compilation flags and it will disable all deprecation warnings for versions of GLib after that version. Sure, if we know we don't want to see the warnings: Hiding them can lead to surprises later on when functionality is really removed or changed. I guess that's not a very big problem with glib though... Either way works for me. 789352 12 jussi.kukkonen 2012-12-12 02:00:55 -0800 (In reply to comment #7) > I don't understand how the build breaks because of this... I tested and we do indeed fail on warnings, so must have at least 'Werror=deprecated-declarations'. Personally I wouldn't do that normally, but since we mainly support jhbuild-based building, it kind of makes sense: a developer who checks things out and follows directions should not normally end up with a broken build. So assuming we want to preserve 'deprecated-declarations' build errors, I think we should go with my patch. 790530 13 178792 jussi.kukkonen 2012-12-13 05:38:25 -0800 Comment on attachment 178792 Patch No-one's complained so I'll set cq? -- patch still applies cleanly. 790545 14 178792 webkit.review.bot 2012-12-13 06:22:50 -0800 Comment on attachment 178792 Patch Clearing flags on attachment: 178792 Committed r137588: <http://trac.webkit.org/changeset/137588> 790546 15 webkit.review.bot 2012-12-13 06:22:55 -0800 All reviewed patches have been landed. Closing bug. 175896 2012-11-25 16:48:23 -0800 2012-12-11 06:18:17 -0800 deprecated function triggered compilation stop webkit-efl.dif.gz text/plain 510 szukw000 H4sICGu+slAAA3dlYmtpdC1lZmwuZGlmALWSXW/aMBSGr5dfccZukoZ82CQhCTeAllWolKHSjsso BEMtTBw5Rlk17b/XAVpW1Eprtb0XiXPs4/eck8eyLJgnw6vRrTP7MXFqsthQaWEXYQshC/vOjO9E Tpw5WVxRiZ270VTwnFSVM5iOHLJiDqk36TajhZ2Xpc0FXX96zg7ARbHXjRG2O52oGwZYhUwXua5m muY/9D23jGI3sCMUdCPPw/7Rst8HK/TaEZj7Z7+vwZPWXHIgQnCRkpwLkv7sHTZ/a/CFFEu60izN 2p9M5UNJUlpQqRs9FTWdC+tM8JWUguSZJMsYVOtB/DINaAUFr2HJCwLZTvJtJmmeMfagmcd6XriA Zp5bvEsXzqEZugL986G/ZnAp47xM14wulJEka6EK1g0Dfp3mMh/cTPRW0qRAnTVVS8j5tqSMLKGm 8h4ux3QB1a4suZBtqPiWQMl2a1pUap+xfUbrdGGjVs3FBnRKYhgs+YLAN5ZV90arGec7aVTvJywa JE6f16q/ZMXeYtL3YozswItC5Icd/4NM/o37ubEfY8/2Qz/Erou7f5IZtUNFZtRG7h7NI3agVuq/ JZPBcJzol+PRMJ3dTaffb26N19B7U5r5cShfQbIB/78ReMJFELkTBaDe8zweAdVP9zSwBAAA 178792 2012-12-11 06:18:22 -0800 2012-12-13 06:22:50 -0800 Patch bug-103209-20121211161543.patch text/plain 5535 jussi.kukkonen U3VidmVyc2lvbiBSZXZpc2lvbjogMTM3Mjk1CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0L2Vm bC9DaGFuZ2VMb2cgYi9Tb3VyY2UvV2ViS2l0L2VmbC9DaGFuZ2VMb2cKaW5kZXggMDNjY2FkZDJl NTJlZDdkMWY4MzcwZjk2NzczYWFkZWQ3YzdmOWM0Yi4uZmJkMTEyMDVhYWQzOGUwMjZkMzFjZTJk ZDY4ZmViZDQzZDdmZDZhMSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYktpdC9lZmwvQ2hhbmdlTG9n CisrKyBiL1NvdXJjZS9XZWJLaXQvZWZsL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE2IEBACisyMDEy LTEyLTExICBKdXNzaSBLdWtrb25lbiAgPGp1c3NpLmt1a2tvbmVuQGludGVsLmNvbT4KKworICAg ICAgICBbRUZMXVtHVEtdIERvbid0IGNhbGwgZGVwcmVjYXRlZCBnX3R5cGVfaW5pdCB3aGVuIGds aWIgPT4gMi4zNQorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/ aWQ9MTAzMjA5CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAg ICAgZ190eXBlX2luaXQoKSBpcyBkZXByZWNhdGVkIGZyb20gMi4zNS4wIG9ud2FyZHMuIERvbid0 IGNhbGwgaXQKKyAgICAgICAgaW4gdGhhdCBjYXNlIHRvIGF2b2lkIHdhcm5pbmdzIGFuZC9vciBi dWlsZCBmYWlsdXJlLgorCisgICAgICAgICogZXdrL2V3a19tYWluLmNwcDoKKyAgICAgICAgKF9l d2tfaW5pdF9ib2R5KToKKwogMjAxMi0xMi0wNSAgSGFsdG9uIEh1byAgPGhhbHRvbi5odW9AaW50 ZWwuY29tPgogCiAgICAgICAgIFtDTWFrZV0gVW5pZnkgY29kaW5nIHN0eWxlIGZvciBDTWFrZSBm aWxlcwpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYktpdDIvQ2hhbmdlTG9nIGIvU291cmNlL1dlYktp dDIvQ2hhbmdlTG9nCmluZGV4IDc3OGFlNDViZjdkODFhOGNkOThhNGU5ZDc2ZDRhMDI2MWIxNmM2 OWUuLjE0M2VhMjA1OWJhYjgwM2MzMGY0Njc1MDRkN2QxOTgyMTBjMmNiMGUgMTAwNjQ0Ci0tLSBh L1NvdXJjZS9XZWJLaXQyL0NoYW5nZUxvZworKysgYi9Tb3VyY2UvV2ViS2l0Mi9DaGFuZ2VMb2cK QEAgLTEsMyArMSwyMyBAQAorMjAxMi0xMi0xMSAgSnVzc2kgS3Vra29uZW4gIDxqdXNzaS5rdWtr b25lbkBpbnRlbC5jb20+CisKKyAgICAgICAgW0VGTF1bR1RLXSBEb24ndCBjYWxsIGRlcHJlY2F0 ZWQgZ190eXBlX2luaXQgd2hlbiBnbGliID0+IDIuMzUKKyAgICAgICAgaHR0cHM6Ly9idWdzLndl YmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTEwMzIwOQorCisgICAgICAgIFJldmlld2VkIGJ5IE5P Qk9EWSAoT09QUyEpLgorCisgICAgICAgIGdfdHlwZV9pbml0KCkgaXMgZGVwcmVjYXRlZCBmcm9t IDIuMzUuMCBvbndhcmRzLiBEb24ndCBjYWxsIGl0CisgICAgICAgIGluIHRoYXQgY2FzZSB0byBh dm9pZCB3YXJuaW5ncyBhbmQvb3IgYnVpbGQgZmFpbHVyZS4KKworICAgICAgICBBbHNvLCByZW1v dmUgYSBjYWxsIHRvIGdfdHlwZV9pbml0KCkgZnJvbSBXZWJQcm9jZXNzTWFpbkd0aygpOgorICAg ICAgICBJdCBpcyBub3QgbmVlZGVkIGlmIGd0a19pbml0KCkgaXMgY2FsbGVkLgorCisgICAgICAg ICogVUlQcm9jZXNzL0FQSS9lZmwvZXdrX21haW4uY3BwOgorICAgICAgICAoZXdrX2luaXQpOgor ICAgICAgICAqIFdlYlByb2Nlc3MvZWZsL1dlYlByb2Nlc3NNYWluRWZsLmNwcDoKKyAgICAgICAg KFdlYktpdDo6V2ViUHJvY2Vzc01haW5FZmwpOgorICAgICAgICAqIFdlYlByb2Nlc3MvZ3RrL1dl YlByb2Nlc3NNYWluR3RrLmNwcDoKKyAgICAgICAgKFdlYktpdDo6V2ViUHJvY2Vzc01haW5HdGsp OgorCiAyMDEyLTEyLTExICBDaHJpc3RvcGhlIER1bWV6ICA8Y2hyaXN0b3BoZS5kdW1lekBpbnRl bC5jb20+CiAKICAgICAgICAgW0Nvb3JkaW5hdGVkR3JhcGhpY3NdIFVzZSB1bnNpZ25lZCBpbnRl Z2VycyBmb3IgVXBkYXRlQXRsYXMgSURzCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0L2VmbC9l d2svZXdrX21haW4uY3BwIGIvU291cmNlL1dlYktpdC9lZmwvZXdrL2V3a19tYWluLmNwcAppbmRl eCBjOWE3NjA5MzY2MTlmMjY4Yjc2ZGVmZWFiNWY1ZGI1ZGY4NWFmYTM3Li4xMjM1MjViM2JmZGYy MzQzZTUwYWJlMzg2ZWM0M2E0NjUzMzBmMmMxIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViS2l0L2Vm bC9ld2svZXdrX21haW4uY3BwCisrKyBiL1NvdXJjZS9XZWJLaXQvZWZsL2V3ay9ld2tfbWFpbi5j cHAKQEAgLTE1OSw4ICsxNTksOSBAQCBzdGF0aWMgV2ViQ29yZTo6U3RvcmFnZVRyYWNrZXJDbGll bnRFZmwqIHRyYWNrZXJDbGllbnQoKQogCiBFaW5hX0Jvb2wgX2V3a19pbml0X2JvZHkodm9pZCkK IHsKLQorI2lmICFHTElCX0NIRUNLX1ZFUlNJT04oMiwgMzUsIDApCiAgICAgZ190eXBlX2luaXQo KTsKKyNlbmRpZgogCiAgICAgaWYgKCFlY29yZV9tYWluX2xvb3BfZ2xpYl9pbnRlZ3JhdGUoKSkK ICAgICAgICAgV0FSTigiRWNvcmUgd2FzIG5vdCBjb21waWxlZCB3aXRoIEdMaWIgc3VwcG9ydCwg c29tZSBwbHVnaW5zIHdpbGwgbm90ICIKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJLaXQyL1VJUHJv Y2Vzcy9BUEkvZWZsL2V3a19tYWluLmNwcCBiL1NvdXJjZS9XZWJLaXQyL1VJUHJvY2Vzcy9BUEkv ZWZsL2V3a19tYWluLmNwcAppbmRleCA4OTBiYzY5OWFlYzkzOTJmY2ViOTFmMzFjYTY0M2Y5MWFl ZjMzZDRiLi4yYjIxODlkYzU3ODRmZDk5MmY4YmU2ZTExNTNjN2IyNzdjZWQ5OTVmIDEwMDY0NAot LS0gYS9Tb3VyY2UvV2ViS2l0Mi9VSVByb2Nlc3MvQVBJL2VmbC9ld2tfbWFpbi5jcHAKKysrIGIv U291cmNlL1dlYktpdDIvVUlQcm9jZXNzL0FQSS9lZmwvZXdrX21haW4uY3BwCkBAIC04NSw3ICs4 NSw5IEBAIGludCBld2tfaW5pdCh2b2lkKQogICAgIH0KICNlbmRpZgogCisjaWYgIUdMSUJfQ0hF Q0tfVkVSU0lPTigyLCAzNSwgMCkKICAgICBnX3R5cGVfaW5pdCgpOworI2VuZGlmCiAKICAgICBp ZiAoIWVjb3JlX21haW5fbG9vcF9nbGliX2ludGVncmF0ZSgpKSB7CiAgICAgICAgIFdBUk4oIkVj b3JlIHdhcyBub3QgY29tcGlsZWQgd2l0aCBHTGliIHN1cHBvcnQsIHNvbWUgcGx1Z2lucyB3aWxs IG5vdCAiCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0Mi9XZWJQcm9jZXNzL2VmbC9XZWJQcm9j ZXNzTWFpbkVmbC5jcHAgYi9Tb3VyY2UvV2ViS2l0Mi9XZWJQcm9jZXNzL2VmbC9XZWJQcm9jZXNz TWFpbkVmbC5jcHAKaW5kZXggZWNmMTAzZDM2YjQ5NDA4OWU1MzU2MzllYzVjOWZmOTE0MjE0Nzg3 MC4uMDBmNjBkOGYzN2QyYjQ5MDYzNzRkYTJlNDM0MmQ5M2UzOWNiODIzNSAxMDA2NDQKLS0tIGEv U291cmNlL1dlYktpdDIvV2ViUHJvY2Vzcy9lZmwvV2ViUHJvY2Vzc01haW5FZmwuY3BwCisrKyBi L1NvdXJjZS9XZWJLaXQyL1dlYlByb2Nlc3MvZWZsL1dlYlByb2Nlc3NNYWluRWZsLmNwcApAQCAt ODgsNyArODgsOSBAQCBXS19FWFBPUlQgaW50IFdlYlByb2Nlc3NNYWluRWZsKGludCBhcmdjLCBj aGFyKiBhcmd2W10pCiAgICAgfQogI2VuZGlmCiAKKyNpZiAhR0xJQl9DSEVDS19WRVJTSU9OKDIs IDM1LCAwKQogICAgIGdfdHlwZV9pbml0KCk7CisjZW5kaWYKIAogICAgIGlmICghZWNvcmVfbWFp bl9sb29wX2dsaWJfaW50ZWdyYXRlKCkpCiAgICAgICAgIHJldHVybiAxOwpkaWZmIC0tZ2l0IGEv U291cmNlL1dlYktpdDIvV2ViUHJvY2Vzcy9ndGsvV2ViUHJvY2Vzc01haW5HdGsuY3BwIGIvU291 cmNlL1dlYktpdDIvV2ViUHJvY2Vzcy9ndGsvV2ViUHJvY2Vzc01haW5HdGsuY3BwCmluZGV4IGYx N2FjNmNlZWZkNDFkOGI2YWM1N2E0YjcwMGI0ZGJjMjlmMDI4YzMuLjUwNzIzYzVjZTU1ZGU4MTY0 NDRhYTAwOGNlNmNjNDlmMGE3ZjgyOWMgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQyL1dlYlBy b2Nlc3MvZ3RrL1dlYlByb2Nlc3NNYWluR3RrLmNwcAorKysgYi9Tb3VyY2UvV2ViS2l0Mi9XZWJQ cm9jZXNzL2d0ay9XZWJQcm9jZXNzTWFpbkd0ay5jcHAKQEAgLTU1LDcgKzU1LDYgQEAgV0tfRVhQ T1JUIGludCBXZWJQcm9jZXNzTWFpbkd0ayhpbnQgYXJnYywgY2hhciogYXJndltdKQogI2VuZGlm CiAKICAgICBndGtfaW5pdCgmYXJnYywgJmFyZ3YpOwotICAgIGdfdHlwZV9pbml0KCk7CiAKICAg ICBKU0M6OmluaXRpYWxpemVUaHJlYWRpbmcoKTsKICAgICBXVEY6OmluaXRpYWxpemVNYWluVGhy ZWFkKCk7CmRpZmYgLS1naXQgYS9Ub29scy9DaGFuZ2VMb2cgYi9Ub29scy9DaGFuZ2VMb2cKaW5k ZXggMDUzMzExNDA2YTVmODYyMGIxYzA0M2Q1Njc3NWY3NmZjNzljZmE1ZC4uODhlMDBjMjcwZjdm OWU4YzM1NGFlOTNlM2I4YmUyMDUyZjVkMTdmMSAxMDA2NDQKLS0tIGEvVG9vbHMvQ2hhbmdlTG9n CisrKyBiL1Rvb2xzL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE2IEBACisyMDEyLTEyLTExICBKdXNz aSBLdWtrb25lbiAgPGp1c3NpLmt1a2tvbmVuQGludGVsLmNvbT4KKworICAgICAgICBbRUZMXVtH VEtdIERvbid0IGNhbGwgZGVwcmVjYXRlZCBnX3R5cGVfaW5pdCB3aGVuIGdsaWIgPT4gMi4zNQor ICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTAzMjA5CisK KyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgZ190eXBlX2lu aXQoKSBpcyBkZXByZWNhdGVkIGZyb20gMi4zNS4wIG9ud2FyZHMuIERvbid0IGNhbGwgaXQKKyAg ICAgICAgaW4gdGhhdCBjYXNlIHRvIGF2b2lkIHdhcm5pbmdzIGFuZC9vciBidWlsZCBmYWlsdXJl LgorCisgICAgICAgICogRHVtcFJlbmRlclRyZWUvZ3RrL0ltYWdlRGlmZi5jcHA6CisgICAgICAg IChtYWluKToKKwogMjAxMi0xMi0xMSAgTWFydGluIFJvYmluc29uICA8bXJvYmluc29uQGlnYWxp YS5jb20+CiAKICAgICAgICAgW0dUS10gQnVtcCB0aGUgamhidWlsZCBsaWJzb3VwIHZlcnNpb24g dG8gZml4IGFuIGF1dGhlbnRpY2F0aW9uIGlzc3VlCmRpZmYgLS1naXQgYS9Ub29scy9EdW1wUmVu ZGVyVHJlZS9ndGsvSW1hZ2VEaWZmLmNwcCBiL1Rvb2xzL0R1bXBSZW5kZXJUcmVlL2d0ay9JbWFn ZURpZmYuY3BwCmluZGV4IGU0MGMzM2FjZjhmZWQ0Nzc4ZTkwZmVjOWM2YzlmYjFmZjI0MGRhMmQu LmY2ZjY4MGFhM2I1ZDNkZGM4YzBhNjVjNTA0NDhmNWIyNGJjNzAzNzUgMTAwNjQ0Ci0tLSBhL1Rv b2xzL0R1bXBSZW5kZXJUcmVlL2d0ay9JbWFnZURpZmYuY3BwCisrKyBiL1Rvb2xzL0R1bXBSZW5k ZXJUcmVlL2d0ay9JbWFnZURpZmYuY3BwCkBAIC0xNzgsNyArMTc4LDkgQEAgdm9pZCBwcmludElt YWdlRGlmZmVyZW5jZXMoR2RrUGl4YnVmKiBiYXNlbGluZUltYWdlLCBHZGtQaXhidWYqIGFjdHVh bEltYWdlKQogCiBpbnQgbWFpbihpbnQgYXJnYywgY2hhciogYXJndltdKQogeworI2lmICFHTElC X0NIRUNLX1ZFUlNJT04oMiwgMzUsIDApCiAgICAgZ190eXBlX2luaXQoKTsKKyNlbmRpZgogCiAg ICAgR0Vycm9yKiBlcnJvciA9IDA7CiAgICAgR09wdGlvbkNvbnRleHQqIGNvbnRleHQgPSBnX29w dGlvbl9jb250ZXh0X25ldygiLSBjb21wYXJlIHR3byBpbWFnZSBmaWxlcywgcHJpbnRpbmcgdGhl aXIgcGVyY2VudGFnZSBkaWZmZXJlbmNlIGFuZCB0aGUgZGlmZmVyZW5jZSBpbWFnZSB0byBzdGRv dXQiKTsK